Page MenuHomeFreeBSD

qlxge(4): Distribute RSS over num_rx_rings with a modulo
Needs ReviewPublic

Authored by nick_spun.io on May 26 2026, 5:02 PM.
Referenced Files
F170971014: D57253.id178645.diff
Mon, Sep 7, 10:42 PM
F170935767: D57253.id178638.diff
Mon, Sep 7, 5:27 PM
F170906487: D57253.id178642.diff
Mon, Sep 7, 11:54 AM
Unknown Object (File)
Sun, Sep 6, 5:33 PM
Unknown Object (File)
Thu, Sep 3, 7:35 PM
Unknown Object (File)
Sun, Aug 30, 12:27 AM
Unknown Object (File)
Fri, Aug 21, 10:55 AM
Unknown Object (File)
Thu, Aug 20, 3:23 PM
Subscribers

Details

Reviewers
adrian
Summary

qls_init_rss() built the RSS indirection table with rss_icb->cq_id[i] = (i & (ha->num_rx_rings - 1)); which assumes num_rx_rings is a power of two. When it is not, the AND mask leaves some completion queues with no entries and skews the hash
distribution.

MAX_RX_RINGS is currently hardcoded to 1, so this is latent today, but use a modulo so the table stays correct if the ring count is ever raised to a non-power-of-two value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73455
Build 70338: arc lint + arc unit