Page MenuHomeFreeBSD

qlxge(4): Distribute RSS over num_rx_rings with a modulo
Needs ReviewPublic

Authored by nick_spun.io on May 26 2026, 5:02 PM.
Referenced Files
F162786628: D57253.id178642.diff
Thu, Jul 16, 9:27 PM
F162784576: D57253.id178645.diff
Thu, Jul 16, 8:55 PM
Unknown Object (File)
Thu, Jul 16, 7:33 AM
Unknown Object (File)
Thu, Jul 16, 4:51 AM
Unknown Object (File)
Thu, Jul 16, 3:33 AM
Unknown Object (File)
Wed, Jul 15, 7:05 PM
Unknown Object (File)
Tue, Jul 14, 11:01 PM
Unknown Object (File)
Sat, Jul 11, 10:02 PM
Subscribers

Details

Reviewers
adrian
Summary

qls_init_rss() built the RSS indirection table with rss_icb->cq_id[i] = (i & (ha->num_rx_rings - 1)); which assumes num_rx_rings is a power of two. When it is not, the AND mask leaves some completion queues with no entries and skews the hash
distribution.

MAX_RX_RINGS is currently hardcoded to 1, so this is latent today, but use a modulo so the table stays correct if the ring count is ever raised to a non-power-of-two value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73456
Build 70339: arc lint + arc unit