Differential D59839

vfs_register: prevent kernel crash
ClosedPublic
Actions

Authored by netchild on Sat, Sep 19, 10:20 AM.

Tags

None

Referenced Files

	F173085685: D59839.id187213.diff
	Wed, Sep 23, 11:45 AM

	F173054801: D59839.id187213.diff
	Wed, Sep 23, 5:22 AM

	Unknown Object (File)
	Mon, Sep 21, 11:22 AM

	Unknown Object (File)
	Mon, Sep 21, 12:12 AM

	Unknown Object (File)
	Sun, Sep 20, 7:28 PM

	Unknown Object (File)
	Sat, Sep 19, 12:06 PM

Subscribers

Details

Reviewers

kib
rmacklem
olce

Commits

rG3897678132e7: vfs_register: prevent kernel crash

Summary

vfs_register hashes the filesystem name and uses it for sysctl oids.
A filesystem name which hashes to 0 crashes in sysctl_register_oid().

Map 0 to 1 to prevent the kernel crash.

This can be tested with "udf2" as the filesystem name.

MFC after: 1 month
MFC to: stable/15 stable/14

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

netchild created this revision.Sat, Sep 19, 10:20 AM

Herald added subscribers: olce, imp. · View Herald TranscriptSat, Sep 19, 10:20 AM

netchild requested review of this revision.Sat, Sep 19, 10:20 AM

Harbormaster completed remote builds in B77087: Diff 187213.Sat, Sep 19, 10:20 AM

kib accepted this revision.Sat, Sep 19, 10:33 AM

This revision is now accepted and ready to land.Sat, Sep 19, 10:33 AM

Closed by commit rG3897678132e7: vfs_register: prevent kernel crash (authored by netchild). · Explain WhyWed, Sep 23, 12:48 PM

This revision was automatically updated to reflect the committed changes.

netchild added a commit: rG3897678132e7: vfs_register: prevent kernel crash.

Herald added a reviewer: olce. · View Herald TranscriptWed, Sep 23, 12:48 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

Diff 187499

sys/kern/vfs_init.c

Loading...