Page MenuHomeFreeBSD

callbootd: Add man page, update Makefile to install man page, and update usage().
Needs ReviewPublic

Authored by felix.the.red_gmail.com on Thu, Feb 6, 9:03 PM.
Tags
None
Referenced Files
F109974959: D48872.diff
Tue, Feb 11, 11:14 PM
Unknown Object (File)
Tue, Feb 11, 5:47 AM
Unknown Object (File)
Sun, Feb 9, 9:15 AM
Unknown Object (File)
Thu, Feb 6, 9:07 PM
Subscribers

Details

Reviewers
bdrewery
ngie
sjg
nyan
Group Reviewers
manpages
Summary

Create man page for callbootd.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 62367
Build 59251: arc lint + arc unit

Event Timeline

maxim added inline comments.
usr.sbin/bootparamd/callbootd/callbootd.8
24

You probably want to Xr bootparamd.8 here.

53

Missed comma

ziaee added a subscriber: ziaee.

It's been quite a long time, but adding reviewers who have worked on this codebase.

Looks ok - fix the items noted by maxim

gbe added inline comments.
usr.sbin/bootparamd/callbootd/callbootd.8
2

Please add a SPDX Header and a copyright notice.

56

This should something like

The ABC command / utility was written by
$NAME_OF_SRC_AUTHOR .
This manage was written by...

Add SPDX header and BSD Documentation License.

Updated to include recommendations. Please review.

usr.sbin/bootparamd/callbootd/callbootd.8
38

I don't understand the comment. It shows a different usage than is displayed in this section? I'm not familiar with the program to know which is correct.

57

style.mdoc(5) says the width should be the longest item, unless that hurts readability then it should be indent. I like to check mine at MANWIDTH=80 and MANWIDTH=59

75

Ql is quoted literal, so you don't need to quote it's arguments

usr.sbin/bootparamd/callbootd/callbootd.c
151–154

This is backwards: this should all be hard-tab indented per style(9).