Page MenuHomeFreeBSD

tests/sys/opencrypto: enable armv8crypto
ClosedPublic

Authored by greg_unrelenting.technology on Jul 21 2019, 7:28 PM.

Details

Summary

The tests were useful for adding XTS (D21017) and will no doubt be useful for adding more of the things :)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lwhsu added a reviewer: jhb.Jul 22 2019, 2:11 PM
lwhsu added a subscriber: lwhsu.
ngie added a comment.Jul 22 2019, 4:15 PM

Could you please test this change out on amd64?

Thank you for the submission :)!

tests/sys/opencrypto/runtests.sh
67 ↗(On Diff #59995)

Please use a switch statement here, e.g.,

case “${cpu_type}” in
aarch64)
    cpu_module=...
    ;;
amd64|i386)
    cpu_module=...
    ;;
esac

The above change would break some testing on i386.

PS please pardon my editing. I’m submitting the comment via my iPhone).

greg_unrelenting.technology marked an inline comment as done.
In D21018#456270, @ngie wrote:

Could you please test this change out on amd64?

Yes, works fine of course.

tests/sys/opencrypto/runtests.sh
67 ↗(On Diff #59995)

Of course Intel added AES-NI to the 32-bit mode, why did I assume that all new features were restricted to 64-bit.. Sorry :D

Updated the patch.

emaste added a subscriber: emaste.Aug 8 2019, 8:09 PM

@ngie will you commit this?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2019, 3:53 PM
This revision was automatically updated to reflect the committed changes.