The tests were useful for adding XTS (D21017) and will no doubt be useful for adding more of the things :)
Details
Details
- Reviewers
ngie jmg jhb - Group Reviewers
Contributor Reviews (src) - Commits
- rS350837: tests/sys/opencrypto: enable armv8crypto on aarch64
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Could you please test this change out on amd64?
Thank you for the submission :)!
| tests/sys/opencrypto/runtests.sh | ||
|---|---|---|
| 67 ↗ | (On Diff #59995) | Please use a switch statement here, e.g., case “${cpu_type}” in
aarch64)
cpu_module=...
;;
amd64|i386)
cpu_module=...
;;
esacThe above change would break some testing on i386. PS please pardon my editing. I’m submitting the comment via my iPhone). |
Comment Actions
Yes, works fine of course.
| tests/sys/opencrypto/runtests.sh | ||
|---|---|---|
| 67 ↗ | (On Diff #59995) | Of course Intel added AES-NI to the 32-bit mode, why did I assume that all new features were restricted to 64-bit.. Sorry :D Updated the patch. |