Differential D27831

rockchip: add audio-related clocks to the CRU driver
ClosedPublic
Actions

Authored by gonzo on Dec 30 2020, 12:28 AM.

Tags

None

Referenced Files

	F111987234: D27831.id81381.diff
	Tue, Mar 11, 5:28 AM

	F111986915: D27831.id81347.diff
	Tue, Mar 11, 5:26 AM

	F111984876: D27831.id81383.diff
	Tue, Mar 11, 4:54 AM

	F111981086: D27831.id.diff
	Tue, Mar 11, 3:41 AM

	F111970848: D27831.diff
	Tue, Mar 11, 12:18 AM

	Unknown Object (File)
	Tue, Mar 4, 3:57 PM

	Unknown Object (File)
	Sat, Mar 1, 4:19 AM

	Unknown Object (File)
	Feb 7 2025, 5:17 AM

View All 96 Files

Subscribers

Details

Reviewers

manu
mmel

Commits

rGd03fd8ede2c4: rockchip: add audio-related clocks to the CRU driver

Summary

Add I2S and CODEC clocks to CRU driver
Add support for gate selection to frac clock
Add setfreq support to mux clock

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gonzo created this revision.Dec 30 2020, 12:28 AM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptDec 30 2020, 12:28 AM

gonzo requested review of this revision.Dec 30 2020, 12:28 AM

Harbormaster completed remote builds in B35773: Diff 81347.Dec 30 2020, 12:28 AM

gbe added a subscriber: gbe.Dec 30 2020, 8:50 AM

manu added inline comments.Dec 30 2020, 9:26 AM

sys/arm64/rockchip/clk/rk_clk_mux.c
166	We should honor the CLK_SET_ROUND* here.

gonzo added inline comments.Dec 30 2020, 7:12 PM

sys/arm64/rockchip/clk/rk_clk_mux.c
166	Isn't it handled by line 151? We just pick any parent that can deliver a requested frequency with specified flags. If we want the best suitable parent according to flags, additional modifications required to clknode_set_freq to get an actual freq achievable by the clock.

Add Allwinner codecs and I2S driver as an example for the framework usage
simple-amplifier: make gpio-enable optional

Harbormaster completed remote builds in B35798: Diff 81381.Dec 30 2020, 7:32 PM

Revert back to the correct diff

Harbormaster completed remote builds in B35800: Diff 81383.Dec 30 2020, 7:34 PM

manu accepted this revision.Dec 31 2020, 10:34 AM

manu added inline comments.

sys/arm64/rockchip/clk/rk_clk_mux.c
166	Yes you're right, I've miss read this part.

This revision is now accepted and ready to land.Dec 31 2020, 10:34 AM

Closed by commit rGd03fd8ede2c4: rockchip: add audio-related clocks to the CRU driver (authored by gonzo). · Explain WhyJan 4 2021, 1:07 AM

This revision was automatically updated to reflect the committed changes.

gonzo added a commit: rGd03fd8ede2c4: rockchip: add audio-related clocks to the CRU driver.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

rockchip/

clk/

275 lines

6 lines

4 lines

35 lines

1 line

61 lines

Diff 81603

sys/arm64/rockchip/clk/rk3328_cru.c

Loading...

sys/arm64/rockchip/clk/rk3399_cru.c

Loading...

sys/arm64/rockchip/clk/rk_clk_fract.h

Loading...

sys/arm64/rockchip/clk/rk_clk_fract.c

Loading...

sys/arm64/rockchip/clk/rk_clk_mux.h

Loading...

sys/arm64/rockchip/clk/rk_clk_mux.c

Loading...