Page MenuHomeFreeBSD

rockchip: add audio-related clocks to the CRU driver
ClosedPublic

Authored by gonzo on Dec 30 2020, 12:28 AM.

Details

Summary
  • Add I2S and CODEC clocks to CRU driver
  • Add support for gate selection to frac clock
  • Add setfreq support to mux clock

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sys/arm64/rockchip/clk/rk_clk_mux.c
165

We should honor the CLK_SET_ROUND* here.

sys/arm64/rockchip/clk/rk_clk_mux.c
165

Isn't it handled by line 151? We just pick any parent that can deliver a requested frequency with specified flags.
If we want the best suitable parent according to flags, additional modifications required to clknode_set_freq to get an actual freq achievable by the clock.

  • Add Allwinner codecs and I2S driver as an example for the framework usage
  • simple-amplifier: make gpio-enable optional

Revert back to the correct diff

manu added inline comments.
sys/arm64/rockchip/clk/rk_clk_mux.c
165

Yes you're right, I've miss read this part.

This revision is now accepted and ready to land.Dec 31 2020, 10:34 AM