Differential D26006

Improvements for Rockchip's integration of if_dwc
ClosedPublic
Actions

Authored by gonzo on Aug 8 2020, 6:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 23, 2:04 PM

	Unknown Object (File)
	Mon, Apr 21, 9:40 PM

	Unknown Object (File)
	Mon, Apr 21, 8:50 AM

	Unknown Object (File)
	Fri, Apr 18, 4:56 PM

	Unknown Object (File)
	Wed, Apr 16, 10:04 PM

	Unknown Object (File)
	Mon, Apr 14, 1:49 PM

	Unknown Object (File)
	Mon, Apr 14, 11:53 AM

	Unknown Object (File)
	Mon, Apr 14, 4:25 AM

View All 89 Files

Subscribers

Details

Reviewers

Commits

rS365388: MFC r362736, r364088
rS364088: Improve Rockchip's integration of if_dwc

Summary

Add support for RMII
Properly set up clocks for both RGMII and RMII cases
Handle media switching between 100Mb and 1000Mb networks

Test Plan

Tested on RockPro64, Firefly-RK3399, Rock Pi E (both interfaces), Rock64 (still some issues with functionality)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gonzo created this revision.Aug 8 2020, 6:33 AM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptAug 8 2020, 6:33 AM

gonzo requested review of this revision.Aug 8 2020, 6:33 AM

Harbormaster completed remote builds in B32872: Diff 75604.Aug 8 2020, 6:33 AM

manu added inline comments.Aug 8 2020, 2:04 PM

sys/arm64/rockchip/if_dwc_rk.c
63 ↗	(On Diff #75604)	It's called gmac2io_txclk_dly_ena in the TRM, maybe we should do the same or at least something more close to the TRM. (Same comment for all the other ones)
73 ↗	(On Diff #75604)	s/INT/INTF/ This could be confusing as it's not interrupts but interface.
79 ↗	(On Diff #75604)	0 << 2
186 ↗	(On Diff #75604)	if (bootverbose)
207 ↗	(On Diff #75604)	Leftover from debug code ?
sys/dev/dwc/if_dwc.c
1221 ↗	(On Diff #75604)	if (bootverbose)

gonzo marked 5 inline comments as done.Aug 8 2020, 7:23 PM

gonzo marked an inline comment as done.Aug 8 2020, 11:01 PM

Fix all issues mentioned by manu@

Harbormaster completed remote builds in B32881: Diff 75616.Aug 8 2020, 11:01 PM

manu accepted this revision.Aug 9 2020, 10:30 AM

This revision is now accepted and ready to land.Aug 9 2020, 10:30 AM

Closed by commit rS364088: Improve Rockchip's integration of if_dwc (authored by gonzo). · Explain WhyAug 10 2020, 7:37 PM

This revision was automatically updated to reflect the committed changes.

gonzo added a commit: rS364088: Improve Rockchip's integration of if_dwc.

gonzo added a commit: rS365388: MFC r362736, r364088.Sep 6 2020, 7:04 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

rockchip/

540 lines

dev/

dwc/

4 lines

24 lines

14 lines

1 line

Diff 75646

head/sys/arm64/rockchip/if_dwc_rk.c

Loading...

head/sys/dev/dwc/if_dwc.h

Loading...

head/sys/dev/dwc/if_dwc.c

Loading...

head/sys/dev/dwc/if_dwc_if.m

Loading...

head/sys/dev/dwc/if_dwcvar.h

Loading...