Rename MACHINE_ABI and TARGET_ABI
ClosedPublic
Actions

Authored by brooks on Sep 1 2022, 10:25 PM.

Details

Reviewers

jrtc27
imp
jhb

Commits

rG77becb932575: Rename MACHINE_ABI and TARGET_ABI

Summary

The MACHINE_ABI and TARGET_ABI variables are used to set the middle of
the target triple (e.g., "-unknown-" or "-gnueabihf-"). The are not set
by any tool in the base system and I've only found the latter mentioned
in one review online. As such, rename them to to MACHINE_TRIPLE_ABI and
TARGET_TRIPLE_ABI to clear the way to use MACHINE_ABI as a suplement to
MACHINE_CPU, etc.

Obtained from: CheriBSD
Sponsored by: DARPA, AFRL

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Sep 1 2022, 10:25 PM

Herald added a subscriber: emaste. · View Herald TranscriptSep 1 2022, 10:25 PM

brooks requested review of this revision.Sep 1 2022, 10:25 PM

Harbormaster completed remote builds in B47224: Diff 110062.Sep 1 2022, 10:25 PM

brooks added a child revision: D36421: Introduce MACHINE_ABI as a list of ABI properties.Sep 1 2022, 10:25 PM

brooks mentioned this in D36421: Introduce MACHINE_ABI as a list of ABI properties.Sep 1 2022, 10:28 PM

They're not exported so they can't be being used elsewhere

imp added inline comments.Sep 1 2022, 10:44 PM

UPDATING
35 ↗	(On Diff #110062)	Needed? Is this really something people set?

brooks added inline comments.Sep 1 2022, 11:02 PM

UPDATING
35 ↗	(On Diff #110062)	I doubt it, but maybe there's someone setting them to `undermydesk` or the like (as always, see https://xkcd.com/1172/ :). Happy to drop this, but in the unlikely event someone is using them it makes the change discoverable.