rockchip rng support, similar with bcm2835_rng
random data generated is passed to
random_harvest_queue
v1 and v2 supported only v2 tested
randomness of data generated only tested with the 'eye test'
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Haven't reviewed yet but this needs to be hooked into the build (and also have a module with PNP_INFO).
Comment Actions
Generally speaking, lot of style issues.
| arm64/rockchip/rk_rng.c | ||
|---|---|---|
| 106 ↗ | (On Diff #130216) | Style |
| 137–138 ↗ | (On Diff #130216) | Style. |
| 157 ↗ | (On Diff #130216) | Style. |
| 182 ↗ | (On Diff #130216) | Style. |
| 204 ↗ | (On Diff #130216) | Why do you use "| 0"? What is the point? |
| 216 ↗ | (On Diff #130216) | Style. |
| 222 ↗ | (On Diff #130216) | Style. |
| 228 ↗ | (On Diff #130216) | Style. |
| 270 ↗ | (On Diff #130216) | Style. |
| 275 ↗ | (On Diff #130216) | I suggest to free bus resources when one of the following errors appear. |
| 285 ↗ | (On Diff #130216) | Style. |
| 299 ↗ | (On Diff #130216) | Style. |
| 301 ↗ | (On Diff #130216) | Style. |
| 308 ↗ | (On Diff #130216) | Style. |
| 347 ↗ | (On Diff #130216) | Style. |
Comment Actions
fixed some styling
to build add in
/sys/conf/files.arm64
arm64/rockchip/rk_rng.c optional fdt rk_rng
/sys/arm64/conf/std.rockchip
device rk_rng # RockChip TRNG
| sys/arm64/rockchip/rk_rng.c | ||
|---|---|---|
| 232 ↗ | (On Diff #130256) | RANDOM_PURE_BROADCOM? |
Comment Actions
Looks like you've updated a partial diff, please fix this so someone (tm) can review your changes.