Page MenuHomeFreeBSD

Don't do the busy dance in icee_open/close
ClosedPublic

Authored by imp on Mon, Sep 14, 10:36 PM.

Details

Summary

We don't need to do the busy dance for this driver. It's handled by
destroy_dev() entirely. Since all we did was busy/unbusy in
open/close, just delete them. We therefore don't need to track closes
either.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Mon, Sep 14, 10:36 PM
imp created this revision.
ian accepted this revision.Mon, Sep 14, 11:16 PM
ian added a subscriber: ian.

Applied patch to freebsd 8 (which we use at $work but it has the icee.c source from -current) and freebsd 11 and it behaves as expected on our products.

Based on the commit history, I was the one who added the busy/unbusy, and I think I was just being a bit too overprotective, wanting to prevent doing a kldunload on the module while something had the cdev open. The TRACKCLOSE was just my misunderstanding of how that flag works, it was never needed.

This revision is now accepted and ready to land.Mon, Sep 14, 11:16 PM
This revision was automatically updated to reflect the committed changes.