Don't do the busy dance in icee_open/close
ClosedPublic
Actions

Authored by imp on Sep 14 2020, 10:36 PM.

Details

Reviewers

Commits

rS365735: Don't do the busy dance in icee_open/close

Summary

We don't need to do the busy dance for this driver. It's handled by
destroy_dev() entirely. Since all we did was busy/unbusy in
open/close, just delete them. We therefore don't need to track closes
either.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33556
Build 30811: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sep 14 2020, 10:36 PM

imp created this revision.

Harbormaster completed remote builds in B33556: Diff 77032.Sep 14 2020, 10:36 PM

Applied patch to freebsd 8 (which we use at $work but it has the icee.c source from -current) and freebsd 11 and it behaves as expected on our products.

Based on the commit history, I was the one who added the busy/unbusy, and I think I was just being a bit too overprotective, wanting to prevent doing a kldunload on the module while something had the cdev open. The TRACKCLOSE was just my misunderstanding of how that flag works, it was never needed.

This revision is now accepted and ready to land.Sep 14 2020, 11:16 PM

Closed by commit rS365735: Don't do the busy dance in icee_open/close (authored by imp). · Explain WhySep 14 2020, 11:30 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS365735: Don't do the busy dance in icee_open/close.