Page MenuHomeFreeBSD

Tune DTrace 'aframes' for the FBT and profile providers on arm64.
ClosedPublic

Authored by rwatson on Sun, Mar 21, 12:08 AM.

Details

Summary

In both cases, too few frames were trimmed, leading to exception handling
or DTrace internals being exposed in stack traces exposed by D's stack()
primitive.

MFC after: 3 days

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Mon, Mar 22, 9:30 AM
emaste added inline comments.
sys/cddl/dev/profile/profile.c
107

I deleted this and the sparc comment above in 64a790d264808116469914c19265e905b3929e00, thinking that this change had already been committed. In any case this shouldn't be a conflict.

This revision now requires review to proceed.Mon, Mar 22, 2:31 PM
andrew added inline comments.
sys/cddl/dev/profile/profile.c
117

There is also a duplicate __mips that could be removed after this has been committed

133

Here

This revision is now accepted and ready to land.Mon, Mar 22, 2:58 PM