Page MenuHomeFreeBSD

Add -NODEBUG variant of GENERIC-MMCCAM kernel configuration.
ClosedPublic

Authored by rwatson on Mon, Jan 11, 8:38 AM.

Details

Summary

This is the same as GENERIC-MMCCAM but including GENERIC-NODEBUG as the
baseline. This is the kernel configuration we plan to use in Cambridge's
L41 course.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Mon, Jan 11, 2:33 PM

Update comment for new kernel name.

This revision now requires review to proceed.Mon, Jan 11, 2:56 PM

Hm, my instinct would be to make it include GENERIC-MMCCAM instead and then turn of debugging, especially given the name.

Hm, my instinct would be to make it include GENERIC-MMCCAM instead and then turn of debugging, especially given the name.

This isn't a bad idea.
However, it's been my experience that if you use KERNCONF for the (build)kernel target in make, you have to have KERNCONF="GENERIC GENERIC-NODEBUG GENERIC-MMCCAM" before you can run the installkernel target with KERNCONF=GENERIC-MMCCAM - that fun little experience has bitten me a few times too many. :)

Hm, my instinct would be to make it include GENERIC-MMCCAM instead and then turn of debugging, especially given the name.

I also thought about this. However, the reason I didn't do this is that I suspect it's more likely that people updating GENERIC and GENERIC-NODEBUG will forget to update GENERIC-MMCCAM-NODEBUG than that people modifying GENERIC-MMCCAM will forget to update GENERIc-MMCCAM-NODEBUG. I.e., when someone adds a new "options foo" debugging feature, I fear that they will be more likely to miss some arm64-local config variations.

We could split out the -NODEBUG options to std.nodebug then include that from both here and GENERIC-NODEBUG

We could split out the -NODEBUG options to std.nodebug then include that from both here and GENERIC-NODEBUG

That's what we do downstream for CHERI-RISC-V (though with an uppercase NODEBUG to match the names of the kernel configs), and we've been meaning to upstream a std.NODEBUG (which should probably be in sys/conf, and if architectures really have additional options to disable they can have a sys/arch/conf/std.NODEBUG that includes and extends it), and possibly also add a std.DEBUG (which might make re@'s job easier?).

After R10:6eebda3bbad9 you can replace this with:

include GENERIC-MMCCAP
include "../../conf/std.nodebug"

ident GENERIC-MMCCAM-NODEBUG

I added the CAM debug options to std.nodebug so they shouldn't be needed.

Following R10:6eebda3bbad9, update this patch to use std.nodebug, which is
much preferred.

This revision is now accepted and ready to land.Sat, Jan 16, 1:48 PM