sson (Stacey Son)
User

Projects (6)

User Details

User Since
Jul 28 2014, 3:08 PM (148 w, 19 h)

Recent Activity

Sep 16 2016

sson added a comment to D2535: New, experimental PMAP implementation for MIPS64.

I committed the pagemask enumeration/printing logic to -head a while ago. We should gather some dmesg's from various embedded MIPS boards.

IIRC, some of the mips24kc parts were only doing 4k pages.. :(

Sep 16 2016, 10:24 PM · MIPS

Mar 13 2016

sson added a comment to D5623: Fix MIPS pmap_align_superpage() function to use superpage rather than segment alignment.

Yes, the superpage size should be 2M (PDRSIZE) for mips64. This looks correct. I am not sure it matters for mips32 given there is no superpage support for it yet. The way it is done for mips64 (see https://reviews.freebsd.org/D2535 ) may not work for mips32 given the limited number of available PTE bits. Of course, the mips64 superpage implementation was designed to support multiple superpage sizes (more than just 2M) although only one superpage size is currently implemented. I imagine with mips32 only one superpage size would be supported.

Mar 13 2016, 6:05 PM · MIPS

Feb 3 2016

sson abandoned D5171: Add e_flags information to ELF core files.

I will fix this in LLDB. Thanks Warner!

Feb 3 2016, 10:24 PM · MIPS
sson added a comment to D5171: Add e_flags information to ELF core files.
In D5171#110109, @imp wrote:

Also, the LLVM parser is wrong.

case llvm::ELF::EF_MIPS_ARCH_3:
case llvm::ELF::EF_MIPS_ARCH_4:
case llvm::ELF::EF_MIPS_ARCH_5:
case llvm::ELF::EF_MIPS_ARCH_64:
    return (endian == ELFDATA2LSB) ? ArchSpec::eMIPSSubType_mips64el : ArchSpec::eMIPSSubType_mips64;

This is incorrect. These arch (at least the first two) are both 32-bit and 64-bit. You know what arch you are executing based on the e_ident[EI_CLASS} telling you 32 vs 64 bit.

32-bit mips FreeBSD binaries are MIPS-3. And that's correct. And LLVM doesn't grok that. So the LLVM parser also needs work.

Feb 3 2016, 5:42 PM · MIPS
sson added a comment to D5171: Add e_flags information to ELF core files.
In D5171#110106, @imp wrote:

I don't like this interface. The CPU specific eflags aren't a property of the CPU, but rather are a property of how the binary was compiled. These should be in the header for the binary being executed, which is completely ignored. On arm, there's at least two flavors we support executing today. On mips we support 3 different binary ABIs. And we wish to support more flavors of those ABIs (soft-float, hard-float, cheri) and you can't know based on the kernel which one of these you are running.

Feb 3 2016, 5:33 PM · MIPS
sson retitled D5171: Add e_flags information to ELF core files from to Add e_flags information to ELF core files.
Feb 3 2016, 4:02 PM · MIPS

Jun 18 2015

sson accepted D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..
Jun 18 2015, 1:30 AM

Jun 14 2015

sson added inline comments to D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..
Jun 14 2015, 5:52 AM

Jun 8 2015

sson added a comment to D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..
In D1971#52645, @mjg wrote:

the problem of holding a non-sleep lock during a page fault as reported by witness

What page fault?

Jun 8 2015, 7:02 PM
sson accepted D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..
Jun 8 2015, 3:09 PM

Jun 5 2015

sson added inline comments to D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..
Jun 5 2015, 6:10 PM

Jun 4 2015

sson abandoned D2096: Use a reader count instead of holding lock..

This has been replaced by https://reviews.freebsd.org/D2123

Jun 4 2015, 8:42 PM
sson abandoned D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..

This has been replaced by https://reviews.freebsd.org/D2123

Jun 4 2015, 8:41 PM
sson added a reviewer for D2123: Use a reader count instead of holding lock.: sbruno.
Jun 4 2015, 6:27 PM

May 13 2015

sson updated D2535: New, experimental PMAP implementation for MIPS64.
May 13 2015, 3:19 PM · MIPS
sson retitled D2535: New, experimental PMAP implementation for MIPS64 from to New, experimental PMAP implementation for MIPS64.
May 13 2015, 3:16 PM · MIPS

Mar 24 2015

sson retitled D2123: Use a reader count instead of holding lock. from to Use a reader count instead of holding lock..
Mar 24 2015, 4:11 AM

Mar 19 2015

sson retitled D2096: Use a reader count instead of holding lock. from to Use a reader count instead of holding lock..
Mar 19 2015, 3:54 PM

Mar 2 2015

sson updated the diff for D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..

This one should apply cleanly to head.

Mar 2 2015, 8:24 PM

Feb 27 2015

sson added a comment to D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..

I don't know why http://svnweb.freebsd.org/base/head/sys/kern/imgact_binmisc.c?r1=264282&r2=271141&pathrev=271141 showed up in this diff. Weird.

Feb 27 2015, 2:00 PM
sson updated the diff for D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex..

Simplify change by just acquiring exclusive lock and not trying to upgrade it.

Feb 27 2015, 1:51 PM

Feb 26 2015

sson retitled D1971: Update imgact_binmisc.c to use a sx lock instead of a mutex. from to Update imgact_binmisc.c to use a sx lock instead of a mutex..
Feb 26 2015, 2:03 PM

Jul 28 2014

sson updated subscribers of D494: Add shortcut support to binmiscctl.

I would "#if 0" the dead code for now (rather than adding a 'return 0') to avoid upsetting the compiler god. Other than that, it looks fine.

Jul 28 2014, 3:13 PM