sbruno (Sean Bruno)
User

Projects (6)

User Details

User Since
May 26 2014, 3:41 PM (195 w, 6 d)

Recent Activity

Thu, Feb 15

sbruno accepted D14389: libsa: Add MAXWAIT to net for establishing max total timeout.

After *READING* the review, I tested with a MAXWAIT of 20 and this works as advertised.

Thu, Feb 15, 10:08 PM
sbruno requested changes to D14389: libsa: Add MAXWAIT to net for establishing max total timeout.

Hmmm ... I'm up to five minutes waiting for a timeout here and I don't even see the twiddle moving.

Thu, Feb 15, 9:53 PM
sbruno accepted D14373: libsa: Consolidate tftp sendrecv into net.c sendrecv.

stlgtm

Thu, Feb 15, 6:26 PM

Wed, Feb 14

sbruno requested changes to D14373: libsa: Consolidate tftp sendrecv into net.c sendrecv.

Quick and dirty assessment: BTX panics. :-( More review to come.

Wed, Feb 14, 10:18 PM

Tue, Feb 13

sbruno accepted D14350: libsa: Fix IP recv timeout.

BINGO

Tue, Feb 13, 9:56 PM
sbruno requested changes to D14350: libsa: Fix IP recv timeout.

Ugh, phab seems to have not take the diffs from the root of the src tree. I'll munge a bit, but can you regenerate?

Tue, Feb 13, 8:53 PM
sbruno abandoned D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.

Heh, sorry, I ended up creating another review with a different version of that patch: https://reviews.freebsd.org/D14350 -- it turned out there was also a case over in net.c that needed fixing, and we have some timing weirdness happening in the tftp bits to go with it.

Tue, Feb 13, 8:51 PM
sbruno retitled D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT from libsa: Allow a tftp retry if a sendrecv returns EAGAIN to libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Tue, Feb 13, 8:47 PM
sbruno updated the diff for D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.

Use kevans@ version of the patch from private email. Add a debug statement so
I can detect the ETIMEDOUT condition, which does get hit and resumes TFTP without
failing.

Tue, Feb 13, 8:45 PM

Mon, Feb 12

sbruno added inline comments to D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Mon, Feb 12, 6:28 PM
sbruno updated subscribers of D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Mon, Feb 12, 6:27 PM
sbruno updated the summary of D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Mon, Feb 12, 6:26 PM
sbruno created D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Mon, Feb 12, 6:25 PM

Thu, Feb 1

sbruno committed rP460635: emulators/qemu-sbruno add missing files to pkg-plist.
emulators/qemu-sbruno add missing files to pkg-plist
Thu, Feb 1, 9:06 PM
sbruno committed rP460605: audio/clementine-player: Fixup build breakage after clang 6 update..
audio/clementine-player: Fixup build breakage after clang 6 update.
Thu, Feb 1, 2:54 PM

Wed, Jan 31

sbruno committed rP460499: Fix nullptr definition buildfailure on current with clang6.
Fix nullptr definition buildfailure on current with clang6
Wed, Jan 31, 4:38 PM
sbruno closed D14131: Correct check for nullptr to fix build with clang 6..
Wed, Jan 31, 4:38 PM
sbruno accepted D14131: Correct check for nullptr to fix build with clang 6..
Wed, Jan 31, 4:33 PM

Tue, Jan 30

sbruno committed rS328603: Add missing non-POWERPC case to give the scr value something non-zero..
Add missing non-POWERPC case to give the scr value something non-zero.
Tue, Jan 30, 8:00 PM
sbruno added a comment to D14131: Correct check for nullptr to fix build with clang 6..

I'll run this through my local meat grinder and approve/commit after. THANKS

Tue, Jan 30, 6:25 PM

Jan 26 2018

sbruno added a comment to D13885: ixgbe(4): Update shared code, add support for X552, fix bug.

Unrelated, is there a use case for FreeBSD Bhyve here? If we had PF support on FreeBSD, could we use pass through to use VFs?

Jan 26 2018, 5:20 PM

Jan 19 2018

sbruno committed rP459464: sysutils/devcpu-data: Revert back to legacy microcode.dat implementation..
sysutils/devcpu-data: Revert back to legacy microcode.dat implementation.
Jan 19 2018, 7:28 PM
sbruno closed D13987: sysutils/devcpu-data: Revert back to legacy microcode.dat implementation.
Jan 19 2018, 7:28 PM
sbruno updated the summary of D13987: sysutils/devcpu-data: Revert back to legacy microcode.dat implementation.
Jan 19 2018, 6:24 PM
sbruno created D13987: sysutils/devcpu-data: Revert back to legacy microcode.dat implementation.
Jan 19 2018, 6:23 PM
sbruno accepted D13982: bnxt: Update man page with newly supported devices, options, ect.
Jan 19 2018, 6:02 PM
sbruno abandoned D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..

I will be reverting back to the ucode-tool in the next revision. There is definitely an issue with cpucontrol iterating though an intel microcode file with multiple updates.

Jan 19 2018, 5:45 PM

Jan 17 2018

sbruno added inline comments to D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Jan 17 2018, 10:30 PM
sbruno retitled D13958: sysutils/devcpu-data: Restore one "legacy" microcode update. from sysutils/devcpu-data: Restore one "legacy" micrcodoe update. to sysutils/devcpu-data: Restore one "legacy" microcode update..
Jan 17 2018, 8:16 PM
sbruno added a comment to D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..

It sure looks like there is a problem here.

Jan 17 2018, 8:16 PM
sbruno updated the summary of D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Jan 17 2018, 8:14 PM
sbruno created D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Jan 17 2018, 8:13 PM
sbruno committed rP459266: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated….
sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated…
Jan 17 2018, 4:04 PM
sbruno closed D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Jan 17 2018, 4:04 PM

Jan 16 2018

sbruno committed rP459205: Revert Intel URL to the correct location for microcode-20171117.tgz.
Revert Intel URL to the correct location for microcode-20171117.tgz
Jan 16 2018, 7:56 PM
sbruno accepted D13885: ixgbe(4): Update shared code, add support for X552, fix bug.

Let me know if you need me to commit this.

Jan 16 2018, 1:56 PM

Jan 15 2018

sbruno added inline comments to D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Jan 15 2018, 8:00 PM
sbruno added a comment to D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..

Surprisingly, this seems to work for us.

Jan 15 2018, 5:43 PM
sbruno created D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Jan 15 2018, 5:42 PM

Jan 14 2018

sbruno committed rP458987: sysutils/devcpu-data: Only run "cpucontrol -e" once..
sysutils/devcpu-data: Only run "cpucontrol -e" once.
Jan 14 2018, 6:28 PM

Jan 13 2018

sbruno committed rP458943: sysutils/devcpu-data: Update AMD microcode, add cpu 17h microcode,.
sysutils/devcpu-data: Update AMD microcode, add cpu 17h microcode,
Jan 13 2018, 9:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Jan 13 2018, 9:36 PM
sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
In D13832#290897, @cem wrote:

Your CPU, "family 0xf model 0xb stepping 0x2 extfamily 0 extmodel 0x6" should be 0x60fb2 -- which, yeah, isn't one of 0x600f20, 0x610f01, or 0x600f12. So this microcode file doesn't have an update for your CPU, as I understand it.

I am not sure whether you are correct in this assumption.
The name mangling that is done by ucode-tool is bad and confusing. Imho ucode-tool should be retired, as it is legacy stuff, and the vendor-supplied binary files be used instead for more consistency.
I have done a write-up about this topic on the FreeBSD forums here, where I analyze why the microcode_update thing seems to be broken due to a fundamentally wrong approach.

Jan 13 2018, 9:28 PM

Jan 11 2018

sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

This works for my FX-8150:

Jan 11 2018, 9:43 PM
sbruno updated the diff for D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Update after Intel microcode revert

Jan 11 2018, 9:41 PM
sbruno committed rP458792: Revert to previous Intel microcode archive (20171117)..
Revert to previous Intel microcode archive (20171117).
Jan 11 2018, 8:45 PM
sbruno planned changes to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Blocking pending update for Intel microcode revert.

Jan 11 2018, 7:34 PM
sbruno committed rP458760: sysutils/x86info Update to top of github tree.
sysutils/x86info Update to top of github tree
Jan 11 2018, 5:57 PM
sbruno closed D13866: sysutils/x86info Update to top of tree and add patches from kib@.
Jan 11 2018, 5:57 PM
sbruno updated the summary of D13866: sysutils/x86info Update to top of tree and add patches from kib@.
Jan 11 2018, 5:40 PM
sbruno created D13866: sysutils/x86info Update to top of tree and add patches from kib@.
Jan 11 2018, 5:39 PM
sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
In D13832#290218, @cem wrote:

Is there any way to check the microcode version currently in use?

$ x86info -a | grep Microcode

Unfortunately, it appears microcode loading is broken on Family 17h, so I haven't tested anything useful.

Should this work for Intel cpu's as well? I have a couple servers that use Intel chips, but I have no idea if the microcode is actually being updated. I suspect it is not, x86info -a doesn't provide any information about the microcode.

Jan 11 2018, 5:15 PM
sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

I found that "chopping up" the AMD microcode files was incorrect (and probably broken for 3+ years). If you have access to AMD hosts, please try my review on your systems. I now get an update to my FX-8150 with my review.

Jan 11 2018, 4:23 PM
sbruno updated the diff for D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Examining the amd cpucontrol code has led me to realize that chopping up
the microcode files for AMD cpus is exactly wrong. They are already in
the format that corresponds to our processing via "amd10h" so don't do that
anymore.

Jan 11 2018, 12:49 AM

Jan 10 2018

sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Add Family 17h firmware.

Jan 10 2018, 8:15 PM
sbruno created D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
Jan 10 2018, 8:13 PM
sbruno committed rP458664: sysutils/devcpu-data follow up commit to 20180108 Intel microcode update..
sysutils/devcpu-data follow up commit to 20180108 Intel microcode update.
Jan 10 2018, 5:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Jan 10 2018, 5:32 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Now that the microcode has already been updated, cleanup the review.

Jan 10 2018, 5:27 PM
sbruno added inline comments to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 10 2018, 12:29 AM

Jan 9 2018

sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

It is more than sufficient to check for a non-zero return code from cpucontrol
using -e.

Jan 9 2018, 11:38 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Redirect cpucontrol error spew to /dev/null when testing -e

Jan 9 2018, 10:56 PM
sbruno added a comment to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Any further objections? I still need to smoke test this a bit too.

Jan 9 2018, 9:47 PM
sbruno updated subscribers of D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 9 2018, 9:33 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

When trying to rescan CPU flags, detect versions that don't support -e and error out

Jan 9 2018, 9:31 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Clarify pkg-message to indicate one does not need to reboot to install the microcode
update. (bdrewery)

Jan 9 2018, 9:18 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Make "cpucontrol -e" rescan of CPU flags conditional on updating ALL CPUS in the
host system. (gtetlow)

Jan 9 2018, 9:15 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Add a cpucontrol -e after microcode update is complete to re-evaluate
CPU flags. (suggested by bdrewery and cem)

Jan 9 2018, 9:07 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Add pkg-message file to indicate "how" this should be implemented after installing
the package.

Jan 9 2018, 8:37 PM
sbruno updated the summary of D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 9 2018, 8:27 PM
sbruno updated the summary of D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 9 2018, 8:27 PM
sbruno created D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 9 2018, 8:26 PM

Jan 7 2018

sbruno committed rP458363: sysutils/devcpu-data Unbreak build by using a cached distfile for amd microcode..
sysutils/devcpu-data Unbreak build by using a cached distfile for amd microcode.
Jan 7 2018, 6:14 PM
sbruno closed D13792: sysutils/devcpu-data Unbreak build with cached distfile for amd microcode.
Jan 7 2018, 6:14 PM
sbruno added a comment to D13792: sysutils/devcpu-data Unbreak build with cached distfile for amd microcode.

review from mat@

  • Drop PORTREVISION (this fixes the build, not needed)
  • Use recommended LOCAL/sbruno to indicate where to fetch the AMD microcode tar.
Jan 7 2018, 5:04 PM
sbruno updated the diff for D13792: sysutils/devcpu-data Unbreak build with cached distfile for amd microcode.

review from mat@

  • Drop PORTREVISION (this fixes the build, not needed)
  • Use recommended LOCAL/sbruno to indicate where to fetch the AMD microcode tar.
Jan 7 2018, 5:03 PM
sbruno created D13792: sysutils/devcpu-data Unbreak build with cached distfile for amd microcode.
Jan 7 2018, 4:34 PM

Jan 5 2018

sbruno committed rS327606: Handle misconfigured/nonexistent pcidev for comconsole instead of BTX panic..
Handle misconfigured/nonexistent pcidev for comconsole instead of BTX panic.
Jan 5 2018, 11:51 PM
sbruno closed D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
Jan 5 2018, 11:51 PM
sbruno committed rP458169: sysutils/devcpu-data with Intel microcode update 20171117..
sysutils/devcpu-data with Intel microcode update 20171117.
Jan 5 2018, 8:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Jan 5 2018, 8:38 PM
sbruno added a comment to D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
In D13776#288516, @imp wrote:

Looks good to me.

Though the more I think about it, how the heck did biospci_read_config find a config entry at all to extract the port info from the BAR?

Jan 5 2018, 8:32 PM
sbruno added a comment to D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.

Updated for comments and tested to validate functional AMT console and functional serial console. All looks good from here.

Jan 5 2018, 8:13 PM
sbruno updated the diff for D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.

Check against 0xffffffff instead of -1.

Jan 5 2018, 8:12 PM
sbruno updated the test plan for D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
Jan 5 2018, 7:17 PM
sbruno created D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
Jan 5 2018, 7:14 PM

Jan 4 2018

sbruno added a comment to D13771: sysutils/devcpu-data update to Intel Microcode update 20171117.

Please keep the plist sorted too.

Jan 4 2018, 11:23 PM
sbruno updated the diff for D13771: sysutils/devcpu-data update to Intel Microcode update 20171117.

Sort new entries to pkg-plist

Jan 4 2018, 11:23 PM
sbruno created D13771: sysutils/devcpu-data update to Intel Microcode update 20171117.
Jan 4 2018, 10:14 PM
sbruno committed rP458040: net/scapy: Update to upstream release 2.3.3.
net/scapy: Update to upstream release 2.3.3
Jan 4 2018, 5:50 PM
sbruno closed D13572: net/scapy: Update to upstream release 2.3.3.
Jan 4 2018, 5:50 PM
sbruno updated the diff for D13572: net/scapy: Update to upstream release 2.3.3.

Clean up tab vs space PORTLINT warning.

Jan 4 2018, 2:48 AM

Jan 3 2018

sbruno added a comment to D11067: usr.bin/elf2aout build warning fix.

@emaste Is this "ok" to commit or is this masking something else going on?

Jan 3 2018, 11:15 PM
sbruno added a reviewer for D11067: usr.bin/elf2aout build warning fix: emaste.
Jan 3 2018, 11:14 PM
sbruno accepted D11958: usr.bin/mandoc build warning/error fixes.

Any objections?

Jan 3 2018, 11:11 PM
sbruno added reviewers for D11958: usr.bin/mandoc build warning/error fixes: Doc Committers, jilles.
Jan 3 2018, 11:11 PM

Dec 28 2017

sbruno closed D13660: e1000: Add support for Ice Lake and Cannon Lake.
Dec 28 2017, 9:27 PM
sbruno committed rS327312: e1000: Add support for Ice Lake and Cannon Lake.
e1000: Add support for Ice Lake and Cannon Lake
Dec 28 2017, 9:27 PM
sbruno accepted D13660: e1000: Add support for Ice Lake and Cannon Lake.
Dec 28 2017, 5:10 PM

Dec 22 2017

sbruno committed rP456991: comms/amtterm Update to 1.6 release.
comms/amtterm Update to 1.6 release
Dec 22 2017, 8:56 PM