sbruno (Sean Bruno)
User

Projects (6)

User Details

User Since
May 26 2014, 3:41 PM (203 w, 4 d)

Recent Activity

Today

sbruno accepted D15142: Merge iflib to 11-STABLE.

Because "slush" is happening, I suspect you need to ask re@ to commit this.

Sat, Apr 21, 12:21 AM

Wed, Apr 18

sbruno accepted D15120: Fix queue distribution when there are no threads.
Wed, Apr 18, 3:22 PM

Thu, Apr 12

sbruno accepted D14514: Microsemi smartpqi SCSI driver for PQI controllers.

I'm running a universe build. After that, would you like this committed?

Thu, Apr 12, 10:44 PM
sbruno accepted D14984: Sleep rather than spin in e1000 when doing long running config operations.

Basic compile, boot tests are good to go. Perf TBD

Thu, Apr 12, 7:52 PM
sbruno requested changes to D14802: fix malloc length in ip6_output.c:GET_PKTOPT_VAR.
Thu, Apr 12, 6:29 PM
sbruno committed rS332432: Restore r332389 after resolution of locking fixes..
Restore r332389 after resolution of locking fixes.
Thu, Apr 12, 2:35 PM

Wed, Apr 11

sbruno committed rS332411: Revert r332389 as it is causing panics for various users and we need.
Revert r332389 as it is causing panics for various users and we need
Wed, Apr 11, 5:27 PM
sbruno accepted D15041: Use C99 initializers for if_txrx..

stlgtm

Wed, Apr 11, 3:09 PM

Mon, Apr 9

sbruno requested changes to D14969: separate out list manipulation locking from state change in multicast.
Mon, Apr 9, 2:56 PM

Sat, Apr 7

sbruno accepted D14967: split out flag manipulation from general context manipulation in iflib.

Y'all want this committed?

Sat, Apr 7, 10:26 PM

Fri, Apr 6

sbruno added inline comments to D14514: Microsemi smartpqi SCSI driver for PQI controllers.
Fri, Apr 6, 4:30 PM

Thu, Apr 5

sbruno committed rS332070: Squash error from geom by sizing ident strings to DISK_IDENT_SIZE..
Squash error from geom by sizing ident strings to DISK_IDENT_SIZE.
Thu, Apr 5, 1:57 PM
sbruno closed D14962: geom: squash g_attribute kernel message by using correctly sized buffers.
Thu, Apr 5, 1:56 PM

Wed, Apr 4

sbruno added a comment to D14962: geom: squash g_attribute kernel message by using correctly sized buffers.
In D14962#314735, @avg wrote:

While you are here, could you please fix g_label_disk_ident_taste as well?
It has a more reasonable sized buffer (100), but still would be nice to use the proper constant.

Wed, Apr 4, 6:17 PM
sbruno updated the diff for D14962: geom: squash g_attribute kernel message by using correctly sized buffers.

Add g_label_disk_ident_taste() to our list of fixes.

Wed, Apr 4, 6:17 PM
sbruno updated the summary of D14962: geom: squash g_attribute kernel message by using correctly sized buffers.
Wed, Apr 4, 5:04 PM
sbruno created D14962: geom: squash g_attribute kernel message by using correctly sized buffers.
Wed, Apr 4, 5:02 PM
sbruno added a comment to D14514: Microsemi smartpqi SCSI driver for PQI controllers.

I agree all the other review comments and fixed them. But need some clarifications on the below.

  1. > smartpqi_includes.h:26

+ */
+
+#ifndef _PQI_INCLUDES_H

This file seems like an overuse of include files. Since this is included in almost every file in the driver, it seems like we are including the header files many, many times. This does lead to bloat in the driver but is functionally harmless.

----> We actually have two sets of header files – OS specific and PQI protocol specific. We tried to consolidate them in one header file and use it. So could you please help us out by elaborating what could be the best solution here.

Wed, Apr 4, 3:26 PM

Tue, Apr 3

sbruno added a comment to D14952: Add etdump for dumping El Torito boot catalog information.

Minor man page review.

Tue, Apr 3, 8:47 PM

Fri, Mar 30

sbruno committed rP465985: games/cockatrice: Update to 2.5.0 release..
games/cockatrice: Update to 2.5.0 release.
Fri, Mar 30, 5:02 PM

Thu, Mar 29

sbruno added a member for committers: ericbsd.
Thu, Mar 29, 4:57 PM

Tue, Mar 27

sbruno added a comment to D14514: Microsemi smartpqi SCSI driver for PQI controllers.

I've added a bunch of review comments. Nothing super major.

Tue, Mar 27, 3:21 PM

Mon, Mar 26

sbruno committed rS331567: CC Cubic: fix underflow for cubic_cwnd().
CC Cubic: fix underflow for cubic_cwnd()
Mon, Mar 26, 7:54 PM
sbruno closed D14141: fix underflow for cubic_cwnd().
Mon, Mar 26, 7:54 PM

Fri, Mar 23

sbruno committed rS331454: Revert r331379 as the "simple" lock changes have revealed a deeper problem.
Revert r331379 as the "simple" lock changes have revealed a deeper problem
Fri, Mar 23, 6:34 PM

Thu, Mar 22

sbruno accepted D14621: fix memory management for fetching options in ip_ctloutput().
Thu, Mar 22, 11:37 PM
sbruno accepted D14623: fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl().
Thu, Mar 22, 11:37 PM
sbruno accepted D14141: fix underflow for cubic_cwnd().
Thu, Mar 22, 11:37 PM
sbruno committed rS331380: Refactor ip6_getpcbopt() for better locking and memory management.
Refactor ip6_getpcbopt() for better locking and memory management
Thu, Mar 22, 11:35 PM
sbruno closed D14619: refactor ip6_getpcbopt() for better locking and memory management.
Thu, Mar 22, 11:35 PM
sbruno committed rS331379: Simple locking fixes in ip_ctloutput, ip6_ctloutput, rip_ctloutput..
Simple locking fixes in ip_ctloutput, ip6_ctloutput, rip_ctloutput.
Thu, Mar 22, 10:30 PM
sbruno closed D14624: simple locking fixes in ip_ctloutput, ip6_ctloutput, rip_ctloutput.
Thu, Mar 22, 10:29 PM
sbruno closed D14622: handle locking and memory safety for IPV6_PATHMTU in ip6_ctloutput().
Thu, Mar 22, 9:19 PM
sbruno committed rS331376: Handle locking and memory safety for IPV6_PATHMTU in ip6_ctloutput()..
Handle locking and memory safety for IPV6_PATHMTU in ip6_ctloutput().
Thu, Mar 22, 9:18 PM
sbruno committed rS331373: Improve write locking in ip6_ctloutput() with macros..
Improve write locking in ip6_ctloutput() with macros.
Thu, Mar 22, 8:21 PM
sbruno closed D14620: improve write locking in ip6_ctloutput() with macros.
Thu, Mar 22, 8:21 PM

Mar 20 2018

sbruno requested changes to D14621: fix memory management for fetching options in ip_ctloutput().
Mar 20 2018, 5:37 PM
sbruno committed rS331249: MFC r330675.
MFC r330675
Mar 20 2018, 5:27 PM

Mar 14 2018

sbruno committed rP464504: sysutils/devcpu-data.
sysutils/devcpu-data
Mar 14 2018, 3:33 PM
sbruno closed D14686: sysutils/devcpu-data: Update to Intel release 20180312.
Mar 14 2018, 3:33 PM

Mar 13 2018

sbruno added a comment to D14686: sysutils/devcpu-data: Update to Intel release 20180312.
In D14686#308545, @imp wrote:

Love it.
However, %%DATADIR%%/mef406f1_0b000021.fw is listed there, but I have a 2a version in my tree from Intel. Can you confirm that this is the latest version in what's released? The 2a version may be pre-release still.
Otherwise, all the files I care about for $WORK match the latest that we have.

Mar 13 2018, 9:56 PM
sbruno updated subscribers of D14686: sysutils/devcpu-data: Update to Intel release 20180312.
Mar 13 2018, 8:52 PM
sbruno added a reviewer for D14686: sysutils/devcpu-data: Update to Intel release 20180312: imp.
Mar 13 2018, 8:51 PM
sbruno updated the summary of D14686: sysutils/devcpu-data: Update to Intel release 20180312.
Mar 13 2018, 8:50 PM
sbruno created D14686: sysutils/devcpu-data: Update to Intel release 20180312.
Mar 13 2018, 8:49 PM

Mar 9 2018

sbruno committed rS330675: Update tcp_lro with tested bugfixes from Netflix and LLNW:.
Update tcp_lro with tested bugfixes from Netflix and LLNW:
Mar 9 2018, 12:08 AM
sbruno closed D14540: Several LRO fixes.
Mar 9 2018, 12:08 AM · transport

Mar 8 2018

sbruno accepted D14540: Several LRO fixes.

I'll grab this and shovel it in after builds are done.

Mar 8 2018, 6:25 PM · transport
sbruno accepted D14619: refactor ip6_getpcbopt() for better locking and memory management.
Mar 8 2018, 5:16 PM
sbruno accepted D14620: improve write locking in ip6_ctloutput() with macros.
Mar 8 2018, 5:15 PM
sbruno accepted D14621: fix memory management for fetching options in ip_ctloutput().
Mar 8 2018, 5:14 PM
sbruno accepted D14622: handle locking and memory safety for IPV6_PATHMTU in ip6_ctloutput().
Mar 8 2018, 5:13 PM
sbruno accepted D14623: fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl().
Mar 8 2018, 5:13 PM
sbruno accepted D14624: simple locking fixes in ip_ctloutput, ip6_ctloutput, rip_ctloutput.
Mar 8 2018, 5:11 PM

Feb 15 2018

sbruno accepted D14389: libsa: Add MAXWAIT to net for establishing max total timeout.

After *READING* the review, I tested with a MAXWAIT of 20 and this works as advertised.

Feb 15 2018, 10:08 PM
sbruno requested changes to D14389: libsa: Add MAXWAIT to net for establishing max total timeout.

Hmmm ... I'm up to five minutes waiting for a timeout here and I don't even see the twiddle moving.

Feb 15 2018, 9:53 PM
sbruno accepted D14373: libsa: Consolidate tftp sendrecv into net.c sendrecv.

stlgtm

Feb 15 2018, 6:26 PM

Feb 14 2018

sbruno requested changes to D14373: libsa: Consolidate tftp sendrecv into net.c sendrecv.

Quick and dirty assessment: BTX panics. :-( More review to come.

Feb 14 2018, 10:18 PM

Feb 13 2018

sbruno accepted D14350: libsa: Fix IP recv timeout.

BINGO

Feb 13 2018, 9:56 PM
sbruno requested changes to D14350: libsa: Fix IP recv timeout.

Ugh, phab seems to have not take the diffs from the root of the src tree. I'll munge a bit, but can you regenerate?

Feb 13 2018, 8:53 PM
sbruno abandoned D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.

Heh, sorry, I ended up creating another review with a different version of that patch: https://reviews.freebsd.org/D14350 -- it turned out there was also a case over in net.c that needed fixing, and we have some timing weirdness happening in the tftp bits to go with it.

Feb 13 2018, 8:51 PM
sbruno retitled D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT from libsa: Allow a tftp retry if a sendrecv returns EAGAIN to libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Feb 13 2018, 8:47 PM
sbruno updated the diff for D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.

Use @kevans version of the patch from private email. Add a debug statement so
I can detect the ETIMEDOUT condition, which does get hit and resumes TFTP without
failing.

Feb 13 2018, 8:45 PM

Feb 12 2018

sbruno added inline comments to D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Feb 12 2018, 6:28 PM
sbruno updated subscribers of D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Feb 12 2018, 6:27 PM
sbruno updated the summary of D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Feb 12 2018, 6:26 PM
sbruno created D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.
Feb 12 2018, 6:25 PM

Feb 1 2018

sbruno committed rP460635: emulators/qemu-sbruno add missing files to pkg-plist.
emulators/qemu-sbruno add missing files to pkg-plist
Feb 1 2018, 9:06 PM
sbruno committed rP460605: audio/clementine-player: Fixup build breakage after clang 6 update..
audio/clementine-player: Fixup build breakage after clang 6 update.
Feb 1 2018, 2:54 PM

Jan 31 2018

sbruno committed rP460499: Fix nullptr definition buildfailure on current with clang6.
Fix nullptr definition buildfailure on current with clang6
Jan 31 2018, 4:38 PM
sbruno closed D14131: Correct check for nullptr to fix build with clang 6..
Jan 31 2018, 4:38 PM
sbruno accepted D14131: Correct check for nullptr to fix build with clang 6..
Jan 31 2018, 4:33 PM

Jan 30 2018

sbruno committed rS328603: Add missing non-POWERPC case to give the scr value something non-zero..
Add missing non-POWERPC case to give the scr value something non-zero.
Jan 30 2018, 8:00 PM
sbruno added a comment to D14131: Correct check for nullptr to fix build with clang 6..

I'll run this through my local meat grinder and approve/commit after. THANKS

Jan 30 2018, 6:25 PM

Jan 26 2018

sbruno added a comment to D13885: ixgbe(4): Update shared code, add support for X552, fix bug.

Unrelated, is there a use case for FreeBSD Bhyve here? If we had PF support on FreeBSD, could we use pass through to use VFs?

Jan 26 2018, 5:20 PM

Jan 19 2018

sbruno committed rP459464: sysutils/devcpu-data: Revert back to legacy microcode.dat implementation..
sysutils/devcpu-data: Revert back to legacy microcode.dat implementation.
Jan 19 2018, 7:28 PM
sbruno closed D13987: sysutils/devcpu-data: Revert back to legacy microcode.dat implementation.
Jan 19 2018, 7:28 PM
sbruno updated the summary of D13987: sysutils/devcpu-data: Revert back to legacy microcode.dat implementation.
Jan 19 2018, 6:24 PM
sbruno created D13987: sysutils/devcpu-data: Revert back to legacy microcode.dat implementation.
Jan 19 2018, 6:23 PM
sbruno accepted D13982: bnxt: Update man page with newly supported devices, options, ect.
Jan 19 2018, 6:02 PM
sbruno abandoned D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..

I will be reverting back to the ucode-tool in the next revision. There is definitely an issue with cpucontrol iterating though an intel microcode file with multiple updates.

Jan 19 2018, 5:45 PM

Jan 17 2018

sbruno added inline comments to D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Jan 17 2018, 10:30 PM
sbruno retitled D13958: sysutils/devcpu-data: Restore one "legacy" microcode update. from sysutils/devcpu-data: Restore one "legacy" micrcodoe update. to sysutils/devcpu-data: Restore one "legacy" microcode update..
Jan 17 2018, 8:16 PM
sbruno added a comment to D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..

It sure looks like there is a problem here.

Jan 17 2018, 8:16 PM
sbruno updated the summary of D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Jan 17 2018, 8:14 PM
sbruno created D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Jan 17 2018, 8:13 PM
sbruno committed rP459266: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated….
sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated…
Jan 17 2018, 4:04 PM
sbruno closed D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Jan 17 2018, 4:04 PM

Jan 16 2018

sbruno committed rP459205: Revert Intel URL to the correct location for microcode-20171117.tgz.
Revert Intel URL to the correct location for microcode-20171117.tgz
Jan 16 2018, 7:56 PM
sbruno accepted D13885: ixgbe(4): Update shared code, add support for X552, fix bug.

Let me know if you need me to commit this.

Jan 16 2018, 1:56 PM

Jan 15 2018

sbruno added inline comments to D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Jan 15 2018, 8:00 PM
sbruno added a comment to D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..

Surprisingly, this seems to work for us.

Jan 15 2018, 5:43 PM
sbruno created D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Jan 15 2018, 5:42 PM

Jan 14 2018

sbruno committed rP458987: sysutils/devcpu-data: Only run "cpucontrol -e" once..
sysutils/devcpu-data: Only run "cpucontrol -e" once.
Jan 14 2018, 6:28 PM

Jan 13 2018

sbruno committed rP458943: sysutils/devcpu-data: Update AMD microcode, add cpu 17h microcode,.
sysutils/devcpu-data: Update AMD microcode, add cpu 17h microcode,
Jan 13 2018, 9:36 PM
sbruno closed D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
Jan 13 2018, 9:36 PM
sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
In D13832#290897, @cem wrote:

Your CPU, "family 0xf model 0xb stepping 0x2 extfamily 0 extmodel 0x6" should be 0x60fb2 -- which, yeah, isn't one of 0x600f20, 0x610f01, or 0x600f12. So this microcode file doesn't have an update for your CPU, as I understand it.

I am not sure whether you are correct in this assumption.
The name mangling that is done by ucode-tool is bad and confusing. Imho ucode-tool should be retired, as it is legacy stuff, and the vendor-supplied binary files be used instead for more consistency.
I have done a write-up about this topic on the FreeBSD forums here, where I analyze why the microcode_update thing seems to be broken due to a fundamentally wrong approach.

Jan 13 2018, 9:28 PM

Jan 11 2018

sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

This works for my FX-8150:

Jan 11 2018, 9:43 PM
sbruno updated the diff for D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Update after Intel microcode revert

Jan 11 2018, 9:41 PM
sbruno committed rP458792: Revert to previous Intel microcode archive (20171117)..
Revert to previous Intel microcode archive (20171117).
Jan 11 2018, 8:45 PM