- User Since
- May 26 2014, 3:41 PM (182 w, 4 d)
Address review comments
This code block also needs an adjustment to "something" as we have no need to add these to this target's build in the GCC case.
Thu, Nov 23
Thu, Nov 16
Yep, looks good. Thanks!
Wed, Nov 15
What I take away from the conversation in this review is that the solution being proposed does what its supposed to do, and there is even more room for improvement.
Tue, Nov 14
Builds. Untested at this time.
Odd, I get a wierd chmod error on FreeBSD 10 when building this port. On 11/12 it builds fine:
Mon, Nov 13
@olivier Can you post the sysctl/loader.conf settings you are using from both iterations of the test?
@olivier So a decrease of ~33% with IFLIB?
Fri, Nov 10
bump. What's the plan here?
bump. What's up here?
Thu, Nov 9
Tue, Nov 7
Sat, Nov 4
Tue, Oct 31
Found while testing the iflib'd version of ixgbe(4).
Ok, my report is due to the test systems disabling AIM in sysctl.conf.
I found pretty bad behavior with LRO enabled on this change.
Mon, Oct 30
This looks good to me. Can you verify that this is merged into the ixgbe(4) IFLIB review as well?
Oct 25 2017
Ran iperf3 test between two hosts booted into i386 and all seems to be well.
Oct 24 2017
Oct 23 2017
Oct 20 2017
Oct 12 2017
Oct 10 2017
Oct 9 2017
This seems pretty reasonable to me. Any objections? Can I get a transport@ review accept on this?
Oct 7 2017
Oct 5 2017
Oct 2 2017
Does this version work on 32bit FreeBSD? Or are you waiting for us to review/commit the 32bit support review?
Sep 28 2017
The issues I was running into seem to be related to my attempts to use the old way/old documentation. I can tftp a kernel/ramdisk with the default options.
Sep 27 2017
Huh ... I saw this review and noted that its still open. Is this still under evaluation?
I suspect this review needs to have stephen's comments addressed.
Ok, lets rename prefetch2() to something that indicates why there is a second function (being a bit pedantic here). something like prefetch_align() or whatever.
Sep 23 2017
Sep 22 2017
I went back to the man page, just to validate. I used the example from the man page after rebuilding pxeboot with *defaults*. It defintely does not TFTP in this case.
Did microsoft update the referenced link? I don't see the removal notice in it.
Is there a reason that we don't modify prefetch() instead of creating a new prefetch2() function?