sbruno (Sean Bruno)
User

Projects (6)

User Details

User Since
May 26 2014, 3:41 PM (216 w, 58 m)

Recent Activity

Sat, Jul 14

sbruno committed rS336298: There was quite a bit of feedback on r336282 that has led to the.
There was quite a bit of feedback on r336282 that has led to the
Sat, Jul 14, 11:54 PM
sbruno reopened D14621: Fix a potential use after free in getsockopt() access to inp_options.

Reopen at the request of submitter.

Sat, Jul 14, 11:51 PM
sbruno resigned from D13023: Bring www/madsonic-standalone to www/libresonic-standalone's standards..
Sat, Jul 14, 4:21 PM
sbruno resigned from D13040: Bring www/subsonic-standalone to www/libresonic-standalone's standards..
Sat, Jul 14, 4:21 PM
sbruno closed D14621: Fix a potential use after free in getsockopt() access to inp_options.
Sat, Jul 14, 4:20 PM
sbruno committed rS336282: Fixup memory management for fetching options in ip_ctloutput().
Fixup memory management for fetching options in ip_ctloutput()
Sat, Jul 14, 4:20 PM
sbruno accepted D16259: Fix vnic fallback PHY name matching after r334880..

This works for us in the FreeBSD cluster. Thanks!

Sat, Jul 14, 3:44 PM

Fri, Jul 13

sbruno added a comment to D16259: Fix vnic fallback PHY name matching after r334880..

Let me do a quick test on the cluster ThunderX1 machine.

Fri, Jul 13, 7:17 PM

Wed, Jul 11

sbruno committed rS336201: smartpqi(4):.
smartpqi(4):
Wed, Jul 11, 4:44 PM
sbruno closed D16060: Maintenance's commit of Microsemi smartpqi driver.
Wed, Jul 11, 4:44 PM · Src Committers
sbruno accepted D16060: Maintenance's commit of Microsemi smartpqi driver.
Wed, Jul 11, 4:42 PM · Src Committers
sbruno created D16226: [MIPS]: reap unused struct proc *p1;.
Wed, Jul 11, 4:24 PM
sbruno committed rP474447: sysutils/devcpu-data:.
sysutils/devcpu-data:
Wed, Jul 11, 2:00 PM
sbruno closed D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.
Wed, Jul 11, 2:00 PM

Tue, Jul 10

sbruno accepted D16201: acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic.
Tue, Jul 10, 11:24 PM
sbruno added a comment to D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.

From the release notes and will be in the commit log:

Tue, Jul 10, 8:41 PM
sbruno updated the diff for D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.

0.o Remove the other directories from this review.

Tue, Jul 10, 8:39 PM
sbruno created D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.
Tue, Jul 10, 8:38 PM
sbruno added inline comments to D16169: Rework sys/modules/Makefile to improve arch and option filtering..
Tue, Jul 10, 4:50 PM

Sun, Jul 8

sbruno added a comment to D16164: Make options IFLIB a real configuration option..
In D16164#342962, @cem wrote:
In D16164#342951, @erj wrote:

can iflib.ko be created and then the driver modules depend on that?

That would be really nice. :-P

Driver modules already can and do depend on iflib, without forcing it to be a kld object (.ko) — grep for MODULE_DEPEND(..., iflib, ...).

If the idea is pulling iflib out of the kernel just for space savings, I'm not sure that really makes sense on any platform that supports iflib drivers anyway (i.e., non-embedded).

Please do add the IFLIB option to most/all GENERICs simultaneously with this change, though.

Sun, Jul 8, 2:57 PM

Sat, Jul 7

sbruno added a comment to D16164: Make options IFLIB a real configuration option..

Does this not also make it so that these drivers require IFLIB, so they need to be marked as such in GENERIC/NOTES/etc and man pages?

Sat, Jul 7, 4:44 PM
sbruno added a reviewer for D16164: Make options IFLIB a real configuration option.: rgrimes.
Sat, Jul 7, 1:41 PM
sbruno accepted D14802: fix malloc length in ip6_output.c:GET_PKTOPT_VAR.
Sat, Jul 7, 1:38 PM
sbruno closed D16113: sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMA.
Sat, Jul 7, 1:38 PM
sbruno committed rS336063: Wrap the declaration and assignment of "stripe" with #ifdef NUMA declarations.
Wrap the declaration and assignment of "stripe" with #ifdef NUMA declarations
Sat, Jul 7, 1:38 PM
sbruno closed D16063: sys/net/if.c -- move compat32 variable into #ifdef.
Sat, Jul 7, 1:35 PM
sbruno committed rS336062: struct ifmediareq *ifmrp is only used in the COMPAT_FREEBSD32 parts of.
struct ifmediareq *ifmrp is only used in the COMPAT_FREEBSD32 parts of
Sat, Jul 7, 1:35 PM

Fri, Jul 6

sbruno created D16164: Make options IFLIB a real configuration option..
Fri, Jul 6, 1:46 PM
sbruno committed rS336032: Remove duplicate configuration values as they are already defined in.
Remove duplicate configuration values as they are already defined in
Fri, Jul 6, 1:31 PM
sbruno committed rS336031: r336028 changed next_msg to a char * from char [] of fixed size. Change.
r336028 changed next_msg to a char * from char [] of fixed size. Change
Fri, Jul 6, 1:23 PM

Thu, Jul 5

sbruno closed D16114: sys/riscv/riscv/machdep.c: Remove unused variable "code".
Thu, Jul 5, 5:26 PM
sbruno committed rS336009: riscv: Remove unused variable "code".
riscv: Remove unused variable "code"
Thu, Jul 5, 5:26 PM
sbruno committed rS336006: Remove redundant device ar71xx_wdog which is now included from.
Remove redundant device ar71xx_wdog which is now included from
Thu, Jul 5, 5:12 PM
sbruno committed rS336005: Remove redundant AH_DEBUG_ALQ..
Remove redundant AH_DEBUG_ALQ.
Thu, Jul 5, 5:10 PM
sbruno committed rS336004: Make ZSTD a real option via ZSTDIO..
Make ZSTD a real option via ZSTDIO.
Thu, Jul 5, 5:07 PM
sbruno closed D16007: Make ZSTD optional via options ZSTDIO..
Thu, Jul 5, 5:07 PM

Wed, Jul 4

sbruno abandoned D15326: Stop using non ctype.h versions of toupper().
Wed, Jul 4, 5:19 PM
sbruno committed rS335963: WITHOUT_SERVICESDB:.
WITHOUT_SERVICESDB:
Wed, Jul 4, 5:18 PM
sbruno closed D9655: Add src.conf knob to disable the installation of /var/db/services.db.
Wed, Jul 4, 5:18 PM
sbruno closed D14623: fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl().
Wed, Jul 4, 5:10 PM
sbruno committed rS335962: fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl().
fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl()
Wed, Jul 4, 5:10 PM

Tue, Jul 3

sbruno added reviewers for D16063: sys/net/if.c -- move compat32 variable into #ifdef: mmacy, jtl.
Tue, Jul 3, 7:05 PM
sbruno committed rS335896: Reset indentiation of ata_suspend() such that its clear we fall through.
Reset indentiation of ata_suspend() such that its clear we fall through
Tue, Jul 3, 4:18 PM
sbruno created D16114: sys/riscv/riscv/machdep.c: Remove unused variable "code".
Tue, Jul 3, 4:15 PM
sbruno added a comment to D16113: sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMA.
/home/sbruno/bsd/fbsd_head/sys/vm/uma_core.c: In function 'zone_import':
/home/sbruno/bsd/fbsd_head/sys/vm/uma_core.c:2774:6: warning: variable 'stripe' set but not used [-Wunused-but-set-variable]
  int stripe;
Tue, Jul 3, 4:12 PM
sbruno created D16113: sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMA.
Tue, Jul 3, 4:12 PM
sbruno added reviewers for D16060: Maintenance's commit of Microsemi smartpqi driver: scottl, mav.
Tue, Jul 3, 3:57 PM · Src Committers
sbruno committed rS335894: Reset indentation of this flag. No functional change intended..
Reset indentation of this flag. No functional change intended.
Tue, Jul 3, 3:56 PM

Fri, Jun 29

sbruno added reviewers for D16007: Make ZSTD optional via options ZSTDIO.: br, emaste.
Fri, Jun 29, 3:27 PM
sbruno updated the diff for D16007: Make ZSTD optional via options ZSTDIO..

Add riscv and mips configurations to keep ZSTDIO building for
the GENERIC target and MALTA targets (std.MALTA).

Fri, Jun 29, 3:26 PM
sbruno created D16063: sys/net/if.c -- move compat32 variable into #ifdef.
Fri, Jun 29, 3:16 PM

Thu, Jun 28

sbruno accepted D14621: Fix a potential use after free in getsockopt() access to inp_options.
Thu, Jun 28, 1:30 AM

Tue, Jun 26

sbruno accepted D16021: Clang: Only build needed target for bootstrap compiler..
Tue, Jun 26, 7:19 PM
sbruno accepted D16020: Add LLVM_TARGET_ALL option..
Tue, Jun 26, 7:19 PM
sbruno accepted D16018: Use dependent options to auto enable _SUPPORT and CLANG_FULL options..
Tue, Jun 26, 7:18 PM
sbruno added a comment to D16025: Fix misspellings of transmit, transmitter, and transmitted.

Hrm. Phabricator seems to think there's no context for your diff here. What's that all about?

Tue, Jun 26, 7:17 PM

Mon, Jun 25

sbruno added a comment to D11124: ZSTD compression for ZFS.

I was just looking at making ZSTD a compile option via ZSTDIO here https://reviews.freebsd.org/D16007

Mon, Jun 25, 6:30 PM
sbruno added a comment to D16007: Make ZSTD optional via options ZSTDIO..
In D16007#338923, @cem wrote:

Maybe I just don't see it. What's the relationship between ZFS and ZSTD?

ZFS supports compressing file data. One algorithm it can use is Zstd.

Edit: https://reviews.freebsd.org/D11124 — I guess it's not in OpenZFS nor FreeBSD yet.

Mon, Jun 25, 6:18 PM
sbruno added a comment to D16007: Make ZSTD optional via options ZSTDIO..

Doesn't it also need to be conditional on ZFS support?

Mon, Jun 25, 5:58 PM
sbruno added a comment to D16007: Make ZSTD optional via options ZSTDIO..

Doesn't it also need to be conditional on ZFS support?

Mon, Jun 25, 2:27 PM
sbruno created D16007: Make ZSTD optional via options ZSTDIO..
Mon, Jun 25, 1:22 PM

Sun, Jun 24

sbruno committed rS335610: Enable TCP_FASTOPEN by default for FreeBSD 12..
Enable TCP_FASTOPEN by default for FreeBSD 12.
Sun, Jun 24, 9:47 PM
sbruno closed D15959: Enable TFO client support by default.
Sun, Jun 24, 9:47 PM
sbruno committed rS335609: Reap unused variable and assignment that had no effect. Noted by cross.
Reap unused variable and assignment that had no effect. Noted by cross
Sun, Jun 24, 9:36 PM
sbruno committed rS335608: Assuming that the intent (from the white space) is that the fprintf().
Assuming that the intent (from the white space) is that the fprintf()
Sun, Jun 24, 9:19 PM
sbruno accepted D15959: Enable TFO client support by default.
Sun, Jun 24, 1:55 PM

Sat, Jun 23

sbruno committed rP473103: qemu-user-static update:.
qemu-user-static update:
Sat, Jun 23, 12:02 AM

Thu, Jun 21

sbruno added a comment to D14279: fixed amd type flash write opration and diaplay chip infomation at boot.

I will compile commit this review.

Thu, Jun 21, 4:04 PM
sbruno accepted D14279: fixed amd type flash write opration and diaplay chip infomation at boot.
Thu, Jun 21, 4:03 PM
sbruno accepted D15804: Keep --forward when using PATCH_DEBUG..
Thu, Jun 21, 1:24 PM

Wed, Jun 20

sbruno accepted D15927: Update ixl(4) man page.
Wed, Jun 20, 6:05 PM

Tue, Jun 19

sbruno added a comment to D10052: sparc64 EARLY_AP_STARTUP.

Hrm ... this patch seems like abandon ware to me. Is it still relevant?

Tue, Jun 19, 9:17 PM
sbruno added a comment to D1305: Add Xfce FAQ in htdocs/ directory.

bump. @olivierd Do you intend to commit this or do you need a doc committer to finish this off?

Tue, Jun 19, 9:16 PM
sbruno updated subscribers of D7350: PMC: Collect user call chains while in kernel space.

@jtl Can you close this as it appears @mmacy committed functionally the same thing? Or is there work yet to be done here?

Tue, Jun 19, 9:14 PM
sbruno added a comment to D15560: Use a spin lock to serialize updates on AMD CPUs..

bump. @markj Did you want to shovel this into head?

Tue, Jun 19, 9:12 PM
sbruno accepted D9655: Add src.conf knob to disable the installation of /var/db/services.db.

Heh, I can accept my own revision. :-)

Tue, Jun 19, 9:09 PM
sbruno committed rS335386: MK_EFI - Add uefisign and friends to this knob and ensure that we don't.
MK_EFI - Add uefisign and friends to this knob and ensure that we don't
Tue, Jun 19, 9:07 PM
sbruno closed D15211: Add uefisign and friends to MK_EFI.
Tue, Jun 19, 9:07 PM
sbruno added reviewers for D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4): erj, mmacy.
Tue, Jun 19, 9:04 PM
sbruno committed rS335379: Set prev to NULL so its garaunteed to have a value of some kind and.
Set prev to NULL so its garaunteed to have a value of some kind and
Tue, Jun 19, 6:09 PM
sbruno committed rS335372: Remove "diff" line indicator. Next to see if this code works or not..
Remove "diff" line indicator. Next to see if this code works or not.
Tue, Jun 19, 3:55 PM

Jun 12 2018

sbruno accepted D15727: Quiet coretemp probe.
Jun 12 2018, 7:46 PM
sbruno updated the diff for D9655: Add src.conf knob to disable the installation of /var/db/services.db.

After building the src.conf man page, update the WITHOUT_SERVICESDB entry to
generate something that looks more sensible.

Jun 12 2018, 7:43 PM
sbruno committed rS335011: WITHOUT_NLS cleanup of more empty dirs..
WITHOUT_NLS cleanup of more empty dirs.
Jun 12 2018, 7:26 PM
sbruno closed D15626: WITHOUT_NLS cleanup of more empty dirs.
Jun 12 2018, 7:26 PM
sbruno committed rS335010: cpucontrol:.
cpucontrol:
Jun 12 2018, 6:59 PM
sbruno closed D15574: cpucontrol: fix debugging for family on AMD cpus and add useful debugging..
Jun 12 2018, 6:59 PM
sbruno updated the diff for D15211: Add uefisign and friends to MK_EFI.

Sort by alpha as per @emaste.

Jun 12 2018, 6:56 PM
sbruno accepted D15754: Fix build of liquidio with base gcc on i386.

stlgtm

Jun 12 2018, 3:42 PM

Jun 9 2018

sbruno accepted D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

Adding my "ok" pending bnxt review by @shurd

Jun 9 2018, 9:25 PM

Jun 7 2018

sbruno committed rS334788: Unbreak dtrace runtime for udp after svn r334719 SO_REUSEPORT commit..
Unbreak dtrace runtime for udp after svn r334719 SO_REUSEPORT commit.
Jun 7 2018, 3:27 PM

Jun 6 2018

sbruno closed D11003: Load balance sockets with new SO_REUSEPORT_LB option.
Jun 6 2018, 3:46 PM
sbruno committed rS334719: Load balance sockets with new SO_REUSEPORT_LB option..
Load balance sockets with new SO_REUSEPORT_LB option.
Jun 6 2018, 3:46 PM

Jun 1 2018

sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.
 root@lab:/home/sbruno/bsd/fbsd_head # env | grep SRCCONF
 SRCCONF=/home/sbruno/bsd/src.conf.efitest
 root@lab:/home/sbruno/bsd/fbsd_head # cat ${SRCCONF}
 WTTHOUT_EFI="YES"
 root@lab:/home/sbruno/bsd/fbsd_head # make delete-old DESTDIR=/tftpboot/netboot
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
>>> Old directories removed
 To remove old libraries run 'make delete-old-libs'.
 root@lab:/home/sbruno/bsd/fbsd_head # make delete-old MK_EFI=no DESTDIR=/tftpboot/netboot                                                                                                                                                    
>>> Removing old files (only deletes safe to delete libs)
 remove /tftpboot/netboot/usr/sbin/efibootmgr?
Jun 1 2018, 8:44 PM
sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.

Is setting it in the environment expected to work? What about make SRCCONF=/foo/bar/baz ...?

Jun 1 2018, 2:06 PM
sbruno updated the diff for D15211: Add uefisign and friends to MK_EFI.

Don't nuke *all* the efi tools if OPENSSL isn't installed. (imp)

Jun 1 2018, 2:06 PM

May 31 2018

sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.

hrm ... WITH_EFI="NO" has zero effect as well. So, I'm stumped.

May 31 2018, 6:58 PM
sbruno accepted D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Pending no further review comments, this will go in the tree on Monday, May 31. That way folks can yell at me when we all get together in Ottawa.

May 31 2018, 6:31 PM
sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.
root@lab:/home/sbruno/bsd/fbsd_head # env | grep SRCCONF
SRCCONF=/home/sbruno/bsd/src.conf.efitest
root@lab:/home/sbruno/bsd/fbsd_head # cat ${SRCCONF}
WTTHOUT_EFI="YES"
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old DESTDIR=/tftpboot/netboot
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old MK_EFI=no DESTDIR=/tftpboot/netboot                                                                                                                                                    
>>> Removing old files (only deletes safe to delete libs)
remove /tftpboot/netboot/usr/sbin/efibootmgr?
May 31 2018, 6:20 PM
sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.

WITHOUT_EFI="YES" seems to do nothing.

May 31 2018, 6:17 PM