Page MenuHomeFreeBSD

sbruno (Sean Bruno)
User

Projects (6)

User Details

User Since
May 26 2014, 3:41 PM (225 w, 1 d)

Recent Activity

Yesterday

sbruno added a reviewer for D17230: Update udp6_output() inp locking to avoid concurrency issues with route cache updates: rstone.
Tue, Sep 18, 10:32 PM

Fri, Sep 14

sbruno accepted D16808: fix vlan locking to permit sx acquisition in ioctl calls.
Fri, Sep 14, 1:48 PM

Thu, Sep 6

sbruno accepted D17031: Fix synchronization of lbgroup access..
Thu, Sep 6, 3:27 PM

Mon, Aug 27

sbruno accepted D16924: devcpu-data: Provide a file for loading at boot time.
Mon, Aug 27, 9:37 PM
sbruno accepted D16924: devcpu-data: Provide a file for loading at boot time.

Can you bump PORTVERSION when you commit this?

Mon, Aug 27, 8:49 PM

Sun, Aug 26

sbruno committed rS338330: r338270 had the side effect of no longer installing libmd.so into /lib..
r338270 had the side effect of no longer installing libmd.so into /lib.
Sun, Aug 26, 5:06 PM
sbruno closed D16910: libmd: Install libmd.so.6 into /lib again after SVN r338270.
Sun, Aug 26, 5:06 PM

Sat, Aug 25

sbruno accepted D16899: SO_REUSEPORT_LB critical bug fix: avoid IPv4 listen group in IPv6.
Sat, Aug 25, 4:46 PM

Aug 12 2018

sbruno abandoned D11958: usr.bin/mandoc build warning/error fixes.
Aug 12 2018, 3:47 PM
sbruno commandeered D11958: usr.bin/mandoc build warning/error fixes.

A new release of mandoc was posted last week, is this still valid?

Aug 12 2018, 3:47 PM

Aug 8 2018

sbruno accepted D16633: [powerpc] Fix kernel panic when using "options BOOTP_NFSROOT".
Aug 8 2018, 8:24 PM
sbruno committed rP476664: sysutils/devcpu-data:.
sysutils/devcpu-data:
Aug 8 2018, 7:29 PM

Jul 31 2018

sbruno added a reviewer for D16534: e1000: Don't use 9k jumbo clusters: Intel Networking.
Jul 31 2018, 8:30 PM

Jul 25 2018

sbruno accepted D16428: iflib: Changes for ixlv(4) update.
Jul 25 2018, 6:16 PM · Intel Networking

Jul 24 2018

sbruno committed rP475259: games/cockatrice: Update to release 2.6.1.
games/cockatrice: Update to release 2.6.1
Jul 24 2018, 3:01 PM

Jul 14 2018

sbruno committed rS336298: There was quite a bit of feedback on r336282 that has led to the.
There was quite a bit of feedback on r336282 that has led to the
Jul 14 2018, 11:54 PM
sbruno reopened D14621: Fix a potential use after free in getsockopt() access to inp_options.

Reopen at the request of submitter.

Jul 14 2018, 11:51 PM
sbruno resigned from D13023: Bring www/madsonic-standalone to www/libresonic-standalone's standards..
Jul 14 2018, 4:21 PM
sbruno resigned from D13040: Bring www/subsonic-standalone to www/libresonic-standalone's standards..
Jul 14 2018, 4:21 PM
sbruno closed D14621: Fix a potential use after free in getsockopt() access to inp_options.
Jul 14 2018, 4:20 PM
sbruno committed rS336282: Fixup memory management for fetching options in ip_ctloutput().
Fixup memory management for fetching options in ip_ctloutput()
Jul 14 2018, 4:20 PM
sbruno accepted D16259: Fix vnic fallback PHY name matching after r334880..

This works for us in the FreeBSD cluster. Thanks!

Jul 14 2018, 3:44 PM

Jul 13 2018

sbruno added a comment to D16259: Fix vnic fallback PHY name matching after r334880..

Let me do a quick test on the cluster ThunderX1 machine.

Jul 13 2018, 7:17 PM

Jul 11 2018

sbruno committed rS336201: smartpqi(4):.
smartpqi(4):
Jul 11 2018, 4:44 PM
sbruno closed D16060: Maintenance's commit of Microsemi smartpqi driver.
Jul 11 2018, 4:44 PM · Src Committers
sbruno accepted D16060: Maintenance's commit of Microsemi smartpqi driver.
Jul 11 2018, 4:42 PM · Src Committers
sbruno created D16226: [MIPS]: reap unused struct proc *p1;.
Jul 11 2018, 4:24 PM
sbruno committed rP474447: sysutils/devcpu-data:.
sysutils/devcpu-data:
Jul 11 2018, 2:00 PM
sbruno closed D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.
Jul 11 2018, 2:00 PM

Jul 10 2018

sbruno accepted D16201: acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic.
Jul 10 2018, 11:24 PM
sbruno added a comment to D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.

From the release notes and will be in the commit log:

Jul 10 2018, 8:41 PM
sbruno updated the diff for D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.

0.o Remove the other directories from this review.

Jul 10 2018, 8:39 PM
sbruno created D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.
Jul 10 2018, 8:38 PM
sbruno added inline comments to D16169: Rework sys/modules/Makefile to improve arch and option filtering..
Jul 10 2018, 4:50 PM

Jul 8 2018

sbruno added a comment to D16164: Make options IFLIB a real configuration option..
In D16164#342962, @cem wrote:
In D16164#342951, @erj wrote:

can iflib.ko be created and then the driver modules depend on that?

That would be really nice. :-P

Driver modules already can and do depend on iflib, without forcing it to be a kld object (.ko) — grep for MODULE_DEPEND(..., iflib, ...).

If the idea is pulling iflib out of the kernel just for space savings, I'm not sure that really makes sense on any platform that supports iflib drivers anyway (i.e., non-embedded).

Please do add the IFLIB option to most/all GENERICs simultaneously with this change, though.

Jul 8 2018, 2:57 PM

Jul 7 2018

sbruno added a comment to D16164: Make options IFLIB a real configuration option..

Does this not also make it so that these drivers require IFLIB, so they need to be marked as such in GENERIC/NOTES/etc and man pages?

Jul 7 2018, 4:44 PM
sbruno added a reviewer for D16164: Make options IFLIB a real configuration option.: rgrimes.
Jul 7 2018, 1:41 PM
sbruno accepted D14802: fix malloc length in ip6_output.c:GET_PKTOPT_VAR.
Jul 7 2018, 1:38 PM
sbruno closed D16113: sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMA.
Jul 7 2018, 1:38 PM
sbruno committed rS336063: Wrap the declaration and assignment of "stripe" with #ifdef NUMA declarations.
Wrap the declaration and assignment of "stripe" with #ifdef NUMA declarations
Jul 7 2018, 1:38 PM
sbruno closed D16063: sys/net/if.c -- move compat32 variable into #ifdef.
Jul 7 2018, 1:35 PM
sbruno committed rS336062: struct ifmediareq *ifmrp is only used in the COMPAT_FREEBSD32 parts of.
struct ifmediareq *ifmrp is only used in the COMPAT_FREEBSD32 parts of
Jul 7 2018, 1:35 PM

Jul 6 2018

sbruno created D16164: Make options IFLIB a real configuration option..
Jul 6 2018, 1:46 PM
sbruno committed rS336032: Remove duplicate configuration values as they are already defined in.
Remove duplicate configuration values as they are already defined in
Jul 6 2018, 1:31 PM
sbruno committed rS336031: r336028 changed next_msg to a char * from char [] of fixed size. Change.
r336028 changed next_msg to a char * from char [] of fixed size. Change
Jul 6 2018, 1:23 PM

Jul 5 2018

sbruno closed D16114: sys/riscv/riscv/machdep.c: Remove unused variable "code".
Jul 5 2018, 5:26 PM
sbruno committed rS336009: riscv: Remove unused variable "code".
riscv: Remove unused variable "code"
Jul 5 2018, 5:26 PM
sbruno committed rS336006: Remove redundant device ar71xx_wdog which is now included from.
Remove redundant device ar71xx_wdog which is now included from
Jul 5 2018, 5:12 PM
sbruno committed rS336005: Remove redundant AH_DEBUG_ALQ..
Remove redundant AH_DEBUG_ALQ.
Jul 5 2018, 5:10 PM
sbruno committed rS336004: Make ZSTD a real option via ZSTDIO..
Make ZSTD a real option via ZSTDIO.
Jul 5 2018, 5:07 PM
sbruno closed D16007: Make ZSTD optional via options ZSTDIO..
Jul 5 2018, 5:07 PM

Jul 4 2018

sbruno abandoned D15326: Stop using non ctype.h versions of toupper().
Jul 4 2018, 5:19 PM
sbruno committed rS335963: WITHOUT_SERVICESDB:.
WITHOUT_SERVICESDB:
Jul 4 2018, 5:18 PM
sbruno closed D9655: Add src.conf knob to disable the installation of /var/db/services.db.
Jul 4 2018, 5:18 PM
sbruno closed D14623: fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl().
Jul 4 2018, 5:10 PM
sbruno committed rS335962: fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl().
fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl()
Jul 4 2018, 5:10 PM

Jul 3 2018

sbruno added reviewers for D16063: sys/net/if.c -- move compat32 variable into #ifdef: mmacy, jtl.
Jul 3 2018, 7:05 PM
sbruno committed rS335896: Reset indentiation of ata_suspend() such that its clear we fall through.
Reset indentiation of ata_suspend() such that its clear we fall through
Jul 3 2018, 4:18 PM
sbruno created D16114: sys/riscv/riscv/machdep.c: Remove unused variable "code".
Jul 3 2018, 4:15 PM
sbruno added a comment to D16113: sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMA.
/home/sbruno/bsd/fbsd_head/sys/vm/uma_core.c: In function 'zone_import':
/home/sbruno/bsd/fbsd_head/sys/vm/uma_core.c:2774:6: warning: variable 'stripe' set but not used [-Wunused-but-set-variable]
  int stripe;
Jul 3 2018, 4:12 PM
sbruno created D16113: sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMA.
Jul 3 2018, 4:12 PM
sbruno added reviewers for D16060: Maintenance's commit of Microsemi smartpqi driver: scottl, mav.
Jul 3 2018, 3:57 PM · Src Committers
sbruno committed rS335894: Reset indentation of this flag. No functional change intended..
Reset indentation of this flag. No functional change intended.
Jul 3 2018, 3:56 PM

Jun 29 2018

sbruno added reviewers for D16007: Make ZSTD optional via options ZSTDIO.: br, emaste.
Jun 29 2018, 3:27 PM
sbruno updated the diff for D16007: Make ZSTD optional via options ZSTDIO..

Add riscv and mips configurations to keep ZSTDIO building for
the GENERIC target and MALTA targets (std.MALTA).

Jun 29 2018, 3:26 PM
sbruno created D16063: sys/net/if.c -- move compat32 variable into #ifdef.
Jun 29 2018, 3:16 PM

Jun 28 2018

sbruno accepted D14621: Fix a potential use after free in getsockopt() access to inp_options.
Jun 28 2018, 1:30 AM

Jun 26 2018

sbruno accepted D16021: Clang: Only build needed target for bootstrap compiler..
Jun 26 2018, 7:19 PM
sbruno accepted D16020: Add LLVM_TARGET_ALL option..
Jun 26 2018, 7:19 PM
sbruno accepted D16018: Use dependent options to auto enable _SUPPORT and CLANG_FULL options..
Jun 26 2018, 7:18 PM
sbruno added a comment to D16025: Fix misspellings of transmit, transmitter, and transmitted.

Hrm. Phabricator seems to think there's no context for your diff here. What's that all about?

Jun 26 2018, 7:17 PM

Jun 25 2018

sbruno added a comment to D11124: ZSTD compression for ZFS.

I was just looking at making ZSTD a compile option via ZSTDIO here https://reviews.freebsd.org/D16007

Jun 25 2018, 6:30 PM
sbruno added a comment to D16007: Make ZSTD optional via options ZSTDIO..
In D16007#338923, @cem wrote:

Maybe I just don't see it. What's the relationship between ZFS and ZSTD?

ZFS supports compressing file data. One algorithm it can use is Zstd.

Edit: https://reviews.freebsd.org/D11124 — I guess it's not in OpenZFS nor FreeBSD yet.

Jun 25 2018, 6:18 PM
sbruno added a comment to D16007: Make ZSTD optional via options ZSTDIO..

Doesn't it also need to be conditional on ZFS support?

Jun 25 2018, 5:58 PM
sbruno added a comment to D16007: Make ZSTD optional via options ZSTDIO..

Doesn't it also need to be conditional on ZFS support?

Jun 25 2018, 2:27 PM
sbruno created D16007: Make ZSTD optional via options ZSTDIO..
Jun 25 2018, 1:22 PM

Jun 24 2018

sbruno committed rS335610: Enable TCP_FASTOPEN by default for FreeBSD 12..
Enable TCP_FASTOPEN by default for FreeBSD 12.
Jun 24 2018, 9:47 PM
sbruno closed D15959: Enable TFO client support by default.
Jun 24 2018, 9:47 PM
sbruno committed rS335609: Reap unused variable and assignment that had no effect. Noted by cross.
Reap unused variable and assignment that had no effect. Noted by cross
Jun 24 2018, 9:36 PM
sbruno committed rS335608: Assuming that the intent (from the white space) is that the fprintf().
Assuming that the intent (from the white space) is that the fprintf()
Jun 24 2018, 9:19 PM
sbruno accepted D15959: Enable TFO client support by default.
Jun 24 2018, 1:55 PM

Jun 23 2018

sbruno committed rP473103: qemu-user-static update:.
qemu-user-static update:
Jun 23 2018, 12:02 AM

Jun 21 2018

sbruno added a comment to D14279: fixed amd type flash write opration and diaplay chip infomation at boot.

I will compile commit this review.

Jun 21 2018, 4:04 PM
sbruno accepted D14279: fixed amd type flash write opration and diaplay chip infomation at boot.
Jun 21 2018, 4:03 PM
sbruno accepted D15804: Keep --forward when using PATCH_DEBUG..
Jun 21 2018, 1:24 PM

Jun 20 2018

sbruno accepted D15927: Update ixl(4) man page.
Jun 20 2018, 6:05 PM

Jun 19 2018

sbruno added a comment to D10052: sparc64 EARLY_AP_STARTUP.

Hrm ... this patch seems like abandon ware to me. Is it still relevant?

Jun 19 2018, 9:17 PM
sbruno added a comment to D1305: Add Xfce FAQ in htdocs/ directory.

bump. @olivierd Do you intend to commit this or do you need a doc committer to finish this off?

Jun 19 2018, 9:16 PM
sbruno updated subscribers of D7350: PMC: Collect user call chains while in kernel space.

@jtl Can you close this as it appears @mmacy committed functionally the same thing? Or is there work yet to be done here?

Jun 19 2018, 9:14 PM
sbruno added a comment to D15560: Use a spin lock to serialize updates on AMD CPUs..

bump. @markj Did you want to shovel this into head?

Jun 19 2018, 9:12 PM
sbruno accepted D9655: Add src.conf knob to disable the installation of /var/db/services.db.

Heh, I can accept my own revision. :-)

Jun 19 2018, 9:09 PM
sbruno committed rS335386: MK_EFI - Add uefisign and friends to this knob and ensure that we don't.
MK_EFI - Add uefisign and friends to this knob and ensure that we don't
Jun 19 2018, 9:07 PM
sbruno closed D15211: Add uefisign and friends to MK_EFI.
Jun 19 2018, 9:07 PM
sbruno added reviewers for D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4): erj, mmacy.
Jun 19 2018, 9:04 PM
sbruno committed rS335379: Set prev to NULL so its garaunteed to have a value of some kind and.
Set prev to NULL so its garaunteed to have a value of some kind and
Jun 19 2018, 6:09 PM
sbruno committed rS335372: Remove "diff" line indicator. Next to see if this code works or not..
Remove "diff" line indicator. Next to see if this code works or not.
Jun 19 2018, 3:55 PM

Jun 12 2018

sbruno accepted D15727: Quiet coretemp probe.
Jun 12 2018, 7:46 PM
sbruno updated the diff for D9655: Add src.conf knob to disable the installation of /var/db/services.db.

After building the src.conf man page, update the WITHOUT_SERVICESDB entry to
generate something that looks more sensible.

Jun 12 2018, 7:43 PM
sbruno committed rS335011: WITHOUT_NLS cleanup of more empty dirs..
WITHOUT_NLS cleanup of more empty dirs.
Jun 12 2018, 7:26 PM
sbruno closed D15626: WITHOUT_NLS cleanup of more empty dirs.
Jun 12 2018, 7:26 PM