Page MenuHomeFreeBSD

sbruno (Sean Bruno)
User

Projects

User Details

User Since
May 26 2014, 3:41 PM (260 w, 6 d)

Recent Activity

Tue, May 14

sbruno committed rP501672: sysutils/devcpu-data: 1.22.
sysutils/devcpu-data: 1.22
Tue, May 14, 11:30 PM
sbruno closed D20236: sysutils/devcpu-data: update to Intel github release 201900514.
Tue, May 14, 11:30 PM
sbruno retitled D20236: sysutils/devcpu-data: update to Intel github release 201900514 from sysutils/devcpu-data: update to Intel github release 201900511 to sysutils/devcpu-data: update to Intel github release 201900514.
Tue, May 14, 11:27 PM
sbruno added a comment to D20236: sysutils/devcpu-data: update to Intel github release 201900514.

I will add the following references to the commits:

Tue, May 14, 10:34 PM
sbruno retitled D20236: sysutils/devcpu-data: update to Intel github release 201900514 from sysutils/devcpu-data: update to Intel github release 20190312 to sysutils/devcpu-data: update to Intel github release 201900511.
Tue, May 14, 10:31 PM
sbruno updated the diff for D20236: sysutils/devcpu-data: update to Intel github release 201900514.

While this review was in progress, 20190511 was released. Reset to that version.

Tue, May 14, 10:31 PM
sbruno added inline comments to D20236: sysutils/devcpu-data: update to Intel github release 201900514.
Tue, May 14, 10:29 PM

Sun, May 12

sbruno added a comment to D20236: sysutils/devcpu-data: update to Intel github release 201900514.
Sun, May 12, 10:14 PM
sbruno updated the diff for D20236: sysutils/devcpu-data: update to Intel github release 201900514.

Use GH_TAGNAME a bit more thoughout the build as suggested by swills.

Sun, May 12, 10:14 PM

Sat, May 11

sbruno updated the diff for D20236: sysutils/devcpu-data: update to Intel github release 201900514.

Apparently arc doesn't use relative path by default. Delete unrelated tree changes.

Sat, May 11, 3:10 PM
sbruno updated the diff for D20236: sysutils/devcpu-data: update to Intel github release 201900514.

Implement @mat suggestions for USE_GH

Sat, May 11, 3:08 PM
sbruno added a reviewer for D20236: sysutils/devcpu-data: update to Intel github release 201900514: imp.
Sat, May 11, 12:15 AM
sbruno added a reviewer for D20236: sysutils/devcpu-data: update to Intel github release 201900514: markj.
Sat, May 11, 12:15 AM
sbruno created D20236: sysutils/devcpu-data: update to Intel github release 201900514.
Sat, May 11, 12:11 AM

Mar 31 2019

sbruno requested review of D17772: Add hack to allow users to bypass pin widget initialization..

Yeah, just changing VREF_ENABLE_MASK was insufficient. I think I'll just commit this so people can use it for their newer desktops/laptops.

Mar 31 2019, 3:16 PM

Mar 24 2019

sbruno accepted D19696: Make smartpqi(4) behave better when running out of memory..
Mar 24 2019, 9:06 PM
sbruno committed rP496772: Fix build after base r345349.
Fix build after base r345349
Mar 24 2019, 7:45 PM
sbruno removed a reviewer for D13648: Add flashmap rootfs search function: sbruno.
Mar 24 2019, 1:43 PM

Mar 20 2019

sbruno accepted D19652: iflib: return ENETDOWN when the network device is down.

stlgtm

Mar 20 2019, 11:51 AM

Mar 19 2019

sbruno removed a reviewer for D16875: Possible fix for "desc avail = " dmesg spam and igb breakage: sbruno.
Mar 19 2019, 9:43 PM
sbruno committed rP496258: emulators/qemu-sbruno:.
emulators/qemu-sbruno:
Mar 19 2019, 11:54 AM

Mar 18 2019

sbruno accepted D19625: Fix smartpqi(4) malloc tag and description to match the driver name..

This seems like a good accounting change. Thanks.

Mar 18 2019, 10:01 PM

Mar 10 2019

sbruno committed rP495298: games/cockatrice: Update to 2.7.0 release..
games/cockatrice: Update to 2.7.0 release.
Mar 10 2019, 4:18 PM

Mar 5 2019

sbruno accepted D19470: Fix crash in low memory conditions..

Thanks for digging into this.

Mar 5 2019, 11:03 PM

Feb 14 2019

sbruno accepted D19166: [PPC64] Fix mismatch between thread flags and MSR.

This looks good from the user side as the machine is humming along quite nicely. Thank you for digging into this!

Feb 14 2019, 12:40 PM

Feb 13 2019

sbruno removed a reviewer for D11378: iWARP driver for Intel X722 Adapter - initial commit: sbruno.
Feb 13 2019, 12:53 PM
sbruno removed a member for Intel Networking: sbruno.
Feb 13 2019, 12:53 PM

Feb 12 2019

sbruno added a comment to D19166: [PPC64] Fix mismatch between thread flags and MSR.

Patched the build tree in the freebsd.org cluster and installed -current + this review on the pkg build server. You can track builds here when it starts spinning up in about an hour.

Feb 12 2019, 11:32 PM
sbruno updated subscribers of D19166: [PPC64] Fix mismatch between thread flags and MSR.
Feb 12 2019, 11:16 PM

Jan 29 2019

sbruno committed rP491590: Release Sergey from mentorship..
Release Sergey from mentorship.
Jan 29 2019, 7:08 PM

Jan 23 2019

sbruno added a comment to D16164: Make options IFLIB a real configuration option..

bump to see if phabricator shovels some emails.

Jan 23 2019, 9:06 PM

Jan 22 2019

sbruno added a comment to D16164: Make options IFLIB a real configuration option..

trivial bump to generate email.

Jan 22 2019, 5:44 PM
sbruno added a comment to D16164: Make options IFLIB a real configuration option..

@shurd any objections from the peanut gallery?

Jan 22 2019, 5:42 PM

Jan 18 2019

sbruno resigned from D13858: 1 << 31 redux.
Jan 18 2019, 7:29 PM

Jan 16 2019

sbruno committed rP490487: sysutils/devcpu-data:.
sysutils/devcpu-data:
Jan 16 2019, 3:37 PM

Jan 9 2019

sbruno committed rP489812: games/cockatrice:.
games/cockatrice:
Jan 9 2019, 3:57 PM
sbruno committed rP489804: audio/clementine-player:.
audio/clementine-player:
Jan 9 2019, 2:56 PM

Jan 3 2019

sbruno abandoned D17891: audio/clementine-player: Migrate to Qt5.

Ports revision r489228 based on different patches has been committed.

Jan 3 2019, 9:47 PM
sbruno committed rP489228: audio/clementine-player: Jump to qt5.
audio/clementine-player: Jump to qt5
Jan 3 2019, 9:44 PM

Dec 26 2018

sbruno closed D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.

r481915 | sbruno | 2018-10-12 11:51:37 -0600 (Fri, 12 Oct 2018) | 11 lines

Dec 26 2018, 5:52 PM

Dec 23 2018

sbruno committed rP488221: games/cockatrice: update to 2.6.2: Bog Humbug.
games/cockatrice: update to 2.6.2: Bog Humbug
Dec 23 2018, 2:13 PM

Dec 19 2018

sbruno added a comment to D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.

We are seeing tx hangs with UDP using multiple clients when offloads are disabled. Cannot reproduce on 12.0-RELEASE. Reproducible on X520 and X550.

Huh? Does this review break things for you? Or are you bringing up a new problem?

Just reporting issues/regressions we found while testing this :)

Dec 19 2018, 7:12 PM

Dec 18 2018

sbruno added a comment to D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.

We are seeing tx hangs with UDP using multiple clients when offloads are disabled. Cannot reproduce on 12.0-RELEASE. Reproducible on X520 and X550.

Dec 18 2018, 6:20 PM
sbruno added a reviewer for D18545: intel: correct initialization of tx_cidx_processed: Intel Networking.
Dec 18 2018, 4:13 PM
sbruno requested changes to D18598: MFH: r486750 (partial)devel/staf: Unbreak for openssl111.

Doesn't this patch need to be conditional somehow (FreeBSD versions < 12 don't need this).

Dec 18 2018, 3:29 PM

Dec 16 2018

sbruno added reviewers for D18575: Add AT_HWCAP / AT_HWCAP2 to elf64_sysvec_v2.: emaste, mmacy, nwhitehorn.
Dec 16 2018, 2:12 PM · PowerPC

Dec 14 2018

sbruno accepted D18505: Remove the timed daemon..

stlgtm

Dec 14 2018, 2:09 PM
sbruno added inline comments to D18505: Remove the timed daemon..
Dec 14 2018, 2:03 PM

Dec 10 2018

sbruno accepted D18502: sysutils/intel-nvmupdate: Remove obsolete chmod workaround.
Dec 10 2018, 4:05 PM · Intel Networking
sbruno accepted D18467: devel/staf: Use ${RLN} instead of ${LN} in do-install.
Dec 10 2018, 4:03 PM
sbruno accepted D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status.
Dec 10 2018, 4:03 PM
sbruno accepted D18469: ix: Fix accessing wrong register, improve WoL support recognition ix, ixv: Update link status with autonegotiated baudrate value.
Dec 10 2018, 3:49 PM
sbruno accepted D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.

I guess this will wait for @jeffrey.e.pieper_intel.com to test or approve? This looks correct to my eye.

Dec 10 2018, 3:42 PM
sbruno accepted D17806: ppc64: handle exception 0x1500 (soft patch).

Agreed. Feel free to commit this at your leisure.

Dec 10 2018, 1:30 PM

Dec 9 2018

sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).
panic: Memory modified after free 0xc0000000e2f31580(32) val=0 @ 0xc0000000e2f31580
Dec 9 2018, 9:13 PM
sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).
FreeBSD pylon.nyi.freebsd.org 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r341766M: Sun Dec  9 18:59:51 UTC 2018     sbruno@build-13.freebsd.org:/usr/obj/powerpc.powerpc64/usr/src/sys/CLUSTER13  powerpc
Dec 9 2018, 8:32 PM
sbruno requested changes to D17806: ppc64: handle exception 0x1500 (soft patch).

This panic is fairly reliable on our Power8 box. Is it related to this change or is it unrelated? I'm not convinced this panic should keep this review blocked as it resolves other things.

panic: Memory modified after free 0xc0000000850584a0(32) val=0 @ 0xc0000000850584a0
Dec 9 2018, 6:55 PM

Dec 8 2018

sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

The reason of segmentation fault when treating the 0x1500 exception
was because it was being treated as a non-hypervisor trap, which
consider the registers srr0/srr1. As this trap is an hypervisor one,
the values were being placed in hsrr0/hsrr1.
Just changed the enter point for hypertrap, which saves the value of
hsrr0 and hsrr1 in srr0 and srr1.

Dec 8 2018, 1:54 PM

Dec 6 2018

sbruno committed rS341643: Change u32 to uint32_t to allow the native-xtools target to build.
Change u32 to uint32_t to allow the native-xtools target to build
Dec 6 2018, 6:59 PM

Dec 5 2018

sbruno accepted D18438: net/intel-ixl-kmod: Update from 1.9.13 to 1.10.4.
Dec 5 2018, 6:05 PM · Intel Networking
sbruno accepted D18440: devel/staf: Unbreak for openssl111.
Dec 5 2018, 6:05 PM

Dec 4 2018

sbruno committed rS341453: Revert r340997 at the request of multiple users..
Revert r340997 at the request of multiple users.
Dec 4 2018, 3:23 AM

Dec 3 2018

sbruno added reviewers for D18420: add a method to defer destruction of if_softc to if_destroy: jtl, glebius.
Dec 3 2018, 2:47 PM

Dec 2 2018

sbruno added a reviewer for D18408: PR209468: aacraid fixes to work with newer controller firmware: mav.
Dec 2 2018, 4:14 PM
sbruno added reviewers for D18408: PR209468: aacraid fixes to work with newer controller firmware: scottl, scott.benesh_microsemi.com.
Dec 2 2018, 4:14 PM
sbruno added reviewers for D18402: netmap: ixgbe: add support for jumbo frames: shurd, Intel Networking.
Dec 2 2018, 4:06 PM

Nov 30 2018

sbruno accepted D18382: Add new "trim" conversion for dd(1).
Nov 30 2018, 2:36 AM

Nov 28 2018

sbruno added a comment to D10776: Make Capsicum obligatory..

Is it acceptable if some binaries fail?

This has become a real issue - @sbruno found wc did not work on ERL, fixed in rS341140. This is somewhat independent of whether we have the #ifdefs or not though.

Nov 28 2018, 7:02 PM
sbruno committed rS341140: Add CAPABILITIES to the ERL kernel config so that tools that have been.
Add CAPABILITIES to the ERL kernel config so that tools that have been
Nov 28 2018, 1:26 PM

Nov 17 2018

sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

Oof. I got a different panic, that may or may not be useful.

Nov 17 2018, 8:24 PM
sbruno updated the diff for D17891: audio/clementine-player: Migrate to Qt5.

Meaningless update to test that phab is still working

Nov 17 2018, 8:19 PM
sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

Running this on the Tyan Power8 hosts now. I'll report back in a day or two after we get some poudriere runs under our belt.

Nov 17 2018, 4:37 PM

Nov 11 2018

sbruno committed rP484702: Bump qemu-sbruno to capture 4ef7d07.
Bump qemu-sbruno to capture 4ef7d07
Nov 11 2018, 5:15 PM

Nov 9 2018

sbruno committed rP484536: Incorpororate fixes to build packages after freebsd svn r339655. (kevans).
Incorpororate fixes to build packages after freebsd svn r339655. (kevans)
Nov 9 2018, 6:14 PM

Nov 7 2018

sbruno requested changes to D11378: iWARP driver for Intel X722 Adapter - initial commit.

Is there any intention to rebase this to -current?

Nov 7 2018, 4:36 PM
sbruno updated the diff for D17891: audio/clementine-player: Migrate to Qt5.

Nuke extra pkgname suffix

Nov 7 2018, 2:23 PM
sbruno created D17891: audio/clementine-player: Migrate to Qt5.
Nov 7 2018, 2:21 PM

Nov 1 2018

sbruno updated subscribers of D17806: ppc64: handle exception 0x1500 (soft patch).
Nov 1 2018, 10:28 PM

Oct 31 2018

sbruno planned changes to D17772: Add hack to allow users to bypass pin widget initialization..
In D17772#379922, @mav wrote:

Have you tried to investigate whether keeping only VREF_ENABLE_MASK would be enough? It could have some more sense in general, since the driver has no way to know what VREF is needed in specific case. Same time other bits there are pretty logical.

Oct 31 2018, 2:36 PM
sbruno added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

Address man page review comments. Word wrap at 80 columns.

Oct 31 2018, 1:26 PM
sbruno updated the diff for D17772: Add hack to allow users to bypass pin widget initialization..

Address man page style review for new lines and correct case of BIOS use.

Oct 31 2018, 1:26 PM
sbruno updated the diff for D17772: Add hack to allow users to bypass pin widget initialization..

Add a man page update like a good dev.

Oct 31 2018, 12:04 AM

Oct 30 2018

sbruno added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

This is probably completely wrong on multiple levels, but this certainly does allow me to use my headphones again on my Skylake Intel HDA box.

Oct 30 2018, 11:51 PM
sbruno created D17772: Add hack to allow users to bypass pin widget initialization..
Oct 30 2018, 11:49 PM

Oct 29 2018

sbruno accepted D17749: net/intel-em-kmod: take maintainership.
Oct 29 2018, 3:05 PM · Intel Networking

Oct 25 2018

sbruno accepted D17646: net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH.
Oct 25 2018, 5:25 PM · Intel Networking

Oct 22 2018

sbruno added a comment to D17470: Fix net/qt4-network with OpenSSL 1.1.1.

This definitely fixes the build and runtime of clementine-player (qt4).

Oct 22 2018, 7:19 PM

Oct 19 2018

sbruno added a comment to D17618: locale data should be consistent-endian (big).

Sean, could you please give this a try on ref12-ppc64?

Oct 19 2018, 7:02 PM
sbruno accepted D17601: ppc64: limited 32-bit DMA address range.

This is running live on the host archon.nyi.freebsd.org that hosts ref12-ppc64.freebsd.org. We can do buildworlds and network things now. This is awesome.

Oct 19 2018, 3:04 PM
sbruno accepted D17603: PR231965: make localedef output locale data in target endian order.

issue fixed (wchar_t, that is (unsigned) int, is *4* bytes).
Now the amd64 cross-built locale data matches the one built natively on powerpc64.

Updating ref12-ppc64 for verification.

Oct 19 2018, 3:03 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

issue fixed (wchar_t, that is (unsigned) int, is *4* bytes).
Now the amd64 cross-built locale data matches the one built natively on powerpc64.

Oct 19 2018, 2:59 PM

Oct 18 2018

sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.
The build host is amd64 and builds multiple targets, aarch64, i386, powerpc64 and amd64. What information would you like from the builds?

I'd really like to compare results from native EB (e.g. powerpc64) build for /usr/share/locale with what amd64 cross-build produces.

Ok. I'll update ref12-ppc64 to this review (product of cross build) and then you can natively do a buildworld there to see what it looks like?

Thank you!

Oct 18 2018, 10:12 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.
The build host is amd64 and builds multiple targets, aarch64, i386, powerpc64 and amd64. What information would you like from the builds?

I'd really like to compare results from native EB (e.g. powerpc64) build for /usr/share/locale with what amd64 cross-build produces.

Oct 18 2018, 9:44 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.

Oct 18 2018, 9:27 PM
sbruno added a comment to D17470: Fix net/qt4-network with OpenSSL 1.1.1.

I'll test this against clementine-player today and see if it can do SSL/TLS connections for streaming. That should give us a bit of a warm fuzzy.

Oct 18 2018, 3:53 PM
sbruno accepted D17470: Fix net/qt4-network with OpenSSL 1.1.1.

This allows audio/murmur to build again.

Oct 18 2018, 1:50 PM

Oct 15 2018

sbruno accepted D17544: iavf: Finish the rename/rebrand internally.

@erj do you want to ask RE permission to commit this?

Oct 15 2018, 4:32 PM

Oct 14 2018

sbruno committed rP482049: Connect net/intel-ix-kmod to the build. Missed in r481900..
Connect net/intel-ix-kmod to the build. Missed in r481900.
Oct 14 2018, 4:06 PM

Oct 12 2018

sbruno committed rP481917: Setting DOCS=off will set EXTRA_PATCHES, so we need to append to this.
Setting DOCS=off will set EXTRA_PATCHES, so we need to append to this
Oct 12 2018, 6:20 PM
sbruno committed rP481915: sysutils/ipmitool: unbreak with openssl 1.1.1 import.
sysutils/ipmitool: unbreak with openssl 1.1.1 import
Oct 12 2018, 5:51 PM