Page MenuHomeFreeBSD

sbruno (Sean Bruno)
User

Projects (6)

User Details

User Since
May 26 2014, 3:41 PM (233 w, 6 d)

Recent Activity

Yesterday

sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

Oof. I got a different panic, that may or may not be useful.

Sat, Nov 17, 8:24 PM
sbruno updated the diff for D17891: audio/clementine-player: Migrate to Qt5.

Meaningless update to test that phab is still working

Sat, Nov 17, 8:19 PM
sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

Running this on the Tyan Power8 hosts now. I'll report back in a day or two after we get some poudriere runs under our belt.

Sat, Nov 17, 4:37 PM

Sun, Nov 11

sbruno committed rP484702: Bump qemu-sbruno to capture 4ef7d07.
Bump qemu-sbruno to capture 4ef7d07
Sun, Nov 11, 5:15 PM

Fri, Nov 9

sbruno committed rP484536: Incorpororate fixes to build packages after freebsd svn r339655. (kevans).
Incorpororate fixes to build packages after freebsd svn r339655. (kevans)
Fri, Nov 9, 6:14 PM

Wed, Nov 7

sbruno requested changes to D11378: iWARP driver for Intel X722 Adapter - initial commit.

Is there any intention to rebase this to -current?

Wed, Nov 7, 4:36 PM
sbruno updated the diff for D17891: audio/clementine-player: Migrate to Qt5.

Nuke extra pkgname suffix

Wed, Nov 7, 2:23 PM
sbruno created D17891: audio/clementine-player: Migrate to Qt5.
Wed, Nov 7, 2:21 PM

Thu, Nov 1

sbruno updated subscribers of D17806: ppc64: handle exception 0x1500 (soft patch).
Thu, Nov 1, 10:28 PM

Wed, Oct 31

sbruno planned changes to D17772: Add hack to allow users to bypass pin widget initialization..
In D17772#379922, @mav wrote:

Have you tried to investigate whether keeping only VREF_ENABLE_MASK would be enough? It could have some more sense in general, since the driver has no way to know what VREF is needed in specific case. Same time other bits there are pretty logical.

Wed, Oct 31, 2:36 PM
sbruno added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

Address man page review comments. Word wrap at 80 columns.

Wed, Oct 31, 1:26 PM
sbruno updated the diff for D17772: Add hack to allow users to bypass pin widget initialization..

Address man page style review for new lines and correct case of BIOS use.

Wed, Oct 31, 1:26 PM
sbruno updated the diff for D17772: Add hack to allow users to bypass pin widget initialization..

Add a man page update like a good dev.

Wed, Oct 31, 12:04 AM

Tue, Oct 30

sbruno added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

This is probably completely wrong on multiple levels, but this certainly does allow me to use my headphones again on my Skylake Intel HDA box.

Tue, Oct 30, 11:51 PM
sbruno created D17772: Add hack to allow users to bypass pin widget initialization..
Tue, Oct 30, 11:49 PM

Mon, Oct 29

sbruno accepted D17749: net/intel-em-kmod: take maintainership.
Mon, Oct 29, 3:05 PM · Intel Networking

Thu, Oct 25

sbruno accepted D17646: net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH.
Thu, Oct 25, 5:25 PM · Intel Networking

Mon, Oct 22

sbruno added a comment to D17470: Fix net/qt4-network with OpenSSL 1.1.1.

This definitely fixes the build and runtime of clementine-player (qt4).

Mon, Oct 22, 7:19 PM

Fri, Oct 19

sbruno added a comment to D17618: locale data should be consistent-endian (big).

Sean, could you please give this a try on ref12-ppc64?

Fri, Oct 19, 7:02 PM

Oct 19 2018

sbruno accepted D17601: ppc64: limited 32-bit DMA address range.

This is running live on the host archon.nyi.freebsd.org that hosts ref12-ppc64.freebsd.org. We can do buildworlds and network things now. This is awesome.

Oct 19 2018, 3:04 PM
sbruno accepted D17603: PR231965: make localedef output locale data in target endian order.

issue fixed (wchar_t, that is (unsigned) int, is *4* bytes).

Now the amd64 cross-built locale data matches the one built natively on powerpc64.

Updating ref12-ppc64 for verification.

Oct 19 2018, 3:03 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

issue fixed (wchar_t, that is (unsigned) int, is *4* bytes).

Now the amd64 cross-built locale data matches the one built natively on powerpc64.

Oct 19 2018, 2:59 PM

Oct 18 2018

sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.

The build host is amd64 and builds multiple targets, aarch64, i386, powerpc64 and amd64. What information would you like from the builds?

I'd really like to compare results from native EB (e.g. powerpc64) build for /usr/share/locale with what amd64 cross-build produces.

Ok. I'll update ref12-ppc64 to this review (product of cross build) and then you can natively do a buildworld there to see what it looks like?

Thank you!

Oct 18 2018, 10:12 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.

The build host is amd64 and builds multiple targets, aarch64, i386, powerpc64 and amd64. What information would you like from the builds?

I'd really like to compare results from native EB (e.g. powerpc64) build for /usr/share/locale with what amd64 cross-build produces.

Oct 18 2018, 9:44 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.

Oct 18 2018, 9:27 PM
sbruno added a comment to D17470: Fix net/qt4-network with OpenSSL 1.1.1.

I'll test this against clementine-player today and see if it can do SSL/TLS connections for streaming. That should give us a bit of a warm fuzzy.

Oct 18 2018, 3:53 PM
sbruno accepted D17470: Fix net/qt4-network with OpenSSL 1.1.1.

This allows audio/murmur to build again.

Oct 18 2018, 1:50 PM

Oct 15 2018

sbruno accepted D17544: iavf: Finish the rename/rebrand internally.

@erj do you want to ask RE permission to commit this?

Oct 15 2018, 4:32 PM

Oct 14 2018

sbruno committed rP482049: Connect net/intel-ix-kmod to the build. Missed in r481900..
Connect net/intel-ix-kmod to the build. Missed in r481900.
Oct 14 2018, 4:06 PM

Oct 12 2018

sbruno committed rP481917: Setting DOCS=off will set EXTRA_PATCHES, so we need to append to this.
Setting DOCS=off will set EXTRA_PATCHES, so we need to append to this
Oct 12 2018, 6:20 PM
sbruno committed rP481915: sysutils/ipmitool: unbreak with openssl 1.1.1 import.
sysutils/ipmitool: unbreak with openssl 1.1.1 import
Oct 12 2018, 5:51 PM
sbruno updated the diff for D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.

Apply openssl 1.1.1 update patch only if running on a FreeBSD version where
openssl 1.1.1 exists.

Oct 12 2018, 4:22 PM
sbruno committed rP481910: comms/conserver-com: Update for openssl 1.1.1 in 12-CURRENT..
comms/conserver-com: Update for openssl 1.1.1 in 12-CURRENT.
Oct 12 2018, 3:51 PM
sbruno closed D17524: comms/conserver-com: Update to 8.2.2 - support base openssl 1.1.1 - switch to upstream github.
Oct 12 2018, 3:51 PM
sbruno added a comment to D17524: comms/conserver-com: Update to 8.2.2 - support base openssl 1.1.1 - switch to upstream github.

The USE_* section should be below the LICENSE section

Oct 12 2018, 3:21 PM
sbruno added a comment to D17528: comms/conserver-com: Update licensing details and pet portlint.

There is no ${WRKSRC}/LICENSES , was this tested?

Oct 12 2018, 3:13 PM
sbruno accepted D17533: net/intel-ixl-kmod: Remove -Werror from CFLAGS.
Oct 12 2018, 2:37 PM · Intel Networking
sbruno requested changes to D17528: comms/conserver-com: Update licensing details and pet portlint.

FATAL: Makefile: license specified is BSD3CLAUSE OTHERBSDLIKELICENSES, but LICENSE_FILE specified is for BSD3CLAUSE.

Oct 12 2018, 2:15 PM
sbruno accepted D17528: comms/conserver-com: Update licensing details and pet portlint.
Oct 12 2018, 1:43 PM
sbruno added a comment to D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.

Tested on FreeBSD 12 natively and compiled in poudriere.

Oct 12 2018, 3:52 AM
sbruno added a comment to D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.

https://github.com/ipmitool/ipmitool/commit/1664902525a1c3771b4d8b3ccab7ea1ba6b2bdd1#diff-707b424f074d272f2934512475a3e99c

Oct 12 2018, 3:51 AM
sbruno created D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.
Oct 12 2018, 3:50 AM

Oct 11 2018

sbruno accepted D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Oct 11 2018, 10:48 PM · Intel Networking
sbruno accepted D15927: Update ixl(4) and ixlv(4) man pages.
Oct 11 2018, 10:47 PM
sbruno added a comment to D17524: comms/conserver-com: Update to 8.2.2 - support base openssl 1.1.1 - switch to upstream github.

Test builds of 12/11/10 on i386/amd64 build and pkg fine.

Oct 11 2018, 9:59 PM
sbruno created D17524: comms/conserver-com: Update to 8.2.2 - support base openssl 1.1.1 - switch to upstream github.
Oct 11 2018, 9:59 PM
sbruno added a comment to D17473: fix PNP entries for if_ix and if_ixv.

@yuripv Do you want me to commit this or are you going to be able to send the request to release engineering?

Oct 11 2018, 5:58 PM
sbruno accepted D17473: fix PNP entries for if_ix and if_ixv.
Oct 11 2018, 5:50 PM
sbruno accepted D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.
Oct 11 2018, 5:40 PM · Intel Networking

Oct 5 2018

sbruno accepted D17442: Fix egregious magic number constants.
Oct 5 2018, 9:43 PM
sbruno added a comment to D17442: Fix egregious magic number constants.
In D17442#372066, @erj wrote:

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

Oct 5 2018, 9:25 PM
sbruno accepted D17440: net/intel-em-kmod: Update to 7.7.4, enable netmap on 11.
Oct 5 2018, 9:23 PM · Intel Networking
sbruno requested changes to D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.

Does this require a LICENSE or some sort?

Oct 5 2018, 9:22 PM · Intel Networking
sbruno accepted D17437: sysutils/intel-qcu: Update to 2.30.23.0.
Oct 5 2018, 8:16 PM · Intel Networking
sbruno accepted D17435: net/intel-ixl-kmod: Add had-linked man page.
Oct 5 2018, 4:06 PM

Oct 1 2018

sbruno accepted D17246: Hold a write lock across udp_notify().

Ok, whom would like to submit this to re@ to get it into the tree?

Oct 1 2018, 2:42 AM

Sep 22 2018

sbruno accepted D17283: Add myself to mentees with sbruno as mentor.
Sep 22 2018, 6:41 PM
sbruno accepted D17284: Change MAINTAINER in my ports to @FreeBSD.org email.
Sep 22 2018, 6:40 PM

Sep 21 2018

sbruno accepted D17269: Add myself to authors, developers, and news.
Sep 21 2018, 1:52 PM
sbruno committed rP480270: Add Sergey Kozlov to our ranks of committers with myself as a mentor..
Add Sergey Kozlov to our ranks of committers with myself as a mentor.
Sep 21 2018, 1:52 PM

Sep 19 2018

sbruno accepted D17250: Add support for EC2 i3.metal serial port.

stlgtm

Sep 19 2018, 10:01 PM

Sep 18 2018

sbruno added a reviewer for D17230: Update udp6_output() inp locking to avoid concurrency issues with route cache updates: rstone.
Sep 18 2018, 10:32 PM

Sep 14 2018

sbruno accepted D16808: fix vlan locking to permit sx acquisition in ioctl calls.
Sep 14 2018, 1:48 PM

Sep 6 2018

sbruno accepted D17031: Fix synchronization of lbgroup access..
Sep 6 2018, 3:27 PM

Aug 27 2018

sbruno accepted D16924: devcpu-data: Provide a file for loading at boot time.
Aug 27 2018, 9:37 PM
sbruno accepted D16924: devcpu-data: Provide a file for loading at boot time.

Can you bump PORTVERSION when you commit this?

Aug 27 2018, 8:49 PM

Aug 26 2018

sbruno committed rS338330: r338270 had the side effect of no longer installing libmd.so into /lib..
r338270 had the side effect of no longer installing libmd.so into /lib.
Aug 26 2018, 5:06 PM
sbruno closed D16910: libmd: Install libmd.so.6 into /lib again after SVN r338270.
Aug 26 2018, 5:06 PM

Aug 25 2018

sbruno accepted D16899: SO_REUSEPORT_LB critical bug fix: avoid IPv4 listen group in IPv6.
Aug 25 2018, 4:46 PM

Aug 12 2018

sbruno abandoned D11958: usr.bin/mandoc build warning/error fixes.
Aug 12 2018, 3:47 PM
sbruno commandeered D11958: usr.bin/mandoc build warning/error fixes.

A new release of mandoc was posted last week, is this still valid?

Aug 12 2018, 3:47 PM

Aug 8 2018

sbruno accepted D16633: [powerpc] Fix kernel panic when using "options BOOTP_NFSROOT".
Aug 8 2018, 8:24 PM
sbruno committed rP476664: sysutils/devcpu-data:.
sysutils/devcpu-data:
Aug 8 2018, 7:29 PM

Jul 31 2018

sbruno added a reviewer for D16534: e1000: Don't use 9k jumbo clusters: Intel Networking.
Jul 31 2018, 8:30 PM

Jul 25 2018

sbruno accepted D16428: iflib: Changes for ixlv(4) update.
Jul 25 2018, 6:16 PM · Intel Networking

Jul 24 2018

sbruno committed rP475259: games/cockatrice: Update to release 2.6.1.
games/cockatrice: Update to release 2.6.1
Jul 24 2018, 3:01 PM

Jul 14 2018

sbruno committed rS336298: There was quite a bit of feedback on r336282 that has led to the.
There was quite a bit of feedback on r336282 that has led to the
Jul 14 2018, 11:54 PM
sbruno reopened D14621: Fix a potential use after free in getsockopt() access to inp_options.

Reopen at the request of submitter.

Jul 14 2018, 11:51 PM
sbruno resigned from D13023: Bring www/madsonic-standalone to www/libresonic-standalone's standards..
Jul 14 2018, 4:21 PM
sbruno resigned from D13040: Bring www/subsonic-standalone to www/libresonic-standalone's standards..
Jul 14 2018, 4:21 PM
sbruno closed D14621: Fix a potential use after free in getsockopt() access to inp_options.
Jul 14 2018, 4:20 PM
sbruno committed rS336282: Fixup memory management for fetching options in ip_ctloutput().
Fixup memory management for fetching options in ip_ctloutput()
Jul 14 2018, 4:20 PM
sbruno accepted D16259: Fix vnic fallback PHY name matching after r334880..

This works for us in the FreeBSD cluster. Thanks!

Jul 14 2018, 3:44 PM

Jul 13 2018

sbruno added a comment to D16259: Fix vnic fallback PHY name matching after r334880..

Let me do a quick test on the cluster ThunderX1 machine.

Jul 13 2018, 7:17 PM

Jul 11 2018

sbruno committed rS336201: smartpqi(4):.
smartpqi(4):
Jul 11 2018, 4:44 PM
sbruno closed D16060: Maintenance's commit of Microsemi smartpqi driver.
Jul 11 2018, 4:44 PM · Src Committers
sbruno accepted D16060: Maintenance's commit of Microsemi smartpqi driver.
Jul 11 2018, 4:42 PM · Src Committers
sbruno created D16226: [MIPS]: reap unused struct proc *p1;.
Jul 11 2018, 4:24 PM
sbruno committed rP474447: sysutils/devcpu-data:.
sysutils/devcpu-data:
Jul 11 2018, 2:00 PM
sbruno closed D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.
Jul 11 2018, 2:00 PM

Jul 10 2018

sbruno accepted D16201: acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic.
Jul 10 2018, 11:24 PM
sbruno added a comment to D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.

From the release notes and will be in the commit log:

Jul 10 2018, 8:41 PM
sbruno updated the diff for D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.

0.o Remove the other directories from this review.

Jul 10 2018, 8:39 PM
sbruno created D16209: sysutils/devcpu-data: - Update to Intel Micorocde release 07032018.
Jul 10 2018, 8:38 PM
sbruno added inline comments to D16169: Rework sys/modules/Makefile to improve arch and option filtering..
Jul 10 2018, 4:50 PM

Jul 8 2018

sbruno added a comment to D16164: Make options IFLIB a real configuration option..
In D16164#342962, @cem wrote:
In D16164#342951, @erj wrote:

can iflib.ko be created and then the driver modules depend on that?

That would be really nice. :-P

Driver modules already can and do depend on iflib, without forcing it to be a kld object (.ko) — grep for MODULE_DEPEND(..., iflib, ...).

If the idea is pulling iflib out of the kernel just for space savings, I'm not sure that really makes sense on any platform that supports iflib drivers anyway (i.e., non-embedded).

Please do add the IFLIB option to most/all GENERICs simultaneously with this change, though.

Jul 8 2018, 2:57 PM

Jul 7 2018

sbruno added a comment to D16164: Make options IFLIB a real configuration option..

Does this not also make it so that these drivers require IFLIB, so they need to be marked as such in GENERIC/NOTES/etc and man pages?

Jul 7 2018, 4:44 PM
sbruno added a reviewer for D16164: Make options IFLIB a real configuration option.: rgrimes.
Jul 7 2018, 1:41 PM
sbruno accepted D14802: fix malloc length in ip6_output.c:GET_PKTOPT_VAR.
Jul 7 2018, 1:38 PM
sbruno closed D16113: sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMA.
Jul 7 2018, 1:38 PM