sbruno (Sean Bruno)
User

Projects (6)

User Details

User Since
May 26 2014, 3:41 PM (182 w, 4 d)

Recent Activity

Today

sbruno updated the diff for D13062: Add vmm(4) man page.

Address review comments

Sat, Nov 25, 12:28 AM
sbruno commandeered D13062: Add vmm(4) man page.
Sat, Nov 25, 12:18 AM

Yesterday

sbruno added a comment to D13230: native-xtools: GCC and CLANG are exclusive, pick one..

This code block also needs an adjustment to "something" as we have no need to add these to this target's build in the GCC case.

Fri, Nov 24, 7:48 PM
sbruno added a comment to D13230: native-xtools: GCC and CLANG are exclusive, pick one..
In D13230#275661, @jhb wrote:

I wonder if this shouldn't be conditional on which compiler is used as cc. That way if you do 'make native-stools WITH_CLANG_AS_CC=yes' you would get clang instead of gcc.

Fri, Nov 24, 7:44 PM
sbruno created D13230: native-xtools: GCC and CLANG are exclusive, pick one..
Fri, Nov 24, 5:57 PM

Thu, Nov 23

sbruno committed rP454769: games/cockatrice: Bump to 2.4.0 Release.
games/cockatrice: Bump to 2.4.0 Release
Thu, Nov 23, 5:56 PM

Thu, Nov 16

sbruno committed rP454345: sysutils/intel-nvmupdate: Update to 6.01.
sysutils/intel-nvmupdate: Update to 6.01
Thu, Nov 16, 9:54 PM
sbruno closed D12180: sysutils/intel-nvmupdate: Update to 6.01.
Thu, Nov 16, 9:54 PM · Intel Networking
sbruno committed rP454344: net/intel-ixl-kmod Update to 1.8.1.
net/intel-ixl-kmod Update to 1.8.1
Thu, Nov 16, 9:52 PM
sbruno closed D12179: net/intel-ixl-kmod: Update to 1.8.1.
Thu, Nov 16, 9:52 PM · Intel Networking
sbruno committed rP454343: sysutils/intel-qcu Update to 2.30.16.8.
sysutils/intel-qcu Update to 2.30.16.8
Thu, Nov 16, 9:48 PM
sbruno closed D13085: sysutils/intel-qcu: Update to 2.30.16.8.
Thu, Nov 16, 9:48 PM · Intel Networking
sbruno accepted D12180: sysutils/intel-nvmupdate: Update to 6.01.

Yep, looks good. Thanks!

Thu, Nov 16, 7:22 PM · Intel Networking

Wed, Nov 15

sbruno added a comment to D12132: Avoid spinning in random_harvest_queue.

What I take away from the conversation in this review is that the solution being proposed does what its supposed to do, and there is even more room for improvement.

Wed, Nov 15, 9:09 PM
sbruno accepted D13096: Fix default numbers of queue sets.
Wed, Nov 15, 3:56 PM
sbruno added a reviewer for D13096: Fix default numbers of queue sets: bhargava.marreddy_broadcom.com.
Wed, Nov 15, 3:55 PM

Tue, Nov 14

sbruno accepted D13085: sysutils/intel-qcu: Update to 2.30.16.8.

Builds. Untested at this time.

Tue, Nov 14, 7:43 PM · Intel Networking
sbruno added a reviewer for D13085: sysutils/intel-qcu: Update to 2.30.16.8: swills.
Tue, Nov 14, 7:40 PM · Intel Networking
sbruno accepted D12179: net/intel-ixl-kmod: Update to 1.8.1.
Tue, Nov 14, 7:39 PM · Intel Networking
sbruno added a reviewer for D12179: net/intel-ixl-kmod: Update to 1.8.1: swills.
Tue, Nov 14, 7:39 PM · Intel Networking
sbruno added a comment to D12180: sysutils/intel-nvmupdate: Update to 6.01.

Odd, I get a wierd chmod error on FreeBSD 10 when building this port. On 11/12 it builds fine:

Tue, Nov 14, 7:38 PM · Intel Networking
sbruno added a reviewer for D12180: sysutils/intel-nvmupdate: Update to 6.01: swills.
Tue, Nov 14, 7:37 PM · Intel Networking

Mon, Nov 13

sbruno added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

@olivier Can you post the sysctl/loader.conf settings you are using from both iterations of the test?

Mon, Nov 13, 7:22 PM
sbruno added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

@olivier So a decrease of ~33% with IFLIB?

Mon, Nov 13, 7:17 PM

Fri, Nov 10

sbruno requested changes to D12179: net/intel-ixl-kmod: Update to 1.8.1.

bump. What's the plan here?

Fri, Nov 10, 1:26 AM · Intel Networking
sbruno requested changes to D12180: sysutils/intel-nvmupdate: Update to 6.01.

bump. What's up here?

Fri, Nov 10, 1:26 AM · Intel Networking

Thu, Nov 9

sbruno committed rS325620: Fix issue with VXLAN-ecapsulated rx h/w checksumming..
Fix issue with VXLAN-ecapsulated rx h/w checksumming.
Thu, Nov 9, 10:27 PM
sbruno closed D12976: Fix issue with VXLAN-encapsulated rx h/w checksum.
Thu, Nov 9, 10:27 PM
sbruno accepted D12973: bnxt: While VLAN TCP Tx is progress, "ifconfig destroy" caused kernel Crash in Iflib code.
Thu, Nov 9, 8:12 PM
sbruno committed rS325618: Merge r323509 and r324994 adding Cavium LiquidIO Driver (lio).
Merge r323509 and r324994 adding Cavium LiquidIO Driver (lio)
Thu, Nov 9, 7:58 PM
sbruno closed D12425: Cavium Liquidio 23xx Intelligent network adapter driver initial submission to FreeBSD 11.
Thu, Nov 9, 7:54 PM
sbruno accepted D12425: Cavium Liquidio 23xx Intelligent network adapter driver initial submission to FreeBSD 11.
Thu, Nov 9, 5:22 PM
sbruno added a comment to D12425: Cavium Liquidio 23xx Intelligent network adapter driver initial submission to FreeBSD 11.

Hi Bruno,

Are you expecting me to update the revision with the Makefile change?

Thanks
Prasad

Thu, Nov 9, 5:21 PM

Tue, Nov 7

sbruno updated the summary of D12976: Fix issue with VXLAN-encapsulated rx h/w checksum.
Tue, Nov 7, 8:19 PM
sbruno committed rS325498: Release shurd from mentorship..
Release shurd from mentorship.
Tue, Nov 7, 3:58 PM
sbruno closed D12795: Fix support for ifconfig's vlanhwtag flag..
Tue, Nov 7, 3:52 PM
sbruno committed rS325492: Fix ixgbe(4) support for ifconfig's vlanhwtag flag. Disabling this flag.
Fix ixgbe(4) support for ifconfig's vlanhwtag flag. Disabling this flag
Tue, Nov 7, 3:52 PM
sbruno committed rS325497: Add shurd <-> sbruno mentor relationship, so I can delete it..
Add shurd <-> sbruno mentor relationship, so I can delete it.
Tue, Nov 7, 3:52 PM
sbruno committed rS325494: Fix NOINET/NOINET6 build during compilation of iflib..
Fix NOINET/NOINET6 build during compilation of iflib.
Tue, Nov 7, 3:52 PM
sbruno created D12976: Fix issue with VXLAN-encapsulated rx h/w checksum.
Tue, Nov 7, 3:51 PM
sbruno updated the summary of D12976: Fix issue with VXLAN-encapsulated rx h/w checksum.
Tue, Nov 7, 3:51 PM
sbruno accepted D12876: Only chain non-LRO mbufs when LRO is not possible.
Tue, Nov 7, 3:51 PM
sbruno accepted D12896: bnxt: Add support for new phy_types and speeds - Part #2.
Tue, Nov 7, 3:51 PM

Sat, Nov 4

sbruno committed rS323509: The diff is the initial submission of Cavium Liquidio 2350/2360 10/25G.
The diff is the initial submission of Cavium Liquidio 2350/2360 10/25G
Sat, Nov 4, 8:50 AM
sbruno closed D11927: Cavium LiquidIo 2350/2360 10/25G Intelligent NIC driver Initial submission.
Sat, Nov 4, 8:50 AM

Tue, Oct 31

sbruno added inline comments to D11727: ixgbe(4): Update HEAD to use iflib.
Tue, Oct 31, 9:48 PM
sbruno accepted D12880: Preserve TSO checksum flags.
Tue, Oct 31, 6:54 PM
sbruno accepted D12876: Only chain non-LRO mbufs when LRO is not possible.

Found while testing the iflib'd version of ixgbe(4).

Tue, Oct 31, 5:39 PM
sbruno requested changes to D11727: ixgbe(4): Update HEAD to use iflib.

Ok, my report is due to the test systems disabling AIM in sysctl.conf.

Tue, Oct 31, 5:38 PM
sbruno accepted D12798: Possible fix for PR221990.
Tue, Oct 31, 5:26 PM
sbruno requested changes to D11727: ixgbe(4): Update HEAD to use iflib.

I found pretty bad behavior with LRO enabled on this change.

Tue, Oct 31, 5:29 AM
sbruno accepted D12842: Fix build with nodevice netmap.
Tue, Oct 31, 2:47 AM

Mon, Oct 30

sbruno accepted D12795: Fix support for ifconfig's vlanhwtag flag..

This looks good to me. Can you verify that this is merged into the ixgbe(4) IFLIB review as well?

Mon, Oct 30, 8:22 PM
sbruno accepted D12423: bnxt: Add support for new phy_types and speeds.
Mon, Oct 30, 8:19 PM
sbruno accepted D12805: Avoid enabling MSI-X if MSI-X is disabled globally..
Mon, Oct 30, 8:18 PM
sbruno accepted D12774: bnxt: HW_LRO Rx Pkt with > 32 fragments caused Crash (iflib).
Mon, Oct 30, 8:18 PM
sbruno accepted D12769: Fix PR222744 - netmap errors with iflib em driver.

stlgtm

Mon, Oct 30, 8:18 PM

Oct 25 2017

sbruno committed rS324994: Enable i386 build of the Cavium LiquidIO driver (lio) module..
Enable i386 build of the Cavium LiquidIO driver (lio) module.
Oct 25 2017, 5:49 PM
sbruno closed D12415: 32 Bit support for Cavium 23xx Intelligent Adapter driver.
Oct 25 2017, 5:49 PM
sbruno requested changes to D12425: Cavium Liquidio 23xx Intelligent network adapter driver initial submission to FreeBSD 11.
Oct 25 2017, 5:24 PM
sbruno accepted D12415: 32 Bit support for Cavium 23xx Intelligent Adapter driver.

Ran iperf3 test between two hosts booted into i386 and all seems to be well.

Oct 25 2017, 4:09 PM

Oct 24 2017

sbruno accepted D12599: bnxt: Add support for Flow control setting using sysctl.
Oct 24 2017, 8:18 PM
sbruno committed rP452783: Fix build on FreeBSD 10. (cpm@).
Fix build on FreeBSD 10. (cpm@)
Oct 24 2017, 4:44 PM

Oct 23 2017

sbruno accepted D12447: Some cache related optimizations.
Oct 23 2017, 7:00 PM
sbruno added a comment to D12447: Some cache related optimizations.

Ok, lets rename prefetch2() to something that indicates why there is a second function (being a bit pedantic here). something like prefetch_align() or whatever.

Do you like prefetch2cachelines() better?

Oct 23 2017, 5:37 PM

Oct 20 2017

sbruno committed rP452562: Update to capture some feature fixes:.
Update to capture some feature fixes:
Oct 20 2017, 9:28 PM

Oct 12 2017

sbruno committed rP451906: Repair a lock order reversion and remove mmap_fork_end() from fork_end().
Repair a lock order reversion and remove mmap_fork_end() from fork_end()
Oct 12 2017, 4:31 PM

Oct 10 2017

sbruno committed rS324508: match sendfile() error handling to send()..
match sendfile() error handling to send().
Oct 10 2017, 10:21 PM
sbruno closed D12633: match sendfile() error handling to send().
Oct 10 2017, 10:21 PM
sbruno committed rS324500: Hard link if_igb.ko to if_em.ko. Use a LINK directive to ensure that.
Hard link if_igb.ko to if_em.ko. Use a LINK directive to ensure that
Oct 10 2017, 7:14 PM
sbruno committed rS324459: Revert r324405 at the request of the submitter pending better solution..
Revert r324405 at the request of the submitter pending better solution.
Oct 10 2017, 12:32 AM

Oct 9 2017

sbruno added a comment to D12583: check so_error earlier in sosend_generic.

This seems pretty reasonable to me. Any objections? Can I get a transport@ review accept on this?

Oct 9 2017, 6:34 PM

Oct 7 2017

sbruno committed rS324406: Fix symlink if_igb.ko in -current such that its relative and doesn't.
Fix symlink if_igb.ko in -current such that its relative and doesn't
Oct 7 2017, 11:33 PM
sbruno closed D12575: Check so_error early in sendfile() call.
Oct 7 2017, 11:31 PM
sbruno committed rS324405: Check so_error early in sendfile() call. Prior to this patch, if a.
Check so_error early in sendfile() call. Prior to this patch, if a
Oct 7 2017, 11:31 PM

Oct 5 2017

sbruno accepted D12527: bnxt: intermittently VLAN ping doesn't work .

stlgtm

Oct 5 2017, 5:24 PM

Oct 2 2017

sbruno added a comment to D12425: Cavium Liquidio 23xx Intelligent network adapter driver initial submission to FreeBSD 11.

Does this version work on 32bit FreeBSD? Or are you waiting for us to review/commit the 32bit support review?

Oct 2 2017, 6:16 PM
sbruno accepted D12567: Update the process of creating new Wiki accounts.

Thanks!

Oct 2 2017, 6:09 PM

Sep 28 2017

sbruno abandoned D12466: Allow LOADER_TFTP_SUPPORT to work again.

The issues I was running into seem to be related to my attempts to use the old way/old documentation. I can tftp a kernel/ramdisk with the default options.

Sep 28 2017, 4:41 PM

Sep 27 2017

sbruno accepted D10535: ixgbe: Acquire lock for shared code API calls in handle_phy.
Sep 27 2017, 6:52 PM
D1305: Add Xfce FAQ in htdocs/ directory is now accepted and ready to land.

Huh ... I saw this review and noted that its still open. Is this still under evaluation?

Sep 27 2017, 6:51 PM
sbruno requested changes to D12423: bnxt: Add support for new phy_types and speeds.

I suspect this review needs to have stephen's comments addressed.

Sep 27 2017, 6:49 PM
sbruno requested changes to D12447: Some cache related optimizations.

Ok, lets rename prefetch2() to something that indicates why there is a second function (being a bit pedantic here). something like prefetch_align() or whatever.

Sep 27 2017, 6:47 PM
sbruno accepted D12454: ixgbe: Remove never defined UDP_IPV4_EX.
Sep 27 2017, 6:46 PM
sbruno accepted D12496: Fix "taskqgroup_attach: setaffinity failed: 3" with iflib drivers.
Sep 27 2017, 6:45 PM

Sep 23 2017

sbruno accepted D12439: Have ifmp_ring_enqueue() abdicate instead of switch to a consumer.
Sep 23 2017, 2:13 PM
sbruno accepted D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.
Sep 23 2017, 2:11 PM

Sep 22 2017

sbruno added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

I went back to the man page, just to validate. I used the example from the man page after rebuilding pxeboot with *defaults*. It defintely does not TFTP in this case.

Sep 22 2017, 11:00 PM
sbruno added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

Sep 22 2017, 8:16 PM
sbruno added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

Sep 22 2017, 6:27 PM
sbruno accepted D12449: Make struct grouptask gt_name member a char array.
Sep 22 2017, 5:34 PM
sbruno created D12466: Allow LOADER_TFTP_SUPPORT to work again.
Sep 22 2017, 3:42 PM
sbruno added a reviewer for D11869: sys/boot/geli build warning fixes: allanjude.
Sep 22 2017, 1:21 PM
sbruno added a comment to D12450: ixl: Fix mbuf hash type settings..

Did microsoft update the referenced link? I don't see the removal notice in it.

Sep 22 2017, 1:00 PM
sbruno added a comment to D12447: Some cache related optimizations.

Is there a reason that we don't modify prefetch() instead of creating a new prefetch2() function?

Sep 22 2017, 12:54 PM
sbruno accepted D12446: Support attaching tx queues to cpus.
Sep 22 2017, 12:53 PM
sbruno accepted D12445: Make the rx budget a tunable.
Sep 22 2017, 12:51 PM
sbruno accepted D12444: Chain mbufs before passing to if_input().
Sep 22 2017, 12:51 PM
sbruno accepted D12442: Some small packet performance improvements.
Sep 22 2017, 12:51 PM

Sep 21 2017

sbruno accepted D12448: Fix error (undeclared variable used) introduced in r323879.
Sep 21 2017, 11:21 PM