sbruno (Sean Bruno)
User

Projects (6)

User Details

User Since
May 26 2014, 3:41 PM (173 w, 4 d)

Recent Activity

Today

sbruno added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

Fri, Sep 22, 8:16 PM
sbruno added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

Fri, Sep 22, 6:27 PM
sbruno accepted D12449: Make struct grouptask gt_name member a char array.
Fri, Sep 22, 5:34 PM
sbruno created D12466: Allow LOADER_TFTP_SUPPORT to work again.
Fri, Sep 22, 3:42 PM
sbruno added a reviewer for D11869: sys/boot/geli build warning fixes: allanjude.
Fri, Sep 22, 1:21 PM
sbruno added a comment to D12450: ixl: Fix mbuf hash type settings..

Did microsoft update the referenced link? I don't see the removal notice in it.

Fri, Sep 22, 1:00 PM
sbruno added a comment to D12447: Some cache related optimizations.

Is there a reason that we don't modify prefetch() instead of creating a new prefetch2() function?

Fri, Sep 22, 12:54 PM
sbruno accepted D12446: Support attaching tx queues to cpus.
Fri, Sep 22, 12:53 PM
sbruno accepted D12445: Make the rx budget a tunable.
Fri, Sep 22, 12:51 PM
sbruno accepted D12444: Chain mbufs before passing to if_input().
Fri, Sep 22, 12:51 PM
sbruno accepted D12442: Some small packet performance improvements.
Fri, Sep 22, 12:51 PM

Yesterday

sbruno accepted D12448: Fix error (undeclared variable used) introduced in r323879.
Thu, Sep 21, 11:21 PM
sbruno accepted D12436: Improved logging of gtaskqueue failues.
Thu, Sep 21, 9:00 PM
sbruno accepted D12438: Fix M_GTASKQUEUE definition.
Thu, Sep 21, 7:52 PM
sbruno requested changes to D12436: Improved logging of gtaskqueue failues.
Thu, Sep 21, 7:51 PM
sbruno accepted D12410: bnxt: Enable support to run as a guest driver on VF attached VM.

Since there's no real way to test this on FreeBSD at the moment ...

Thu, Sep 21, 7:49 PM

Wed, Sep 13

sbruno committed rS323543: Don't (try to) build lio(4) if the SOURCELESS_UCODE is set..
Don't (try to) build lio(4) if the SOURCELESS_UCODE is set.
Wed, Sep 13, 3:17 PM
sbruno committed rS323518: Jenkins i386 LINT build uses NOTES to generate its LINT kernel config..
Jenkins i386 LINT build uses NOTES to generate its LINT kernel config.
Wed, Sep 13, 3:56 AM
sbruno accepted D12347: Fix GCC build failure caused by r323516.
Wed, Sep 13, 2:35 AM
sbruno accepted D12235: iflib rollup patch..
Wed, Sep 13, 1:15 AM

Tue, Sep 12

sbruno committed rS323512: Leave the Cavium Liquid IO driver exist in files, not files.amd64.
Leave the Cavium Liquid IO driver exist in files, not files.amd64
Tue, Sep 12, 11:58 PM
sbruno committed rS323510: Do not try to build the Cavium Liquidio driver on all architechtures..
Do not try to build the Cavium Liquidio driver on all architechtures.
Tue, Sep 12, 11:43 PM
sbruno added a comment to D11927: Cavium LiquidIo 2350/2360 10/25G Intelligent NIC driver Initial submission.

Since this driver explicitly refuses to compile on non-64bit architectures (where LP64 is not defined), I'm moving this to files.amd64 as I suspect that this was what was intended. Else this breaks every FreeBSD build.

Tue, Sep 12, 11:30 PM
sbruno accepted D11927: Cavium LiquidIo 2350/2360 10/25G Intelligent NIC driver Initial submission.
Tue, Sep 12, 11:04 PM
sbruno accepted D12235: iflib rollup patch..
Tue, Sep 12, 9:13 PM

Sat, Sep 9

sbruno committed rS323373: revert r323371 in prepartion for a proper fix.
revert r323371 in prepartion for a proper fix
Sat, Sep 9, 8:07 PM
sbruno committed rS323371: r323359 instroduced an ARMv8 only uart(4) device to the tree but placed.
r323359 instroduced an ARMv8 only uart(4) device to the tree but placed
Sat, Sep 9, 7:19 PM

Fri, Sep 8

sbruno accepted D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

stlgtm

Fri, Sep 8, 4:41 PM

Wed, Sep 6

sbruno accepted D12203: bnxt: Update firmware header file with the latest one.

This is a mass replacement of the header file defines. Its a lot of churn.

Wed, Sep 6, 5:38 PM
sbruno accepted D12128: bnxt: Use correct firmware ioctl to get number of Rx/Tx queues supported by firmware.
Wed, Sep 6, 5:37 PM
sbruno accepted D12226: Add myself to the committers-[ports|src].dot files It looks like I failed to do so when I got my ports bit....
Wed, Sep 6, 2:53 PM
sbruno accepted D12225: Announce my shiny new src bit.
Wed, Sep 6, 12:15 AM

Sat, Sep 2

sbruno committed rS323130: Upgrade Steven Hurd (shurd) to a src committer..
Upgrade Steven Hurd (shurd) to a src committer.
Sat, Sep 2, 5:16 PM

Wed, Aug 30

sbruno committed rS323027: Revert r323008 and its conversion of e1000/iflib to using SX locks..
Revert r323008 and its conversion of e1000/iflib to using SX locks.
Wed, Aug 30, 6:56 PM
sbruno added inline comments to D12137: Adaptively enable/disable entropy collection from packets.
Wed, Aug 30, 6:53 PM
sbruno requested changes to D12137: Adaptively enable/disable entropy collection from packets.

I *think* sbin/ifconfig/ifconfig.c needs to be modified with shortcuts for this with something like:

Wed, Aug 30, 6:52 PM
sbruno accepted D12140: fix iflib netmap rx.
Wed, Aug 30, 1:04 AM
sbruno closed D12101: swfw_sync DELAY -> sleep conversion by committing rS323008: Continuation of lock cleanup in e1000..
Wed, Aug 30, 12:20 AM · network
sbruno committed rS323008: Continuation of lock cleanup in e1000..
Continuation of lock cleanup in e1000.
Wed, Aug 30, 12:20 AM

Tue, Aug 29

sbruno accepted D12101: swfw_sync DELAY -> sleep conversion.
Tue, Aug 29, 10:30 PM · network
sbruno committed rP448937: Minor comment nit fix0r..
Minor comment nit fix0r.
Tue, Aug 29, 8:22 PM
sbruno committed rP448935: Remove the armv7 configuration when shutting down..
Remove the armv7 configuration when shutting down.
Tue, Aug 29, 6:23 PM

Fri, Aug 25

sbruno committed rP448742: Bump qemu-sbruno to chase qemu release candidates..
Bump qemu-sbruno to chase qemu release candidates.
Fri, Aug 25, 10:53 PM
sbruno committed rS322906: Add a different #define for the maximum number of transmit and.
Add a different #define for the maximum number of transmit and
Fri, Aug 25, 10:39 PM
sbruno requested changes to D11927: Cavium LiquidIo 2350/2360 10/25G Intelligent NIC driver Initial submission.

So far, so good. A couple of "nits" that I'd like you to consider first.

Fri, Aug 25, 8:23 PM
sbruno committed rS322900: Use counter(9) for PLPMTUD counters..
Use counter(9) for PLPMTUD counters.
Fri, Aug 25, 7:42 PM
sbruno closed D12003: Use counter(9) for PLPMTUD counters by committing rS322900: Use counter(9) for PLPMTUD counters..
Fri, Aug 25, 7:42 PM · transport
sbruno added a comment to D12101: swfw_sync DELAY -> sleep conversion.

Yeah, legacy em(4) device on em2:

Fri, Aug 25, 7:11 PM · network
sbruno added a comment to D12101: swfw_sync DELAY -> sleep conversion.

Huh .... Testing this review by itself this morning. I see the following startup panic:

Fri, Aug 25, 7:02 PM · network

Wed, Aug 23

sbruno committed rS322823: iflib: call device's if_init function during vlan initialization..
iflib: call device's if_init function during vlan initialization.
Wed, Aug 23, 9:51 PM
sbruno closed D12098: During VLAN creation, bnxt_init() seems to be getting invoked without bnxt_stop(). by committing rS322823: iflib: call device's if_init function during vlan initialization..
Wed, Aug 23, 9:51 PM

Aug 10 2017

sbruno committed rS322363: Purge deprecated locking macros..
Purge deprecated locking macros.
Aug 10 2017, 2:55 PM
sbruno committed rS322338: Don't leak mbufs if clusers exceeds the number of segments. This would.
Don't leak mbufs if clusers exceeds the number of segments. This would
Aug 10 2017, 3:43 AM
sbruno committed rS322337: Export IFCAP_HWSTATS so that we don't experience double stats counting.
Export IFCAP_HWSTATS so that we don't experience double stats counting
Aug 10 2017, 3:11 AM
sbruno committed rS322336: Add sbruno@ birthday information..
Add sbruno@ birthday information.
Aug 10 2017, 2:55 AM

Aug 9 2017

sbruno added a comment to D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

Latest e1000 driver seems to be following this ...

  1. em_if_timer() invokes iflib_admin_intr_deferred()
  2. iflib_admin_intr_deferred() triggers em_if_update_admin_status() to be invoked.

    Can I follow same in my driver?
Aug 9 2017, 4:07 PM

Aug 8 2017

sbruno committed rP447530: Pointyhat to me..
Pointyhat to me.
Aug 8 2017, 1:39 AM

Aug 7 2017

sbruno added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

@erj are you going to commit this once you've made the IXL updates required for it to function?

Aug 7 2017, 6:07 PM
sbruno added a comment to D9901: aacraid: try to fix internal locking versus bus_dma locking.

@scottl Can you respond to @avg here?

Aug 7 2017, 6:04 PM
sbruno accepted D11915: emulators/qemu-utils: Update to 2.9.0.

Fire away.

Aug 7 2017, 6:02 PM
sbruno requested changes to D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

IFLIB provides an ifdi_update_admin_status() function that is called periodically do that you don't have to manage the callout yourself. sys/dev/e1000/if_em.c does this as an example. Can this be changed to match the IFLIB implementation?

Aug 7 2017, 4:05 PM

Aug 3 2017

sbruno committed rP447189: Add a code block for the qemu-user enabled cross build environment. When using.
Add a code block for the qemu-user enabled cross build environment. When using
Aug 3 2017, 12:56 AM

Aug 2 2017

sbruno committed rP447129: Add a code block for the qemu-user enabled cross build environment. When using.
Add a code block for the qemu-user enabled cross build environment. When using
Aug 2 2017, 5:58 PM

Aug 1 2017

sbruno added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

I've tested 82599ES in single and LAGG configurations. This all seems good to me.

Aug 1 2017, 8:04 PM

Jul 31 2017

sbruno added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Can you update the review today to address Matt's changes in head that removed the extraneous config variable?

Jul 31 2017, 7:44 PM

Jul 28 2017

sbruno committed rS321658: binmiscctl should use modfind instead of kldfind.
binmiscctl should use modfind instead of kldfind
Jul 28 2017, 6:12 PM
sbruno added a comment to D11701: bnxt: Register for asynchronous link state notifications with firmware..

Ok, cool. If there's nothing to be done with this review, then "abandon" it so it closes out and goes away.

Jul 28 2017, 3:17 PM
sbruno added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.
In D11378#243724, @erj wrote:

@sbruno - I think Bartosz needed an update to the in-kernel ixl(4) for this to work properly.

@bartosz.sobczak_intel.com - I'm still working on fixing a critical SW6 bug; I need to get that fixed before I upstream the updated ixl(4) driver. I'm sorry for the delay, but it's difficult to debug.

Jul 28 2017, 12:37 AM

Jul 27 2017

sbruno committed rS321631: Drop IXL RX lock during TCP_LRO, fixes LOR mahem while holding the RX.
Drop IXL RX lock during TCP_LRO, fixes LOR mahem while holding the RX
Jul 27 2017, 11:01 PM
sbruno closed D11724: Drop ixl rx lock during TCP LRO by committing rS321631: Drop IXL RX lock during TCP_LRO, fixes LOR mahem while holding the RX.
Jul 27 2017, 11:01 PM · Intel Networking
sbruno closed D11476: iflib - try m_defrag when m_collapse fails by committing rS321630: Slight restructure of iflib_busdma_load_mbuf_sg() to fix accounting.
Jul 27 2017, 10:54 PM
sbruno committed rS321630: Slight restructure of iflib_busdma_load_mbuf_sg() to fix accounting.
Slight restructure of iflib_busdma_load_mbuf_sg() to fix accounting
Jul 27 2017, 10:54 PM
sbruno accepted D11724: Drop ixl rx lock during TCP LRO.
Jul 27 2017, 9:28 PM · Intel Networking
sbruno committed rS321629: Deprecate unused int isc_max_txqsets and int isc_max_rxqsets as they.
Deprecate unused int isc_max_txqsets and int isc_max_rxqsets as they
Jul 27 2017, 9:21 PM
sbruno accepted D11378: iWARP driver for Intel X722 Adapter - initial commit.

I will add this to the commit queue for today.

Jul 27 2017, 6:37 PM
sbruno added inline comments to D11727: ixgbe(4): Update HEAD to use iflib.
Jul 27 2017, 6:36 PM
sbruno accepted D11476: iflib - try m_defrag when m_collapse fails.
Jul 27 2017, 4:27 PM
sbruno added inline comments to D11727: ixgbe(4): Update HEAD to use iflib.
Jul 27 2017, 3:58 PM

Jul 26 2017

sbruno added inline comments to D11727: ixgbe(4): Update HEAD to use iflib.
Jul 26 2017, 7:06 PM

Jul 25 2017

sbruno requested changes to D11727: ixgbe(4): Update HEAD to use iflib.

These seem odd. Did they get disconnected from the driver?

Jul 25 2017, 8:16 PM
sbruno added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

*sigh* patch on FreeBSD sure doesn't like this review. I'm trying to find the "do what I tell you to do" command line switch to get this to apply.

Jul 25 2017, 4:10 PM
sbruno added inline comments to D11727: ixgbe(4): Update HEAD to use iflib.
Jul 25 2017, 3:55 PM
sbruno requested changes to D11701: bnxt: Register for asynchronous link state notifications with firmware..

Can this be regenerated after svn R321481? It seems like there was some cross-over between these two reviews and the diff isn't valid now.

Jul 25 2017, 3:39 PM
sbruno committed rS321481: bnxt: Implement interrupt coalescing options using sysctl..
bnxt: Implement interrupt coalescing options using sysctl.
Jul 25 2017, 3:33 PM
sbruno closed D11702: bnxt: Implement interrupt coalescing options using sysctl. by committing rS321481: bnxt: Implement interrupt coalescing options using sysctl..
Jul 25 2017, 3:33 PM
sbruno accepted D11702: bnxt: Implement interrupt coalescing options using sysctl..
Jul 25 2017, 3:32 PM
sbruno reopened D8225: Let congestion control algorithms decide congestion window..

This was reverted at svn R321480. I'm reopening for further discussion.

Jul 25 2017, 3:09 PM
sbruno committed rS321480: Revert r307901 - Inform CC modules about loss events..
Revert r307901 - Inform CC modules about loss events.
Jul 25 2017, 3:09 PM
sbruno reopened D8349: Setting ssthresh more accurately on loss..

I've reverted this from -current at svn R308180. Please discuss here.

Jul 25 2017, 3:03 PM
sbruno committed rS321479: Revert r308180 - Set slow start threshold more accurrately on loss ....
Revert r308180 - Set slow start threshold more accurrately on loss ...
Jul 25 2017, 3:03 PM
sbruno closed D11711: Fix LOR in if_lagg by committing rS321477: Don't hold the RM lock during lagg_proto_addport() to avoid an LOR..
Jul 25 2017, 2:42 PM
sbruno committed rS321477: Don't hold the RM lock during lagg_proto_addport() to avoid an LOR..
Don't hold the RM lock during lagg_proto_addport() to avoid an LOR.
Jul 25 2017, 2:42 PM
sbruno committed rS321476: Drop ixgbe RX lock during TCP_LRO processing. This eliminates a "storm".
Drop ixgbe RX lock during TCP_LRO processing. This eliminates a "storm"
Jul 25 2017, 2:38 PM
sbruno closed D11712: Drop ixgbe rx lock during TCP LRO by committing rS321476: Drop ixgbe RX lock during TCP_LRO processing. This eliminates a "storm".
Jul 25 2017, 2:38 PM · Intel Networking

Jul 24 2017

sbruno requested changes to D11701: bnxt: Register for asynchronous link state notifications with firmware..

Can this be regenerated from the base of the tree instead of sys/dev/bnxt ?

Jul 24 2017, 9:47 PM
sbruno requested changes to D11702: bnxt: Implement interrupt coalescing options using sysctl..

Can this review be regenerated from the base of the tree instead of inside sys/dev/bnxt ?

Jul 24 2017, 9:46 PM
sbruno accepted D11712: Drop ixgbe rx lock during TCP LRO.
Jul 24 2017, 8:02 PM · Intel Networking
sbruno added inline comments to D11712: Drop ixgbe rx lock during TCP LRO.
Jul 24 2017, 8:01 PM · Intel Networking
sbruno added inline comments to D11712: Drop ixgbe rx lock during TCP LRO.
Jul 24 2017, 3:57 PM · Intel Networking

Jul 21 2017

sbruno added a comment to D6448: Allow bigger number of packets to generate.

gnn: You want to grab this and commit it?

Jul 21 2017, 9:32 PM