sbruno (Sean Bruno)
User

Projects (6)

User Details

User Since
May 26 2014, 3:41 PM (165 w, 1 d)

Recent Activity

Today

sbruno requested changes to D11727: ixgbe(4): Update HEAD to use iflib.

These seem odd. Did they get disconnected from the driver?

Tue, Jul 25, 8:16 PM
sbruno added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

*sigh* patch on FreeBSD sure doesn't like this review. I'm trying to find the "do what I tell you to do" command line switch to get this to apply.

Tue, Jul 25, 4:10 PM
sbruno added inline comments to D11727: ixgbe(4): Update HEAD to use iflib.
Tue, Jul 25, 3:55 PM
sbruno requested changes to D11701: bnxt: Register for asynchronous link state notifications with firmware..

Can this be regenerated after svn R321481? It seems like there was some cross-over between these two reviews and the diff isn't valid now.

Tue, Jul 25, 3:39 PM
sbruno committed rS321481: bnxt: Implement interrupt coalescing options using sysctl..
bnxt: Implement interrupt coalescing options using sysctl.
Tue, Jul 25, 3:33 PM
sbruno closed D11702: bnxt: Implement interrupt coalescing options using sysctl. by committing rS321481: bnxt: Implement interrupt coalescing options using sysctl..
Tue, Jul 25, 3:33 PM
sbruno accepted D11702: bnxt: Implement interrupt coalescing options using sysctl..
Tue, Jul 25, 3:32 PM
sbruno reopened D8225: Let congestion control algorithms decide congestion window..

This was reverted at svn R321480. I'm reopening for further discussion.

Tue, Jul 25, 3:09 PM
sbruno committed rS321480: Revert r307901 - Inform CC modules about loss events..
Revert r307901 - Inform CC modules about loss events.
Tue, Jul 25, 3:09 PM
sbruno reopened D8349: Setting ssthresh more accurately on loss..

I've reverted this from -current at svn R308180. Please discuss here.

Tue, Jul 25, 3:03 PM
sbruno committed rS321479: Revert r308180 - Set slow start threshold more accurrately on loss ....
Revert r308180 - Set slow start threshold more accurrately on loss ...
Tue, Jul 25, 3:03 PM
sbruno closed D11711: Fix LOR in if_lagg by committing rS321477: Don't hold the RM lock during lagg_proto_addport() to avoid an LOR..
Tue, Jul 25, 2:42 PM
sbruno committed rS321477: Don't hold the RM lock during lagg_proto_addport() to avoid an LOR..
Don't hold the RM lock during lagg_proto_addport() to avoid an LOR.
Tue, Jul 25, 2:42 PM
sbruno committed rS321476: Drop ixgbe RX lock during TCP_LRO processing. This eliminates a "storm".
Drop ixgbe RX lock during TCP_LRO processing. This eliminates a "storm"
Tue, Jul 25, 2:38 PM
sbruno closed D11712: Drop ixgbe rx lock during TCP LRO by committing rS321476: Drop ixgbe RX lock during TCP_LRO processing. This eliminates a "storm".
Tue, Jul 25, 2:38 PM · Intel Networking

Yesterday

sbruno requested changes to D11701: bnxt: Register for asynchronous link state notifications with firmware..

Can this be regenerated from the base of the tree instead of sys/dev/bnxt ?

Mon, Jul 24, 9:47 PM
sbruno requested changes to D11702: bnxt: Implement interrupt coalescing options using sysctl..

Can this review be regenerated from the base of the tree instead of inside sys/dev/bnxt ?

Mon, Jul 24, 9:46 PM
sbruno accepted D11712: Drop ixgbe rx lock during TCP LRO.
Mon, Jul 24, 8:02 PM · Intel Networking
sbruno added inline comments to D11712: Drop ixgbe rx lock during TCP LRO.
Mon, Jul 24, 8:01 PM · Intel Networking
sbruno added inline comments to D11712: Drop ixgbe rx lock during TCP LRO.
Mon, Jul 24, 3:57 PM · Intel Networking

Fri, Jul 21

sbruno added a comment to D6448: Allow bigger number of packets to generate.

gnn: You want to grab this and commit it?

Fri, Jul 21, 9:32 PM
sbruno committed rP446348: Update host kernel signal state when using sa_sigaction..
Update host kernel signal state when using sa_sigaction.
Fri, Jul 21, 9:15 PM
sbruno added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

I don't think these are very significant, but I get the following warnings during a build:

Fri, Jul 21, 7:13 PM
sbruno committed rS321336: Do not update stats counter in SWI context. Defer to the already existing.
Do not update stats counter in SWI context. Defer to the already existing
Fri, Jul 21, 5:43 PM

Thu, Jul 20

sbruno accepted D11665: Some trivial style(9) fixes.
Thu, Jul 20, 1:48 AM

Wed, Jul 19

sbruno committed rS321257: Restore igb(4) code dropped during iflib conversion.
Restore igb(4) code dropped during iflib conversion
Wed, Jul 19, 10:41 PM
sbruno committed rS321253: Don't cache mbuf pointers if the number of descriptors is greater than.
Don't cache mbuf pointers if the number of descriptors is greater than
Wed, Jul 19, 9:18 PM

Tue, Jul 18

sbruno committed rP446169: Bump to 05.05.2017 release version..
Bump to 05.05.2017 release version.
Tue, Jul 18, 6:05 PM

Mon, Jul 17

sbruno abandoned D8532: ixgbe(4) Update driver API.

Yeah, this should be thrown into the abyss.

Mon, Jul 17, 7:42 PM
sbruno committed rP446108: Sync to QEMU for today..
Sync to QEMU for today.
Mon, Jul 17, 7:39 PM
sbruno added a comment to D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
In D11058#239815, @erj wrote:

This should be abandoned, right?

Mon, Jul 17, 7:34 PM

Sat, Jul 15

sbruno requested changes to D7350: PMC: Collect user call chains while in kernel space.

This review definitely needs D4227 updated and committed before it can land.

Sat, Jul 15, 4:27 PM
sbruno added a dependency for D7350: PMC: Collect user call chains while in kernel space: D4227: Implement per-thread counters for PMC sampling.
Sat, Jul 15, 4:26 PM
sbruno added a dependent revision for D4227: Implement per-thread counters for PMC sampling: D7350: PMC: Collect user call chains while in kernel space.
Sat, Jul 15, 4:26 PM
sbruno added inline comments to D11476: iflib - try m_defrag when m_collapse fails.
Sat, Jul 15, 12:54 AM

Thu, Jul 13

sbruno committed rS320953: Add 4k and NCQ_TRIM_BROKEN quirks for Samsung 845 SSDs..
Add 4k and NCQ_TRIM_BROKEN quirks for Samsung 845 SSDs.
Thu, Jul 13, 4:57 PM
sbruno closed D7967: CAM: Add 4k quirks for Samsung 845 enterprise series SSD by committing rS320953: Add 4k and NCQ_TRIM_BROKEN quirks for Samsung 845 SSDs..
Thu, Jul 13, 4:57 PM
sbruno accepted D7967: CAM: Add 4k quirks for Samsung 845 enterprise series SSD.
Thu, Jul 13, 4:55 PM
sbruno closed D9478: Add quirks for Samsung 750 EVO SSD by committing rS320948: Add 4K quirks for Samsung 750 EVO SSD.
Thu, Jul 13, 3:33 PM
sbruno committed rS320948: Add 4K quirks for Samsung 750 EVO SSD.
Add 4K quirks for Samsung 750 EVO SSD
Thu, Jul 13, 3:33 PM
sbruno commandeered D9478: Add quirks for Samsung 750 EVO SSD.
Thu, Jul 13, 2:59 PM

Wed, Jul 12

sbruno accepted D11542: Add deprecation notices for various device drivers removed in 12.0..

stlgtm

Wed, Jul 12, 6:44 PM
sbruno removed a reviewer for D11414: ixl: gcc build errors: jfv.
Wed, Jul 12, 6:00 PM
sbruno committed rS320917: MFC r320916.
MFC r320916
Wed, Jul 12, 5:51 PM
sbruno committed rS320916: Reset unsupported SFP tuneable back to original entry name..
Reset unsupported SFP tuneable back to original entry name.
Wed, Jul 12, 5:35 PM

Tue, Jul 11

sbruno committed rP445548: Bump after pull requests..
Bump after pull requests.
Tue, Jul 11, 8:03 PM

Sun, Jul 9

sbruno accepted D9478: Add quirks for Samsung 750 EVO SSD.
Sun, Jul 9, 4:29 PM

Fri, Jul 7

sbruno committed rP445283: Bump for today's pull request:.
Bump for today's pull request:
Fri, Jul 7, 9:02 PM
sbruno committed rP445254: Bump qemu-sbruno/qemu-user-static to capture fixes that are now required.
Bump qemu-sbruno/qemu-user-static to capture fixes that are now required
Fri, Jul 7, 2:14 PM

Wed, Jul 5

sbruno updated subscribers of D11476: iflib - try m_defrag when m_collapse fails.
Wed, Jul 5, 7:17 PM
sbruno requested changes to D11476: iflib - try m_defrag when m_collapse fails.
Wed, Jul 5, 7:16 PM

Mon, Jul 3

sbruno committed rS320616: Clear clang warning:.
Clear clang warning:
Mon, Jul 3, 7:49 PM
sbruno closed D11166: lib/libpcap build warning fixes by committing rS320616: Clear clang warning:.
Mon, Jul 3, 7:49 PM
sbruno committed rS320614: Add a sysctl to toggle the use of the sockets LOWAT when calculating auto….
Add a sysctl to toggle the use of the sockets LOWAT when calculating auto…
Mon, Jul 3, 7:40 PM
sbruno closed D11016: Add a sysctl to toggle the use of the sockets LOWAT when calculating auto window growth by committing rS320614: Add a sysctl to toggle the use of the sockets LOWAT when calculating auto….
Mon, Jul 3, 7:40 PM
sbruno committed rS320613: Garbage collect kernel option TWA_FLASH_FIRMWARE.
Garbage collect kernel option TWA_FLASH_FIRMWARE
Mon, Jul 3, 7:34 PM
sbruno closed D11387: Garbage collect kernel option TWA_FLASH_FIRMWARE by committing rS320613: Garbage collect kernel option TWA_FLASH_FIRMWARE.
Mon, Jul 3, 7:34 PM
sbruno committed rS320611: iflib - flib_busdma_load_mbuf_sg used isc_tx_maxsize as max semgent size..
iflib - flib_busdma_load_mbuf_sg used isc_tx_maxsize as max semgent size.
Mon, Jul 3, 7:24 PM
sbruno closed D11403: iflib - use proper max segment size for DMA by committing rS320611: iflib - flib_busdma_load_mbuf_sg used isc_tx_maxsize as max semgent size..
Mon, Jul 3, 7:24 PM
sbruno requested changes to D11403: iflib - use proper max segment size for DMA.
Mon, Jul 3, 6:38 PM
sbruno committed rS320609: bnxt(4) Enable LRO support, redux.
bnxt(4) Enable LRO support, redux
Mon, Jul 3, 6:23 PM
sbruno closed D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely. by committing rS320609: bnxt(4) Enable LRO support, redux.
Mon, Jul 3, 6:23 PM
sbruno accepted D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..
Mon, Jul 3, 3:03 PM

Sun, Jul 2

sbruno abandoned D11432: sbin/nvmecontrol: fix build.

This was fixed at r320522

Sun, Jul 2, 5:41 PM

Sat, Jul 1

sbruno updated the diff for D11432: sbin/nvmecontrol: fix build.

I perused the relevant values being assigned to len and resid. It
is ok to truncate the 64bit signed value to 32bit unsigned on x86_64
for this comparison.

Sat, Jul 1, 8:17 PM
sbruno added inline comments to D11432: sbin/nvmecontrol: fix build.
Sat, Jul 1, 4:57 PM

Fri, Jun 30

sbruno created D11432: sbin/nvmecontrol: fix build.
Fri, Jun 30, 9:50 PM

Tue, Jun 27

sbruno added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

Missing a man page. Probably needs something for share/man/man4. Maybe an iw_ixl(4) page?

Tue, Jun 27, 4:19 PM
sbruno added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

Module build is not connected vi sys/modules/Makefile

Tue, Jun 27, 4:18 PM
sbruno requested changes to D11378: iWARP driver for Intel X722 Adapter - initial commit.

This doesn't appear to be connected to the kernel build via sys/conf/files. It also does not have a kernel config option via sys/conf/options.

Tue, Jun 27, 4:17 PM

Jun 22 2017

sbruno added a comment to D11180: gnu/usr.bin/grep some build warning fixes.

I don't have any ETA on the switch to bsdgrep. Since we don't, I want to clean up the code that we are actively using first.

Jun 22 2017, 4:37 PM

Jun 20 2017

sbruno added inline comments to D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..
Jun 20 2017, 9:03 PM
sbruno added a comment to D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..

Have you looked at the kernel crash when adding a device to a ethernet bridge?

<Chenna>
Yes, I tried Ethernet bridge also, no issues seen.
#ifconfig bridge0 create
#ifconfig bridge0 addm bnxt0
No Stacktrace / Crash seen.

Note: I do not have em0 in my server so tried with bnxt0, bge0 and bge1, no Crash.

Jun 20 2017, 8:49 PM
sbruno added a comment to D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..

bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely.

Correction to earlier patch:
Realized that we have been invoking bit_alloc() by holding CTX_LOCK , i.e. from iflib_init_locked().
Corrected alloc and free invocations in following way, i.e. one from _register() and other from _deregister().

iflib_device_register() => iflib_queues_alloc() ==> bit_alloc(ifl_rx_bitmap)
iflib_device_deregister() ==> free(ifl_rx_bitmap)

Jun 20 2017, 3:51 PM

Jun 19 2017

sbruno committed rS320117: Direct commit to stable/10 to correctly setting the EIAC and IMS.
Direct commit to stable/10 to correctly setting the EIAC and IMS
Jun 19 2017, 3:56 PM
sbruno committed rS320102: Direct commit to stable/11 to correctly setting the EIAC and IMS.
Direct commit to stable/11 to correctly setting the EIAC and IMS
Jun 19 2017, 3:03 PM

Jun 18 2017

sbruno requested changes to D11170: cddl/usr.bin/zstreamdump build warning fixes.
Jun 18 2017, 10:48 PM
sbruno added inline comments to D11104: cddl/sbin/zpool build warning fixes.
Jun 18 2017, 8:33 PM

Jun 17 2017

sbruno added a comment to D10385: Remove many write-only variables from kernel.
In D10385#215182, @erj wrote:

@sbruno is it ok to remove "first" in igb_txrx.c? It looks like it might be a leftover from the pre-iflib converted version of the driver, but I don't know if it was intended to be used for something in the current version.

Jun 17 2017, 8:24 PM
sbruno requested changes to D11068: tests/sys/geom build warning fixes.

Instead of casting to const char *, can you investigate actually changing and/or making the variable type consistent (either const char [] or const uint8_t [])?

Jun 17 2017, 7:37 PM
sbruno added a reviewer for D9478: Add quirks for Samsung 750 EVO SSD: j-nitrology.com.
Jun 17 2017, 7:10 PM
sbruno requested changes to D11166: lib/libpcap build warning fixes.

The old code will always #define SOLARIS with a value of 1 or 0. (true/false)

Jun 17 2017, 7:09 PM
sbruno added reviewers for D11166: lib/libpcap build warning fixes: dim, emaste.
Jun 17 2017, 7:02 PM
sbruno added reviewers for D11100: cddl/sbin/zfs build warning fixes: avg, allanjude.
Jun 17 2017, 7:00 PM
sbruno added a comment to D11100: cddl/sbin/zfs build warning fixes.

I think this should go upstream (https://github.com/openzfs/openzfs) but they are happy to have it come from FreeBSD or just be directly to their github.

Jun 17 2017, 7:00 PM
sbruno added reviewers for D11104: cddl/sbin/zpool build warning fixes: avg, allanjude.
Jun 17 2017, 6:58 PM
sbruno added reviewers for D11170: cddl/usr.bin/zstreamdump build warning fixes: avg, allanjude.
Jun 17 2017, 6:46 PM
sbruno added reviewers for D11171: cddl/usr.bin/ztest build warning fixes: allanjude, avg.
Jun 17 2017, 6:46 PM
sbruno requested changes to D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..
Jun 17 2017, 6:35 PM
sbruno added a comment to D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..

Panic when adding a device to an active bridge device:

Jun 17 2017, 6:35 PM
sbruno added a comment to D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..

LOR with GENERIC:

Jun 17 2017, 6:33 PM
sbruno reopened D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..

I have reverted this at svn revision 320059.

Jun 17 2017, 5:43 PM
sbruno committed rS320059: Revert r319989 "bnxt(4) Enable LRO support".
Revert r319989 "bnxt(4) Enable LRO support"
Jun 17 2017, 5:43 PM

Jun 16 2017

sbruno committed rS320033: TCP Wrappers: tcpdchk (tcp wrapper configuration checker) and tcpdmatch.
TCP Wrappers: tcpdchk (tcp wrapper configuration checker) and tcpdmatch
Jun 16 2017, 10:32 PM
sbruno closed D10995: tcp: tcpdchk & tcpdmatch: warning fixes by committing rS320033: TCP Wrappers: tcpdchk (tcp wrapper configuration checker) and tcpdmatch.
Jun 16 2017, 10:32 PM
sbruno added a reviewer for D11178: cddl/usr.sbin/zdb build warning fixes: avg.
Jun 16 2017, 8:05 PM
sbruno committed rS320009: Quiesce clang warning while building lpc..
Quiesce clang warning while building lpc.
Jun 16 2017, 8:01 PM
sbruno closed D11019: usr.sbin/lpr/lpc: build warning fixes by committing rS320009: Quiesce clang warning while building lpc..
Jun 16 2017, 8:01 PM
sbruno accepted D11019: usr.sbin/lpr/lpc: build warning fixes.
Jun 16 2017, 5:54 PM
sbruno added a reviewer for D11012: usr.sbin/sendmail: build warnings fixed: gshapiro.
Jun 16 2017, 4:24 PM