- User Since
- May 26 2014, 3:41 PM (165 w, 1 d)
These seem odd. Did they get disconnected from the driver?
*sigh* patch on FreeBSD sure doesn't like this review. I'm trying to find the "do what I tell you to do" command line switch to get this to apply.
Can this be regenerated after svn R321481? It seems like there was some cross-over between these two reviews and the diff isn't valid now.
This was reverted at svn R321480. I'm reopening for further discussion.
I've reverted this from -current at svn R308180. Please discuss here.
Can this be regenerated from the base of the tree instead of sys/dev/bnxt ?
Can this review be regenerated from the base of the tree instead of inside sys/dev/bnxt ?
Fri, Jul 21
gnn: You want to grab this and commit it?
I don't think these are very significant, but I get the following warnings during a build:
Thu, Jul 20
Wed, Jul 19
Tue, Jul 18
Mon, Jul 17
Yeah, this should be thrown into the abyss.
Sat, Jul 15
This review definitely needs D4227 updated and committed before it can land.
Thu, Jul 13
Wed, Jul 12
Tue, Jul 11
Sun, Jul 9
Fri, Jul 7
Wed, Jul 5
Mon, Jul 3
Sun, Jul 2
Sat, Jul 1
I perused the relevant values being assigned to len and resid. It
is ok to truncate the 64bit signed value to 32bit unsigned on x86_64
for this comparison.
Fri, Jun 30
Tue, Jun 27
Missing a man page. Probably needs something for share/man/man4. Maybe an iw_ixl(4) page?
Module build is not connected vi sys/modules/Makefile
This doesn't appear to be connected to the kernel build via sys/conf/files. It also does not have a kernel config option via sys/conf/options.
Jun 22 2017
I don't have any ETA on the switch to bsdgrep. Since we don't, I want to clean up the code that we are actively using first.
Jun 20 2017
Jun 19 2017
Jun 18 2017
Jun 17 2017
Instead of casting to const char *, can you investigate actually changing and/or making the variable type consistent (either const char  or const uint8_t )?
The old code will always #define SOLARIS with a value of 1 or 0. (true/false)
Panic when adding a device to an active bridge device:
LOR with GENERIC:
I have reverted this at svn revision 320059.