Feed Advanced Search

Yesterday

sbruno added a comment to D14279: fixed amd type flash write opration and diaplay chip infomation at boot.

I will compile commit this review.

Thu, Jun 21, 4:04 PM
sbruno accepted D14279: fixed amd type flash write opration and diaplay chip infomation at boot.
Thu, Jun 21, 4:03 PM
sbruno accepted D15804: Keep --forward when using PATCH_DEBUG..
Thu, Jun 21, 1:24 PM

Wed, Jun 20

sbruno accepted D15927: Update ixl(4) man page.
Wed, Jun 20, 6:05 PM

Tue, Jun 19

sbruno added a comment to D10052: sparc64 EARLY_AP_STARTUP.

Hrm ... this patch seems like abandon ware to me. Is it still relevant?

Tue, Jun 19, 9:17 PM
sbruno added a comment to D1305: Add Xfce FAQ in htdocs/ directory.

bump. @olivierd Do you intend to commit this or do you need a doc committer to finish this off?

Tue, Jun 19, 9:16 PM
sbruno updated subscribers of D7350: PMC: Collect user call chains while in kernel space.

@jtl Can you close this as it appears @mmacy committed functionally the same thing? Or is there work yet to be done here?

Tue, Jun 19, 9:14 PM
sbruno added a comment to D15560: Use a spin lock to serialize updates on AMD CPUs..

bump. @markj Did you want to shovel this into head?

Tue, Jun 19, 9:12 PM
sbruno accepted D9655: Add src.conf knob to disable the installation of /var/db/services.db.

Heh, I can accept my own revision. :-)

Tue, Jun 19, 9:09 PM
sbruno committed rS335386: MK_EFI - Add uefisign and friends to this knob and ensure that we don't.
MK_EFI - Add uefisign and friends to this knob and ensure that we don't
Tue, Jun 19, 9:07 PM
sbruno closed D15211: Add uefisign and friends to MK_EFI.
Tue, Jun 19, 9:07 PM
sbruno added reviewers for D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4): erj, mmacy.
Tue, Jun 19, 9:04 PM
sbruno committed rS335379: Set prev to NULL so its garaunteed to have a value of some kind and.
Set prev to NULL so its garaunteed to have a value of some kind and
Tue, Jun 19, 6:09 PM
sbruno committed rS335372: Remove "diff" line indicator. Next to see if this code works or not..
Remove "diff" line indicator. Next to see if this code works or not.
Tue, Jun 19, 3:55 PM

Tue, Jun 12

sbruno accepted D15727: Quiet coretemp probe.
Tue, Jun 12, 7:46 PM
sbruno updated the diff for D9655: Add src.conf knob to disable the installation of /var/db/services.db.

After building the src.conf man page, update the WITHOUT_SERVICESDB entry to
generate something that looks more sensible.

Tue, Jun 12, 7:43 PM
sbruno committed rS335011: WITHOUT_NLS cleanup of more empty dirs..
WITHOUT_NLS cleanup of more empty dirs.
Tue, Jun 12, 7:26 PM
sbruno closed D15626: WITHOUT_NLS cleanup of more empty dirs.
Tue, Jun 12, 7:26 PM
sbruno committed rS335010: cpucontrol:.
cpucontrol:
Tue, Jun 12, 6:59 PM
sbruno closed D15574: cpucontrol: fix debugging for family on AMD cpus and add useful debugging..
Tue, Jun 12, 6:59 PM
sbruno updated the diff for D15211: Add uefisign and friends to MK_EFI.

Sort by alpha as per @emaste.

Tue, Jun 12, 6:56 PM
sbruno accepted D15754: Fix build of liquidio with base gcc on i386.

stlgtm

Tue, Jun 12, 3:42 PM

Sat, Jun 9

sbruno accepted D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

Adding my "ok" pending bnxt review by @shurd

Sat, Jun 9, 9:25 PM

Thu, Jun 7

sbruno committed rS334788: Unbreak dtrace runtime for udp after svn r334719 SO_REUSEPORT commit..
Unbreak dtrace runtime for udp after svn r334719 SO_REUSEPORT commit.
Thu, Jun 7, 3:27 PM

Wed, Jun 6

sbruno closed D11003: Load balance sockets with new SO_REUSEPORT_LB option.
Wed, Jun 6, 3:46 PM
sbruno committed rS334719: Load balance sockets with new SO_REUSEPORT_LB option..
Load balance sockets with new SO_REUSEPORT_LB option.
Wed, Jun 6, 3:46 PM

Fri, Jun 1

sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.
 root@lab:/home/sbruno/bsd/fbsd_head # env | grep SRCCONF
 SRCCONF=/home/sbruno/bsd/src.conf.efitest
 root@lab:/home/sbruno/bsd/fbsd_head # cat ${SRCCONF}
 WTTHOUT_EFI="YES"
 root@lab:/home/sbruno/bsd/fbsd_head # make delete-old DESTDIR=/tftpboot/netboot
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
>>> Old directories removed
 To remove old libraries run 'make delete-old-libs'.
 root@lab:/home/sbruno/bsd/fbsd_head # make delete-old MK_EFI=no DESTDIR=/tftpboot/netboot                                                                                                                                                    
>>> Removing old files (only deletes safe to delete libs)
 remove /tftpboot/netboot/usr/sbin/efibootmgr?
Fri, Jun 1, 8:44 PM
sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.

Is setting it in the environment expected to work? What about make SRCCONF=/foo/bar/baz ...?

Fri, Jun 1, 2:06 PM
sbruno updated the diff for D15211: Add uefisign and friends to MK_EFI.

Don't nuke *all* the efi tools if OPENSSL isn't installed. (imp)

Fri, Jun 1, 2:06 PM

Thu, May 31

sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.

hrm ... WITH_EFI="NO" has zero effect as well. So, I'm stumped.

Thu, May 31, 6:58 PM
sbruno accepted D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Pending no further review comments, this will go in the tree on Monday, May 31. That way folks can yell at me when we all get together in Ottawa.

Thu, May 31, 6:31 PM
sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.
root@lab:/home/sbruno/bsd/fbsd_head # env | grep SRCCONF
SRCCONF=/home/sbruno/bsd/src.conf.efitest
root@lab:/home/sbruno/bsd/fbsd_head # cat ${SRCCONF}
WTTHOUT_EFI="YES"
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old DESTDIR=/tftpboot/netboot
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old MK_EFI=no DESTDIR=/tftpboot/netboot                                                                                                                                                    
>>> Removing old files (only deletes safe to delete libs)
remove /tftpboot/netboot/usr/sbin/efibootmgr?
Thu, May 31, 6:20 PM
sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.

WITHOUT_EFI="YES" seems to do nothing.

Thu, May 31, 6:17 PM
sbruno updated the diff for D15211: Add uefisign and friends to MK_EFI.

Exclude MK_EFI things if OPENSSL is unset with some better
syntax.

Thu, May 31, 6:06 PM
sbruno updated the diff for D15211: Add uefisign and friends to MK_EFI.

Add missing LDIRS for uefisign

Thu, May 31, 3:44 PM
sbruno added inline comments to D15211: Add uefisign and friends to MK_EFI.
Thu, May 31, 3:42 PM

Wed, May 30

sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.
In D15211#329987, @imp wrote:

No, we've always just used efiFOO for the efi programs.

Oh, so you're saying that "uefisign" should be a symlink to efisign? I don't know the background here.

Yeah, we had efi in the loader from before UEFI existed, and now also have efibootmgr, efidp and efivar userland binaries.

Wed, May 30, 9:35 PM
sbruno accepted D15526: reduce overhead of entropy collection.
Wed, May 30, 9:19 PM
sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.
In D15211#329987, @imp wrote:

No, we've always just used efiFOO for the efi programs.

Wed, May 30, 8:22 PM
sbruno created D15626: WITHOUT_NLS cleanup of more empty dirs.
Wed, May 30, 7:59 PM
sbruno added a comment to D15211: Add uefisign and friends to MK_EFI.
In D15211#320576, @imp wrote:

while you're here, maybe it's time to do the uefisign -> efisign with a legacy link.

Wed, May 30, 4:21 PM
sbruno updated the diff for D15211: Add uefisign and friends to MK_EFI.

Regenerate after some of the pkg base stuff hit the tree.

Wed, May 30, 4:20 PM

Tue, May 29

sbruno requested changes to D11003: Load balance sockets with new SO_REUSEPORT_LB option.

@johalun0_gmail.com Can this be regenerated against head when you get to it in the morning?

Tue, May 29, 11:14 PM
sbruno committed rS334357: dumpon(8).
dumpon(8)
Tue, May 29, 9:52 PM

Mon, May 28

sbruno committed rP471058: sysutils/devcpu-data.
sysutils/devcpu-data
Mon, May 28, 5:08 PM
sbruno closed D15523: sysutils/devcpu-data: Update AMD microcode..
Mon, May 28, 5:08 PM
sbruno committed rP471047: audio/idjc.
audio/idjc
Mon, May 28, 2:58 PM
sbruno closed D15555: audio/idjc audio/shout-idjc.
Mon, May 28, 2:58 PM
sbruno updated the diff for D15555: audio/idjc audio/shout-idjc.

Remove MACRO for pyo files

Mon, May 28, 2:48 PM
sbruno added inline comments to D15555: audio/idjc audio/shout-idjc.
Mon, May 28, 2:29 PM

Sun, May 27

sbruno committed rS334263: r334229 mismerged and broke kernel options CAM_IOSCHED_DYNAMIC..
r334229 mismerged and broke kernel options CAM_IOSCHED_DYNAMIC.
Sun, May 27, 11:52 PM
sbruno updated the diff for D15555: audio/idjc audio/shout-idjc.

Resort pkg-plist via makeplist.

Sun, May 27, 8:06 PM
sbruno committed rP470986: audio/clementine-player.
audio/clementine-player
Sun, May 27, 3:05 PM
sbruno closed D15544: audio/clementine-player -- sync to github.
Sun, May 27, 3:05 PM

Sat, May 26

sbruno committed rS334251: Activate Wake On Lan features for Ice Lake and Cannon Lake devices..
Activate Wake On Lan features for Ice Lake and Cannon Lake devices.
Sat, May 26, 9:59 PM
sbruno committed rS334246: Activate Wake On Lan features for Ice Lake and Cannon Lake devices..
Activate Wake On Lan features for Ice Lake and Cannon Lake devices.
Sat, May 26, 8:02 PM

Fri, May 25

sbruno committed rS334229: MFC r323829.
MFC r323829
Fri, May 25, 11:18 PM
sbruno committed rS334215: pmcstat(8).
pmcstat(8)
Fri, May 25, 6:11 PM
sbruno closed D15549: Document per thread pmcstat(8) filtering.
Fri, May 25, 6:11 PM
sbruno added inline comments to D15574: cpucontrol: fix debugging for family on AMD cpus and add useful debugging..
Fri, May 25, 6:02 PM
sbruno added a comment to D15523: sysutils/devcpu-data: Update AMD microcode..

My spider sense is tingling as well.

Fri, May 25, 6:00 PM
sbruno accepted D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
Fri, May 25, 5:58 PM
sbruno added a dependent revision for D15574: cpucontrol: fix debugging for family on AMD cpus and add useful debugging.: D15523: sysutils/devcpu-data: Update AMD microcode..
Fri, May 25, 5:18 PM
sbruno added a dependency for D15523: sysutils/devcpu-data: Update AMD microcode.: D15574: cpucontrol: fix debugging for family on AMD cpus and add useful debugging..
Fri, May 25, 5:18 PM
sbruno created D15574: cpucontrol: fix debugging for family on AMD cpus and add useful debugging..
Fri, May 25, 5:17 PM
sbruno added a comment to D15523: sysutils/devcpu-data: Update AMD microcode..
In D15523#328831, @cem wrote:

cpucontrol print on multiple input files could be a lot more clear :(. I disambiguated it by copying fam17h to its own directory:

$ mkdir tmp
$ cp -a work/stage/usr/local/share/cpucontrol/microcode_amd_fam17h.bin tmp
$ sudo cpucontrol -vvv -n -d ./tmp -u /dev/cpuctl0
amd10h_probe: family: 0x17
cpucontrol: skipping ./tmp/.: is a directory
cpucontrol: skipping ./tmp/..: is a directory
amd10h_update: signature: 0x800f11
cpucontrol: found cpu family 0xf model 0x1 stepping 0x1 extfamily 0x8 extmodel 0.
cpucontrol: microcode revision 0x8001129
amd10h_update: installed_cpu: 0x600f20
amd10h_update: installed_cpu: 0x610f01
amd10h_update: installed_cpu: 0x700f01
amd10h_update: installed_cpu: 0x800f12
amd10h_update: installed_cpu: 0x800f11
cpucontrol: equiv_id: 8011
$ echo $?
0

Nothing in /var/log/messages. Patch level is 0x8001129 per x86info.

This is on TR (fam 17h). Does that help? :-)

Fri, May 25, 4:58 PM
sbruno added a comment to D15523: sysutils/devcpu-data: Update AMD microcode..

Hrm. I guess this *is* working, at least for the EPYC I have at work.

Fri, May 25, 4:06 PM
sbruno added a comment to D15523: sysutils/devcpu-data: Update AMD microcode..

Trying out some debugging here. Can someone apply this patch
https://people.freebsd.org/~sbruno/cpucontrol.diff.txt

And send me the results of something like the following?

I get the same output, i.e., "CPU is not found in the equivalence table" for all files.

Fri, May 25, 3:39 PM
sbruno updated the diff for D15523: sysutils/devcpu-data: Update AMD microcode..

Update to catch linux-firmware commit 7518922bd5b98b137af7aaf3c836f5a498e91609

Fri, May 25, 3:30 PM

Thu, May 24

sbruno accepted D15560: Use a spin lock to serialize updates on AMD CPUs..

This had no effect on my AMD FX-8150, which is to be expected.

Thu, May 24, 7:46 PM
sbruno added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

Thu, May 24, 6:17 PM ยท Intel Networking
sbruno updated the summary of D15555: audio/idjc audio/shout-idjc.
Thu, May 24, 3:38 PM
sbruno created D15555: audio/idjc audio/shout-idjc.
Thu, May 24, 3:34 PM
sbruno updated the diff for D15544: audio/clementine-player -- sync to github.

Adapt tag settings to provide a pkg version that is compatible
with old versioning and possible new versioning.

Thu, May 24, 12:52 PM
sbruno created D15544: audio/clementine-player -- sync to github.
Thu, May 24, 1:39 AM

Wed, May 23

sbruno accepted D15526: reduce overhead of entropy collection.

Pending trivial cleanups pointed out by @cem , approved.

Wed, May 23, 11:15 PM
sbruno added a comment to D11003: Load balance sockets with new SO_REUSEPORT_LB option.
In D11003#327485, @jtl wrote:

Is everyone on this review fine with me committing this? With the inheritance code removed, I believe there are no further objections or questions.

Have you addressed all of @rwatson's comments?

I've been meaning to review this, but have been delayed. I would appreciate a few extra days to look it over.

Wed, May 23, 8:58 PM
sbruno added a comment to D15523: sysutils/devcpu-data: Update AMD microcode..

Trying out some debugging here. Can someone apply this patch
https://people.freebsd.org/~sbruno/cpucontrol.diff.txt

Wed, May 23, 3:20 PM
sbruno added a comment to D15523: sysutils/devcpu-data: Update AMD microcode..

On my AMD Ryzen Threadripper 1950X I see Microcode patch level: 0x8001127 before and after trying the microcode in this review (i.e., the new microcode_amd_fam17h.bin either does not contain microcode for Threadripper, or is not getting applied).

Wed, May 23, 2:43 PM
sbruno added a comment to D15523: sysutils/devcpu-data: Update AMD microcode..
In D15523#327855, @jmd wrote:

On a AMD Threadripper 1900X I see "microcode updating..." and output of the CPU information. On a Carrizo APU, I see "microcode updating..." and "done", nothing else. How to check it DTRT?

Wed, May 23, 2:31 PM

May 22 2018

sbruno added reviewers for D15523: sysutils/devcpu-data: Update AMD microcode.: cem, eadler.
May 22 2018, 5:26 PM
sbruno added a comment to D15523: sysutils/devcpu-data: Update AMD microcode..

On my FX-8150, previous update was:

May 22 2018, 5:25 PM
sbruno created D15523: sysutils/devcpu-data: Update AMD microcode..
May 22 2018, 5:25 PM
sbruno accepted D15520: Apply Linux's workaround for Broadwell ucode update issues..

I don't believe that I have access to a Broadwell host at the moment. However, this works fine for my machines.

May 22 2018, 3:10 PM
sbruno committed rP470620: sysutils/devcpu-data:.
sysutils/devcpu-data:
May 22 2018, 3:09 PM

May 21 2018

sbruno added a comment to D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Is everyone on this review fine with me committing this? With the inheritance code removed, I believe there are no further objections or questions.

May 21 2018, 9:04 PM

May 20 2018

sbruno accepted D15497: update py-monotonic to 1.5.
May 20 2018, 3:18 PM
sbruno accepted D15496: Update django-bootstrap-form to 3.4, support newer django.
May 20 2018, 3:18 PM
sbruno accepted D15495: Update py-Faker to 0.8.15.
May 20 2018, 3:18 PM
sbruno accepted D15494: update django-countries to 5.3.
May 20 2018, 3:17 PM
sbruno accepted D15493: update python websocket-client to 0.47.0.
May 20 2018, 3:17 PM

May 19 2018

sbruno accepted D15387: Migrate top(1) to usr.bin.

Do you need to update ObsoleteFiles in order to remove the old version?

This is just moving the source files. It installs to the same place.

May 19 2018, 9:32 PM
sbruno added a comment to D15387: Migrate top(1) to usr.bin.

Do you need to update ObsoleteFiles in order to remove the old version?

May 19 2018, 9:05 PM
sbruno added inline comments to D15486: fix set but not used warnings.
May 19 2018, 2:41 AM

May 18 2018

sbruno committed rP470321: games/cockatrice.
games/cockatrice
May 18 2018, 7:36 PM
sbruno closed D15416: games/cockatrice: Add server component.
May 18 2018, 7:36 PM
sbruno committed rS333801: Quiesce a couple pages of clang warnings with a cast. Duplicates.
Quiesce a couple pages of clang warnings with a cast. Duplicates
May 18 2018, 5:23 PM
sbruno closed D15476: Quiesce build errors with cast to u_int8_t.
May 18 2018, 5:23 PM
sbruno added inline comments to D15476: Quiesce build errors with cast to u_int8_t.
May 18 2018, 5:13 PM
sbruno updated the summary of D15476: Quiesce build errors with cast to u_int8_t.
May 18 2018, 1:58 PM