Page MenuHomeFreeBSD
Feed Advanced Search

Fri, Dec 14

sbruno accepted D18505: Remove the timed daemon..

stlgtm

Fri, Dec 14, 2:09 PM
sbruno added inline comments to D18505: Remove the timed daemon..
Fri, Dec 14, 2:03 PM

Mon, Dec 10

sbruno accepted D18502: sysutils/intel-nvmupdate: Remove obsolete chmod workaround.
Mon, Dec 10, 4:05 PM · Intel Networking
sbruno accepted D18467: devel/staf: Use ${RLN} instead of ${LN} in do-install.
Mon, Dec 10, 4:03 PM
sbruno accepted D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status.
Mon, Dec 10, 4:03 PM
sbruno accepted D18469: ix: Fix accessing wrong register, improve WoL support recognition ix, ixv: Update link status with autonegotiated baudrate value.
Mon, Dec 10, 3:49 PM
sbruno accepted D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.

I guess this will wait for @jeffrey.e.pieper_intel.com to test or approve? This looks correct to my eye.

Mon, Dec 10, 3:42 PM
sbruno accepted D17806: ppc64: handle exception 0x1500 (soft patch).

Agreed. Feel free to commit this at your leisure.

Mon, Dec 10, 1:30 PM

Sun, Dec 9

sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).
panic: Memory modified after free 0xc0000000e2f31580(32) val=0 @ 0xc0000000e2f31580
Sun, Dec 9, 9:13 PM
sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).
FreeBSD pylon.nyi.freebsd.org 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r341766M: Sun Dec  9 18:59:51 UTC 2018     sbruno@build-13.freebsd.org:/usr/obj/powerpc.powerpc64/usr/src/sys/CLUSTER13  powerpc
Sun, Dec 9, 8:32 PM
sbruno requested changes to D17806: ppc64: handle exception 0x1500 (soft patch).

This panic is fairly reliable on our Power8 box. Is it related to this change or is it unrelated? I'm not convinced this panic should keep this review blocked as it resolves other things.

panic: Memory modified after free 0xc0000000850584a0(32) val=0 @ 0xc0000000850584a0
Sun, Dec 9, 6:55 PM

Sat, Dec 8

sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

The reason of segmentation fault when treating the 0x1500 exception
was because it was being treated as a non-hypervisor trap, which
consider the registers srr0/srr1. As this trap is an hypervisor one,
the values were being placed in hsrr0/hsrr1.
Just changed the enter point for hypertrap, which saves the value of
hsrr0 and hsrr1 in srr0 and srr1.

Sat, Dec 8, 1:54 PM

Thu, Dec 6

sbruno committed rS341643: Change u32 to uint32_t to allow the native-xtools target to build.
Change u32 to uint32_t to allow the native-xtools target to build
Thu, Dec 6, 6:59 PM

Wed, Dec 5

sbruno accepted D18438: net/intel-ixl-kmod: Update from 1.9.13 to 1.10.4.
Wed, Dec 5, 6:05 PM · Intel Networking
sbruno accepted D18440: devel/staf: Unbreak for openssl111.
Wed, Dec 5, 6:05 PM

Tue, Dec 4

sbruno committed rS341453: Revert r340997 at the request of multiple users..
Revert r340997 at the request of multiple users.
Tue, Dec 4, 3:23 AM

Mon, Dec 3

sbruno added reviewers for D18420: add a method to defer destruction of if_softc to if_destroy: jtl, glebius.
Mon, Dec 3, 2:47 PM

Sun, Dec 2

sbruno added a reviewer for D18408: PR209468: aacraid fixes to work with newer controller firmware: mav.
Sun, Dec 2, 4:14 PM
sbruno added reviewers for D18408: PR209468: aacraid fixes to work with newer controller firmware: scottl, scott.benesh_microsemi.com.
Sun, Dec 2, 4:14 PM
sbruno added reviewers for D18402: netmap: ixgbe: add support for jumbo frames: shurd, Intel Networking.
Sun, Dec 2, 4:06 PM

Fri, Nov 30

sbruno accepted D18382: Add new "trim" conversion for dd(1).
Fri, Nov 30, 2:36 AM

Wed, Nov 28

sbruno added a comment to D10776: Make Capsicum obligatory..

Is it acceptable if some binaries fail?

This has become a real issue - @sbruno found wc did not work on ERL, fixed in rS341140. This is somewhat independent of whether we have the #ifdefs or not though.

Wed, Nov 28, 7:02 PM
sbruno committed rS341140: Add CAPABILITIES to the ERL kernel config so that tools that have been.
Add CAPABILITIES to the ERL kernel config so that tools that have been
Wed, Nov 28, 1:26 PM

Sat, Nov 17

sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

Oof. I got a different panic, that may or may not be useful.

Sat, Nov 17, 8:24 PM
sbruno updated the diff for D17891: audio/clementine-player: Migrate to Qt5.

Meaningless update to test that phab is still working

Sat, Nov 17, 8:19 PM
sbruno added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

Running this on the Tyan Power8 hosts now. I'll report back in a day or two after we get some poudriere runs under our belt.

Sat, Nov 17, 4:37 PM

Nov 11 2018

sbruno committed rP484702: Bump qemu-sbruno to capture 4ef7d07.
Bump qemu-sbruno to capture 4ef7d07
Nov 11 2018, 5:15 PM

Nov 9 2018

sbruno committed rP484536: Incorpororate fixes to build packages after freebsd svn r339655. (kevans).
Incorpororate fixes to build packages after freebsd svn r339655. (kevans)
Nov 9 2018, 6:14 PM

Nov 7 2018

sbruno requested changes to D11378: iWARP driver for Intel X722 Adapter - initial commit.

Is there any intention to rebase this to -current?

Nov 7 2018, 4:36 PM
sbruno updated the diff for D17891: audio/clementine-player: Migrate to Qt5.

Nuke extra pkgname suffix

Nov 7 2018, 2:23 PM
sbruno created D17891: audio/clementine-player: Migrate to Qt5.
Nov 7 2018, 2:21 PM

Nov 1 2018

sbruno updated subscribers of D17806: ppc64: handle exception 0x1500 (soft patch).
Nov 1 2018, 10:28 PM

Oct 31 2018

sbruno planned changes to D17772: Add hack to allow users to bypass pin widget initialization..
In D17772#379922, @mav wrote:

Have you tried to investigate whether keeping only VREF_ENABLE_MASK would be enough? It could have some more sense in general, since the driver has no way to know what VREF is needed in specific case. Same time other bits there are pretty logical.

Oct 31 2018, 2:36 PM
sbruno added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

Address man page review comments. Word wrap at 80 columns.

Oct 31 2018, 1:26 PM
sbruno updated the diff for D17772: Add hack to allow users to bypass pin widget initialization..

Address man page style review for new lines and correct case of BIOS use.

Oct 31 2018, 1:26 PM
sbruno updated the diff for D17772: Add hack to allow users to bypass pin widget initialization..

Add a man page update like a good dev.

Oct 31 2018, 12:04 AM

Oct 30 2018

sbruno added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

This is probably completely wrong on multiple levels, but this certainly does allow me to use my headphones again on my Skylake Intel HDA box.

Oct 30 2018, 11:51 PM
sbruno created D17772: Add hack to allow users to bypass pin widget initialization..
Oct 30 2018, 11:49 PM

Oct 29 2018

sbruno accepted D17749: net/intel-em-kmod: take maintainership.
Oct 29 2018, 3:05 PM · Intel Networking

Oct 25 2018

sbruno accepted D17646: net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH.
Oct 25 2018, 5:25 PM · Intel Networking

Oct 22 2018

sbruno added a comment to D17470: Fix net/qt4-network with OpenSSL 1.1.1.

This definitely fixes the build and runtime of clementine-player (qt4).

Oct 22 2018, 7:19 PM

Oct 19 2018

sbruno added a comment to D17618: locale data should be consistent-endian (big).

Sean, could you please give this a try on ref12-ppc64?

Oct 19 2018, 7:02 PM
sbruno accepted D17601: ppc64: limited 32-bit DMA address range.

This is running live on the host archon.nyi.freebsd.org that hosts ref12-ppc64.freebsd.org. We can do buildworlds and network things now. This is awesome.

Oct 19 2018, 3:04 PM
sbruno accepted D17603: PR231965: make localedef output locale data in target endian order.

issue fixed (wchar_t, that is (unsigned) int, is *4* bytes).

Now the amd64 cross-built locale data matches the one built natively on powerpc64.

Updating ref12-ppc64 for verification.

Oct 19 2018, 3:03 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

issue fixed (wchar_t, that is (unsigned) int, is *4* bytes).

Now the amd64 cross-built locale data matches the one built natively on powerpc64.

Oct 19 2018, 2:59 PM

Oct 18 2018

sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.

The build host is amd64 and builds multiple targets, aarch64, i386, powerpc64 and amd64. What information would you like from the builds?

I'd really like to compare results from native EB (e.g. powerpc64) build for /usr/share/locale with what amd64 cross-build produces.

Ok. I'll update ref12-ppc64 to this review (product of cross build) and then you can natively do a buildworld there to see what it looks like?

Thank you!

Oct 18 2018, 10:12 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.

The build host is amd64 and builds multiple targets, aarch64, i386, powerpc64 and amd64. What information would you like from the builds?

I'd really like to compare results from native EB (e.g. powerpc64) build for /usr/share/locale with what amd64 cross-build produces.

Oct 18 2018, 9:44 PM
sbruno added a comment to D17603: PR231965: make localedef output locale data in target endian order.

I'll apply this to the fbsd cluster build.

Oct 18 2018, 9:27 PM
sbruno added a comment to D17470: Fix net/qt4-network with OpenSSL 1.1.1.

I'll test this against clementine-player today and see if it can do SSL/TLS connections for streaming. That should give us a bit of a warm fuzzy.

Oct 18 2018, 3:53 PM
sbruno accepted D17470: Fix net/qt4-network with OpenSSL 1.1.1.

This allows audio/murmur to build again.

Oct 18 2018, 1:50 PM

Oct 15 2018

sbruno accepted D17544: iavf: Finish the rename/rebrand internally.

@erj do you want to ask RE permission to commit this?

Oct 15 2018, 4:32 PM

Oct 14 2018

sbruno committed rP482049: Connect net/intel-ix-kmod to the build. Missed in r481900..
Connect net/intel-ix-kmod to the build. Missed in r481900.
Oct 14 2018, 4:06 PM

Oct 12 2018

sbruno committed rP481917: Setting DOCS=off will set EXTRA_PATCHES, so we need to append to this.
Setting DOCS=off will set EXTRA_PATCHES, so we need to append to this
Oct 12 2018, 6:20 PM
sbruno committed rP481915: sysutils/ipmitool: unbreak with openssl 1.1.1 import.
sysutils/ipmitool: unbreak with openssl 1.1.1 import
Oct 12 2018, 5:51 PM
sbruno updated the diff for D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.

Apply openssl 1.1.1 update patch only if running on a FreeBSD version where
openssl 1.1.1 exists.

Oct 12 2018, 4:22 PM
sbruno committed rP481910: comms/conserver-com: Update for openssl 1.1.1 in 12-CURRENT..
comms/conserver-com: Update for openssl 1.1.1 in 12-CURRENT.
Oct 12 2018, 3:51 PM
sbruno closed D17524: comms/conserver-com: Update to 8.2.2 - support base openssl 1.1.1 - switch to upstream github.
Oct 12 2018, 3:51 PM
sbruno added a comment to D17524: comms/conserver-com: Update to 8.2.2 - support base openssl 1.1.1 - switch to upstream github.

The USE_* section should be below the LICENSE section

Oct 12 2018, 3:21 PM
sbruno added a comment to D17528: comms/conserver-com: Update licensing details and pet portlint.

There is no ${WRKSRC}/LICENSES , was this tested?

Oct 12 2018, 3:13 PM
sbruno accepted D17533: net/intel-ixl-kmod: Remove -Werror from CFLAGS.
Oct 12 2018, 2:37 PM · Intel Networking
sbruno requested changes to D17528: comms/conserver-com: Update licensing details and pet portlint.

FATAL: Makefile: license specified is BSD3CLAUSE OTHERBSDLIKELICENSES, but LICENSE_FILE specified is for BSD3CLAUSE.

Oct 12 2018, 2:15 PM
sbruno accepted D17528: comms/conserver-com: Update licensing details and pet portlint.
Oct 12 2018, 1:43 PM
sbruno added a comment to D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.

Tested on FreeBSD 12 natively and compiled in poudriere.

Oct 12 2018, 3:52 AM
sbruno added a comment to D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.

https://github.com/ipmitool/ipmitool/commit/1664902525a1c3771b4d8b3ccab7ea1ba6b2bdd1#diff-707b424f074d272f2934512475a3e99c

Oct 12 2018, 3:51 AM
sbruno created D17527: sysutils/ipmitool - unbreak for openssl 1.1.1.
Oct 12 2018, 3:50 AM

Oct 11 2018

sbruno accepted D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Oct 11 2018, 10:48 PM · Intel Networking
sbruno accepted D15927: Update ixl(4) and ixlv(4) man pages.
Oct 11 2018, 10:47 PM
sbruno added a comment to D17524: comms/conserver-com: Update to 8.2.2 - support base openssl 1.1.1 - switch to upstream github.

Test builds of 12/11/10 on i386/amd64 build and pkg fine.

Oct 11 2018, 9:59 PM
sbruno created D17524: comms/conserver-com: Update to 8.2.2 - support base openssl 1.1.1 - switch to upstream github.
Oct 11 2018, 9:59 PM
sbruno added a comment to D17473: fix PNP entries for if_ix and if_ixv.

@yuripv Do you want me to commit this or are you going to be able to send the request to release engineering?

Oct 11 2018, 5:58 PM
sbruno accepted D17473: fix PNP entries for if_ix and if_ixv.
Oct 11 2018, 5:50 PM
sbruno accepted D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.
Oct 11 2018, 5:40 PM · Intel Networking

Oct 5 2018

sbruno accepted D17442: Fix egregious magic number constants.
Oct 5 2018, 9:43 PM
sbruno added a comment to D17442: Fix egregious magic number constants.
In D17442#372066, @erj wrote:

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

Oct 5 2018, 9:25 PM
sbruno accepted D17440: net/intel-em-kmod: Update to 7.7.4, enable netmap on 11.
Oct 5 2018, 9:23 PM · Intel Networking
sbruno requested changes to D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.

Does this require a LICENSE or some sort?

Oct 5 2018, 9:22 PM · Intel Networking
sbruno accepted D17437: sysutils/intel-qcu: Update to 2.30.23.0.
Oct 5 2018, 8:16 PM · Intel Networking
sbruno accepted D17435: net/intel-ixl-kmod: Add had-linked man page.
Oct 5 2018, 4:06 PM

Oct 1 2018

sbruno accepted D17246: Hold a write lock across udp_notify().

Ok, whom would like to submit this to re@ to get it into the tree?

Oct 1 2018, 2:42 AM

Sep 22 2018

sbruno accepted D17283: Add myself to mentees with sbruno as mentor.
Sep 22 2018, 6:41 PM
sbruno accepted D17284: Change MAINTAINER in my ports to @FreeBSD.org email.
Sep 22 2018, 6:40 PM

Sep 21 2018

sbruno accepted D17269: Add myself to authors, developers, and news.
Sep 21 2018, 1:52 PM
sbruno committed rP480270: Add Sergey Kozlov to our ranks of committers with myself as a mentor..
Add Sergey Kozlov to our ranks of committers with myself as a mentor.
Sep 21 2018, 1:52 PM

Sep 19 2018

sbruno accepted D17250: Add support for EC2 i3.metal serial port.

stlgtm

Sep 19 2018, 10:01 PM

Sep 18 2018

sbruno added a reviewer for D17230: Update udp6_output() inp locking to avoid concurrency issues with route cache updates: rstone.
Sep 18 2018, 10:32 PM

Sep 14 2018

sbruno accepted D16808: fix vlan locking to permit sx acquisition in ioctl calls.
Sep 14 2018, 1:48 PM

Sep 6 2018

sbruno accepted D17031: Fix synchronization of lbgroup access..
Sep 6 2018, 3:27 PM

Aug 27 2018

sbruno accepted D16924: devcpu-data: Provide a file for loading at boot time.
Aug 27 2018, 9:37 PM
sbruno accepted D16924: devcpu-data: Provide a file for loading at boot time.

Can you bump PORTVERSION when you commit this?

Aug 27 2018, 8:49 PM

Aug 26 2018

sbruno committed rS338330: r338270 had the side effect of no longer installing libmd.so into /lib..
r338270 had the side effect of no longer installing libmd.so into /lib.
Aug 26 2018, 5:06 PM
sbruno closed D16910: libmd: Install libmd.so.6 into /lib again after SVN r338270.
Aug 26 2018, 5:06 PM

Aug 25 2018

sbruno accepted D16899: SO_REUSEPORT_LB critical bug fix: avoid IPv4 listen group in IPv6.
Aug 25 2018, 4:46 PM

Aug 12 2018

sbruno abandoned D11958: usr.bin/mandoc build warning/error fixes.
Aug 12 2018, 3:47 PM
sbruno commandeered D11958: usr.bin/mandoc build warning/error fixes.

A new release of mandoc was posted last week, is this still valid?

Aug 12 2018, 3:47 PM

Aug 8 2018

sbruno accepted D16633: [powerpc] Fix kernel panic when using "options BOOTP_NFSROOT".
Aug 8 2018, 8:24 PM
sbruno committed rP476664: sysutils/devcpu-data:.
sysutils/devcpu-data:
Aug 8 2018, 7:29 PM

Jul 31 2018

sbruno added a reviewer for D16534: e1000: Don't use 9k jumbo clusters: Intel Networking.
Jul 31 2018, 8:30 PM

Jul 25 2018

sbruno accepted D16428: iflib: Changes for ixlv(4) update.
Jul 25 2018, 6:16 PM · Intel Networking

Jul 24 2018

sbruno committed rP475259: games/cockatrice: Update to release 2.6.1.
games/cockatrice: Update to release 2.6.1
Jul 24 2018, 3:01 PM

Jul 14 2018

sbruno committed rS336298: There was quite a bit of feedback on r336282 that has led to the.
There was quite a bit of feedback on r336282 that has led to the
Jul 14 2018, 11:54 PM