Feed Advanced Search

Yesterday

sbruno added inline comments to D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Wed, Jan 17, 10:30 PM
sbruno retitled D13958: sysutils/devcpu-data: Restore one "legacy" microcode update. from sysutils/devcpu-data: Restore one "legacy" micrcodoe update. to sysutils/devcpu-data: Restore one "legacy" microcode update..
Wed, Jan 17, 8:16 PM
sbruno added a comment to D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..

It sure looks like there is a problem here.

Wed, Jan 17, 8:16 PM
sbruno updated the summary of D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Wed, Jan 17, 8:14 PM
sbruno created D13958: sysutils/devcpu-data: Restore one "legacy" microcode update..
Wed, Jan 17, 8:13 PM
sbruno committed rP459266: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated….
sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated…
Wed, Jan 17, 4:04 PM
sbruno closed D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Wed, Jan 17, 4:04 PM

Tue, Jan 16

sbruno committed rP459205: Revert Intel URL to the correct location for microcode-20171117.tgz.
Revert Intel URL to the correct location for microcode-20171117.tgz
Tue, Jan 16, 7:56 PM
sbruno accepted D13885: ixgbe(4): Update shared code, add support for X552, fix bugs.

Let me know if you need me to commit this.

Tue, Jan 16, 1:56 PM

Mon, Jan 15

sbruno added inline comments to D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Mon, Jan 15, 8:00 PM
sbruno added a comment to D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..

Surprisingly, this seems to work for us.

Mon, Jan 15, 5:43 PM
sbruno created D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..
Mon, Jan 15, 5:42 PM

Sun, Jan 14

sbruno committed rP458987: sysutils/devcpu-data: Only run "cpucontrol -e" once..
sysutils/devcpu-data: Only run "cpucontrol -e" once.
Sun, Jan 14, 6:28 PM

Sat, Jan 13

sbruno committed rP458943: sysutils/devcpu-data: Update AMD microcode, add cpu 17h microcode,.
sysutils/devcpu-data: Update AMD microcode, add cpu 17h microcode,
Sat, Jan 13, 9:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, Jan 13, 9:36 PM
sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
In D13832#290897, @cem wrote:

Your CPU, "family 0xf model 0xb stepping 0x2 extfamily 0 extmodel 0x6" should be 0x60fb2 -- which, yeah, isn't one of 0x600f20, 0x610f01, or 0x600f12. So this microcode file doesn't have an update for your CPU, as I understand it.

I am not sure whether you are correct in this assumption.
The name mangling that is done by ucode-tool is bad and confusing. Imho ucode-tool should be retired, as it is legacy stuff, and the vendor-supplied binary files be used instead for more consistency.
I have done a write-up about this topic on the FreeBSD forums here, where I analyze why the microcode_update thing seems to be broken due to a fundamentally wrong approach.

Sat, Jan 13, 9:28 PM

Thu, Jan 11

sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

This works for my FX-8150:

Thu, Jan 11, 9:43 PM
sbruno updated the diff for D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Update after Intel microcode revert

Thu, Jan 11, 9:41 PM
sbruno committed rP458792: Revert to previous Intel microcode archive (20171117)..
Revert to previous Intel microcode archive (20171117).
Thu, Jan 11, 8:45 PM
sbruno planned changes to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Blocking pending update for Intel microcode revert.

Thu, Jan 11, 7:34 PM
sbruno committed rP458760: sysutils/x86info Update to top of github tree.
sysutils/x86info Update to top of github tree
Thu, Jan 11, 5:57 PM
sbruno closed D13866: sysutils/x86info Update to top of tree and add patches from kib@.
Thu, Jan 11, 5:57 PM
sbruno updated the summary of D13866: sysutils/x86info Update to top of tree and add patches from kib@.
Thu, Jan 11, 5:40 PM
sbruno created D13866: sysutils/x86info Update to top of tree and add patches from kib@.
Thu, Jan 11, 5:39 PM
sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
In D13832#290218, @cem wrote:

Is there any way to check the microcode version currently in use?

$ x86info -a | grep Microcode

Unfortunately, it appears microcode loading is broken on Family 17h, so I haven't tested anything useful.

Should this work for Intel cpu's as well? I have a couple servers that use Intel chips, but I have no idea if the microcode is actually being updated. I suspect it is not, x86info -a doesn't provide any information about the microcode.

Thu, Jan 11, 5:15 PM
sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

I found that "chopping up" the AMD microcode files was incorrect (and probably broken for 3+ years). If you have access to AMD hosts, please try my review on your systems. I now get an update to my FX-8150 with my review.

Thu, Jan 11, 4:23 PM
sbruno updated the diff for D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Examining the amd cpucontrol code has led me to realize that chopping up
the microcode files for AMD cpus is exactly wrong. They are already in
the format that corresponds to our processing via "amd10h" so don't do that
anymore.

Thu, Jan 11, 12:49 AM

Wed, Jan 10

sbruno added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Add Family 17h firmware.

Wed, Jan 10, 8:15 PM
sbruno created D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
Wed, Jan 10, 8:13 PM
sbruno committed rP458664: sysutils/devcpu-data follow up commit to 20180108 Intel microcode update..
sysutils/devcpu-data follow up commit to 20180108 Intel microcode update.
Wed, Jan 10, 5:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Jan 10, 5:32 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Now that the microcode has already been updated, cleanup the review.

Wed, Jan 10, 5:27 PM
sbruno added inline comments to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Wed, Jan 10, 12:29 AM

Tue, Jan 9

sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

It is more than sufficient to check for a non-zero return code from cpucontrol
using -e.

Tue, Jan 9, 11:38 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Redirect cpucontrol error spew to /dev/null when testing -e

Tue, Jan 9, 10:56 PM
sbruno added a comment to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Any further objections? I still need to smoke test this a bit too.

Tue, Jan 9, 9:47 PM
sbruno updated subscribers of D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Tue, Jan 9, 9:33 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

When trying to rescan CPU flags, detect versions that don't support -e and error out

Tue, Jan 9, 9:31 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Clarify pkg-message to indicate one does not need to reboot to install the microcode
update. (bdrewery)

Tue, Jan 9, 9:18 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Make "cpucontrol -e" rescan of CPU flags conditional on updating ALL CPUS in the
host system. (gtetlow)

Tue, Jan 9, 9:15 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Add a cpucontrol -e after microcode update is complete to re-evaluate
CPU flags. (suggested by bdrewery and cem)

Tue, Jan 9, 9:07 PM
sbruno updated the diff for D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.

Add pkg-message file to indicate "how" this should be implemented after installing
the package.

Tue, Jan 9, 8:37 PM
sbruno updated the summary of D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Tue, Jan 9, 8:27 PM
sbruno updated the summary of D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Tue, Jan 9, 8:27 PM
sbruno created D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Tue, Jan 9, 8:26 PM

Sun, Jan 7

sbruno committed rP458363: sysutils/devcpu-data Unbreak build by using a cached distfile for amd microcode..
sysutils/devcpu-data Unbreak build by using a cached distfile for amd microcode.
Sun, Jan 7, 6:14 PM
sbruno closed D13792: sysutils/devcpu-data Unbreak build with cached distfile for amd microcode.
Sun, Jan 7, 6:14 PM
sbruno added a comment to D13792: sysutils/devcpu-data Unbreak build with cached distfile for amd microcode.

review from mat@

  • Drop PORTREVISION (this fixes the build, not needed)
  • Use recommended LOCAL/sbruno to indicate where to fetch the AMD microcode tar.
Sun, Jan 7, 5:04 PM
sbruno updated the diff for D13792: sysutils/devcpu-data Unbreak build with cached distfile for amd microcode.

review from mat@

  • Drop PORTREVISION (this fixes the build, not needed)
  • Use recommended LOCAL/sbruno to indicate where to fetch the AMD microcode tar.
Sun, Jan 7, 5:03 PM
sbruno created D13792: sysutils/devcpu-data Unbreak build with cached distfile for amd microcode.
Sun, Jan 7, 4:34 PM

Fri, Jan 5

sbruno committed rS327606: Handle misconfigured/nonexistent pcidev for comconsole instead of BTX panic..
Handle misconfigured/nonexistent pcidev for comconsole instead of BTX panic.
Fri, Jan 5, 11:51 PM
sbruno closed D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
Fri, Jan 5, 11:51 PM
sbruno committed rP458169: sysutils/devcpu-data with Intel microcode update 20171117..
sysutils/devcpu-data with Intel microcode update 20171117.
Fri, Jan 5, 8:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Jan 5, 8:38 PM
sbruno added a comment to D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
In D13776#288516, @imp wrote:

Looks good to me.

Though the more I think about it, how the heck did biospci_read_config find a config entry at all to extract the port info from the BAR?

Fri, Jan 5, 8:32 PM
sbruno added a comment to D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.

Updated for comments and tested to validate functional AMT console and functional serial console. All looks good from here.

Fri, Jan 5, 8:13 PM
sbruno updated the diff for D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.

Check against 0xffffffff instead of -1.

Fri, Jan 5, 8:12 PM
sbruno updated the test plan for D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
Fri, Jan 5, 7:17 PM
sbruno created D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
Fri, Jan 5, 7:14 PM

Thu, Jan 4

sbruno added a comment to D13771: sysutils/devcpu-data update to Intel Microcode update 20171117.

Please keep the plist sorted too.

Thu, Jan 4, 11:23 PM
sbruno updated the diff for D13771: sysutils/devcpu-data update to Intel Microcode update 20171117.

Sort new entries to pkg-plist

Thu, Jan 4, 11:23 PM
sbruno created D13771: sysutils/devcpu-data update to Intel Microcode update 20171117.
Thu, Jan 4, 10:14 PM
sbruno committed rP458040: net/scapy: Update to upstream release 2.3.3.
net/scapy: Update to upstream release 2.3.3
Thu, Jan 4, 5:50 PM
sbruno closed D13572: net/scapy: Update to upstream release 2.3.3.
Thu, Jan 4, 5:50 PM
sbruno updated the diff for D13572: net/scapy: Update to upstream release 2.3.3.

Clean up tab vs space PORTLINT warning.

Thu, Jan 4, 2:48 AM

Wed, Jan 3

sbruno added a comment to D11067: usr.bin/elf2aout build warning fix.

@emaste Is this "ok" to commit or is this masking something else going on?

Wed, Jan 3, 11:15 PM
sbruno added a reviewer for D11067: usr.bin/elf2aout build warning fix: emaste.
Wed, Jan 3, 11:14 PM
sbruno accepted D11958: usr.bin/mandoc build warning/error fixes.

Any objections?

Wed, Jan 3, 11:11 PM
sbruno added reviewers for D11958: usr.bin/mandoc build warning/error fixes: Doc Committers, jilles.
Wed, Jan 3, 11:11 PM

Thu, Dec 28

sbruno closed D13660: e1000: Add support for Ice Lake and Cannon Lake.
Thu, Dec 28, 9:27 PM
sbruno committed rS327312: e1000: Add support for Ice Lake and Cannon Lake.
e1000: Add support for Ice Lake and Cannon Lake
Thu, Dec 28, 9:27 PM
sbruno accepted D13660: e1000: Add support for Ice Lake and Cannon Lake.
Thu, Dec 28, 5:10 PM

Fri, Dec 22

sbruno committed rP456991: comms/amtterm Update to 1.6 release.
comms/amtterm Update to 1.6 release
Fri, Dec 22, 8:56 PM
sbruno closed D13590: comms/amtterm Update to release version 1.6.
Fri, Dec 22, 8:56 PM
sbruno added a comment to D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

@erj Do you want to abandon this review in light of your work on newer releases?

Fri, Dec 22, 8:05 PM · Intel Networking
sbruno created D13590: comms/amtterm Update to release version 1.6.
Fri, Dec 22, 7:54 PM

Thu, Dec 21

sbruno updated the diff for D13572: net/scapy: Update to upstream release 2.3.3.

Delete GH_TAGNAME and use DISVERSIONPREFIX + PORTREVISION to fetch.

Thu, Dec 21, 3:49 PM
sbruno updated the diff for D13572: net/scapy: Update to upstream release 2.3.3.

Missed needing to delete the second patch file which is no longer needed

Thu, Dec 21, 3:41 PM
sbruno updated the summary of D13572: net/scapy: Update to upstream release 2.3.3.
Thu, Dec 21, 3:38 PM
sbruno created D13572: net/scapy: Update to upstream release 2.3.3.
Thu, Dec 21, 3:38 PM
sbruno committed rP456912: net/intel-ixl-kmod: Update to 1.9.5.
net/intel-ixl-kmod: Update to 1.9.5
Thu, Dec 21, 3:35 PM
sbruno closed D13491: net/intel-ixl-kmod: Update to 1.9.5.
Thu, Dec 21, 3:35 PM
sbruno accepted D13491: net/intel-ixl-kmod: Update to 1.9.5.
Thu, Dec 21, 3:34 PM

Wed, Dec 20

sbruno accepted D13561: Don't call tcp_lro_rx() unless hardware verified TCP/UDP csum.

This was noted in the FreeBSD Cluster as well. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224346 Ensure this Bug is added to the commit.

Wed, Dec 20, 9:05 PM

Tue, Dec 19

sbruno accepted D11727: ixgbe(4): Update HEAD to use iflib.

Blocking on D12446 which should committed soon.

Tue, Dec 19, 10:28 PM
sbruno added a dependency for D11727: ixgbe(4): Update HEAD to use iflib: D12446: Support attaching tx queues to cpus.
Tue, Dec 19, 10:28 PM
sbruno added a dependent revision for D12446: Support attaching tx queues to cpus: D11727: ixgbe(4): Update HEAD to use iflib.
Tue, Dec 19, 10:28 PM

Dec 17 2017

sbruno committed rP456518: emulators/qemu-sbruno.
emulators/qemu-sbruno
Dec 17 2017, 12:14 AM

Dec 16 2017

sbruno added a reviewer for D13494: Fix arc after kmem/kernel_arena merge: allanjude.
Dec 16 2017, 11:37 PM

Dec 14 2017

sbruno requested changes to D11727: ixgbe(4): Update HEAD to use iflib.

Adding a temporary block until Monday to give us time to do live fire tests in production.

Dec 14 2017, 6:17 PM

Dec 7 2017

sbruno abandoned D13230: native-xtools: GCC and CLANG are exclusive, pick one..
Dec 7 2017, 4:17 PM

Dec 4 2017

sbruno accepted D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Dec 4 2017, 11:06 PM
sbruno accepted D13324: Add support to pad Ethernet frames to a minimum size.
Dec 4 2017, 11:05 PM
sbruno accepted D13368: Avoid calling CURVNET_[SET|RESTORE] up to twice per packet.

Spicy

Dec 4 2017, 11:05 PM
sbruno added reviewers for D11029: usr.sbin/ntp/libopts: build time warning fixes: gnn, roberto.
Dec 4 2017, 3:43 PM
sbruno accepted D13060: Github export changed size.

Do you need someone to commit this?

Dec 4 2017, 3:38 PM

Nov 27 2017

sbruno committed rS326281: Add vmm(4) man page.
Add vmm(4) man page
Nov 27 2017, 4:28 PM
sbruno closed D13062: Add vmm(4) man page.
Nov 27 2017, 4:28 PM

Nov 25 2017

sbruno updated the diff for D13062: Add vmm(4) man page.

Address review comments

Nov 25 2017, 12:28 AM
sbruno commandeered D13062: Add vmm(4) man page.
Nov 25 2017, 12:18 AM