Page MenuHomeFreeBSD

if_ixv: disable RSS configuration on 82599 and X540 VFs
Needs ReviewPublic

Authored by avg on Wed, Sep 18, 12:36 PM.

Details

Summary

It is reported that those VFs share their RSS configuration with PF and,
thus, they cannot be configured independently.

Also:

  • add missing opt_rss.h to if_ixv.c, otherwise RSS kernel option could not be seen
  • do not enable IXGBE_FEATURE_RSS on the older VFs
  • set flowid / hash type to M_HASHTYPE_NONE or M_HASHTYPE_OPAQUE_HASH (based on what the hardware reports) if IXGBE_FEATURE_RSS is not set

Sponsored by: Panzura

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 26554
Build 24942: arc lint + arc unit

Event Timeline

avg created this revision.Wed, Sep 18, 12:36 PM
avg added inline comments.Wed, Sep 18, 12:39 PM
sys/dev/ixgbe/ix_txrx.c
549

By the way, should this be M_HASHTYPE_OPAQUE or M_HASHTYPE_OPAQUE_HASH ?

avg added inline comments.Wed, Sep 18, 12:43 PM
sys/dev/ixgbe/ix_txrx.c
549

I think that sephe once did M_HASHTYPE_OPAQUE ==> M_HASHTYPE_OPAQUE_HASH (rS301538), but that got reverted during the convertion to iflib in rS327031.

avg edited the summary of this revision. (Show Details)Wed, Sep 18, 12:45 PM
avg added a comment.Mon, Sep 30, 1:21 PM

Any feedback at all?

avg added a comment.Thu, Oct 17, 6:23 AM

So, no hard feelings if I commit this?
I will try to handle any fallout if it happens.

jeb added a subscriber: jeb.Thu, Oct 17, 6:05 PM
jeb added inline comments.
sys/dev/ixgbe/if_ixv.c
1462

Why wouldn't the guard be feat_en & ICE_FEATURE_RSS?

jacob.e.keller_intel.com added inline comments.
sys/dev/ixgbe/if_ixv.c
1462

Doex ixgbe have feature flags for this? (seeing as this isn't the ice driver).

jeb added inline comments.Thu, Oct 17, 8:15 PM
sys/dev/ixgbe/if_ixv.c
1462

Sorry, not ICE, but rather IXGBE_FEATURE_RSS.