Page MenuHomeFreeBSD

pkelsey (Patrick Kelsey)
User

Projects

User Details

User Since
Jun 2 2014, 3:47 PM (254 w, 4 d)

Recent Activity

Mar 14 2019

pkelsey added a member for iflib: pkelsey.
Mar 14 2019, 6:01 PM

Feb 18 2019

pkelsey added a comment to D19140: Fix memory corruption bug in vdev_read in loader ZFS support.

Not sure that this works.
I try this on 11.2 and on Hyper-V gen1 system stick at ldelf loading stage on boot from zfs root.

Feb 18 2019, 10:13 PM

Feb 17 2019

pkelsey committed rS344234: It turns out r344226 narrowed the overrun bug but did not eliminate it entirely.
It turns out r344226 narrowed the overrun bug but did not eliminate it entirely
Feb 17 2019, 5:47 PM
pkelsey closed D19220: Still a memory corruption bug in vdev_read in loader ZFS support.
Feb 17 2019, 5:47 PM
pkelsey retitled D19220: Still a memory corruption bug in vdev_read in loader ZFS support from Still a memory corruption bug in vdev_readin loader ZFS support to Still a memory corruption bug in vdev_read in loader ZFS support.
Feb 17 2019, 4:27 PM
pkelsey created D19220: Still a memory corruption bug in vdev_read in loader ZFS support.
Feb 17 2019, 4:17 AM
pkelsey committed rS344227: Remove whole-disk vdev support from zfsboot.
Remove whole-disk vdev support from zfsboot
Feb 17 2019, 3:52 AM
pkelsey closed D19142: Remove whole-disk vdev support from zfsboot.
Feb 17 2019, 3:52 AM
pkelsey updated the summary of D19142: Remove whole-disk vdev support from zfsboot.
Feb 17 2019, 3:50 AM
pkelsey committed rS344226: Fix memory corruption bug introduced in r325310.
Fix memory corruption bug introduced in r325310
Feb 17 2019, 3:35 AM
pkelsey closed D19140: Fix memory corruption bug in vdev_read in loader ZFS support.
Feb 17 2019, 3:35 AM

Feb 12 2019

pkelsey updated the diff for D19140: Fix memory corruption bug in vdev_read in loader ZFS support.

Introduced local char * buffer pointer to avoid casts on output buffer pointer updates

Feb 12 2019, 12:42 AM
pkelsey committed rS344031: MFC r343919:.
MFC r343919:
Feb 12 2019, 12:00 AM

Feb 11 2019

pkelsey committed rS344030: MFC r343535:.
MFC r343535:
Feb 11 2019, 11:35 PM
pkelsey committed rS344029: MFC r343534:.
MFC r343534:
Feb 11 2019, 11:33 PM
pkelsey committed rS344028: MFC r343995:.
MFC r343995:
Feb 11 2019, 11:30 PM
pkelsey committed rS344027: MFC r343291:.
MFC r343291:
Feb 11 2019, 11:24 PM
pkelsey committed rS344026: MFC r343287:.
MFC r343287:
Feb 11 2019, 11:13 PM
pkelsey committed rS344025: Fix the fix added in r343287 for spurious HFSC bandwidth check errors.
Fix the fix added in r343287 for spurious HFSC bandwidth check errors
Feb 11 2019, 10:58 PM
pkelsey closed D19124: Fix HFSC configuration bug introduced in r343287.
Feb 11 2019, 10:58 PM
pkelsey added a comment to D19140: Fix memory corruption bug in vdev_read in loader ZFS support.

The reason why I am asking is, I am trying to understand if we actually *can* get into the situation with overrun, I got the impression the zfs on disk format should keep things sector aligned, but it really is easy to get confused there... And it does feel safer if we do have proper checks in place.

If the zfs on-disk format keeps things sector-aligned / sector-multiple, then why was vdev_read complicated with code to handle non-sector aligned / non-sector multiple reads to begin with?

Yea, you are right:)

Feb 11 2019, 5:08 PM
pkelsey added a comment to D19140: Fix memory corruption bug in vdev_read in loader ZFS support.

The reason why I am asking is, I am trying to understand if we actually *can* get into the situation with overrun, I got the impression the zfs on disk format should keep things sector aligned, but it really is easy to get confused there... And it does feel safer if we do have proper checks in place.

Feb 11 2019, 4:39 PM
pkelsey added inline comments to D19140: Fix memory corruption bug in vdev_read in loader ZFS support.
Feb 11 2019, 2:32 PM
pkelsey added a comment to D19140: Fix memory corruption bug in vdev_read in loader ZFS support.

I have two questions:

  1. how was it tested - was there some corruption case?
Feb 11 2019, 2:31 PM
pkelsey created D19142: Remove whole-disk vdev support from zfsboot.
Feb 11 2019, 6:19 AM
pkelsey committed rS343996: Place pf_altq_get_nth_active() under the ALTQ ifdef.
Place pf_altq_get_nth_active() under the ALTQ ifdef
Feb 11 2019, 5:39 AM
pkelsey updated the summary of D19131: Decrease the time the kernel takes to install a new PF config with a large number of queues.
Feb 11 2019, 5:18 AM
pkelsey committed rS343995: Reduce the time it takes the kernel to install a new PF config containing a….
Reduce the time it takes the kernel to install a new PF config containing a…
Feb 11 2019, 5:17 AM
pkelsey closed D19131: Decrease the time the kernel takes to install a new PF config with a large number of queues.
Feb 11 2019, 5:17 AM
pkelsey created D19140: Fix memory corruption bug in vdev_read in loader ZFS support.
Feb 11 2019, 5:06 AM

Feb 9 2019

pkelsey added a comment to D19124: Fix HFSC configuration bug introduced in r343287.

I have no objections to the patch, but I don't know enough about HFSC to meaningfully review this, I'm afraid.

Feb 9 2019, 5:41 PM
pkelsey updated the test plan for D19124: Fix HFSC configuration bug introduced in r343287.
Feb 9 2019, 5:22 PM

Feb 8 2019

pkelsey closed D19070: Fix em(4) tx interrupt routing.
Feb 8 2019, 8:35 PM
pkelsey committed rS343919: Fix em(4) interrupt routing.
Fix em(4) interrupt routing
Feb 8 2019, 8:35 PM
pkelsey updated the summary of D19131: Decrease the time the kernel takes to install a new PF config with a large number of queues.
Feb 8 2019, 8:15 PM
pkelsey created D19131: Decrease the time the kernel takes to install a new PF config with a large number of queues.
Feb 8 2019, 8:02 PM
pkelsey created D19124: Fix HFSC configuration bug introduced in r343287.
Feb 8 2019, 7:03 PM

Feb 3 2019

pkelsey created D19070: Fix em(4) tx interrupt routing.
Feb 3 2019, 12:22 AM

Feb 2 2019

pkelsey committed rS343688: Fix interrupt index configuratoin when using MSI interrupts..
Fix interrupt index configuratoin when using MSI interrupts.
Feb 2 2019, 9:15 PM

Jan 28 2019

pkelsey committed rS343535: Speed up non-status operations applied to a single interface.
Speed up non-status operations applied to a single interface
Jan 28 2019, 8:30 PM
pkelsey closed D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 28 2019, 8:30 PM
pkelsey committed rS343534: Don't re-evaluate ALTQ kernel configuration due to events on non-ALTQ interfaces.
Don't re-evaluate ALTQ kernel configuration due to events on non-ALTQ interfaces
Jan 28 2019, 8:26 PM
pkelsey closed D18918: Don't re-evaluate ALTQ kernel configuration due to events on non-ALTQ interfaces.
Jan 28 2019, 8:26 PM

Jan 24 2019

pkelsey added inline comments to D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 24 2019, 3:53 AM
pkelsey added inline comments to D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 24 2019, 3:46 AM
pkelsey added inline comments to D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 24 2019, 3:43 AM
pkelsey updated the diff for D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.

Added ifname parameter to getifflags(), which now uses that instead of the global name var.

Jan 24 2019, 3:41 AM
pkelsey added inline comments to D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 24 2019, 3:27 AM

Jan 22 2019

pkelsey committed rS343301: Add missing dependency to vmxnet3 Makefile and clean it up a bit otherwise..
Add missing dependency to vmxnet3 Makefile and clean it up a bit otherwise.
Jan 22 2019, 4:36 AM
pkelsey committed rS343296: Remove unused function gsc_destroy().
Remove unused function gsc_destroy()
Jan 22 2019, 2:54 AM
pkelsey created D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 22 2019, 2:10 AM
pkelsey created D18918: Don't re-evaluate ALTQ kernel configuration due to events on non-ALTQ interfaces.
Jan 22 2019, 1:55 AM
pkelsey committed rS343291: onvert vmx(4) to being an iflib driver..
onvert vmx(4) to being an iflib driver.
Jan 22 2019, 1:11 AM
pkelsey closed D18761: Convert vmx(4) to iflib.
Jan 22 2019, 1:11 AM
pkelsey committed rS343288: Fix various resource leaks that can occur in the error paths of.
Fix various resource leaks that can occur in the error paths of
Jan 22 2019, 12:56 AM
pkelsey closed D18760: Fix error-path resource leaks in iflib registration routines.
Jan 22 2019, 12:56 AM
pkelsey added a comment to D18760: Fix error-path resource leaks in iflib registration routines.

Looks good, only a tiny nitpick on the fail label.

Jan 22 2019, 12:53 AM
pkelsey committed rS343287: Reduce pf.conf parsing cost for configs that define N queues from O(N^2) to O(N).
Reduce pf.conf parsing cost for configs that define N queues from O(N^2) to O(N)
Jan 22 2019, 12:50 AM
pkelsey closed D18759: Improve pf.conf parsing speed for large numbers of queues.
Jan 22 2019, 12:50 AM

Jan 21 2019

pkelsey added a comment to D18759: Improve pf.conf parsing speed for large numbers of queues.

Also, I’d really, really like some basic tests for altq. It should be reasonably straightforward to do something based on the existing pf tests. At least, if altq can work on top of epairs.

That’s not a requirement to commit this patch, of course, but it’d be nice to be confident we don’t accidentally break altq.

Jan 21 2019, 11:57 PM
pkelsey added inline comments to D18759: Improve pf.conf parsing speed for large numbers of queues.
Jan 21 2019, 11:48 PM
pkelsey added inline comments to D18761: Convert vmx(4) to iflib.
Jan 21 2019, 11:38 PM

Jan 8 2019

pkelsey added a comment to D18761: Convert vmx(4) to iflib.

My only concern here is making IFLIB_MAX_RX_SEGS available to the driver...

IFLIB_MAX_RX_SEGS is more as an upper limit on what a sane driver would want rather than an upper limit of what a driver can use. If the driver actually wants (and can/will use) more, this may be the time to move ifr_frags to the end of struct iflib_rxq and use a dynamic size so the driver can have as many as it actually wants instead... that would allow other drivers to use a smaller rxq struct. ixgbe for example appears to be limited to 8 via an MPASS(), and it looks like no e1000 devices support larger than 16k frame sizes either. Dropping this to 8 for most drivers and having it at 32 or 64 for ones that support hardware 64k frames or LRO/GRO then setting this driver to use whatever is best for it could be worth the effort.

Jan 8 2019, 4:28 AM

Jan 6 2019

pkelsey created D18761: Convert vmx(4) to iflib.
Jan 6 2019, 5:24 AM
pkelsey created D18760: Fix error-path resource leaks in iflib registration routines.
Jan 6 2019, 5:02 AM
pkelsey created D18759: Improve pf.conf parsing speed for large numbers of queues.
Jan 6 2019, 12:23 AM

Nov 14 2018

pkelsey accepted D17758: Fix flags collision causing inability to enable CBQ in ALTQ.

To clarify 'the symptom is that a kernel with CBQ support and not CODEL fails to load a QoS policy with the obscure error "pfctl: DIOCADDALTQ: Cannot allocate memory."', to experience this failure it is also required that the queue configuration include the BORROW flag ('borrow' keyword in pf.conf), as that sets the bit that is misinterpreted by rmclass as requesting CODEL.

Nov 14 2018, 4:55 PM

Nov 13 2018

pkelsey accepted D17979: Fix leaks caused by ifc_nhwtxqs never being initialized.

Looks good to me.

Nov 13 2018, 7:36 PM

Aug 23 2018

pkelsey committed rS338260: Fix warning about crossing INT32_MAX boundary in computation of constant value..
Fix warning about crossing INT32_MAX boundary in computation of constant value.
Aug 23 2018, 5:41 PM
pkelsey committed rS338253: Extend tbrsize heuristic in pfctl(8) to provide a sensible value for.
Extend tbrsize heuristic in pfctl(8) to provide a sensible value for
Aug 23 2018, 4:10 PM
pkelsey closed D16852: Update pfctl(8) tbrsize heuristic for high bandwidth interfaces.
Aug 23 2018, 4:10 PM
pkelsey added a comment to D16852: Update pfctl(8) tbrsize heuristic for high bandwidth interfaces.

This seems straightforward, reasonable, and sufficient. Longer-term, I'd wonder about some sort of arithmetic approach here rather than this kind of hand-scaling?

Aug 23 2018, 3:33 AM

Aug 22 2018

pkelsey created D16852: Update pfctl(8) tbrsize heuristic for high bandwidth interfaces.
Aug 22 2018, 8:59 PM
pkelsey updated the test plan for D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 22 2018, 7:40 PM
pkelsey committed rS338209: Extended pf(4) ioctl interface and pfctl(8) to allow bandwidths of.
Extended pf(4) ioctl interface and pfctl(8) to allow bandwidths of
Aug 22 2018, 7:39 PM
pkelsey closed D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 22 2018, 7:39 PM

Aug 19 2018

pkelsey updated the diff for D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.

Incorporated all reviewer comments up to this point.

Aug 19 2018, 5:25 PM
pkelsey updated the test plan for D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 19 2018, 5:02 PM
pkelsey added inline comments to D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 19 2018, 3:57 PM

Aug 18 2018

pkelsey added inline comments to D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 18 2018, 4:23 PM
pkelsey added a comment to D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.

It'd be really awesome if you could also see about writing some basic tests (both as pfctl parser tests, to check we can now set higher bitrates for shaping, and as a basic test that shaping actually happens), but that's certainly not blocking.

Aug 18 2018, 4:20 PM
pkelsey added inline comments to D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 18 2018, 4:06 PM
pkelsey updated the test plan for D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 18 2018, 10:19 AM
pkelsey updated the summary of D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 18 2018, 10:18 AM
pkelsey created D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 18 2018, 9:59 AM

Aug 4 2018

pkelsey committed rS337281: Mark the send queue ready so ALTQ is available..
Mark the send queue ready so ALTQ is available.
Aug 4 2018, 1:45 AM

Jul 25 2018

pkelsey committed rS336727: ALTQ support for iflib..
ALTQ support for iflib.
Jul 25 2018, 10:46 PM
pkelsey closed D16433: Add ALTQ support to iflib.
Jul 25 2018, 10:46 PM

Jul 24 2018

pkelsey created D16433: Add ALTQ support to iflib.
Jul 24 2018, 8:04 PM

Mar 7 2018

pkelsey added a comment to D14048: Modify handling of TCP_RFC7413 (TFO) kernel option.

Going to commit this soon as the review has been open for nearly one month and has been idle for two weeks.

Mar 7 2018, 4:47 PM
pkelsey added inline comments to D14554: Support printing of the TCP fast open client side cache.
Mar 7 2018, 4:43 PM
pkelsey closed D14048: Modify handling of TCP_RFC7413 (TFO) kernel option.
Mar 7 2018, 4:42 PM
pkelsey closed D14047: TCP Fast Open (TFO) [RFC7413] Client-side Implementation (take two).
Mar 7 2018, 4:42 PM
pkelsey updated the diff for D14047: TCP Fast Open (TFO) [RFC7413] Client-side Implementation (take two).

Addressed reviewer comments.

Mar 7 2018, 4:42 PM
pkelsey added a comment to D14047: TCP Fast Open (TFO) [RFC7413] Client-side Implementation (take two).

Going to commit this soon as there has not been any further review comments in nearly three weeks.

Mar 7 2018, 4:42 PM

Mar 6 2018

pkelsey accepted D14554: Support printing of the TCP fast open client side cache.

Looks good. Thanks.

Mar 6 2018, 3:46 AM

Feb 26 2018

pkelsey committed rS330035: Ensure signed comparison to avoid false trip of assert during VNET teardown..
Ensure signed comparison to avoid false trip of assert during VNET teardown.
Feb 26 2018, 8:31 PM
pkelsey committed rS330002: Greatly reduce the number of #ifdefs supporting the TCP_RFC7413 kernel option..
Greatly reduce the number of #ifdefs supporting the TCP_RFC7413 kernel option.
Feb 26 2018, 3:04 AM
pkelsey committed rS330001: This is an implementation of the client side of TCP Fast Open (TFO).
This is an implementation of the client side of TCP Fast Open (TFO)
Feb 26 2018, 2:53 AM
pkelsey committed rS330000: Fix harmless locking bug in tfp_fastopen_check_cookie()..
Fix harmless locking bug in tfp_fastopen_check_cookie().
Feb 26 2018, 2:43 AM