Page MenuHomeFreeBSD

rozhuk.im-gmail.com (Rozhuk Ivan)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Feb 26 2015, 12:49 AM (247 w, 1 d)

Recent Activity

Sep 29 2019

rozhuk.im-gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

kernel trap 22 with interrupts disabled
panic: spin locks can only use msleep_spin
cpuid = 7 time = 1569790352
KDB: stack backtrace:
#0 0xffffffff805da3fd at kdb_backtrace+0x6d
#1 0xffffffff80594fed at vpanic+0x19d
#2 0xffffffff80594e43 at panic+0x43
#3 0xffffffff8057df32 at unlock_spin+0x12
#4 0xffffffff8053f577 at _cv_wait_sig+0x127
#5 0xffffffff81d1dace at iichid_read+0x8e
#6 0xffffffff804b690a at devfs_read_f+0xda
#7 0xffffffff805f4752 at kern_readv+0x92
#8 0xffffffff805f46b4 at sys_read+0x84
#9 0xffffffff808451d8 at amd64_syscall+0x218
#10 0xffffffff80821270 at fast_syscall_common+0x101

Sep 29 2019, 9:08 PM · Contributor Reviews (base)
rozhuk.im-gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Panic on kldload acpi_iichid in iichid_read()->cv_wait_sig().
FreeBSD 12.1 amd64 @ Asus 505z

Sep 29 2019, 5:04 AM · Contributor Reviews (base)

Sep 14 2019

rozhuk.im-gmail.com added inline comments to D21206: libc: add fdwalk.
Sep 14 2019, 7:23 PM

Mar 25 2019

rozhuk.im-gmail.com added a comment to D19690: mount/unmount events to devd.

This is alternate to kqueue EVFILT_FS, but there is no need to keep prev state from getmntinfo() and compare with new to find changes.
Also user can use shell scripts to perform additional actions.

Mar 25 2019, 3:34 PM · Contributor Reviews (base)

Mar 23 2019

rozhuk.im-gmail.com retitled D19690: mount/unmount events to devd from mount/unmount event to devd to mount/unmount events to devd.
Mar 23 2019, 4:11 PM · Contributor Reviews (base)
rozhuk.im-gmail.com created D19690: mount/unmount events to devd.
Mar 23 2019, 4:09 PM · Contributor Reviews (base)

Feb 19 2019

rozhuk.im-gmail.com added a comment to D19140: Fix memory corruption bug in vdev_read in loader ZFS support.

I merge it to stable.
Sorry for noise, problem was with random - not enough entropy on first boot to unblock it. It reproduced even on 11.2 from official site.

Feb 19 2019, 5:40 PM

Feb 18 2019

rozhuk.im-gmail.com added a comment to D19140: Fix memory corruption bug in vdev_read in loader ZFS support.

Not sure that this works.
I try this on 11.2 and on Hyper-V gen1 system stick at ldelf loading stage on boot from zfs root.

Feb 18 2019, 4:03 PM

Jan 5 2019

rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.

More proper temp calculatuion based on RangeUnajusted, according to "Preliminary BIOS and Kernel Developer’s Guide (BKDG) for AMD Family 16h Models 00h-0Fh (Kabini) Processors".

Jan 5 2019, 12:23 AM · x86

Dec 7 2018

rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.
Dec 7 2018, 9:29 PM · x86
rozhuk.im-gmail.com added inline comments to D9759: amdtemp driver update.
Dec 7 2018, 7:32 PM · x86
rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.
Dec 7 2018, 7:32 PM · x86

Sep 2 2018

rozhuk.im-gmail.com added a comment to D14721: emulators/wine-devel: add WOW64.

That's better. However, I still prefer lib32- approach. Mostly because it doesn't waste my time deploying chroot and compiling the same Wine components multiple times. (I also wouldn't mind 32-bit version of mesa-demos package, that would be very handy when I'm trying to diagnose 3d issues for other users on the FreeBSD forum or elsewhere. And that requires establishing some kind of packaging convention unless we want to stuff every potentially useful binary into wine-devel.)

Sep 2 2018, 5:09 PM
rozhuk.im-gmail.com added a comment to D14721: emulators/wine-devel: add WOW64.

@rozhuk.im-gmail.com You know the chroot approach is basically unmergable, right?

Sep 2 2018, 3:32 PM
rozhuk.im-gmail.com added a comment to D14721: emulators/wine-devel: add WOW64.

http://www.netlab.linkpc.net/download/tmp/wine-devel_wow.patch
I update patch:

  • now it for 3.15
  • use ccache to build
  • nullfs mount as ro for all things that do not required write
  • add copy of /etc/resolv.conf to chroot
  • add copy of /etc/make.conf to chroot
  • fix staging download if wow enabled
Sep 2 2018, 6:26 AM

Sep 1 2018

rozhuk.im-gmail.com added a comment to D14721: emulators/wine-devel: add WOW64.
  1. unmount does not work on errors - and I lost mine: /usr/ports, /var/db/ports, distfiles. DOH!
Sep 1 2018, 11:54 PM

Sep 6 2017

rozhuk.im-gmail.com added a comment to rS323184: Add smn(4) driver for AMD System Management Network.

Sorry for annoying, but may be better:

  1. rename it to amdsb
  2. add SMU
  3. add amdsmn_is_avail(), amdsmu_is_avail()
  4. may be some staff from amdsbwd
  5. may be whole amd_ecc_inject
Sep 6 2017, 2:25 AM

Sep 5 2017

rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..
In D12217#253766, @avg wrote:

@rozhuk.im-gmail.com
SMN can and will be used for far more things than just the temperature reading. A lot of registers has been moved behind SMN. Having SMN interface in a separate module is just a good software design.
Your arguments so far sound irrational.
Regarding your note on the Linux change -- yes, they added SMN to the existing driver, but that's because they already had a driver to provide structured access to various things in the AMD "northbridge" and that's because Linux tinkers with hardware insides far more than FreeBSD does.
This change is the step in the same direction, not away from it.
E.g. I wish I was smart enough to create AMD "southbridge" driver at the time when I was writing amdsbwd driver. Without that driver the dependencies between amdsbwd, intpm and the proposed apuled drivers are much poorer than they would be with it.

Sep 5 2017, 11:02 AM
rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..

Now, no one needs an amdsmn.
If some module in future will use SMN then it will be easy to share this code into module.

That's true, but what's so offensive about having another module? Why do we need to wait for abundant reasons to have logical code separation as opposed to copy paste code sharing?

Sep 5 2017, 9:46 AM
rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..
In D12217#253696, @cem wrote:

That is all what module do. Same for write.
8 lines.
One consumer - amdtemp.
No perspective to get more consumers.
Unknown perspective to be supported in hardware in future.

So what?

Sep 5 2017, 12:53 AM

Sep 4 2017

rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..

My point is: while only amdtemp uses amdsmn on few CPUs - no need to have amdsmn as module, let it be a part of amdtemp.

Why is that better? What is bad about the separate module?

Sep 4 2017, 11:35 PM
rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..
In D12217#253620, @avg wrote:

Why do you think that there is any direct relation between SMU and Miscellaneous registers in family 15h and SMN in family 17h?
SMN is a completely new thing in family 17h (or so it seems), the only similarity between SMU and SMN is "SM" :-)
Family 17h is a big step from families 10h - 16h and even between those families there were incompatible changes in PCI register definitions (I know that for sure about registers that describe DRAM configuration).
Given the lack of documentation we can resort -- again! -- to using Linux commits by AMD employees as a guidance.
For example, https://patchwork.kernel.org/patch/9432511/

Sep 4 2017, 10:32 PM
rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..
family = CPUID_TO_FAMILY(cpu_id);

What about systems with multiple and different CPUs?
That is why amdtemp reads:

cpuid = pci_read_config(dev, AMDTEMP_CPUID, 4);

That register does not appear to exist on Ryzen. It is not mentioned in the Processor Programming Reference (PPR) for AMD Family 17 Model 01h, Revision B1 Processors. When I previously tested your patch, I searched all of config space and didn't find any registers with contents that matched what what I expect to see there.
I don't believe that populating a multi-socket system with non-identical CPU chips is supported.

Sep 4 2017, 6:28 PM
rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..
In D12217#253572, @cem wrote:

For 15h model 60-6f
D0F0x60 Miscellaneous Index
D0F0x64 Miscellaneous Index Data
...
D0F0xB8 SMU Index Address
D0F0xBC SMU Index Data
Is amdsmn required as additional device?

I don't understand the question.

Sep 4 2017, 6:23 PM
rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.

add Ryzen specific SMU registers.

Sep 4 2017, 6:06 PM · x86
rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..

This is potentially possible in server segment.
I this this is reason why amdtemp read CPUID via PCI and try to not use global cpu_id and local do_cpuid().
Linux gays in k10temp.c: k10temp_is_visible() uses only info that read from target device.

Sep 4 2017, 2:11 PM
rozhuk.im-gmail.com added a comment to D12217: Add temperature sensor support for AMD Zen processors; two separate commits included this review..

For 15h model 60-6f
D0F0x60 Miscellaneous Index
D0F0x64 Miscellaneous Index Data
...
D0F0xB8 SMU Index Address
D0F0xBC SMU Index Data

Sep 4 2017, 9:02 AM
rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.

Add support Bristol Ridge, possible Ryzen - need check
Remove TSI reading methods

Sep 4 2017, 12:49 AM · x86

Jul 31 2017

rozhuk.im-gmail.com added a comment to D11780: Lower shared page for amd64 on Ryzen to work around bug with code near top of user space.

Is it have same effect:

Jul 31 2017, 1:22 AM

Jun 10 2017

rozhuk.im-gmail.com added a comment to D11140: OSS: allow unplug soundcars without apps close devices.

Thank you.

Jun 10 2017, 9:18 PM · Contributor Reviews (base), multimedia
rozhuk.im-gmail.com added a comment to D11140: OSS: allow unplug soundcars without apps close devices.

No.
How I can check mem use after free and how turn on mem debug?

Jun 10 2017, 9:02 PM · Contributor Reviews (base), multimedia
rozhuk.im-gmail.com created D11140: OSS: allow unplug soundcars without apps close devices.
Jun 10 2017, 8:50 PM · Contributor Reviews (base), multimedia

Apr 4 2017

rozhuk.im-gmail.com added a comment to D9759: amdtemp driver update.

I m waiting for documentation from AMD to Ryzen CPU, looks like 17h have new interfaces.

Apr 4 2017, 10:44 AM · x86

Mar 8 2017

rozhuk.im-gmail.com added a comment to D9759: amdtemp driver update.
In D9759#204651, @cy wrote:

Will there be man page updates?

Mar 8 2017, 6:25 AM · x86
rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.

Since revision 310051 sysctl_add_oid have +1 param, add macro to handle it.

Mar 8 2017, 5:34 AM · x86

Mar 5 2017

rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.
Mar 5 2017, 10:20 PM · x86

Mar 4 2017

rozhuk.im-gmail.com added a comment to D9759: amdtemp driver update.

I have some AMD: E350, 5350, APU 6800, Phenom II X4 955 - test OK.

Mar 4 2017, 6:09 PM · x86
rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.
Mar 4 2017, 6:05 PM · x86
rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.

Style update.
CTASSERT() removed.

Mar 4 2017, 1:57 AM · x86

Feb 25 2017

rozhuk.im-gmail.com added inline comments to D9759: amdtemp driver update.
Feb 25 2017, 6:39 PM · x86
rozhuk.im-gmail.com added a comment to D9759: amdtemp driver update.

I will fix style a bi later.

Feb 25 2017, 4:12 AM · x86

Feb 24 2017

rozhuk.im-gmail.com updated the diff for D9759: amdtemp driver update.

Style corrections.

Feb 24 2017, 11:43 PM · x86
rozhuk.im-gmail.com added a reviewer for D9759: amdtemp driver update: rpaulo.
Feb 24 2017, 12:05 PM · x86

Feb 23 2017

rozhuk.im-gmail.com added a project to D9759: amdtemp driver update: x86.
Feb 23 2017, 9:35 PM · x86
rozhuk.im-gmail.com added a reviewer for D9759: amdtemp driver update: Contributor Reviews (base).
Feb 23 2017, 9:33 PM · x86

Feb 22 2017

rozhuk.im-gmail.com retitled D9759: amdtemp driver update from to amdtemp driver update.
Feb 22 2017, 11:59 PM · x86