Capsicumize addr2line(1).
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 7:27 PM.

Details

Reviewers

oshogbo
emaste

Group Reviewers

capsicum

Commits

rS350515: Capsicumize addr2line(1).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 29 2019, 7:27 PM

Herald added a subscriber: jonathan. · View Herald TranscriptJul 29 2019, 7:27 PM

Harbormaster completed remote builds in B25568: Diff 60242.Jul 29 2019, 7:27 PM

markj added reviewers: capsicum, oshogbo, emaste.Jul 29 2019, 7:29 PM

oshogbo added inline comments.Jul 29 2019, 7:34 PM

contrib/elftoolchain/addr2line/addr2line.c
719 ↗	(On Diff #60242)	caph_enter. You not using casper here.

oshogbo added inline comments.Jul 29 2019, 7:35 PM

contrib/elftoolchain/addr2line/addr2line.c
713 ↗	(On Diff #60242)	This can be a one linear: if (caph_rights_limit(fd, cap_rights_init(&rights, CAP_FSTAT, CAP_MMAP_R)) < 0)

Include Makefile updates.
Address feedback.

Harbormaster completed remote builds in B25573: Diff 60247.Jul 29 2019, 7:41 PM

emaste added a subscriber: jkoshy_users.sourceforge.net.Jul 29 2019, 7:49 PM

oshogbo added inline comments.Jul 29 2019, 8:55 PM

usr.bin/addr2line/Makefile
15 ↗	(On Diff #60247)	Not using casper.

markj added inline comments.Jul 29 2019, 9:08 PM

usr.bin/addr2line/Makefile
15 ↗	(On Diff #60247)	Ah, I thought this define was needed to use all caph_*

Don't need to define WITH_CASPER.

Harbormaster completed remote builds in B25577: Diff 60254.Jul 29 2019, 9:10 PM

oshogbo added inline comments.Jul 31 2019, 6:00 PM

contrib/elftoolchain/addr2line/addr2line.c
712 ↗	(On Diff #60254)	IF THE ELF will be built without ELFTC_HAVE_MMAP it will require read permissions as well. Should we support that?

markj added inline comments.Jul 31 2019, 6:23 PM

contrib/elftoolchain/addr2line/addr2line.c
712 ↗	(On Diff #60254)	I think this is probably overkill. _elftc.h defines ELFTC_HAVE_MMAP based on the target OS, it's not a compile-time configuration parameter. The capsicum additions are FreeBSD specific, so I think it's safe to simply assume that mmap is available.

Ok.

This revision is now accepted and ready to land.Jul 31 2019, 6:26 PM

markj mentioned this in D21105: Capsicumize size(1)..Jul 31 2019, 6:28 PM

Closed by commit rS350515: Capsicumize addr2line(1). (authored by markj). · Explain WhyAug 1 2019, 6:56 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS350515: Capsicumize addr2line(1)..

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2019, 6:56 PM

In file included from /usr/src/contrib/elftoolchain/addr2line/addr2line.c:30:
/usr/include/capsicum_helpers.h:42:10: fatal error: 'libcasper.h' file not found
#include <libcasper.h>

^~~~~~~~~~~~~

1 error generated.

addr2line.o ---
[addr2line.o] Error code 1

make[3]: stopped in /usr/src/usr.bin/addr2line
1 error

make[3]: stopped in /usr/src/usr.bin/addr2line

cross-tools ---
[cross-tools] Error code 2

make[2]: stopped in /usr/src
1 error

make[2]: stopped in /usr/src

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

addr2line/

addr2line.c

13 lines

Diff 60363

View Options

head/contrib/elftoolchain/addr2line/addr2line.c

Capsicumize addr2line(1).ClosedPublicActions