Page MenuHomeFreeBSD

Capsicumize size(1).
ClosedPublic

Authored by markj on Jul 29 2019, 7:34 PM.

Details

Reviewers
oshogbo
emaste
Group Reviewers
capsicum
Commits
rS350517: Capsicumize size(1).

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Jul 29 2019, 7:34 PM
oshogbo added inline comments.Jul 31 2019, 6:07 PM
contrib/elftoolchain/size/size.c
211 ↗(On Diff #60248)

I guess here is the same problem with mmap.

238 ↗(On Diff #60248)

If we are freeing defaultfn should we also close fileargs ?

markj marked an inline comment as done.Jul 31 2019, 6:28 PM
markj added inline comments.
contrib/elftoolchain/size/size.c
211 ↗(On Diff #60248)

See my comment in D21104.

markj updated this revision to Diff 60327.Jul 31 2019, 6:28 PM

Free fileargs.

This revision is now accepted and ready to land.Jul 31 2019, 6:29 PM
This revision was automatically updated to reflect the committed changes.