Capsicumize size(1).
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 7:34 PM.

Details

Reviewers

oshogbo
emaste

Group Reviewers

capsicum

Commits

rS350517: Capsicumize size(1).

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25574
Build 24179: arc lint + arc unit

Event Timeline

markj created this revision.Jul 29 2019, 7:34 PM

Herald added a subscriber: jonathan. · View Herald TranscriptJul 29 2019, 7:34 PM

Harbormaster completed remote builds in B25570: Diff 60244.Jul 29 2019, 7:34 PM

Fixup.

Harbormaster completed remote builds in B25574: Diff 60248.Jul 29 2019, 7:43 PM

markj added reviewers: capsicum, oshogbo, emaste.Jul 29 2019, 7:45 PM

oshogbo added inline comments.Jul 31 2019, 6:07 PM

contrib/elftoolchain/size/size.c
211	I guess here is the same problem with mmap.
238	If we are freeing defaultfn should we also close fileargs ?

markj marked an inline comment as done.Jul 31 2019, 6:28 PM

markj added inline comments.

contrib/elftoolchain/size/size.c
211	See my comment in D21104.

Free fileargs.

Harbormaster completed remote builds in B25618: Diff 60327.Jul 31 2019, 6:29 PM

Ok.

This revision is now accepted and ready to land.Jul 31 2019, 6:29 PM

Closed by commit rS350517: Capsicumize size(1). (authored by markj). · Explain WhyAug 1 2019, 6:57 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS350517: Capsicumize size(1)..

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2019, 6:57 PM

Revision Contents
Changeset List

Path

Size

contrib/

elftoolchain/

size/

size.c

62 lines

usr.bin/

size/

Makefile

6 lines

Diff 60248

View Options

contrib/elftoolchain/size/size.c