Page MenuHomeFreeBSD
Differential D21104

Capsicumize addr2line(1).
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 6:33 AM
Unknown Object (File)
Jan 5 2025, 11:33 AM
Unknown Object (File)
Dec 25 2024, 10:14 AM
Unknown Object (File)
Dec 22 2024, 5:52 AM
Unknown Object (File)
Nov 8 2024, 10:12 AM
Unknown Object (File)
Oct 29 2024, 6:12 PM
Unknown Object (File)
Sep 24 2024, 4:49 PM
Unknown Object (File)
Sep 19 2024, 9:11 PM
View All 79 Files
Subscribers
imp
jkoshy_users.sourceforge.net
jonathan
rozhuk.im-gmail.com

Details

Reviewers
oshogbo
emaste
Group Reviewers
capsicum
Commits
rS350515: Capsicumize addr2line(1).

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25577
Build 24181: arc lint + arc unit

Event Timeline

markj created this revision.Jul 29 2019, 7:27 PM
Herald added a subscriber: jonathan. · View Herald TranscriptJul 29 2019, 7:27 PM
Harbormaster completed remote builds in B25568: Diff 60242.Jul 29 2019, 7:27 PM
markj added reviewers: capsicum, oshogbo, emaste.Jul 29 2019, 7:29 PM
oshogbo added inline comments.Jul 29 2019, 7:34 PM
contrib/elftoolchain/addr2line/addr2line.c
719

caph_enter.
You not using casper here.

oshogbo added inline comments.Jul 29 2019, 7:35 PM
contrib/elftoolchain/addr2line/addr2line.c
713

This can be a one linear:
if (caph_rights_limit(fd, cap_rights_init(&rights, CAP_FSTAT, CAP_MMAP_R)) < 0)

markj updated this revision to Diff 60247.Jul 29 2019, 7:41 PM
markj marked 2 inline comments as done.
  • Include Makefile updates.
  • Address feedback.
Harbormaster completed remote builds in B25573: Diff 60247.Jul 29 2019, 7:41 PM
emaste added a subscriber: jkoshy_users.sourceforge.net.Jul 29 2019, 7:49 PM
oshogbo added inline comments.Jul 29 2019, 8:55 PM
usr.bin/addr2line/Makefile
15 ↗(On Diff #60247)

Not using casper.

markj added inline comments.Jul 29 2019, 9:08 PM
usr.bin/addr2line/Makefile
15 ↗(On Diff #60247)

Ah, I thought this define was needed to use all caph_*

markj updated this revision to Diff 60254.Jul 29 2019, 9:10 PM
markj marked an inline comment as done.

Don't need to define WITH_CASPER.

Harbormaster completed remote builds in B25577: Diff 60254.Jul 29 2019, 9:10 PM
oshogbo added inline comments.Jul 31 2019, 6:00 PM
contrib/elftoolchain/addr2line/addr2line.c
712

IF THE ELF will be built without ELFTC_HAVE_MMAP it will require read permissions as well. Should we support that?

markj added inline comments.Jul 31 2019, 6:23 PM
contrib/elftoolchain/addr2line/addr2line.c
712

I think this is probably overkill. _elftc.h defines ELFTC_HAVE_MMAP based on the target OS, it's not a compile-time configuration parameter. The capsicum additions are FreeBSD specific, so I think it's safe to simply assume that mmap is available.

oshogbo accepted this revision.Jul 31 2019, 6:26 PM

Ok.

This revision is now accepted and ready to land.Jul 31 2019, 6:26 PM
markj mentioned this in D21105: Capsicumize size(1)..Jul 31 2019, 6:28 PM
Closed by commit rS350515: Capsicumize addr2line(1). (authored by markj). · Explain WhyAug 1 2019, 6:56 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS350515: Capsicumize addr2line(1)..
Herald added a subscriber: imp. · View Herald TranscriptAug 1 2019, 6:56 PM
rozhuk.im-gmail.com added a subscriber: rozhuk.im-gmail.com.Feb 21 2020, 1:53 AM

In file included from /usr/src/contrib/elftoolchain/addr2line/addr2line.c:30:
/usr/include/capsicum_helpers.h:42:10: fatal error: 'libcasper.h' file not found
#include <libcasper.h>

^~~~~~~~~~~~~

1 error generated.

  • addr2line.o ---
  • [addr2line.o] Error code 1

make[3]: stopped in /usr/src/usr.bin/addr2line
1 error

make[3]: stopped in /usr/src/usr.bin/addr2line

  • cross-tools ---
  • [cross-tools] Error code 2

make[2]: stopped in /usr/src
1 error

make[2]: stopped in /usr/src

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
addr2line/
13 lines

Diff 60254

View Options

contrib/elftoolchain/addr2line/addr2line.c

Loading...