Page MenuHomeFreeBSD

tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (312 w, 9 h)

Recent Activity

Wed, Dec 1

tsoome accepted D33215: fb: Remove unused FBIOSATTR/FBIOGATTR ioctls.
Wed, Dec 1, 4:02 PM
tsoome accepted D33216: fb: Remove unused FBIOSVIDEO/FBIOGVIDEO ioctls.
Wed, Dec 1, 4:02 PM
tsoome accepted D33217: fb: Remove unused cursors ioctls.
Wed, Dec 1, 4:01 PM
tsoome accepted D33218: fb: Remove unused FBIOGXINFO ioctl.
Wed, Dec 1, 4:00 PM
tsoome accepted D33219: fb: Remove unused FBIOMONINFO ioctl.
Wed, Dec 1, 3:59 PM
tsoome accepted D33220: fb: Remove unused FBIOPUTCMAPI/FBIOGETCMAPI ioctls.
Wed, Dec 1, 3:59 PM
tsoome accepted D33221: fb: Add new FBTYPE_EFIFB.
Wed, Dec 1, 2:44 PM
tsoome added a comment to D33221: fb: Add new FBTYPE_EFIFB.

I'd guess the same issue is with VBE.

Wed, Dec 1, 2:29 PM

Sat, Nov 27

tsoome accepted D33141: Remove options VESA from x86 GENERIC.
Sat, Nov 27, 9:25 PM

Mon, Nov 15

tsoome accepted D32991: loader: lsefi: Print more information.
Mon, Nov 15, 4:15 PM

Oct 24 2021

tsoome added inline comments to D32620: vt(4): Connect to teken's TP_SETBELLPD.
Oct 24 2021, 6:14 AM
tsoome accepted D32619: sysbeep: Adjust interface to take a duration as a sbt.

Thanks for doing this:)

Oct 24 2021, 6:11 AM

Oct 19 2021

tsoome committed R10:98e805b4a18d: loader: net_open() should not replace f->f_devdata (authored by tsoome).
loader: net_open() should not replace f->f_devdata
Oct 19 2021, 4:49 PM
tsoome closed D32227: loader: net_open() should not replace f->f_devdata.
Oct 19 2021, 4:48 PM

Oct 18 2021

tsoome accepted D32543: vt: Disable bell by default.
Oct 18 2021, 8:30 AM

Oct 4 2021

tsoome committed R10:c39bfe47139b: vt: call driver's postswitch when panicking on ttyv0 (authored by greg_unrelenting.technology).
vt: call driver's postswitch when panicking on ttyv0
Oct 4 2021, 3:37 AM

Oct 3 2021

tsoome added a comment to D32249: loader bcache: Refactor adjustment of ra.

It does feel wrong to have two if (complete) blocks in a row, perhaps it isworth to factor ra update out to separate function at some time...

I considered that, but since this is the only place we adjust bc->ra it seemed like an unnecessary complication to add a new function; at least now the changes are collected together in one place.

The entire function could probably do with being refactored and/or restyled, but that seemed like something which could wait.

Oct 3 2021, 7:04 PM

Oct 1 2021

tsoome accepted D32250: loader bcache: Track unconsumed readahead.
Oct 1 2021, 7:42 AM
tsoome accepted D32251: loader bcache: Allow readahead up to a maximum I/O size of 256 kB.
Oct 1 2021, 7:36 AM
tsoome accepted D32249: loader bcache: Refactor adjustment of ra.

It does feel wrong to have two if (complete) blocks in a row, perhaps it isworth to factor ra update out to separate function at some time...

Oct 1 2021, 7:21 AM
tsoome committed R10:b91af716ed87: loader: dev_net.c should use __func__ with printf (authored by tsoome).
loader: dev_net.c should use __func__ with printf
Oct 1 2021, 6:57 AM

Sep 30 2021

tsoome accepted D32239: loader: Don't free bcache for devices of type DEVT_DISK.

The obvious flaw is about possible unfreed memory, but that shouldn't be big problem anyhow.

Sep 30 2021, 9:02 PM
tsoome accepted D32172: loader: set boot_safe=YES when safe mode is selected.
Sep 30 2021, 4:02 PM
tsoome added a comment to D32172: loader: set boot_safe=YES when safe mode is selected.

Advise that only the presence of a value matters

Sep 30 2021, 3:21 PM

Sep 29 2021

tsoome added a comment to D32227: loader: net_open() should not replace f->f_devdata.
In D32227#727121, @bz wrote:

Is it limited to aarch64 or general EFI netbooting?

Sep 29 2021, 4:25 PM
tsoome requested review of D32227: loader: net_open() should not replace f->f_devdata.
Sep 29 2021, 4:17 PM
tsoome accepted D32225: loader.efi: remove extra extern ST.
Sep 29 2021, 4:10 PM

Sep 24 2021

tsoome committed R10:1a25c51e38a7: loader: dev_net.c should use __func__ with printf (authored by tsoome).
loader: dev_net.c should use __func__ with printf
Sep 24 2021, 6:51 PM

Sep 21 2021

tsoome accepted D32027: powerpc64: fix loader regression.
Sep 21 2021, 4:34 PM

Sep 20 2021

tsoome committed R10:c937a405bdce: vt: call driver's postswitch when panicking on ttyv0 (authored by greg_unrelenting.technology).
vt: call driver's postswitch when panicking on ttyv0
Sep 20 2021, 6:08 PM
tsoome closed D29961: vt: call driver's postswitch when panicking on ttyv0.
Sep 20 2021, 6:07 PM
tsoome requested changes to D32027: powerpc64: fix loader regression.

I think, it is still not set early enough; you want to have it set up before we run devsw probes.

Sep 20 2021, 6:01 PM

Sep 19 2021

tsoome added a comment to D4713: loader bcache redesign experiment.

Sorry to re-review something from five years ago, but I had a question about this code...

Sep 19 2021, 7:02 PM
tsoome added a comment to D29961: vt: call driver's postswitch when panicking on ttyv0.

ping. someone please commit?

Could you mail me git format-patch?

Done (sent to the freebsd.org address). Also updated it here, though "Download Raw Diff" still extracts a small diff anyway :/ Seems like only arc can apply patches with the message and everything from phab.

Sep 19 2021, 9:12 AM

Sep 15 2021

tsoome added a comment to D29961: vt: call driver's postswitch when panicking on ttyv0.

ping. someone please commit?

Sep 15 2021, 4:21 PM

Sep 9 2021

tsoome committed R10:1f91b3b631db: loader.efi: fix console output after BS off (authored by tsoome).
loader.efi: fix console output after BS off
Sep 9 2021, 9:53 AM

Sep 8 2021

tsoome committed R10:b4cb3fe0e39a: loader: implement mount/unmount rootfs (authored by tsoome).
loader: implement mount/unmount rootfs
Sep 8 2021, 12:50 PM
tsoome closed D30848: loader: implement mount/unmount rootfs.
Sep 8 2021, 12:50 PM
tsoome updated the diff for D30848: loader: implement mount/unmount rootfs.

added support for more file systems.

Sep 8 2021, 12:49 PM

Sep 3 2021

tsoome committed R10:343da8f5e98f: libsecureboot: define SOPEN_MAX (authored by tsoome).
libsecureboot: define SOPEN_MAX
Sep 3 2021, 8:47 PM
tsoome accepted D31814: efi: switch boot_services_gone to boot_services_active.

Thanks!

Sep 3 2021, 8:41 AM

Sep 2 2021

tsoome committed R10:4c7a3a70e047: loader.efi: fix console output after BS off (authored by tsoome).
loader.efi: fix console output after BS off
Sep 2 2021, 9:51 PM

Aug 28 2021

tsoome committed R10:0e98ea64237d: loader: loader_lua can run command_more twice (authored by tsoome).
loader: loader_lua can run command_more twice
Aug 28 2021, 10:17 AM
tsoome committed R10:d54fdcd59e23: loader: FB console does leave garbage on screen while scrolling (authored by tsoome).
loader: FB console does leave garbage on screen while scrolling
Aug 28 2021, 5:45 AM

Aug 26 2021

tsoome committed R10:ed760a3a6f6f: libsa: cstyle cleanup of dosfs.c (authored by tsoome).
libsa: cstyle cleanup of dosfs.c
Aug 26 2021, 8:48 AM
tsoome committed R10:cb08b3020f7a: loader: open file list should be dynamic (authored by tsoome).
loader: open file list should be dynamic
Aug 26 2021, 8:44 AM

Aug 25 2021

tsoome accepted D31512: pxeboot: improve and simplify rx handling.
Aug 25 2021, 8:52 PM
tsoome accepted D31512: pxeboot: improve and simplify rx handling.

Other than those few nits, it seems to be good (I hope the hw tests will also confirm;)

Aug 25 2021, 8:37 PM
tsoome added a comment to D31512: pxeboot: improve and simplify rx handling.

Ok, after some thinking, I did realize, we need to restructure this code some more. The problem is, pxe_netif_receive() should return complete Frame unless there is nothing coming, but UNDI ISR can end up in different states, and in some cases, we would want to receive again. Or to put other way - the current implementation is using pxe_netif_receive() as interrupt routine for UNDI, but UNDI interrupt and pxe_netif_receive have different semantics.

Aug 25 2021, 10:15 AM

Aug 23 2021

tsoome added a comment to D30848: loader: implement mount/unmount rootfs.

Can this be committed now, with other mount/unmount capabilities added later?

Aug 23 2021, 8:32 PM

Aug 21 2021

tsoome committed R10:7b0d05d56dfa: loader: loader_lua can run command_more twice (authored by tsoome).
loader: loader_lua can run command_more twice
Aug 21 2021, 6:30 PM
tsoome committed R10:e5a50b03297f: loader: FB console does leave garbage on screen while scrolling (authored by tsoome).
loader: FB console does leave garbage on screen while scrolling
Aug 21 2021, 4:18 PM

Aug 20 2021

tsoome accepted D31623: Make boot block read-ahead caching algorithm smarter.

I think, https://reviews.freebsd.org/D30848 should improve your use case even more.

Aug 20 2021, 8:08 PM

Aug 19 2021

tsoome updated the diff for D30848: loader: implement mount/unmount rootfs.

implement mount/unmount for dosfs.

Aug 19 2021, 4:43 PM
tsoome committed R10:3ec0714d6db0: libsa: cstyle cleanup of dosfs.c (authored by tsoome).
libsa: cstyle cleanup of dosfs.c
Aug 19 2021, 2:37 PM
tsoome committed R10:416194c9af84: loader: cstyle cleanup of userboot/devicename.c (authored by tsoome).
loader: cstyle cleanup of userboot/devicename.c
Aug 19 2021, 1:07 PM

Aug 16 2021

tsoome updated the diff for D30848: loader: implement mount/unmount rootfs.

update cd9660 to have mount/unmount.

Aug 16 2021, 5:00 PM

Aug 15 2021

tsoome updated the diff for D30848: loader: implement mount/unmount rootfs.

add zfs_mount and zfs_unmount.

Aug 15 2021, 6:26 PM

Aug 14 2021

tsoome updated the diff for D30848: loader: implement mount/unmount rootfs.

more comments.

Aug 14 2021, 9:22 PM
tsoome added inline comments to D30848: loader: implement mount/unmount rootfs.
Aug 14 2021, 12:40 PM
tsoome updated the diff for D30848: loader: implement mount/unmount rootfs.

Addressing first round of comments and suggestions.

Aug 14 2021, 12:39 PM
tsoome retitled D30848: loader: implement mount/unmount rootfs from loader: avoid bcache flushes on currdev to loader: implement mount/unmount rootfs.
Aug 14 2021, 12:38 PM

Aug 13 2021

tsoome updated the diff for D30848: loader: implement mount/unmount rootfs.

This is complete rework. Instead of hacking into not releasing
bcache, we "mount" filesystem (if supported) while we set "currdev"
environment variable. By mounting, we create open disk device and we
do keep it open till this file system will get unmounted, and the
bcache segment for this devei is preserved.

Aug 13 2021, 9:18 PM

Aug 12 2021

tsoome committed R10:5d5a6216645a: loader: cstyle cleanup of userboot/devicename.c (authored by tsoome).
loader: cstyle cleanup of userboot/devicename.c
Aug 12 2021, 9:29 AM
tsoome added inline comments to D31512: pxeboot: improve and simplify rx handling.
Aug 12 2021, 8:55 AM
tsoome added a comment to D31512: pxeboot: improve and simplify rx handling.

This is something I was suspecting to happen:) Still need to read the resulting code carefully. Which method was used to load kernel, tftp or nfs?

Aug 12 2021, 6:40 AM

Aug 11 2021

tsoome committed R10:ee6dc333e1a1: libsecureboot: define SOPEN_MAX (authored by tsoome).
libsecureboot: define SOPEN_MAX
Aug 11 2021, 10:07 PM
tsoome committed R10:97cbd5e72238: loader: open file list should be dynamic (authored by tsoome).
loader: open file list should be dynamic
Aug 11 2021, 9:14 PM
tsoome closed D31364: loader: open file list should be dynamic.
Aug 11 2021, 9:14 PM

Aug 9 2021

tsoome committed R10:e6639057146d: loader: tftp client should use server address from rootip (authored by tsoome).
loader: tftp client should use server address from rootip
Aug 9 2021, 8:26 AM
tsoome committed R10:e6847536a89a: loader: cstyle cleanup of libsa/lseek.c (authored by tsoome).
loader: cstyle cleanup of libsa/lseek.c
Aug 9 2021, 8:23 AM

Aug 3 2021

tsoome updated the diff for D31364: loader: open file list should be dynamic.

Suggestions from imp.

Aug 3 2021, 7:48 AM
tsoome added inline comments to D31364: loader: open file list should be dynamic.
Aug 3 2021, 7:47 AM

Aug 2 2021

tsoome added inline comments to D31364: loader: open file list should be dynamic.
Aug 2 2021, 6:32 PM
tsoome updated the diff for D31364: loader: open file list should be dynamic.

As suggested by imp

Aug 2 2021, 12:46 PM
tsoome committed R10:1b1bb6f17880: loader: tftp client should use server address from rootip (authored by tsoome).
loader: tftp client should use server address from rootip
Aug 2 2021, 12:45 PM

Aug 1 2021

tsoome committed R10:bbb539b83cec: loader: cstyle cleanup of libsa/lseek.c (authored by tsoome).
loader: cstyle cleanup of libsa/lseek.c
Aug 1 2021, 7:12 AM

Jul 31 2021

tsoome requested review of D31364: loader: open file list should be dynamic.
Jul 31 2021, 8:11 AM

Jul 24 2021

tsoome accepted D31297: lua loader: Add disable-device to disable a device..
Jul 24 2021, 3:11 PM

Jul 23 2021

tsoome accepted D29961: vt: call driver's postswitch when panicking on ttyv0.
Jul 23 2021, 6:08 PM

Jul 19 2021

tsoome accepted D31047: Fix build of stand/ when building world with ASAN.

Thanks!

Jul 19 2021, 2:48 PM

Jul 15 2021

tsoome accepted D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Jul 15 2021, 9:26 AM

Jul 9 2021

tsoome accepted D31106: stand/kmem_zalloc: panic when a M_WAITOK allocation fails.

Seems good, thanks!

Jul 9 2021, 6:40 AM

Jul 8 2021

tsoome added inline comments to D31106: stand/kmem_zalloc: panic when a M_WAITOK allocation fails.
Jul 8 2021, 6:30 AM

Jun 22 2021

tsoome added inline comments to D30848: loader: implement mount/unmount rootfs.
Jun 22 2021, 5:02 AM

Jun 21 2021

tsoome added a comment to D30848: loader: implement mount/unmount rootfs.

This also returns with pd->pd_blkio set to non-NULL. Is this intentional?

Jun 21 2021, 9:48 PM
tsoome updated the diff for D30848: loader: implement mount/unmount rootfs.

do not set pd_blkio to NULL.

Jun 21 2021, 9:42 PM
tsoome requested review of D30848: loader: implement mount/unmount rootfs.
Jun 21 2021, 6:13 PM

Jun 5 2021

tsoome accepted D30650: nextboot: Improve the shell code used to figure out the zpool name.
Jun 5 2021, 8:32 AM

May 23 2021

tsoome committed R10:3dc9f92a0d3d: loader: gfx_fb_drawrect should use GfxFbBltVideoFill (authored by tsoome).
loader: gfx_fb_drawrect should use GfxFbBltVideoFill
May 23 2021, 8:24 AM

May 16 2021

tsoome committed R10:5365af662c78: loader: gfx_fb_drawrect should use GfxFbBltVideoFill (authored by tsoome).
loader: gfx_fb_drawrect should use GfxFbBltVideoFill
May 16 2021, 9:14 AM

May 12 2021

tsoome accepted D30227: Update the EFI timer to be called once a second.
May 12 2021, 4:14 PM

Apr 28 2021

tsoome committed R10:eabfffcb4c14: loader: do not output empty menu title (authored by tsoome).
loader: do not output empty menu title
Apr 28 2021, 9:37 AM

Apr 21 2021

tsoome committed R10:4ba91fa0736b: loader: do not output empty menu title (authored by tsoome).
loader: do not output empty menu title
Apr 21 2021, 11:51 AM

Apr 10 2021

tsoome committed R10:3056bbfc2cb2: loader: we should support pools without features (authored by tsoome).
loader: we should support pools without features
Apr 10 2021, 8:38 AM

Apr 4 2021

tsoome committed R10:d019c774e906: loader: insert spaces around menu title (authored by tsoome).
loader: insert spaces around menu title
Apr 4 2021, 8:25 AM
tsoome committed R10:d36341f7b8dd: loader: we should support pools without features (authored by tsoome).
loader: we should support pools without features
Apr 4 2021, 8:25 AM

Apr 1 2021

tsoome added a comment to D29512: Loader: support booting OS from memory disk (MD).

Since md case is depending on build options and is not part of generic build, this feature should not generate problems for general public. I do agree, it should get documented. Do we want to provide feature parity with i386 tree (BIOS loader)?

Thanks Toomas. I suspect that this feature is rarely used in legacy BIOS so did not add it in i386 tree. But I'm fine if you think it's worth to be added.

Apr 1 2021, 4:49 PM
tsoome accepted D29512: Loader: support booting OS from memory disk (MD).

Since md case is depending on build options and is not part of generic build, this feature should not generate problems for general public. I do agree, it should get documented. Do we want to provide feature parity with i386 tree (BIOS loader)?

Apr 1 2021, 9:38 AM

Mar 24 2021

tsoome accepted D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
Mar 24 2021, 8:30 PM