tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (115 w, 2 d)

Recent Activity

Sun, Feb 18

tsoome accepted D14415: efi: Do not pad the efi devpath structure.

LGTM

Sun, Feb 18, 7:15 AM

Thu, Feb 15

tsoome accepted D14373: libsa: Consolidate tftp sendrecv into net.c sendrecv.
Thu, Feb 15, 7:02 PM

Wed, Feb 14

tsoome accepted D14350: libsa: Fix IP recv timeout.
Wed, Feb 14, 6:16 AM
tsoome added a comment to D14350: libsa: Fix IP recv timeout.

For what it's worth, I would almost like to do something more like this: https://people.freebsd.org/~kevans/stand-ip.diff

It's a lot more invasive, but it gets rid sendrecv_tftp and consolidates MINTMO/MAXTMO timeout logic into one spot that everything honors.

Wed, Feb 14, 6:16 AM

Tue, Feb 13

tsoome accepted D14334: efi: Only scan the BLKIO MEDIA once.

shoot:)

Tue, Feb 13, 6:36 AM

Mon, Feb 12

tsoome added inline comments to D14334: efi: Only scan the BLKIO MEDIA once.
Mon, Feb 12, 8:29 PM
tsoome accepted D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.

nice catch.

Mon, Feb 12, 6:36 PM

Sat, Feb 10

tsoome added a comment to D14295: Add Lua as a scripting langauge to /boot/loader.

As an note, please install scripts into /boot/lua - so we wont pollute the whole /boot.

Sat, Feb 10, 9:48 AM
tsoome accepted D14295: Add Lua as a scripting langauge to /boot/loader.

Im sure there is still much to do, but go for it.

Sat, Feb 10, 9:39 AM

Jan 16 2018

tsoome committed rS328061: utf8_to_ucs2() should check for malloc failure.
utf8_to_ucs2() should check for malloc failure
Jan 16 2018, 8:36 PM
tsoome closed D13933: utf8_to_ucs2() should check for malloc failure.
Jan 16 2018, 8:36 PM
tsoome created D13933: utf8_to_ucs2() should check for malloc failure.
Jan 16 2018, 11:48 AM

Jan 15 2018

tsoome accepted D13917: When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory..
Jan 15 2018, 8:02 PM
tsoome added inline comments to D13918: Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string..
Jan 15 2018, 7:58 PM

Dec 19 2017

tsoome accepted D13541: [efi/boot1] Scan all display modes rather than sequential try-fail way.
Dec 19 2017, 8:53 AM

Dec 14 2017

tsoome committed rS326854: libefi: make efichar.h more usable in stand code.
libefi: make efichar.h more usable in stand code
Dec 14 2017, 4:42 PM
tsoome closed D13488: libefi: make efichar.h more usable in stand code.
Dec 14 2017, 4:42 PM
tsoome created D13488: libefi: make efichar.h more usable in stand code.
Dec 14 2017, 8:34 AM

Dec 6 2017

tsoome committed rS326616: dhcp_try_rfc1048() is not used any more.
dhcp_try_rfc1048() is not used any more
Dec 6 2017, 6:50 AM
tsoome closed D13382: dhcp_try_rfc1048() is not used any more.
Dec 6 2017, 6:50 AM

Dec 5 2017

tsoome created D13382: dhcp_try_rfc1048() is not used any more.
Dec 5 2017, 9:20 PM

Dec 4 2017

tsoome committed rS326509: loader.efi: add note about iPXE into the efipart.c.
loader.efi: add note about iPXE into the efipart.c
Dec 4 2017, 8:50 AM

Dec 1 2017

tsoome committed rS326421: loader.efi: efipart should exclude iPXE stub block protocol.
loader.efi: efipart should exclude iPXE stub block protocol
Dec 1 2017, 6:37 AM
tsoome closed D13297: loader.efi: efipart should exclude iPXE stub block protocol.
Dec 1 2017, 6:37 AM
tsoome updated the diff for D13297: loader.efi: efipart should exclude iPXE stub block protocol.

use proper powerof2

Dec 1 2017, 5:32 AM
tsoome added inline comments to D13297: loader.efi: efipart should exclude iPXE stub block protocol.
Dec 1 2017, 5:25 AM

Nov 30 2017

tsoome updated the diff for D13297: loader.efi: efipart should exclude iPXE stub block protocol.

Update to check BlockSize

Nov 30 2017, 9:16 PM
tsoome accepted D13301: Fix various warnings related to geli support..
Nov 30 2017, 5:03 PM
tsoome added inline comments to D13297: loader.efi: efipart should exclude iPXE stub block protocol.
Nov 30 2017, 1:05 PM
tsoome accepted D13301: Fix various warnings related to geli support..

Seems good.

Nov 30 2017, 6:35 AM

Nov 29 2017

tsoome updated the diff for D13297: loader.efi: efipart should exclude iPXE stub block protocol.

use macro for constant.

Nov 29 2017, 6:52 PM
tsoome created D13297: loader.efi: efipart should exclude iPXE stub block protocol.
Nov 29 2017, 6:14 PM

Nov 22 2017

tsoome committed rS326090: net_parse_rootpath() has no parameters.
net_parse_rootpath() has no parameters
Nov 22 2017, 10:04 AM
tsoome closed D13026: loader.efi: efipart does not recognize partitionless disks.
Nov 22 2017, 8:48 AM
tsoome committed rS326089: loader.efi: efipart does not recognize partitionless disks.
loader.efi: efipart does not recognize partitionless disks
Nov 22 2017, 8:48 AM

Nov 18 2017

tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

Add more comments and reorder some checks

Nov 18 2017, 10:57 AM

Nov 15 2017

tsoome created D13109: regex/engine.c: error: variable 'dp' set but not used.
Nov 15 2017, 9:29 PM
tsoome added a comment to D13026: loader.efi: efipart does not recognize partitionless disks.
In D13026#272423, @imp wrote:

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

Nov 15 2017, 3:13 PM
tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

Update to revision 325851.

Nov 15 2017, 1:12 PM

Nov 10 2017

tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

efipart_hdd() was quite broken.

Nov 10 2017, 5:05 PM
tsoome created D13026: loader.efi: efipart does not recognize partitionless disks.
Nov 10 2017, 12:39 PM
tsoome committed rS325641: loader.efi: efi_devpath_is_prefix should return bool.
loader.efi: efi_devpath_is_prefix should return bool
Nov 10 2017, 12:08 PM
tsoome accepted D12924: Remove mailaddr(7).
Nov 10 2017, 8:19 AM

Nov 2 2017

tsoome committed rS325310: zfs.c:vdev_read() needs to be careful about large sectors.
zfs.c:vdev_read() needs to be careful about large sectors
Nov 2 2017, 8:47 AM
tsoome closed D12850: zfs.c:vdev_read() needs to be careful about large sectors.
Nov 2 2017, 8:47 AM

Nov 1 2017

tsoome committed rS325286: efipart_strategy is using wrong offset with >512B sectors.
efipart_strategy is using wrong offset with >512B sectors
Nov 1 2017, 6:50 PM
tsoome closed D12849: efipart_strategy is using wrong offset with >512B sectors.
Nov 1 2017, 6:50 PM
tsoome updated the diff for D12850: zfs.c:vdev_read() needs to be careful about large sectors.

Validate the return value from lseek()

Nov 1 2017, 8:31 AM

Oct 31 2017

tsoome closed D12847: loader ptblread() is broken with >512B sectors.
Oct 31 2017, 8:29 PM
tsoome committed rS325248: loader ptblread() is broken with >512B sectors.
loader ptblread() is broken with >512B sectors
Oct 31 2017, 8:29 PM
tsoome updated the diff for D12849: efipart_strategy is using wrong offset with >512B sectors.

offset is better name.

Oct 31 2017, 8:22 PM
tsoome updated the diff for D12847: loader ptblread() is broken with >512B sectors.

Reword the comment.

Oct 31 2017, 8:05 PM
tsoome created D12850: zfs.c:vdev_read() needs to be careful about large sectors.
Oct 31 2017, 11:57 AM
tsoome created D12849: efipart_strategy is using wrong offset with >512B sectors.
Oct 31 2017, 11:53 AM
tsoome created D12847: loader ptblread() is broken with >512B sectors.
Oct 31 2017, 11:48 AM

Oct 20 2017

tsoome requested changes to D12732: Revert efipart to use EFI_HANDLEs for partitions.

This patch will need more work and cleanup, especially printing information about the devices.

Oct 20 2017, 9:02 AM

Oct 18 2017

tsoome committed rS324719: libsa/ip: stop read loop on bad fragments.
libsa/ip: stop read loop on bad fragments
Oct 18 2017, 8:06 AM
tsoome committed rS324717: libsa/ip.c: misplaced comment, ip_v is half char, not ip_p.
libsa/ip.c: misplaced comment, ip_v is half char, not ip_p
Oct 18 2017, 7:39 AM

Oct 13 2017

tsoome added a comment to D10447: Unify boot1 with loader.
In D10447#262729, @imp wrote:

I wonder why we even have boot1 anymore after these changes.... It's turning into a mini loader.efi. I wonder why we don't just kill it entirely. We don't need boot volume selection (that's supposed to be the EFI boot BIOS's job). We seem to duplicate a lot of code just to load /boot/loader.efi off of UFS or ZFS partitions. However, we could just use loader.efi directly (though some of the root detection code would need to be tweaked). boot1 used to be small, limited and basically unchanging (so updates weren't needed). Now that boot1.efi has hitched its wagon to loader.efi, I wonder why have an extra boot stage that seems to be good at messing up it's partition guessing...

I'm going to go ahead and commit this (after adding back the bits I keep saying were bogusly deleted), but I'm thinking strongly that we consider just moving to loader.efi installed into \efi\freebsd\loader.efi starting in FreeBSD 12 since we'll be able to point efibootmgr at it by then.

Oct 13 2017, 5:07 AM

Oct 2 2017

tsoome accepted D12565: remove heuristic error detection from ddi_strto*().
Oct 2 2017, 2:11 PM

Sep 25 2017

tsoome committed rS323991: libefi: efipart_floppy() will should not pass acpi pointer if the HID test fails.
libefi: efipart_floppy() will should not pass acpi pointer if the HID test fails
Sep 25 2017, 7:50 PM

Sep 22 2017

tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

Sep 22 2017, 8:20 PM
tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

Sep 22 2017, 6:59 PM
tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

Sep 22 2017, 5:37 PM
tsoome committed rS323909: libefi: define EISA PNP constants.
libefi: define EISA PNP constants
Sep 22 2017, 7:44 AM
tsoome committed rS323908: libefi: efipart_hdinfo_add_filepath should check strtol result.
libefi: efipart_hdinfo_add_filepath should check strtol result
Sep 22 2017, 7:40 AM
tsoome committed rS323907: libefi: efipart.c cstyle fix for efipart_print_common().
libefi: efipart.c cstyle fix for efipart_print_common()
Sep 22 2017, 7:38 AM
tsoome committed rS323906: libefi: efipart_strategy() should return ENXIO when there is no media.
libefi: efipart_strategy() should return ENXIO when there is no media
Sep 22 2017, 7:34 AM
tsoome committed rS323905: libefi: pdinfo_t pd_unit and pd_open should be unsigned.
libefi: pdinfo_t pd_unit and pd_open should be unsigned
Sep 22 2017, 7:29 AM
tsoome committed rS323897: efilib.h: typo in structure member description.
efilib.h: typo in structure member description
Sep 22 2017, 2:59 AM
tsoome committed rS323896: r323885 did miss efilib.h update.
r323885 did miss efilib.h update
Sep 22 2017, 2:56 AM
tsoome committed rS323895: libefi: efi_devpath_match local len should be unsigned.
libefi: efi_devpath_match local len should be unsigned
Sep 22 2017, 2:53 AM

Sep 21 2017

tsoome committed rS323886: libefi: efipart.c should use calloc().
libefi: efipart.c should use calloc()
Sep 21 2017, 11:22 PM
tsoome committed rS323885: libefi: efi_devpath_match() should return bool.
libefi: efi_devpath_match() should return bool
Sep 21 2017, 11:14 PM
tsoome committed rS323867: libefi: devicename.c cleanups.
libefi: devicename.c cleanups
Sep 21 2017, 3:30 PM

Sep 18 2017

tsoome committed rS323707: loader: biosmem allocate heap just below 4GB.
loader: biosmem allocate heap just below 4GB
Sep 18 2017, 3:17 PM
tsoome closed D12368: loader: biosmem allocate heap just below 4GB.
Sep 18 2017, 3:17 PM

Sep 14 2017

tsoome updated the diff for D12368: loader: biosmem allocate heap just below 4GB.

update after cstyle fix commit.

Sep 14 2017, 4:46 PM
tsoome committed rS323589: loader: biosmem.c cstyle cleanup.
loader: biosmem.c cstyle cleanup
Sep 14 2017, 4:42 PM
tsoome closed D12370: loader: biosmem.c cstyle cleanup.
Sep 14 2017, 4:42 PM
tsoome updated the summary of D12370: loader: biosmem.c cstyle cleanup.
Sep 14 2017, 3:19 PM
tsoome created D12370: loader: biosmem.c cstyle cleanup.
Sep 14 2017, 3:18 PM
tsoome added a comment to D12368: loader: biosmem allocate heap just below 4GB.

The whitespace changes make this a bit hard to read - do you have them as a separate local change that could be committed first?

Sep 14 2017, 2:11 PM
tsoome updated the summary of D12368: loader: biosmem allocate heap just below 4GB.
Sep 14 2017, 12:26 PM
tsoome created D12368: loader: biosmem allocate heap just below 4GB.
Sep 14 2017, 12:25 PM

Sep 13 2017

tsoome committed rS323541: libefi: efipart_realstrategy rsize pointer may be NULL.
libefi: efipart_realstrategy rsize pointer may be NULL
Sep 13 2017, 2:27 PM
tsoome accepted D9680: Increase EFI MSDOSFS image size to 512Kib.
Sep 13 2017, 7:09 AM

Sep 12 2017

tsoome closed D12340: libefi: efipart_open should check the status from disk_open.
Sep 12 2017, 2:19 PM
tsoome committed rS323497: libefi: efipart_open should check the status from disk_open.
libefi: efipart_open should check the status from disk_open
Sep 12 2017, 2:19 PM
tsoome created D12340: libefi: efipart_open should check the status from disk_open.
Sep 12 2017, 2:10 PM
tsoome closed D12202: libstand: tftp_open() can leak pkt on error.
Sep 12 2017, 1:51 PM
tsoome committed rS323496: libstand: tftp_open() can leak pkt on error.
libstand: tftp_open() can leak pkt on error
Sep 12 2017, 1:51 PM
tsoome committed rS323494: loader should support large_dnode.
loader should support large_dnode
Sep 12 2017, 1:45 PM
tsoome closed D12288: loader should support large_dnode.
Sep 12 2017, 1:45 PM

Sep 11 2017

tsoome updated the diff for D12288: loader should support large_dnode.

svn update

Sep 11 2017, 11:57 AM
tsoome updated the test plan for D12288: loader should support large_dnode.
Sep 11 2017, 11:54 AM
tsoome committed rS323428: r323389 breaks the kernel build when WITHOUT_ZFS is defined in src.conf.
r323389 breaks the kernel build when WITHOUT_ZFS is defined in src.conf
Sep 11 2017, 7:39 AM

Sep 10 2017

tsoome committed rS323389: loader.efi: chain loader should provide proper device handle.
loader.efi: chain loader should provide proper device handle
Sep 10 2017, 1:54 PM
tsoome closed D12287: loader.efi: chain loader should provide proper device handle.
Sep 10 2017, 1:53 PM

Sep 9 2017

tsoome created D12288: loader should support large_dnode.
Sep 9 2017, 11:58 AM