In D29512#662063, @yongbo.yao_dell.com wrote:

In D29512#661895, @tsoome wrote:

Since md case is depending on build options and is not part of generic build, this feature should not generate problems for general public. I do agree, it should get documented. Do we want to provide feature parity with i386 tree (BIOS loader)?

Thanks Toomas. I suspect that this feature is rarely used in legacy BIOS so did not add it in i386 tree. But I'm fine if you think it's worth to be added.

Since md case is depending on build options and is not part of generic build, this feature should not generate problems for general public. I do agree, it should get documented. Do we want to provide feature parity with i386 tree (BIOS loader)?

In D29020#655703, @manu wrote:

In D29020#655696, @emaste wrote:

@tsoome will you commit?

I planned to do it last weekend but this was delayed for this week. I'll probably do that tomorow.

In D29126#652263, @chuck wrote:

I'm having trouble matching pci_nvme.c:903 to current, stable/12 or stable/13. Which branch is this? I'm curious to see why the compiler doesn't like this instance as (naively) everything should be nicely aligned.

In D29126#652257, @chuck wrote:

I'm happy to help out on the NVMe part but don't see this warning while building x86_64 on current. Can you point me in the direction of how to reproduce this?

You want to add the same to vbefb.

use MAX().

There is this thing....

make it actually to work...

use gop_handle, not gop protocol

In D28707#643373, @manu wrote:

In D28707#643366, @emaste wrote:

@allanjude these originated as a number of commits, right? Does it make sense to start committing earlier patches that have been reviewed (e.g. stand bits) and rebase this review?

stand patches can't go in without the kernel ones.
If we find a smbios v3 table we don't set the kenv of the v2.1 one so kernel won't work.

The loader part seems OK for me (I did the SMB3 support in illumos loader), the kernel part seems to make sense, but I am not familiar with those bits:)

There are few concerns... not yet complete list as it is getting late for me, but hopefully it will still be helpful.

Seems to be OK.

In D24041#635435, @imp wrote:

My big concern with this is that there is no override provision. It is good we set it early, but it makes it harder to say you want a video console instead...

update zfsboot (gptzfsboot) to check SPCR.