Page MenuHomeFreeBSD

tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (218 w, 4 d)

Recent Activity

Mon, Feb 10

tsoome accepted D23611: lualoader: disable autoboot on high-level interpreter errors.
Mon, Feb 10, 8:09 PM

Wed, Feb 5

tsoome committed rS357571: followup on r357497: clean obsolete comment and use shift instead of….
followup on r357497: clean obsolete comment and use shift instead of…
Wed, Feb 5, 1:08 PM
tsoome committed rS357569: zfsboot: vdev_read_pad2 does allocate buffer with wrong size.
zfsboot: vdev_read_pad2 does allocate buffer with wrong size
Wed, Feb 5, 11:02 AM
tsoome committed rS357567: vdev_read_pad2: freeing wrong pointer.
vdev_read_pad2: freeing wrong pointer
Wed, Feb 5, 5:43 AM

Tue, Feb 4

tsoome committed rS357497: loader: rewrite zfs reader zap code to use malloc.
loader: rewrite zfs reader zap code to use malloc
Tue, Feb 4, 7:38 AM
tsoome closed D23433: loader: rewrite zfs reader zap code to use malloc.
Tue, Feb 4, 7:38 AM
tsoome committed rS357496: MFC r357442:.
MFC r357442:
Tue, Feb 4, 7:19 AM
tsoome committed rS357495: MFC r357442:.
MFC r357442:
Tue, Feb 4, 7:15 AM

Mon, Feb 3

tsoome updated the diff for D23433: loader: rewrite zfs reader zap code to use malloc.

Suggestions from delphij, thanks!

Mon, Feb 3, 5:51 PM
tsoome committed rS357442: loader: bc_add can not use any other probes than ah=0x4b.
loader: bc_add can not use any other probes than ah=0x4b
Mon, Feb 3, 11:33 AM

Sun, Feb 2

tsoome accepted D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Sun, Feb 2, 7:17 AM

Fri, Jan 31

tsoome updated the diff for D23433: loader: rewrite zfs reader zap code to use malloc.

replace if chain by switch. Print out entire zap_block_type.

Fri, Jan 31, 4:12 PM

Thu, Jan 30

tsoome created D23433: loader: rewrite zfs reader zap code to use malloc.
Thu, Jan 30, 8:33 PM
tsoome accepted D23411: stand: properly declare build dependencies or .WAIT, start building in parallel.
Thu, Jan 30, 6:03 AM

Jan 13 2020

tsoome added a reverting change for rS356693: loader: allocate properly aligned buffer for network packet: rS356700: Backout 356693. The libsa malloc does provide necessary alignment and.
Jan 13 2020, 8:02 PM
tsoome committed rS356700: Backout 356693. The libsa malloc does provide necessary alignment and.
Backout 356693. The libsa malloc does provide necessary alignment and
Jan 13 2020, 8:02 PM
tsoome committed rS356693: loader: allocate properly aligned buffer for network packet.
loader: allocate properly aligned buffer for network packet
Jan 13 2020, 6:23 PM

Jan 9 2020

tsoome committed rS356572: MFC r356570:.
MFC r356570:
Jan 9 2020, 9:41 PM
tsoome committed rS356571: MFC r356570:.
MFC r356570:
Jan 9 2020, 9:38 PM
tsoome committed rS356570: loader: bioscd probe can get sector size 0.
loader: bioscd probe can get sector size 0
Jan 9 2020, 9:21 PM

Jan 6 2020

tsoome committed rS356424: loader: update zfsimpl.c from illumos review suggestions.
loader: update zfsimpl.c from illumos review suggestions
Jan 6 2020, 7:35 PM

Dec 29 2019

tsoome accepted D22951: "help" loader command broken.
Dec 29 2019, 9:39 AM
tsoome added inline comments to D22951: "help" loader command broken.
Dec 29 2019, 8:10 AM

Dec 22 2019

tsoome committed rS356027: MFC r355844:.
MFC r355844:
Dec 22 2019, 8:37 PM
tsoome committed rS356003: MFC r354283, r354323, r354363, r354364, r354593, r355773, r355786:.
MFC r354283, r354323, r354363, r354364, r354593, r355773, r355786:
Dec 22 2019, 8:22 AM

Dec 20 2019

tsoome committed rS355929: MFC r355702:.
MFC r355702:
Dec 20 2019, 8:16 AM
tsoome committed rS355928: MFC r355703:.
MFC r355703:
Dec 20 2019, 8:13 AM
tsoome committed rS355927: MFC r355713:.
MFC r355713:
Dec 20 2019, 7:40 AM

Dec 17 2019

tsoome committed rS355844: loader.efi: efi_readkey_ex needs to key despite the shift status or toggle….
loader.efi: efi_readkey_ex needs to key despite the shift status or toggle…
Dec 17 2019, 8:30 AM

Dec 15 2019

tsoome committed rS355786: loader: rewrite zfs vdev initialization.
loader: rewrite zfs vdev initialization
Dec 15 2019, 9:52 PM
tsoome committed rS355773: loader: zfsimpl.c cstyle cleanup.
loader: zfsimpl.c cstyle cleanup
Dec 15 2019, 2:10 PM

Dec 13 2019

tsoome committed rS355713: loader: cd9660_open() warn: is 'buf' large enough for 'struct….
loader: cd9660_open() warn: is 'buf' large enough for 'struct…
Dec 13 2019, 12:36 PM
tsoome committed rS355703: loader: clean up devopen and devclose a bit.
loader: clean up devopen and devclose a bit
Dec 13 2019, 8:42 AM
tsoome committed rS355702: loader: vdisk dereference after free.
loader: vdisk dereference after free
Dec 13 2019, 8:20 AM

Dec 9 2019

tsoome committed rS355571: MFC r355347:.
MFC r355347:
Dec 9 2019, 9:10 PM
tsoome committed rS355560: MFC r355224, r355308, r355392:.
MFC r355224, r355308, r355392:
Dec 9 2019, 4:21 PM

Dec 6 2019

tsoome added a comment to D22139: loader.efi: implement comconsole with UEFI SerialIO protocol.

Would it be possible to also support memory-mapped UART this way? Intel >=Skylake and all aarch64 systems use mmio.
I've added an SPCR table to my Kaby Lake laptop to configure the UART, but it would be nice if it could auto configure without SPCR.

Dec 6 2019, 12:00 PM
tsoome updated the diff for D22139: loader.efi: implement comconsole with UEFI SerialIO protocol.

Rename comconsole.c to efiserialio.c to avoid issues with libi386/comconsole.c.
On x86, use libi386/comconsole because we still can not ensure the proper order
of serial ports and there is known issue on some systems with input on serial.

Dec 6 2019, 10:07 AM
tsoome committed rS355441: loader.efi: print ImageBase so we know where we are.
loader.efi: print ImageBase so we know where we are
Dec 6 2019, 9:50 AM
tsoome accepted D22663: Warn against use of whole disks in boot, mirror, and RAID-Z zpools..
Dec 6 2019, 9:40 AM

Dec 4 2019

tsoome committed rS355392: loader: clean up efipart filter expressions.
loader: clean up efipart filter expressions
Dec 4 2019, 4:41 PM

Dec 3 2019

tsoome committed rS355347: loader: ReadKeyStrokeEx may return partial keystrokes.
loader: ReadKeyStrokeEx may return partial keystrokes
Dec 3 2019, 6:36 PM

Dec 2 2019

tsoome committed rS355308: loader.efi: fix cd boot for cisco C220M3.
loader.efi: fix cd boot for cisco C220M3
Dec 2 2019, 9:09 PM
tsoome committed rS355292: MFC r355291:.
MFC r355291:
Dec 2 2019, 3:44 PM
tsoome committed rS355291: libzpool: use CFLAGS.lz4.c to build lz4.o and lz4.pico.
libzpool: use CFLAGS.lz4.c to build lz4.o and lz4.pico
Dec 2 2019, 3:37 PM
tsoome committed rS355290: libzpool: lz4.c build needs CFLAGS.lz4.c.
libzpool: lz4.c build needs CFLAGS.lz4.c
Dec 2 2019, 3:28 PM
tsoome committed rS355286: MFC r354267:.
MFC r354267:
Dec 2 2019, 12:27 PM
tsoome committed rS355285: MFC r354253, r354254, r354264, r354265.
MFC r354253, r354254, r354264, r354265
Dec 2 2019, 11:44 AM
tsoome committed rS355284: r353501 did mimerge r350654 boot1 and gptboot were left out.
r353501 did mimerge r350654 boot1 and gptboot were left out
Dec 2 2019, 9:57 AM

Nov 30 2019

tsoome committed rS355224: loader.efi: efipart needs better support detecting nested partitions.
loader.efi: efipart needs better support detecting nested partitions
Nov 30 2019, 9:11 AM
tsoome closed D22553: loader.efi: efipart needs better support detecting nested partitions.
Nov 30 2019, 9:11 AM
tsoome updated the summary of D22553: loader.efi: efipart needs better support detecting nested partitions.
Nov 30 2019, 9:08 AM

Nov 29 2019

tsoome updated the diff for D22553: loader.efi: efipart needs better support detecting nested partitions.

really check the device node type. Free unused devpaths by calling
efi_close_devpath().

Nov 29 2019, 10:59 AM

Nov 28 2019

tsoome updated the diff for D22553: loader.efi: efipart needs better support detecting nested partitions.

need to handle usb luns

Nov 28 2019, 1:37 PM

Nov 27 2019

tsoome updated the diff for D22553: loader.efi: efipart needs better support detecting nested partitions.

left over debug printf.

Nov 27 2019, 5:38 PM
tsoome accepted D22569: Add support to allocate more space before and after a current allocation.

Seems ok.
Note, the issue about the staging size is not really if we can or can not allocate specific size, but if we have enough target space to copy it. I have starting to port other change (https://reviews.freebsd.org/D22309), the idea there is that we should determine if the target location has enough space. The bios version is simple as there we own the memory and we can not load directly to target address, in UEFI case we need to allocate, load and after switching off the BS, only then we can copy.

Nov 27 2019, 4:08 PM

Nov 26 2019

tsoome updated the diff for D22553: loader.efi: efipart needs better support detecting nested partitions.

Wrong place for efi_devpath_trim.
No need to walk partitions in efipart_find_parent.
No need for local variable.

Nov 26 2019, 12:07 PM

Nov 25 2019

tsoome created D22553: loader.efi: efipart needs better support detecting nested partitions.
Nov 25 2019, 9:56 PM

Nov 18 2019

tsoome committed rS354818: MFC r354746:.
MFC r354746:
Nov 18 2019, 4:40 PM
tsoome committed rS354817: MFC r354743, r354766:.
MFC r354743, r354766:
Nov 18 2019, 4:37 PM

Nov 16 2019

tsoome committed rS354766: loader: remove unused variable from efipart.c.
loader: remove unused variable from efipart.c
Nov 16 2019, 8:17 AM

Nov 15 2019

tsoome committed rS354746: loader: add support for hybrid PMBR for GPT partition table.
loader: add support for hybrid PMBR for GPT partition table
Nov 15 2019, 8:43 PM
tsoome committed rS354743: loader: r354415 did miss to sort subpaths below the partitions.
loader: r354415 did miss to sort subpaths below the partitions
Nov 15 2019, 6:57 PM

Nov 14 2019

tsoome committed rS354704: MFC r354435:.
MFC r354435:
Nov 14 2019, 9:39 AM

Nov 13 2019

tsoome committed rS354674: MFC: r354415.
MFC: r354415
Nov 13 2019, 7:04 AM

Nov 12 2019

tsoome committed rS354635: reverting r354594.
reverting r354594
Nov 12 2019, 10:02 AM

Nov 10 2019

tsoome created D22309: loader: bios loader should check the smap while loading the modules.
Nov 10 2019, 9:17 PM
tsoome committed rS354594: loader: use struct initializer in vdev_probe()..
loader: use struct initializer in vdev_probe().
Nov 10 2019, 3:07 PM
tsoome committed rS354593: loader: memory leak in vdev_label_read_config().
loader: memory leak in vdev_label_read_config()
Nov 10 2019, 3:04 PM
tsoome committed rS354590: MFC r354279:.
MFC r354279:
Nov 10 2019, 9:32 AM

Nov 8 2019

tsoome committed rS354535: cstyle cleanup for i386_copy.c.
cstyle cleanup for i386_copy.c
Nov 8 2019, 12:19 PM

Nov 7 2019

tsoome committed rS354435: loader: implement fallback efi_devpath_to_name().
loader: implement fallback efi_devpath_to_name()
Nov 7 2019, 11:17 AM

Nov 6 2019

tsoome committed rS354415: loader.efi: HARDDRIVE_DEVICE_PATH may have subpaths.
loader.efi: HARDDRIVE_DEVICE_PATH may have subpaths
Nov 6 2019, 9:13 PM

Nov 5 2019

tsoome committed rS354364: loader: clean up the noise around log device.
loader: clean up the noise around log device
Nov 5 2019, 6:35 PM
tsoome committed rS354363: loader: populate nvl with data even when label_txg is 0.
loader: populate nvl with data even when label_txg is 0
Nov 5 2019, 6:07 PM

Nov 4 2019

tsoome committed rS354332: loader: show APFS partition type name.
loader: show APFS partition type name
Nov 4 2019, 12:20 PM
tsoome committed rS354330: MFC r354237:.
MFC r354237:
Nov 4 2019, 6:36 AM

Nov 3 2019

tsoome committed rS354324: loader: allow booting from pool with log device.
loader: allow booting from pool with log device
Nov 3 2019, 9:36 PM
tsoome committed rS354323: loader: factor out label and uberblock load from vdev_probe, add MMP checks.
loader: factor out label and uberblock load from vdev_probe, add MMP checks
Nov 3 2019, 9:20 PM
tsoome committed rS354284: loader: zfs.c is missing malloc checks, fix it.
loader: zfs.c is missing malloc checks, fix it
Nov 3 2019, 2:36 PM
tsoome committed rS354283: loader: we do not support booting from pool with log device.
loader: we do not support booting from pool with log device
Nov 3 2019, 1:25 PM
tsoome committed rS354282: loader: should check malloc in zfs_dev_open.
loader: should check malloc in zfs_dev_open
Nov 3 2019, 1:04 PM
tsoome committed rS354279: loader: calculate physical vdev psize from asize.
loader: calculate physical vdev psize from asize
Nov 3 2019, 11:09 AM
tsoome committed rS354278: loader: userboot/test should accept more than one disk.
loader: userboot/test should accept more than one disk
Nov 3 2019, 9:14 AM
tsoome committed rS354277: MFC: r354127.
MFC: r354127
Nov 3 2019, 7:11 AM

Nov 2 2019

tsoome committed rS354267: r354264 did mix up the directory path.
r354264 did mix up the directory path
Nov 2 2019, 9:53 PM
tsoome committed rS354265: r354253 did miss the fact that libzpool is built as fake kernel.
r354253 did miss the fact that libzpool is built as fake kernel
Nov 2 2019, 9:03 PM
tsoome committed rS354264: r354253 did miss the updates to sys/conf/files and sys/conf/kern.pre.mk.
r354253 did miss the updates to sys/conf/files and sys/conf/kern.pre.mk
Nov 2 2019, 8:47 PM
tsoome committed rS354254: r354253 did miss lz4.c from sys/cddl/boot/zfs..
r354253 did miss lz4.c from sys/cddl/boot/zfs.
Nov 2 2019, 3:08 PM
tsoome closed D22037: remove duplicate lz4 implementations.
Nov 2 2019, 12:28 PM
tsoome committed rS354253: Remove duplicate lz4 implementations.
Remove duplicate lz4 implementations
Nov 2 2019, 12:28 PM
tsoome committed rS354252: loader: libi386/comconsole.c cstyle cleanup.
loader: libi386/comconsole.c cstyle cleanup
Nov 2 2019, 10:53 AM
tsoome committed rS354249: loader: fall back to term_emu on efi console with serial backend.
loader: fall back to term_emu on efi console with serial backend
Nov 2 2019, 9:50 AM
tsoome closed D22161: loader: fall back to term_emu on efi console with serial backend In case of efi console having serial backend (video + serial or only serial), we need to stick with old emulator till we can draw console..
Nov 2 2019, 9:50 AM
tsoome committed rS354248: MFC r354119:.
MFC r354119:
Nov 2 2019, 9:22 AM

Nov 1 2019

tsoome committed rS354237: loader: asprinf does crash arm64 due to missing NULL pointer check.
loader: asprinf does crash arm64 due to missing NULL pointer check
Nov 1 2019, 6:54 AM

Oct 27 2019

tsoome committed rS354127: loader: zio_checksum_verify should check byteswap.
loader: zio_checksum_verify should check byteswap
Oct 27 2019, 8:35 AM

Oct 26 2019

tsoome committed rS354119: loader: rs_alloc() may return NULL.
loader: rs_alloc() may return NULL
Oct 26 2019, 6:29 PM
tsoome created D22161: loader: fall back to term_emu on efi console with serial backend In case of efi console having serial backend (video + serial or only serial), we need to stick with old emulator till we can draw console..
Oct 26 2019, 5:52 PM
tsoome committed rS354114: MFC r353757:.
MFC r353757:
Oct 26 2019, 10:33 AM