Page MenuHomeFreeBSD
People tsoome

tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (156 w, 3 d)

Recent Activity
View All

Mon, Dec 3

tsoome committed rS341438: zfs: we can boot from dataset with large_dnode enabled.
zfs: we can boot from dataset with large_dnode enabled
Mon, Dec 3, 7:36 PM
tsoome closed D18391: zfs: we can boot from dataset with large_dnode enabled.
Mon, Dec 3, 7:36 PM
tsoome accepted D18369: stand/i386: rename .s to .S to use Clang IAS.
Mon, Dec 3, 7:08 PM

Fri, Nov 30

tsoome added inline comments to D17131: loader: create bio_alloc and bio_free for bios bounce buffer.
Fri, Nov 30, 5:22 PM
tsoome updated the diff for D17131: loader: create bio_alloc and bio_free for bios bounce buffer.

Rebase on r341328

Fri, Nov 30, 11:41 AM
tsoome added a comment to D18391: zfs: we can boot from dataset with large_dnode enabled.
In D18391#391262, @avg wrote:

Maybe rather than removing the code it would be better to ifdef it out?
But not sure. What are plans for illumos in this respect?

Fri, Nov 30, 11:34 AM
tsoome created D18391: zfs: we can boot from dataset with large_dnode enabled.
Fri, Nov 30, 10:51 AM
tsoome committed rS341329: loader.efi: fix EFI getchar() for multiple consoles.
loader.efi: fix EFI getchar() for multiple consoles
Fri, Nov 30, 8:42 AM
tsoome committed rS341328: loader: create separate lists for fd, cd and hd, merge bioscd with biosdisk.
loader: create separate lists for fd, cd and hd, merge bioscd with biosdisk
Fri, Nov 30, 8:04 AM
tsoome closed D17888: loader: create separate lists for fd, cd and hd, merge bioscd with biosdisk.
Fri, Nov 30, 8:04 AM

Thu, Nov 29

tsoome committed rS341231: loader: command_bcache() should print unsigned values.
loader: command_bcache() should print unsigned values
Thu, Nov 29, 2:22 PM
tsoome committed rS341230: MFC r340047:.
MFC r340047:
Thu, Nov 29, 2:01 PM
tsoome committed rS341229: MFC r340049:.
MFC r340049:
Thu, Nov 29, 1:58 PM
tsoome committed rS341228: MFC r339959:.
MFC r339959:
Thu, Nov 29, 1:54 PM
tsoome committed rS341227: MFC r339658:.
MFC r339658:
Thu, Nov 29, 1:47 PM
tsoome committed rS341226: MFC r340215:.
MFC r340215:
Thu, Nov 29, 1:40 PM
tsoome committed rS341225: MFC: r340240:.
MFC: r340240:
Thu, Nov 29, 1:01 PM
tsoome committed rS341224: MFC r339651,339992-339993,340026.
MFC r339651,339992-339993,340026
Thu, Nov 29, 12:14 PM
tsoome updated the diff for D17888: loader: create separate lists for fd, cd and hd, merge bioscd with biosdisk.

Cleaning up a bit:

Thu, Nov 29, 9:54 AM

Thu, Nov 22

tsoome accepted D18299: Get rid of superfluous "bug marker" code in the bcache.

Good by me - I did add this for extra safety because the malloc markers are checked on free. And since we havent been bitten yet, I guess we are good:)

Thu, Nov 22, 6:22 PM

Fri, Nov 16

tsoome added a comment to D17947: Rework UEFI ESP generation.
In D17947#384896, @bcran wrote:
In D17947#384893, @allanjude wrote:

I think the EFI size should be 200MB or 256MB, rather than 35MB

I’m not sure that the install media should waste that much space for the ESP. It should definitely be around 200MB when being installed though.

Fri, Nov 16, 7:00 AM

Nov 7 2018

tsoome committed rS340240: loader: ptable_open() check for ptable_cd9660read result is wrong.
loader: ptable_open() check for ptable_cd9660read result is wrong
Nov 7 2018, 9:37 PM
tsoome closed D17890: loader: ptable_open() check for ptable_cd9660read result is wrong.
Nov 7 2018, 9:37 PM
tsoome added a comment to D17890: loader: ptable_open() check for ptable_cd9660read result is wrong.
In D17890#382275, @lev wrote:

This helps. It doen't show BSD partitions, but shows all four MBR slices without crash.

Nov 7 2018, 9:19 PM
tsoome created D17890: loader: ptable_open() check for ptable_cd9660read result is wrong.
Nov 7 2018, 1:50 PM
tsoome created D17888: loader: create separate lists for fd, cd and hd, merge bioscd with biosdisk.
Nov 7 2018, 12:19 PM
tsoome committed rS340215: loader: always set media size from partition..
loader: always set media size from partition.
Nov 7 2018, 11:14 AM
tsoome closed D17822: loader: always set media size from partition..
Nov 7 2018, 11:14 AM

Nov 5 2018

tsoome updated the diff for D17822: loader: always set media size from partition..

Typo fixed.

Nov 5 2018, 9:01 AM
tsoome added inline comments to D17822: loader: always set media size from partition..
Nov 5 2018, 9:00 AM

Nov 3 2018

tsoome created D17822: loader: always set media size from partition..
Nov 3 2018, 12:52 PM

Nov 2 2018

tsoome committed rS340049: loader: biosdisk should check if the media is present.
loader: biosdisk should check if the media is present
Nov 2 2018, 11:42 AM
tsoome committed rS340047: loader: do not probe floppy devices for zfs.
loader: do not probe floppy devices for zfs
Nov 2 2018, 9:47 AM

Nov 1 2018

tsoome committed rS340026: libsa: cstyle cleanup tftp.c.
libsa: cstyle cleanup tftp.c
Nov 1 2018, 10:13 PM
tsoome committed rS339993: libsa: tftp should use calloc.
libsa: tftp should use calloc
Nov 1 2018, 1:30 PM
tsoome committed rS339992: libsa: tftp should not read past file end.
libsa: tftp should not read past file end
Nov 1 2018, 1:12 PM

Oct 31 2018

tsoome committed rS339959: loader: issue edd probe before legacy ah=08 and detect no media.
loader: issue edd probe before legacy ah=08 and detect no media
Oct 31 2018, 4:42 PM
tsoome closed D17667: loader: issue edd probe before legacy ah=08 and detect no media.
Oct 31 2018, 4:42 PM
tsoome added inline comments to D17667: loader: issue edd probe before legacy ah=08 and detect no media.
Oct 31 2018, 3:04 PM
tsoome updated the diff for D17667: loader: issue edd probe before legacy ah=08 and detect no media.

Test the presence of floppy device before attempting to read information
about it. We can get bogus information about non-existing floppy devices.

Oct 31 2018, 11:52 AM

Oct 23 2018

tsoome created D17667: loader: issue edd probe before legacy ah=08 and detect no media.
Oct 23 2018, 3:51 PM
tsoome committed rS339658: loader: biosdisk interface should be able to cope with 4k sectors.
loader: biosdisk interface should be able to cope with 4k sectors
Oct 23 2018, 2:44 PM
tsoome closed D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Oct 23 2018, 2:44 PM
tsoome committed rS339651: libsa: re-send ACK for older data packets in tftp.
libsa: re-send ACK for older data packets in tftp
Oct 23 2018, 1:38 PM
tsoome closed D17087: libsa: re-send ACK for older data packets.
Oct 23 2018, 1:38 PM
tsoome added inline comments to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Oct 23 2018, 6:11 AM

Oct 22 2018

tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.

add sector size checks.

Oct 22 2018, 7:58 PM

Oct 12 2018

tsoome committed rS339334: loader.efi: add poweroff command.
loader.efi: add poweroff command
Oct 12 2018, 4:25 PM
tsoome closed D17535: loader.efi: add poweroff command.
Oct 12 2018, 4:25 PM
tsoome created D17535: loader.efi: add poweroff command.
Oct 12 2018, 3:50 PM

Oct 10 2018

tsoome updated the summary of D17087: libsa: re-send ACK for older data packets.
Oct 10 2018, 10:01 AM

Sep 12 2018

tsoome added a comment to D17131: loader: create bio_alloc and bio_free for bios bounce buffer.
In D17131#365407, @imp wrote:

Generally I like this, but it also looks like there's some drive reset retry logic tossed in as well...

Sep 12 2018, 6:56 PM
tsoome added a reviewer for D17131: loader: create bio_alloc and bio_free for bios bounce buffer: cperciva.
Sep 12 2018, 12:31 PM
tsoome updated the diff for D17131: loader: create bio_alloc and bio_free for bios bounce buffer.

BIO_BUFFER_SIZE is defined in libi386.h

Sep 12 2018, 12:31 PM
tsoome created D17131: loader: create bio_alloc and bio_free for bios bounce buffer.
Sep 12 2018, 12:27 PM

Sep 9 2018

tsoome created D17087: libsa: re-send ACK for older data packets.
Sep 9 2018, 7:07 AM
tsoome committed rS338540: libsa: validate tftp_makereq() after we did reset the read.
libsa: validate tftp_makereq() after we did reset the read
Sep 9 2018, 6:30 AM
tsoome closed D17081: libsa: validate tftp_makereq() after we did reset the read.
Sep 9 2018, 6:30 AM

Sep 8 2018

tsoome created D17081: libsa: validate tftp_makereq() after we did reset the read.
Sep 8 2018, 7:29 PM
tsoome committed rS338535: libsa: memory leak in tftp_open().
libsa: memory leak in tftp_open()
Sep 8 2018, 7:17 PM
tsoome closed D17058: libsa: memory leak in tftp_open().
Sep 8 2018, 7:17 PM

Sep 6 2018

tsoome created D17058: libsa: memory leak in tftp_open().
Sep 6 2018, 12:25 PM
tsoome accepted D17016: Be a little conservative about when to force size optimizations..
Sep 6 2018, 12:24 PM

Sep 2 2018

tsoome accepted D16977: Make -a (to make the entry active) apply to creation of a new boot variable..
Sep 2 2018, 3:22 PM

Aug 22 2018

tsoome committed rS338188: loader: bios loader should allow to chain load a file.
loader: bios loader should allow to chain load a file
Aug 22 2018, 10:05 AM

Aug 19 2018

tsoome added inline comments to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Aug 19 2018, 1:43 PM

Aug 16 2018

tsoome added inline comments to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Aug 16 2018, 8:04 PM
tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.

reverted comment, requested by imp.

Aug 16 2018, 7:00 PM
tsoome added a comment to D11174: loader: biosdisk interface should be able to cope with 4k sectors.

Comments updated.

Aug 16 2018, 6:58 PM
tsoome updated the summary of D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Aug 16 2018, 10:40 AM
tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.

Rebase on recent rev.

Aug 16 2018, 10:34 AM
tsoome committed rS337891: libi386: bd_io_workaround() is to be called for reads only.
libi386: bd_io_workaround() is to be called for reads only
Aug 16 2018, 7:13 AM
tsoome committed rS337890: libi386: small style updates in biosdisk.
libi386: small style updates in biosdisk
Aug 16 2018, 6:51 AM

Aug 15 2018

tsoome committed rS337881: libi386: use BD_RD and BR_WR constants.
libi386: use BD_RD and BR_WR constants
Aug 15 2018, 10:40 PM
tsoome committed rS337878: libi386: remove bd_read() and bd_write() wrappers.
libi386: remove bd_read() and bd_write() wrappers
Aug 15 2018, 10:25 PM
tsoome committed rS337874: libsa: zfs_probe() needs to set spa to NULL.
libsa: zfs_probe() needs to set spa to NULL
Aug 15 2018, 9:38 PM
tsoome committed rS337872: libi386: remove BD_SUPPORT_FRAGS.
libi386: remove BD_SUPPORT_FRAGS
Aug 15 2018, 9:21 PM
tsoome closed D16600: loader: remove BD_SUPPORT_FRAGS.
Aug 15 2018, 9:21 PM
tsoome committed rS337833: cd9660 pointer sign issues and missing __packed attribute.
cd9660 pointer sign issues and missing __packed attribute
Aug 15 2018, 6:42 AM
tsoome closed D16564: cd9660 pointer sign issues and missing __packed attribute.
Aug 15 2018, 6:42 AM
tsoome abandoned D15207: loader: zfs reader must use uint64_t instead of off_t.
Aug 15 2018, 6:36 AM

Aug 7 2018

tsoome committed rS337413: libsa: gzipfs.c converts pointers to integer types with different sign.
libsa: gzipfs.c converts pointers to integer types with different sign
Aug 7 2018, 10:54 AM
tsoome committed rS337412: libsa: dos_checksum() should take unsigned chars.
libsa: dos_checksum() should take unsigned chars
Aug 7 2018, 10:48 AM

Aug 6 2018

tsoome created D16600: loader: remove BD_SUPPORT_FRAGS.
Aug 6 2018, 5:24 AM

Aug 5 2018

tsoome committed rS337356: loader: bd_open() should cleanup from disk_open() error.
loader: bd_open() should cleanup from disk_open() error
Aug 5 2018, 7:17 PM
tsoome committed rS337354: loader: 337353 did miss to rename 2 write instances.
loader: 337353 did miss to rename 2 write instances
Aug 5 2018, 6:24 PM
tsoome committed rS337353: loader: cstyle cleanup for biosdisk.c.
loader: cstyle cleanup for biosdisk.c
Aug 5 2018, 6:20 PM

Aug 4 2018

tsoome committed rS337326: loader: biosdisk.c has leftover geli header..
loader: biosdisk.c has leftover geli header.
Aug 4 2018, 8:04 PM
tsoome accepted D16588: Sanity check BIOS EDD CHS numbers before using them..
Aug 4 2018, 11:12 AM

Aug 3 2018

tsoome committed rS337231: loader.efi: clean up misleading noise from missing block devices.
loader.efi: clean up misleading noise from missing block devices
Aug 3 2018, 7:59 AM
tsoome accepted D16577: Fix boot hang when Mediasonic HD3-U2B-ME USB disk enclsosure is attached.
Aug 3 2018, 4:55 AM

Aug 2 2018

tsoome committed rS337131: loader.efi: efipart_inithandles() failure should not prevent devsw….
loader.efi: efipart_inithandles() failure should not prevent devsw…
Aug 2 2018, 12:43 PM
tsoome created D16564: cd9660 pointer sign issues and missing __packed attribute.
Aug 2 2018, 10:16 AM
tsoome committed rS337065: libsa: dereferencing type-punned pointer in cd9660.
libsa: dereferencing type-punned pointer in cd9660
Aug 2 2018, 6:22 AM

Aug 1 2018

tsoome committed rS337039: libsa: assignment to char * from u_char *.
libsa: assignment to char * from u_char *
Aug 1 2018, 12:14 PM
tsoome committed rS337038: libsa: bootp is using pointers with different sign.
libsa: bootp is using pointers with different sign
Aug 1 2018, 12:07 PM
tsoome committed rS337037: libsa: pointer differs in signedness.
libsa: pointer differs in signedness
Aug 1 2018, 11:41 AM
tsoome accepted D12698: Add EFI KMS and keybuf integration.
Aug 1 2018, 11:16 AM

Jul 23 2018

tsoome accepted D16403: Finalize the boot manager protocol support for next-stage boot loading..

Seems OK

Jul 23 2018, 8:31 PM

Jul 19 2018

tsoome added a comment to D16322: If rootdev is set, use it as currdev..
In D16322#346807, @ish_amail.plala.or.jp wrote:

Sorry, although this patch is good working from rEFInd, it is not working for loader prompt.
While showing boot menu, press '3' and go to loader prompt.
OK set rootdev=disk0pX
OK boot
The OS is booted from currdev, not from rootdev.

Jul 19 2018, 7:10 AM