In D15207#334555, @imp wrote:

I don't like this change at all. There's no practical difference, and this diverges us from the normal unix APIs.

gptboot.c was missing the switch to uint64_t

In D12732#331837, @eric_metricspace.net wrote:

Rebase from master and tried on real hardware

In D15207#322069, @avg wrote:

In D15207#322067, @tsoome wrote:

In D15207#322036, @avg wrote:

I think that on FreeBSD off_t is always 64 bit.

Yes, thats correct, it is 8 bytes (did verify). However, there is still issue of sign. Of course even with signed case we have quite a large max value there...

I think that the difference between 2⁶⁴ and 2⁶³ is negligible for all practical purposes.

In D15207#322036, @avg wrote:

I think that on FreeBSD off_t is always 64 bit.

removed parens.

remove excess parens

Still looking quite nice, but there is a bit of competition still, have you checked on https://reviews.freebsd.org/D13784 and how much those 2 updates are conflicting and in which order should we implement them to cause the least amount of issues on integration?

LGTM

In D14350#301042, @kevans wrote:

For what it's worth, I would almost like to do something more like this: https://people.freebsd.org/~kevans/stand-ip.diff

It's a lot more invasive, but it gets rid sendrecv_tftp and consolidates MINTMO/MAXTMO timeout logic into one spot that everything honors.

shoot:)

nice catch.

As an note, please install scripts into /boot/lua - so we wont pollute the whole /boot.

Im sure there is still much to do, but go for it.

use proper powerof2

Update to check BlockSize

Seems good.

use macro for constant.

Add more comments and reorder some checks

In D13026#272423, @imp wrote:

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

Update to revision 325851.

efipart_hdd() was quite broken.