tsoome (Toomas Soome)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2015, 11:12 PM (67 w, 6 d)

Recent Activity

Yesterday

tsoome committed rS316287: Remove OLD_NFSV2 from loader and libstand.
Remove OLD_NFSV2 from loader and libstand
Thu, Mar 30, 7:32 PM
tsoome closed D10206: Remove OLD_NFSV2 from loader and libstand by committing rS316287: Remove OLD_NFSV2 from loader and libstand.
Thu, Mar 30, 7:32 PM
tsoome updated the diff for D10206: Remove OLD_NFSV2 from loader and libstand.

I think the NQNFS comment is also not actual any more

Thu, Mar 30, 7:18 PM
tsoome committed rS316282: boot1.efi: can't boot from ZFS on 4kn HDD.
boot1.efi: can't boot from ZFS on 4kn HDD
Thu, Mar 30, 5:24 PM
tsoome created D10206: Remove OLD_NFSV2 from loader and libstand.
Thu, Mar 30, 5:04 PM
tsoome closed D10198: loader: simplify efi_zfs_probe and avoid double probing for zfs. by committing rS316280: loader: simplify efi_zfs_probe and avoid double probing for zfs..
Thu, Mar 30, 4:33 PM
tsoome committed rS316280: loader: simplify efi_zfs_probe and avoid double probing for zfs..
loader: simplify efi_zfs_probe and avoid double probing for zfs.
Thu, Mar 30, 4:33 PM
tsoome committed rS316279: loader: efipart should check disk size from partition table.
loader: efipart should check disk size from partition table
Thu, Mar 30, 4:23 PM
tsoome closed D10197: loader: efipart should check disk size from partition table by committing rS316279: loader: efipart should check disk size from partition table.
Thu, Mar 30, 4:23 PM
tsoome added a comment to D10203: loader: zfs reader should check all labels.

even just reading the 2nd label is a big improvement. Thank you.

Have you tested this by say clobbering the first label?

Thu, Mar 30, 4:09 PM
tsoome added a comment to D10198: loader: simplify efi_zfs_probe and avoid double probing for zfs..

Does this change which pool might be booted from if you have more than 1 pool?

How have you tested this change?

Thu, Mar 30, 3:58 PM
tsoome created D10203: loader: zfs reader should check all labels.
Thu, Mar 30, 3:39 PM
tsoome created D10198: loader: simplify efi_zfs_probe and avoid double probing for zfs..
Thu, Mar 30, 12:24 PM
tsoome created D10197: loader: efipart should check disk size from partition table.
Thu, Mar 30, 11:38 AM

Wed, Mar 29

tsoome created D10187: loader: want mechanism to avoid RA with bcache.
Wed, Mar 29, 6:11 PM
tsoome created D10180: loader: part.c cstyle cleanup.
Wed, Mar 29, 10:34 AM

Tue, Mar 28

tsoome closed D10066: loader: ls command should display file types properly by committing rS316112: loader: ls command should display file types properly.
Tue, Mar 28, 9:50 PM
tsoome committed rS316112: loader: ls command should display file types properly.
loader: ls command should display file types properly
Tue, Mar 28, 9:50 PM
tsoome committed rS316111: loader: move bios getsecs into time.c.
loader: move bios getsecs into time.c
Tue, Mar 28, 9:47 PM
tsoome closed D10058: loader: move bios getsecs into time.c by committing rS316111: loader: move bios getsecs into time.c.
Tue, Mar 28, 9:47 PM
tsoome updated the diff for D10066: loader: ls command should display file types properly.

svn update.

Tue, Mar 28, 9:27 PM

Tue, Mar 21

tsoome updated the diff for D10066: loader: ls command should display file types properly.

still missed one space before tab.

Tue, Mar 21, 6:59 AM
tsoome updated the diff for D10066: loader: ls command should display file types properly.

And some more cstyle fixes.

Tue, Mar 21, 6:56 AM
tsoome updated the diff for D10066: loader: ls command should display file types properly.

missed one more malloc check, and small cstyle fix - missing space after
return keyword.

Tue, Mar 21, 6:34 AM

Mon, Mar 20

tsoome committed rS315653: loader: verify the value from dhcp.interface-mtu and use snprintf to set mtu.
loader: verify the value from dhcp.interface-mtu and use snprintf to set mtu
Mon, Mar 20, 10:20 PM
tsoome closed D8492: Verify the value from dhcp.interface-mtu and use snprintf to set mtu. by committing rS315653: loader: verify the value from dhcp.interface-mtu and use snprintf to set mtu.
Mon, Mar 20, 10:20 PM
tsoome added a comment to D10066: loader: ls command should display file types properly.

The review at illumos side: https://www.illumos.org/rb/r/408/

Mon, Mar 20, 10:11 PM
tsoome added inline comments to D10066: loader: ls command should display file types properly.
Mon, Mar 20, 8:41 PM
tsoome updated the diff for D10066: loader: ls command should display file types properly.

malloc can fail: so the stat size and mode should be zeroed before.
stat can fail: set mode = 0
and free does not need the check, but the comment is helpful.

Mon, Mar 20, 8:39 PM
tsoome updated the test plan for D10066: loader: ls command should display file types properly.
Mon, Mar 20, 8:19 PM
tsoome added a comment to D8492: Verify the value from dhcp.interface-mtu and use snprintf to set mtu..

This work is an result of review in https://www.illumos.org/rb/r/259/

Mon, Mar 20, 8:11 PM
tsoome created D10066: loader: ls command should display file types properly.
Mon, Mar 20, 8:09 PM
tsoome updated the diff for D8492: Verify the value from dhcp.interface-mtu and use snprintf to set mtu..

Fixed the dhcp.interface-mtu check.

Mon, Mar 20, 7:18 PM
tsoome committed rS315648: libstand: verify value provided by nfs.read_size.
libstand: verify value provided by nfs.read_size
Mon, Mar 20, 7:16 PM
tsoome closed D8491: libstand: verify value provided by nfs.read_size by committing rS315648: libstand: verify value provided by nfs.read_size.
Mon, Mar 20, 7:16 PM
tsoome committed rS315646: loader: pxe.h constants have wrong values.
loader: pxe.h constants have wrong values
Mon, Mar 20, 6:15 PM
tsoome closed D10056: loader: pxe.h constants have wrong values by committing rS315646: loader: pxe.h constants have wrong values.
Mon, Mar 20, 6:15 PM
tsoome committed rS315645: loader: disk_cleanup was left in userboot_disk.c.
loader: disk_cleanup was left in userboot_disk.c
Mon, Mar 20, 6:03 PM
tsoome closed D10060: loader: disk_cleanup was left in userboot_disk.c by committing rS315645: loader: disk_cleanup was left in userboot_disk.c.
Mon, Mar 20, 6:03 PM
tsoome updated the summary of D10056: loader: pxe.h constants have wrong values.
Mon, Mar 20, 5:52 PM
tsoome updated the diff for D10058: loader: move bios getsecs into time.c.

gcc did complain about missing prototype for getsecs(), including net.h
alone is not enough, so I just did add local prototype. clang does not seem
to care...

Mon, Mar 20, 10:04 AM
tsoome created D10060: loader: disk_cleanup was left in userboot_disk.c.
Mon, Mar 20, 8:35 AM

Sun, Mar 19

tsoome created D10058: loader: move bios getsecs into time.c.
Sun, Mar 19, 10:55 PM
tsoome added inline comments to D9547: libstand/dosfs: cache FAT32 in 128 Kb blocks to save loader memory.
Sun, Mar 19, 9:30 PM
tsoome created D10056: loader: pxe.h constants have wrong values.
Sun, Mar 19, 8:08 PM

Fri, Mar 17

tsoome added a comment to D9547: libstand/dosfs: cache FAT32 in 128 Kb blocks to save loader memory.

Ah, right, there is an problem now with viewing the changes - if you just upload the diff, there is not enough context for phabricator to work with. arcanist does post automatically, diff needs some command line option to provide the whole file, I can not recall it off hand..

Fri, Mar 17, 7:26 PM
tsoome added a comment to D9547: libstand/dosfs: cache FAT32 in 128 Kb blocks to save loader memory.

Actually hold the horses a bit, I have incoming comments from illumos review and we can get this even better:)

Fri, Mar 17, 3:22 PM

Thu, Mar 16

tsoome accepted D9547: libstand/dosfs: cache FAT32 in 128 Kb blocks to save loader memory.

seems ok for me:)

Thu, Mar 16, 10:41 PM
tsoome added inline comments to D9547: libstand/dosfs: cache FAT32 in 128 Kb blocks to save loader memory.
Thu, Mar 16, 10:25 PM
tsoome closed D10032: loader: biosdisk should report IO error from INT13 by committing rS315427: loader: biosdisk should report IO error from INT13.
Thu, Mar 16, 9:34 PM
tsoome committed rS315427: loader: biosdisk should report IO error from INT13.
loader: biosdisk should report IO error from INT13
Thu, Mar 16, 9:34 PM
tsoome added a comment to D9547: libstand/dosfs: cache FAT32 in 128 Kb blocks to save loader memory.

I'm sorry it took so long till I got to this one, some cstyle issues need attention.

Thu, Mar 16, 6:53 PM
tsoome created D10032: loader: biosdisk should report IO error from INT13.
Thu, Mar 16, 5:26 PM
tsoome committed rS315408: loader: remove open_disk cache.
loader: remove open_disk cache
Thu, Mar 16, 12:05 PM
tsoome closed D9757: loader: remove open_disk cache by committing rS315408: loader: remove open_disk cache.
Thu, Mar 16, 12:05 PM
tsoome added inline comments to D9757: loader: remove open_disk cache.
Thu, Mar 16, 11:50 AM
tsoome updated the diff for D9757: loader: remove open_disk cache.

whitespace cleanup

Thu, Mar 16, 11:49 AM

Wed, Mar 15

tsoome added inline comments to D8491: libstand: verify value provided by nfs.read_size.
Wed, Mar 15, 9:41 PM
tsoome added inline comments to D8491: libstand: verify value provided by nfs.read_size.
Wed, Mar 15, 9:21 PM
tsoome updated the diff for D8491: libstand: verify value provided by nfs.read_size.

Typo in errno name and casting to int.

Wed, Mar 15, 9:16 PM
tsoome updated the diff for D9757: loader: remove open_disk cache.

ptable_print needs to open the nested partition with disk_open,
as the state is not shared any more.

Wed, Mar 15, 8:37 PM
tsoome closed D9870: PR216964: boot1.efi: can't boot from ZFS on 4kn HDD by committing rS315326: boot1.efi: can't boot from ZFS on 4kn HDD.
Wed, Mar 15, 7:48 PM
tsoome committed rS315326: boot1.efi: can't boot from ZFS on 4kn HDD.
boot1.efi: can't boot from ZFS on 4kn HDD
Wed, Mar 15, 7:48 PM
tsoome added a comment to D9870: PR216964: boot1.efi: can't boot from ZFS on 4kn HDD.

Please let me know if you need another round of testing done to commit this one

Wed, Mar 15, 4:32 PM

Sat, Mar 4

tsoome updated the diff for D9870: PR216964: boot1.efi: can't boot from ZFS on 4kn HDD.

Rewrote to use single sector sized bounce buffer. Done for safety reasons,
so we wont attempt to allocate some large buffers due to chaining errors.

Sat, Mar 4, 7:48 PM

Fri, Mar 3

tsoome updated the diff for D9870: PR216964: boot1.efi: can't boot from ZFS on 4kn HDD.

typo fixed.

Fri, Mar 3, 6:07 PM
tsoome updated the diff for D9870: PR216964: boot1.efi: can't boot from ZFS on 4kn HDD.

Update suggested by rpokala.

Fri, Mar 3, 6:05 PM

Thu, Mar 2

tsoome retitled D9870: PR216964: boot1.efi: can't boot from ZFS on 4kn HDD from to PR216964: boot1.efi: can't boot from ZFS on 4kn HDD.
Thu, Mar 2, 7:45 PM

Wed, Mar 1

tsoome committed rS314504: loader: r314112 did introduce dereference freed pointer entry.
loader: r314112 did introduce dereference freed pointer entry
Wed, Mar 1, 7:02 PM
tsoome closed D9846: loader: r314112 did introduce dereference freed pointer entry by committing rS314504: loader: r314112 did introduce dereference freed pointer entry.
Wed, Mar 1, 7:02 PM
tsoome retitled D9846: loader: r314112 did introduce dereference freed pointer entry from to loader: r314112 did introduce dereference freed pointer entry.
Wed, Mar 1, 5:14 PM

Feb 24 2017

tsoome accepted D9782: Remove control+r handling from geliboot's pwgets().

LGTM

Feb 24 2017, 8:20 AM

Feb 22 2017

tsoome retitled D9757: loader: remove open_disk cache from to loader: remove open_disk cache.
Feb 22 2017, 10:41 PM
tsoome closed D9706: loader: update symlink support in zfs reader by committing rS314112: loader: update symlink support in zfs reader.
Feb 22 2017, 10:00 PM
tsoome committed rS314112: loader: update symlink support in zfs reader.
loader: update symlink support in zfs reader
Feb 22 2017, 10:00 PM
tsoome updated the diff for D9706: loader: update symlink support in zfs reader.

svn update; and clean up the inverted if statement.

Feb 22 2017, 12:42 PM
tsoome updated the diff for D9706: loader: update symlink support in zfs reader.

Fixes suggested by smh.

Feb 22 2017, 12:22 PM
tsoome added inline comments to D9706: loader: update symlink support in zfs reader.
Feb 22 2017, 12:21 PM

Feb 21 2017

tsoome retitled D9706: loader: update symlink support in zfs reader from to loader: update symlink support in zfs reader.
Feb 21 2017, 8:27 PM

Feb 20 2017

tsoome added a comment to D9687: Add string16 API.
In D9687#200246, @imp wrote:

All the string functions suffer from the same problem we have with the original string functions you replaced: they don't properly implement character conversions. Please see the efivar stuff I did in -current to see what you need to do there. And you should put the functions I wrote there into libstand. While these functions work well enough for ASCIIish things, they fail for anything more complex. If we're going to rework things, let's do it correctly and reuse what was done correctly for efivar (who, to be fair, stole and reworked the code from Marcel's earlier efi on ia64 work).

Feb 20 2017, 4:59 PM

Feb 16 2017

tsoome added inline comments to D9430: Use -Os when compiling all bootloaders, not just some.
Feb 16 2017, 6:55 AM

Feb 13 2017

tsoome closed D9562: loader: cstyle fixes and DIOCGMEDIASIZE should use uint64_t by committing rS313710: loader: cstyle fixes and DIOCGMEDIASIZE should use uint64_t.
Feb 13 2017, 9:34 PM
tsoome committed rS313710: loader: cstyle fixes and DIOCGMEDIASIZE should use uint64_t.
loader: cstyle fixes and DIOCGMEDIASIZE should use uint64_t
Feb 13 2017, 9:34 PM
tsoome retitled D9562: loader: cstyle fixes and DIOCGMEDIASIZE should use uint64_t from to loader: cstyle fixes and DIOCGMEDIASIZE should use uint64_t.
Feb 13 2017, 6:52 AM

Feb 11 2017

tsoome closed D9520: loader: implement MEDIA_FILEPATH_DP support in efipart by committing rS313645: loader: implement MEDIA_FILEPATH_DP support in efipart.
Feb 11 2017, 3:26 PM
tsoome committed rS313645: loader: implement MEDIA_FILEPATH_DP support in efipart.
loader: implement MEDIA_FILEPATH_DP support in efipart
Feb 11 2017, 3:26 PM

Feb 10 2017

tsoome added a comment to D9520: loader: implement MEDIA_FILEPATH_DP support in efipart.
In D9520#196965, @gonzo wrote:

I tested it on rpi3, it works with crochet-generated image

OK  lsdev
disk devices:
    disk0:    15564801 X 512 blocks (removable)
      disk0s1: DOS/Windows
      disk0s2: FreeBSD
        disk0s2a: FreeBSD UFS
net devices:
    net0:
Feb 10 2017, 7:36 PM
tsoome added a comment to D9520: loader: implement MEDIA_FILEPATH_DP support in efipart.

Once you get someone to verify this works on an ARM device, approved.

Feb 10 2017, 4:49 PM
tsoome retitled D9520: loader: implement MEDIA_FILEPATH_DP support in efipart from to loader: implement MEDIA_FILEPATH_DP support in efipart.
Feb 10 2017, 10:23 AM

Feb 8 2017

tsoome closed D9496: loader: possible NULL pointer dereference in bcache.c by committing rS313451: loader: possible NULL pointer dereference in bcache.c.
Feb 8 2017, 6:33 PM
tsoome committed rS313451: loader: possible NULL pointer dereference in bcache.c.
loader: possible NULL pointer dereference in bcache.c
Feb 8 2017, 6:33 PM
tsoome retitled D9496: loader: possible NULL pointer dereference in bcache.c from to loader: possible NULL pointer dereference in bcache.c.
Feb 8 2017, 5:25 PM
tsoome committed rS313442: loader: possible NULL pointer dereference in efipart.c.
loader: possible NULL pointer dereference in efipart.c
Feb 8 2017, 3:52 PM
tsoome closed D9490: loader: possible NULL pointer dereference in efipart.c by committing rS313442: loader: possible NULL pointer dereference in efipart.c.
Feb 8 2017, 3:52 PM
tsoome retitled D9490: loader: possible NULL pointer dereference in efipart.c from to loader: possible NULL pointer dereference in efipart.c.
Feb 8 2017, 2:05 PM

Feb 7 2017

tsoome added a comment to D5992: Add chain loader support for loader.

Can you add some instructions or a man page explaining how to use it? (and how one would test it)

Feb 7 2017, 8:40 PM

Feb 6 2017

tsoome committed rS313355: MFC r309369,310850,310853:.
MFC r309369,310850,310853:
Feb 6 2017, 10:03 PM
tsoome committed rS313353: MFC r310845: boot2 will deadlock if extended keys are used on text input.
MFC r310845: boot2 will deadlock if extended keys are used on text input
Feb 6 2017, 8:57 PM
tsoome committed rS313349: loader: disk io should not use alloca().
loader: disk io should not use alloca()
Feb 6 2017, 6:44 PM
tsoome closed D9455: loader: disk io should not use alloca() by committing rS313349: loader: disk io should not use alloca().
Feb 6 2017, 6:44 PM