Page MenuHomeFreeBSD

tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (254 w, 6 d)

Recent Activity

Thu, Oct 22

tsoome committed rS366951: loader: revert r342161 and r342151.
loader: revert r342161 and r342151
Thu, Oct 22, 8:02 PM

Wed, Oct 21

tsoome accepted D26880: Restore identification of VDEVs using non-native block size..

I guess the openzfs PR will add more, but so far, so good:)

Wed, Oct 21, 5:10 AM

Sat, Oct 17

tsoome added inline comments to D26829: Mute efi/loader.
Sat, Oct 17, 3:23 PM · ARM

Mon, Oct 12

tsoome committed rS366631: loader: edd_device_path_v3 is too small.
loader: edd_device_path_v3 is too small
Mon, Oct 12, 9:35 AM

Thu, Oct 8

tsoome accepted D26687: Add a routine to dump the boot metadata.
Thu, Oct 8, 4:39 AM

Wed, Oct 7

tsoome accepted D26710: bhyveload(8): Implement loader_callbacks::diskwrite.

I assume, bhyveload does open disk images RW.

Wed, Oct 7, 7:57 PM

Tue, Oct 6

tsoome accepted D26687: Add a routine to dump the boot metadata.

LGTM.

Tue, Oct 6, 2:16 PM
tsoome added inline comments to D26687: Add a routine to dump the boot metadata.
Tue, Oct 6, 1:52 PM

Sep 28 2020

tsoome accepted D26574: For mulitcons boot, report it and which console is primary.
Sep 28 2020, 9:22 AM
tsoome accepted D26572: Fix video on PCI heuristic.
Sep 28 2020, 5:53 AM

Sep 25 2020

tsoome accepted D26543: Adjustments to includes for openzfs.

I think printf is ok to have.

Sep 25 2020, 8:00 PM

Sep 23 2020

tsoome added a comment to D25512: WIP bootnext: Next Generation.

If src.conf contains
WITHOUT_LOADER_ZFS=true
WITHOUT_ZFS=true

This commit (r365938) will break buildworld.

  • all_subdir_stand ---

/usr/src/stand/efi/loader_4th/../loader/main.c:39:10: fatal error: 'sys/zfs_bootenv.h' file not found
#include <sys/zfs_bootenv.h>

^~~~~~~~~~~~~~~~~~~

My target is ARM with GENERIC conf and src.conf as above.
Sorry if it has already been reported.

Sep 23 2020, 7:16 PM
tsoome committed rS366087: loader: fix non-zfs build.
loader: fix non-zfs build
Sep 23 2020, 7:15 PM
tsoome committed rS366066: loader: zfs_probe_dev should pick first matching zfs pool.
loader: zfs_probe_dev should pick first matching zfs pool
Sep 23 2020, 8:22 AM

Sep 21 2020

tsoome closed D25512: WIP bootnext: Next Generation.
Sep 21 2020, 9:02 AM
tsoome committed rS365938: loader: zfs should support bootonce an nextboot.
loader: zfs should support bootonce an nextboot
Sep 21 2020, 9:01 AM

Sep 19 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

update manuals.

Sep 19 2020, 10:12 AM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

rebase after openzfs import

Sep 19 2020, 8:21 AM

Sep 14 2020

tsoome accepted D26364: stand/ficl 64-bit compatibility.
Sep 14 2020, 4:42 AM · PowerPC

Sep 13 2020

tsoome added inline comments to D26364: stand/ficl 64-bit compatibility.
Sep 13 2020, 7:29 PM · PowerPC
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

continuation should be indented 4 spaces

Sep 13 2020, 2:49 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

add lzbe_flags_t to notify if lzbe_set_boot_device() should add data to
current bootenv, or create new bootenv.

Sep 13 2020, 12:08 PM

Sep 9 2020

tsoome added inline comments to D26364: stand/ficl 64-bit compatibility.
Sep 9 2020, 9:18 PM · PowerPC
tsoome added inline comments to D26364: stand/ficl 64-bit compatibility.
Sep 9 2020, 9:09 PM · PowerPC

Sep 8 2020

tsoome accepted D21281: Work around a bug in the EFI HTTP driver.
Sep 8 2020, 5:13 AM

Aug 31 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

keep if statement simple.

Aug 31 2020, 7:48 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

defaults/loader.conf should not have nextboot_enable
fix lua
update forth nextboot

Aug 31 2020, 7:32 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

add nextboot bits.

Aug 31 2020, 3:56 PM

Aug 27 2020

tsoome added inline comments to D26207: Add zfs zstd support to loader.
Aug 27 2020, 6:26 AM

Aug 26 2020

tsoome committed rS364827: libsa: only skein_block.c is using SKEIN_LOOP.
libsa: only skein_block.c is using SKEIN_LOOP
Aug 26 2020, 5:52 PM
tsoome committed rS364818: efibootmgr: wrong check for opts.order.
efibootmgr: wrong check for opts.order
Aug 26 2020, 2:02 PM
tsoome committed rS364806: remove pragma ident lines.
remove pragma ident lines
Aug 26 2020, 7:29 AM
tsoome committed rS364805: remove left over empty directory.
remove left over empty directory
Aug 26 2020, 7:00 AM

Aug 21 2020

tsoome accepted D26144: The condition can never be true.

The same fix is applied in illumos (detected by smatch).

Aug 21 2020, 4:55 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

add nvstore framework and command

Aug 21 2020, 2:41 PM

Aug 19 2020

tsoome committed rS364408: libsa: remove leftover whitespace.
libsa: remove leftover whitespace
Aug 19 2020, 8:41 PM
tsoome committed rS364398: libsa: make env_discard() public.
libsa: make env_discard() public
Aug 19 2020, 3:27 PM
tsoome committed rS364397: libsa: cstyle cleanup for environment.c.
libsa: cstyle cleanup for environment.c
Aug 19 2020, 3:20 PM

Aug 6 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

move libzfsbootenv to cddl tree

Aug 6 2020, 8:41 PM

Aug 5 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

move libzfsbootenv to cddl tree.

Aug 5 2020, 9:16 PM
tsoome added inline comments to D25512: WIP bootnext: Next Generation.
Aug 5 2020, 2:57 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Rebase on OpenZFS update:
Add support for boot environment data to be stored in the label

Aug 5 2020, 2:51 PM
tsoome committed rS363911: MFOpenZFS: Add support for boot environment data to be stored in the label.
MFOpenZFS: Add support for boot environment data to be stored in the label
Aug 5 2020, 2:32 PM
tsoome committed rS363910: zfs_keys_nextboot array is missing ZPOOL_CONFIG_POOL_GUID and ZPOOL_CONFIG_GUID.
zfs_keys_nextboot array is missing ZPOOL_CONFIG_POOL_GUID and ZPOOL_CONFIG_GUID
Aug 5 2020, 2:09 PM

Aug 3 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Fix zfs_ioc_nextboot()

Aug 3 2020, 3:07 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

libzfsbootenv should have major version 1

Aug 3 2020, 1:13 PM

Aug 2 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

make bootonce BE permanenty active, if zfs_bootonce_activate is YES.

Aug 2 2020, 1:08 PM

Aug 1 2020

tsoome accepted D25907: Document automatic handling of font height for BDF files.
Aug 1 2020, 4:28 PM
tsoome added inline comments to D25907: Document automatic handling of font height for BDF files.
Aug 1 2020, 4:56 AM

Jul 26 2020

tsoome committed rS363558: MFC 363241:.
MFC 363241:
Jul 26 2020, 11:01 AM
tsoome committed rS363557: MFC 363241:.
MFC 363241:
Jul 26 2020, 10:59 AM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Missed few bits..

Jul 26 2020, 8:36 AM

Jul 25 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

whitespace cleanup

Jul 25 2020, 1:40 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Add zfs_bootenv.h with key values for nvlist pairs.

Jul 25 2020, 1:22 PM

Jul 23 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

userboot should also set zfs-bootonce environment variable

Jul 23 2020, 7:03 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

restore version field in bootenv. It does help us to keep old stage2
not to freak on nvlist stream data.

Jul 23 2020, 5:44 PM

Jul 22 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Update zfsbootcfg.8

Jul 22 2020, 11:57 AM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Updates as requested by kevans.

Jul 22 2020, 10:52 AM
tsoome added inline comments to D25512: WIP bootnext: Next Generation.
Jul 22 2020, 10:51 AM

Jul 21 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

zfsbootcfg should output the bootonce value when run without any
arguments.

Jul 21 2020, 11:54 AM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Add zfs_get_bootenv() and zfs_set_bootenv()

Jul 21 2020, 11:23 AM

Jul 19 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

testing to record bootonce command as zfs-bootonce in loader env.

Jul 19 2020, 4:15 PM
tsoome committed rS363318: loader: cstyle cleanup.
loader: cstyle cleanup
Jul 19 2020, 6:59 AM

Jul 18 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

update bectl and libbe.

Jul 18 2020, 7:50 AM

Jul 16 2020

tsoome committed rS363241: efibootmgr: typo in long option name.
efibootmgr: typo in long option name
Jul 16 2020, 10:21 AM

Jul 15 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

previous push was from wrong vm.

Jul 15 2020, 9:20 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Instead of doing read test on bootenv area, read vdev_phys.

Jul 15 2020, 8:04 PM

Jul 14 2020

tsoome accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 14 2020, 2:43 PM

Jul 11 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

include libzfsbootenv.h

Jul 11 2020, 8:13 PM
tsoome accepted D25629: Loader: explain currdev syntax.
Jul 11 2020, 7:54 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

add libzfsbootenv and update zfsbootcfg to use it

Jul 11 2020, 5:59 PM
tsoome committed rS363090: loader: implement GELI writes.
loader: implement GELI writes
Jul 11 2020, 6:52 AM
tsoome closed D25605: loader: GELI writes are not yet implemented.
Jul 11 2020, 6:52 AM

Jul 10 2020

tsoome accepted D25608: First cut at a loader.conf.d support.
Jul 10 2020, 7:38 AM

Jul 9 2020

tsoome updated the diff for D25605: loader: GELI writes are not yet implemented.

Hopefully better comment.

Jul 9 2020, 10:34 PM
tsoome updated the summary of D25605: loader: GELI writes are not yet implemented.
Jul 9 2020, 10:32 PM
tsoome requested review of D25605: loader: GELI writes are not yet implemented.
Jul 9 2020, 9:12 PM
tsoome committed rS363042: loader: setting vdev size based on label asize is not working.
loader: setting vdev size based on label asize is not working
Jul 9 2020, 1:19 PM
tsoome closed D25586: loader: setting vdev size based on label asize is not working.
Jul 9 2020, 1:19 PM

Jul 8 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

We can only write to leaf (disk) devices.
Return any error from write.

Jul 8 2020, 12:55 PM

Jul 7 2020

tsoome updated the diff for D25586: loader: setting vdev size based on label asize is not working.

set asize to 0 on error

Jul 7 2020, 10:50 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

verify read before attempting to write label.

Jul 7 2020, 9:25 PM
tsoome requested review of D25586: loader: setting vdev size based on label asize is not working.
Jul 7 2020, 6:30 PM
tsoome committed rS362989: loader: geli_dev_ioctl does return huge mediasize.
loader: geli_dev_ioctl does return huge mediasize
Jul 7 2020, 12:25 PM

Jul 6 2020

tsoome added a reviewer for D25512: WIP bootnext: Next Generation: glebius.
Jul 6 2020, 5:17 PM

Jul 5 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

replace sprintf by snprintf

Jul 5 2020, 5:42 PM

Jul 4 2020

tsoome updated the diff for D25512: WIP bootnext: Next Generation.

clean signed vs unsigned

Jul 4 2020, 12:10 PM

Jul 2 2020

tsoome committed rS362884: loader: zfs reader does not need BOOT2 bits.
loader: zfs reader does not need BOOT2 bits
Jul 2 2020, 7:16 AM
tsoome committed rS362883: loader: potential memory leak and check return values.
loader: potential memory leak and check return values
Jul 2 2020, 7:04 AM

Jul 1 2020

tsoome accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 1 2020, 8:43 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Read and write all 4 label instances.

Jul 1 2020, 8:32 AM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

Mistake on dates

Jul 1 2020, 7:30 AM

Jun 30 2020

tsoome updated the summary of D25512: WIP bootnext: Next Generation.
Jun 30 2020, 10:11 PM
tsoome updated the diff for D25512: WIP bootnext: Next Generation.

boot1 change was committed.

Jun 30 2020, 9:52 PM
tsoome committed rS362812: boot1.efi: use malloc family from libsa.
boot1.efi: use malloc family from libsa
Jun 30 2020, 9:49 PM
tsoome added a comment to D25512: WIP bootnext: Next Generation.

@tsoome Is this purely refactoring or some additional features/improvements as the goal.

Jun 30 2020, 5:58 PM
tsoome added inline comments to D25512: WIP bootnext: Next Generation.
Jun 30 2020, 10:10 AM

Jun 29 2020

tsoome requested review of D25512: WIP bootnext: Next Generation.
Jun 29 2020, 10:23 PM

Jun 26 2020

tsoome committed rS362663: loader: can not read zfs pool with slog removed.
loader: can not read zfs pool with slog removed
Jun 26 2020, 9:21 PM

Jun 23 2020

tsoome committed rS362531: MFOpenZFS: Add basic zfs ioc input nvpair validation.
MFOpenZFS: Add basic zfs ioc input nvpair validation
Jun 23 2020, 6:43 AM