removed parens.

remove excess parens

Still looking quite nice, but there is a bit of competition still, have you checked on https://reviews.freebsd.org/D13784 and how much those 2 updates are conflicting and in which order should we implement them to cause the least amount of issues on integration?

LGTM

In D14350#301042, @kevans wrote:

For what it's worth, I would almost like to do something more like this: https://people.freebsd.org/~kevans/stand-ip.diff

It's a lot more invasive, but it gets rid sendrecv_tftp and consolidates MINTMO/MAXTMO timeout logic into one spot that everything honors.

shoot:)

nice catch.

As an note, please install scripts into /boot/lua - so we wont pollute the whole /boot.

Im sure there is still much to do, but go for it.

use proper powerof2

Update to check BlockSize

Seems good.

use macro for constant.

Add more comments and reorder some checks

In D13026#272423, @imp wrote:

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

Update to revision 325851.

efipart_hdd() was quite broken.

Validate the return value from lseek()

offset is better name.

Reword the comment.

This patch will need more work and cleanup, especially printing information about the devices.

In D10447#262729, @imp wrote:

I wonder why we even have boot1 anymore after these changes.... It's turning into a mini loader.efi. I wonder why we don't just kill it entirely. We don't need boot volume selection (that's supposed to be the EFI boot BIOS's job). We seem to duplicate a lot of code just to load /boot/loader.efi off of UFS or ZFS partitions. However, we could just use loader.efi directly (though some of the root detection code would need to be tweaked). boot1 used to be small, limited and basically unchanging (so updates weren't needed). Now that boot1.efi has hitched its wagon to loader.efi, I wonder why have an extra boot stage that seems to be good at messing up it's partition guessing...

I'm going to go ahead and commit this (after adding back the bits I keep saying were bogusly deleted), but I'm thinking strongly that we consider just moving to loader.efi installed into \efi\freebsd\loader.efi starting in FreeBSD 12 since we'll be able to point efibootmgr at it by then.