tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (102 w, 2 h)

Recent Activity

Wed, Nov 22

tsoome committed rS326090: net_parse_rootpath() has no parameters.
net_parse_rootpath() has no parameters
Wed, Nov 22, 10:04 AM
tsoome closed D13026: loader.efi: efipart does not recognize partitionless disks.
Wed, Nov 22, 8:48 AM
tsoome committed rS326089: loader.efi: efipart does not recognize partitionless disks.
loader.efi: efipart does not recognize partitionless disks
Wed, Nov 22, 8:48 AM

Sat, Nov 18

tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

Add more comments and reorder some checks

Sat, Nov 18, 10:57 AM

Wed, Nov 15

tsoome created D13109: regex/engine.c: error: variable 'dp' set but not used.
Wed, Nov 15, 9:29 PM
tsoome added a comment to D13026: loader.efi: efipart does not recognize partitionless disks.
In D13026#272423, @imp wrote:

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

Wed, Nov 15, 3:13 PM
tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

Update to revision 325851.

Wed, Nov 15, 1:12 PM

Fri, Nov 10

tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

efipart_hdd() was quite broken.

Fri, Nov 10, 5:05 PM
tsoome created D13026: loader.efi: efipart does not recognize partitionless disks.
Fri, Nov 10, 12:39 PM
tsoome committed rS325641: loader.efi: efi_devpath_is_prefix should return bool.
loader.efi: efi_devpath_is_prefix should return bool
Fri, Nov 10, 12:08 PM
tsoome accepted D12924: Remove mailaddr(7).
Fri, Nov 10, 8:19 AM

Thu, Nov 2

tsoome committed rS325310: zfs.c:vdev_read() needs to be careful about large sectors.
zfs.c:vdev_read() needs to be careful about large sectors
Thu, Nov 2, 8:47 AM
tsoome closed D12850: zfs.c:vdev_read() needs to be careful about large sectors.
Thu, Nov 2, 8:47 AM

Wed, Nov 1

tsoome committed rS325286: efipart_strategy is using wrong offset with >512B sectors.
efipart_strategy is using wrong offset with >512B sectors
Wed, Nov 1, 6:50 PM
tsoome closed D12849: efipart_strategy is using wrong offset with >512B sectors.
Wed, Nov 1, 6:50 PM
tsoome updated the diff for D12850: zfs.c:vdev_read() needs to be careful about large sectors.

Validate the return value from lseek()

Wed, Nov 1, 8:31 AM

Tue, Oct 31

tsoome closed D12847: loader ptblread() is broken with >512B sectors.
Tue, Oct 31, 8:29 PM
tsoome committed rS325248: loader ptblread() is broken with >512B sectors.
loader ptblread() is broken with >512B sectors
Tue, Oct 31, 8:29 PM
tsoome updated the diff for D12849: efipart_strategy is using wrong offset with >512B sectors.

offset is better name.

Tue, Oct 31, 8:22 PM
tsoome updated the diff for D12847: loader ptblread() is broken with >512B sectors.

Reword the comment.

Tue, Oct 31, 8:05 PM
tsoome created D12850: zfs.c:vdev_read() needs to be careful about large sectors.
Tue, Oct 31, 11:57 AM
tsoome created D12849: efipart_strategy is using wrong offset with >512B sectors.
Tue, Oct 31, 11:53 AM
tsoome created D12847: loader ptblread() is broken with >512B sectors.
Tue, Oct 31, 11:48 AM

Oct 20 2017

tsoome requested changes to D12732: Revert efipart to use EFI_HANDLEs for partitions.

This patch will need more work and cleanup, especially printing information about the devices.

Oct 20 2017, 9:02 AM

Oct 18 2017

tsoome committed rS324719: libsa/ip: stop read loop on bad fragments.
libsa/ip: stop read loop on bad fragments
Oct 18 2017, 8:06 AM
tsoome committed rS324717: libsa/ip.c: misplaced comment, ip_v is half char, not ip_p.
libsa/ip.c: misplaced comment, ip_v is half char, not ip_p
Oct 18 2017, 7:39 AM

Oct 13 2017

tsoome added a comment to D10447: Unify boot1 with loader.
In D10447#262729, @imp wrote:

I wonder why we even have boot1 anymore after these changes.... It's turning into a mini loader.efi. I wonder why we don't just kill it entirely. We don't need boot volume selection (that's supposed to be the EFI boot BIOS's job). We seem to duplicate a lot of code just to load /boot/loader.efi off of UFS or ZFS partitions. However, we could just use loader.efi directly (though some of the root detection code would need to be tweaked). boot1 used to be small, limited and basically unchanging (so updates weren't needed). Now that boot1.efi has hitched its wagon to loader.efi, I wonder why have an extra boot stage that seems to be good at messing up it's partition guessing...

I'm going to go ahead and commit this (after adding back the bits I keep saying were bogusly deleted), but I'm thinking strongly that we consider just moving to loader.efi installed into \efi\freebsd\loader.efi starting in FreeBSD 12 since we'll be able to point efibootmgr at it by then.

Oct 13 2017, 5:07 AM

Oct 2 2017

tsoome accepted D12565: remove heuristic error detection from ddi_strto*().
Oct 2 2017, 2:11 PM

Sep 25 2017

tsoome committed rS323991: libefi: efipart_floppy() will should not pass acpi pointer if the HID test fails.
libefi: efipart_floppy() will should not pass acpi pointer if the HID test fails
Sep 25 2017, 7:50 PM

Sep 22 2017

tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

Sep 22 2017, 8:20 PM
tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

Sep 22 2017, 6:59 PM
tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

Sep 22 2017, 5:37 PM
tsoome committed rS323909: libefi: define EISA PNP constants.
libefi: define EISA PNP constants
Sep 22 2017, 7:44 AM
tsoome committed rS323908: libefi: efipart_hdinfo_add_filepath should check strtol result.
libefi: efipart_hdinfo_add_filepath should check strtol result
Sep 22 2017, 7:40 AM
tsoome committed rS323907: libefi: efipart.c cstyle fix for efipart_print_common().
libefi: efipart.c cstyle fix for efipart_print_common()
Sep 22 2017, 7:38 AM
tsoome committed rS323906: libefi: efipart_strategy() should return ENXIO when there is no media.
libefi: efipart_strategy() should return ENXIO when there is no media
Sep 22 2017, 7:34 AM
tsoome committed rS323905: libefi: pdinfo_t pd_unit and pd_open should be unsigned.
libefi: pdinfo_t pd_unit and pd_open should be unsigned
Sep 22 2017, 7:29 AM
tsoome committed rS323897: efilib.h: typo in structure member description.
efilib.h: typo in structure member description
Sep 22 2017, 2:59 AM
tsoome committed rS323896: r323885 did miss efilib.h update.
r323885 did miss efilib.h update
Sep 22 2017, 2:56 AM
tsoome committed rS323895: libefi: efi_devpath_match local len should be unsigned.
libefi: efi_devpath_match local len should be unsigned
Sep 22 2017, 2:53 AM

Sep 21 2017

tsoome committed rS323886: libefi: efipart.c should use calloc().
libefi: efipart.c should use calloc()
Sep 21 2017, 11:22 PM
tsoome committed rS323885: libefi: efi_devpath_match() should return bool.
libefi: efi_devpath_match() should return bool
Sep 21 2017, 11:14 PM
tsoome committed rS323867: libefi: devicename.c cleanups.
libefi: devicename.c cleanups
Sep 21 2017, 3:30 PM

Sep 18 2017

tsoome committed rS323707: loader: biosmem allocate heap just below 4GB.
loader: biosmem allocate heap just below 4GB
Sep 18 2017, 3:17 PM
tsoome closed D12368: loader: biosmem allocate heap just below 4GB.
Sep 18 2017, 3:17 PM

Sep 14 2017

tsoome updated the diff for D12368: loader: biosmem allocate heap just below 4GB.

update after cstyle fix commit.

Sep 14 2017, 4:46 PM
tsoome committed rS323589: loader: biosmem.c cstyle cleanup.
loader: biosmem.c cstyle cleanup
Sep 14 2017, 4:42 PM
tsoome closed D12370: loader: biosmem.c cstyle cleanup.
Sep 14 2017, 4:42 PM
tsoome updated the summary of D12370: loader: biosmem.c cstyle cleanup.
Sep 14 2017, 3:19 PM
tsoome created D12370: loader: biosmem.c cstyle cleanup.
Sep 14 2017, 3:18 PM
tsoome added a comment to D12368: loader: biosmem allocate heap just below 4GB.

The whitespace changes make this a bit hard to read - do you have them as a separate local change that could be committed first?

Sep 14 2017, 2:11 PM
tsoome updated the summary of D12368: loader: biosmem allocate heap just below 4GB.
Sep 14 2017, 12:26 PM
tsoome created D12368: loader: biosmem allocate heap just below 4GB.
Sep 14 2017, 12:25 PM

Sep 13 2017

tsoome committed rS323541: libefi: efipart_realstrategy rsize pointer may be NULL.
libefi: efipart_realstrategy rsize pointer may be NULL
Sep 13 2017, 2:27 PM
tsoome accepted D9680: Increase EFI MSDOSFS image size to 512Kib.
Sep 13 2017, 7:09 AM

Sep 12 2017

tsoome closed D12340: libefi: efipart_open should check the status from disk_open.
Sep 12 2017, 2:19 PM
tsoome committed rS323497: libefi: efipart_open should check the status from disk_open.
libefi: efipart_open should check the status from disk_open
Sep 12 2017, 2:19 PM
tsoome created D12340: libefi: efipart_open should check the status from disk_open.
Sep 12 2017, 2:10 PM
tsoome closed D12202: libstand: tftp_open() can leak pkt on error.
Sep 12 2017, 1:51 PM
tsoome committed rS323496: libstand: tftp_open() can leak pkt on error.
libstand: tftp_open() can leak pkt on error
Sep 12 2017, 1:51 PM
tsoome committed rS323494: loader should support large_dnode.
loader should support large_dnode
Sep 12 2017, 1:45 PM
tsoome closed D12288: loader should support large_dnode.
Sep 12 2017, 1:45 PM

Sep 11 2017

tsoome updated the diff for D12288: loader should support large_dnode.

svn update

Sep 11 2017, 11:57 AM
tsoome updated the test plan for D12288: loader should support large_dnode.
Sep 11 2017, 11:54 AM
tsoome committed rS323428: r323389 breaks the kernel build when WITHOUT_ZFS is defined in src.conf.
r323389 breaks the kernel build when WITHOUT_ZFS is defined in src.conf
Sep 11 2017, 7:39 AM

Sep 10 2017

tsoome committed rS323389: loader.efi: chain loader should provide proper device handle.
loader.efi: chain loader should provide proper device handle
Sep 10 2017, 1:54 PM
tsoome closed D12287: loader.efi: chain loader should provide proper device handle.
Sep 10 2017, 1:53 PM

Sep 9 2017

tsoome created D12288: loader should support large_dnode.
Sep 9 2017, 11:58 AM
tsoome created D12287: loader.efi: chain loader should provide proper device handle.
Sep 9 2017, 11:48 AM

Sep 1 2017

tsoome closed D12201: libstand: nfs_readlink() should return proper return code by committing rS323100: libstand: nfs_readlink() should return proper return code.
Sep 1 2017, 4:40 PM
tsoome committed rS323100: libstand: nfs_readlink() should return proper return code.
libstand: nfs_readlink() should return proper return code
Sep 1 2017, 4:40 PM
tsoome created D12202: libstand: tftp_open() can leak pkt on error.
Sep 1 2017, 11:19 AM
tsoome created D12201: libstand: nfs_readlink() should return proper return code.
Sep 1 2017, 11:14 AM

Aug 15 2017

tsoome committed rS322542: loader.efi: repace XXX with real comments in trap.c.
loader.efi: repace XXX with real comments in trap.c
Aug 15 2017, 2:03 PM
tsoome closed D12035: loader.efi: repace XXX with real comments in trap.c by committing rS322542: loader.efi: repace XXX with real comments in trap.c.
Aug 15 2017, 2:03 PM
tsoome created D12035: loader.efi: repace XXX with real comments in trap.c.
Aug 15 2017, 1:40 PM

Aug 7 2017

tsoome added inline comments to D11886: Implement automatic kernel list in the boot loader.
Aug 7 2017, 7:46 AM

Aug 5 2017

tsoome committed rS322074: libefi/time.c cstyle cleanup.
libefi/time.c cstyle cleanup
Aug 5 2017, 5:20 AM
tsoome closed D11861: libefi/time.c cstyle cleanup by committing rS322074: libefi/time.c cstyle cleanup.
Aug 5 2017, 5:20 AM
tsoome updated the diff for D11861: libefi/time.c cstyle cleanup.

use memset instead of initializer

Aug 5 2017, 5:16 AM
tsoome updated the diff for D11861: libefi/time.c cstyle cleanup.

Added missing newlines.

Aug 5 2017, 5:03 AM

Aug 4 2017

tsoome updated the summary of D11861: libefi/time.c cstyle cleanup.
Aug 4 2017, 10:00 AM
tsoome created D11861: libefi/time.c cstyle cleanup.
Aug 4 2017, 9:57 AM

Aug 3 2017

tsoome added a comment to D10447: Unify boot1 with loader.
In D10447#245408, @imp wrote:

Also, the current change in size for boot1.efi from these changes is going to present problems for the upgrade path since we foolishly chose such small FAT partitions in the past, in violation of the UEFI standard (though to be honest, even at work where we have acres of disk space, I only make 50MB partitions). Some thought may need to be given to the upgrade path since the old installs won't be able to upgrade to the new boot1.efi.

Aug 3 2017, 6:13 AM
tsoome accepted D11820: Minor code refactor.
Aug 3 2017, 6:07 AM

Jul 31 2017

tsoome committed rS321767: Add myself to calendar.
Add myself to calendar
Jul 31 2017, 8:11 AM

Jul 25 2017

tsoome accepted D11732: Always set the receive mask in loader.efi.

Are there some specific examples about systems needing this?

Jul 25 2017, 4:09 PM

Jul 20 2017

tsoome accepted D11678: Fix printf format warning in zfs_module.c.
Jul 20 2017, 8:19 PM

Jul 1 2017

tsoome added inline comments to rS317097: loader: F_READ/F_WRITE should be checked against masked flag.
Jul 1 2017, 7:36 PM

Jun 29 2017

tsoome committed rS320467: loader: chain load relocate data declaration is bad.
loader: chain load relocate data declaration is bad
Jun 29 2017, 4:34 AM
tsoome closed D11321: loader: chain load relocate data declaration is bad by committing rS320467: loader: chain load relocate data declaration is bad.
Jun 29 2017, 4:34 AM

Jun 28 2017

tsoome added inline comments to D11321: loader: chain load relocate data declaration is bad.
Jun 28 2017, 8:27 PM
tsoome updated the diff for D11321: loader: chain load relocate data declaration is bad.

Use the struct based array.

Jun 28 2017, 6:27 PM

Jun 23 2017

tsoome added inline comments to D11321: loader: chain load relocate data declaration is bad.
Jun 23 2017, 10:45 AM
tsoome updated the summary of D11321: loader: chain load relocate data declaration is bad.
Jun 23 2017, 9:15 AM
tsoome added inline comments to D5992: Add chain loader support for loader.
Jun 23 2017, 9:14 AM
tsoome created D11321: loader: chain load relocate data declaration is bad.
Jun 23 2017, 9:12 AM

Jun 16 2017

tsoome committed rS320011: Add chain loader support for loader.
Add chain loader support for loader
Jun 16 2017, 8:08 PM
tsoome closed D5992: Add chain loader support for loader by committing rS320011: Add chain loader support for loader.
Jun 16 2017, 8:08 PM

Jun 13 2017

tsoome added a comment to D11174: loader: biosdisk interface should be able to cope with 4k sectors.

Comments updated.

Jun 13 2017, 5:34 PM