- User Since
- Dec 11 2015, 11:12 PM (67 w, 6 d)
I think the NQNFS comment is also not actual any more
Wed, Mar 29
Tue, Mar 28
Tue, Mar 21
still missed one space before tab.
And some more cstyle fixes.
missed one more malloc check, and small cstyle fix - missing space after
Mon, Mar 20
The review at illumos side: https://www.illumos.org/rb/r/408/
malloc can fail: so the stat size and mode should be zeroed before.
stat can fail: set mode = 0
and free does not need the check, but the comment is helpful.
This work is an result of review in https://www.illumos.org/rb/r/259/
Fixed the dhcp.interface-mtu check.
gcc did complain about missing prototype for getsecs(), including net.h
alone is not enough, so I just did add local prototype. clang does not seem
Sun, Mar 19
Fri, Mar 17
Ah, right, there is an problem now with viewing the changes - if you just upload the diff, there is not enough context for phabricator to work with. arcanist does post automatically, diff needs some command line option to provide the whole file, I can not recall it off hand..
Actually hold the horses a bit, I have incoming comments from illumos review and we can get this even better:)
Thu, Mar 16
seems ok for me:)
I'm sorry it took so long till I got to this one, some cstyle issues need attention.
Wed, Mar 15
Typo in errno name and casting to int.
ptable_print needs to open the nested partition with disk_open,
as the state is not shared any more.
Sat, Mar 4
Rewrote to use single sector sized bounce buffer. Done for safety reasons,
so we wont attempt to allocate some large buffers due to chaining errors.
Fri, Mar 3
Update suggested by rpokala.
Thu, Mar 2
Wed, Mar 1
Feb 24 2017
Feb 22 2017
svn update; and clean up the inverted if statement.
Fixes suggested by smh.