Page MenuHomeFreeBSD

tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (364 w, 2 d)

Recent Activity

Fri, Nov 18

tsoome accepted D37438: arm64/pmap: freed only used for PV_STATS.

Seems reasonable.

Fri, Nov 18, 5:00 PM

Oct 13 2022

tsoome accepted D36975: loader: fix elf lookup_symbol type filtering.
Oct 13 2022, 9:47 AM

Oct 11 2022

tsoome accepted D36927: sys/_pv_entry.h: Include sys/param.h.
Oct 11 2022, 2:29 PM

Oct 10 2022

tsoome accepted D36926: hwpmc: Define full set of Armv8.0 events.
Oct 10 2022, 4:06 PM
tsoome accepted D36925: hwpmc: Move DMC-620 and CMN-600 events to allow for full Armv8.0 space.

LGTM, thanks!

Oct 10 2022, 4:06 PM

Sep 20 2022

tsoome added a comment to D34479: Add support for custom keyboard layout when GELI asks for a passphrase.
In D34479#831843, @imp wrote:

Some general comments...

The style of indented #if isn't what we do in FreeBSD. Code should be indented as if the #if isn't present, and the # directives should be in column 1.
We don't add extra spaces around the ('s, as I've highlighted
We don't do if (foo) bar; on one line.
logical operators are at the end of the line, not the start of the continuation.

It's an interesting notion... You'll likely want to do something similar to the EFI boot loader as well.

Sep 20 2022, 9:02 PM · x86

Sep 14 2022

tsoome accepted D36568: stand: use archsw.arch_copyin instead of i386_copyin.
Sep 14 2022, 8:34 PM
tsoome accepted D36575: stand: Allocate bootinfo rather than have it be static.
Sep 14 2022, 8:32 PM
tsoome accepted D36576: stand/geli: Allocate saved_keys instead of making it static.
Sep 14 2022, 8:29 PM

Sep 13 2022

tsoome accepted D36544: i386: Mark the obsolete fields in bootinfo with _was_.
Sep 13 2022, 6:31 AM
tsoome accepted D36144: stand: Move amd64 tramp page table from .data to heap.
Sep 13 2022, 6:30 AM

Sep 8 2022

tsoome accepted D36490: stand: i386: take into account disk sector size for blk calculation.

Thanks!

Sep 8 2022, 6:54 AM

Sep 5 2022

tsoome committed rG1f5679569dd4: libpmc: pmc_init() should avoid overflowing pmc_class_table (authored by tsoome).
libpmc: pmc_init() should avoid overflowing pmc_class_table
Sep 5 2022, 12:40 PM
tsoome closed D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.
Sep 5 2022, 12:39 PM

Aug 31 2022

tsoome added inline comments to D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.
Aug 31 2022, 4:16 PM
tsoome updated the diff for D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.

review feedback.

Aug 31 2022, 4:15 PM
tsoome added inline comments to D36052: Enabling FreeBSD on ARM64 Hyper-V.
Aug 31 2022, 12:01 PM
tsoome updated the diff for D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.

50 enumeration values not handled in switch

Aug 31 2022, 11:44 AM
tsoome updated the diff for D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.

commit message update

Aug 31 2022, 11:30 AM
tsoome requested review of D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.
Aug 31 2022, 11:14 AM

Aug 15 2022

tsoome committed rGd98de7440507: loader: zfs reader should only store devdesc in f_devdata (authored by tsoome).
loader: zfs reader should only store devdesc in f_devdata
Aug 15 2022, 6:08 PM
tsoome closed D36202: loader: zfs reader should only store devdesc in f_devdata.
Aug 15 2022, 6:08 PM

Aug 14 2022

tsoome requested review of D36202: loader: zfs reader should only store devdesc in f_devdata.
Aug 14 2022, 9:52 PM

Aug 13 2022

tsoome accepted D36144: stand: Move amd64 tramp page table from .data to heap.

BSS would not had saved us as we do have code, data, bss, stack in low memory.

Aug 13 2022, 5:57 AM

Aug 12 2022

tsoome accepted D36145: stand: Only compile decompression routines.
Aug 12 2022, 6:33 AM

Jul 28 2022

tsoome accepted D35965: stand: Move i386_devdesc to a union.
Jul 28 2022, 4:49 PM

Jul 27 2022

tsoome accepted D35965: stand: Move i386_devdesc to a union.

I like it too.

Jul 27 2022, 5:50 PM

Jul 26 2022

tsoome accepted D35919: stand: Use devformat rather than disk_devfmt.
Jul 26 2022, 12:38 PM
tsoome accepted D35923: stand: For zfs, set dv_fmtdev to zfs_fmtdev.
Jul 26 2022, 12:35 PM
tsoome accepted D35928: stand: tftp.c doesn't need bootinfo.h.
Jul 26 2022, 12:32 PM
tsoome accepted D35927: stand: i386_fmtdev can be reduced to devformat.
Jul 26 2022, 12:30 PM
tsoome accepted D35917: stand: Add disk_fmtdev for dv_fmtdev for all the disk devices.
Jul 26 2022, 12:27 PM
tsoome accepted D35915: stand: Add dv_devfmt to return a string represenation of the device.
Jul 26 2022, 10:30 AM
tsoome committed rGcedbdaf0e586: Add pmc.dmc-620(3) man page. (authored by ray).
Add pmc.dmc-620(3) man page.
Jul 26 2022, 8:20 AM
tsoome closed D32669: Add pmc.dmc-620(3) man page..
Jul 26 2022, 8:19 AM

Jul 25 2022

tsoome accepted D35916: stand: Add devformat to return formatted string for a device.
Jul 25 2022, 10:33 PM
tsoome added inline comments to D35915: stand: Add dv_devfmt to return a string represenation of the device.
Jul 25 2022, 10:13 PM
tsoome added inline comments to D35914: stand: Change disk_fmtdev to take a struct devdesc *.
Jul 25 2022, 9:49 PM
tsoome accepted D35918: stand: In geli, use devformat instead of disk_fmtdev.
Jul 25 2022, 9:46 PM
tsoome accepted D35920: stand: Remove unneeded include from geli.
Jul 25 2022, 9:41 PM
tsoome accepted D35911: stand: Small comment correction.
Jul 25 2022, 9:40 PM
tsoome accepted D35913: stand: Make sure nobody has a NULL pointer for dv_cleanup.
Jul 25 2022, 8:34 PM
tsoome accepted D35910: stand: Create DEV_NAMLEN for the length of a device name.
Jul 25 2022, 8:32 PM

Jul 24 2022

tsoome accepted D35894: stand/libsa: zfs use standard ZFS_EARLY stuff.
Jul 24 2022, 9:09 PM
tsoome accepted D35893: zfs: Increase compatibility for different environments.

I am wondering, if we should use #ifndef ASSERT etc instead.

Jul 24 2022, 7:38 PM
tsoome accepted D35896: tools/boot: Fix universe.sh's ZFS exclusion test.
Jul 24 2022, 7:33 PM
tsoome accepted D35891: skein: Update guard define check.
Jul 24 2022, 7:32 PM
tsoome accepted D35892: stand: improve compatibility.
Jul 24 2022, 7:31 PM
tsoome accepted D35894: stand/libsa: zfs use standard ZFS_EARLY stuff.
Jul 24 2022, 7:27 PM
tsoome accepted D35887: stand/zfs: Limit flags further for ZFS.
Jul 24 2022, 5:03 PM
tsoome accepted D35887: stand/zfs: Limit flags further for ZFS.
Jul 24 2022, 7:29 AM

Jul 22 2022

tsoome updated the diff for D32669: Add pmc.dmc-620(3) man page..

update date and nuke $FreeBSD$

Jul 22 2022, 1:27 PM
tsoome updated the diff for D32669: Add pmc.dmc-620(3) man page..

suggestions from review.

Jul 22 2022, 1:21 PM

Jul 20 2022

tsoome accepted D33302: zfs boot: prefer a pool with bootfs set for a boot pool.
In D33302#814333, @avg wrote:

@tsoome , could you please clarify the nature of our objection to this change?

Jul 20 2022, 10:50 PM

Jul 14 2022

tsoome committed rGf4ca0fdbe69d: loader.efi: faults could try to print out call trace (authored by tsoome).
loader.efi: faults could try to print out call trace
Jul 14 2022, 1:04 PM
tsoome closed D35433: loader.efi: faults could try to print out call trace.
Jul 14 2022, 1:04 PM

Jul 10 2022

tsoome updated the diff for D32669: Add pmc.dmc-620(3) man page..

Do not split authors on new lines.

Jul 10 2022, 11:08 AM
tsoome commandeered D32669: Add pmc.dmc-620(3) man page..
Jul 10 2022, 11:07 AM
tsoome abandoned D35592: loader: add blake3 checksum support.

Implemented by https://reviews.freebsd.org/D35750

Jul 10 2022, 10:13 AM
tsoome committed rGda4e1e319c6c: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man… (authored by ray).
Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man…
Jul 10 2022, 9:29 AM
tsoome closed D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
Jul 10 2022, 9:29 AM

Jul 9 2022

tsoome added a comment to D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..

most done

Jul 9 2022, 9:01 AM
tsoome updated the diff for D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..

and more feedback

Jul 9 2022, 9:00 AM
tsoome updated the diff for D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..

some more feedback.

Jul 9 2022, 8:58 AM
tsoome updated the diff for D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..

review feedback

Jul 9 2022, 8:54 AM
tsoome commandeered D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
Jul 9 2022, 8:43 AM

Jul 8 2022

tsoome added a comment to D35750: Make blake3 work.

It does look good, thanks! (waiting for update as noted in chat).

Jul 8 2022, 8:00 PM

Jul 4 2022

tsoome accepted D35709: fix pmcstat .

Seems to be good. and on this arm64 machine, it does work:

Jul 4 2022, 4:08 PM
tsoome committed rG67f8b6d985db: loader: GELI encrypted disk should still use device name disk (authored by tsoome).
loader: GELI encrypted disk should still use device name disk
Jul 4 2022, 6:16 AM

Jun 26 2022

tsoome committed rG59191f3573f6: Add support of ARM CMN-600 controller, PMU access functions only. Add support… (authored by ray).
Add support of ARM CMN-600 controller, PMU access functions only. Add support…
Jun 26 2022, 10:29 PM
tsoome closed D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..
Jun 26 2022, 10:28 PM
tsoome committed rG1459a22787ea: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver (authored by ray).
The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver
Jun 26 2022, 10:22 PM
tsoome closed D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.
Jun 26 2022, 10:21 PM
tsoome committed rGe3572eb65473: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by… (authored by ray).
Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by…
Jun 26 2022, 10:18 PM
tsoome closed D35609: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU..
Jun 26 2022, 10:17 PM
tsoome requested review of D35609: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU..
Jun 26 2022, 8:39 PM
tsoome committed rGfdfeaa66b58a: Support of optional PMC classes. (authored by ray).
Support of optional PMC classes.
Jun 26 2022, 9:20 AM
tsoome closed D32316: Support of optional PMC classes..
Jun 26 2022, 9:19 AM · pmc
tsoome committed rGb6e28991bf3a: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620… (authored by ray).
System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620…
Jun 26 2022, 9:13 AM
tsoome closed D35342: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..
Jun 26 2022, 9:12 AM
tsoome committed rG39510c65e376: test_diskread(): detect end of the disk (authored by tsoome).
test_diskread(): detect end of the disk
Jun 26 2022, 8:51 AM
tsoome committed rGc796ba5824d8: loader.efi: fix panic() after BS off (authored by tsoome).
loader.efi: fix panic() after BS off
Jun 26 2022, 8:46 AM
tsoome committed rG95e283e4d00f: loader: abstract boot services exiting to libefi function (authored by imp).
loader: abstract boot services exiting to libefi function
Jun 26 2022, 8:35 AM
Herald added a reviewer for D32226: loader: abstract boot services exiting to libefi function: manu.
Jun 26 2022, 8:34 AM
tsoome committed rGc8e7050f8a6a: efi: switch boot_services_gone to boot_services_active (authored by imp).
efi: switch boot_services_gone to boot_services_active
Jun 26 2022, 8:26 AM
Herald added a reviewer for D31814: efi: switch boot_services_gone to boot_services_active: manu.
Jun 26 2022, 8:25 AM
tsoome committed rG412c7437218a: userboot is missing vdisk_dev (authored by tsoome).
userboot is missing vdisk_dev
Jun 26 2022, 8:16 AM

Jun 25 2022

tsoome added a comment to D35342: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..

Seems to be the same as the original review with my two suggested tweaks? LGTM

Jun 25 2022, 8:21 PM
tsoome updated the diff for D35342: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..

Updates to pmc.3 as suggested by pauamma_gundo.com.

Jun 25 2022, 8:03 PM
tsoome added inline comments to D35342: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..
Jun 25 2022, 8:01 PM
tsoome added a comment to D35592: loader: add blake3 checksum support.
In D35592#807294, @imp wrote:

I really really rather you use the files directly. I fought for a long time to get the OpenZFS integration working well, and I really want a better reason for this copying than 'headers are a mess'.

Like before, though, I'm happy to help. Copied files are a huge source of technical debt and we have way way way too much of that in the loader as it is.

Jun 25 2022, 6:07 PM
tsoome added a comment to D35592: loader: add blake3 checksum support.

Based on OpenZFS bits. I did try to use blake3 sources directly, but headers are still major trap there. Of course there would also be question of generic versus asm implementations, but linker set would help there IMO (linker sets should be supported by most systems).

Jun 25 2022, 11:55 AM
tsoome requested review of D35592: loader: add blake3 checksum support.
Jun 25 2022, 11:49 AM

Jun 20 2022

tsoome committed rGe417249016ef: loader: GELI encrypted disk should still use device name disk (authored by tsoome).
loader: GELI encrypted disk should still use device name disk
Jun 20 2022, 7:11 AM

Jun 19 2022

tsoome committed rGe368fb6eb6eb: userboot is missing vdisk_dev (authored by tsoome).
userboot is missing vdisk_dev
Jun 19 2022, 6:36 PM
tsoome committed rG942e52f776e6: test_diskread(): detect end of the disk (authored by tsoome).
test_diskread(): detect end of the disk
Jun 19 2022, 3:27 PM
tsoome closed D35432: test_diskread(): detect end of the disk.
Jun 19 2022, 3:27 PM
tsoome committed rGa2e02d9d8e10: loader.efi: fix panic() after BS off (authored by tsoome).
loader.efi: fix panic() after BS off
Jun 19 2022, 2:48 PM

Jun 9 2022

tsoome committed rGe50e40684aa6: loader: add support for gzip compression (authored by tsoome).
loader: add support for gzip compression
Jun 9 2022, 7:20 PM
tsoome closed D35320: loader: add support for gzip compression.
Jun 9 2022, 7:20 PM