tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (92 w, 6 d)

Recent Activity

Today

tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

Fri, Sep 22, 8:20 PM
tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

Fri, Sep 22, 6:59 PM
tsoome added a comment to D12466: Allow LOADER_TFTP_SUPPORT to work again.

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

Fri, Sep 22, 5:37 PM
tsoome committed rS323909: libefi: define EISA PNP constants.
libefi: define EISA PNP constants
Fri, Sep 22, 7:44 AM
tsoome committed rS323908: libefi: efipart_hdinfo_add_filepath should check strtol result.
libefi: efipart_hdinfo_add_filepath should check strtol result
Fri, Sep 22, 7:40 AM
tsoome committed rS323907: libefi: efipart.c cstyle fix for efipart_print_common().
libefi: efipart.c cstyle fix for efipart_print_common()
Fri, Sep 22, 7:38 AM
tsoome committed rS323906: libefi: efipart_strategy() should return ENXIO when there is no media.
libefi: efipart_strategy() should return ENXIO when there is no media
Fri, Sep 22, 7:34 AM
tsoome committed rS323905: libefi: pdinfo_t pd_unit and pd_open should be unsigned.
libefi: pdinfo_t pd_unit and pd_open should be unsigned
Fri, Sep 22, 7:29 AM
tsoome committed rS323897: efilib.h: typo in structure member description.
efilib.h: typo in structure member description
Fri, Sep 22, 2:59 AM
tsoome committed rS323896: r323885 did miss efilib.h update.
r323885 did miss efilib.h update
Fri, Sep 22, 2:56 AM
tsoome committed rS323895: libefi: efi_devpath_match local len should be unsigned.
libefi: efi_devpath_match local len should be unsigned
Fri, Sep 22, 2:53 AM

Yesterday

tsoome committed rS323886: libefi: efipart.c should use calloc().
libefi: efipart.c should use calloc()
Thu, Sep 21, 11:22 PM
tsoome committed rS323885: libefi: efi_devpath_match() should return bool.
libefi: efi_devpath_match() should return bool
Thu, Sep 21, 11:14 PM
tsoome committed rS323867: libefi: devicename.c cleanups.
libefi: devicename.c cleanups
Thu, Sep 21, 3:30 PM

Mon, Sep 18

tsoome committed rS323707: loader: biosmem allocate heap just below 4GB.
loader: biosmem allocate heap just below 4GB
Mon, Sep 18, 3:17 PM
tsoome closed D12368: loader: biosmem allocate heap just below 4GB.
Mon, Sep 18, 3:17 PM

Thu, Sep 14

tsoome updated the diff for D12368: loader: biosmem allocate heap just below 4GB.

update after cstyle fix commit.

Thu, Sep 14, 4:46 PM
tsoome committed rS323589: loader: biosmem.c cstyle cleanup.
loader: biosmem.c cstyle cleanup
Thu, Sep 14, 4:42 PM
tsoome closed D12370: loader: biosmem.c cstyle cleanup.
Thu, Sep 14, 4:42 PM
tsoome updated the summary of D12370: loader: biosmem.c cstyle cleanup.
Thu, Sep 14, 3:19 PM
tsoome created D12370: loader: biosmem.c cstyle cleanup.
Thu, Sep 14, 3:18 PM
tsoome added a comment to D12368: loader: biosmem allocate heap just below 4GB.

The whitespace changes make this a bit hard to read - do you have them as a separate local change that could be committed first?

Thu, Sep 14, 2:11 PM
tsoome updated the summary of D12368: loader: biosmem allocate heap just below 4GB.
Thu, Sep 14, 12:26 PM
tsoome created D12368: loader: biosmem allocate heap just below 4GB.
Thu, Sep 14, 12:25 PM

Wed, Sep 13

tsoome committed rS323541: libefi: efipart_realstrategy rsize pointer may be NULL.
libefi: efipart_realstrategy rsize pointer may be NULL
Wed, Sep 13, 2:27 PM
tsoome accepted D9680: Increase EFI MSDOSFS image size to 512Kib.
Wed, Sep 13, 7:09 AM

Tue, Sep 12

tsoome closed D12340: libefi: efipart_open should check the status from disk_open.
Tue, Sep 12, 2:19 PM
tsoome committed rS323497: libefi: efipart_open should check the status from disk_open.
libefi: efipart_open should check the status from disk_open
Tue, Sep 12, 2:19 PM
tsoome created D12340: libefi: efipart_open should check the status from disk_open.
Tue, Sep 12, 2:10 PM
tsoome closed D12202: libstand: tftp_open() can leak pkt on error.
Tue, Sep 12, 1:51 PM
tsoome committed rS323496: libstand: tftp_open() can leak pkt on error.
libstand: tftp_open() can leak pkt on error
Tue, Sep 12, 1:51 PM
tsoome committed rS323494: loader should support large_dnode.
loader should support large_dnode
Tue, Sep 12, 1:45 PM
tsoome closed D12288: loader should support large_dnode.
Tue, Sep 12, 1:45 PM

Mon, Sep 11

tsoome updated the diff for D12288: loader should support large_dnode.

svn update

Mon, Sep 11, 11:57 AM
tsoome updated the test plan for D12288: loader should support large_dnode.
Mon, Sep 11, 11:54 AM
tsoome committed rS323428: r323389 breaks the kernel build when WITHOUT_ZFS is defined in src.conf.
r323389 breaks the kernel build when WITHOUT_ZFS is defined in src.conf
Mon, Sep 11, 7:39 AM

Sun, Sep 10

tsoome committed rS323389: loader.efi: chain loader should provide proper device handle.
loader.efi: chain loader should provide proper device handle
Sun, Sep 10, 1:54 PM
tsoome closed D12287: loader.efi: chain loader should provide proper device handle.
Sun, Sep 10, 1:53 PM

Sat, Sep 9

tsoome created D12288: loader should support large_dnode.
Sat, Sep 9, 11:58 AM
tsoome created D12287: loader.efi: chain loader should provide proper device handle.
Sat, Sep 9, 11:48 AM

Fri, Sep 1

tsoome closed D12201: libstand: nfs_readlink() should return proper return code by committing rS323100: libstand: nfs_readlink() should return proper return code.
Fri, Sep 1, 4:40 PM
tsoome committed rS323100: libstand: nfs_readlink() should return proper return code.
libstand: nfs_readlink() should return proper return code
Fri, Sep 1, 4:40 PM
tsoome created D12202: libstand: tftp_open() can leak pkt on error.
Fri, Sep 1, 11:19 AM
tsoome created D12201: libstand: nfs_readlink() should return proper return code.
Fri, Sep 1, 11:14 AM

Aug 15 2017

tsoome committed rS322542: loader.efi: repace XXX with real comments in trap.c.
loader.efi: repace XXX with real comments in trap.c
Aug 15 2017, 2:03 PM
tsoome closed D12035: loader.efi: repace XXX with real comments in trap.c by committing rS322542: loader.efi: repace XXX with real comments in trap.c.
Aug 15 2017, 2:03 PM
tsoome created D12035: loader.efi: repace XXX with real comments in trap.c.
Aug 15 2017, 1:40 PM

Aug 7 2017

tsoome added inline comments to D11886: Implement automatic kernel list in the boot loader.
Aug 7 2017, 7:46 AM

Aug 5 2017

tsoome committed rS322074: libefi/time.c cstyle cleanup.
libefi/time.c cstyle cleanup
Aug 5 2017, 5:20 AM
tsoome closed D11861: libefi/time.c cstyle cleanup by committing rS322074: libefi/time.c cstyle cleanup.
Aug 5 2017, 5:20 AM
tsoome updated the diff for D11861: libefi/time.c cstyle cleanup.

use memset instead of initializer

Aug 5 2017, 5:16 AM
tsoome updated the diff for D11861: libefi/time.c cstyle cleanup.

Added missing newlines.

Aug 5 2017, 5:03 AM

Aug 4 2017

tsoome updated the summary of D11861: libefi/time.c cstyle cleanup.
Aug 4 2017, 10:00 AM
tsoome created D11861: libefi/time.c cstyle cleanup.
Aug 4 2017, 9:57 AM

Aug 3 2017

tsoome added a comment to D10447: Unify boot1 with loader.
In D10447#245408, @imp wrote:

Also, the current change in size for boot1.efi from these changes is going to present problems for the upgrade path since we foolishly chose such small FAT partitions in the past, in violation of the UEFI standard (though to be honest, even at work where we have acres of disk space, I only make 50MB partitions). Some thought may need to be given to the upgrade path since the old installs won't be able to upgrade to the new boot1.efi.

Aug 3 2017, 6:13 AM
tsoome accepted D11820: Minor code refactor.
Aug 3 2017, 6:07 AM

Jul 31 2017

tsoome committed rS321767: Add myself to calendar.
Add myself to calendar
Jul 31 2017, 8:11 AM

Jul 25 2017

tsoome accepted D11732: Always set the receive mask in loader.efi.

Are there some specific examples about systems needing this?

Jul 25 2017, 4:09 PM

Jul 20 2017

tsoome accepted D11678: Fix printf format warning in zfs_module.c.
Jul 20 2017, 8:19 PM

Jul 1 2017

tsoome added inline comments to rS317097: loader: F_READ/F_WRITE should be checked against masked flag.
Jul 1 2017, 7:36 PM

Jun 29 2017

tsoome committed rS320467: loader: chain load relocate data declaration is bad.
loader: chain load relocate data declaration is bad
Jun 29 2017, 4:34 AM
tsoome closed D11321: loader: chain load relocate data declaration is bad by committing rS320467: loader: chain load relocate data declaration is bad.
Jun 29 2017, 4:34 AM

Jun 28 2017

tsoome added inline comments to D11321: loader: chain load relocate data declaration is bad.
Jun 28 2017, 8:27 PM
tsoome updated the diff for D11321: loader: chain load relocate data declaration is bad.

Use the struct based array.

Jun 28 2017, 6:27 PM

Jun 23 2017

tsoome added inline comments to D11321: loader: chain load relocate data declaration is bad.
Jun 23 2017, 10:45 AM
tsoome updated the summary of D11321: loader: chain load relocate data declaration is bad.
Jun 23 2017, 9:15 AM
tsoome added inline comments to D5992: Add chain loader support for loader.
Jun 23 2017, 9:14 AM
tsoome created D11321: loader: chain load relocate data declaration is bad.
Jun 23 2017, 9:12 AM

Jun 16 2017

tsoome committed rS320011: Add chain loader support for loader.
Add chain loader support for loader
Jun 16 2017, 8:08 PM
tsoome closed D5992: Add chain loader support for loader by committing rS320011: Add chain loader support for loader.
Jun 16 2017, 8:08 PM

Jun 13 2017

tsoome added a comment to D11174: loader: biosdisk interface should be able to cope with 4k sectors.

Comments updated.

Jun 13 2017, 5:34 PM
tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.

Comment wording as suggested by allanjude

Jun 13 2017, 5:32 PM
tsoome added a comment to D11174: loader: biosdisk interface should be able to cope with 4k sectors.

Looks good to me. What needs to be done for the GELI bits?

Jun 13 2017, 3:59 PM
tsoome created D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Jun 13 2017, 12:24 PM

Jun 5 2017

tsoome added a comment to D7600: The experiment to consolidate some crypto functions, shared between zfs/geli..

Thanks for the work! (I thought this was already landed last year :)

The change looks good to me (and I appreciate it as a step forward -- duplicated copies of cryptographic code is a big headache for us) overall.

(Totally optional: I wonder if the cryptoboot library could be folded into libstand? Or is there some specific reasons we have to create a new library instead? I'm asking because doing so would avoid building it multiple times, and the license of the source are all BSD compatible.)

Jun 5 2017, 9:06 PM
tsoome updated the diff for D7600: The experiment to consolidate some crypto functions, shared between zfs/geli..

Updated to revision 319604.

Jun 5 2017, 6:06 PM
tsoome committed rS319601: ANSIfy md5 functions.
ANSIfy md5 functions
Jun 5 2017, 11:55 AM
tsoome closed D11055: ANSIfy md5 functions by committing rS319601: ANSIfy md5 functions.
Jun 5 2017, 11:55 AM
tsoome created D11055: ANSIfy md5 functions.
Jun 5 2017, 11:21 AM

May 31 2017

tsoome added a comment to D11007: flag to switch off bootp().

It's the only one from pxeloader. I can safety remove the same from iPXE and in summary, during boot chain I have less a half of DHCP request in network. Let's say grain by grain...

May 31 2017, 10:10 PM

May 28 2017

tsoome closed D10981: use the same option list for dhcp discovery and request by committing rS319085: use the same option list for dhcp discovery and request.
May 28 2017, 9:30 PM
tsoome committed rS319085: use the same option list for dhcp discovery and request.
use the same option list for dhcp discovery and request
May 28 2017, 9:30 PM
tsoome created D10981: use the same option list for dhcp discovery and request.
May 28 2017, 9:24 PM
tsoome committed rS319084: Small cleanup in dev_net.c.
Small cleanup in dev_net.c
May 28 2017, 9:21 PM
tsoome closed D10980: Small cleanup in dev_net.c by committing rS319084: Small cleanup in dev_net.c.
May 28 2017, 9:21 PM
tsoome created D10980: Small cleanup in dev_net.c.
May 28 2017, 9:11 PM

May 27 2017

tsoome accepted D10953: Partially revert 314948.

LGTM.

May 27 2017, 12:43 PM
tsoome accepted D10952: Always issue the pxe request.
May 27 2017, 12:31 PM
tsoome added inline comments to D10952: Always issue the pxe request.
May 27 2017, 12:26 PM
tsoome accepted D10947: Support URI scheme for root-path in netbooting.

LGTM.

May 27 2017, 12:01 PM
tsoome added inline comments to D10947: Support URI scheme for root-path in netbooting.
May 27 2017, 11:12 AM
tsoome accepted D10951: Pass a "FREEBSD" user-class in PXE dhcp request.

LGTM.

May 27 2017, 10:46 AM

May 25 2017

tsoome accepted D10895: Make the ZFS min_auto_ashift=12 setting persistent.

ok, that explanation does make sense, LGTM.

May 25 2017, 5:33 PM
tsoome added a comment to D10895: Make the ZFS min_auto_ashift=12 setting persistent.

IMO if it is really supposed to be default, then the correct place is in /boot/defaults/loader.conf - overloading /boot/loader.conf will only confuse people.

May 25 2017, 1:37 PM

May 22 2017

tsoome added inline comments to D10854: Add support for protocol prefixes in rootpath.
May 22 2017, 4:27 PM
tsoome added inline comments to D10854: Add support for protocol prefixes in rootpath.
May 22 2017, 3:53 PM

May 19 2017

tsoome accepted D10736: bsdinstall: do not use distextract in scripted mode.

LGTM:)

May 19 2017, 8:18 AM
tsoome accepted D10738: bsdinstall: mount is not needed for the ZFS install case.
May 19 2017, 8:14 AM

May 18 2017

tsoome accepted D10738: bsdinstall: mount is not needed for the ZFS install case.

I do not know much about bsdinstall scripts but as much as it counts, seems ok for me;)

May 18 2017, 4:08 PM

May 17 2017

tsoome added a comment to D10603: distinguish NFS versus TFTP boot by rootpath.
In D10603#223350, @bapt wrote:

What I mean is we cannot use the one I listed above because they are interpreted by ipxe. For example if one netboots from qemu it will use ipxe under the hood first, then if you pass rootpath tftp:/ ipxe will say

Next server: 192.168.42.1
Filename: /pxeboot
Root path: tftp:/
Could not open SAN device: Invalid argument (http://ipxe.org/1c126002)
No more network devices

and the boot process fails.

Which is why what I propose is tftpfs:/ because it is not used by ipxe
and by default we remain on over nfs so we don't break existing usage

May 17 2017, 10:04 PM