People tsoome

tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (140 w, 4 d)

Recent Activity
View All

Sun, Aug 19

tsoome added inline comments to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Sun, Aug 19, 1:43 PM

Thu, Aug 16

tsoome added inline comments to D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Thu, Aug 16, 8:04 PM
tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.

reverted comment, requested by imp.

Thu, Aug 16, 7:00 PM
tsoome added a comment to D11174: loader: biosdisk interface should be able to cope with 4k sectors.

Comments updated.

Thu, Aug 16, 6:58 PM
tsoome updated the summary of D11174: loader: biosdisk interface should be able to cope with 4k sectors.
Thu, Aug 16, 10:40 AM
tsoome updated the diff for D11174: loader: biosdisk interface should be able to cope with 4k sectors.

Rebase on recent rev.

Thu, Aug 16, 10:34 AM
tsoome committed rS337891: libi386: bd_io_workaround() is to be called for reads only.
libi386: bd_io_workaround() is to be called for reads only
Thu, Aug 16, 7:13 AM
tsoome committed rS337890: libi386: small style updates in biosdisk.
libi386: small style updates in biosdisk
Thu, Aug 16, 6:51 AM

Wed, Aug 15

tsoome committed rS337881: libi386: use BD_RD and BR_WR constants.
libi386: use BD_RD and BR_WR constants
Wed, Aug 15, 10:40 PM
tsoome committed rS337878: libi386: remove bd_read() and bd_write() wrappers.
libi386: remove bd_read() and bd_write() wrappers
Wed, Aug 15, 10:25 PM
tsoome committed rS337874: libsa: zfs_probe() needs to set spa to NULL.
libsa: zfs_probe() needs to set spa to NULL
Wed, Aug 15, 9:38 PM
tsoome committed rS337872: libi386: remove BD_SUPPORT_FRAGS.
libi386: remove BD_SUPPORT_FRAGS
Wed, Aug 15, 9:21 PM
tsoome closed D16600: loader: remove BD_SUPPORT_FRAGS.
Wed, Aug 15, 9:21 PM
tsoome committed rS337833: cd9660 pointer sign issues and missing __packed attribute.
cd9660 pointer sign issues and missing __packed attribute
Wed, Aug 15, 6:42 AM
tsoome closed D16564: cd9660 pointer sign issues and missing __packed attribute.
Wed, Aug 15, 6:42 AM
tsoome abandoned D15207: loader: zfs reader must use uint64_t instead of off_t.
Wed, Aug 15, 6:36 AM

Tue, Aug 7

tsoome committed rS337413: libsa: gzipfs.c converts pointers to integer types with different sign.
libsa: gzipfs.c converts pointers to integer types with different sign
Tue, Aug 7, 10:54 AM
tsoome committed rS337412: libsa: dos_checksum() should take unsigned chars.
libsa: dos_checksum() should take unsigned chars
Tue, Aug 7, 10:48 AM

Mon, Aug 6

tsoome created D16600: loader: remove BD_SUPPORT_FRAGS.
Mon, Aug 6, 5:24 AM

Sun, Aug 5

tsoome committed rS337356: loader: bd_open() should cleanup from disk_open() error.
loader: bd_open() should cleanup from disk_open() error
Sun, Aug 5, 7:17 PM
tsoome committed rS337354: loader: 337353 did miss to rename 2 write instances.
loader: 337353 did miss to rename 2 write instances
Sun, Aug 5, 6:24 PM
tsoome committed rS337353: loader: cstyle cleanup for biosdisk.c.
loader: cstyle cleanup for biosdisk.c
Sun, Aug 5, 6:20 PM

Sat, Aug 4

tsoome committed rS337326: loader: biosdisk.c has leftover geli header..
loader: biosdisk.c has leftover geli header.
Sat, Aug 4, 8:04 PM
tsoome accepted D16588: Sanity check BIOS EDD CHS numbers before using them..
Sat, Aug 4, 11:12 AM

Fri, Aug 3

tsoome committed rS337231: loader.efi: clean up misleading noise from missing block devices.
loader.efi: clean up misleading noise from missing block devices
Fri, Aug 3, 7:59 AM
tsoome accepted D16577: Fix boot hang when Mediasonic HD3-U2B-ME USB disk enclsosure is attached.
Fri, Aug 3, 4:55 AM

Thu, Aug 2

tsoome committed rS337131: loader.efi: efipart_inithandles() failure should not prevent devsw….
loader.efi: efipart_inithandles() failure should not prevent devsw…
Thu, Aug 2, 12:43 PM
tsoome created D16564: cd9660 pointer sign issues and missing __packed attribute.
Thu, Aug 2, 10:16 AM
tsoome committed rS337065: libsa: dereferencing type-punned pointer in cd9660.
libsa: dereferencing type-punned pointer in cd9660
Thu, Aug 2, 6:22 AM

Wed, Aug 1

tsoome committed rS337039: libsa: assignment to char * from u_char *.
libsa: assignment to char * from u_char *
Wed, Aug 1, 12:14 PM
tsoome committed rS337038: libsa: bootp is using pointers with different sign.
libsa: bootp is using pointers with different sign
Wed, Aug 1, 12:07 PM
tsoome committed rS337037: libsa: pointer differs in signedness.
libsa: pointer differs in signedness
Wed, Aug 1, 11:41 AM
tsoome accepted D12698: Add EFI KMS and keybuf integration.
Wed, Aug 1, 11:16 AM

Mon, Jul 23

tsoome accepted D16403: Finalize the boot manager protocol support for next-stage boot loading..

Seems OK

Mon, Jul 23, 8:31 PM

Jul 19 2018

tsoome added a comment to D16322: If rootdev is set, use it as currdev..
In D16322#346807, @ish_amail.plala.or.jp wrote:

Sorry, although this patch is good working from rEFInd, it is not working for loader prompt.
While showing boot menu, press '3' and go to loader prompt.
OK set rootdev=disk0pX
OK boot
The OS is booted from currdev, not from rootdev.

Jul 19 2018, 7:10 AM
tsoome added inline comments to D16322: If rootdev is set, use it as currdev..
Jul 19 2018, 5:46 AM

Jul 18 2018

tsoome accepted D16322: If rootdev is set, use it as currdev..
Jul 18 2018, 3:34 PM
tsoome added a comment to D12698: Add EFI KMS and keybuf integration.
In D12698#346268, @eric_metricspace.net wrote:

Some part of this ought to be committed, as it enables TPM support in EFI. It's worth discussing exactly which parts are necessary.

Jul 18 2018, 10:59 AM

Jul 17 2018

tsoome accepted D16309: Remove bogus attempt to simulate scrolling. It's not needed and messes up serial output..
Jul 17 2018, 8:48 PM

Jul 16 2018

tsoome added inline comments to D11124: ZSTD compression for ZFS.
Jul 16 2018, 5:49 PM

Jul 14 2018

tsoome committed rS336274: regex/engine.c: error: variable 'dp' set but not used.
regex/engine.c: error: variable 'dp' set but not used
Jul 14 2018, 9:30 AM
tsoome closed D13109: regex/engine.c: error: variable 'dp' set but not used.
Jul 14 2018, 9:30 AM

Jun 30 2018

tsoome accepted D16068: Colons in boot environment name.
Jun 30 2018, 6:01 AM

Jun 16 2018

tsoome accepted D15844: Avoid reading past the end of the disk in zfsboot.c and biosdisk.c.
Jun 16 2018, 6:28 AM

Jun 15 2018

tsoome added a comment to D15207: loader: zfs reader must use uint64_t instead of off_t.
In D15207#334555, @imp wrote:

I don't like this change at all. There's no practical difference, and this diverges us from the normal unix APIs.

Jun 15 2018, 4:16 PM
tsoome updated the diff for D15207: loader: zfs reader must use uint64_t instead of off_t.

gptboot.c was missing the switch to uint64_t

Jun 15 2018, 7:36 AM

Jun 14 2018

tsoome committed rS335148: libsa: open() should use NULL instead of typecasted 0.
libsa: open() should use NULL instead of typecasted 0
Jun 14 2018, 4:12 PM
tsoome committed rS335127: libsa: remobe unneeded check before free().
libsa: remobe unneeded check before free()
Jun 14 2018, 9:10 AM
tsoome committed rS335126: libsa: f_rabuf could be NULL.
libsa: f_rabuf could be NULL
Jun 14 2018, 9:07 AM
tsoome committed rS335125: libsa: cstyle cleanup for open/close/read/write sources.
libsa: cstyle cleanup for open/close/read/write sources
Jun 14 2018, 8:58 AM

Jun 13 2018

tsoome accepted D15784: Use "$@" instead of $* to cope with parameters that have spaces in them..
Jun 13 2018, 6:09 AM

Jun 8 2018

tsoome added a comment to D12732: Revert efipart to use EFI_HANDLEs for partitions.
In D12732#331837, @eric_metricspace.net wrote:

Rebase from master and tried on real hardware

Jun 8 2018, 7:26 AM

May 28 2018

tsoome accepted D15599: switch amd64 memstick installer images to MBR.
May 28 2018, 5:20 PM

May 3 2018

tsoome added a comment to D15207: loader: zfs reader must use uint64_t instead of off_t.
In D15207#322069, @avg wrote:
In D15207#322067, @tsoome wrote:
In D15207#322036, @avg wrote:

I think that on FreeBSD off_t is always 64 bit.

Yes, thats correct, it is 8 bytes (did verify). However, there is still issue of sign. Of course even with signed case we have quite a large max value there...

I think that the difference between 2⁶⁴ and 2⁶³ is negligible for all practical purposes.

May 3 2018, 12:29 PM
tsoome updated the summary of D15207: loader: zfs reader must use uint64_t instead of off_t.
May 3 2018, 12:16 PM
tsoome added a comment to D15207: loader: zfs reader must use uint64_t instead of off_t.
In D15207#322036, @avg wrote:

I think that on FreeBSD off_t is always 64 bit.

May 3 2018, 12:16 PM

May 1 2018

tsoome accepted D15264: Remove 'All Rights Reserved' from the collection copyright and templates..
May 1 2018, 7:08 PM

Apr 26 2018

tsoome created D15207: loader: zfs reader must use uint64_t instead of off_t.
Apr 26 2018, 9:10 AM

Apr 18 2018

tsoome added inline comments to D15064: Add st_ino etc to libsa ufs_stat.
Apr 18 2018, 7:50 PM
tsoome added inline comments to D15064: Add st_ino etc to libsa ufs_stat.
Apr 18 2018, 7:23 AM

Apr 16 2018

tsoome closed D15087: loader: cstyle cleanup of command.c.
Apr 16 2018, 2:10 PM
tsoome committed rS332565: loader: cstyle cleanup of command.c.
loader: cstyle cleanup of command.c
Apr 16 2018, 2:10 PM
tsoome added a comment to D15087: loader: cstyle cleanup of command.c.

removed parens.

Apr 16 2018, 1:59 PM
tsoome updated the diff for D15087: loader: cstyle cleanup of command.c.

remove excess parens

Apr 16 2018, 1:58 PM
tsoome created D15087: loader: cstyle cleanup of command.c.
Apr 16 2018, 12:50 PM
tsoome closed D15082: loader: make sure we do not return garbage from help_getnext.
Apr 16 2018, 12:46 PM
tsoome committed rS332560: loader: make sure we do not return garbage from help_getnext.
loader: make sure we do not return garbage from help_getnext
Apr 16 2018, 12:46 PM
tsoome created D15082: loader: make sure we do not return garbage from help_getnext.
Apr 16 2018, 8:55 AM
tsoome committed rS332558: loader: command_errmsg should be const.
loader: command_errmsg should be const
Apr 16 2018, 8:42 AM
tsoome committed rS332557: loader: make sure we use snprintf() in commands.c.
loader: make sure we use snprintf() in commands.c
Apr 16 2018, 8:16 AM
tsoome committed rS332555: loader: provide values in help_getnext().
loader: provide values in help_getnext()
Apr 16 2018, 7:26 AM

Apr 8 2018

tsoome committed rS332275: loader: 332270 did left out stand/i386/loader/loader.rc.
loader: 332270 did left out stand/i386/loader/loader.rc
Apr 8 2018, 1:40 PM
tsoome committed rS332272: loader: 332270 did use wrong path for efi.4th.
loader: 332270 did use wrong path for efi.4th
Apr 8 2018, 11:58 AM
tsoome committed rS332270: loader: include efi.4th only if we do have uefi.
loader: include efi.4th only if we do have uefi
Apr 8 2018, 11:39 AM

Apr 7 2018

tsoome committed rS332173: libsa: name is not used in dirmatch().
libsa: name is not used in dirmatch()
Apr 7 2018, 2:43 PM
tsoome committed rS332170: libsa: cd9660: warning: 'lenskip' may be used uninitialized in this function.
libsa: cd9660: warning: 'lenskip' may be used uninitialized in this function
Apr 7 2018, 2:40 PM

Mar 29 2018

tsoome added a comment to D12732: Revert efipart to use EFI_HANDLEs for partitions.

Still looking quite nice, but there is a bit of competition still, have you checked on https://reviews.freebsd.org/D13784 and how much those 2 updates are conflicting and in which order should we implement them to cause the least amount of issues on integration?

Mar 29 2018, 3:36 PM

Mar 15 2018

tsoome committed rS330970: libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE.
libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE
Mar 15 2018, 5:59 AM
tsoome closed D14696: libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE.
Mar 15 2018, 5:59 AM

Mar 14 2018

tsoome created D14696: libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE.
Mar 14 2018, 7:11 PM
tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 14 2018, 10:11 AM

Mar 13 2018

tsoome committed rS330837: biosdisk.c should not set d_opendata..
biosdisk.c should not set d_opendata.
Mar 13 2018, 9:58 AM

Mar 12 2018

tsoome committed rS330803: e1000g: this statement may fall through.
e1000g: this statement may fall through
Mar 12 2018, 5:06 PM
tsoome closed D14663: e1000g: this statement may fall through.
Mar 12 2018, 5:06 PM
tsoome created D14663: e1000g: this statement may fall through.
Mar 12 2018, 5:52 AM

Mar 10 2018

tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 10 2018, 6:08 AM

Mar 9 2018

tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 9 2018, 5:32 AM

Mar 8 2018

tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 8 2018, 5:33 PM
tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 8 2018, 10:31 AM
tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 8 2018, 9:05 AM

Mar 7 2018

tsoome accepted D13784: Make loader.efi dual boot, step 1.
Mar 7 2018, 4:13 PM

Mar 5 2018

tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 5 2018, 4:35 PM
tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 5 2018, 7:26 AM

Feb 27 2018

tsoome committed rS330056: libsa: replace remaining _write callbacks by null_write.
libsa: replace remaining _write callbacks by null_write
Feb 27 2018, 12:53 PM
tsoome closed D14523: libsa: replace remaining _write callbacks by null_write.
Feb 27 2018, 12:53 PM

Feb 26 2018

tsoome added inline comments to D14523: libsa: replace remaining _write callbacks by null_write.
Feb 26 2018, 5:50 PM
tsoome accepted D14389: libsa: Add MAXWAIT to net for establishing max total timeout.
Feb 26 2018, 4:57 PM
tsoome created D14523: libsa: replace remaining _write callbacks by null_write.
Feb 26 2018, 4:44 PM

Feb 18 2018

tsoome accepted D14415: efi: Do not pad the efi devpath structure.

LGTM

Feb 18 2018, 7:15 AM

Feb 15 2018

tsoome accepted D14373: libsa: Consolidate tftp sendrecv into net.c sendrecv.
Feb 15 2018, 7:02 PM