Page MenuHomeFreeBSD

tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (233 w, 4 d)

Recent Activity

Yesterday

tsoome requested review of D25103: zfsbootcfg: use vfs.root.mountfrom and update nextboot on every vdev.
Tue, Jun 2, 4:18 PM

Wed, May 27

tsoome added inline comments to D24920: zfs: add to bootloader option to rewind the ZFS checkpoint..
Wed, May 27, 8:15 PM

Thu, May 21

tsoome accepted D24920: zfs: add to bootloader option to rewind the ZFS checkpoint..

I can not tell much about lua bits, but the rest seems good. I was starting to think if using ! is complicating things (could just use environment variable - those are accessible via kenv), but I'm all good.

Thu, May 21, 5:40 PM
tsoome added a comment to D24920: zfs: add to bootloader option to rewind the ZFS checkpoint..

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

It will appear only if you will if you have checkpoint in the system.
This is small demo: https://youtu.be/Flor6seU080
Please ignore some debug info I already removed them.
Yea probably it is good to update the handbook as well.
I'm never edited the handbook though.

Thu, May 21, 5:20 PM
tsoome added a comment to D24920: zfs: add to bootloader option to rewind the ZFS checkpoint..

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

Thu, May 21, 6:16 AM

Tue, May 19

tsoome committed rS361266: lz4 hash table does not start zeroed.
lz4 hash table does not start zeroed
Tue, May 19, 7:53 PM

Mon, May 11

tsoome committed rS360891: MFC r360836:.
MFC r360836:
Mon, May 11, 7:01 AM
tsoome committed rS360890: MFC r360836:.
MFC r360836:
Mon, May 11, 6:59 AM

Sat, May 9

tsoome committed rS360836: loader: vdev_read() can corrupt memory.
loader: vdev_read() can corrupt memory
Sat, May 9, 6:25 AM

Mar 30 2020

tsoome committed rS359458: gallant: pound sign (0xa3) is a bit broken. Add extra glyphs..
gallant: pound sign (0xa3) is a bit broken. Add extra glyphs.
Mar 30 2020, 8:07 PM

Mar 29 2020

tsoome committed rS359421: loader: use #elif defined() in stand.h.
loader: use #elif defined() in stand.h
Mar 29 2020, 6:49 AM

Mar 28 2020

tsoome committed rS359411: loader.efi: restore the init and fix the color setup.
loader.efi: restore the init and fix the color setup
Mar 28 2020, 10:38 PM
tsoome committed rS359409: loader: typo did slip into 359408.
loader: typo did slip into 359408
Mar 28 2020, 9:56 PM
tsoome committed rS359408: loader: strdup name strings from dataset walker.
loader: strdup name strings from dataset walker
Mar 28 2020, 9:50 PM
tsoome committed rS359407: loader: add knob to build with user malloc.
loader: add knob to build with user malloc
Mar 28 2020, 9:47 PM

Mar 27 2020

tsoome committed rS359372: loader.efi: conout->QueryMode() can fail to return screen dimensions.
loader.efi: conout->QueryMode() can fail to return screen dimensions
Mar 27 2020, 6:01 PM

Mar 26 2020

tsoome accepted D21733: loader: Fully reset terminal settings, not just colors.

Seems ok.

Mar 26 2020, 8:29 PM

Mar 25 2020

tsoome created D24189: Move font related data structured to sys/font.c and update vtfontcvt.
Mar 25 2020, 9:13 PM

Mar 19 2020

tsoome committed rS359153: loader: remove libsa/crc32.c and use version from zlib.
loader: remove libsa/crc32.c and use version from zlib
Mar 19 2020, 9:05 PM
tsoome closed D24068: loader: remove libsa/crc32.c and use version from zlib.
Mar 19 2020, 9:05 PM
tsoome committed rS359147: loader: misaligned access of dos_partition structure.
loader: misaligned access of dos_partition structure
Mar 19 2020, 5:27 PM
tsoome committed rS359143: MFC r354240, r354252, r358906.
MFC r354240, r354252, r358906
Mar 19 2020, 4:52 PM

Mar 18 2020

tsoome committed rS359099: loader.efi: handle efi_cons_init() failure cases better.
loader.efi: handle efi_cons_init() failure cases better
Mar 18 2020, 10:21 PM

Mar 15 2020

tsoome updated the diff for D24041: loader should consult with ACPI SPCR table for serial console.

feedback from cem.

Mar 15 2020, 6:24 PM

Mar 14 2020

tsoome retitled D24068: loader: remove libsa/crc32.c and use version from zlib from loader: rename crc32 to crc32_libsa to loader: remove libsa/crc32.c and use version from zlib.
Mar 14 2020, 8:42 PM
tsoome updated the diff for D24068: loader: remove libsa/crc32.c and use version from zlib.

drop crc32 from libsa and use version provided by zlib.

Mar 14 2020, 7:36 PM
tsoome added a comment to D24068: loader: remove libsa/crc32.c and use version from zlib.
In D24068#529184, @cem wrote:

I’d suggest using the zlib one unless it takes excessive space (bigger precomputed tables, for ex.).

Mar 14 2020, 4:17 PM
tsoome updated the diff for D24068: loader: remove libsa/crc32.c and use version from zlib.

missed stand/uboot/lib/glue.c

Mar 14 2020, 3:53 PM
tsoome created D24068: loader: remove libsa/crc32.c and use version from zlib.
Mar 14 2020, 3:48 PM
tsoome committed rS358989: loader: add comconsole implementation on top of SIO protocol.
loader: add comconsole implementation on top of SIO protocol
Mar 14 2020, 6:36 AM

Mar 12 2020

tsoome added a comment to D24041: loader should consult with ACPI SPCR table for serial console.

hmm.. The kernel already reads from SPCR (dev/uart/uart_cpu_acpi.c), do we need to feed it duplicate info via comconsole_speed etc.? Or does the i386 legacy bios loader use this info for itself somehow? (I thought env is for the kernel mostly..)

Also, does the setenv("console", "comconsole", 1) mean it's not going to probe vidconsole? (The existence of SPCR should never mean there's no vidconsole ­— I have amd64 and arm64 devices that boot with both an SPCR-defined serial port and a graphical (EFI framebuffer) console at the same time.. )

Wait, that setenv would be overwritten by the ones just after the new biosacpi_detect() call, where the initial_howto & RB_MULTIPLE stuff is.. so is it meant for the case where none of these conditions are true?

Mar 12 2020, 7:39 PM
tsoome added a comment to D24041: loader should consult with ACPI SPCR table for serial console.

hmm.. The kernel already reads from SPCR (dev/uart/uart_cpu_acpi.c), do we need to feed it duplicate info via comconsole_speed etc.? Or does the i386 legacy bios loader use this info for itself somehow? (I thought env is for the kernel mostly..)

Also, does the setenv("console", "comconsole", 1) mean it's not going to probe vidconsole? (The existence of SPCR should never mean there's no vidconsole ­— I have amd64 and arm64 devices that boot with both an SPCR-defined serial port and a graphical (EFI framebuffer) console at the same time.. )

Wait, that setenv would be overwritten by the ones just after the new biosacpi_detect() call, where the initial_howto & RB_MULTIPLE stuff is.. so is it meant for the case where none of these conditions are true?

Mar 12 2020, 7:27 PM
tsoome updated the diff for D24041: loader should consult with ACPI SPCR table for serial console.

feedback from cem.

Mar 12 2020, 6:40 PM
tsoome created D24041: loader should consult with ACPI SPCR table for serial console.
Mar 12 2020, 5:44 PM
tsoome committed rS358906: test if port does exist via using scratch register.
test if port does exist via using scratch register
Mar 12 2020, 6:45 AM

Mar 9 2020

tsoome committed rS358815: gallant is 12x22, not 8x16.
gallant is 12x22, not 8x16
Mar 9 2020, 7:43 PM

Mar 4 2020

tsoome committed rS358632: loader: crc32 is provided by libsa.
loader: crc32 is provided by libsa
Mar 4 2020, 6:38 PM
tsoome accepted D23827: veloader use vectx API for kernel and modules.
Mar 4 2020, 4:28 AM

Feb 26 2020

tsoome committed rS358343: loader: replace zfs_alloc/zfs_free with malloc/free.
loader: replace zfs_alloc/zfs_free with malloc/free
Feb 26 2020, 6:12 PM

Feb 23 2020

tsoome committed rS358260: loader: alloc_pread() should set errno if malloc fails.
loader: alloc_pread() should set errno if malloc fails
Feb 23 2020, 3:21 PM

Feb 20 2020

tsoome committed rS358163: efi_register_handles() is missing NULL pointer check.
efi_register_handles() is missing NULL pointer check
Feb 20 2020, 9:03 AM
tsoome committed rS358162: insert_zfs() is missing NULL pointer check.
insert_zfs() is missing NULL pointer check
Feb 20 2020, 9:00 AM
tsoome committed rS358160: efipart_inithandles() is missing NULL pointer check.
efipart_inithandles() is missing NULL pointer check
Feb 20 2020, 8:57 AM
tsoome committed rS358159: connect_controllers() is missing NULL pointer check.
connect_controllers() is missing NULL pointer check
Feb 20 2020, 8:55 AM
tsoome committed rS358158: efihttp_fs_seek() is missing NULL pointer check.
efihttp_fs_seek() is missing NULL pointer check
Feb 20 2020, 8:53 AM
tsoome committed rS358157: efinet_dev_init() is missing NULL pointer check.
efinet_dev_init() is missing NULL pointer check
Feb 20 2020, 8:48 AM

Feb 10 2020

tsoome accepted D23611: lualoader: disable autoboot on high-level interpreter errors.
Feb 10 2020, 8:09 PM

Feb 5 2020

tsoome committed rS357571: followup on r357497: clean obsolete comment and use shift instead of….
followup on r357497: clean obsolete comment and use shift instead of…
Feb 5 2020, 1:08 PM
tsoome committed rS357569: zfsboot: vdev_read_pad2 does allocate buffer with wrong size.
zfsboot: vdev_read_pad2 does allocate buffer with wrong size
Feb 5 2020, 11:02 AM
tsoome committed rS357567: vdev_read_pad2: freeing wrong pointer.
vdev_read_pad2: freeing wrong pointer
Feb 5 2020, 5:43 AM

Feb 4 2020

tsoome committed rS357497: loader: rewrite zfs reader zap code to use malloc.
loader: rewrite zfs reader zap code to use malloc
Feb 4 2020, 7:38 AM
tsoome closed D23433: loader: rewrite zfs reader zap code to use malloc.
Feb 4 2020, 7:38 AM
tsoome committed rS357496: MFC r357442:.
MFC r357442:
Feb 4 2020, 7:19 AM
tsoome committed rS357495: MFC r357442:.
MFC r357442:
Feb 4 2020, 7:15 AM

Feb 3 2020

tsoome updated the diff for D23433: loader: rewrite zfs reader zap code to use malloc.

Suggestions from delphij, thanks!

Feb 3 2020, 5:51 PM
tsoome committed rS357442: loader: bc_add can not use any other probes than ah=0x4b.
loader: bc_add can not use any other probes than ah=0x4b
Feb 3 2020, 11:33 AM

Feb 2 2020

tsoome accepted D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Feb 2 2020, 7:17 AM

Jan 31 2020

tsoome updated the diff for D23433: loader: rewrite zfs reader zap code to use malloc.

replace if chain by switch. Print out entire zap_block_type.

Jan 31 2020, 4:12 PM

Jan 30 2020

tsoome created D23433: loader: rewrite zfs reader zap code to use malloc.
Jan 30 2020, 8:33 PM
tsoome accepted D23411: stand: properly declare build dependencies or .WAIT, start building in parallel.
Jan 30 2020, 6:03 AM

Jan 13 2020

tsoome added a reverting change for rS356693: loader: allocate properly aligned buffer for network packet: rS356700: Backout 356693. The libsa malloc does provide necessary alignment and.
Jan 13 2020, 8:02 PM
tsoome committed rS356700: Backout 356693. The libsa malloc does provide necessary alignment and.
Backout 356693. The libsa malloc does provide necessary alignment and
Jan 13 2020, 8:02 PM
tsoome committed rS356693: loader: allocate properly aligned buffer for network packet.
loader: allocate properly aligned buffer for network packet
Jan 13 2020, 6:23 PM

Jan 9 2020

tsoome committed rS356572: MFC r356570:.
MFC r356570:
Jan 9 2020, 9:41 PM
tsoome committed rS356571: MFC r356570:.
MFC r356570:
Jan 9 2020, 9:38 PM
tsoome committed rS356570: loader: bioscd probe can get sector size 0.
loader: bioscd probe can get sector size 0
Jan 9 2020, 9:21 PM

Jan 6 2020

tsoome committed rS356424: loader: update zfsimpl.c from illumos review suggestions.
loader: update zfsimpl.c from illumos review suggestions
Jan 6 2020, 7:35 PM

Dec 29 2019

tsoome accepted D22951: "help" loader command broken.
Dec 29 2019, 9:39 AM
tsoome added inline comments to D22951: "help" loader command broken.
Dec 29 2019, 8:10 AM

Dec 22 2019

tsoome committed rS356027: MFC r355844:.
MFC r355844:
Dec 22 2019, 8:37 PM
tsoome committed rS356003: MFC r354283, r354323, r354363, r354364, r354593, r355773, r355786:.
MFC r354283, r354323, r354363, r354364, r354593, r355773, r355786:
Dec 22 2019, 8:22 AM

Dec 20 2019

tsoome committed rS355929: MFC r355702:.
MFC r355702:
Dec 20 2019, 8:16 AM
tsoome committed rS355928: MFC r355703:.
MFC r355703:
Dec 20 2019, 8:13 AM
tsoome committed rS355927: MFC r355713:.
MFC r355713:
Dec 20 2019, 7:40 AM

Dec 17 2019

tsoome committed rS355844: loader.efi: efi_readkey_ex needs to key despite the shift status or toggle….
loader.efi: efi_readkey_ex needs to key despite the shift status or toggle…
Dec 17 2019, 8:30 AM

Dec 15 2019

tsoome committed rS355786: loader: rewrite zfs vdev initialization.
loader: rewrite zfs vdev initialization
Dec 15 2019, 9:52 PM
tsoome committed rS355773: loader: zfsimpl.c cstyle cleanup.
loader: zfsimpl.c cstyle cleanup
Dec 15 2019, 2:10 PM

Dec 13 2019

tsoome committed rS355713: loader: cd9660_open() warn: is 'buf' large enough for 'struct….
loader: cd9660_open() warn: is 'buf' large enough for 'struct…
Dec 13 2019, 12:36 PM
tsoome committed rS355703: loader: clean up devopen and devclose a bit.
loader: clean up devopen and devclose a bit
Dec 13 2019, 8:42 AM
tsoome committed rS355702: loader: vdisk dereference after free.
loader: vdisk dereference after free
Dec 13 2019, 8:20 AM

Dec 9 2019

tsoome committed rS355571: MFC r355347:.
MFC r355347:
Dec 9 2019, 9:10 PM
tsoome committed rS355560: MFC r355224, r355308, r355392:.
MFC r355224, r355308, r355392:
Dec 9 2019, 4:21 PM

Dec 6 2019

tsoome added a comment to D22139: loader.efi: implement comconsole with UEFI SerialIO protocol.

Would it be possible to also support memory-mapped UART this way? Intel >=Skylake and all aarch64 systems use mmio.

I've added an SPCR table to my Kaby Lake laptop to configure the UART, but it would be nice if it could auto configure without SPCR.

Dec 6 2019, 12:00 PM
tsoome updated the diff for D22139: loader.efi: implement comconsole with UEFI SerialIO protocol.

Rename comconsole.c to efiserialio.c to avoid issues with libi386/comconsole.c.
On x86, use libi386/comconsole because we still can not ensure the proper order
of serial ports and there is known issue on some systems with input on serial.

Dec 6 2019, 10:07 AM
tsoome committed rS355441: loader.efi: print ImageBase so we know where we are.
loader.efi: print ImageBase so we know where we are
Dec 6 2019, 9:50 AM
tsoome accepted D22663: Warn against use of whole disks in boot, mirror, and RAID-Z zpools..
Dec 6 2019, 9:40 AM

Dec 4 2019

tsoome committed rS355392: loader: clean up efipart filter expressions.
loader: clean up efipart filter expressions
Dec 4 2019, 4:41 PM

Dec 3 2019

tsoome committed rS355347: loader: ReadKeyStrokeEx may return partial keystrokes.
loader: ReadKeyStrokeEx may return partial keystrokes
Dec 3 2019, 6:36 PM

Dec 2 2019

tsoome committed rS355308: loader.efi: fix cd boot for cisco C220M3.
loader.efi: fix cd boot for cisco C220M3
Dec 2 2019, 9:09 PM
tsoome committed rS355292: MFC r355291:.
MFC r355291:
Dec 2 2019, 3:44 PM
tsoome committed rS355291: libzpool: use CFLAGS.lz4.c to build lz4.o and lz4.pico.
libzpool: use CFLAGS.lz4.c to build lz4.o and lz4.pico
Dec 2 2019, 3:37 PM
tsoome committed rS355290: libzpool: lz4.c build needs CFLAGS.lz4.c.
libzpool: lz4.c build needs CFLAGS.lz4.c
Dec 2 2019, 3:28 PM
tsoome committed rS355286: MFC r354267:.
MFC r354267:
Dec 2 2019, 12:27 PM
tsoome committed rS355285: MFC r354253, r354254, r354264, r354265.
MFC r354253, r354254, r354264, r354265
Dec 2 2019, 11:44 AM
tsoome committed rS355284: r353501 did mimerge r350654 boot1 and gptboot were left out.
r353501 did mimerge r350654 boot1 and gptboot were left out
Dec 2 2019, 9:57 AM

Nov 30 2019

tsoome committed rS355224: loader.efi: efipart needs better support detecting nested partitions.
loader.efi: efipart needs better support detecting nested partitions
Nov 30 2019, 9:11 AM
tsoome closed D22553: loader.efi: efipart needs better support detecting nested partitions.
Nov 30 2019, 9:11 AM
tsoome updated the summary of D22553: loader.efi: efipart needs better support detecting nested partitions.
Nov 30 2019, 9:08 AM

Nov 29 2019

tsoome updated the diff for D22553: loader.efi: efipart needs better support detecting nested partitions.

really check the device node type. Free unused devpaths by calling
efi_close_devpath().

Nov 29 2019, 10:59 AM

Nov 28 2019

tsoome updated the diff for D22553: loader.efi: efipart needs better support detecting nested partitions.

need to handle usb luns

Nov 28 2019, 1:37 PM