Page MenuHomeFreeBSD

tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (287 w, 3 d)

Recent Activity

Sat, Jun 5

tsoome accepted D30650: nextboot: Improve the shell code used to figure out the zpool name.
Sat, Jun 5, 8:32 AM

Sun, May 23

tsoome committed R10:3dc9f92a0d3d: loader: gfx_fb_drawrect should use GfxFbBltVideoFill (authored by tsoome).
loader: gfx_fb_drawrect should use GfxFbBltVideoFill
Sun, May 23, 8:24 AM

Sun, May 16

tsoome committed R10:5365af662c78: loader: gfx_fb_drawrect should use GfxFbBltVideoFill (authored by tsoome).
loader: gfx_fb_drawrect should use GfxFbBltVideoFill
Sun, May 16, 9:14 AM

May 12 2021

tsoome accepted D30227: Update the EFI timer to be called once a second.
May 12 2021, 4:14 PM

Apr 28 2021

tsoome committed R10:eabfffcb4c14: loader: do not output empty menu title (authored by tsoome).
loader: do not output empty menu title
Apr 28 2021, 9:37 AM

Apr 21 2021

tsoome committed R10:4ba91fa0736b: loader: do not output empty menu title (authored by tsoome).
loader: do not output empty menu title
Apr 21 2021, 11:51 AM

Apr 10 2021

tsoome committed R10:3056bbfc2cb2: loader: we should support pools without features (authored by tsoome).
loader: we should support pools without features
Apr 10 2021, 8:38 AM

Apr 4 2021

tsoome committed R10:d019c774e906: loader: insert spaces around menu title (authored by tsoome).
loader: insert spaces around menu title
Apr 4 2021, 8:25 AM
tsoome committed R10:d36341f7b8dd: loader: we should support pools without features (authored by tsoome).
loader: we should support pools without features
Apr 4 2021, 8:25 AM

Apr 1 2021

tsoome added a comment to D29512: Loader: support booting OS from memory disk (MD).

Since md case is depending on build options and is not part of generic build, this feature should not generate problems for general public. I do agree, it should get documented. Do we want to provide feature parity with i386 tree (BIOS loader)?

Thanks Toomas. I suspect that this feature is rarely used in legacy BIOS so did not add it in i386 tree. But I'm fine if you think it's worth to be added.

Apr 1 2021, 4:49 PM
tsoome accepted D29512: Loader: support booting OS from memory disk (MD).

Since md case is depending on build options and is not part of generic build, this feature should not generate problems for general public. I do agree, it should get documented. Do we want to provide feature parity with i386 tree (BIOS loader)?

Apr 1 2021, 9:38 AM

Mar 24 2021

tsoome accepted D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
Mar 24 2021, 8:30 PM

Mar 23 2021

tsoome committed R10:62ffcaab8f3c: loader: insert spaces around menu title (authored by tsoome).
loader: insert spaces around menu title
Mar 23 2021, 7:34 AM

Mar 16 2021

tsoome added a comment to D29020: efifb,vbefb: implement vd_fini.
In D29020#655703, @manu wrote:

@tsoome will you commit?

I planned to do it last weekend but this was delayed for this week. I'll probably do that tomorow.

Mar 16 2021, 7:01 AM

Mar 9 2021

tsoome committed R10:1ceb3c6c3bdb: loader: cursor off should restore display content (authored by tsoome).
loader: cursor off should restore display content
Mar 9 2021, 2:31 PM
tsoome accepted D29020: efifb,vbefb: implement vd_fini.
Mar 9 2021, 12:38 PM
tsoome committed R10:38fe00d43dcc: loader: cursor off should restore display content (authored by tsoome).
loader: cursor off should restore display content
Mar 9 2021, 7:33 AM

Mar 8 2021

tsoome added a comment to D29126: bhyve: address-of-packed-member warnings.

I'm having trouble matching pci_nvme.c:903 to current, stable/12 or stable/13. Which branch is this? I'm curious to see why the compiler doesn't like this instance as (naively) everything should be nicely aligned.

Mar 8 2021, 4:18 PM
tsoome updated the summary of D29126: bhyve: address-of-packed-member warnings.
Mar 8 2021, 4:18 PM
tsoome updated the summary of D29126: bhyve: address-of-packed-member warnings.
Mar 8 2021, 4:16 PM
tsoome added a comment to D29126: bhyve: address-of-packed-member warnings.

I'm happy to help out on the NVMe part but don't see this warning while building x86_64 on current. Can you point me in the direction of how to reproduce this?

Mar 8 2021, 3:33 PM
tsoome requested review of D29126: bhyve: address-of-packed-member warnings.
Mar 8 2021, 10:55 AM

Mar 6 2021

tsoome committed R10:d708f23ebb06: loader: cursor off should restore display content (authored by tsoome).
loader: cursor off should restore display content
Mar 6 2021, 10:24 AM
tsoome committed R10:bafab32168c8: loader_4th: brand image is aligned right (authored by tsoome).
loader_4th: brand image is aligned right
Mar 6 2021, 9:38 AM
tsoome committed R10:99e1b2d79868: loader_4th: brand image is aligned right (authored by tsoome).
loader_4th: brand image is aligned right
Mar 6 2021, 9:08 AM
tsoome committed R10:6a3095aa6d03: loader_4th: brand image is aligned right (authored by tsoome).
loader_4th: brand image is aligned right
Mar 6 2021, 9:01 AM

Mar 5 2021

tsoome committed R10:acd98bcb2821: loader: use display pixel density for font autoselection (authored by tsoome).
loader: use display pixel density for font autoselection
Mar 5 2021, 7:38 PM

Mar 4 2021

tsoome committed R10:209247b9614f: loader: use display pixel density for font autoselection (authored by tsoome).
loader: use display pixel density for font autoselection
Mar 4 2021, 9:01 PM

Mar 2 2021

tsoome added a comment to D29020: efifb,vbefb: implement vd_fini.

You want to add the same to vbefb.

Mar 2 2021, 9:11 PM

Mar 1 2021

tsoome committed R10:05e4a34e4360: loader: autoload_font will hung loader when there is no local console (authored by tsoome).
loader: autoload_font will hung loader when there is no local console
Mar 1 2021, 10:55 AM

Feb 27 2021

tsoome committed R10:becaac3972f1: loader: use display pixel density for font autoselection (authored by tsoome).
loader: use display pixel density for font autoselection
Feb 27 2021, 9:28 AM
tsoome closed D28849: loader: use display pixel density for font autoselection.
Feb 27 2021, 9:28 AM

Feb 26 2021

tsoome accepted D28936: Split out the loader efifb setup to a new function.
Feb 26 2021, 2:10 PM

Feb 25 2021

tsoome committed R10:e680f3c0bd2b: loader: autoload_font will hung loader when there is no local console (authored by tsoome).
loader: autoload_font will hung loader when there is no local console
Feb 25 2021, 4:06 PM

Feb 24 2021

tsoome committed R10:6daafec20838: Fix loader detection of vbefb support on !amd64 (authored by dim).
Fix loader detection of vbefb support on !amd64
Feb 24 2021, 6:41 PM
tsoome committed R10:b3e822993503: loader_lua: consider userboot console as serial (authored by tsoome).
loader_lua: consider userboot console as serial
Feb 24 2021, 6:41 PM
tsoome committed R10:8305d6906fe9: loader: unload command should reset tg_kernel_supported in gfx_state (authored by tsoome).
loader: unload command should reset tg_kernel_supported in gfx_state
Feb 24 2021, 6:40 PM
tsoome committed R10:ce132d4aab67: loader: start kernel in text mode when there is no vbefb vt driver (authored by tsoome).
loader: start kernel in text mode when there is no vbefb vt driver
Feb 24 2021, 6:40 PM
tsoome updated the diff for D28849: loader: use display pixel density for font autoselection.

use MAX().

Feb 24 2021, 10:10 AM

Feb 23 2021

tsoome accepted D28897: Mount ESP on newly-installed systems.
Feb 23 2021, 8:34 PM
tsoome accepted D28897: Mount ESP on newly-installed systems.
Feb 23 2021, 4:00 PM
tsoome added a comment to D28897: Mount ESP on newly-installed systems.

There is this thing....

Feb 23 2021, 3:13 PM
tsoome updated the diff for D28849: loader: use display pixel density for font autoselection.

make it actually to work...

Feb 23 2021, 10:46 AM
tsoome committed R10:debcf835b16b: loader: unload command should reset tg_kernel_supported in gfx_state (authored by tsoome).
loader: unload command should reset tg_kernel_supported in gfx_state
Feb 23 2021, 7:29 AM
tsoome committed R10:1714029b8a9c: Fix loader detection of vbefb support on !amd64 (authored by dim).
Fix loader detection of vbefb support on !amd64
Feb 23 2021, 7:29 AM
tsoome committed R10:b7f1582221f5: loader: start kernel in text mode when there is no vbefb vt driver (authored by tsoome).
loader: start kernel in text mode when there is no vbefb vt driver
Feb 23 2021, 7:28 AM

Feb 22 2021

tsoome committed R10:57d6e82d1f69: loader_lua: consider userboot console as serial (authored by tsoome).
loader_lua: consider userboot console as serial
Feb 22 2021, 10:05 PM
tsoome committed R10:61c50cbc096d: loader: autoload_font will hung loader when there is no local console (authored by tsoome).
loader: autoload_font will hung loader when there is no local console
Feb 22 2021, 9:42 PM
tsoome updated the diff for D28849: loader: use display pixel density for font autoselection.

use gop_handle, not gop protocol

Feb 22 2021, 9:42 AM
tsoome abandoned D28851: loader: use display pixel density for font autoselection.
Feb 22 2021, 9:41 AM
tsoome requested review of D28851: loader: use display pixel density for font autoselection.
Feb 22 2021, 9:37 AM
tsoome requested review of D28849: loader: use display pixel density for font autoselection.
Feb 22 2021, 9:15 AM

Feb 18 2021

tsoome committed R10:eb7d18ff0ab5: loader: do not autoselect smaller font than 8x16 with high res display (authored by tsoome).
loader: do not autoselect smaller font than 8x16 with high res display
Feb 18 2021, 10:04 PM
tsoome committed R10:d560d01b02a1: loader: remove BORDER_PIXELS (authored by tsoome).
loader: remove BORDER_PIXELS
Feb 18 2021, 10:04 PM
tsoome committed R10:03c31d3ca31a: vt: terminal size can grow too big with small font (authored by tsoome).
vt: terminal size can grow too big with small font
Feb 18 2021, 10:02 PM

Feb 17 2021

tsoome accepted D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Feb 17 2021, 9:44 PM
tsoome added a comment to D28707: Fix attachment of IPMI driver on ARM64.
In D28707#643373, @manu wrote:

@allanjude these originated as a number of commits, right? Does it make sense to start committing earlier patches that have been reviewed (e.g. stand bits) and rebase this review?

stand patches can't go in without the kernel ones.
If we find a smbios v3 table we don't set the kenv of the v2.1 one so kernel won't work.

Feb 17 2021, 6:47 PM
tsoome added a comment to D28707: Fix attachment of IPMI driver on ARM64.

The loader part seems OK for me (I did the SMB3 support in illumos loader), the kernel part seems to make sense, but I am not familiar with those bits:)

Feb 17 2021, 4:14 PM

Feb 16 2021

tsoome committed R10:d9dd77252cab: loader: do not autoselect smaller font than 8x16 with high res display (authored by tsoome).
loader: do not autoselect smaller font than 8x16 with high res display
Feb 16 2021, 10:44 AM
tsoome committed R10:b72a2e3ffa3a: loader: remove BORDER_PIXELS (authored by tsoome).
loader: remove BORDER_PIXELS
Feb 16 2021, 10:43 AM
tsoome accepted D28497: stand/multiboot2: add support for booting a Xen dom0 in UEFI mode.
Feb 16 2021, 10:35 AM

Feb 15 2021

tsoome committed R10:76702e90d007: vt: terminal size can grow too big with small font (authored by tsoome).
vt: terminal size can grow too big with small font
Feb 15 2021, 8:22 AM

Feb 14 2021

tsoome committed R10:5d8c062fe3ee: loader_lua: consider userboot console as serial (authored by tsoome).
loader_lua: consider userboot console as serial
Feb 14 2021, 9:17 PM

Feb 9 2021

tsoome committed R10:a26f73585831: loader: do not autoselect smaller font than 8x16 with high res display (authored by tsoome).
loader: do not autoselect smaller font than 8x16 with high res display
Feb 9 2021, 11:47 AM
tsoome committed R10:96bef2053a87: loader: remove BORDER_PIXELS (authored by tsoome).
loader: remove BORDER_PIXELS
Feb 9 2021, 11:47 AM

Feb 8 2021

tsoome committed R10:32bf05ad89aa: vt: terminal size can grow too big with small font (authored by tsoome).
vt: terminal size can grow too big with small font
Feb 8 2021, 4:02 PM

Feb 5 2021

tsoome added a comment to D28497: stand/multiboot2: add support for booting a Xen dom0 in UEFI mode.

There are few concerns... not yet complete list as it is getting late for me, but hopefully it will still be helpful.

Feb 5 2021, 8:52 PM
tsoome accepted D28495: stand/efi: allow not exiting boot services.
Feb 5 2021, 8:11 PM

Feb 4 2021

tsoome committed R10:0c839497c174: loader.efi: There are systems without ConOut, also use ConOutDev (authored by tsoome).
loader.efi: There are systems without ConOut, also use ConOutDev
Feb 4 2021, 9:35 PM
tsoome committed R10:2bd4ff2d8911: loader.efi: There are systems without ConOut, also use ConOutDev (authored by tsoome).
loader.efi: There are systems without ConOut, also use ConOutDev
Feb 4 2021, 9:30 PM

Feb 2 2021

tsoome committed R10:a66467dcfd65: userboot: provide stub gfx functions (authored by tsoome).
userboot: provide stub gfx functions
Feb 2 2021, 1:02 PM
tsoome committed R10:b79f2bc6c5c7: vt: panic while changing vt font (authored by tsoome).
vt: panic while changing vt font
Feb 2 2021, 12:57 PM
tsoome committed R10:0d381d1b92e5: loader: create built in font from bold font face (authored by tsoome).
loader: create built in font from bold font face
Feb 2 2021, 12:41 PM

Feb 1 2021

tsoome committed R10:1912d2b15e6d: vt: parse_font_info_static should set refcount, not parse_font_info (authored by tsoome).
vt: parse_font_info_static should set refcount, not parse_font_info
Feb 1 2021, 10:35 PM

Jan 30 2021

tsoome committed R10:d51cc252a062: userboot: provide stub gfx functions (authored by tsoome).
userboot: provide stub gfx functions
Jan 30 2021, 7:21 PM

Jan 29 2021

tsoome accepted D28412: stand/amd64: remove unused addr parameter from bi_load64.
Jan 29 2021, 8:24 PM
tsoome accepted D28411: stand/multiboot: adjust the protocol between loader and kernel.

Seems to be OK.

Jan 29 2021, 12:41 PM
tsoome added inline comments to D28411: stand/multiboot: adjust the protocol between loader and kernel.
Jan 29 2021, 12:08 PM

Jan 28 2021

tsoome added a comment to D24041: loader should consult with ACPI SPCR table for serial console.
In D24041#635435, @imp wrote:

My big concern with this is that there is no override provision. It is good we set it early, but it makes it harder to say you want a video console instead...

Jan 28 2021, 11:14 PM
tsoome updated the diff for D24041: loader should consult with ACPI SPCR table for serial console.

update zfsboot (gptzfsboot) to check SPCR.

Jan 28 2021, 10:38 PM
tsoome committed R10:9b388ac30375: loader: unload command should reset tg_kernel_supported in gfx_state (authored by tsoome).
loader: unload command should reset tg_kernel_supported in gfx_state
Jan 28 2021, 7:53 AM

Jan 26 2021

tsoome committed R10:6c7a932d0b8b: loader: start kernel in text mode when there is no vbefb vt driver (authored by tsoome).
loader: start kernel in text mode when there is no vbefb vt driver
Jan 26 2021, 11:09 PM
tsoome committed R10:93ebd6307efe: vt: panic while changing vt font (authored by tsoome).
vt: panic while changing vt font
Jan 26 2021, 11:09 PM

Jan 23 2021

tsoome committed R10:6c789c55c4ba: loader: create built in font from bold font face (authored by tsoome).
loader: create built in font from bold font face
Jan 23 2021, 8:57 AM

Jan 19 2021

tsoome committed R10:4bbfe4bf08d6: loader: comment on rgb_to_color_index() (authored by tsoome).
loader: comment on rgb_to_color_index()
Jan 19 2021, 8:17 PM
tsoome committed R10:52e3a7300d81: loader: handle malloc failures in vbe_init, use consistent naming (authored by tsoome).
loader: handle malloc failures in vbe_init, use consistent naming
Jan 19 2021, 7:59 PM

Jan 17 2021

tsoome committed R10:1caed70c6264: loader: update gfx module (authored by tsoome).
loader: update gfx module
Jan 17 2021, 10:16 PM
tsoome committed R10:52ec89a93c79: loader.efi: commands gop, uga and autoresize should use cached data (authored by tsoome).
loader.efi: commands gop, uga and autoresize should use cached data
Jan 17 2021, 1:35 PM
tsoome committed R10:9adce1aedd2e: loader.efi: variable 'hlist' is uninitialized (authored by tsoome).
loader.efi: variable 'hlist' is uninitialized
Jan 17 2021, 11:48 AM
tsoome committed R10:fb3a792a8827: loader.efi: unused variable 'mode' (authored by tsoome).
loader.efi: unused variable 'mode'
Jan 17 2021, 11:46 AM

Jan 16 2021

tsoome committed R10:ef698fabe428: loader.efi: handle multiple gop instances (authored by tsoome).
loader.efi: handle multiple gop instances
Jan 16 2021, 11:30 PM
tsoome committed R10:3ddf7eade0e9: loader.efi: Use Blt with gop as default (authored by tsoome).
loader.efi: Use Blt with gop as default
Jan 16 2021, 7:15 PM
tsoome committed R10:ad1ebbe5cea8: loader: create local copy of mode list provided by vbeinfoblock (authored by tsoome).
loader: create local copy of mode list provided by vbeinfoblock
Jan 16 2021, 8:24 AM

Jan 15 2021

tsoome committed R10:0974bfa3a8da: loader: do not update palette in text mode (real fix) (authored by tsoome).
loader: do not update palette in text mode (real fix)
Jan 15 2021, 11:47 AM

Jan 13 2021

tsoome added a reverting change for R10:8b1839548750: loader.efi: disable workaround for serial console on non-x86: R10:fdaf9cb942d9: Revert "loader.efi: disable workaround for serial console on non-x86".
Jan 13 2021, 6:20 PM
tsoome committed R10:fdaf9cb942d9: Revert "loader.efi: disable workaround for serial console on non-x86" (authored by tsoome).
Revert "loader.efi: disable workaround for serial console on non-x86"
Jan 13 2021, 6:20 PM
tsoome committed R10:98c15d4dc284: loader.efi: initial terminal size should base on UEFI terminal size (authored by tsoome).
loader.efi: initial terminal size should base on UEFI terminal size
Jan 13 2021, 5:09 PM

Jan 12 2021

tsoome committed R10:8b1839548750: loader.efi: disable workaround for serial console on non-x86 (authored by tsoome).
loader.efi: disable workaround for serial console on non-x86
Jan 12 2021, 11:12 AM
tsoome committed R10:50180d2b52cc: loader.efi: reworked framebuffer setup (authored by tsoome).
loader.efi: reworked framebuffer setup
Jan 12 2021, 11:09 AM

Jan 11 2021

tsoome committed R10:2c52512caf6e: pnglite: should use ntohl (authored by tsoome).
pnglite: should use ntohl
Jan 11 2021, 10:59 PM