tsoome (Toomas Soome)
User

Projects

User Details

User Since
Dec 11 2015, 11:12 PM (123 w, 8 h)

Recent Activity

Wed, Apr 18

tsoome added inline comments to D15064: Add st_ino etc to libsa ufs_stat.
Wed, Apr 18, 7:50 PM
tsoome added inline comments to D15064: Add st_ino etc to libsa ufs_stat.
Wed, Apr 18, 7:23 AM

Mon, Apr 16

tsoome closed D15087: loader: cstyle cleanup of command.c.
Mon, Apr 16, 2:10 PM
tsoome committed rS332565: loader: cstyle cleanup of command.c.
loader: cstyle cleanup of command.c
Mon, Apr 16, 2:10 PM
tsoome added a comment to D15087: loader: cstyle cleanup of command.c.

removed parens.

Mon, Apr 16, 1:59 PM
tsoome updated the diff for D15087: loader: cstyle cleanup of command.c.

remove excess parens

Mon, Apr 16, 1:58 PM
tsoome created D15087: loader: cstyle cleanup of command.c.
Mon, Apr 16, 12:50 PM
tsoome closed D15082: loader: make sure we do not return garbage from help_getnext.
Mon, Apr 16, 12:46 PM
tsoome committed rS332560: loader: make sure we do not return garbage from help_getnext.
loader: make sure we do not return garbage from help_getnext
Mon, Apr 16, 12:46 PM
tsoome created D15082: loader: make sure we do not return garbage from help_getnext.
Mon, Apr 16, 8:55 AM
tsoome committed rS332558: loader: command_errmsg should be const.
loader: command_errmsg should be const
Mon, Apr 16, 8:42 AM
tsoome committed rS332557: loader: make sure we use snprintf() in commands.c.
loader: make sure we use snprintf() in commands.c
Mon, Apr 16, 8:16 AM
tsoome committed rS332555: loader: provide values in help_getnext().
loader: provide values in help_getnext()
Mon, Apr 16, 7:26 AM

Sun, Apr 8

tsoome committed rS332275: loader: 332270 did left out stand/i386/loader/loader.rc.
loader: 332270 did left out stand/i386/loader/loader.rc
Sun, Apr 8, 1:40 PM
tsoome committed rS332272: loader: 332270 did use wrong path for efi.4th.
loader: 332270 did use wrong path for efi.4th
Sun, Apr 8, 11:58 AM
tsoome committed rS332270: loader: include efi.4th only if we do have uefi.
loader: include efi.4th only if we do have uefi
Sun, Apr 8, 11:39 AM

Sat, Apr 7

tsoome committed rS332173: libsa: name is not used in dirmatch().
libsa: name is not used in dirmatch()
Sat, Apr 7, 2:43 PM
tsoome committed rS332170: libsa: cd9660: warning: 'lenskip' may be used uninitialized in this function.
libsa: cd9660: warning: 'lenskip' may be used uninitialized in this function
Sat, Apr 7, 2:40 PM

Thu, Mar 29

tsoome added a comment to D12732: Revert efipart to use EFI_HANDLEs for partitions.

Still looking quite nice, but there is a bit of competition still, have you checked on https://reviews.freebsd.org/D13784 and how much those 2 updates are conflicting and in which order should we implement them to cause the least amount of issues on integration?

Thu, Mar 29, 3:36 PM

Mar 15 2018

tsoome committed rS330970: libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE.
libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE
Mar 15 2018, 5:59 AM
tsoome closed D14696: libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE.
Mar 15 2018, 5:59 AM

Mar 14 2018

tsoome created D14696: libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE.
Mar 14 2018, 7:11 PM
tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 14 2018, 10:11 AM

Mar 13 2018

tsoome committed rS330837: biosdisk.c should not set d_opendata..
biosdisk.c should not set d_opendata.
Mar 13 2018, 9:58 AM

Mar 12 2018

tsoome committed rS330803: e1000g: this statement may fall through.
e1000g: this statement may fall through
Mar 12 2018, 5:06 PM
tsoome closed D14663: e1000g: this statement may fall through.
Mar 12 2018, 5:06 PM
tsoome created D14663: e1000g: this statement may fall through.
Mar 12 2018, 5:52 AM

Mar 10 2018

tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 10 2018, 6:08 AM

Mar 9 2018

tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 9 2018, 5:32 AM

Mar 8 2018

tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 8 2018, 5:33 PM
tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 8 2018, 10:31 AM
tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 8 2018, 9:05 AM

Mar 7 2018

tsoome accepted D13784: Make loader.efi dual boot, step 1.
Mar 7 2018, 4:13 PM

Mar 5 2018

tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 5 2018, 4:35 PM
tsoome added inline comments to D13784: Make loader.efi dual boot, step 1.
Mar 5 2018, 7:26 AM

Feb 27 2018

tsoome committed rS330056: libsa: replace remaining _write callbacks by null_write.
libsa: replace remaining _write callbacks by null_write
Feb 27 2018, 12:53 PM
tsoome closed D14523: libsa: replace remaining _write callbacks by null_write.
Feb 27 2018, 12:53 PM

Feb 26 2018

tsoome added inline comments to D14523: libsa: replace remaining _write callbacks by null_write.
Feb 26 2018, 5:50 PM
tsoome accepted D14389: libsa: Add MAXWAIT to net for establishing max total timeout.
Feb 26 2018, 4:57 PM
tsoome created D14523: libsa: replace remaining _write callbacks by null_write.
Feb 26 2018, 4:44 PM

Feb 18 2018

tsoome accepted D14415: efi: Do not pad the efi devpath structure.

LGTM

Feb 18 2018, 7:15 AM

Feb 15 2018

tsoome accepted D14373: libsa: Consolidate tftp sendrecv into net.c sendrecv.
Feb 15 2018, 7:02 PM

Feb 14 2018

tsoome accepted D14350: libsa: Fix IP recv timeout.
Feb 14 2018, 6:16 AM
tsoome added a comment to D14350: libsa: Fix IP recv timeout.

For what it's worth, I would almost like to do something more like this: https://people.freebsd.org/~kevans/stand-ip.diff

It's a lot more invasive, but it gets rid sendrecv_tftp and consolidates MINTMO/MAXTMO timeout logic into one spot that everything honors.

Feb 14 2018, 6:16 AM

Feb 13 2018

tsoome accepted D14334: efi: Only scan the BLKIO MEDIA once.

shoot:)

Feb 13 2018, 6:36 AM

Feb 12 2018

tsoome added inline comments to D14334: efi: Only scan the BLKIO MEDIA once.
Feb 12 2018, 8:29 PM
tsoome accepted D14332: libsa: Allow a tftp retry if a sendrecv returns ETIMEDOUT.

nice catch.

Feb 12 2018, 6:36 PM

Feb 10 2018

tsoome added a comment to D14295: Add Lua as a scripting langauge to /boot/loader.

As an note, please install scripts into /boot/lua - so we wont pollute the whole /boot.

Feb 10 2018, 9:48 AM
tsoome accepted D14295: Add Lua as a scripting langauge to /boot/loader.

Im sure there is still much to do, but go for it.

Feb 10 2018, 9:39 AM

Jan 16 2018

tsoome committed rS328061: utf8_to_ucs2() should check for malloc failure.
utf8_to_ucs2() should check for malloc failure
Jan 16 2018, 8:36 PM
tsoome closed D13933: utf8_to_ucs2() should check for malloc failure.
Jan 16 2018, 8:36 PM
tsoome created D13933: utf8_to_ucs2() should check for malloc failure.
Jan 16 2018, 11:48 AM

Jan 15 2018

tsoome accepted D13917: When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory..
Jan 15 2018, 8:02 PM
tsoome added inline comments to D13918: Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string..
Jan 15 2018, 7:58 PM

Dec 19 2017

tsoome accepted D13541: [efi/boot1] Scan all display modes rather than sequential try-fail way.
Dec 19 2017, 8:53 AM

Dec 14 2017

tsoome committed rS326854: libefi: make efichar.h more usable in stand code.
libefi: make efichar.h more usable in stand code
Dec 14 2017, 4:42 PM
tsoome closed D13488: libefi: make efichar.h more usable in stand code.
Dec 14 2017, 4:42 PM
tsoome created D13488: libefi: make efichar.h more usable in stand code.
Dec 14 2017, 8:34 AM

Dec 6 2017

tsoome committed rS326616: dhcp_try_rfc1048() is not used any more.
dhcp_try_rfc1048() is not used any more
Dec 6 2017, 6:50 AM
tsoome closed D13382: dhcp_try_rfc1048() is not used any more.
Dec 6 2017, 6:50 AM

Dec 5 2017

tsoome created D13382: dhcp_try_rfc1048() is not used any more.
Dec 5 2017, 9:20 PM

Dec 4 2017

tsoome committed rS326509: loader.efi: add note about iPXE into the efipart.c.
loader.efi: add note about iPXE into the efipart.c
Dec 4 2017, 8:50 AM

Dec 1 2017

tsoome committed rS326421: loader.efi: efipart should exclude iPXE stub block protocol.
loader.efi: efipart should exclude iPXE stub block protocol
Dec 1 2017, 6:37 AM
tsoome closed D13297: loader.efi: efipart should exclude iPXE stub block protocol.
Dec 1 2017, 6:37 AM
tsoome updated the diff for D13297: loader.efi: efipart should exclude iPXE stub block protocol.

use proper powerof2

Dec 1 2017, 5:32 AM
tsoome added inline comments to D13297: loader.efi: efipart should exclude iPXE stub block protocol.
Dec 1 2017, 5:25 AM

Nov 30 2017

tsoome updated the diff for D13297: loader.efi: efipart should exclude iPXE stub block protocol.

Update to check BlockSize

Nov 30 2017, 9:16 PM
tsoome accepted D13301: Fix various warnings related to geli support..
Nov 30 2017, 5:03 PM
tsoome added inline comments to D13297: loader.efi: efipart should exclude iPXE stub block protocol.
Nov 30 2017, 1:05 PM
tsoome accepted D13301: Fix various warnings related to geli support..

Seems good.

Nov 30 2017, 6:35 AM

Nov 29 2017

tsoome updated the diff for D13297: loader.efi: efipart should exclude iPXE stub block protocol.

use macro for constant.

Nov 29 2017, 6:52 PM
tsoome created D13297: loader.efi: efipart should exclude iPXE stub block protocol.
Nov 29 2017, 6:14 PM

Nov 22 2017

tsoome committed rS326090: net_parse_rootpath() has no parameters.
net_parse_rootpath() has no parameters
Nov 22 2017, 10:04 AM
tsoome closed D13026: loader.efi: efipart does not recognize partitionless disks.
Nov 22 2017, 8:48 AM
tsoome committed rS326089: loader.efi: efipart does not recognize partitionless disks.
loader.efi: efipart does not recognize partitionless disks
Nov 22 2017, 8:48 AM

Nov 18 2017

tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

Add more comments and reorder some checks

Nov 18 2017, 10:57 AM

Nov 15 2017

tsoome created D13109: regex/engine.c: error: variable 'dp' set but not used.
Nov 15 2017, 9:29 PM
tsoome added a comment to D13026: loader.efi: efipart does not recognize partitionless disks.
In D13026#272423, @imp wrote:

This looks OK, but the code could use some high level comments outlining the algorithms used since they are becoming harder to discern from the just reading the code.

Nov 15 2017, 3:13 PM
tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

Update to revision 325851.

Nov 15 2017, 1:12 PM

Nov 10 2017

tsoome updated the diff for D13026: loader.efi: efipart does not recognize partitionless disks.

efipart_hdd() was quite broken.

Nov 10 2017, 5:05 PM
tsoome created D13026: loader.efi: efipart does not recognize partitionless disks.
Nov 10 2017, 12:39 PM
tsoome committed rS325641: loader.efi: efi_devpath_is_prefix should return bool.
loader.efi: efi_devpath_is_prefix should return bool
Nov 10 2017, 12:08 PM
tsoome accepted D12924: Remove mailaddr(7).
Nov 10 2017, 8:19 AM

Nov 2 2017

tsoome committed rS325310: zfs.c:vdev_read() needs to be careful about large sectors.
zfs.c:vdev_read() needs to be careful about large sectors
Nov 2 2017, 8:47 AM
tsoome closed D12850: zfs.c:vdev_read() needs to be careful about large sectors.
Nov 2 2017, 8:47 AM

Nov 1 2017

tsoome committed rS325286: efipart_strategy is using wrong offset with >512B sectors.
efipart_strategy is using wrong offset with >512B sectors
Nov 1 2017, 6:50 PM
tsoome closed D12849: efipart_strategy is using wrong offset with >512B sectors.
Nov 1 2017, 6:50 PM
tsoome updated the diff for D12850: zfs.c:vdev_read() needs to be careful about large sectors.

Validate the return value from lseek()

Nov 1 2017, 8:31 AM

Oct 31 2017

tsoome closed D12847: loader ptblread() is broken with >512B sectors.
Oct 31 2017, 8:29 PM
tsoome committed rS325248: loader ptblread() is broken with >512B sectors.
loader ptblread() is broken with >512B sectors
Oct 31 2017, 8:29 PM
tsoome updated the diff for D12849: efipart_strategy is using wrong offset with >512B sectors.

offset is better name.

Oct 31 2017, 8:22 PM
tsoome updated the diff for D12847: loader ptblread() is broken with >512B sectors.

Reword the comment.

Oct 31 2017, 8:05 PM
tsoome created D12850: zfs.c:vdev_read() needs to be careful about large sectors.
Oct 31 2017, 11:57 AM
tsoome created D12849: efipart_strategy is using wrong offset with >512B sectors.
Oct 31 2017, 11:53 AM
tsoome created D12847: loader ptblread() is broken with >512B sectors.
Oct 31 2017, 11:48 AM

Oct 20 2017

tsoome requested changes to D12732: Revert efipart to use EFI_HANDLEs for partitions.

This patch will need more work and cleanup, especially printing information about the devices.

Oct 20 2017, 9:02 AM

Oct 18 2017

tsoome committed rS324719: libsa/ip: stop read loop on bad fragments.
libsa/ip: stop read loop on bad fragments
Oct 18 2017, 8:06 AM
tsoome committed rS324717: libsa/ip.c: misplaced comment, ip_v is half char, not ip_p.
libsa/ip.c: misplaced comment, ip_v is half char, not ip_p
Oct 18 2017, 7:39 AM

Oct 13 2017

tsoome added a comment to D10447: Unify boot1 with loader.
In D10447#262729, @imp wrote:

I wonder why we even have boot1 anymore after these changes.... It's turning into a mini loader.efi. I wonder why we don't just kill it entirely. We don't need boot volume selection (that's supposed to be the EFI boot BIOS's job). We seem to duplicate a lot of code just to load /boot/loader.efi off of UFS or ZFS partitions. However, we could just use loader.efi directly (though some of the root detection code would need to be tweaked). boot1 used to be small, limited and basically unchanging (so updates weren't needed). Now that boot1.efi has hitched its wagon to loader.efi, I wonder why have an extra boot stage that seems to be good at messing up it's partition guessing...

I'm going to go ahead and commit this (after adding back the bits I keep saying were bogusly deleted), but I'm thinking strongly that we consider just moving to loader.efi installed into \efi\freebsd\loader.efi starting in FreeBSD 12 since we'll be able to point efibootmgr at it by then.

Oct 13 2017, 5:07 AM

Oct 2 2017

tsoome accepted D12565: remove heuristic error detection from ddi_strto*().
Oct 2 2017, 2:11 PM