Page MenuHomeFreeBSD
Differential D55979

loader(8): embedded MD should be the most preferred currdev
ClosedPublic
Actions

Authored by np on Fri, Mar 20, 12:55 AM.

Details

Reviewers
imp
glebius
tsoome
manu
Commits
rG0661997cea16: loader(8): embedded MD should be the most preferred currdev
Summary

A loader built with MD_IMAGE_SIZE is almost always meant for use with
its embedded image and should try that as currdev before anything else.
Recent changes (d69fc3a9dc71, 784150fd2535) seem to have relaxed the ZFS
code's search for a rootfs and exposed this problem.

MFC after: 1 week
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

np created this revision.Fri, Mar 20, 12:55 AM
Herald added a reviewer: manu. · View Herald TranscriptFri, Mar 20, 12:55 AM
Herald added subscribers: dab, bcran. · View Herald Transcript
np requested review of this revision.Fri, Mar 20, 12:55 AM
Harbormaster completed remote builds in B71563: Diff 173967.Fri, Mar 20, 12:55 AM
imp accepted this revision.Fri, Mar 20, 4:24 AM

While I think we need to move back to STRICT for a variety of reasons, this is a good chance I think.

This revision is now accepted and ready to land.Fri, Mar 20, 4:24 AM
tsoome accepted this revision.Fri, Mar 20, 8:03 AM
Closed by commit rG0661997cea16: loader(8): embedded MD should be the most preferred currdev (authored by np). · Explain WhyFri, Mar 20, 2:45 PM
This revision was automatically updated to reflect the committed changes.
np added a commit: rG0661997cea16: loader(8): embedded MD should be the most preferred currdev.

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
18 lines

Diff 174019

View Options

stand/efi/loader/main.c

Loading...