Differential D55979

loader(8): embedded MD should be the most preferred currdev
ClosedPublic
Actions

Authored by np on Mar 20 2026, 12:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 18, 5:59 PM

	Unknown Object (File)
	Sat, Apr 18, 3:46 PM

	Unknown Object (File)
	Wed, Apr 8, 9:24 PM

	Unknown Object (File)
	Wed, Apr 8, 3:18 PM

	Unknown Object (File)
	Mon, Apr 6, 3:30 PM

	Unknown Object (File)
	Sun, Apr 5, 11:47 AM

	Unknown Object (File)
	Sun, Apr 5, 3:09 AM

	Unknown Object (File)
	Sat, Apr 4, 2:24 PM

View All 15 Files

Subscribers

Details

Reviewers

imp
glebius
tsoome
manu

Commits

rGa4a3825d3e1d: loader(8): embedded MD should be the most preferred currdev
rG4fed52fd6410: loader(8): embedded MD should be the most preferred currdev
rG0661997cea16: loader(8): embedded MD should be the most preferred currdev

Summary

A loader built with MD_IMAGE_SIZE is almost always meant for use with
its embedded image and should try that as currdev before anything else.
Recent changes (d69fc3a9dc71, 784150fd2535) seem to have relaxed the ZFS
code's search for a rootfs and exposed this problem.

MFC after: 1 week
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

np created this revision.Mar 20 2026, 12:55 AM

Herald added a reviewer: manu. · View Herald TranscriptMar 20 2026, 12:55 AM

Herald added subscribers: dab, bcran. · View Herald Transcript

np requested review of this revision.Mar 20 2026, 12:55 AM

Harbormaster completed remote builds in B71563: Diff 173967.Mar 20 2026, 12:55 AM

While I think we need to move back to STRICT for a variety of reasons, this is a good chance I think.

This revision is now accepted and ready to land.Mar 20 2026, 4:24 AM

tsoome accepted this revision.Mar 20 2026, 8:03 AM

Closed by commit rG0661997cea16: loader(8): embedded MD should be the most preferred currdev (authored by np). · Explain WhyMar 20 2026, 2:45 PM

This revision was automatically updated to reflect the committed changes.

np added a commit: rG0661997cea16: loader(8): embedded MD should be the most preferred currdev.

np added a commit: rG4fed52fd6410: loader(8): embedded MD should be the most preferred currdev.Wed, Apr 1, 11:01 PM

np added a commit: rGa4a3825d3e1d: loader(8): embedded MD should be the most preferred currdev.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

18 lines

Diff 174019

stand/efi/loader/main.c

Loading...