Page MenuHomeFreeBSD

np (Navdeep Parhar)
User

Projects

User Details

User Since
Dec 12 2014, 10:38 PM (346 w, 12 h)

Recent Activity

Mon, Jul 26

np committed R10:6e405dd9e48d: cxgbe(4): Remove some dead code. (authored by np).
cxgbe(4): Remove some dead code.
Mon, Jul 26, 10:03 PM

Tue, Jul 20

np committed R10:76c890229628: cxgbe(4): Initialize abs_id for ctrl and ofld queues. (authored by np).
cxgbe(4): Initialize abs_id for ctrl and ofld queues.
Tue, Jul 20, 8:19 AM
np added a comment to D31149: ibcore: Kernel space update based on Linux 5.7-rc1.

@np: Is is possible you could send the changes as an incremental diff to: hselasky@freebsd.org ?

Tue, Jul 20, 7:45 AM
np added inline comments to D31149: ibcore: Kernel space update based on Linux 5.7-rc1.
Tue, Jul 20, 7:41 AM

Wed, Jul 14

np added a comment to D31149: ibcore: Kernel space update based on Linux 5.7-rc1.

@np: I'd like to push this by end of week. Please respond!

Wed, Jul 14, 8:05 AM
np committed R10:35e62b00c334: cxgbetool(8): Update the register definitions used to decode regdump. (authored by np).
cxgbetool(8): Update the register definitions used to decode regdump.
Wed, Jul 14, 1:02 AM
np committed R10:f13920b39b8b: cxgbe(4): Skip a few more T5/T6 registers during a regdump. (authored by np).
cxgbe(4): Skip a few more T5/T6 registers during a regdump.
Wed, Jul 14, 12:41 AM

Tue, Jul 13

np committed R10:3c900106ea7a: cxgbe(4): Update firmwares to 1.26.0.0. (authored by np).
cxgbe(4): Update firmwares to 1.26.0.0.
Tue, Jul 13, 4:29 AM

Jun 25 2021

np committed R10:ec8004dd419d: cxgbe(4): Do not configure traffic classes automatically on attach. (authored by np).
cxgbe(4): Do not configure traffic classes automatically on attach.
Jun 25 2021, 11:11 PM
np committed R10:6beb67c7e0ad: cxgbe(4): Get the number of usable traffic classes from the firmware. (authored by np).
cxgbe(4): Get the number of usable traffic classes from the firmware.
Jun 25 2021, 11:11 PM

Jun 22 2021

np accepted D30871: cxgbe tom: Permit rcv_nxt mismatches on FIN for iSCSI connections on T6..
Jun 22 2021, 11:22 PM
np accepted D30782: toe: Read-lock the inp in toe_4tuple_check()..
Jun 22 2021, 11:18 PM

Jun 4 2021

np committed R10:f13d72fd0b74: cxgb(4): Report proper TSO limits. (authored by np).
cxgb(4): Report proper TSO limits.
Jun 4 2021, 8:35 PM
np committed R10:bb877c062034: cxgbe(4): Empty the clib_db before trying to destroy it. (authored by np).
cxgbe(4): Empty the clib_db before trying to destroy it.
Jun 4 2021, 7:20 PM
np accepted D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..

I know it's not directly related but the 'if' here is not needed. If you're tightening the len checks in the function then maybe clean this too?

Jun 4 2021, 6:12 PM

Jun 3 2021

np committed R10:5104dfbeff3e: bsdinstall: Fix typo (Instalation -> Installation). (authored by np).
bsdinstall: Fix typo (Instalation -> Installation).
Jun 3 2021, 4:51 AM

Jun 1 2021

np committed R10:211972cfb816: cxgbe/iw_cxgbe: Support for 512 SGL entries in one memory registration. (authored by np).
cxgbe/iw_cxgbe: Support for 512 SGL entries in one memory registration.
Jun 1 2021, 10:37 PM
np committed R10:db15dbf88011: cxgbe(4): Check if the firmware supports 512 SGL per FR MR. (authored by np).
cxgbe(4): Check if the firmware supports 512 SGL per FR MR.
Jun 1 2021, 10:37 PM

May 29 2021

np committed R10:e0fa04e257c1: cxgbe(4): Update firmwares to 1.25.6.0. (authored by np).
cxgbe(4): Update firmwares to 1.25.6.0.
May 29 2021, 8:27 AM

May 27 2021

np committed R10:5ef87bf8b687: cxgbe(4): Fix an incorrect assert. (authored by np).
cxgbe(4): Fix an incorrect assert.
May 27 2021, 6:01 AM
np committed R10:740d722def71: cxgbe(4): Use correct argument in call to hashdestroy. (authored by np).
cxgbe(4): Use correct argument in call to hashdestroy.
May 27 2021, 5:44 AM

May 25 2021

np accepted D30460: cxgbe: set iq flags only after it has been initialized.

Thanks for the fix. Please add a "Fixes: 43bbae19483fbde0a91e61acad8a6e71e334c8b8" line to the commit log before checking it in.

May 25 2021, 11:56 PM

May 24 2021

np committed R10:ac02945f7e2b: cxgbetool(8): add a 'clip' subcommand to deal with the CLIP table. (authored by np).
cxgbetool(8): add a 'clip' subcommand to deal with the CLIP table.
May 24 2021, 1:35 AM

May 23 2021

np committed R10:24b98f288d11: cxgbe(4): Overhaul CLIP (Compressed Local IPv6) table management. (authored by np).
cxgbe(4): Overhaul CLIP (Compressed Local IPv6) table management.
May 23 2021, 11:09 PM

May 22 2021

np committed R10:ffbb373c5a95: cxgbe(4): Fix build warnings with NOINET kernels. (authored by np).
cxgbe(4): Fix build warnings with NOINET kernels.
May 22 2021, 3:50 AM
np closed D26334: cxgbe: Apply more checks for INET and INET6.
May 22 2021, 3:50 AM

May 19 2021

np committed R10:3965469eaa33: cxgbe(4): Remove some dead code. (authored by np).
cxgbe(4): Remove some dead code.
May 19 2021, 6:20 AM

May 16 2021

np committed R10:1f9df724eb20: cxgbe(4): Use ifaddr_event_ext instead of ifaddr_event for CLIP management. (authored by np).
cxgbe(4): Use ifaddr_event_ext instead of ifaddr_event for CLIP management.
May 16 2021, 3:47 AM
np committed R10:8f7d9587664a: cxgbe(4): Do not panic when tx is called with invalid checksum requests. (authored by np).
cxgbe(4): Do not panic when tx is called with invalid checksum requests.
May 16 2021, 3:46 AM
np committed R10:1c0a5613ac8f: cxgbe(4): hw.cxgbe.panic_on_fatal_err can be changed any time. (authored by np).
cxgbe(4): hw.cxgbe.panic_on_fatal_err can be changed any time.
May 16 2021, 3:39 AM
np committed R10:294591a4b7be: cxgbe(4): Move the hw-specific parts of VXLAN setup to a separate function. (authored by np).
cxgbe(4): Move the hw-specific parts of VXLAN setup to a separate function.
May 16 2021, 3:38 AM
np committed R10:7d984fe000d8: cxgbe(4): Add flag to reliably stop the driver from accessing hw stats. (authored by np).
cxgbe(4): Add flag to reliably stop the driver from accessing hw stats.
May 16 2021, 3:36 AM
np committed R10:8b8b659f39f3: cxgbe(4): RSS hash for VXLAN traffic is computed from the inner frame. (authored by np).
cxgbe(4): RSS hash for VXLAN traffic is computed from the inner frame.
May 16 2021, 3:31 AM
np committed R10:b7259437d5d7: cxgbe(4): Fix minor nit in the display of MPS TCAM entries. (authored by np).
cxgbe(4): Fix minor nit in the display of MPS TCAM entries.
May 16 2021, 3:27 AM
np committed R10:9b107d9ef469: cxgbe(4): make the logging helpers a little more robust. (authored by np).
cxgbe(4): make the logging helpers a little more robust.
May 16 2021, 3:27 AM
np committed R10:e0897d666922: cxgbe(4): Always use the per-VI callout to read interface stats. (authored by np).
cxgbe(4): Always use the per-VI callout to read interface stats.
May 16 2021, 3:25 AM
np committed R10:81ec0d054652: cxgbe/tom: Fix potential leak in t4_aiotx_process_job. (authored by np).
cxgbe/tom: Fix potential leak in t4_aiotx_process_job.
May 16 2021, 3:25 AM
np committed R10:248bc9784a2c: cxgbe/t4_tom: restore socket's protosw before entering TIME_WAIT. (authored by np).
cxgbe/t4_tom: restore socket's protosw before entering TIME_WAIT.
May 16 2021, 3:20 AM
np committed R10:95a3005326e9: cxgbe(4): Allow a T6 adapter to switch between TOE and NIC TLS mode. (authored by np).
cxgbe(4): Allow a T6 adapter to switch between TOE and NIC TLS mode.
May 16 2021, 3:14 AM
np committed R10:139c8bd6f3da: cxgbe(4): create a separate helper routine to write the global RSS key. (authored by np).
cxgbe(4): create a separate helper routine to write the global RSS key.
May 16 2021, 3:12 AM
np committed R10:d9eb1e0c9084: cxgbe(4): make it safe to call setup_memwin repeatedly. (authored by np).
cxgbe(4): make it safe to call setup_memwin repeatedly.
May 16 2021, 3:11 AM
np committed R10:564d1f6aef5e: cxgbe(4): use standard sysctl routines to deal with 16b values. (authored by np).
cxgbe(4): use standard sysctl routines to deal with 16b values.
May 16 2021, 3:08 AM
np committed R10:af1edd87f678: cxgbe(4): catch up with the latest cryptocaps. (authored by np).
cxgbe(4): catch up with the latest cryptocaps.
May 16 2021, 3:04 AM
np committed R10:9b9bd9345060: cxgbe(4): Remove extra blank line. (authored by np).
cxgbe(4): Remove extra blank line.
May 16 2021, 3:02 AM
np committed R10:7f681917602b: cxgbe(4): Fix an assertion that is not valid during attach. (authored by np).
cxgbe(4): Fix an assertion that is not valid during attach.
May 16 2021, 3:02 AM
np committed R10:98893d4953da: cxgbetool(8): Add support for setting the hashfilter mode (filter mask). (authored by np).
cxgbetool(8): Add support for setting the hashfilter mode (filter mask).
May 16 2021, 3:01 AM
np committed R10:d314a9f27939: cxgbe(4): Use the correct filter width for T5+. (authored by np).
cxgbe(4): Use the correct filter width for T5+.
May 16 2021, 2:57 AM
np committed R10:a8076e0afdf4: cxgbe(4): Add a driver ioctl to set the filter mask. (authored by np).
cxgbe(4): Add a driver ioctl to set the filter mask.
May 16 2021, 2:55 AM
np committed R10:191894573beb: cxgbe(4): Use firmware commands to get/set filter configuration. (authored by np).
cxgbe(4): Use firmware commands to get/set filter configuration.
May 16 2021, 2:52 AM
np committed R10:e99210ab632b: cxgbe(4): Break up t4_read_chip_settings. (authored by np).
cxgbe(4): Break up t4_read_chip_settings.
May 16 2021, 2:49 AM

May 14 2021

np accepted D30269: cxgbei: Add tunable sysctls for the FirstBurstLength and MaxBurstLength..
May 14 2021, 11:22 PM
np accepted D30268: cxgbei: Remove unused sysctls..
May 14 2021, 11:22 PM

May 12 2021

np added inline comments to D29904: cxgbe tom: Set the tid in the work requests to program page pods for iSCSI..
May 12 2021, 5:30 PM

May 5 2021

np committed R10:f4ba035bca92: cxgbe(4): Use ifaddr_event_ext instead of ifaddr_event for CLIP management. (authored by np).
cxgbe(4): Use ifaddr_event_ext instead of ifaddr_event for CLIP management.
May 5 2021, 3:18 AM

Apr 28 2021

np committed R10:b9820bca183a: cxgbe(4): Do not panic when tx is called with invalid checksum requests. (authored by np).
cxgbe(4): Do not panic when tx is called with invalid checksum requests.
Apr 28 2021, 11:42 PM
np committed R10:83b5cda106a2: cxgbe(4): Add support for NIC suspend/resume and live reset. (authored by np).
cxgbe(4): Add support for NIC suspend/resume and live reset.
Apr 28 2021, 6:04 AM

Apr 26 2021

np committed R10:43bbae19483f: cxgbe(4): Separate the sw- and hw-specific parts of resource allocations (authored by np).
cxgbe(4): Separate the sw- and hw-specific parts of resource allocations
Apr 26 2021, 9:12 PM

Apr 23 2021

np committed R10:50f5d13eeb88: cxgbe(4): hw.cxgbe.panic_on_fatal_err can be changed any time. (authored by np).
cxgbe(4): hw.cxgbe.panic_on_fatal_err can be changed any time.
Apr 23 2021, 7:29 PM
np committed R10:5f00292fe3b7: cxgbe(4): Move the hw-specific parts of VXLAN setup to a separate function. (authored by np).
cxgbe(4): Move the hw-specific parts of VXLAN setup to a separate function.
Apr 23 2021, 7:29 AM
np committed R10:b47b28e5b28a: cxgbe(4): Add flag to reliably stop the driver from accessing hw stats. (authored by np).
cxgbe(4): Add flag to reliably stop the driver from accessing hw stats.
Apr 23 2021, 12:47 AM

Apr 22 2021

np committed R10:dc77e7929644: cxgbe(4): Fix minor nit in the display of MPS TCAM entries. (authored by np).
cxgbe(4): Fix minor nit in the display of MPS TCAM entries.
Apr 22 2021, 10:41 PM
np committed R10:8f1bc78ef79b: cxgbe(4): make the logging helpers a little more robust. (authored by np).
cxgbe(4): make the logging helpers a little more robust.
Apr 22 2021, 10:32 PM
np committed R10:557c4521bbb2: cxgbe/t4_tom: Implement tod_pmtu_update. (authored by np).
cxgbe/t4_tom: Implement tod_pmtu_update.
Apr 22 2021, 10:08 PM

Apr 21 2021

np committed R10:01d74fe1ffc3: Path MTU discovery hooks for offloaded TCP connections. (authored by np).
Path MTU discovery hooks for offloaded TCP connections.
Apr 21 2021, 8:02 PM
np closed D29755: Path MTU discovery hooks for offloaded TCP connections..
Apr 21 2021, 8:02 PM

Apr 14 2021

np requested review of D29755: Path MTU discovery hooks for offloaded TCP connections..
Apr 14 2021, 12:48 AM
np added a comment to D29741: ifconfig: Reuse media state in ifmedia_getstate.

I can confirm that this change fixes the problem for me.

Apr 14 2021, 12:36 AM
np committed R10:d107ee06f3e3: cxgbe(4): RSS hash for VXLAN traffic is computed from the inner frame. (authored by np).
cxgbe(4): RSS hash for VXLAN traffic is computed from the inner frame.
Apr 14 2021, 12:06 AM

Apr 13 2021

np accepted D29739: TOE: Use a read lock on the PCB for syncache_add()..
Apr 13 2021, 10:51 PM

Apr 12 2021

np committed R10:bf5057691bb0: cxgbe/tom: Fix potential leak in t4_aiotx_process_job. (authored by np).
cxgbe/tom: Fix potential leak in t4_aiotx_process_job.
Apr 12 2021, 3:50 AM
np closed D29579: cxgbe/tom: Fix potential leak in t4_aiotx_process_job..
Apr 12 2021, 3:50 AM
np accepted D29297: cxgbe: Add counters for iSCSI PDUs transmitted via TOE..
Apr 12 2021, 2:40 AM

Apr 4 2021

np requested review of D29579: cxgbe/tom: Fix potential leak in t4_aiotx_process_job..
Apr 4 2021, 10:09 PM

Apr 1 2021

np closed D29527: cxgbe(4): Always use the per-VI callout to read interface stats..
Apr 1 2021, 9:26 PM
np committed R10:516fe911a6b7: cxgbe(4): Always use the per-VI callout to read interface stats. (authored by np).
cxgbe(4): Always use the per-VI callout to read interface stats.
Apr 1 2021, 9:26 PM
np updated the diff for D29527: cxgbe(4): Always use the per-VI callout to read interface stats..

Acquire reg_lock around read_vf_stat instead of in a loop in the function.

Apr 1 2021, 5:59 PM
np requested review of D29527: cxgbe(4): Always use the per-VI callout to read interface stats..
Apr 1 2021, 8:43 AM

Mar 31 2021

np committed R10:539489326947: cxgbe/t4_tom: restore socket's protosw before entering TIME_WAIT. (authored by np).
cxgbe/t4_tom: restore socket's protosw before entering TIME_WAIT.
Mar 31 2021, 6:19 PM
np closed D29503: cxgbe/t4_tom: restore socket's protosw before entering TIME_WAIT..
Mar 31 2021, 6:19 PM
np accepted D29501: vxlan: correct interface MTU when using hw offloads.
Mar 31 2021, 2:12 AM
np added inline comments to D29501: vxlan: correct interface MTU when using hw offloads.
Mar 31 2021, 1:19 AM
np added a comment to D29501: vxlan: correct interface MTU when using hw offloads.

By the way there's an "MTU" section in the vxlan(4) man page and you might want to update it with this new behavior.

Mar 31 2021, 12:51 AM
np accepted D29501: vxlan: correct interface MTU when using hw offloads.
Mar 31 2021, 12:49 AM

Mar 30 2021

np added a comment to D29501: vxlan: correct interface MTU when using hw offloads.
In D29501#661249, @np wrote:

vxlan_setup_interface_hdrlen() can be called repeatedly and if the vxlan interface is down it will call vxlan_ctrl_set_remote_addr(). if_mtu will get decremented every time and that's not correct.

Mar 30 2021, 9:26 PM
np requested changes to D29501: vxlan: correct interface MTU when using hw offloads.

vxlan_setup_interface_hdrlen() can be called repeatedly and if the vxlan interface is down it will call vxlan_ctrl_set_remote_addr(). if_mtu will get decremented every time and that's not correct.

Mar 30 2021, 9:23 PM
np requested review of D29503: cxgbe/t4_tom: restore socket's protosw before entering TIME_WAIT..
Mar 30 2021, 8:50 PM

Mar 26 2021

np accepted D29383: cxgbe: Make the TOE TLS stats per-queue instead of per-port..
Mar 26 2021, 9:46 PM
np added a comment to D29382: cxgbe: Add a struct sge_ofld_txq type..

Let's land this if it's ready.

Mar 26 2021, 9:40 PM
np accepted D29432: cxgbe: remove unused linux headers.
Mar 26 2021, 5:39 PM

Mar 25 2021

np accepted D29382: cxgbe: Add a struct sge_ofld_txq type..
Mar 25 2021, 10:37 PM
np committed R10:15f335556783: cxgbe(4): Allow a T6 adapter to switch between TOE and NIC TLS mode. (authored by np).
cxgbe(4): Allow a T6 adapter to switch between TOE and NIC TLS mode.
Mar 25 2021, 8:47 PM
np closed D29291: cxgbe(4): Allow a T6 adapter to switch between TOE and KTLS mode..
Mar 25 2021, 8:47 PM
np requested changes to D29382: cxgbe: Add a struct sge_ofld_txq type..

There's also this in t4_main.c that needs to be updated to sizeof(struct sge_ofld_txq):

Mar 25 2021, 5:17 AM

Mar 24 2021

np added a comment to D29382: cxgbe: Add a struct sge_ofld_txq type..

The offload tx queues are also used for RATELIMIT tx and we should either set cxgbe_rate_tag->eo_txq to ofld_txq->wrq in ethofld_transmit or change eo_txq to be a sge_ofld_txq.

Mar 24 2021, 9:00 PM
np updated the diff for D29291: cxgbe(4): Allow a T6 adapter to switch between TOE and KTLS mode..

"NIC TLS" instead of "KTLS" in the message as suggested by jhb@.

Mar 24 2021, 1:12 AM

Mar 22 2021

np accepted D29366: LinuxKPI/ofed/mlx: mark/hide net_device is ifnet code.
Mar 22 2021, 12:15 AM

Mar 19 2021

np committed R10:3cc6f777befc: cxgbe(4): create a separate helper routine to write the global RSS key. (authored by np).
cxgbe(4): create a separate helper routine to write the global RSS key.
Mar 19 2021, 8:47 PM
np committed R10:a1d803c16206: cxgbe(4): make it safe to call setup_memwin repeatedly. (authored by np).
cxgbe(4): make it safe to call setup_memwin repeatedly.
Mar 19 2021, 7:39 PM
np committed R10:473f6163e310: cxgbe(4): use standard sysctl routines to deal with 16b values. (authored by np).
cxgbe(4): use standard sysctl routines to deal with 16b values.
Mar 19 2021, 6:05 PM

Mar 17 2021

np accepted D29302: cxgbei: Enter network epoch and set vnet around t4_push_pdus()..
Mar 17 2021, 12:39 AM