Page MenuHomeFreeBSD

np (Navdeep Parhar)
User

Projects

User Details

User Since
Dec 12 2014, 10:38 PM (227 w, 1 d)

Recent Activity

Sat, Apr 13

np committed rS346188: MFC r343666, r343861-r343862, r343923, r343968, r345660, and r345810..
MFC r343666, r343861-r343862, r343923, r343968, r345660, and r345810.
Sat, Apr 13, 7:23 PM

Tue, Apr 2

np committed rS345810: cxgbe(4): Add a flag to indicate that bits in interrupt cause but not in.
cxgbe(4): Add a flag to indicate that bits in interrupt cause but not in
Tue, Apr 2, 6:50 PM

Fri, Mar 29

np committed rS345714: tcp_autorcvbuf_inc was removed in r344433..
tcp_autorcvbuf_inc was removed in r344433.
Fri, Mar 29, 9:40 PM
np committed rS345701: cxgbe/t4_tom: Catch up with r344433, which removed tcb_autorcvbuf_inc..
cxgbe/t4_tom: Catch up with r344433, which removed tcb_autorcvbuf_inc.
Fri, Mar 29, 4:43 PM

Thu, Mar 28

np committed rS345660: cxgbe(4): Count and clear interrupts generated at the software's request..
cxgbe(4): Count and clear interrupts generated at the software's request.
Thu, Mar 28, 9:22 PM
np committed rS345629: MFC r329788 (by jhb@):.
MFC r329788 (by jhb@):
Thu, Mar 28, 6:10 AM

Wed, Mar 27

np committed rS345622: MFC r344654, r345334..
MFC r344654, r345334.
Wed, Mar 27, 10:52 PM
np committed rS345621: MFC r340651, r343264, r343269, and r345083..
MFC r340651, r343264, r343269, and r345083.
Wed, Mar 27, 10:42 PM
np committed rS345619: MFC r344519, r344682, and r344719..
MFC r344519, r344682, and r344719.
Wed, Mar 27, 10:27 PM
np committed rS345618: MFC r344524:.
MFC r344524:
Wed, Mar 27, 10:21 PM
np committed rS345616: MFC r341620:.
MFC r341620:
Wed, Mar 27, 10:06 PM
np committed rS345615: MFC r343889:.
MFC r343889:
Wed, Mar 27, 9:59 PM
np committed rS345614: MFC r343539:.
MFC r343539:
Wed, Mar 27, 9:55 PM
np committed rS345612: MFC r343233:.
MFC r343233:
Wed, Mar 27, 9:50 PM
np committed rS345610: MFC r342954:.
MFC r342954:
Wed, Mar 27, 9:47 PM
np committed rS345609: MFC r342356:.
MFC r342356:
Wed, Mar 27, 9:45 PM
np committed rS345608: MFC r342284:.
MFC r342284:
Wed, Mar 27, 9:43 PM
np committed rS345607: MFC r342758:.
MFC r342758:
Wed, Mar 27, 9:38 PM
np committed rS345606: MFC r342234:.
MFC r342234:
Wed, Mar 27, 9:34 PM
np committed rS345605: MFC r342208:.
MFC r342208:
Wed, Mar 27, 9:29 PM
np committed rS345604: MFC r341172, r341270 (both by jhb@)..
MFC r341172, r341270 (both by jhb@).
Wed, Mar 27, 9:23 PM
np committed rS345603: MFC r341654:.
MFC r341654:
Wed, Mar 27, 8:56 PM
np committed rS345599: MFC r339967:.
MFC r339967:
Wed, Mar 27, 7:47 PM
np committed rS345598: MFC r339965:.
MFC r339965:
Wed, Mar 27, 7:42 PM
np committed rS345597: MFC r339886:.
MFC r339886:
Wed, Mar 27, 7:40 PM
np committed rS345595: MFC r339717, r339749, and r339809..
MFC r339717, r339749, and r339809.
Wed, Mar 27, 7:38 PM
np committed rS345592: MFC r339705:.
MFC r339705:
Wed, Mar 27, 7:24 PM
np committed rS345591: MFC r339700:.
MFC r339700:
Wed, Mar 27, 7:18 PM
np committed rS345587: MFC some iw_cxgbe fixes (r339667, r339891, r340063, r342266, r342270,.
MFC some iw_cxgbe fixes (r339667, r339891, r340063, r342266, r342270,
Wed, Mar 27, 6:47 PM
np committed rS345586: MFC r339628:.
MFC r339628:
Wed, Mar 27, 6:22 PM

Mar 20 2019

np committed rS345334: cxgbe(4): Treat the viid as an opaque identifier..
cxgbe(4): Treat the viid as an opaque identifier.
Mar 20 2019, 5:27 PM

Mar 19 2019

np committed rS345307: iw_cxgbe: Remove unused smac_idx from the ep structure..
iw_cxgbe: Remove unused smac_idx from the ep structure.
Mar 19 2019, 7:11 PM

Mar 14 2019

np created P249 non uu-encoded firmwares for cxgbe.
Mar 14 2019, 5:28 PM
np created P248 non uu encoded fw.
Mar 14 2019, 4:41 PM

Mar 13 2019

np committed rS345083: cxgbe(4): Update T4/5/6 firmwares to 1.23.0.0..
cxgbe(4): Update T4/5/6 firmwares to 1.23.0.0.
Mar 13 2019, 6:46 AM

Mar 2 2019

np committed rS344719: cxgbev(4): Enable 32b port capabilities in the VF driver..
cxgbev(4): Enable 32b port capabilities in the VF driver.
Mar 2 2019, 4:40 AM

Mar 1 2019

np committed rS344682: cxgbe(4): Don't forget to report link state to the kernel if the link is.
cxgbe(4): Don't forget to report link state to the kernel if the link is
Mar 1 2019, 2:43 AM

Feb 28 2019

np accepted D19399: Don't assume all children of a nexus are ports..
Feb 28 2019, 5:50 AM
np committed rS344654: cxgbe(4): Request high priority filter support explicitly, as required.
cxgbe(4): Request high priority filter support explicitly, as required
Feb 28 2019, 5:45 AM

Feb 27 2019

np committed rS344617: libcxgb4: Don't spam stderr. Write combining is not enabled by default.
libcxgb4: Don't spam stderr. Write combining is not enabled by default
Feb 27 2019, 6:50 AM

Feb 25 2019

np committed rS344524: cxgbe(4): Updates to the default and hashfilter configurations..
cxgbe(4): Updates to the default and hashfilter configurations.
Feb 25 2019, 4:28 PM
np committed rS344519: cxgbe(4): Use correct port_info in the call to is_bt()..
cxgbe(4): Use correct port_info in the call to is_bt().
Feb 25 2019, 3:47 PM

Feb 10 2019

np committed rS343968: cxgbe(4): Ignore unused interrupts..
cxgbe(4): Ignore unused interrupts.
Feb 10 2019, 7:20 PM

Feb 9 2019

np committed rS343923: cxgbe(4): Delay the panic due to a fatal error by 30s..
cxgbe(4): Delay the panic due to a fatal error by 30s.
Feb 9 2019, 1:50 AM

Feb 8 2019

np committed rS343889: cxgbev(4): Initialize debug_flags from the environment like in the PF driver..
cxgbev(4): Initialize debug_flags from the environment like in the PF driver.
Feb 8 2019, 3:31 AM

Feb 7 2019

np committed rS343862: cxgbe(4): Auto-dump the CIM block's logic analyzer on a TIMER0 interrupt..
cxgbe(4): Auto-dump the CIM block's logic analyzer on a TIMER0 interrupt.
Feb 7 2019, 5:41 AM
np committed rS343861: cxgbe(4): Auto-dump the device log on a mailbox timeout or when the.
cxgbe(4): Auto-dump the device log on a mailbox timeout or when the
Feb 7 2019, 5:06 AM

Feb 1 2019

np committed rS343666: cxgbe(4): Improved error reporting and diagnostics..
cxgbe(4): Improved error reporting and diagnostics.
Feb 1 2019, 8:42 PM

Jan 30 2019

np committed rS343569: cxgbe/iw_cxgbe: Fix an address calculation in the memory registration code that.
cxgbe/iw_cxgbe: Fix an address calculation in the memory registration code that
Jan 30 2019, 5:39 AM

Jan 29 2019

np committed rS343539: cxgbe(4): Add adapter information to messages logged by the OS-agnostic.
cxgbe(4): Add adapter information to messages logged by the OS-agnostic
Jan 29 2019, 12:49 AM

Jan 25 2019

np accepted D18966: Fix a few more places to handle ofld tx queues for RATELIMIT..
Jan 25 2019, 6:44 PM

Jan 24 2019

np committed rS343404: MFC r342603:.
MFC r342603:
Jan 24 2019, 5:31 PM

Jan 21 2019

np committed rS343269: cxgbe(4): Allow negative values in hw.cxgbe.fw_install and take them to.
cxgbe(4): Allow negative values in hw.cxgbe.fw_install and take them to
Jan 21 2019, 6:42 PM
np committed rS343264: cxgbe(4): Use a truncated firmware header for version checks. All the.
cxgbe(4): Use a truncated firmware header for version checks. All the
Jan 21 2019, 5:58 PM

Jan 20 2019

np committed rS343233: cxgbe(4): Clear the reply-pending status of a hashfilter when the reply.
cxgbe(4): Clear the reply-pending status of a hashfilter when the reply
Jan 20 2019, 11:30 PM

Jan 12 2019

np committed rS342954: cxgbe(4): Move some INTx specific code to a more appropriate place..
cxgbe(4): Move some INTx specific code to a more appropriate place.
Jan 12 2019, 4:44 AM

Jan 4 2019

np committed rS342758: cxgbe(4): Clear FW_OK if the firmware reports an error..
cxgbe(4): Clear FW_OK if the firmware reports an error.
Jan 4 2019, 4:15 AM

Dec 30 2018

np committed rS342603: cxgbe(4): Attach to two T540 variants..
cxgbe(4): Attach to two T540 variants.
Dec 30 2018, 1:57 AM

Dec 21 2018

np committed rS342356: Remove unused macros from t4_tom.h..
Remove unused macros from t4_tom.h.
Dec 21 2018, 8:46 PM

Dec 20 2018

np committed rS342289: cxgbe/iw_cxgbe: Remove redundant CTRs from c4iw_alloc/c4iw_rdev_open..
cxgbe/iw_cxgbe: Remove redundant CTRs from c4iw_alloc/c4iw_rdev_open.
Dec 20 2018, 10:40 PM
np committed rS342288: cxgbe/iw_cxgbe: Do not terminate CTRx messages with \n..
cxgbe/iw_cxgbe: Do not terminate CTRx messages with \n.
Dec 20 2018, 10:31 PM
np committed rS342284: cxgbe(4): Make sure the rx queues start off with the correct timestamp.
cxgbe(4): Make sure the rx queues start off with the correct timestamp
Dec 20 2018, 8:34 PM
np committed rS342272: cxgbe/iw_cxgbe: Use -ve errno when interfacing with linuxkpi/OFED..
cxgbe/iw_cxgbe: Use -ve errno when interfacing with linuxkpi/OFED.
Dec 20 2018, 1:36 AM
np committed rS342270: cxgbe/iw_cxgbe: Add a knob for testing that lets iWARP connections cycle.
cxgbe/iw_cxgbe: Add a knob for testing that lets iWARP connections cycle
Dec 20 2018, 1:00 AM

Dec 19 2018

np committed rS342266: cxgbe/iw_cxgbe: Use DSGLs to write to card's memory when appropriate..
cxgbe/iw_cxgbe: Use DSGLs to write to card's memory when appropriate.
Dec 19 2018, 11:29 PM
np committed rS342234: cxgbe(4): Do not issue mbox commands after t4_fw_bye..
cxgbe(4): Do not issue mbox commands after t4_fw_bye.
Dec 19 2018, 7:21 PM
np committed rS342208: cxgbe/t4_tom: fixes for issues on the passive open side..
cxgbe/t4_tom: fixes for issues on the passive open side.
Dec 19 2018, 1:37 AM

Dec 6 2018

np committed rS341654: cxgbe(4): Get Linux cxgb4vf working in bhyve VMs with VFs passed.
cxgbe(4): Get Linux cxgb4vf working in bhyve VMs with VFs passed
Dec 6 2018, 9:33 PM
np committed rS341620: cxgbe(4): Fall back to a basic configuration in case of any error during.
cxgbe(4): Fall back to a basic configuration in case of any error during
Dec 6 2018, 6:18 AM

Nov 29 2018

np accepted D18384: Make most of the CLIP code conditional on #ifdef INET6..
Nov 29 2018, 11:07 PM

Nov 27 2018

np accepted D17987: netmap: set IFCAP_NETMAP in if_capabilities.

The truth is that netmap not setting the IFCAP_NETMAP flag in ifp->if_capabilities after r307394 is a mistake that we did not notice so far.
It got introduced by refactoring, 3 years ago (see https://github.com/luigirizzo/netmap/commit/5d0796f93a1107eb14422c7b8ea416f7fd750a2e).
Sorry for that, it was unintended.
I just happened to notice that and fix it.

Nov 27 2018, 8:12 PM
np accepted D18360: Add read-only sysctls for all tunables in the cxgbe(4) driver..
Nov 27 2018, 5:12 PM

Nov 26 2018

np accepted D18010: Move CLIP table handling out of TOM and into the base driver..
Nov 26 2018, 11:20 PM
np requested changes to D17987: netmap: set IFCAP_NETMAP in if_capabilities.

The cxgbe part of this diff reverts r309725. The commit message for r309725 indicates the changes were made to catch up with r307394, which was the a netmap update. Can you confirm that various releases of netmap have had different behavior regarding if_capabilities? If netmap has finally settled on handling the caps this way then I have no objection to one last catch-up in the driver.

Nov 26 2018, 5:57 PM
np accepted D18310: Fix a check..
Nov 26 2018, 5:11 PM

Nov 19 2018

np committed rS340651: cxgbe(4): Update T4/5/6 firmwares to 1.22.0.3..
cxgbe(4): Update T4/5/6 firmwares to 1.22.0.3.
Nov 19 2018, 9:59 PM

Nov 9 2018

np accepted D17915: Use tcp_state_change() in the cxgbe(4) TOE module..
Nov 9 2018, 1:10 AM

Nov 6 2018

np added a comment to D17870: cxgbe netmap: Avoid too frequent flush of CIDX by the NIC.

lazy_tx_credit_flush in the driver is supposed to avoid the situation you described. Try setting it to 1 if it isn't already and see if that helps.

Nov 6 2018, 8:34 PM
np added inline comments to D17868: cxgbe netmap: Micro optimizations of the rxsync function.
Nov 6 2018, 6:00 PM
np added a reviewer for D17868: cxgbe netmap: Micro optimizations of the rxsync function: v.maffione_gmail.com.

+Vincenzo for the netmap_kern.h part.

Nov 6 2018, 5:54 PM
np requested changes to D17869: cxgbe: Fix false sharing between t4_nm_intr and cxgbe_netmap_rxsync.

How about using __aligned(CACHE_LINE_SIZE) like the rest of the driver and let the compiler figure out the padding?

Nov 6 2018, 5:35 PM
np accepted D17857: Treat the memory lengths for CHELSIO_T4_GET_MEM as unsigned..
Nov 6 2018, 1:32 AM

Nov 5 2018

np accepted D17811: Add a facility for transmitting "raw" work requests on regular NIC queues..
Nov 5 2018, 10:44 PM
np accepted D17802: Fix cxgbe netmap when interface is DOWN.

Can you provide exact steps to reproduce the problem that you described? I get an EAGAIN (as expected) and not a panic if I try to enable netmap when the link is down.

Nov 5 2018, 6:38 PM
np added a comment to D17843: Fix Chelsio T6 drop statistics.
In D17843#381477, @ae wrote:

Hi, I have a report, that cxgbe driver doesn't take into account packets, that are received from mirrored port. So, when you run netstat -hw 1 -I cxl0 you will see no packets, but tcpdump will show them. It seems a bit confusing. I didn't checked this, so I might be wrong.

Nov 5 2018, 6:11 PM
np requested changes to D17843: Fix Chelsio T6 drop statistics.

What version of FreeBSD is this? I think this is already fixed in 12.0.

Nov 5 2018, 5:12 PM

Nov 2 2018

np committed rS340063: cxgbe/iw_cxgbe: Suppress spurious "Unexpected streaming data ...".
cxgbe/iw_cxgbe: Suppress spurious "Unexpected streaming data ..."
Nov 2 2018, 4:22 PM

Oct 31 2018

np committed rS339967: cxgbe(4): Add rate limiting support for UDP..
cxgbe(4): Add rate limiting support for UDP.
Oct 31 2018, 7:19 PM
np committed rS339965: cxgbe(4): Report a reasonable non-zero if_hw_tsomaxsegsize to the.
cxgbe(4): Report a reasonable non-zero if_hw_tsomaxsegsize to the
Oct 31 2018, 6:30 PM

Oct 30 2018

np committed rS339905: MFC r339626:.
MFC r339626:
Oct 30 2018, 5:04 AM

Oct 29 2018

np committed rS339891: cxgbe/iw_cxgbe: Install the socket upcall before calling soconnect to.
cxgbe/iw_cxgbe: Install the socket upcall before calling soconnect to
Oct 29 2018, 10:36 PM
np closed D17707: iWARP rping server fails to bind socket when no IP address is specified.
Oct 29 2018, 9:46 PM
np committed rS339886: rping(1): Make sure the socket address defaults to something reasonable.
rping(1): Make sure the socket address defaults to something reasonable
Oct 29 2018, 9:46 PM
np accepted D17707: iWARP rping server fails to bind socket when no IP address is specified.

I'll check this into FreeBSD later today. Please send the patch upstream too.

Oct 29 2018, 7:00 PM

Oct 27 2018

np committed rS339809: cxgbetool(8): Add a subaction (tcbrss <n>) that can be used with "pass".
cxgbetool(8): Add a subaction (tcbrss <n>) that can be used with "pass"
Oct 27 2018, 5:26 AM

Oct 25 2018

np committed rS339749: cxgbe(4): Add a knob to split the rx queues for a netmap enabled.
cxgbe(4): Add a knob to split the rx queues for a netmap enabled
Oct 25 2018, 10:55 PM
np added a reviewer for D17707: iWARP rping server fails to bind socket when no IP address is specified: hselasky.

Where is the real upstream for rping? Maybe this fix should go there first?

Oct 25 2018, 10:05 PM
np committed rS339717: cxgbe(4): Allow "pass" filters to distribute matching traffic using a.
cxgbe(4): Allow "pass" filters to distribute matching traffic using a
Oct 25 2018, 2:37 PM
np committed rS339705: cxgbe(4): Update the VI's default queue when netmap is enabled/disabled..
cxgbe(4): Update the VI's default queue when netmap is enabled/disabled.
Oct 25 2018, 6:25 AM
np committed rS339700: cxgbe(4): new sysctl to display the start of the RSS region for a VI..
cxgbe(4): new sysctl to display the start of the RSS region for a VI.
Oct 25 2018, 1:20 AM