Looks good (other than the yoda style in one conditional).

This was committed in r360232

Incorporate feedback.

This isn't the exact change I'd suggested or tested but it looks ok to me.

This doesn't quite work because I can't have a struct pci_dev in the softc of the device, which has a native BSD driver (cxgbe) and doesn't use linuxkpi. A different module (iw_cxgbe) on top of cxgbe deals with OFED and that uses linuxkpi. With all this in mind I made the following changes on top of this revision:
https://people.freebsd.org/~np/lkpi_pci.diff

The RSS hash will always be present in the passive open CPL so it's safe to remove the conditional.

If the RSS hash is available in the CPL headers then maybe we could use that directly instead of the tid?

Can you please try r359159?

Address feedback.

In D23752#522021, @hselasky wrote:

@np: Can the Chelsio NIC allocate one queue for each ratelimited connection?

Nick, just set hw.cxgbe.rsrv_noflow and all tx traffic that doesn't have a flowid (LACP, ARP, etc.)
will be treated as special by cxgbe and will be transmitted over a reserved tx queue.

This doesn't look right to me.

Adding original author of the code as a reviewer.

I see this with slightly modifed prints in and around the code being removed. This is with a card with a 512B VPD.

A different version of this was committed as r357606.

Incorporate feedback from jhb@.