Page MenuHomeFreeBSD

np (Navdeep Parhar)
User

Projects

User Details

User Since
Dec 12 2014, 10:38 PM (306 w, 7 h)

Recent Activity

Yesterday

np committed rS366959: cxgbe(4): Fix min/max typo in r366958..
cxgbe(4): Fix min/max typo in r366958.
Fri, Oct 23, 2:25 AM
np committed rS366958: cxgbe(4): refine the values reported in if_ratelimit_query..
cxgbe(4): refine the values reported in if_ratelimit_query.
Fri, Oct 23, 1:37 AM

Thu, Oct 22

np accepted D26800: Handle CPL_RX_DATA on active TLS sockets..
Thu, Oct 22, 11:55 PM
np committed rS366941: if_vxlan(4): csum_flags_to_inner_flags takes the tunnel protocol as a parameter..
if_vxlan(4): csum_flags_to_inner_flags takes the tunnel protocol as a parameter.
Thu, Oct 22, 5:06 PM
np committed rS366929: cxgbe(4): fix the size of the iq/eq maps..
cxgbe(4): fix the size of the iq/eq maps.
Thu, Oct 22, 8:40 AM

Wed, Oct 21

np accepted D26800: Handle CPL_RX_DATA on active TLS sockets..
Wed, Oct 21, 10:40 PM
np added inline comments to D26800: Handle CPL_RX_DATA on active TLS sockets..
Wed, Oct 21, 10:40 PM
np accepted D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.
Wed, Oct 21, 10:07 PM
np committed rS366916: cxgbe(4): display correct tid range for T6 based -SO cards..
cxgbe(4): display correct tid range for T6 based -SO cards.
Wed, Oct 21, 8:42 PM

Mon, Oct 19

np committed rS366862: cxgbe(4): Updates to the drop features from r366532..
cxgbe(4): Updates to the drop features from r366532.
Mon, Oct 19, 9:11 PM
np committed rS366853: cxgbe(4): Fix page fault in t4_get_lb_stats with 2 port T5 cards..
cxgbe(4): Fix page fault in t4_get_lb_stats with 2 port T5 cards.
Mon, Oct 19, 8:09 PM
np commandeered D26334: cxgbe: Apply more checks for INET and INET6.

okay, I'll take care of this.

Mon, Oct 19, 6:39 PM
np accepted D26803: Check TF_TOE not the tod pointer to determine if TOE is active..
Mon, Oct 19, 5:29 PM
np accepted D26799: Re-enable receive flow control for TOE TLS sockets..
Mon, Oct 19, 5:28 PM
np accepted D26334: cxgbe: Apply more checks for INET and INET6.
Mon, Oct 19, 5:27 PM
np added a comment to D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.

The page fault in t4_get_lb_stats with my T580-LP-SO-CR was fun.

Mon, Oct 19, 6:12 AM

Sun, Oct 18

np requested changes to D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.

I don't see any change in behavior. My test setup has a T6 card and cxgbe(4) is loaded. Then I run

Sun, Oct 18, 7:34 AM

Wed, Oct 14

np committed rS366696: cxgbe(4): Do not request FEC when requesting speeds that don't have FEC..
cxgbe(4): Do not request FEC when requesting speeds that don't have FEC.
Wed, Oct 14, 10:12 AM
np committed rS366694: cxgbe(4): unimplemented cudbg routines should return the correct.
cxgbe(4): unimplemented cudbg routines should return the correct
Wed, Oct 14, 8:04 AM

Fri, Oct 9

np committed rS366589: cxgbe(4): More fixes for the T6 FCS error counter..
cxgbe(4): More fixes for the T6 FCS error counter.
Fri, Oct 9, 10:24 PM

Thu, Oct 8

np committed rS366532: cxgbe(4): knobs to drop various kinds of undesirable frames on ingress..
cxgbe(4): knobs to drop various kinds of undesirable frames on ingress.
Thu, Oct 8, 10:00 AM

Mon, Oct 5

np committed rS366467: cxgbe(4) sysctls do not need Giant..
cxgbe(4) sysctls do not need Giant.
Mon, Oct 5, 10:18 PM
np accepted D26689: Store the send tag type in the common send tag header..
Mon, Oct 5, 9:23 PM
np committed rS366463: MFC r366354:.
MFC r366354:
Mon, Oct 5, 7:45 PM
np committed rS366460: MFC r366247:.
MFC r366247:
Mon, Oct 5, 7:22 PM
np committed rS366459: MFC r366246:.
MFC r366246:
Mon, Oct 5, 6:59 PM
np committed rS366458: MFC r366245:.
MFC r366245:
Mon, Oct 5, 6:50 PM
np committed rS366457: MFC r366244:.
MFC r366244:
Mon, Oct 5, 6:47 PM
np committed rS366455: MFC r366242:.
MFC r366242:
Mon, Oct 5, 6:45 PM
np committed rS366451: MFS r366438:.
MFS r366438:
Mon, Oct 5, 4:40 PM
np committed rS366443: MFC r365993:.
MFC r365993:
Mon, Oct 5, 9:03 AM
np committed rS366442: MFC r365871. This needs a couple other revisions which aren't in.
MFC r365871. This needs a couple other revisions which aren't in
Mon, Oct 5, 8:51 AM
np committed rS366441: MFC r365868:.
MFC r365868:
Mon, Oct 5, 7:26 AM
np committed rS366440: Get tools/tools/cxgbtool to build with the latest clang..
Get tools/tools/cxgbtool to build with the latest clang.
Mon, Oct 5, 6:53 AM
np committed rS366439: MFC r365867:.
MFC r365867:
Mon, Oct 5, 6:39 AM
np committed rS366438: MFC r366384:.
MFC r366384:
Mon, Oct 5, 5:36 AM

Fri, Oct 2

np committed rS366384: cxgbe(4): set up the firmware flowc for the tid before send_abort_rpl..
cxgbe(4): set up the firmware flowc for the tid before send_abort_rpl.
Fri, Oct 2, 11:49 PM
np committed rS366354: cxgbe(4): validate largest_rx_cluster and safest_rx_cluster..
cxgbe(4): validate largest_rx_cluster and safest_rx_cluster.
Fri, Oct 2, 6:00 AM

Wed, Sep 30

np committed rS366274: MFC r365991:.
MFC r365991:
Wed, Sep 30, 12:13 AM

Tue, Sep 29

np committed rS366272: MFC r349533 (by jhb@)..
MFC r349533 (by jhb@).
Tue, Sep 29, 11:36 PM
np committed rS366247: cxgbe(4): Avoid unnecessary work in the firmware during netmap tx..
cxgbe(4): Avoid unnecessary work in the firmware during netmap tx.
Tue, Sep 29, 9:25 AM
np committed rS366246: Remove duplicate line..
Remove duplicate line.
Tue, Sep 29, 9:11 AM
np committed rS366245: cxgbe(4): adjust the doorbell threshold for netmap freelists to match the.
cxgbe(4): adjust the doorbell threshold for netmap freelists to match the
Tue, Sep 29, 7:51 AM
np committed rS366244: cxgbe(4): display an error message when netmap cannot be enabled because.
cxgbe(4): display an error message when netmap cannot be enabled because
Tue, Sep 29, 7:36 AM
np committed rS366242: cxgbe(4): fixes for netmap operation with only some queues active..
cxgbe(4): fixes for netmap operation with only some queues active.
Tue, Sep 29, 5:08 AM

Mon, Sep 28

np accepted D26582: Fallback to software for more GCM and CCM requests..
Mon, Sep 28, 8:26 PM

Sep 22 2020

np committed rS365993: cxgbe(4): let the PF driver use VM work requests for transmit..
cxgbe(4): let the PF driver use VM work requests for transmit.
Sep 22 2020, 4:16 AM
np committed rS365991: cxgbe(4): add counters for mbuf pullups and defrags..
cxgbe(4): add counters for mbuf pullups and defrags.
Sep 22 2020, 3:06 AM

Sep 21 2020

np committed rS365961: MFS r365937, which merged r365861 and r365872 from head to stable/12..
MFS r365937, which merged r365861 and r365872 from head to stable/12.
Sep 21 2020, 6:20 PM
np committed rS365937: MFC r365861 and r365872..
MFC r365861 and r365872.
Sep 21 2020, 8:17 AM

Sep 18 2020

np committed rS365872: cxgbe(4): add the firmware binaries instead of the empty files that were added.
cxgbe(4): add the firmware binaries instead of the empty files that were added
Sep 18 2020, 3:11 AM
np committed rS365871: cxgbe(4): add support for stateless offloads for VXLAN traffic..
cxgbe(4): add support for stateless offloads for VXLAN traffic.
Sep 18 2020, 3:02 AM
np committed rS365870: if_vxlan(4): add support for hardware assisted checksumming, TSO, and RSS..
if_vxlan(4): add support for hardware assisted checksumming, TSO, and RSS.
Sep 18 2020, 2:38 AM
np committed rS365869: Add a knob to allow zero UDP checksums for UDP/IPv6 traffic on the given UDP….
Add a knob to allow zero UDP checksums for UDP/IPv6 traffic on the given UDP…
Sep 18 2020, 2:21 AM
np committed rS365868: Add two new ifnet capabilities for hw checksumming and TSO for VXLAN traffic..
Add two new ifnet capabilities for hw checksumming and TSO for VXLAN traffic.
Sep 18 2020, 2:10 AM
np committed rS365867: mbuf checksum flags and fields to support tunneling protocols..
mbuf checksum flags and fields to support tunneling protocols.
Sep 18 2020, 1:39 AM
np closed D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..
Sep 18 2020, 1:39 AM

Sep 17 2020

np committed rS365861: cxgbe(4): Update T4/5/6 firmwares to 1.25.0.0..
cxgbe(4): Update T4/5/6 firmwares to 1.25.0.0.
Sep 17 2020, 10:14 PM

Sep 14 2020

np committed rS365732: cxgbe(4): Get the count of FCS errors from the MAC and not MPS for T6 ports..
cxgbe(4): Get the count of FCS errors from the MAC and not MPS for T6 ports.
Sep 14 2020, 10:16 PM

Sep 1 2020

np added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Thanks for the review, kib@.

Sep 1 2020, 10:21 PM

Aug 31 2020

np committed rS365014: cxgbe(4): Check for descriptors before writing a TLS or raw work request..
cxgbe(4): Check for descriptors before writing a TLS or raw work request.
Aug 31 2020, 10:45 PM
np updated the diff for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Serial all VXLAN start/stops (even across different VXLAN interfaces).

Aug 31 2020, 9:26 PM

Aug 30 2020

np updated the diff for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Add a global sx and hold it around the VXLAN start/stop events.

Aug 30 2020, 10:38 PM

Aug 26 2020

np committed rS364849: MFC r358924:.
MFC r358924:
Aug 26 2020, 11:42 PM
np committed rS364848: MFC r340023 (by jhb@), r362905, r362938, and r363167..
MFC r340023 (by jhb@), r362905, r362938, and r363167.
Aug 26 2020, 11:21 PM

Aug 25 2020

np committed rS364776: MFC r363498:.
MFC r363498:
Aug 25 2020, 6:21 PM
np committed rS364774: MFC r364444:.
MFC r364444:
Aug 25 2020, 6:12 PM
np committed rS364750: MFC r362616:.
MFC r362616:
Aug 25 2020, 2:55 AM
np committed rS364748: MFC r362532:.
MFC r362532:
Aug 25 2020, 2:42 AM
np committed rS364745: MFC r351444, r357475, r357479, r357481-r357482, r358859, and r364497..
MFC r351444, r357475, r357479, r357481-r357482, r358859, and r364497.
Aug 25 2020, 2:15 AM

Aug 23 2020

np committed rS364497: cxgbe(4): Use large clusters for TOE rx queues when TOE+TLS is enabled..
cxgbe(4): Use large clusters for TOE rx queues when TOE+TLS is enabled.
Aug 23 2020, 4:16 AM
np closed D26127: cxgbe(4): Use 16K clusters for offload rx queues when the chip supports mode TLS decryption for offloaded connections..
Aug 23 2020, 4:16 AM

Aug 21 2020

np committed rS364444: cxgbei: destroy the worker threads' CV and mutex in stop_worker_threads..
cxgbei: destroy the worker threads' CV and mutex in stop_worker_threads.
Aug 21 2020, 12:34 AM

Aug 20 2020

np updated the diff for D26127: cxgbe(4): Use 16K clusters for offload rx queues when the chip supports mode TLS decryption for offloaded connections..

Remove debug leftovers.

Aug 20 2020, 1:02 AM
np requested review of D26127: cxgbe(4): Use 16K clusters for offload rx queues when the chip supports mode TLS decryption for offloaded connections..
Aug 20 2020, 12:55 AM

Aug 19 2020

np added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

And the refcount underflow check is for the case where a VXLAN is created/started before the NIC driver is kldloaded. It will miss the create/start event but will see the destroy/stop and get confused. The real fix would be to have a count of VXLAN interfaces somewhere and have the driver seed its initial refcount with this value. But if_vxlan itself is a loadable module so this counter would have to be in the kernel proper, or else there would have to be a query function in if_vxlan that is called indirectly (like the vlan functions). I thought all this was too complicated for an unusual case. If users make sure all NIC drivers are loaded before creating VXLANs then there is no problem with missed events.

Aug 19 2020, 9:58 PM
np added inline comments to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..
Aug 19 2020, 9:51 PM
np added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..
In D25873#579567, @kib wrote:

This patch naturally splits into many chunks, for instance RFC7348 port, inner checksums infra, events, driver bits. Do you plan to do more fine-grained commits that one big ci ?

Aug 19 2020, 8:46 PM
np updated the diff for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

incorporate some feedback from kib@

Aug 19 2020, 8:39 PM
np added inline comments to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..
Aug 19 2020, 8:38 PM

Aug 17 2020

np updated the diff for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Tx counters that track hw assistance should consider all inner traffic
irrespective of the IP version of the outer encapsulation.

Aug 17 2020, 6:02 PM

Aug 5 2020

np updated the diff for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Handle rxcsum and rxcsum6 correctly.

Aug 5 2020, 7:07 PM

Aug 3 2020

np updated the diff for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Disable TSO when tx checksumming is disabled.
Add counters for checksums and TSO.

Aug 3 2020, 9:55 PM

Jul 31 2020

np added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..
In D25873#573657, @kib wrote:
In D25873#573638, @np wrote:

The goal is to improve vxlan's performance. mbuf tags would add at least an alloc/free and extra access(es) to the tags (which are on a linked list) on the hot path. Why even consider any other location for the flags if there _are_ bits available in the proper place right now. We'll be out of them after this change, we aren't out already.

Where VNI is currently stored when packet is pushed up or down to driver, for stateless offload ?

Jul 31 2020, 2:28 AM

Jul 30 2020

np added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..
In D25873#573627, @np wrote:

Aren't we soon running out of flag bits in certain integer values?

Given that the inner flags mirror the outer ones, why not use a different variable inner_flags with the same set of flags?

That would work, but it would increase the size of struct mbuf.

So let's move the vxnet specific flags into a mbuf_tag.

Jul 30 2020, 8:31 PM
np added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Aren't we soon running out of flag bits in certain integer values?

Given that the inner flags mirror the outer ones, why not use a different variable inner_flags with the same set of flags?

Jul 30 2020, 7:58 PM
np added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Aren't we soon running out of flag bits in certain integer values?

Jul 30 2020, 7:32 PM

Jul 29 2020

np updated the diff for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Remove comment.

Jul 29 2020, 6:32 PM
np added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

May you please consider splitting the patch into functional groups?

  • VXLAN HW capabilities
  • Spelling errors
  • Logic cleanup "xxx == 0" vs "!xxx"
  • style cleanup
Jul 29 2020, 3:09 PM
np accepted D25838: Properly handle a closed TLS socket with pending receive data..
Jul 29 2020, 2:40 PM
np requested review of D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..
Jul 29 2020, 12:56 AM

Jul 27 2020

np accepted D25767: cxgbe(4): Stop checking for failures from malloc(M_WAITOK)..
Jul 27 2020, 4:20 PM

Jul 24 2020

np committed rS363498: cxgbe(4): Some updates to the common code..
cxgbe(4): Some updates to the common code.
Jul 24 2020, 11:15 PM

Jul 13 2020

np committed rS363167: cxgbev(4): Compare at most 16 bytes of the Ethernet header when trying.
cxgbev(4): Compare at most 16 bytes of the Ethernet header when trying
Jul 13 2020, 7:15 PM

Jul 5 2020

np committed rS362938: cxgbe(4): Fix a bug (introduced in r362905) where some tx traffic wasn't.
cxgbe(4): Fix a bug (introduced in r362905) where some tx traffic wasn't
Jul 5 2020, 5:15 AM

Jul 3 2020

np closed D25454: cxgbe(4): changes in the Tx path to help increase tx coalescing..
Jul 3 2020, 4:44 AM
np committed rS362905: cxgbe(4): changes in the Tx path to help increase tx coalescing..
cxgbe(4): changes in the Tx path to help increase tx coalescing.
Jul 3 2020, 4:44 AM
np updated the diff for D25454: cxgbe(4): changes in the Tx path to help increase tx coalescing..

Incorporate feedback. atomic_load_64 is now used everywhere to read state.

Jul 3 2020, 12:17 AM

Jun 25 2020

np accepted D25457: Reduce contention on per-adapter lock..
Jun 25 2020, 11:28 PM
np requested review of D25454: cxgbe(4): changes in the Tx path to help increase tx coalescing..
Jun 25 2020, 5:08 PM