Page MenuHomeFreeBSD

np (Navdeep Parhar)
User

Projects

User Details

User Since
Dec 12 2014, 10:38 PM (493 w, 1 d)

Recent Activity

Fri, May 17

np committed rG64a00f877fc2: cxgbe(4): Consolidate all mk_set_tcb_field_ulp in one place. (authored by np).
cxgbe(4): Consolidate all mk_set_tcb_field_ulp in one place.
Fri, May 17, 10:58 PM
np committed rGcca3506dc154: cxgbe(4): sc->port is indexed by port_id and not tx_chan. (authored by np).
cxgbe(4): sc->port is indexed by port_id and not tx_chan.
Fri, May 17, 10:46 PM

Wed, May 1

np committed rGc6c6d4aff90d: cxgbe/tom: Fix the rx channel selection in options2. (authored by np).
cxgbe/tom: Fix the rx channel selection in options2.
Wed, May 1, 12:15 AM
np committed rG7f10048f983a: cxgbe(4): Query TPCHMAP once and not once per port. (authored by np).
cxgbe(4): Query TPCHMAP once and not once per port.
Wed, May 1, 12:00 AM
np committed rG480ff89c67b2: cxgbe(4): Rename rx_c_chan to rx_chan. (authored by np).
cxgbe(4): Rename rx_c_chan to rx_chan.
Wed, May 1, 12:00 AM

Tue, Apr 30

np committed rG21aba396551e: cxgbe(4): Minor tweaks to comments. (authored by np).
cxgbe(4): Minor tweaks to comments.
Tue, Apr 30, 8:05 PM
np committed rG9de0036b55dc: cxgbe(4): Initialize mps_bg_map to an invalid value if it's not known. (authored by np).
cxgbe(4): Initialize mps_bg_map to an invalid value if it's not known.
Tue, Apr 30, 8:05 PM
np committed rG4d1362cdc737: cxgbe(4): Do not read hardware registers to determine the number of ports. (authored by np).
cxgbe(4): Do not read hardware registers to determine the number of ports.
Tue, Apr 30, 8:05 PM
np committed rG857d74b6340e: cxgbe(4): Allocate a taskqueue per port instead of per channel. (authored by np).
cxgbe(4): Allocate a taskqueue per port instead of per channel.
Tue, Apr 30, 6:21 PM

Mon, Apr 29

np committed rG2965ae591441: cxgbe(4): Shared code update to deal with partial failure in query_params. (authored by np).
cxgbe(4): Shared code update to deal with partial failure in query_params.
Mon, Apr 29, 9:03 PM
np committed rG43f6f0848804: cxgbe(4): Reword the comment explaining the atid/cookie split. (authored by np).
cxgbe(4): Reword the comment explaining the atid/cookie split.
Mon, Apr 29, 8:49 PM
np committed rGf0ee6112eb61: cxgbe(4): Add missing description for a port type. (authored by np).
cxgbe(4): Add missing description for a port type.
Mon, Apr 29, 8:33 PM
np committed rG1c7f9c8b4673: cxgbe(4): Retire t4_intr_clear. (authored by np).
cxgbe(4): Retire t4_intr_clear.
Mon, Apr 29, 7:46 PM
np committed rGb59c5d97edf1: cxgbe(4): Add a helper function to locate MPS/MAC registers. (authored by np).
cxgbe(4): Add a helper function to locate MPS/MAC registers.
Mon, Apr 29, 7:33 PM
np committed rGf76effed14b2: cxgbe(4): Remove tx_modq lookup table. (authored by np).
cxgbe(4): Remove tx_modq lookup table.
Mon, Apr 29, 6:36 PM

Mar 19 2024

np accepted D44435: cxgbe tom: Handle a race condition when enabling TLS offload.
Mar 19 2024, 11:28 PM

Feb 21 2024

np accepted D43999: ddp: Clear active DDP buffer members to NULL to pacify assertion.
Feb 21 2024, 1:26 AM

Feb 12 2024

np created P631 panic on ampere emag.
Feb 12 2024, 6:45 PM

Jan 30 2024

np accepted D43670: cxgbe tom: Enable ULP_MODE_TCPDDP on demand.
Jan 30 2024, 5:08 PM
np accepted D43669: cxgbe tom: Limit TOE connections to 2 reassembly islands always.
Jan 30 2024, 5:07 PM
np accepted D43668: cxgbe: Add counters for POSIX async I/O requests handled by the driver.
Jan 30 2024, 5:01 PM

Jan 11 2024

np committed rG1c336d39156c: cxgbe(4): Update firmwares to 1.27.5.0 (authored by np).
cxgbe(4): Update firmwares to 1.27.5.0
Jan 11 2024, 5:36 AM
np committed rG2cca64fbe579: cxgbe(4): Use the correct size for the CIM LA on the T6. (authored by np).
cxgbe(4): Use the correct size for the CIM LA on the T6.
Jan 11 2024, 5:36 AM
np committed rG3a507508e365: cxgbe(4): Fix virtual interface reattach. (authored by np).
cxgbe(4): Fix virtual interface reattach.
Jan 11 2024, 5:36 AM
np committed rG86ad0ace9c05: cxgbe(4): Destroy the tick mutex during VI detach. (authored by np).
cxgbe(4): Destroy the tick mutex during VI detach.
Jan 11 2024, 5:36 AM
np committed rGfe77cfce0180: cxgbe(4): Update firmwares to 1.27.4.0 (authored by np).
cxgbe(4): Update firmwares to 1.27.4.0
Jan 11 2024, 5:36 AM
np committed rG5f884ac086ed: cxgbe(4): Update firmwares to version 1.27.3.0 (authored by np).
cxgbe(4): Update firmwares to version 1.27.3.0
Jan 11 2024, 5:35 AM
np committed rGb9ead2c2e71c: cxgbe(4): Dump the firmware log before falling back to a minimal config. (authored by np).
cxgbe(4): Dump the firmware log before falling back to a minimal config.
Jan 11 2024, 5:35 AM
np committed rG8b7e008183c9: cxgbe/iw_cxgbe: debug routines to dump STAG (steering tag) entries. (authored by np).
cxgbe/iw_cxgbe: debug routines to dump STAG (steering tag) entries.
Jan 11 2024, 5:35 AM
np committed rGf0eedbcd8039: cxgbetool(8): Add support for tracing loopback traffic for a port. (authored by np).
cxgbetool(8): Add support for tracing loopback traffic for a port.
Jan 11 2024, 5:35 AM
np committed rG0e3fce67f1e5: cxgbe(4): Allow tracing filters on loopback ports. (authored by np).
cxgbe(4): Allow tracing filters on loopback ports.
Jan 11 2024, 5:35 AM
np committed rGd7623fdcf0f0: cxgbe(4): Use the correct size for the CIM LA on the T6. (authored by np).
cxgbe(4): Use the correct size for the CIM LA on the T6.
Jan 11 2024, 5:35 AM
np committed rG3368fcf147a7: cxgbe(4): Remove dead code. (authored by np).
cxgbe(4): Remove dead code.
Jan 11 2024, 5:35 AM
np committed rGc4bac077581e: cxgbe(4): Add support for netmap offsets. (authored by np).
cxgbe(4): Add support for netmap offsets.
Jan 11 2024, 5:35 AM
np committed rGc2628605787d: cxgbe(4): Update firmwares to 1.27.5.0 (authored by np).
cxgbe(4): Update firmwares to 1.27.5.0
Jan 11 2024, 5:35 AM
np committed rG7d98a455a3ea: cxgbe(4): Fix virtual interface reattach. (authored by np).
cxgbe(4): Fix virtual interface reattach.
Jan 11 2024, 5:35 AM
np committed rG2a2aec721fff: cxgbe(4): Destroy the tick mutex during VI detach. (authored by np).
cxgbe(4): Destroy the tick mutex during VI detach.
Jan 11 2024, 5:34 AM

Jan 9 2024

np committed rG9ea86c8f67a6: cxgbe(4): Use the correct size for the CIM LA on the T6. (authored by np).
cxgbe(4): Use the correct size for the CIM LA on the T6.
Jan 9 2024, 9:52 PM

Jan 8 2024

np committed rGdf8a58b17a19: cxgbe(4): Add support for netmap offsets. (authored by np).
cxgbe(4): Add support for netmap offsets.
Jan 8 2024, 8:10 PM

Jan 4 2024

np committed rGb1e82d33193b: cxgbe(4): Update firmwares to 1.27.5.0 (authored by np).
cxgbe(4): Update firmwares to 1.27.5.0
Jan 4 2024, 8:42 PM

Jan 3 2024

np closed D43287: cxgbe(4): Fix virtual interface reattach..
Jan 3 2024, 7:27 PM
np committed rG0201eb29dde9: cxgbe(4): Fix virtual interface reattach. (authored by np).
cxgbe(4): Fix virtual interface reattach.
Jan 3 2024, 7:27 PM
np added a comment to D43166: tcp: bypass TSO when CWR bit is to be sent.
In D43166#986875, @np wrote:

b) If FIN/PSH are set in tcp flags then they will be set in the flags for the last segment only.
c) If CWR is set in the TCP hdr it is set in the hdr of the first segment only. The ECE bit is copied to all segments.
d) If there are IP options they are copied into each segment unaltered. This means if TCP timestamp option is in use the chip will use the same timestamp in all the segments for the TSO.

Thanks Navdeep!

Is there a r/w mask register similar to what Intel NICs offer available in the cxgbe hardware, to modify specifically the CWR behavior?

Jan 3 2024, 7:04 PM
np added a comment to D43166: tcp: bypass TSO when CWR bit is to be sent.

OK, I'm sorry, I was not aware of AccECN and its desired behavior of setting CWR on all segments.

In any case, a system wide tunable is probably not the correct approach. We would want to have the driver set a bit to advertise which ECN modes it supports. If there is hardware that supports both, and the driver cannot determine easily from the packet itself if normal ECN or AccECN should be used, we probably also need to hint to the driver which ECN mode should be used.

I'd like to see some input from NIC vendors here, so I'm glad @np is on the review.

Jan 3 2024, 6:47 PM
np requested review of D43287: cxgbe(4): Fix virtual interface reattach..
Jan 3 2024, 12:12 AM
np committed rG8b144c015c9c: cxgbe(4): Destroy the tick mutex during VI detach. (authored by np).
cxgbe(4): Destroy the tick mutex during VI detach.
Jan 3 2024, 12:07 AM

Oct 31 2023

np committed rG7523a37f68ec: Fix build with gcc12. (authored by np).
Fix build with gcc12.
Oct 31 2023, 5:45 PM

Oct 27 2023

np committed rGc656f5c1a6f8: Fix build with gcc12. (authored by np).
Fix build with gcc12.
Oct 27 2023, 11:41 PM

Sep 19 2023

np committed rGdda585f2c84b: cxgbe(4): Avoid hang on kldunload on netlink enabled kernels. (authored by np).
cxgbe(4): Avoid hang on kldunload on netlink enabled kernels.
Sep 19 2023, 2:30 PM
np committed rGf976dbaeb482: cxgbe(4): Fix tracing with netlink enabled kernels. (authored by np).
cxgbe(4): Fix tracing with netlink enabled kernels.
Sep 19 2023, 2:30 PM

Sep 18 2023

np committed rG38da3db5f9e3: cxgbe(4): Fix tracing with netlink enabled kernels. (authored by np).
cxgbe(4): Fix tracing with netlink enabled kernels.
Sep 18 2023, 7:12 PM
np committed rG3287f64a7314: cxgbe(4): Avoid hang on kldunload on netlink enabled kernels. (authored by np).
cxgbe(4): Avoid hang on kldunload on netlink enabled kernels.
Sep 18 2023, 7:12 PM

Sep 10 2023

np committed rGe203cb393fe0: cxgbe(4): Fix tracing with netlink enabled kernels. (authored by np).
cxgbe(4): Fix tracing with netlink enabled kernels.
Sep 10 2023, 2:30 PM

Sep 6 2023

np accepted D41688: cxgbe tom: Call t4_rcvd_locked from do_rx_data to return RX credits.
Sep 6 2023, 6:24 PM

Sep 5 2023

np committed rG3814249f1e8d: cxgbe(4): Avoid hang on kldunload on netlink enabled kernels. (authored by np).
cxgbe(4): Avoid hang on kldunload on netlink enabled kernels.
Sep 5 2023, 10:16 PM

Aug 16 2023

np committed rG8a2e880ab07f: cxgbe(4): Update firmwares to 1.27.4.0 (authored by np).
cxgbe(4): Update firmwares to 1.27.4.0
Aug 16 2023, 4:16 PM

Jul 20 2023

np committed rGa29916a6f8f5: ifconfig_netlink.c: whitespace cleanup. (authored by np).
ifconfig_netlink.c: whitespace cleanup.
Jul 20 2023, 5:56 PM
np committed rG88284368fa6b: ifconfig: Shift unsigned value to avoid UB. (authored by np).
ifconfig: Shift unsigned value to avoid UB.
Jul 20 2023, 5:56 PM
np committed rG47b1fef6fb22: ifconfig: Fix the display of capabilities in the netlink based code. (authored by np).
ifconfig: Fix the display of capabilities in the netlink based code.
Jul 20 2023, 5:29 PM
np closed D41107: ifconfig: Fix the display of capabilities in the netlink based code..
Jul 20 2023, 5:29 PM
np added inline comments to D41107: ifconfig: Fix the display of capabilities in the netlink based code..
Jul 20 2023, 5:27 PM
np added a comment to D41107: ifconfig: Fix the display of capabilities in the netlink based code..

I am experimenting with some additional caps that use bits in capabilities2/capenable2 and that's how I ran into this.

Jul 20 2023, 1:28 AM
np requested review of D41107: ifconfig: Fix the display of capabilities in the netlink based code..
Jul 20 2023, 1:26 AM

Jul 19 2023

np closed D41100: ktls_alloc_rcv_tag: Fix capability checks for RXTLS4/6..
Jul 19 2023, 6:18 PM
np committed rGc721694a1ca8: ktls_alloc_rcv_tag: Fix capability checks for RXTLS4/6. (authored by np).
ktls_alloc_rcv_tag: Fix capability checks for RXTLS4/6.
Jul 19 2023, 6:17 PM
np added reviewers for D41100: ktls_alloc_rcv_tag: Fix capability checks for RXTLS4/6.: kib, jhb.
Jul 19 2023, 5:58 PM
np requested review of D41100: ktls_alloc_rcv_tag: Fix capability checks for RXTLS4/6..
Jul 19 2023, 5:57 PM

May 26 2023

np added a comment to D39865: cxgbe: use new cloners KPI..

Ping :-)
I'd love to get rid of if_clone_advanced() before 14 and cxgbe is the only remaining user :-)

May 26 2023, 4:40 PM

May 3 2023

np added a comment to D39865: cxgbe: use new cloners KPI..

Almost there. Now the new ifnet is created successfully but there is an extra 0 in its name. The ifnet should have been t6nex0 and not t6nex00.

May 3 2023, 1:16 AM

Apr 28 2023

np added a comment to D39865: cxgbe: use new cloners KPI..

The if_name2unit call in if_clone_createif_nl -> ifc_handle_unit seems to be the problem. It is returning EINVAL because it doesn't like the 0 in "t6nex0".

Apr 28 2023, 5:47 PM
np requested changes to D39865: cxgbe: use new cloners KPI..

I tried this change but the cloned interface was not created.

Apr 28 2023, 5:08 PM

Apr 21 2023

np committed rGca5391bd8579: cxgbe(4): Update firmwares to version 1.27.3.0 (authored by np).
cxgbe(4): Update firmwares to version 1.27.3.0
Apr 21 2023, 3:59 AM

Apr 20 2023

np committed rG27913351047b: cxgbe(4): Dump the firmware log before falling back to a minimal config. (authored by np).
cxgbe(4): Dump the firmware log before falling back to a minimal config.
Apr 20 2023, 8:20 PM

Apr 19 2023

np committed rG7adf138ba9b9: cxgbe/iw_cxgbe: debug routines to dump STAG (steering tag) entries. (authored by np).
cxgbe/iw_cxgbe: debug routines to dump STAG (steering tag) entries.
Apr 19 2023, 4:52 PM

Apr 12 2023

np accepted D37881: cxgbetool(8): cleanup.

Sorry I missed this previously. This man page has a dependency on groff and I'd like to get rid of it eventually (the dependency, not the man page). But my manpage-fu is weak and I'm not sure how to figure out exactly which parts need groff. Will these proposed changes make any difference as far as reliance on groff goes? Okay to check this in either way.

Apr 12 2023, 3:16 AM

Apr 2 2023

np committed rG4913a24e7910: cxgbetool(8): Add support for tracing loopback traffic for a port. (authored by np).
cxgbetool(8): Add support for tracing loopback traffic for a port.
Apr 2 2023, 1:11 AM
np committed rG9f354cd3d017: cxgbe(4): Allow tracing filters on loopback ports. (authored by np).
cxgbe(4): Allow tracing filters on loopback ports.
Apr 2 2023, 1:11 AM
np committed rG531ef35241b5: cxgbe/iw_cxgbe: Always set a vnet around calls to IN_LOOPBACK. (authored by np).
cxgbe/iw_cxgbe: Always set a vnet around calls to IN_LOOPBACK.
Apr 2 2023, 1:10 AM

Mar 30 2023

np committed rG21b778fbeb93: cxgbe(4): Remove dead code. (authored by np).
cxgbe(4): Remove dead code.
Mar 30 2023, 9:17 PM

Mar 8 2023

np accepted D38971: krping: Use get_cyclecount for get_cycles..
Mar 8 2023, 5:00 PM

Mar 7 2023

np accepted D38597: Mechanically convert if_cxgb(4) and if_cxgbe(4) to IfAPI.
Mar 7 2023, 7:07 PM

Feb 28 2023

np added inline comments to D38597: Mechanically convert if_cxgb(4) and if_cxgbe(4) to IfAPI.
Feb 28 2023, 2:06 AM
np added a comment to D38597: Mechanically convert if_cxgb(4) and if_cxgbe(4) to IfAPI.

I'm done looking at the cxgb part, will look at cxgbe next.

Feb 28 2023, 1:32 AM

Feb 16 2023

np accepted D38579: cxgbe: Queue NIC TLS mbufs internally..
Feb 16 2023, 5:35 PM
np accepted D38577: cxgbe: Allow parse_pkt to internally queue a packet..
Feb 16 2023, 5:33 PM

Feb 15 2023

np accepted D38578: cxgbe: Move helper functions for mbuf metadata to adapter.h..
Feb 15 2023, 7:12 PM
np accepted D38580: cxgbe: Don't leak memory resource if t4iov attach fails..
Feb 15 2023, 7:10 PM
np added a comment to D38597: Mechanically convert if_cxgb(4) and if_cxgbe(4) to IfAPI.

Was this done with some coccinelle type script or something similar? I have a bunch of code that is not upstream yet and it is not ifAPI style. If there's a script I could run pre-commit to make sure any new code is ifAPI clean it would be quite useful.

Feb 15 2023, 5:45 PM

Feb 2 2023

np committed rGf9cc817c17b7: cxgbe/t4_tom: Support for round-robin selection of offload queues. (authored by np).
cxgbe/t4_tom: Support for round-robin selection of offload queues.
Feb 2 2023, 7:45 AM
np committed rGdde4103a465b: pciconf(8): Decode ACS extended capability. (authored by np).
pciconf(8): Decode ACS extended capability.
Feb 2 2023, 7:40 AM
np committed rG0d7de5477378: pcireg.h: Add values for ACS PCIe Extended capability. (authored by np).
pcireg.h: Add values for ACS PCIe Extended capability.
Feb 2 2023, 7:40 AM
np committed rG0d15ab14a4f4: cxgbe/cxgbei: Do not validate the hardware iSCSI tag mask. (authored by np).
cxgbe/cxgbei: Do not validate the hardware iSCSI tag mask.
Feb 2 2023, 7:40 AM
np committed rG5adfcaeacafa: cxgbe(4): Add another setting to the knob that controls congestion. (authored by np).
cxgbe(4): Add another setting to the knob that controls congestion.
Feb 2 2023, 7:40 AM
np committed rGbeb8eaf79368: cxgbe/tom: Fix assertions in the code that maintains TCB history. (authored by np).
cxgbe/tom: Fix assertions in the code that maintains TCB history.
Feb 2 2023, 7:40 AM
np committed rGaf0f5fe24c9b: cxgbe(4): Specify the ingress queue's type when creating it. (authored by np).
cxgbe(4): Specify the ingress queue's type when creating it.
Feb 2 2023, 7:40 AM
np committed rG1b3027b10541: cxgbe(4): Add knob to control congestion behavior for TOE queues. (authored by np).
cxgbe(4): Add knob to control congestion behavior for TOE queues.
Feb 2 2023, 7:40 AM
np committed rG35c9bbff4342: cxgbe(4): Add a knob to request that clocks be gated on suspend. (authored by np).
cxgbe(4): Add a knob to request that clocks be gated on suspend.
Feb 2 2023, 7:40 AM
np committed rG5d57964698e8: cxgbetool: remove unnecessary vertical whitespace. (authored by np).
cxgbetool: remove unnecessary vertical whitespace.
Feb 2 2023, 7:40 AM
np committed rG886a5109c84a: cxgbe(4): Update firmwares to 1.27.0.0. (authored by np).
cxgbe(4): Update firmwares to 1.27.0.0.
Feb 2 2023, 7:40 AM
np committed rG6c2b290e579a: cxgbe(4): Decode and display some more bits in the PL interrupt handler. (authored by np).
cxgbe(4): Decode and display some more bits in the PL interrupt handler.
Feb 2 2023, 7:40 AM