Page MenuHomeFreeBSD
Feed Advanced Search

Today

np committed rS342208: cxgbe/t4_tom: fixes for issues on the passive open side..
cxgbe/t4_tom: fixes for issues on the passive open side.
Wed, Dec 19, 1:37 AM

Thu, Dec 6

np committed rS341654: cxgbe(4): Get Linux cxgb4vf working in bhyve VMs with VFs passed.
cxgbe(4): Get Linux cxgb4vf working in bhyve VMs with VFs passed
Thu, Dec 6, 9:33 PM
np committed rS341620: cxgbe(4): Fall back to a basic configuration in case of any error during.
cxgbe(4): Fall back to a basic configuration in case of any error during
Thu, Dec 6, 6:18 AM

Thu, Nov 29

np accepted D18384: Make most of the CLIP code conditional on #ifdef INET6..
Thu, Nov 29, 11:07 PM

Tue, Nov 27

np accepted D17987: netmap: set IFCAP_NETMAP in if_capabilities.

The truth is that netmap not setting the IFCAP_NETMAP flag in ifp->if_capabilities after r307394 is a mistake that we did not notice so far.
It got introduced by refactoring, 3 years ago (see https://github.com/luigirizzo/netmap/commit/5d0796f93a1107eb14422c7b8ea416f7fd750a2e).
Sorry for that, it was unintended.
I just happened to notice that and fix it.

Tue, Nov 27, 8:12 PM
np accepted D18360: Add read-only sysctls for all tunables in the cxgbe(4) driver..
Tue, Nov 27, 5:12 PM

Mon, Nov 26

np accepted D18010: Move CLIP table handling out of TOM and into the base driver..
Mon, Nov 26, 11:20 PM
np requested changes to D17987: netmap: set IFCAP_NETMAP in if_capabilities.

The cxgbe part of this diff reverts r309725. The commit message for r309725 indicates the changes were made to catch up with r307394, which was the a netmap update. Can you confirm that various releases of netmap have had different behavior regarding if_capabilities? If netmap has finally settled on handling the caps this way then I have no objection to one last catch-up in the driver.

Mon, Nov 26, 5:57 PM
np accepted D18310: Fix a check..
Mon, Nov 26, 5:11 PM

Mon, Nov 19

np committed rS340651: cxgbe(4): Update T4/5/6 firmwares to 1.22.0.3..
cxgbe(4): Update T4/5/6 firmwares to 1.22.0.3.
Mon, Nov 19, 9:59 PM

Nov 9 2018

np accepted D17915: Use tcp_state_change() in the cxgbe(4) TOE module..
Nov 9 2018, 1:10 AM

Nov 6 2018

np added a comment to D17870: cxgbe netmap: Avoid too frequent flush of CIDX by the NIC.

lazy_tx_credit_flush in the driver is supposed to avoid the situation you described. Try setting it to 1 if it isn't already and see if that helps.

Nov 6 2018, 8:34 PM
np added inline comments to D17868: cxgbe netmap: Micro optimizations of the rxsync function.
Nov 6 2018, 6:00 PM
np added a reviewer for D17868: cxgbe netmap: Micro optimizations of the rxsync function: v.maffione_gmail.com.

+Vincenzo for the netmap_kern.h part.

Nov 6 2018, 5:54 PM
np requested changes to D17869: cxgbe: Fix false sharing between t4_nm_intr and cxgbe_netmap_rxsync.

How about using __aligned(CACHE_LINE_SIZE) like the rest of the driver and let the compiler figure out the padding?

Nov 6 2018, 5:35 PM
np accepted D17857: Treat the memory lengths for CHELSIO_T4_GET_MEM as unsigned..
Nov 6 2018, 1:32 AM

Nov 5 2018

np accepted D17811: Add a facility for transmitting "raw" work requests on regular NIC queues..
Nov 5 2018, 10:44 PM
np accepted D17802: Fix cxgbe netmap when interface is DOWN.

Can you provide exact steps to reproduce the problem that you described? I get an EAGAIN (as expected) and not a panic if I try to enable netmap when the link is down.

Nov 5 2018, 6:38 PM
np added a comment to D17843: Fix Chelsio T6 drop statistics.
In D17843#381477, @ae wrote:

Hi, I have a report, that cxgbe driver doesn't take into account packets, that are received from mirrored port. So, when you run netstat -hw 1 -I cxl0 you will see no packets, but tcpdump will show them. It seems a bit confusing. I didn't checked this, so I might be wrong.

Nov 5 2018, 6:11 PM
np requested changes to D17843: Fix Chelsio T6 drop statistics.

What version of FreeBSD is this? I think this is already fixed in 12.0.

Nov 5 2018, 5:12 PM

Nov 2 2018

np committed rS340063: cxgbe/iw_cxgbe: Suppress spurious "Unexpected streaming data ...".
cxgbe/iw_cxgbe: Suppress spurious "Unexpected streaming data ..."
Nov 2 2018, 4:22 PM

Oct 31 2018

np committed rS339967: cxgbe(4): Add rate limiting support for UDP..
cxgbe(4): Add rate limiting support for UDP.
Oct 31 2018, 7:19 PM
np committed rS339965: cxgbe(4): Report a reasonable non-zero if_hw_tsomaxsegsize to the.
cxgbe(4): Report a reasonable non-zero if_hw_tsomaxsegsize to the
Oct 31 2018, 6:30 PM

Oct 30 2018

np committed rS339905: MFC r339626:.
MFC r339626:
Oct 30 2018, 5:04 AM

Oct 29 2018

np committed rS339891: cxgbe/iw_cxgbe: Install the socket upcall before calling soconnect to.
cxgbe/iw_cxgbe: Install the socket upcall before calling soconnect to
Oct 29 2018, 10:36 PM
np closed D17707: iWARP rping server fails to bind socket when no IP address is specified.
Oct 29 2018, 9:46 PM
np committed rS339886: rping(1): Make sure the socket address defaults to something reasonable.
rping(1): Make sure the socket address defaults to something reasonable
Oct 29 2018, 9:46 PM
np accepted D17707: iWARP rping server fails to bind socket when no IP address is specified.

I'll check this into FreeBSD later today. Please send the patch upstream too.

Oct 29 2018, 7:00 PM

Oct 27 2018

np committed rS339809: cxgbetool(8): Add a subaction (tcbrss <n>) that can be used with "pass".
cxgbetool(8): Add a subaction (tcbrss <n>) that can be used with "pass"
Oct 27 2018, 5:26 AM

Oct 25 2018

np committed rS339749: cxgbe(4): Add a knob to split the rx queues for a netmap enabled.
cxgbe(4): Add a knob to split the rx queues for a netmap enabled
Oct 25 2018, 10:55 PM
np added a reviewer for D17707: iWARP rping server fails to bind socket when no IP address is specified: hselasky.

Where is the real upstream for rping? Maybe this fix should go there first?

Oct 25 2018, 10:05 PM
np committed rS339717: cxgbe(4): Allow "pass" filters to distribute matching traffic using a.
cxgbe(4): Allow "pass" filters to distribute matching traffic using a
Oct 25 2018, 2:37 PM
np committed rS339705: cxgbe(4): Update the VI's default queue when netmap is enabled/disabled..
cxgbe(4): Update the VI's default queue when netmap is enabled/disabled.
Oct 25 2018, 6:25 AM
np committed rS339700: cxgbe(4): new sysctl to display the start of the RSS region for a VI..
cxgbe(4): new sysctl to display the start of the RSS region for a VI.
Oct 25 2018, 1:20 AM

Oct 23 2018

np added reviewers for D17665: Ensure mbuf send tags don't trigger on ifnets: gallatin, glebius.

This looks quite hacky to me. A better fix might be to properly purge
the fields whose meaning depends on the "direction" (tx or rx) of the
mbuf when its direction changes. I think we do something similar for
layer-specific bits that are purged every time an mbuf crosses a layer.

Oct 23 2018, 6:59 PM
np committed rS339667: cxgbe/iw_cxgbe: save the ep in the driver-private provider_data field..
cxgbe/iw_cxgbe: save the ep in the driver-private provider_data field.
Oct 23 2018, 6:33 PM

Oct 22 2018

np committed rS339628: cxgbe(4): improve the accuracy of various TSO limits reported to the kernel..
cxgbe(4): improve the accuracy of various TSO limits reported to the kernel.
Oct 22 2018, 11:58 PM
np committed rS339626: cxgbe(4): Use automatic cidx updates with ofld and ctrl queues..
cxgbe(4): Use automatic cidx updates with ofld and ctrl queues.
Oct 22 2018, 11:06 PM

Oct 17 2018

np committed rS339404: MFC r336159:.
MFC r336159:
Oct 17 2018, 2:25 AM
np committed rS339403: MFC r335352:.
MFC r335352:
Oct 17 2018, 2:05 AM
np committed rS339402: MFC r334987:.
MFC r334987:
Oct 17 2018, 2:00 AM
np committed rS339401: MFC r320426:.
MFC r320426:
Oct 17 2018, 1:50 AM
np committed rS339400: MFC r338254:.
MFC r338254:
Oct 17 2018, 1:31 AM
np committed rS339399: MFC r338924:.
MFC r338924:
Oct 17 2018, 1:20 AM
np committed rS339398: MFC r336042:.
MFC r336042:
Oct 17 2018, 1:06 AM
np committed rS339397: MFC r333139:.
MFC r333139:
Oct 17 2018, 12:57 AM
np committed rS339396: MFC r325840, r327811, and r329701..
MFC r325840, r327811, and r329701.
Oct 17 2018, 12:45 AM
np committed rS339395: MFC r320419, r337679, r338366, and r338652..
MFC r320419, r337679, r338366, and r338652.
Oct 17 2018, 12:27 AM

Oct 16 2018

np committed rS339394: MFC r332515:.
MFC r332515:
Oct 16 2018, 10:13 PM
np committed rS339393: MFC r330887:.
MFC r330887:
Oct 16 2018, 10:09 PM
np committed rS339389: MFC r327254, r327904, and r328994..
MFC r327254, r327904, and r328994.
Oct 16 2018, 7:26 PM

Oct 13 2018

np committed rS339342: cxgbe(4): Fix a divide-by-zero that occurs when hw.cxgbe.toecaps_allowed.
cxgbe(4): Fix a divide-by-zero that occurs when hw.cxgbe.toecaps_allowed
Oct 13 2018, 12:13 AM

Sep 26 2018

np committed rS338954: cxgbe(4): Enable support for per-connection rate limiting in the default.
cxgbe(4): Enable support for per-connection rate limiting in the default
Sep 26 2018, 9:16 PM
np committed rS338940: cxgbe(4): Treat base/end of firmware parameters as signed integers when.
cxgbe(4): Treat base/end of firmware parameters as signed integers when
Sep 26 2018, 2:27 AM

Sep 25 2018

np committed rS338924: cxgbe(4): Link related changes..
cxgbe(4): Link related changes.
Sep 25 2018, 5:53 AM

Sep 22 2018

np committed rS338874: cxgbe(4): Reuse existing "switching" L2T entries when possible..
cxgbe(4): Reuse existing "switching" L2T entries when possible.
Sep 22 2018, 1:24 AM

Sep 21 2018

np committed rS338872: cxgbetool(8): The VLAN tag provided in the action for a filter must be prefixed.
cxgbetool(8): The VLAN tag provided in the action for a filter must be prefixed
Sep 21 2018, 11:48 PM
np accepted D17274: cxgb(4): Netdump: only reference allocated qsets.
Sep 21 2018, 10:42 PM
np added a comment to D17274: cxgb(4): Netdump: only reference allocated qsets.

Initializing sc->nqsets here means it may not have a good value until a
port (any port) of the adapter is brought up administratively. This may
work for netdump. If not then setup sc->nqsets in t3_sge_prep instead,
which runs very early.

Sep 21 2018, 6:14 PM

Sep 18 2018

np committed rS338762: cxgbetool(8): Clarify the meaning of the "queue" parameter used to steer.
cxgbetool(8): Clarify the meaning of the "queue" parameter used to steer
Sep 18 2018, 10:41 PM
np committed rS338761: cxgbe(4): Enable TXRTLMT by default when the feature is available in the.
cxgbe(4): Enable TXRTLMT by default when the feature is available in the
Sep 18 2018, 9:34 PM

Sep 13 2018

np committed rS338669: cxgbe(4): Use the correct number of parameters when querying the tid.
cxgbe(4): Use the correct number of parameters when querying the tid
Sep 13 2018, 10:58 PM
np committed rS338652: cxgbe/iw_cxgbe: Fix reported build breakage when the kernel.
cxgbe/iw_cxgbe: Fix reported build breakage when the kernel
Sep 13 2018, 4:27 PM

Aug 29 2018

np committed rS338366: cxgbe/iw_cxgbe: Fix iWARP RDMA + VIMAGE operation by setting the VNET.
cxgbe/iw_cxgbe: Fix iWARP RDMA + VIMAGE operation by setting the VNET
Aug 29 2018, 4:38 AM

Aug 28 2018

np committed rS338355: cxgbe/tom: Unregister shared CPL handlers on module unload. This fixes.
cxgbe/tom: Unregister shared CPL handlers on module unload. This fixes
Aug 28 2018, 6:16 PM

Aug 24 2018

np closed D16887: Unbreak VLANs after r337943..
Aug 24 2018, 9:48 PM
np committed rS338305: Unbreak VLANs after r337943..
Unbreak VLANs after r337943.
Aug 24 2018, 9:48 PM
np added a comment to D16808: fix vlan locking to permit sx acquisition in ioctl calls.

I tried the latest diff and ran into an assertion on VLAN creation:

Aug 24 2018, 8:47 PM
np added inline comments to D16887: Unbreak VLANs after r337943..
Aug 24 2018, 8:18 PM
np created D16887: Unbreak VLANs after r337943..
Aug 24 2018, 7:48 PM

Aug 23 2018

np committed rS338254: cxgbe(4): Use fcmpset instead of cmpset when appropriate..
cxgbe(4): Use fcmpset instead of cmpset when appropriate.
Aug 23 2018, 4:24 PM
np committed rS338218: cxgbev(4): Updates to the VF driver to cope with recent ifmedia and.
cxgbev(4): Updates to the VF driver to cope with recent ifmedia and
Aug 23 2018, 12:58 AM

Aug 21 2018

np committed rS338166: cxgbe(4): Be explicit about ignoring the return value of cmpset in some.
cxgbe(4): Be explicit about ignoring the return value of cmpset in some
Aug 21 2018, 11:33 PM
np committed rS338161: cxgbe/tom: Make sure 'matched' is always initialized before use..
cxgbe/tom: Make sure 'matched' is always initialized before use.
Aug 21 2018, 10:19 PM
np committed rS338160: cxgbe(4): Do not leak memory in case of errors during VI initialization..
cxgbe(4): Do not leak memory in case of errors during VI initialization.
Aug 21 2018, 10:16 PM
np committed rS338159: cxgbe(4): Make it clear that VI_INIT_DONE implies vi->ntxq > 0, and so.
cxgbe(4): Make it clear that VI_INIT_DONE implies vi->ntxq > 0, and so
Aug 21 2018, 9:42 PM
np committed rS338158: cxgbe(4): Check the RO bit properly before disabling relaxed ordering..
cxgbe(4): Check the RO bit properly before disabling relaxed ordering.
Aug 21 2018, 9:33 PM
np committed rS338156: cxgbe(4): Avoid overflow while calculating channel rate..
cxgbe(4): Avoid overflow while calculating channel rate.
Aug 21 2018, 9:10 PM
np accepted D16835: KASSERT: Make runtime optionality optional.
Aug 21 2018, 8:56 PM

Aug 20 2018

np committed rS338119: cxgbe/tom: Provide the hardware tid in tcp_info..
cxgbe/tom: Provide the hardware tid in tcp_info.
Aug 20 2018, 9:40 PM

Aug 18 2018

np committed rS337996: cxgbe(4): Replace T4_PKT_TIMESTAMP with something slightly less hackish..
cxgbe(4): Replace T4_PKT_TIMESTAMP with something slightly less hackish.
Aug 18 2018, 4:24 AM

Aug 17 2018

np committed rS337987: cxgbe(4): Adjust ntids to account for nhptids in the TOE case too..
cxgbe(4): Adjust ntids to account for nhptids in the TOE case too.
Aug 17 2018, 8:28 PM
np committed rS337986: cxgbe/tom: Put the ifnet or VLAN's PCP value in the 802.1Q tag of frames.
cxgbe/tom: Put the ifnet or VLAN's PCP value in the 802.1Q tag of frames
Aug 17 2018, 7:23 PM
np committed rS337943: if_vlan(4): A VLAN always has a PCP and its ifnet's if_pcp should be set.
if_vlan(4): A VLAN always has a PCP and its ifnet's if_pcp should be set
Aug 17 2018, 1:03 AM

Aug 16 2018

np committed rS337932: Add the ability to look up the 3b PCP of a VLAN interface. Use it in.
Add the ability to look up the 3b PCP of a VLAN interface. Use it in
Aug 16 2018, 11:47 PM
np closed D16752: Add the ability to lookup the 3b PCP of a VLAN interface. Use it in toe_l2_resolve to fill up the complete vtag and not just the vid..
Aug 16 2018, 11:47 PM
np added inline comments to D16752: Add the ability to lookup the 3b PCP of a VLAN interface. Use it in toe_l2_resolve to fill up the complete vtag and not just the vid..
Aug 16 2018, 10:42 PM
np added a comment to D16752: Add the ability to lookup the 3b PCP of a VLAN interface. Use it in toe_l2_resolve to fill up the complete vtag and not just the vid..

I decided to grab the PCP from the ifvlan (like VLAN_TAG does). I believe ifconfig ... vlanpcp <foo> updates this field.
ifconfig ... pcp <foo> updates the if_pcp field but I don't see any code that attempts to keep the ifvlan's pcp
and the ifnet's pcp in sync when the ifnet is a vlan ifnet.

Aug 16 2018, 10:22 PM
np added a comment to D16752: Add the ability to lookup the 3b PCP of a VLAN interface. Use it in toe_l2_resolve to fill up the complete vtag and not just the vid..

This is modeled after VLAN_TAG (which is mislabeled and just returns the
vid instead of the entire tag). I'm ok with changing the behavior of
VLAN_TAG to return the full tag including pcp but I went with a separate
VLAN_PCP to avoid surprising existing users of VLAN_TAG.

Aug 16 2018, 6:55 PM
np created D16752: Add the ability to lookup the 3b PCP of a VLAN interface. Use it in toe_l2_resolve to fill up the complete vtag and not just the vid..
Aug 16 2018, 6:54 PM

Aug 15 2018

np committed rS337873: cxgbe(4): Use VLAN_TRUNKDEV instead of private cookie to figure out the.
cxgbe(4): Use VLAN_TRUNKDEV instead of private cookie to figure out the
Aug 15 2018, 9:24 PM
np committed rS337830: cxgbe(4): Use two hashes instead of a table to keep track of.
cxgbe(4): Use two hashes instead of a table to keep track of
Aug 15 2018, 3:03 AM

Aug 13 2018

np committed rS337722: Whitespace nit in t4_tom.h.
Whitespace nit in t4_tom.h
Aug 13 2018, 7:21 PM

Aug 12 2018

np committed rS337679: Remove unused stuff from iw_cxgbe.h.
Remove unused stuff from iw_cxgbe.h
Aug 12 2018, 3:36 AM

Aug 11 2018

np committed rS337659: cxgbe(4): Move all control queues to the adapter..
cxgbe(4): Move all control queues to the adapter.
Aug 11 2018, 9:10 PM
np committed rS337609: cxgbe(4): Create two variants of service_iq, one for queues with.
cxgbe(4): Create two variants of service_iq, one for queues with
Aug 11 2018, 4:55 AM

Aug 9 2018

np committed rS337553: cxgbe(4): Add a sysctl to control the tx credit reclaim mechanism for.
cxgbe(4): Add a sysctl to control the tx credit reclaim mechanism for
Aug 9 2018, 9:52 PM
np committed rS337550: cxgbe(4): Set fl_pktshift to 0 by default..
cxgbe(4): Set fl_pktshift to 0 by default.
Aug 9 2018, 9:07 PM
np committed rS337540: cxgbe(4): Display pkt-size and burst-size in traffic class parameters..
cxgbe(4): Display pkt-size and burst-size in traffic class parameters.
Aug 9 2018, 2:36 PM
np committed rS337539: cxgbetool(8): Userspace part of support for high priority filters on T6+..
cxgbetool(8): Userspace part of support for high priority filters on T6+.
Aug 9 2018, 2:21 PM