iflib: Add iflib managed counters support
Needs ReviewPublic
Actions

Authored by zlei on Jul 30 2024, 4:40 PM.

Details

Reviewers

Group Reviewers

iflib
network

Summary

Currently supports IFCOUNTER_OQDROPS and fallbacks to if_get_counter_default().

PR: 280386
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Jul 30 2024, 4:40 PM

Herald added a reviewer: shurd. · View Herald TranscriptJul 30 2024, 4:40 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

zlei requested review of this revision.Jul 30 2024, 4:40 PM

zlei added a subscriber: mmacy.Jul 30 2024, 5:24 PM

zlei added inline comments.

sys/net/iflib.c
2642	I'm not convinced that we need to reset txq stats on every call `iflib_stop()`. The stats can persist IMO, then `iflib_save_stats` can be omitted. Can the author @mmacy comment on this ?

zlei edited the summary of this revision. (Show Details)Jul 30 2024, 5:33 PM

zlei added a reviewer: network.

See the usage of iflib_if_get_counter_default() in D46187 .

erj added a subscriber: erj.Jul 30 2024, 8:17 PM

erj added inline comments.

sys/net/iflib.c
2642	I agree that I don't think we should do this; maybe it was something that was added because it was useful for debugging when iflib was being developed?
4665	Ok, I think it makes sense that we're adding the IFCOUNTER_OQDROPS from the ifnet, too.

PR: 280386

Is this supposed to help solve the problem in the PR? I'm not sure what's going on there, but I'm not sure it's clear in there except for your comment that Odrops isn't incrementing because they're not being retrieved properly.

In D46186#1052952, @erj wrote:

PR: 280386

Is this supposed to help solve the problem in the PR?

Yes. That PR lead this change. I mean when I hacking if_bridge(4), I realized some iflib drivers ( em and igb in that PR ) does not report Odrops correctly.

I'm not sure what's going on there, but I'm not sure it's clear in there except for your comment that Odrops isn't incrementing because they're not being retrieved properly.

So users ( and also me ) got confused what happens behind. Users are more familiar with netstat(8) than driver specific sysctl variables.