- User Since
- May 4 2018, 7:26 PM (32 w, 2 d)
Fri, Dec 14
Thu, Dec 13
replace GMAC_DIGEST_LEN with CCM_CBC_MAX_DIGEST_LEN
I think I've incorporated all feedback but the MAC len name change.
- incorporate two missing bits of feedback
- rebase post D18522 commit
- incorporate some of cem's feedback
Wed, Dec 12
Tue, Dec 11
- fix numbering
- pull in cryptocheck change
Tue, Nov 27
Sun, Nov 25
Wed, Nov 21
- respond to feedback
- further changes for 4.18
Mon, Nov 19
+1 I was just observing the need for this last night.
Nov 14 2018
Nov 13 2018
Why isn’t this hit elsewhere? Are you compiling without EARLY_AP ?
Nov 9 2018
Nov 6 2018
Nov 5 2018
Nov 4 2018
Odd. It applied cleanly this time. I'll commit after a tinderbox run.
Nov 3 2018
After this change sampling under load is truly terrible - rejecting 99+% of samples:
+ pmcstat -S unhalted_core_cycles -O ppid.pmcstat sleep 10 + pmcstat -R ppid.pmcstat -z100 -G ppid.stacks CONVERSION STATISTICS: #exec/elf 1 #samples/total 566445 #callchain/dubious-frames 565995
Nov 2 2018
This needs to be multiple reviews.
Please separate out the de-inlining in to a separate review. We can commit that as the major chunk and then the other changes will be easier to review.
sorry didn't mean to change the title - just add markj
Oct 29 2018
Also worth looking at:
I just rebased to today's HEAD from that of the 6th. This change makes my system unbootable. I haven't delved in to it, but my guess is I don't have enough contiguous memory below the limit (my system has 512GB)
Oct 26 2018
@rajfbsd_gmail.com I can't actually apply this to a release branch (11.2) I can only commit to stable/11 (from which 11.3 will come) where it looks like parts of this have already been MFC'd. The patch doesn't actually apply cleanly there. Could you please update it to apply to the stable/11 branch?
Oct 25 2018
should we abandon?
Already effectuated in HEAD
It looks fine to me. I'll commit it as soon as I can.
@hselasky this is getting super complicated - how much can we avoid by replacing the epoch_wait()+free() with an epoch_call()?
@hselasky have you had pho@ test this change?
LGTM. Are you cross-building from OSX?
Oct 18 2018
Oct 17 2018
Is this in response to an observed bug? This is adding a lot of complexity when we can simply validate the result
Oct 12 2018
Oct 11 2018
Oct 10 2018
Do you need this in for the 12 release? I can do that, it just means some more hoops for me jump through.
Oct 7 2018
Oct 5 2018
As I pointed out on IRC, this problem is not specific to hwpmc. Nonetheless it does fix the issue here.
Is there a reason you didn't just update the diff on the existing review?
Oct 4 2018
- add #ifdef RACCT
- fix typo
Oct 3 2018
incorporate @alc feedback
@imp anyone else we should add as a reviewer?
incorporate feedback from @markj
I’ll update the patch with the other feedback.
@kib any further comments?
Oct 2 2018
- use atop/ptoa macros
remove invalid assert
- remove unused force parameter