bhyve reviewers group
Mon, Jan 28
Changes made as suggested by previous comments
Question regarding comments
Overall good, just style nits and a diff reduction.
Fri, Jan 25
Jan 16 2019
Not sure about the seg_max value (even in the current code).
Looking at the qemu implementation, I suspect it should be queue length -2, which I guess is what the patched code happens to achieve (based on the definition of VTBLK_RINGSZ), but it could be more explicit.
Jan 15 2019
Jan 14 2019
Added comment where vbc_seg_max is set to note why that value is clamped as it is (as recommended by pmooney_pfmooney.com).
Jan 13 2019
This is effectively what we did in SmartOS/illumos to address the issue:
Thanks for the patch, I will take a look on within the next two weeks.
Fix cut-and-paste error in patch
Jan 4 2019
Jan 2 2019
This looks good to me as well...
LGTM! Could you please set a MFC?
LGTM! Do you mind set a MFC?
Dec 31 2018
Use ONE_BASED() macro for CQ creation as well as SQ
Dec 11 2018
LGTM! Thanks for the patch!
Dec 10 2018
Dec 3 2018
Nov 5 2018
Sep 6 2018
Sep 4 2018
I have tested it with FreeBSD HEAD as a guest running for couple days.
Aug 28 2018
This looks right to me now. I'll try to test it locally in the next day or so.
Minimize diff with suggestions by jhb.