Page MenuHomeFreeBSD

bhyveUmbrella
ActivePublic

Details

Description

bhyve reviewers group

Recent Activity

Tue, Dec 11

mav closed D18504: Allow CTL device specification in bhyve virtio-scsi.
Tue, Dec 11, 8:47 PM · bhyve
araujo accepted D18504: Allow CTL device specification in bhyve virtio-scsi.

LGTM! Thanks for the patch!

Tue, Dec 11, 5:05 AM · bhyve

Mon, Dec 10

mav added a reviewer for D18504: Allow CTL device specification in bhyve virtio-scsi: araujo.
Mon, Dec 10, 9:52 PM · bhyve
mav created D18504: Allow CTL device specification in bhyve virtio-scsi.
Mon, Dec 10, 9:51 PM · bhyve

Mon, Dec 3

avg removed a member for bhyve: avg.
Mon, Dec 3, 1:20 PM

Nov 5 2018

araujo removed a watcher for bhyve: araujo.
Nov 5 2018, 5:57 PM
araujo added a watcher for bhyve: araujo.
Nov 5 2018, 5:56 PM

Sep 6 2018

jhb closed D16822: bhyve: Use MAP_GUARD guard pages.
Sep 6 2018, 8:30 PM · bhyve

Sep 4 2018

araujo accepted D16822: bhyve: Use MAP_GUARD guard pages.

I have tested it with FreeBSD HEAD as a guest running for couple days.

Sep 4 2018, 1:51 AM · bhyve
lattera-gmail.com added a comment to D16822: bhyve: Use MAP_GUARD guard pages.
In D16822#361197, @jhb wrote:

This looks right to me now. I'll try to test it locally in the next day or so.

Sep 4 2018, 12:22 AM · bhyve

Aug 28 2018

jhb added a comment to D16822: bhyve: Use MAP_GUARD guard pages.

This looks right to me now. I'll try to test it locally in the next day or so.

Aug 28 2018, 11:04 PM · bhyve
lattera-gmail.com updated the diff for D16822: bhyve: Use MAP_GUARD guard pages.

Minimize diff with suggestions by jhb.

Aug 28 2018, 9:54 PM · bhyve
lattera-gmail.com added inline comments to D16822: bhyve: Use MAP_GUARD guard pages.
Aug 28 2018, 9:49 PM · bhyve
jhb added inline comments to D16822: bhyve: Use MAP_GUARD guard pages.
Aug 28 2018, 9:45 PM · bhyve
lattera-gmail.com added a comment to D16822: bhyve: Use MAP_GUARD guard pages.
In D16822#361129, @kib wrote:

The only useful feature of the phabricator is to easily see context around the patch, which you successfully botched.

Aug 28 2018, 9:23 PM · bhyve
lattera-gmail.com updated the diff for D16822: bhyve: Use MAP_GUARD guard pages.

Reflect changes requested by both kib and jhb.

Aug 28 2018, 9:23 PM · bhyve
jhb added a comment to D16822: bhyve: Use MAP_GUARD guard pages.

You should only be replacing the existing MAP_ANON / PROT_NONE mmap() calls with MAP_GUARD instead. You shouldn't be adding new mmap() calls. The "real" thing is already being mmap()'d later. As @kib notes, it's good to use 'svn diff -x -U 99999' or the like to generate context when uploading to phabricator.

Aug 28 2018, 9:06 PM · bhyve
kib added a comment to D16822: bhyve: Use MAP_GUARD guard pages.

The only useful feature of the phabricator is to easily see context around the patch, which you successfully botched.

Aug 28 2018, 8:55 PM · bhyve
lattera-gmail.com updated the diff for D16822: bhyve: Use MAP_GUARD guard pages.

Missed a spot. Cover another mapping with MAP_GUARD.

Aug 28 2018, 8:38 PM · bhyve
lattera-gmail.com updated the diff for D16822: bhyve: Use MAP_GUARD guard pages.

Update the patch to use John Baldwin's suggestion on mapping the entire range first with MAP_GUARD.

Aug 28 2018, 8:30 PM · bhyve
lattera-gmail.com added a comment to D16822: bhyve: Use MAP_GUARD guard pages.
In D16822#361106, @jhb wrote:

Adding @kib since he added MAP_GUARD. I think you should instead MAP_GUARD the entire range first and then remap the middle. The middle is already remapped on line 518, so instead of adding new mmap()'s just for the guards, you should replace the mmap() on line 496 with this:

base = mmap(NULL, len2, PROT_NONE, MAP_GUARD | MAP_ALIGNED_SUPER, -1, 0);
Aug 28 2018, 8:14 PM · bhyve
jhb added a comment to D16822: bhyve: Use MAP_GUARD guard pages.

Adding @kib since he added MAP_GUARD. I think you should instead MAP_GUARD the entire range first and then remap the middle. The middle is already remapped on line 518, so instead of adding new mmap()'s just for the guards, you should replace the mmap() on line 496 with this:

Aug 28 2018, 8:03 PM · bhyve
jhb added a reviewer for D16822: bhyve: Use MAP_GUARD guard pages: kib.
Aug 28 2018, 7:52 PM · bhyve
araujo added reviewers for D16822: bhyve: Use MAP_GUARD guard pages: araujo, bhyve.
Aug 28 2018, 6:42 AM · bhyve

Aug 21 2018

lattera-gmail.com updated the summary of D16822: bhyve: Use MAP_GUARD guard pages.
Aug 21 2018, 1:34 AM · bhyve
lattera-gmail.com created D16822: bhyve: Use MAP_GUARD guard pages.
Aug 21 2018, 1:32 AM · bhyve

Aug 1 2018

araujo closed D16057: Support bhyve within a jail.
Aug 1 2018, 12:39 AM · bhyve

Jul 31 2018

araujo accepted D16057: Support bhyve within a jail.

Lgtm, nice work!

Jul 31 2018, 12:16 AM · bhyve

Jul 30 2018

jamie accepted D16057: Support bhyve within a jail.
Jul 30 2018, 5:35 PM · bhyve
lattera-gmail.com updated the diff for D16057: Support bhyve within a jail.

Put the allow.vmm documentation in the right place in the jail(8) manpage.

Jul 30 2018, 5:34 PM · bhyve
lattera-gmail.com added inline comments to D16057: Support bhyve within a jail.
Jul 30 2018, 4:52 PM · bhyve
jamie added inline comments to D16057: Support bhyve within a jail.
Jul 30 2018, 4:46 PM · bhyve
lattera-gmail.com updated the diff for D16057: Support bhyve within a jail.

Address the superfluous conditional and add an entry into the jail(8) manpage.

Jul 30 2018, 4:16 AM · bhyve
lattera-gmail.com added inline comments to D16057: Support bhyve within a jail.
Jul 30 2018, 4:04 AM · bhyve
lattera-gmail.com added a comment to D16057: Support bhyve within a jail.

One more thing to do: jail(8) should mention the flag. There's a section about module-specific flags where I think it would fit better than the main allow.* section.

Jul 30 2018, 4:02 AM · bhyve
jamie added a comment to D16057: Support bhyve within a jail.

One more thing to do: jail(8) should mention the flag. There's a section about module-specific flags where I think it would fit better than the main allow.* section.

Jul 30 2018, 2:20 AM · bhyve
jamie added inline comments to D16057: Support bhyve within a jail.
Jul 30 2018, 2:20 AM · bhyve
lattera-gmail.com updated the diff for D16057: Support bhyve within a jail.

Update the patch to take into account the new dynamic allow.* API.

Jul 30 2018, 1:36 AM · bhyve

Jul 20 2018

unitrunker_gmail.com added a watcher for bhyve: unitrunker_gmail.com.
Jul 20 2018, 5:10 AM

Jul 9 2018

me_cschwarz.com removed a watcher for bhyve: me_cschwarz.com.
Jul 9 2018, 11:49 AM

Jul 6 2018

lattera-gmail.com added a comment to D16057: Support bhyve within a jail.

I've added D16146, which makes a new allow.* bit easy:

flag = prison_add_allow(NULL, "foo", NULL, "Jailed user may do the foo thing");

Jul 6 2018, 5:53 AM · bhyve

Jul 5 2018

jamie added a comment to D16057: Support bhyve within a jail.

I've added D16146, which makes a new allow.* bit easy:

Jul 5 2018, 6:35 PM · bhyve
lattera-gmail.com added inline comments to D16057: Support bhyve within a jail.
Jul 5 2018, 3:14 PM · bhyve
lattera-gmail.com added a comment to D16057: Support bhyve within a jail.

In addition to the question of where to check the permissions, there's also the issue that the allow.vmm parameter shouldn't exist in a non-VMM system. This means the SYSCTL_JAIL_PARAM should be defined in vmm_dev.c or some other vmm-related file; that way, if VMM is loaded as a module, the parameter would be attached to that module.

For an example of module-specific parameters, see compat/linux/linux_mib.c (and where the setup is called in linux_common.c). This is for the parameters linux.*, so it's not quite the same. But there's no actual requirement that your parameter be top-level, and could still be allow.vmm.

The problem is there's more code required for this than should be necessary for a simple allow bit. You don't need everything that linux_mib has, but you would need something to set up the parameter on module load. While I don't have support for dynamic allow.* parameters, I do have prison_add_vfs() in kern_jail.c, which is mostly for adding allow.mount.fsname parameters. I should change that a bit to allow for a more generic method of adding an allow.* flag. That would mean you have a dependency on me.

Jul 5 2018, 3:13 PM · bhyve
jamie added a comment to D16057: Support bhyve within a jail.

In addition to the question of where to check the permissions, there's also the issue that the allow.vmm parameter shouldn't exist in a non-VMM system. This means the SYSCTL_JAIL_PARAM should be defined in vmm_dev.c or some other vmm-related file; that way, if VMM is loaded as a module, the parameter would be attached to that module.

Jul 5 2018, 3:02 PM · bhyve

Jul 4 2018

lattera-gmail.com added inline comments to D16057: Support bhyve within a jail.
Jul 4 2018, 8:57 PM · bhyve
jamie added inline comments to D16057: Support bhyve within a jail.
Jul 4 2018, 7:17 PM · bhyve
lattera-gmail.com added a reviewer for D16057: Support bhyve within a jail: jamie.
Jul 4 2018, 5:30 PM · bhyve
swills updated subscribers of D16057: Support bhyve within a jail.

Might want to add @jamie as a reviewer.

Jul 4 2018, 5:03 PM · bhyve

Jun 29 2018

lattera-gmail.com added a comment to D16057: Support bhyve within a jail.

@lattera-gmail.com first of all thanks for the patch. I'm curious to know what guest OS have you tested inside a jail, could you please share it with me? Also let me know what devices you used, as an example: virtio-blk, virtio-net and etc..

If you can share your tests, it would be perfect.

Thanks.

Jun 29 2018, 12:31 PM · bhyve