Page MenuHomeFreeBSD

bhyveUmbrella
ActivePublic

Details

Description

bhyve reviewers group

Recent Activity

Mon, Jan 28

callum_callumaitchison.uk updated the diff for D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.

Changes made as suggested by previous comments

Mon, Jan 28, 7:35 PM · bhyve
rgrimes added inline comments to D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.
Mon, Jan 28, 5:51 PM · bhyve
callum_callumaitchison.uk added a comment to D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.

Question regarding comments

Mon, Jan 28, 3:43 PM · bhyve
rgrimes added a comment to D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.

Overall good, just style nits and a diff reduction.

Mon, Jan 28, 12:35 PM · bhyve
rgrimes added reviewers for D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units: jhb, tychon, pmooney_pfmooney.com.
Mon, Jan 28, 12:16 PM · bhyve
callum_callumaitchison.uk created D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.
Mon, Jan 28, 12:06 PM · bhyve

Fri, Jan 25

dch added a watcher for bhyve: dch.
Fri, Jan 25, 11:21 AM

Jan 16 2019

richard_meric.id.au added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Not sure about the seg_max value (even in the current code).
Looking at the qemu implementation, I suspect it should be queue length -2, which I guess is what the patched code happens to achieve (based on the definition of VTBLK_RINGSZ), but it could be more explicit.

Jan 16 2019, 6:01 AM · bhyve

Jan 15 2019

araujo added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.
NOTE: I blocked this patch, till I finish my analysis, nothing wrong with that...
Jan 15 2019, 12:19 AM · bhyve
araujo requested changes to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.
Jan 15 2019, 12:17 AM · bhyve

Jan 14 2019

araujo added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Hi Richard,

Do you mind share the tests you made??

Best,

I've currently got these changes running in a FreeNAS-11.2-RELEASE-U1 instance (FreeBSD 11.2 kernel) running a couple of Windows 2016 VMs plus one Centos 7 - all using virtio-blk disk devices without issue. I also have pfSense (FreeBSD 11.2) and OpenSuSE (Leap 42.3) VMs which I haven't tested yet - but can do if required.

Jan 14 2019, 9:43 AM · bhyve
richard_meric.id.au added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Hi Richard,

Do you mind share the tests you made??

Best,

Jan 14 2019, 6:11 AM · bhyve
araujo added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Hi Richard,

Jan 14 2019, 3:31 AM · bhyve
richard_meric.id.au added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

This is effectively what we did in SmartOS/illumos to address the issue:
https://github.com/joyent/illumos-joyent/commit/192e1e6405f98e4b0a12f9488793c5dd000f3f7e

I would suggest including a comment where vbc_seg_max is set to note why that value is clamped as it is.

Jan 14 2019, 12:51 AM · bhyve
richard_meric.id.au updated the diff for D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Added comment where vbc_seg_max is set to note why that value is clamped as it is (as recommended by pmooney_pfmooney.com).

Jan 14 2019, 12:48 AM · bhyve

Jan 13 2019

pmooney_pfmooney.com added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

This is effectively what we did in SmartOS/illumos to address the issue:
https://github.com/joyent/illumos-joyent/commit/192e1e6405f98e4b0a12f9488793c5dd000f3f7e

Jan 13 2019, 11:19 PM · bhyve
araujo added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Thanks for the patch, I will take a look on within the next two weeks.

Jan 13 2019, 7:09 AM · bhyve
richard_meric.id.au updated the diff for D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Fix cut-and-paste error in patch

Jan 13 2019, 7:08 AM · bhyve
araujo added a reviewer for D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests: araujo.
Jan 13 2019, 7:05 AM · bhyve
richard_meric.id.au created D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.
Jan 13 2019, 6:49 AM · bhyve

Jan 4 2019

chuck closed D18703: Fix bhyve's NVMe Completion Queue entry values.
Jan 4 2019, 3:03 PM · bhyve
chuck closed D18702: Fix bhyve's NVMe queue bookkeeping.
Jan 4 2019, 3:03 PM · bhyve

Jan 2 2019

imp added a comment to D18703: Fix bhyve's NVMe Completion Queue entry values.

LGTM! Could you please set a MFC?

Absolutely. I have one in the real commit message, but Differential didn't seem to like it in the summary.

Jan 2 2019, 6:21 PM · bhyve
chuck added a comment to D18703: Fix bhyve's NVMe Completion Queue entry values.

LGTM! Could you please set a MFC?

Jan 2 2019, 5:44 PM · bhyve
imp accepted D18703: Fix bhyve's NVMe Completion Queue entry values.

lgtm

Jan 2 2019, 7:10 AM · bhyve
imp accepted D18702: Fix bhyve's NVMe queue bookkeeping.

This looks good to me as well...

Jan 2 2019, 7:09 AM · bhyve
araujo accepted D18703: Fix bhyve's NVMe Completion Queue entry values.

LGTM! Could you please set a MFC?

Jan 2 2019, 4:21 AM · bhyve
araujo added a reviewer for D18703: Fix bhyve's NVMe Completion Queue entry values: bhyve.
Jan 2 2019, 4:21 AM · bhyve
araujo accepted D18702: Fix bhyve's NVMe queue bookkeeping.
Jan 2 2019, 4:20 AM · bhyve
araujo added a reviewer for D18702: Fix bhyve's NVMe queue bookkeeping: bhyve.
Jan 2 2019, 4:20 AM · bhyve
araujo accepted D18702: Fix bhyve's NVMe queue bookkeeping.

LGTM! Do you mind set a MFC?

Jan 2 2019, 4:20 AM · bhyve

Dec 31 2018

chuck created D18703: Fix bhyve's NVMe Completion Queue entry values.
Dec 31 2018, 6:58 PM · bhyve
chuck updated the diff for D18702: Fix bhyve's NVMe queue bookkeeping.

Use ONE_BASED() macro for CQ creation as well as SQ

Dec 31 2018, 6:54 PM · bhyve
chuck created D18702: Fix bhyve's NVMe queue bookkeeping.
Dec 31 2018, 6:53 PM · bhyve

Dec 11 2018

mav closed D18504: Allow CTL device specification in bhyve virtio-scsi.
Dec 11 2018, 8:47 PM · bhyve
araujo accepted D18504: Allow CTL device specification in bhyve virtio-scsi.

LGTM! Thanks for the patch!

Dec 11 2018, 5:05 AM · bhyve

Dec 10 2018

mav added a reviewer for D18504: Allow CTL device specification in bhyve virtio-scsi: araujo.
Dec 10 2018, 9:52 PM · bhyve
mav created D18504: Allow CTL device specification in bhyve virtio-scsi.
Dec 10 2018, 9:51 PM · bhyve

Dec 3 2018

avg removed a member for bhyve: avg.
Dec 3 2018, 1:20 PM

Nov 5 2018

araujo removed a watcher for bhyve: araujo.
Nov 5 2018, 5:57 PM
araujo added a watcher for bhyve: araujo.
Nov 5 2018, 5:56 PM

Sep 6 2018

jhb closed D16822: bhyve: Use MAP_GUARD guard pages.
Sep 6 2018, 8:30 PM · bhyve

Sep 4 2018

araujo accepted D16822: bhyve: Use MAP_GUARD guard pages.

I have tested it with FreeBSD HEAD as a guest running for couple days.

Sep 4 2018, 1:51 AM · bhyve
lattera-gmail.com added a comment to D16822: bhyve: Use MAP_GUARD guard pages.
In D16822#361197, @jhb wrote:

This looks right to me now. I'll try to test it locally in the next day or so.

Sep 4 2018, 12:22 AM · bhyve

Aug 28 2018

jhb added a comment to D16822: bhyve: Use MAP_GUARD guard pages.

This looks right to me now. I'll try to test it locally in the next day or so.

Aug 28 2018, 11:04 PM · bhyve
lattera-gmail.com updated the diff for D16822: bhyve: Use MAP_GUARD guard pages.

Minimize diff with suggestions by jhb.

Aug 28 2018, 9:54 PM · bhyve
lattera-gmail.com added inline comments to D16822: bhyve: Use MAP_GUARD guard pages.
Aug 28 2018, 9:49 PM · bhyve
jhb added inline comments to D16822: bhyve: Use MAP_GUARD guard pages.
Aug 28 2018, 9:45 PM · bhyve
lattera-gmail.com added a comment to D16822: bhyve: Use MAP_GUARD guard pages.
In D16822#361129, @kib wrote:

The only useful feature of the phabricator is to easily see context around the patch, which you successfully botched.

Aug 28 2018, 9:23 PM · bhyve
lattera-gmail.com updated the diff for D16822: bhyve: Use MAP_GUARD guard pages.

Reflect changes requested by both kib and jhb.

Aug 28 2018, 9:23 PM · bhyve