Page MenuHomeFreeBSD

grehan (Peter Grehan)
User

Projects

User Details

User Since
May 9 2014, 10:54 PM (395 w, 4 d)

Recent Activity

Fri, Nov 19

grehan removed a member for bhyve: grehan.
Fri, Nov 19, 10:20 PM

Thu, Nov 18

grehan committed R10:b9569ba05e20: Remove myself from bhyve maintenance; ENOTIME. (authored by grehan).
Remove myself from bhyve maintenance; ENOTIME.
Thu, Nov 18, 8:04 PM

Sun, Nov 14

grehan committed R10:d9d625047784: igc: Use hardware routine for PHY reset (authored by grehan).
igc: Use hardware routine for PHY reset
Sun, Nov 14, 1:15 AM
grehan committed R10:3d093d5b0053: igc: correctly update RCTL when changing multicast filters. (authored by grehan).
igc: correctly update RCTL when changing multicast filters.
Sun, Nov 14, 1:15 AM

Sat, Nov 13

grehan committed R10:267a39780ea8: igc: Use hardware routine for PHY reset (authored by grehan).
igc: Use hardware routine for PHY reset
Sat, Nov 13, 12:54 AM
grehan committed R10:73e1138208a5: igc: correctly update RCTL when changing multicast filters. (authored by grehan).
igc: correctly update RCTL when changing multicast filters.
Sat, Nov 13, 12:54 AM

Fri, Nov 12

grehan committed R10:37bfb1c96596: igc: Use hardware routine for PHY reset (authored by grehan).
igc: Use hardware routine for PHY reset
Fri, Nov 12, 10:43 PM
grehan committed R10:a4c22552b8c4: igc: correctly update RCTL when changing multicast filters. (authored by grehan).
igc: correctly update RCTL when changing multicast filters.
Fri, Nov 12, 10:43 PM
grehan accepted D32952: bhyve nvme: Add AEN support to NVMe emulation.

Maybe a note to fix the spelling later in the commit :)

Fri, Nov 12, 9:48 PM
grehan accepted D32558: bhyve: initial PowerCycles value and implement PowerOnHours caculation.
Fri, Nov 12, 9:43 PM

Nov 8 2021

grehan closed D32772: igc: Use hardware routine for PHY reset.
Nov 8 2021, 11:08 AM
grehan committed R10:561cd74b1704: igc: Use hardware routine for PHY reset (authored by grehan).
igc: Use hardware routine for PHY reset
Nov 8 2021, 11:08 AM

Nov 1 2021

grehan requested review of D32772: igc: Use hardware routine for PHY reset.
Nov 1 2021, 12:14 PM

Oct 27 2021

grehan accepted D32685: bhyve: use physical lobits for BARs of passthru devices.

Been lucky that most if not all 64-bit BARs have been prefetchable.

Oct 27 2021, 10:22 AM · bhyve

Oct 25 2021

grehan accepted D32596: bhyve: do not explicitly map fbuf framebuffer.

Works fine.

Oct 25 2021, 11:57 AM · bhyve

Oct 22 2021

grehan committed R10:5a3eb6207a35: igc: correctly update RCTL when changing multicast filters. (authored by grehan).
igc: correctly update RCTL when changing multicast filters.
Oct 22 2021, 10:50 AM
grehan closed D32574: Fix setting of RCTL register when modifying multicast filters..
Oct 22 2021, 10:50 AM

Oct 21 2021

grehan updated the summary of D32574: Fix setting of RCTL register when modifying multicast filters..
Oct 21 2021, 9:11 PM

Oct 20 2021

grehan requested review of D32574: Fix setting of RCTL register when modifying multicast filters..
Oct 20 2021, 10:12 AM

Oct 19 2021

grehan accepted D32559: vlapic: Schedule callouts on the local CPU.

This may have been leftover from some early soft-partitioning work where the host was running on CPU 0 (and low CPUs) with bhyve and a single-guest running on the remainder with halt-exits disabled.

Oct 19 2021, 9:00 PM

Oct 17 2021

grehan accepted D32523: bhyve: Fix the WITH_BHYVE_SNAPSHOT build.

I'd say until snapshots are enabled by default, there are no guarantees.

Oct 17 2021, 10:13 PM

Oct 8 2021

grehan accepted D32359: bhyve: Map the MSI-X table unconditionally when passthrough is enabled.
Oct 8 2021, 11:52 PM

Oct 7 2021

grehan accepted D31621: ixgbe: Update shared code.

Looks fine.

Oct 7 2021, 1:37 AM

Sep 22 2021

grehan accepted D31819: bhyve: ignore low bits of CFGADR.

In practice this hasn't been an issue since a) guests use ECAM for config access, or b) mask off the lower bits (e.g. Linux routines in arch/x86/pci/direct.c).

Sep 22 2021, 11:00 AM · bhyve

Aug 23 2021

grehan committed R10:9ffb4c0adab4: igc(4): Introduce new driver for the Intel I225 Ethernet controller. (authored by grehan).
igc(4): Introduce new driver for the Intel I225 Ethernet controller.
Aug 23 2021, 9:33 AM

Aug 22 2021

grehan committed R10:28e22482279f: arm64: HWCAP/HWCAP2 aux args support for 32-bit ARM binaries. (authored by grehan).
arm64: HWCAP/HWCAP2 aux args support for 32-bit ARM binaries.
Aug 22 2021, 2:33 AM

Aug 19 2021

grehan accepted D31547: e1000: Update shared code.
Aug 19 2021, 9:17 AM
grehan added a comment to D31578: bhyve: replace fwctl by QEMU's fwcfg.

Add option -l fwcfg,<name> to select either QEMU or bhyve fwcfg.

Aug 19 2021, 8:40 AM · bhyve
grehan added a comment to D31578: bhyve: replace fwctl by QEMU's fwcfg.

What are the features that you're looking to get from Qemu fwcfg ?

  • An E820 table. It could help D26209.

...

  • ACPI/SMBIOS tables. Don't know if it's benefitial, yet.
Aug 19 2021, 8:38 AM · bhyve

Aug 17 2021

grehan accepted D31570: vmm: Add memlock rlimit and racct limit.

Double-accounting for memory is a never-ending issue in bhyve :(

Aug 17 2021, 10:26 PM
grehan added a comment to D31578: bhyve: replace fwctl by QEMU's fwcfg.

There's zero reason to change for this alone, and it requires a flag day for both bhyve and UEFI firmware which has thus far been avoided.

As next step bhyve could implement more fwcfg items from QEMU to use QEMU's features without developing an own firmware implementation.

Aug 17 2021, 10:11 AM · bhyve
grehan added a comment to D31578: bhyve: replace fwctl by QEMU's fwcfg.

Bhyve's fwctl only passes the number of vcpus to the guest. That could be done easily by QEMU's fwcfg.

Aug 17 2021, 7:17 AM · bhyve

Aug 15 2021

grehan committed R10:d7388d33b4dd: MFC 517904de5cca: igc(4): Introduce new driver for the Intel I225 Ethernet… (authored by grehan).
MFC 517904de5cca: igc(4): Introduce new driver for the Intel I225 Ethernet…
Aug 15 2021, 9:12 AM

Aug 9 2021

grehan accepted D31449: e1000: Fix lem/em UDP rx csum offload.
Aug 9 2021, 9:23 PM

Aug 8 2021

grehan accepted D31462: vmm: Make iommu ops tables const.
Aug 8 2021, 10:05 PM

Aug 7 2021

grehan accepted D28880: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images.
Aug 7 2021, 8:49 AM

Aug 5 2021

grehan accepted D28880: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images.
Aug 5 2021, 11:30 PM

Aug 2 2021

grehan accepted D31372: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1.
Aug 2 2021, 6:49 AM

Jul 31 2021

grehan accepted D31342: bhyve: net_backends, automatically IFF_UP tap devices.

No POLA concerns: this is fine. Thanks bz.

Jul 31 2021, 10:47 PM
grehan accepted D31227: igc: sync igc_txrx with igb.
Jul 31 2021, 3:04 AM

Jul 26 2021

grehan accepted D31306: libvmmapi: Fix warnings and stop overridding WARNS.
Jul 26 2021, 8:26 PM

Jul 25 2021

grehan committed R10:bbe80bff7c35: arm64: HWCAP/HWCAP2 aux args support for 32-bit ARM binaries. (authored by grehan).
arm64: HWCAP/HWCAP2 aux args support for 32-bit ARM binaries.
Jul 25 2021, 8:32 AM
grehan closed D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..
Jul 25 2021, 8:32 AM

Jul 23 2021

grehan updated the diff for D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..
  • Invert sense of SEVL printing.
Jul 23 2021, 7:27 AM

Jul 21 2021

grehan added a comment to D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..

The register printing may be a bit verbose: feedback welcome.

AArch32 Instruction Set Attributes 5 = <CRC32,SHA2,SHA1,AES+VMULL>
AArch32 Media and VFP Features 0 = <FPRound,FPSqrt,FPDivide,DP VFPv3+v4,SP VFPv3+v4,AdvSIMD>
AArch32 Media and VFP Features 1 = <SIMDFMAC,FPHP DP Conv,SIMDHP SP Conv,SIMDSP,SIMDInt,SIMDLS,FPDNaN,FPFtZ>
Jul 21 2021, 12:13 PM
grehan updated the diff for D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..
  • Remove HWCAP32_THUMBEE as this is unused in ARMv8
  • Update COMPAT HWCAP comments to reflect ARMv8 usage.
  • Print aarch32 regs, and compare across all CPUs.
  • Remove _EL1 from register defines.
  • Fix typo in ID_ISAR5_VCMA_IMPL constant.
  • FPshVec -> FPShVec in register defines.
  • Review feedback on register names
Jul 21 2021, 12:09 PM

Jul 20 2021

grehan added a comment to D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..

Thanks: I'll pull in changes for this with the fix for checking caps across CPUs.

Jul 20 2021, 10:43 AM

Jul 15 2021

grehan updated the diff for D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..
  • Remove HWCAP32_THUMBEE as this is unused in ARMv8
  • Update COMPAT HWCAP comments to reflect ARMv8 usage.
Jul 15 2021, 10:41 AM

Jul 14 2021

grehan added inline comments to D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..
Jul 14 2021, 11:14 AM
grehan updated the summary of D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..
Jul 14 2021, 9:00 AM
grehan requested review of D31175: Support HWCAP/HWCAP2 for 32-bit ARM binaries..
Jul 14 2021, 8:51 AM

Jul 13 2021

grehan accepted D30827: vmm: Fix AMD-vi using wrong rid range.
Jul 13 2021, 7:33 AM
grehan added inline comments to D30827: vmm: Fix AMD-vi using wrong rid range.
Jul 13 2021, 3:17 AM

Jul 12 2021

grehan closed D30668: Intel I225 Driver.
Jul 12 2021, 12:18 AM
grehan committed R10:517904de5cca: igc(4): Introduce new driver for the Intel I225 Ethernet controller. (authored by grehan).
igc(4): Introduce new driver for the Intel I225 Ethernet controller.
Jul 12 2021, 12:18 AM

Jun 28 2021

grehan committed R10:4bb2057c13b5: bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL (authored by c.koehne_beckhoff.com).
bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL
Jun 28 2021, 12:09 PM
grehan updated the diff for D30668: Intel I225 Driver.
  • Merge e1000 commit 4b38eed76d for promisc filter handling.
Jun 28 2021, 8:10 AM

Jun 25 2021

grehan accepted D30897: bhyve: Fix NVMe iovec construction for large IOs.
Jun 25 2021, 11:34 PM

Jun 16 2021

grehan updated the diff for D30668: Intel I225 Driver.
  • Use correct SPDX identifier and move to after copyrights.
Jun 16 2021, 10:40 PM
grehan added inline comments to D30668: Intel I225 Driver.
Jun 16 2021, 1:54 PM

Jun 15 2021

grehan added a comment to D30668: Intel I225 Driver.

I don't see any glaring problems with it that should block it from going upstream. Are you going to announce this addition on the mailing lists?

Jun 15 2021, 10:50 PM

Jun 8 2021

grehan closed D30020: bhyve: add virtio-input emulation.
Jun 8 2021, 11:04 AM · bhyve
grehan committed R10:054accac71e0: Add a virtio-input device emulation. (authored by c.koehne_beckhoff.com).
Add a virtio-input device emulation.
Jun 8 2021, 11:04 AM
grehan updated the diff for D30668: Intel I225 Driver.
  • "ethernet" -> "Ethernet"
Jun 8 2021, 7:16 AM
grehan added inline comments to D30668: Intel I225 Driver.
Jun 8 2021, 7:15 AM
grehan updated the diff for D30668: Intel I225 Driver.
  • Fix up copyrights based on review feedback.
  • Consistent capitalization of I225
Jun 8 2021, 5:13 AM
grehan added a comment to D30668: Intel I225 Driver.

Even absent my new draft, there's already a few files in the tree with this construct, so these should be fine going in prior to it being finalized.

Jun 8 2021, 5:12 AM

Jun 7 2021

grehan requested review of D30668: Intel I225 Driver.
Jun 7 2021, 8:41 AM

Jun 4 2021

grehan accepted D30020: bhyve: add virtio-input emulation.

Verified this works with a mouse on Win10.

Jun 4 2021, 7:21 AM · bhyve

Jun 3 2021

grehan accepted D30506: bhyve vtblk: Inform guests of disk resize events..
Jun 3 2021, 1:03 PM
grehan accepted D30505: bhyve: Split out a lower-level helper for VirtIO interrupts..
Jun 3 2021, 12:59 PM
grehan accepted D30504: bhyve: Add support for handling disk resize events to block_if..
Jun 3 2021, 12:56 PM
grehan accepted D30503: bhyve: Add support for EVFILT_VNODE mevents..
Jun 3 2021, 12:55 PM
grehan accepted D30502: bhyve: Register new kevents synchronously..
Jun 3 2021, 12:52 PM

May 31 2021

grehan added a comment to D26976: bhyve - ARMv8 implementation.

bcran that's just informational: it still works fine.

May 31 2021, 5:54 AM

May 26 2021

grehan added a member for pfsense: grehan.
May 26 2021, 8:35 PM
grehan added a comment to D30462: vmm: Let guests enable SMEP/SMAP if the host supports it.
In D30462#684409, @kib wrote:

I believe SMAP on AMD is very recent feature, AFAIR it is not present on Zen2.

May 26 2021, 7:54 AM
grehan added a comment to D30462: vmm: Let guests enable SMEP/SMAP if the host supports it.

From dmesg on a FreeBSD-14 guest on a Ryzen 4700U.

May 26 2021, 1:12 AM
grehan accepted D30462: vmm: Let guests enable SMEP/SMAP if the host supports it.
May 26 2021, 12:03 AM

May 24 2021

grehan added inline comments to D29473: Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K'.
May 24 2021, 11:16 AM
grehan added inline comments to D29473: Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K'.
May 24 2021, 7:59 AM

May 8 2021

grehan accepted D29213: bhyve/snapshot: provide a way to send other messages/data to bhyve.
May 8 2021, 8:08 AM

May 7 2021

grehan accepted D30050: Adds uuid validation to bhyve(8) arg parsing.
May 7 2021, 8:17 AM

May 3 2021

grehan accepted D30049: virtio_blk: Fix issuing T_GET_ID before DRIVER_OK status.
May 3 2021, 11:04 AM

May 1 2021

grehan added inline comments to D30050: Adds uuid validation to bhyve(8) arg parsing.
May 1 2021, 11:48 PM

Apr 30 2021

grehan added a comment to D30050: Adds uuid validation to bhyve(8) arg parsing.

The uuid is being correctly validated in smbiostbl.c:smbios_type1_initializer() so there's no need to do it again. An fprintf to stderr there indicatiing it is invalid is fine, and the assert on a return from smbios_build() can be changed into an exit(1).

Apr 30 2021, 11:16 PM

Apr 19 2021

grehan accepted D29525: AMD-vi: Fortify IVHD device_identify process.
Apr 19 2021, 7:05 AM

Apr 17 2021

grehan added inline comments to D29801: e1000: Add support for [Tiger, Alder, Meteor] Lake client platforms.
Apr 17 2021, 2:28 AM

Apr 15 2021

grehan committed R10:17d214c2ca9f: bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL (authored by c.koehne_beckhoff.com).
bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL
Apr 15 2021, 5:52 AM
grehan closed D29665: bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL.
Apr 15 2021, 5:52 AM · bhyve

Apr 14 2021

grehan added a comment to D29430: Append Keyboard Layout specified option for using VNC. Part one: supporting QEMU Extended Keyboard Event Message.

the least effort would be to not touch this review and commit the already reviewed patch to main.

Apr 14 2021, 10:38 PM

Apr 13 2021

grehan accepted D29665: bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL.

Looks fine, and preserves #GP on writes.

Apr 13 2021, 7:52 AM · bhyve
grehan added a comment to D29430: Append Keyboard Layout specified option for using VNC. Part one: supporting QEMU Extended Keyboard Event Message.

Want to abandon this one and re-submit ?

Apr 13 2021, 7:32 AM
grehan accepted D29696: bhyve: enhance debug info for memory range clash.

This is worth having.

Apr 13 2021, 5:58 AM

Apr 9 2021

grehan accepted D29657: bhyve: add SMBIOS Baseboard Information.

Looks good.

Apr 9 2021, 9:17 AM

Apr 7 2021

grehan added a comment to D29607: byhve: add option to specify IP address for gdb.

Rod, why is your opinion so important ?

Apr 7 2021, 12:26 PM
grehan added inline comments to D29607: byhve: add option to specify IP address for gdb.
Apr 7 2021, 8:06 AM
grehan added inline comments to D29607: byhve: add option to specify IP address for gdb.
Apr 7 2021, 7:56 AM

Apr 3 2021

grehan committed R10:ab899f8937c1: Fix typo in xhci nvlist node name, and also increment device counter. (authored by grehan).
Fix typo in xhci nvlist node name, and also increment device counter.
Apr 3 2021, 6:41 AM

Mar 31 2021

grehan accepted D29521: AMD-vi: Mixed format IVHD block should replace fixed format IVHD block.

Fixes the issue for me.

Mar 31 2021, 10:20 PM