Page MenuHomeFreeBSD

grehan (Peter Grehan)
User

Projects

User Details

User Since
May 9 2014, 10:54 PM (349 w, 6 d)

Recent Activity

Tue, Jan 19

grehan accepted D28242: bhyve(8): allow mevent to filter EVFILT_VNODE kevents.

Looks fine.

Tue, Jan 19, 10:31 PM
grehan added inline comments to D28242: bhyve(8): allow mevent to filter EVFILT_VNODE kevents.
Tue, Jan 19, 10:29 PM
grehan added inline comments to D28242: bhyve(8): allow mevent to filter EVFILT_VNODE kevents.
Tue, Jan 19, 10:27 PM
grehan committed R10:eed1cc6cdfa7: Support COM3 and COM4 serial ports. (authored by grehan).
Support COM3 and COM4 serial ports.
Tue, Jan 19, 8:23 AM
grehan closed D28207: Add COM3 and COM4 to bhyve guests.
Tue, Jan 19, 8:23 AM

Sun, Jan 17

grehan accepted D28207: Add COM3 and COM4 to bhyve guests.

Change looks useful, thanks.

Sun, Jan 17, 11:17 PM

Mon, Jan 11

grehan accepted D27856: virtio: Add VirtIO PCI modern (V1) support.

I've looked at all the non-vtnet phab changes, and looked at the diff of the cumulative vtnet changes.

Mon, Jan 11, 9:15 AM
grehan added inline comments to D27902: virtio_blk: Add modern (V1) support.
Mon, Jan 11, 8:57 AM

Thu, Dec 31

grehan added a comment to D27855: Summary: Revert prior VirtIO "V1" network support to simplify upcoming V1 changes.

I've updated the title and description.

Thu, Dec 31, 4:11 AM
grehan retitled D27855: Summary: Revert prior VirtIO "V1" network support to simplify upcoming V1 changes from Summary: Revert incorrect VirtIO "V1" support to Summary: Revert prior VirtIO "V1" network support to simplify upcoming V1 changes.
Thu, Dec 31, 4:10 AM

Dec 18 2020

grehan closed D27605: Fix issues with various VNC clients..
Dec 18 2020, 12:39 AM
grehan committed rS368747: Fix issues with various VNC clients..
Fix issues with various VNC clients.
Dec 18 2020, 12:39 AM

Dec 16 2020

grehan added inline comments to D26035: Refactor configuration management in bhyve..
Dec 16 2020, 11:39 PM
grehan accepted D27629: x86: stop punishing VMs with low priority for TSC timecounter.
Dec 16 2020, 9:43 AM

Dec 15 2020

grehan updated the diff for D27605: Fix issues with various VNC clients..

Convert to use c11 atomics.

Dec 15 2020, 10:28 AM

Dec 14 2020

grehan requested review of D27605: Fix issues with various VNC clients..
Dec 14 2020, 8:59 AM

Dec 13 2020

grehan committed R9:4bba2cd5594c: Announce as new committer (authored by grehan).
Announce as new committer
Dec 13 2020, 7:17 PM
grehan committed R9:3dfd5c045517: Add myself (authored by grehan).
Add myself
Dec 13 2020, 7:17 PM
grehan committed R9:f0effe2738ca: Belatedly add GnuPG key for upcoming mentor duties. (authored by grehan).
Belatedly add GnuPG key for upcoming mentor duties.
Dec 13 2020, 6:44 PM
grehan committed R9:741e962f181f: Put in request for an XServe for the cluster. There have been a (authored by grehan).
Put in request for an XServe for the cluster. There have been a
Dec 13 2020, 6:44 PM

Dec 10 2020

grehan accepted D26915: virtio_pci: Allow memory space for configuration.
Dec 10 2020, 6:29 AM

Dec 9 2020

grehan committed rS368477: MFC r367762.
MFC r367762
Dec 9 2020, 2:48 AM
grehan accepted D27519: add deprecation notice for bvmdebug and bvmconsole.
Dec 9 2020, 12:05 AM

Dec 6 2020

grehan accepted D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Dec 6 2020, 9:20 PM
grehan accepted D27490: deprecate/remove bvmconsole and bvmdebug.
Dec 6 2020, 12:57 AM

Nov 30 2020

grehan accepted D27230: Update bhyve related ports.

Only other thing I can think of is to install VARS.fd as read-only since it's use is as a template and not a location for vars. But, this can be done later (as can cutting over to an edk2 stable tag)

Nov 30 2020, 6:07 AM

Nov 29 2020

grehan added inline comments to D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Nov 29 2020, 12:37 PM
grehan added inline comments to D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Nov 29 2020, 1:06 AM
grehan committed rS368135: MFC r368047.
MFC r368047
Nov 29 2020, 12:54 AM

Nov 28 2020

grehan accepted D27402: bhyve: limit max GPA to VM_MAXUSER_ADDRESS_LA48..
Nov 28 2020, 1:34 PM
grehan added a comment to D26137: Wireguard merge.

I'm not seeing those files in 80072.

Nov 28 2020, 8:44 AM
grehan closed D27375: vmm: Convert vmm_ops calls to IFUNC.
Nov 28 2020, 1:17 AM
grehan committed rS368115: Convert vmm_ops calls to IFUNC.
Convert vmm_ops calls to IFUNC
Nov 28 2020, 1:17 AM
grehan added inline comments to D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Nov 28 2020, 12:34 AM
grehan accepted D27375: vmm: Convert vmm_ops calls to IFUNC.
Nov 28 2020, 12:17 AM

Nov 27 2020

grehan accepted D26137: Wireguard merge.

I'm ok with this to go in to CURRENT and any remaining debug to occur there.

Nov 27 2020, 8:12 PM

Nov 26 2020

grehan added inline comments to D27230: Update bhyve related ports.
Nov 26 2020, 8:37 AM
grehan committed rS368047: Remove manual instruction encodings for VMLOAD, VMRUN, and VMSAVE..
Remove manual instruction encodings for VMLOAD, VMRUN, and VMSAVE.
Nov 26 2020, 5:59 AM
grehan accepted D27377: vmm: amd: Remove manual instruction encodings.
Nov 26 2020, 3:11 AM

Nov 25 2020

grehan added a comment to D27375: vmm: Convert vmm_ops calls to IFUNC.

Tests out fine on a Ryzen system.

Nov 25 2020, 9:46 PM
grehan added a reviewer for D27262: Break down the sglist if VIRTIO_BLK_F_SIZE_MAX is on: bryanv.
Nov 25 2020, 10:17 AM

Nov 24 2020

grehan committed rS367975: Restore Bryan Venteicher's commit bit.
Restore Bryan Venteicher's commit bit
Nov 24 2020, 2:05 AM

Nov 22 2020

grehan accepted D27301: Pull the check for VM ownership into ppt_find()..
Nov 22 2020, 7:51 PM

Nov 21 2020

grehan accepted D27212: Honor the disabled setting for MSI-X interrupts for passthrough devices..

Looks fine.

Nov 21 2020, 9:10 AM

Nov 20 2020

grehan committed rS367859: MFC r367709.
MFC r367709
Nov 20 2020, 3:33 AM

Nov 19 2020

grehan closed D27243: bhyve: Advance RIP after userspace instruction decode.
Nov 19 2020, 7:23 AM
grehan committed rS367834: Advance RIP after userspace instruction decode.
Advance RIP after userspace instruction decode
Nov 19 2020, 7:23 AM

Nov 18 2020

grehan accepted D27243: bhyve: Advance RIP after userspace instruction decode.
Nov 18 2020, 6:57 PM

Nov 17 2020

grehan closed D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests..
Nov 17 2020, 1:14 PM
grehan committed rS367762: Add legacy debug/test interfaces for kvm unit tests..
Add legacy debug/test interfaces for kvm unit tests.
Nov 17 2020, 1:14 PM
grehan accepted D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests..
Nov 17 2020, 12:22 PM

Nov 16 2020

grehan added a comment to D26209: GVT-d support for bhyve.

D24066 should be committed soon so one less obstacle for this work.

Nov 16 2020, 8:44 AM · bhyve
grehan added a comment to D27230: Update bhyve related ports.

Can we keep the CSM one until the bitter end, and build it from the existing repo ?

Nov 16 2020, 3:20 AM
grehan accepted D27220: libuvmem: usermode port of vmem(9).

No objection from bhyve's PoV.

Nov 16 2020, 2:41 AM

Nov 15 2020

grehan committed rS367709: Fix regression in AHCI controller settings..
Fix regression in AHCI controller settings.
Nov 15 2020, 1:00 PM

Nov 13 2020

grehan accepted D24066: bhyve: support relocating fbuf and passthru data BARs.

EPT invalidation has been tidied up with rS367593 so this is fine to go in now (and is gating D26209)

Nov 13 2020, 8:41 AM · bhyve

Nov 12 2020

grehan added a comment to D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests..

A snapshot of the KVM unit tests, slightly modified to work with bhyve and Adam's change, is at https://people.freebsd.org/~grehan/kvm_unit_tests/kut.tgz

Nov 12 2020, 10:10 AM
grehan retitled D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests. from bhyve: Add legacy debug/test interfaces to bhyve: Add legacy debug/test interfaces for kvm unit tests..
Nov 12 2020, 8:59 AM
grehan accepted D27186: bhyve: remove a hack to map all 8G BARs 1:1.
Nov 12 2020, 2:32 AM

Nov 11 2020

grehan accepted D27147: bhyve: update smbiostbl.c to bump the versions and release dates.
Nov 11 2020, 6:47 PM
grehan accepted D27095: bhyve: avoid allocating BARs above the end of supported physical addresses.
Nov 11 2020, 11:04 AM

Nov 9 2020

grehan added inline comments to D27147: bhyve: update smbiostbl.c to bump the versions and release dates.
Nov 9 2020, 5:33 AM

Nov 7 2020

grehan accepted D27123: Reporting same value for smbios.chassis.maker as smbios.system.maker.
Nov 7 2020, 8:13 AM

Nov 5 2020

grehan accepted D27095: bhyve: avoid allocating BARs above the end of supported physical addresses.

This should be fine.

Nov 5 2020, 9:54 PM
grehan added inline comments to D27095: bhyve: avoid allocating BARs above the end of supported physical addresses.
Nov 5 2020, 1:03 AM
grehan added a comment to D27095: bhyve: avoid allocating BARs above the end of supported physical addresses.

btw many thanks for doing this.

Nov 5 2020, 12:54 AM

Nov 4 2020

grehan requested changes to D27092: bhyve: Handle exits due to membar accesses.

This is incorrect: there should never be an exit for a membar access by a guest, hence the assert.

Nov 4 2020, 8:58 PM

Nov 2 2020

grehan accepted D26910: Make pmap_invalidate_ept() wait synchronously for guest exits.
Nov 2 2020, 7:57 PM

Oct 26 2020

grehan accepted D26910: Make pmap_invalidate_ept() wait synchronously for guest exits.

Would it be possible to cache the smr_seq_t instead of pmap->pm_eptgen ? One less atomic to increment.

Oct 26 2020, 8:24 AM

Oct 17 2020

grehan accepted D26830: vmx: Implement pmap (de)activation in C.

an error from invept results in a panic

Oct 17 2020, 11:07 PM

Oct 16 2020

grehan accepted D26798: /usr/sbin/bhyve: Update TX descriptor base address and host mapping on change.

Ahh Windows :(

Oct 16 2020, 2:58 AM

Oct 7 2020

grehan added a comment to D26710: bhyveload(8): Implement loader_callbacks::diskwrite.

I did not check how the disk is opened by loader

Oct 7 2020, 8:48 PM
grehan accepted D26710: bhyveload(8): Implement loader_callbacks::diskwrite.

Looks fine.

Oct 7 2020, 7:50 PM

Oct 6 2020

grehan added a comment to D26506: [WIP] bhyve: GPU Passthrough for AMD Ryzen V1000.

Could you give me some more information on where to find these patches and how to apply them?

Oct 6 2020, 10:21 AM · bhyve

Oct 4 2020

grehan added a comment to D23021: vmm: Expose per-cpu guest time counters in a new sysctl.

counter(9) should be used to implement this.

Oct 4 2020, 10:41 PM

Sep 29 2020

grehan added a comment to D26506: [WIP] bhyve: GPU Passthrough for AMD Ryzen V1000.

Generic PCI ROM BIOS support in EFI might be a better solution for this (there is a version posted in the vga-bios patches a while back), with ROM extraction being a separate issue.

Sep 29 2020, 9:00 AM · bhyve
grehan added a comment to D26209: GVT-d support for bhyve.

D24066 would cover the unmap code: this work could reuse that.

Sep 29 2020, 7:33 AM · bhyve

Sep 18 2020

grehan committed rS365873: Fix byte-reversal of language ID in string descriptor..
Fix byte-reversal of language ID in string descriptor.
Sep 18 2020, 5:55 AM
grehan closed D26472: bhyve: Fix language id of String Descriptors in usb mouse..
Sep 18 2020, 5:55 AM
grehan accepted D26472: bhyve: Fix language id of String Descriptors in usb mouse..
Sep 18 2020, 1:04 AM

Sep 10 2020

grehan committed rS365560: MFC r364340, r364343, r364656.
MFC r364340, r364343, r364656
Sep 10 2020, 10:50 AM

Sep 8 2020

grehan committed rS365443: MFC 364339.
MFC 364339
Sep 8 2020, 3:56 AM

Sep 2 2020

grehan added inline comments to D26209: GVT-d support for bhyve.
Sep 2 2020, 12:21 PM · bhyve

Aug 27 2020

grehan added a comment to D26209: GVT-d support for bhyve.

The Intel ACRN edk2 fork has a GVT GOP driver that may be suitable

https://github.com/projectacrn/acrn-edk2/tree/ovmf-acrn/OvmfPkg/GvtGopDxe
Aug 27 2020, 7:11 AM · bhyve
grehan added a reviewer for D26209: GVT-d support for bhyve: grehan.

Thanks, looking at this now.

Aug 27 2020, 7:01 AM · bhyve

Aug 24 2020

grehan committed rS364656: cpu_auxmsr: assert caller is preventing CPU migration..
cpu_auxmsr: assert caller is preventing CPU migration.
Aug 24 2020, 11:50 AM
grehan closed D26166: cpu_auxmsr: assert caller is preventing CPU migration.
Aug 24 2020, 11:50 AM
grehan accepted D26166: cpu_auxmsr: assert caller is preventing CPU migration.

Thanks kib@, I can commit this.

Aug 24 2020, 12:58 AM
grehan added inline comments to D26035: Refactor configuration management in bhyve..
Aug 24 2020, 12:11 AM

Aug 19 2020

grehan accepted D24202: bhyve: Initial some NVMe controller health log data..

I'm happy with this change but need to wait for maintainer approval before I commit it

Aug 19 2020, 9:51 PM

Aug 18 2020

grehan committed rS364343: Export a routine to provide the TSC_AUX MSR value and use this in vmm..
Export a routine to provide the TSC_AUX MSR value and use this in vmm.
Aug 18 2020, 11:36 AM
grehan closed D26003: vmm: intel: Support rdtscp and rdpid.
Aug 18 2020, 7:24 AM
grehan committed rS364340: Support guest rdtscp and rdpid instructions on Intel VT-x.
Support guest rdtscp and rdpid instructions on Intel VT-x
Aug 18 2020, 7:23 AM
grehan committed rS364339: Allow guest device MMIO access from bootmem memory segments..
Allow guest device MMIO access from bootmem memory segments.
Aug 18 2020, 7:08 AM
grehan closed D25955: Allow guest device MMIO access from bootmem memory segments..
Aug 18 2020, 7:08 AM
grehan committed rS364334: MFC 363596, 363719, 363733.
MFC 363596, 363719, 363733
Aug 18 2020, 3:40 AM

Aug 14 2020

grehan added inline comments to D26035: Refactor configuration management in bhyve..
Aug 14 2020, 3:40 AM

Aug 13 2020

grehan added a comment to D26035: Refactor configuration management in bhyve..
In D26035#578286, @jhb wrote:

Given the config file syntax will likely change but the "-f" option will be around forever, can a magic number or first-line metadata comment be used to distinguish this key/value file format from a future version ?

I would be fine with using a more obscure option for the flat config file (if we did long opts it could be a --flat-config or some such without a short letter even, but we don't do any long opts so not quite as straightforward to pick an obscure one). I don't really expect the syntax of that to change, but I think having '-f' be used for a more friendly UCL syntax might be more useful and I would be happy to leave "-f" free for the UCL thing to use. The UCL thing might itself include a version number as a field for the UCL parser to use that I think would permit some level of compatibility in the future.

Aug 13 2020, 9:41 PM
grehan added a comment to D26035: Refactor configuration management in bhyve..

Given the config file syntax will likely change but the "-f" option will be around forever, can a magic number or first-line metadata comment be used to distinguish this key/value file format from a future version ?

Aug 13 2020, 1:01 AM

Aug 12 2020

grehan accepted D26003: vmm: intel: Support rdtscp and rdpid.
Aug 12 2020, 8:38 AM