Page MenuHomeFreeBSD

grehan (Peter Grehan)
User

Projects

User Details

User Since
May 9 2014, 10:54 PM (370 w, 6 d)

Recent Activity

Wed, Jun 16

grehan updated the diff for D30668: Intel I225 Driver.
  • Use correct SPDX identifier and move to after copyrights.
Wed, Jun 16, 10:40 PM
grehan added inline comments to D30668: Intel I225 Driver.
Wed, Jun 16, 1:54 PM

Tue, Jun 15

grehan added a comment to D30668: Intel I225 Driver.

I don't see any glaring problems with it that should block it from going upstream. Are you going to announce this addition on the mailing lists?

Tue, Jun 15, 10:50 PM

Tue, Jun 8

grehan closed D30020: bhyve: add virtio-input emulation.
Tue, Jun 8, 11:04 AM · bhyve
grehan committed R10:054accac71e0: Add a virtio-input device emulation. (authored by c.koehne_beckhoff.com).
Add a virtio-input device emulation.
Tue, Jun 8, 11:04 AM
grehan updated the diff for D30668: Intel I225 Driver.
  • "ethernet" -> "Ethernet"
Tue, Jun 8, 7:16 AM
grehan added inline comments to D30668: Intel I225 Driver.
Tue, Jun 8, 7:15 AM
grehan updated the diff for D30668: Intel I225 Driver.
  • Fix up copyrights based on review feedback.
  • Consistent capitalization of I225
Tue, Jun 8, 5:13 AM
grehan added a comment to D30668: Intel I225 Driver.

Even absent my new draft, there's already a few files in the tree with this construct, so these should be fine going in prior to it being finalized.

Tue, Jun 8, 5:12 AM

Mon, Jun 7

grehan requested review of D30668: Intel I225 Driver.
Mon, Jun 7, 8:41 AM

Fri, Jun 4

grehan accepted D30020: bhyve: add virtio-input emulation.

Verified this works with a mouse on Win10.

Fri, Jun 4, 7:21 AM · bhyve

Thu, Jun 3

grehan accepted D30506: bhyve vtblk: Inform guests of disk resize events..
Thu, Jun 3, 1:03 PM
grehan accepted D30505: bhyve: Split out a lower-level helper for VirtIO interrupts..
Thu, Jun 3, 12:59 PM
grehan accepted D30504: bhyve: Add support for handling disk resize events to block_if..
Thu, Jun 3, 12:56 PM
grehan accepted D30503: bhyve: Add support for EVFILT_VNODE mevents..
Thu, Jun 3, 12:55 PM
grehan accepted D30502: bhyve: Register new kevents synchronously..
Thu, Jun 3, 12:52 PM

Mon, May 31

grehan added a comment to D26976: bhyve - ARMv8 implementation.

bcran that's just informational: it still works fine.

Mon, May 31, 5:54 AM

Wed, May 26

grehan added a member for pfsense: grehan.
Wed, May 26, 8:35 PM
grehan added a comment to D30462: vmm: Let guests enable SMEP/SMAP if the host supports it.
In D30462#684409, @kib wrote:

I believe SMAP on AMD is very recent feature, AFAIR it is not present on Zen2.

Wed, May 26, 7:54 AM
grehan added a comment to D30462: vmm: Let guests enable SMEP/SMAP if the host supports it.

From dmesg on a FreeBSD-14 guest on a Ryzen 4700U.

Wed, May 26, 1:12 AM
grehan accepted D30462: vmm: Let guests enable SMEP/SMAP if the host supports it.
Wed, May 26, 12:03 AM

Mon, May 24

grehan added inline comments to D29473: Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K'.
Mon, May 24, 11:16 AM
grehan added inline comments to D29473: Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K'.
Mon, May 24, 7:59 AM

May 8 2021

grehan accepted D29213: bhyve/snapshot: provide a way to send other messages/data to bhyve.
May 8 2021, 8:08 AM

May 7 2021

grehan accepted D30050: Adds uuid validation to bhyve(8) arg parsing.
May 7 2021, 8:17 AM

May 3 2021

grehan accepted D30049: virtio_blk: Fix issuing T_GET_ID before DRIVER_OK status.
May 3 2021, 11:04 AM

May 1 2021

grehan added inline comments to D30050: Adds uuid validation to bhyve(8) arg parsing.
May 1 2021, 11:48 PM

Apr 30 2021

grehan added a comment to D30050: Adds uuid validation to bhyve(8) arg parsing.

The uuid is being correctly validated in smbiostbl.c:smbios_type1_initializer() so there's no need to do it again. An fprintf to stderr there indicatiing it is invalid is fine, and the assert on a return from smbios_build() can be changed into an exit(1).

Apr 30 2021, 11:16 PM

Apr 19 2021

grehan accepted D29525: AMD-vi: Fortify IVHD device_identify process.
Apr 19 2021, 7:05 AM

Apr 17 2021

grehan added inline comments to D29801: e1000: Add support for [Tiger, Alder, Meteor] Lake client platforms.
Apr 17 2021, 2:28 AM

Apr 15 2021

grehan committed R10:17d214c2ca9f: bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL (authored by c.koehne_beckhoff.com).
bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL
Apr 15 2021, 5:52 AM
grehan closed D29665: bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL.
Apr 15 2021, 5:52 AM · bhyve

Apr 14 2021

grehan added a comment to D29430: Append Keyboard Layout specified option for using VNC. Part one: supporting QEMU Extended Keyboard Event Message.

the least effort would be to not touch this review and commit the already reviewed patch to main.

Apr 14 2021, 10:38 PM

Apr 13 2021

grehan accepted D29665: bhyve: implement rdmsr for MSR_IA32_FEATURE_CONTROL.

Looks fine, and preserves #GP on writes.

Apr 13 2021, 7:52 AM · bhyve
grehan added a comment to D29430: Append Keyboard Layout specified option for using VNC. Part one: supporting QEMU Extended Keyboard Event Message.

Want to abandon this one and re-submit ?

Apr 13 2021, 7:32 AM
grehan accepted D29696: bhyve: enhance debug info for memory range clash.

This is worth having.

Apr 13 2021, 5:58 AM

Apr 9 2021

grehan accepted D29657: bhyve: add SMBIOS Baseboard Information.

Looks good.

Apr 9 2021, 9:17 AM

Apr 7 2021

grehan added a comment to D29607: byhve: add option to specify IP address for gdb.

Rod, why is your opinion so important ?

Apr 7 2021, 12:26 PM
grehan added inline comments to D29607: byhve: add option to specify IP address for gdb.
Apr 7 2021, 8:06 AM
grehan added inline comments to D29607: byhve: add option to specify IP address for gdb.
Apr 7 2021, 7:56 AM

Apr 3 2021

grehan committed R10:ab899f8937c1: Fix typo in xhci nvlist node name, and also increment device counter. (authored by grehan).
Fix typo in xhci nvlist node name, and also increment device counter.
Apr 3 2021, 6:41 AM

Mar 31 2021

grehan accepted D29521: AMD-vi: Mixed format IVHD block should replace fixed format IVHD block.

Fixes the issue for me.

Mar 31 2021, 10:20 PM

Mar 30 2021

grehan accepted D29430: Append Keyboard Layout specified option for using VNC. Part one: supporting QEMU Extended Keyboard Event Message.
Mar 30 2021, 8:11 AM

Mar 27 2021

grehan accepted D29430: Append Keyboard Layout specified option for using VNC. Part one: supporting QEMU Extended Keyboard Event Message.

Looks fine: please fix the #define on submit.

Mar 27 2021, 2:02 AM

Mar 18 2021

grehan accepted D26035: Refactor configuration management in bhyve..
Mar 18 2021, 9:44 PM
grehan accepted D24066: bhyve: support relocating fbuf and passthru data BARs.
Mar 18 2021, 12:52 AM · bhyve

Mar 17 2021

grehan added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

The older bhyve edk2 f/w can be built with up to gcc7, if gcc48 needs to be killed off

(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222233#c7)
Mar 17 2021, 7:41 AM

Mar 9 2021

grehan accepted D29143: if_wg: export tx_bytes, rx_bytes, and last_handshake.
Mar 9 2021, 11:38 AM
grehan accepted D29142: if_wg: wg_input: remove a couple locals (NFC).
Mar 9 2021, 11:03 AM

Mar 8 2021

grehan added a comment to D29126: bhyve: address-of-packed-member warnings.

Maybe ping ctuffli/imp for nvme.h, since that may involve removing other unecessary __packed's

Mar 8 2021, 11:00 AM
grehan accepted D29126: bhyve: address-of-packed-member warnings.

Yes for the bhyve parts.

Mar 8 2021, 10:59 AM
grehan accepted D29124: if_wg: avoid sleeping under the net epoch.
Mar 8 2021, 8:05 AM
grehan accepted D29011: wg: Fix some mbuf leaks in the input path.
Mar 8 2021, 6:46 AM

Mar 7 2021

grehan accepted D29084: bhyve: virtio shares definitions between sys/dev/virtio.

Good catch rew :)

Mar 7 2021, 11:05 PM
grehan accepted D29109: bhyvectl: print a better error message when vm_open fails.
Mar 7 2021, 2:18 AM

Mar 6 2021

grehan accepted D29084: bhyve: virtio shares definitions between sys/dev/virtio.
Mar 6 2021, 8:58 PM
grehan accepted D29084: bhyve: virtio shares definitions between sys/dev/virtio.

Thanks for doing this; a long overdue change.

Mar 6 2021, 11:10 AM
grehan committed R10:9705c012c1f0: Import wireguard fixes from pfSense 2.5 (authored by grehan).
Import wireguard fixes from pfSense 2.5
Mar 6 2021, 6:13 AM

Mar 5 2021

grehan committed R10:96aabea8bd23: Import wireguard fixes from pfSense 2.5 (authored by grehan).
Import wireguard fixes from pfSense 2.5
Mar 5 2021, 3:24 AM

Mar 2 2021

grehan added a comment to D28933: wireguard: allow to set IPv6 endpoint.

D28962 now committed with 95331c228a39

Mar 2 2021, 11:35 AM
grehan committed R10:95331c228a39: Import wireguard fixes from pfSense 2.5 (authored by grehan).
Import wireguard fixes from pfSense 2.5
Mar 2 2021, 7:03 AM
grehan closed D28962: Import wireguard fixes from pfSense 2.5.
Mar 2 2021, 7:02 AM

Feb 27 2021

grehan added a comment to D28933: wireguard: allow to set IPv6 endpoint.

FYI the cumulative pfsense wireguard changes are in D28962

Feb 27 2021, 6:29 AM
grehan requested review of D28962: Import wireguard fixes from pfSense 2.5.
Feb 27 2021, 6:27 AM

Feb 26 2021

grehan added a comment to D28933: wireguard: allow to set IPv6 endpoint.

There's a more complete fix for this in the pfsense repo, that also stores the source address so CARP destination addresses will work:

https://github.com/pfsense/FreeBSD-src/commit/1940e7d3
Feb 26 2021, 7:28 AM

Feb 22 2021

grehan accepted D28726: if_vtnet: Fix pointer-sign and used parameter warnings.

The #if 0 debug code in vtnet_rxq_csum_data_valid could be removed and the unused parameter dropped, but not essential for this review.

Feb 22 2021, 3:18 AM

Feb 16 2021

grehan added a comment to D27230: Update bhyve related ports.

The 64-bit issue is still present in the updated EDK2 (and being worked on), but moving off python2/gcc48 is a more pressing issue.

Feb 16 2021, 9:13 PM
grehan accepted D27230: Update bhyve related ports.
Feb 16 2021, 9:11 PM

Feb 14 2021

grehan accepted D28655: ifconfig-wg fix incorrect allowed-ips netmask info.
Feb 14 2021, 8:34 AM

Feb 9 2021

grehan committed R10:82874dcb3610: Always clamp curve25519 keys prior to use. (authored by grehan).
Always clamp curve25519 keys prior to use.
Feb 9 2021, 1:41 AM

Feb 6 2021

grehan committed R10:6136a10e355a: Always clamp curve25519 keys prior to use. (authored by grehan).
Always clamp curve25519 keys prior to use.
Feb 6 2021, 6:10 AM

Feb 3 2021

grehan committed R10:5aaea4b99e5c: Always clamp curve25519 keys prior to use. (authored by grehan).
Always clamp curve25519 keys prior to use.
Feb 3 2021, 11:06 AM

Feb 2 2021

grehan accepted D28238: bhyve/ioapic: improve the tracking of IRR bit.

I tested all 3 ioapic diffs with a FreeBSD 12.2 guest on -current, with MSI/MSI-x disabled to force virtio-net and ahci to use level-triggered legacy IRQs. Some stress testing was done with those devices without any issue.

Feb 2 2021, 8:23 AM
grehan accepted D28237: bhyve/ioapic: only account for asserted line in edge mode.
Feb 2 2021, 8:22 AM
grehan accepted D28236: bhyve/vioapic: remove an extra pin masked check.
Feb 2 2021, 8:22 AM

Feb 1 2021

grehan accepted D28410: libvmm: clean up vmmapi.h.

A separate review is fine.

Feb 1 2021, 8:23 PM

Jan 19 2021

grehan accepted D28242: bhyve(8): allow mevent to filter EVFILT_VNODE kevents.

Looks fine.

Jan 19 2021, 10:31 PM
grehan added inline comments to D28242: bhyve(8): allow mevent to filter EVFILT_VNODE kevents.
Jan 19 2021, 10:29 PM
grehan added inline comments to D28242: bhyve(8): allow mevent to filter EVFILT_VNODE kevents.
Jan 19 2021, 10:27 PM
grehan committed R10:eed1cc6cdfa7: Support COM3 and COM4 serial ports. (authored by grehan).
Support COM3 and COM4 serial ports.
Jan 19 2021, 8:23 AM
grehan closed D28207: Add COM3 and COM4 to bhyve guests.
Jan 19 2021, 8:23 AM

Jan 17 2021

grehan accepted D28207: Add COM3 and COM4 to bhyve guests.

Change looks useful, thanks.

Jan 17 2021, 11:17 PM

Jan 11 2021

grehan accepted D27856: virtio: Add VirtIO PCI modern (V1) support.

I've looked at all the non-vtnet phab changes, and looked at the diff of the cumulative vtnet changes.

Jan 11 2021, 9:15 AM
grehan added inline comments to D27902: virtio_blk: Add modern (V1) support.
Jan 11 2021, 8:57 AM

Dec 31 2020

grehan added a comment to D27855: Summary: Revert prior VirtIO "V1" network support to simplify upcoming V1 changes.

I've updated the title and description.

Dec 31 2020, 4:11 AM
grehan retitled D27855: Summary: Revert prior VirtIO "V1" network support to simplify upcoming V1 changes from Summary: Revert incorrect VirtIO "V1" support to Summary: Revert prior VirtIO "V1" network support to simplify upcoming V1 changes.
Dec 31 2020, 4:10 AM

Dec 18 2020

grehan closed D27605: Fix issues with various VNC clients..
Dec 18 2020, 12:39 AM
grehan committed rS368747: Fix issues with various VNC clients..
Fix issues with various VNC clients.
Dec 18 2020, 12:39 AM

Dec 16 2020

grehan added inline comments to D26035: Refactor configuration management in bhyve..
Dec 16 2020, 11:39 PM
grehan accepted D27629: x86: stop punishing VMs with low priority for TSC timecounter.
Dec 16 2020, 9:43 AM

Dec 15 2020

grehan updated the diff for D27605: Fix issues with various VNC clients..

Convert to use c11 atomics.

Dec 15 2020, 10:28 AM

Dec 14 2020

grehan requested review of D27605: Fix issues with various VNC clients..
Dec 14 2020, 8:59 AM

Dec 13 2020

grehan committed R9:4bba2cd5594c: Announce as new committer (authored by grehan).
Announce as new committer
Dec 13 2020, 7:17 PM
grehan committed R9:3dfd5c045517: Add myself (authored by grehan).
Add myself
Dec 13 2020, 7:17 PM
grehan committed R9:f0effe2738ca: Belatedly add GnuPG key for upcoming mentor duties. (authored by grehan).
Belatedly add GnuPG key for upcoming mentor duties.
Dec 13 2020, 6:44 PM
grehan committed R9:741e962f181f: Put in request for an XServe for the cluster. There have been a (authored by grehan).
Put in request for an XServe for the cluster. There have been a
Dec 13 2020, 6:44 PM

Dec 10 2020

grehan accepted D26915: virtio_pci: Allow memory space for configuration.
Dec 10 2020, 6:29 AM

Dec 9 2020

grehan committed rS368477: MFC r367762.
MFC r367762
Dec 9 2020, 2:48 AM
grehan accepted D27519: add deprecation notice for bvmdebug and bvmconsole.
Dec 9 2020, 12:05 AM

Dec 6 2020

grehan accepted D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Dec 6 2020, 9:20 PM