Page MenuHomeFreeBSD

vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1
ClosedPublic

Authored by khng on Aug 1 2021, 10:55 AM.

Details

Summary

In hw.vmm.create sysctl handler the maximum length of vm name is
VM_MAX_NAMELEN. However in vm_create() the maximum length allowed is
only VM_MAX_NAMELEN - 1 chars. Bump the length of the internal buffer to
allow the length of VM_MAX_NAMELEN for vm name.

MFC after: 3 days
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

khng requested review of this revision.Aug 1 2021, 10:55 AM
This revision is now accepted and ready to land.Aug 2 2021, 6:49 AM
jhb added inline comments.
sys/amd64/vmm/vmm.c
177

I suspect this results in some padding now? Perhaps it would be best to move this field below the vcpu[] array at least?

sys/amd64/vmm/vmm.c
177

It does not create padding with default SPECNAMELEN on FreeBSD 12 and 13, but might be the case for other SPECNAMELEN values.