Differential D31372

vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1
ClosedPublic
Actions

Authored by khng on Aug 1 2021, 10:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 15, 5:22 PM

	Unknown Object (File)
	Fri, May 15, 5:21 PM

	Unknown Object (File)
	Fri, May 15, 5:08 PM

	Unknown Object (File)
	Thu, May 14, 7:37 AM

	Unknown Object (File)
	Thu, May 14, 7:34 AM

	Unknown Object (File)
	Thu, May 14, 1:31 AM

	Unknown Object (File)
	Mon, May 11, 12:56 AM

	Unknown Object (File)
	Wed, Apr 29, 4:31 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG74ef8d180fb0: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1
rG877ba067c0fb: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1
rGdf95cc76affb: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1

Summary

In hw.vmm.create sysctl handler the maximum length of vm name is
VM_MAX_NAMELEN. However in vm_create() the maximum length allowed is
only VM_MAX_NAMELEN - 1 chars. Bump the length of the internal buffer to
allow the length of VM_MAX_NAMELEN for vm name.

MFC after: 3 days
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

khng created this revision.Aug 1 2021, 10:55 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptAug 1 2021, 10:55 AM

khng requested review of this revision.Aug 1 2021, 10:55 AM

Harbormaster completed remote builds in B40789: Diff 93073.Aug 1 2021, 10:55 AM

grehan accepted this revision.Aug 2 2021, 6:49 AM

This revision is now accepted and ready to land.Aug 2 2021, 6:49 AM

Closed by commit rGdf95cc76affb: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1 (authored by khng). · Explain WhyAug 2 2021, 9:59 AM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rGdf95cc76affb: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1.

jhb added a subscriber: jhb.Aug 2 2021, 2:44 PM

jhb added inline comments.

sys/amd64/vmm/vmm.c
177	I suspect this results in some padding now? Perhaps it would be best to move this field below the vcpu[] array at least?

khng added inline comments.Aug 3 2021, 2:04 PM

sys/amd64/vmm/vmm.c
177	It does not create padding with default SPECNAMELEN on FreeBSD 12 and 13, but might be the case for other SPECNAMELEN values.

khng added a commit: rG877ba067c0fb: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1.Aug 27 2021, 11:43 AM

khng added a commit: rG74ef8d180fb0: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1.Aug 27 2021, 12:47 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

5 lines

Diff 93099

sys/amd64/vmm/vmm.c

Loading...