Differential D32952

bhyve nvme: Add AEN support to NVMe emulation
ClosedPublic
Actions

Authored by chuck on Nov 12 2021, 12:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 8, 7:08 PM

	Unknown Object (File)
	Tue, Aug 4, 3:44 PM

	Unknown Object (File)
	Sat, Aug 1, 6:07 AM

	Unknown Object (File)
	Tue, Jul 28, 4:33 AM

	Unknown Object (File)
	Sun, Jul 26, 11:49 AM

	Unknown Object (File)
	Wed, Jul 22, 12:00 AM

	Unknown Object (File)
	Mon, Jul 20, 3:21 AM

	Unknown Object (File)
	Sun, Jul 19, 9:51 PM

Subscribers

Details

Reviewers

imp
rpokala
jhb
grehan

Group Reviewers

Commits

rG9f1fa1a46117: bhyve nvme: Add AEN support to NVMe emulation

Summary

Add Asynchronous Event Notification infrastructure to the NVMe
emulation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chuck created this revision.Nov 12 2021, 12:43 AM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 12 2021, 12:43 AM

Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript

chuck requested review of this revision.Nov 12 2021, 12:43 AM

Harbormaster completed remote builds in B42742: Diff 98388.Nov 12 2021, 12:43 AM

chuck added a child revision: D32953: bhyve nvme: Inform guests of namespace resize.Nov 12 2021, 12:44 AM

chuck added reviewers: imp, rpokala, jhb, grehan.Nov 12 2021, 12:46 AM

Maybe a note to fix the spelling later in the commit :)

This revision is now accepted and ready to land.Nov 12 2021, 9:47 PM

A few updates after passing the compliance tests

Enhanced debug logging
Enable all AENs by default
Wrap waking of AEN processing thread in helper function
Also wake AEN processing as part of some Set Features and Async Requests

This revision now requires review to proceed.Dec 10 2021, 8:04 PM

Generally, this looks good. I've not looked at every bit of it, though, with an eye towards pedantry.
And I don't know bhyve well, but the NVMe stuff looks generally good.

This revision is now accepted and ready to land.Dec 10 2021, 9:06 PM

Closed by commit rG9f1fa1a46117: bhyve nvme: Add AEN support to NVMe emulation (authored by chuck). · Explain WhyDec 14 2021, 11:31 PM

This revision was automatically updated to reflect the committed changes.

chuck added a commit: rG9f1fa1a46117: bhyve nvme: Add AEN support to NVMe emulation.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

273 lines

Diff 100036

usr.sbin/bhyve/pci_nvme.c

Loading...