Differential D31306

libvmmapi: Fix warnings and stop overridding WARNS
ClosedPublic
Actions

Authored by markj on Jul 26 2021, 4:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 8:24 PM

	Unknown Object (File)
	Mon, May 18, 8:17 PM

	Unknown Object (File)
	Mon, May 18, 1:22 PM

	Unknown Object (File)
	Mon, May 18, 1:18 PM

	Unknown Object (File)
	Fri, May 15, 6:21 PM

	Unknown Object (File)
	Fri, May 15, 5:50 PM

	Unknown Object (File)
	Fri, May 15, 5:49 PM

	Unknown Object (File)
	Fri, May 15, 5:49 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG45cd18ec73dc: libvmmapi: Fix warnings and stop overridding WARNS

Summary

Avoid shadowing the global optarg.
Sprinkle __unused.
Cast nitems() to int.
Fix sign in vm_copy_setup().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 26 2021, 4:45 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 26 2021, 4:45 PM

Herald added subscribers: rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Jul 26 2021, 4:45 PM

Harbormaster completed remote builds in B40675: Diff 92745.Jul 26 2021, 4:45 PM

markj added a child revision: D31307: pci: Add ioctls to perform I/O to I/O port BARs.Jul 26 2021, 4:45 PM

Fix mismerge.

Harbormaster completed remote builds in B40678: Diff 92748.Jul 26 2021, 4:48 PM

grehan accepted this revision.Jul 26 2021, 8:26 PM

This revision is now accepted and ready to land.Jul 26 2021, 8:26 PM

Closed by commit rG45cd18ec73dc: libvmmapi: Fix warnings and stop overridding WARNS (authored by markj). · Explain WhyJul 26 2021, 8:55 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG45cd18ec73dc: libvmmapi: Fix warnings and stop overridding WARNS.

Revision Contents
Changeset List

Path

Size

lib/

libvmmapi/

2 lines

34 lines

Diff 92762

lib/libvmmapi/Makefile

Loading...

lib/libvmmapi/vmmapi.c

Loading...