libvmmapi: Fix warnings and stop overridding WARNS
ClosedPublic
Actions

Authored by markj on Jul 26 2021, 4:45 PM.

Tags

None

Referenced Files

	F152519729: D31306.id92762.diff
	Wed, Apr 15, 11:26 AM

	F152490077: D31306.id92748.diff
	Wed, Apr 15, 7:11 AM

	Unknown Object (File)
	Thu, Apr 9, 1:19 AM

	Unknown Object (File)
	Wed, Apr 8, 5:40 PM

	Unknown Object (File)
	Wed, Apr 8, 4:52 AM

	Unknown Object (File)
	Wed, Apr 8, 3:04 AM

	Unknown Object (File)
	Mon, Apr 6, 4:56 PM

	Unknown Object (File)
	Sun, Apr 5, 3:28 PM

View All Files

Subscribers

imp

rgrimes

Details

Reviewers

grehan

Group Reviewers

bhyve

Commits

rG45cd18ec73dc: libvmmapi: Fix warnings and stop overridding WARNS

Summary

Avoid shadowing the global optarg.
Sprinkle __unused.
Cast nitems() to int.
Fix sign in vm_copy_setup().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 26 2021, 4:45 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 26 2021, 4:45 PM

Herald added subscribers: rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Jul 26 2021, 4:45 PM

Harbormaster completed remote builds in B40675: Diff 92745.Jul 26 2021, 4:45 PM

markj added a child revision: D31307: pci: Add ioctls to perform I/O to I/O port BARs.Jul 26 2021, 4:45 PM

Fix mismerge.

Harbormaster completed remote builds in B40678: Diff 92748.Jul 26 2021, 4:48 PM

grehan accepted this revision.Jul 26 2021, 8:26 PM

This revision is now accepted and ready to land.Jul 26 2021, 8:26 PM

Closed by commit rG45cd18ec73dc: libvmmapi: Fix warnings and stop overridding WARNS (authored by markj). · Explain WhyJul 26 2021, 8:55 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG45cd18ec73dc: libvmmapi: Fix warnings and stop overridding WARNS.

Revision Contents
Changeset List

Path

Size

lib/

libvmmapi/

Makefile

2 lines

vmmapi.c

34 lines

Diff 92762

View Options

lib/libvmmapi/Makefile