Page MenuHomeFreeBSD
Differential D28880

bhyve: Use fspacectl(2) for BOP_DELETE on regular file images
ClosedPublic
Actions

Authored by khng on Feb 23 2021, 6:43 AM.
Tags
None
Referenced Files
F61905003: D28880.diff
Sun, May 28, 3:18 AM
Unknown Object (File)
Apr 2 2023, 6:31 PM
Unknown Object (File)
Dec 28 2022, 6:44 PM
Unknown Object (File)
Dec 24 2022, 12:43 AM
Unknown Object (File)
Dec 15 2022, 1:48 AM
Unknown Object (File)
Dec 4 2022, 5:55 PM
Subscribers
bcran
imp
lwhsu
rgrimes
Contributor Reviews (src)

Details

Reviewers
grehan
Group Reviewers
bhyve
Commits
rG3676512b60d6: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images
Summary

bhyve can also make use of fspacectl(2) to implement BOP_DELETE with
hole-punching. Since it is not desirable to do zero-filling for large
DEALLOCATE/UNMAP range, candelete is not set if pathconf(2) indicates
that the underlying file system does not support native
VOP_DEALLOCATE(9).

Submitted by: Ka Ho Ng <khng@freebsdfoundation.org>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Feb 23 2021, 6:43 AM
Herald added a reviewer: bhyve. · View Herald TranscriptFeb 23 2021, 6:43 AM
Herald added subscribers: Contributor Reviews (src), bcran, rgrimes, imp. · View Herald Transcript
khng requested review of this revision.Feb 23 2021, 6:43 AM
khng added a parent revision: D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Feb 23 2021, 6:44 AM
Harbormaster completed remote builds in B37292: Diff 84515.Feb 23 2021, 6:44 AM
lwhsu added a subscriber: lwhsu.Feb 23 2021, 7:02 AM
khng updated this revision to Diff 84554.Feb 23 2021, 3:21 PM

Updated commit message.

Harbormaster completed remote builds in B37315: Diff 84554.Feb 23 2021, 3:21 PM
khng edited the summary of this revision. (Show Details)Feb 23 2021, 3:22 PM
khng updated this revision to Diff 84733.Feb 26 2021, 8:13 AM

Rebased.

Harbormaster completed remote builds in B37398: Diff 84733.Feb 26 2021, 8:14 AM
khng updated this revision to Diff 85985.Mar 18 2021, 7:51 PM

Rebased.

Harbormaster completed remote builds in B37926: Diff 85985.Mar 18 2021, 7:51 PM
khng updated this revision to Diff 86011.Mar 19 2021, 8:40 AM

Rebased

Harbormaster completed remote builds in B37942: Diff 86011.Mar 19 2021, 8:40 AM
khng updated this revision to Diff 86186.Mar 23 2021, 10:13 AM

Updated commit message.

Harbormaster completed remote builds in B38009: Diff 86186.Mar 23 2021, 10:13 AM
khng updated this revision to Diff 93087.Aug 1 2021, 9:22 PM

Bump due to updates of D28347 (fspacectl(2) added new param)

Harbormaster completed remote builds in B40793: Diff 93087.Aug 1 2021, 9:22 PM
grehan accepted this revision.Aug 5 2021, 11:30 PM
This revision is now accepted and ready to land.Aug 5 2021, 11:30 PM
khng updated this revision to Diff 93365.Aug 7 2021, 8:13 AM

Loop over to guarantee the whole region is finished.

This revision now requires review to proceed.Aug 7 2021, 8:13 AM
Harbormaster completed remote builds in B40914: Diff 93365.Aug 7 2021, 8:13 AM
grehan accepted this revision.Aug 7 2021, 8:49 AM
This revision is now accepted and ready to land.Aug 7 2021, 8:49 AM
Closed by commit rG3676512b60d6: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images (authored by khng). · Explain WhyAug 7 2021, 9:12 AM
This revision was automatically updated to reflect the committed changes.
khng added a commit: rG3676512b60d6: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
22 lines

Diff 93366

View Options

usr.sbin/bhyve/block_if.c

Loading...