Paths

Table of Contentst

Differential D31405

Add vn_lktype_write()
ClosedPublic
Actions

Authored by kib on Aug 4 2021, 2:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 11, 11:21 PM

	Unknown Object (File)
	Tue, Dec 3, 5:22 PM

	Unknown Object (File)
	Fri, Nov 22, 3:22 AM

	Unknown Object (File)
	Nov 17 2024, 5:52 AM

	Unknown Object (File)
	Nov 17 2024, 5:13 AM

	Unknown Object (File)
	Nov 17 2024, 3:11 AM

	Unknown Object (File)
	Oct 18 2024, 3:13 AM

	Unknown Object (File)
	Oct 10 2024, 5:51 PM

View All 66 Files

Subscribers

None

Details

Reviewers

khng
markj

Group Reviewers

Commits

rG0ef5eee9d941: Add vn_lktype_write()

Summary

and remove repetetive code that calculates vnode locking type for write.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 4 2021, 2:38 AM

Herald added a reviewer: cam. · View Herald TranscriptAug 4 2021, 2:38 AM

kib requested review of this revision.Aug 4 2021, 2:38 AM

khng accepted this revision.Aug 4 2021, 2:50 AM

This revision is now accepted and ready to land.Aug 4 2021, 2:50 AM

khng mentioned this in D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Aug 4 2021, 2:54 AM

khng added a child revision: D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Aug 4 2021, 3:11 AM

markj added inline comments.Aug 4 2021, 3:31 AM

sys/kern/vfs_vnops.c
3091	When is it possible for vn_start_write() to return `mp = NULL`? Clearly it will happen if the vnode is doomed. Are there other cases? If so, is it possible to have `mp == NULL && outvp->v_mount != NULL`?

kib added inline comments.Aug 4 2021, 9:02 AM

sys/kern/vfs_vnops.c
3091	Official case is for VOP_GETWRITEMOUNT() to return EOPNOTSUPP. In this case vn_start_write() succeeds and sets mp to NULL, regardless of the reclamation status of the vnode. This was designed as a simple opt-out for filesystems that do need support write suspension and do not want to pay for the overhead of maintaining the mnt_writeopcount. Until we have such support, we should accept a possibility that mp == NULL but vp->v_mount != NULL.

markj accepted this revision.Aug 4 2021, 12:29 PM

Closed by commit rG0ef5eee9d941: Add vn_lktype_write() (authored by kib). · Explain WhyAug 4 2021, 5:17 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG0ef5eee9d941: Add vn_lktype_write().

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl_backend_block.c

20 lines

kern/

10 lines

34 lines

sys/

1 line

vm/

6 lines

Diff 93229

sys/cam/ctl/ctl_backend_block.c

Loading...

sys/kern/vfs_syscalls.c

Loading...

sys/kern/vfs_vnops.c

Loading...

sys/sys/vnode.h

Loading...

sys/vm/vm_pageout.c

Loading...