Page MenuHomeFreeBSD
Differential D28834

Wire up OpenZFS with VOP_DEALLOCATE(9)
AbandonedPublic
Actions

Authored by khng on Feb 21 2021, 8:38 AM.

Details

Reviewers
markj
allanjude
Summary

Wire up OpenZFS with VOP_DEALLOCATE(9)

This will go to upstream actually. However a differential is created for
easier tools/tools/git/git-arc.sh workflow.

Submitted by: Ka Ho Ng <khng@freebsdfoundation.org>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 40758
Build 37647: arc lint + arc unit

Event Timeline

khng created this revision.Feb 21 2021, 8:38 AM
Herald added subscribers: Contributor Reviews (base), delphij, imp. · View Herald TranscriptFeb 21 2021, 8:38 AM
khng requested review of this revision.Feb 21 2021, 8:38 AM
Harbormaster completed remote builds in B37238: Diff 84384.Feb 21 2021, 8:38 AM
khng added a parent revision: D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Feb 21 2021, 8:39 AM
khng updated this revision to Diff 84402.Feb 21 2021, 2:34 PM

Rebased

Harbormaster completed remote builds in B37245: Diff 84402.Feb 21 2021, 2:34 PM
khng updated this revision to Diff 84405.Feb 21 2021, 2:43 PM

Rebased on top of the newest D27194.

Harbormaster completed remote builds in B37248: Diff 84405.Feb 21 2021, 2:43 PM
khng added reviewers: markj, allanjude.Feb 21 2021, 2:46 PM
khng edited the summary of this revision. (Show Details)
khng updated this revision to Diff 84731.Feb 26 2021, 8:12 AM

Rebased.

Harbormaster completed remote builds in B37396: Diff 84731.Feb 26 2021, 8:13 AM
allanjude added inline comments.Mar 4 2021, 4:22 PM
sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c
3845

Does this comment need updating to instead say what FreeBSD does in this case?

khng added inline comments.Mar 4 2021, 4:31 PM
sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c
3845

That seems necessary. I don't recall we have the same limitation like Solaris that VOP can only issued on opened files.

khng updated this revision to Diff 85978.Mar 18 2021, 7:43 PM
khng marked an inline comment as not done.

Removed SPACECTL_F_CANEXPAND support on SPACECTL_DEALLOC

Can't think of any use of it right now.

Harbormaster completed remote builds in B37921: Diff 85978.Mar 18 2021, 7:43 PM
khng updated this revision to Diff 85983.Mar 18 2021, 7:49 PM

Rebased

Harbormaster completed remote builds in B37924: Diff 85983.Mar 18 2021, 7:49 PM
khng updated this revision to Diff 86010.Mar 19 2021, 8:40 AM

Rebased.

Harbormaster completed remote builds in B37941: Diff 86010.Mar 19 2021, 8:40 AM
khng mentioned this in D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Mar 22 2021, 7:32 PM
khng updated this revision to Diff 86183.Mar 23 2021, 10:12 AM

Updated commit message.

Harbormaster completed remote builds in B38006: Diff 86183.Mar 23 2021, 10:12 AM
khng updated this revision to Diff 89271.May 15 2021, 7:25 PM
  • New zfs_deallocate and new DMU api instead of calling into zfs_freesp
Harbormaster completed remote builds in B39209: Diff 89271.May 15 2021, 7:25 PM
khng updated this revision to Diff 92997.Jul 30 2021, 5:13 PM

_PC_FDEALLOC_PRESENT -> _PC_DEALLOC_PRESENT

Harbormaster completed remote builds in B40758: Diff 92997.Jul 30 2021, 5:13 PM
khng abandoned this revision.Aug 10 2021, 12:33 PM

Please refer to https://github.com/openzfs/zfs/pull/12458.

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
include/
sys/
2 lines
module/
os/
freebsd/
zfs/
78 lines
10 lines
zfs/
40 lines

Diff 92997

View Options

sys/contrib/openzfs/include/sys/dmu.h

Loading...
View Options

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c

Loading...
View Options

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_znode.c

Loading...
View Options

sys/contrib/openzfs/module/zfs/dmu.c

Loading...