Page MenuHomeFreeBSD

e1000: Fix lem/em UDP rx csum offload
ClosedPublic

Authored by kbowling on Aug 7 2021, 4:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 8:24 PM
Unknown Object (File)
Tue, Nov 26, 1:12 AM
Unknown Object (File)
Sat, Nov 23, 12:31 PM
Unknown Object (File)
Thu, Nov 21, 2:51 PM
Unknown Object (File)
Wed, Nov 20, 8:30 AM
Unknown Object (File)
Fri, Nov 15, 10:09 AM
Unknown Object (File)
Fri, Nov 15, 8:36 AM
Unknown Object (File)
Mon, Nov 11, 7:05 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling created this revision.
kbowling retitled this revision from e1000: Fix UDP rx checksum offload to e1000: Fix lem/em UDP rx csum offload.Aug 7 2021, 4:38 AM
karels added inline comments.
sys/dev/e1000/em_txrx.c
740

Isn't this test redundant?

kbowling marked an inline comment as done.
kbowling added inline comments.
sys/dev/e1000/em_txrx.c
740

Yes, thanks!

sys/dev/e1000/em_txrx.c
740

fwiw, the comment might have been worth keeping.

sys/dev/e1000/em_txrx.c
740

Yeah, seems like it

kbowling added a subscriber: grehan.
kbowling added inline comments.
sys/dev/e1000/em_txrx.c
740

I'm indifferent to it, I'd want to go add it back to igb and igc if it stays here. @grehan thoughts?

This revision is now accepted and ready to land.Aug 9 2021, 9:22 PM