Page MenuHomeFreeBSD

e1000: Fix lem/em UDP rx csum offload
ClosedPublic

Authored by kbowling on Aug 7 2021, 4:36 AM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling created this revision.
kbowling retitled this revision from e1000: Fix UDP rx checksum offload to e1000: Fix lem/em UDP rx csum offload.Aug 7 2021, 4:38 AM
karels added inline comments.
sys/dev/e1000/em_txrx.c
740

Isn't this test redundant?

kbowling marked an inline comment as done.
kbowling added inline comments.
sys/dev/e1000/em_txrx.c
740

Yes, thanks!

sys/dev/e1000/em_txrx.c
740

fwiw, the comment might have been worth keeping.

sys/dev/e1000/em_txrx.c
740

Yeah, seems like it

kbowling added a subscriber: grehan.
kbowling added inline comments.
sys/dev/e1000/em_txrx.c
740

I'm indifferent to it, I'd want to go add it back to igb and igc if it stays here. @grehan thoughts?

This revision is now accepted and ready to land.Aug 9 2021, 9:22 PM