Page MenuHomeFreeBSD

bhyve: Fix the WITH_BHYVE_SNAPSHOT build
ClosedPublic

Authored by markj on Oct 16 2021, 5:27 PM.
Tags
None
Referenced Files
F137418720: D32523.id96956.diff
Sun, Nov 23, 6:53 AM
Unknown Object (File)
Fri, Nov 21, 11:47 AM
Unknown Object (File)
Mon, Nov 17, 8:06 AM
Unknown Object (File)
Thu, Nov 6, 9:29 PM
Unknown Object (File)
Wed, Nov 5, 3:10 PM
Unknown Object (File)
Mon, Nov 3, 5:21 PM
Unknown Object (File)
Wed, Oct 29, 9:19 AM
Unknown Object (File)
Wed, Oct 29, 9:17 AM
Subscribers

Details

Summary

The pba_page_offset field was removed. It was only used by the
passthrough code, and I believe the snapshot code currently does not
handle passthrough devices, so the field perhaps shouldn't have been
there to begin with.

I believe this change breaks compatibility with snapshots created by a
bhyve that doesn't have this change. I'm not sure what guarantees we
provide there, but if necessary we could write a dummy value instead.

Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable