Page MenuHomeFreeBSD

bhyve: Fix the WITH_BHYVE_SNAPSHOT build
ClosedPublic

Authored by markj on Oct 16 2021, 5:27 PM.
Tags
None
Referenced Files
F169818461: D32523.diff
Wed, Sep 2, 4:02 PM
Unknown Object (File)
Sat, Aug 29, 9:29 AM
Unknown Object (File)
Tue, Aug 25, 9:44 PM
Unknown Object (File)
Wed, Aug 19, 5:26 PM
Unknown Object (File)
Thu, Aug 13, 3:55 PM
Unknown Object (File)
Sat, Aug 8, 6:02 PM
Unknown Object (File)
Sat, Aug 8, 12:27 PM
Unknown Object (File)
Fri, Aug 7, 1:52 AM
Subscribers

Details

Summary

The pba_page_offset field was removed. It was only used by the
passthrough code, and I believe the snapshot code currently does not
handle passthrough devices, so the field perhaps shouldn't have been
there to begin with.

I believe this change breaks compatibility with snapshots created by a
bhyve that doesn't have this change. I'm not sure what guarantees we
provide there, but if necessary we could write a dummy value instead.

Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable