Page MenuHomeFreeBSD

bhyve: Fix the WITH_BHYVE_SNAPSHOT build
ClosedPublic

Authored by markj on Oct 16 2021, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 8, 6:02 PM
Unknown Object (File)
Sat, Aug 8, 12:27 PM
Unknown Object (File)
Fri, Aug 7, 1:52 AM
Unknown Object (File)
Mon, Aug 3, 11:50 AM
Unknown Object (File)
Sun, Aug 2, 4:18 AM
Unknown Object (File)
Fri, Jul 24, 11:58 PM
Unknown Object (File)
Thu, Jul 23, 10:25 PM
Unknown Object (File)
Wed, Jul 22, 8:56 PM
Subscribers

Details

Summary

The pba_page_offset field was removed. It was only used by the
passthrough code, and I believe the snapshot code currently does not
handle passthrough devices, so the field perhaps shouldn't have been
there to begin with.

I believe this change breaks compatibility with snapshots created by a
bhyve that doesn't have this change. I'm not sure what guarantees we
provide there, but if necessary we could write a dummy value instead.

Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable