Page MenuHomeFreeBSD

bhyve: Fix the WITH_BHYVE_SNAPSHOT build
ClosedPublic

Authored by markj on Oct 16 2021, 5:27 PM.
Tags
None
Referenced Files
F173255095: D32523.diff
Thu, Sep 24, 6:06 PM
F173200831: D32523.id97064.diff
Thu, Sep 24, 6:33 AM
F173189287: D32523.diff
Thu, Sep 24, 4:42 AM
Unknown Object (File)
Wed, Sep 23, 1:42 PM
Unknown Object (File)
Sat, Sep 19, 10:28 AM
Unknown Object (File)
Tue, Sep 8, 10:54 PM
Unknown Object (File)
Sun, Sep 6, 10:42 PM
Unknown Object (File)
Sun, Sep 6, 12:35 PM
Subscribers

Details

Summary

The pba_page_offset field was removed. It was only used by the
passthrough code, and I believe the snapshot code currently does not
handle passthrough devices, so the field perhaps shouldn't have been
there to begin with.

I believe this change breaks compatibility with snapshots created by a
bhyve that doesn't have this change. I'm not sure what guarantees we
provide there, but if necessary we could write a dummy value instead.

Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable