bhyve/pci_emul.c: Add handlers for ACPI PCI hotplug metadata
AcceptedPublic
Actions

Authored by bnovkov on Sun, Jan 11, 1:32 PM.

Tags

None

Referenced Files

	F144625810: D54646.diff
	Tue, Feb 10, 9:53 AM

	Unknown Object (File)
	Tue, Feb 3, 4:23 PM

	Unknown Object (File)
	Tue, Feb 3, 4:22 PM

	Unknown Object (File)
	Mon, Feb 2, 7:13 AM

	Unknown Object (File)
	Mon, Jan 26, 11:11 PM

	Unknown Object (File)
	Sat, Jan 24, 9:10 AM

	Unknown Object (File)
	Wed, Jan 21, 7:31 AM

	Unknown Object (File)
	Mon, Jan 19, 12:29 AM

Subscribers

Details

Reviewers

markj

Group Reviewers

bhyve

Summary

This change adds memory access handlers for the per-bus ACPI
PCI hotplugging metadata.

This is a prerequisite for PCI device hotplugging since it allows
the guest to interact with the per-bus hotplug metadata.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bnovkov created this revision.Sun, Jan 11, 1:32 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptSun, Jan 11, 1:32 PM

bnovkov requested review of this revision.Sun, Jan 11, 1:32 PM

Harbormaster completed remote builds in B69795: Diff 169466.Sun, Jan 11, 1:32 PM

bnovkov added a parent revision: D54645: bhyve/pci_emul.c: Emit ACPI methods for hotpluggable slots.Sun, Jan 11, 1:32 PM

bnovkov added a child revision: D54647: bhyve/pci_emul.c: Introduce device teardown routines.

markj added a subscriber: markj.Tue, Feb 3, 4:58 PM

markj added inline comments.

usr.sbin/bhyve/pci_emul.c
3138	You don't want to acquire hp_lock around this read?

Address @markj 's comments.

usr.sbin/bhyve/pci_emul.c
3138	ah, thanks for catching this, fixed.

markj accepted this revision as: markj.Fri, Feb 6, 3:35 PM

This revision is now accepted and ready to land.Fri, Feb 6, 3:35 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_emul.c

151 lines

Diff 171267

View Options

bhyve/pci_emul.c: Add handlers for ACPI PCI hotplug metadataAcceptedPublicActions