Page MenuHomeFreeBSD

bhyvectl: Generalize bhyve IPC code
ClosedPublic

Authored by bnovkov on Jan 11 2026, 1:33 PM.
Tags
None
Referenced Files
F170740173: D54652.id.diff
Sun, Sep 6, 8:33 AM
F170685554: D54652.id169536.diff
Sun, Sep 6, 12:46 AM
F170592903: D54652.id169472.diff
Sat, Sep 5, 1:37 PM
Unknown Object (File)
Fri, Sep 4, 8:50 PM
Unknown Object (File)
Fri, Sep 4, 7:59 PM
Unknown Object (File)
Fri, Sep 4, 6:16 PM
Unknown Object (File)
Fri, Sep 4, 8:38 AM
Unknown Object (File)
Thu, Sep 3, 11:52 AM

Details

Reviewers
None
Group Reviewers
bhyve
Commits
rGf49f33ef8c53: bhyvectl: Generalize bhyve IPC code
Summary

Move the nvlist-based bhyve IPC code into a separate function.
No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

if possible, it might be worth splitting the ipc changes outside of hot pluggable stack

think you can land the ipc changes without the hot plugging bits

usr.sbin/bhyvectl/bhyvectl.c
257–258

if you rename nvl to request and then see my suggestion for lines 278-285

290–305

could use nvlist_xfer() instead of nvlist_send() and nvlist_recv()

declare a nvlist_t *reply and then something like reply = nvlist_xfer(socket_fd, request, 0)

bnovkov marked 2 inline comments as done.

Address @rew 's comments.

usr.sbin/bhyvectl/bhyvectl.c
290–305

Thank you for the suggestion, nvlist_xfer makes things much simpler.

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Aug 23, 12:03 PM
This revision was automatically updated to reflect the committed changes.