Page MenuHomeFreeBSD

bhyvectl: Generalize bhyve IPC code
Needs ReviewPublic

Authored by bnovkov on Sun, Jan 11, 1:33 PM.
Tags
None
Referenced Files
F142079600: D54652.diff
Thu, Jan 15, 8:32 PM
F142038739: D54652.id169536.diff
Thu, Jan 15, 7:23 AM
Unknown Object (File)
Thu, Jan 15, 2:53 AM
Unknown Object (File)
Thu, Jan 15, 1:49 AM
Unknown Object (File)
Tue, Jan 13, 9:00 AM
Unknown Object (File)
Mon, Jan 12, 8:53 AM
Unknown Object (File)
Sun, Jan 11, 10:41 PM
Unknown Object (File)
Sun, Jan 11, 7:42 PM

Details

Reviewers
None
Group Reviewers
bhyve
Summary

Move the nvlist-based bhyve IPC code into a separate function.
No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

if possible, it might be worth splitting the ipc changes outside of hot pluggable stack

think you can land the ipc changes without the hot plugging bits

usr.sbin/bhyvectl/bhyvectl.c
253

if you rename nvl to request and then see my suggestion for lines 278-285

278–293

could use nvlist_xfer() instead of nvlist_send() and nvlist_recv()

declare a nvlist_t *reply and then something like reply = nvlist_xfer(socket_fd, request, 0)

bnovkov marked 2 inline comments as done.

Address @rew 's comments.

usr.sbin/bhyvectl/bhyvectl.c
278–293

Thank you for the suggestion, nvlist_xfer makes things much simpler.