Paths

Table of Contentst

Differential D54643

bhyve: Refactor pci_irq_route
Needs ReviewPublic
Actions

Authored by bnovkov on Sun, Jan 11, 1:32 PM.

Tags

None

Referenced Files

	F144033363: D54643.diff
	Tue, Feb 3, 4:23 PM

	F144033287: D54643.diff
	Tue, Feb 3, 4:22 PM

	Unknown Object (File)
	Fri, Jan 30, 5:01 PM

	Unknown Object (File)
	Fri, Jan 30, 5:01 PM

	Unknown Object (File)
	Mon, Jan 26, 8:08 PM

	Unknown Object (File)
	Sat, Jan 24, 9:10 AM

	Unknown Object (File)
	Tue, Jan 20, 2:31 PM

	Unknown Object (File)
	Tue, Jan 20, 12:20 PM

View All 16 Files

Subscribers

Details

Reviewers

Group Reviewers

Summary

Change pci_irq_route's arguments to a slot number and a pin number
instead of a pointer to an emulated PCI device instance.
This allows us to set up fixed IRQ mappings for slots without device
instances, which is a prerequisite for device hotplugging.
No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69792
Build 66675: arc lint + arc unit

Event Timeline

bnovkov created this revision.Sun, Jan 11, 1:32 PM

Herald added a reviewer: andrew. · View Herald TranscriptSun, Jan 11, 1:32 PM

Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript

bnovkov requested review of this revision.Sun, Jan 11, 1:32 PM

Harbormaster completed remote builds in B69792: Diff 169463.Sun, Jan 11, 1:32 PM

bnovkov added a parent revision: D54642: bhyve/pci_emul.c: Introduce notion of fixed and hotpluggable slots.Sun, Jan 11, 1:32 PM

bnovkov added a child revision: D54644: bhyve/pci_emul.c: Setup fixed PCI irq mappings for hotpluggable slots.

Looks ok aside from the comments.

usr.sbin/bhyve/pci_emul.c
2156	What's the purpose of this change?
usr.sbin/bhyve/pci_irq.c
17	Extra newline

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

1 line

aarch64/

	pci_irq_machdep.c
	pci_irq.c

6 lines

amd64/

2 lines

12 lines

	pci_irq_machdep.c
	pci_irq.c

11 lines

9 lines

4 lines

17 lines

riscv/

	pci_irq_machdep.c
	pci_irq.c

6 lines

Diff 169463

usr.sbin/bhyve/Makefile

Loading...

usr.sbin/bhyve/aarch64/pci_irq.c

Loading...

usr.sbin/bhyve/aarch64/pci_irq_machdep.c

Loading...

usr.sbin/bhyve/amd64/ioapic.h

Loading...

usr.sbin/bhyve/amd64/ioapic.c

Loading...

usr.sbin/bhyve/amd64/pci_irq.c

Loading...

usr.sbin/bhyve/amd64/pci_irq_machdep.c

Loading...

usr.sbin/bhyve/pci_emul.c

Loading...

usr.sbin/bhyve/pci_irq.h

Loading...

usr.sbin/bhyve/pci_irq.c

Loading...

usr.sbin/bhyve/riscv/pci_irq.c

Loading...

usr.sbin/bhyve/riscv/pci_irq_machdep.c

Loading...