Page MenuHomeFreeBSD

bhyve: Refactor pci_irq_route
AcceptedPublic

Authored by bnovkov on Jan 11 2026, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 23, 5:39 AM
Unknown Object (File)
Fri, Feb 20, 9:51 AM
Unknown Object (File)
Thu, Feb 19, 4:25 PM
Unknown Object (File)
Wed, Feb 18, 5:26 PM
Unknown Object (File)
Wed, Feb 18, 5:26 PM
Unknown Object (File)
Tue, Feb 10, 11:45 AM
Unknown Object (File)
Mon, Feb 9, 6:42 PM
Unknown Object (File)
Sat, Feb 7, 12:52 AM

Details

Reviewers
andrew
markj
Group Reviewers
bhyve
Summary

Change pci_irq_route's arguments to a slot number and a pin number
instead of a pointer to an emulated PCI device instance.
This allows us to set up fixed IRQ mappings for slots without device
instances, which is a prerequisite for device hotplugging.
No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looks ok aside from the comments.

usr.sbin/bhyve/pci_emul.c
2152

What's the purpose of this change?

usr.sbin/bhyve/pci_irq.c
18

Extra newline

bnovkov marked 2 inline comments as done.

Address @markj 's comments.

usr.sbin/bhyve/pci_emul.c
2152

Ah, that was a leftover change from a previous version of this patch, removed.

This revision is now accepted and ready to land.Fri, Feb 6, 3:41 PM