Page MenuHomeFreeBSD

bhyve: Refactor pci_irq_route
AcceptedPublic

Authored by bnovkov on Jan 11 2026, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 14, 8:57 AM
Unknown Object (File)
Fri, Sep 11, 3:41 PM
Unknown Object (File)
Tue, Sep 8, 9:54 PM
Unknown Object (File)
Tue, Sep 8, 8:47 AM
Unknown Object (File)
Mon, Sep 7, 12:29 PM
Unknown Object (File)
Sun, Sep 6, 8:57 PM
Unknown Object (File)
Sat, Sep 5, 10:53 AM
Unknown Object (File)
Sat, Sep 5, 7:14 AM

Details

Reviewers
andrew
markj
Group Reviewers
bhyve
Summary

Change pci_irq_route's arguments to a slot number and a pin number
instead of a pointer to an emulated PCI device instance.
This allows us to set up fixed IRQ mappings for slots without device
instances, which is a prerequisite for device hotplugging.
No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looks ok aside from the comments.

usr.sbin/bhyve/pci_emul.c
2152

What's the purpose of this change?

usr.sbin/bhyve/pci_irq.c
18

Extra newline

bnovkov marked 2 inline comments as done.

Address @markj 's comments.

usr.sbin/bhyve/pci_emul.c
2152

Ah, that was a leftover change from a previous version of this patch, removed.

This revision is now accepted and ready to land.Feb 6 2026, 3:41 PM