Paths

Table of Contentst

bhyve/pci_emul.c: Setup fixed PCI irq mappings for hotpluggable slots
Needs ReviewPublic
Actions

Authored by bnovkov on Sun, Jan 11, 1:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 3, 4:23 PM

	Unknown Object (File)
	Tue, Feb 3, 4:22 PM

	Unknown Object (File)
	Tue, Jan 27, 3:24 AM

	Unknown Object (File)
	Thu, Jan 22, 10:43 PM

	Unknown Object (File)
	Wed, Jan 21, 2:05 PM

	Unknown Object (File)
	Sun, Jan 18, 7:10 PM

	Unknown Object (File)
	Fri, Jan 16, 5:43 AM

	Unknown Object (File)
	Wed, Jan 14, 11:45 AM

Subscribers

Details

Reviewers

markj

Group Reviewers

bhyve

Summary

Tweak init_pci to set up irq mappings for all pins in a given
hotpluggable slot.
This makes it possible to emit ACPI interrupt routing entries (PRT)
for hotpluggable slots, which is a prerequisite for ACPI-based
device hotplugging.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bnovkov created this revision.Sun, Jan 11, 1:32 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptSun, Jan 11, 1:32 PM

bnovkov requested review of this revision.Sun, Jan 11, 1:32 PM

Harbormaster completed remote builds in B69793: Diff 169464.Sun, Jan 11, 1:32 PM

bnovkov added a parent revision: D54643: bhyve: Refactor pci_irq_route.Sun, Jan 11, 1:32 PM

bnovkov added a child revision: D54645: bhyve/pci_emul.c: Emit ACPI methods for hotpluggable slots.

markj accepted this revision as: markj.Tue, Feb 3, 4:48 PM

markj added a subscriber: markj.

markj added inline comments.

usr.sbin/bhyve/pci_emul.c
1675	These can be declared in the loop, `for (int pin = 0; pin < 4; ...) { struct intxinfo *ii; ... }`
1687	Indentation is wrong here.

This revision is now accepted and ready to land.Tue, Feb 3, 4:48 PM

Address @markj 's comments.

This revision now requires review to proceed.Thu, Feb 5, 6:02 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_emul.c

26 lines

Diff 171260

View Options

bhyve/pci_emul.c: Setup fixed PCI irq mappings for hotpluggable slotsNeeds ReviewPublicActions