Page MenuHomeFreeBSD

bhyve: Fix the WITH_BHYVE_SNAPSHOT build
ClosedPublic

Authored by markj on Oct 16 2021, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 7:51 PM
Unknown Object (File)
Mon, Nov 25, 1:35 PM
Unknown Object (File)
Sun, Nov 24, 5:06 AM
Unknown Object (File)
Sat, Nov 23, 3:25 AM
Unknown Object (File)
Wed, Nov 20, 11:16 PM
Unknown Object (File)
Tue, Nov 19, 6:13 AM
Unknown Object (File)
Sat, Nov 16, 2:10 AM
Unknown Object (File)
Fri, Nov 15, 12:40 PM
Subscribers

Details

Summary

The pba_page_offset field was removed. It was only used by the
passthrough code, and I believe the snapshot code currently does not
handle passthrough devices, so the field perhaps shouldn't have been
there to begin with.

I believe this change breaks compatibility with snapshots created by a
bhyve that doesn't have this change. I'm not sure what guarantees we
provide there, but if necessary we could write a dummy value instead.

Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable