Page MenuHomeFreeBSD

bhyveUmbrella
ActivePublic

Details

Description

bhyve reviewers group

Recent Activity

Jun 14 2024

geyslan_gmail.com added a watcher for bhyve: geyslan_gmail.com.
Jun 14 2024, 8:54 PM

May 24 2024

yan.jurak_gmail.com removed a watcher for bhyve: yan.jurak_gmail.com.
May 24 2024, 2:01 PM

May 20 2024

yan.jurak_gmail.com added a watcher for bhyve: yan.jurak_gmail.com.
May 20 2024, 10:21 PM

Mar 5 2024

mav added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.

stable/13 has this patch
releng/13.2 doesn't have this patch (yet).

I'm not very familiar with FreeBSD's branching system... I see FreeBSD 13.3-RELEASE was released today, is this bug fix included?

Mar 5 2024, 5:32 PM · bhyve
sean_rogue-research.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.

stable/13 has this patch
releng/13.2 doesn't have this patch (yet).

Mar 5 2024, 1:25 PM · bhyve

Mar 4 2024

himanshu_thechauhan.dev added a watcher for bhyve: himanshu_thechauhan.dev.
Mar 4 2024, 2:56 PM

Feb 20 2024

freebsd_ny-central.org added a comment to D43899: Improvements for Handbook: section virtualization.

Thanks to all of you for moving this along so swiftly! I've already started working on the next iteration. Will post that soon.

Feb 20 2024, 7:28 PM · docs, bhyve
emaste added a comment to D43899: Improvements for Handbook: section virtualization.

Thanks again!

Feb 20 2024, 5:47 PM · docs, bhyve

Feb 17 2024

jrm closed D43899: Improvements for Handbook: section virtualization.
Feb 17 2024, 5:31 PM · docs, bhyve

Feb 16 2024

emaste accepted D43899: Improvements for Handbook: section virtualization.
Feb 16 2024, 11:20 PM · docs, bhyve
rgrimes accepted D43899: Improvements for Handbook: section virtualization.
Feb 16 2024, 10:44 PM · docs, bhyve
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.

Combining Ed's and Rod's feedback on processors: removing controversial paragraph on Intel architecture

Feb 16 2024, 9:38 PM · docs, bhyve
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
Feb 16 2024, 9:34 PM · docs, bhyve
emaste added inline comments to D43899: Improvements for Handbook: section virtualization.
Feb 16 2024, 9:12 PM · docs, bhyve
jrm accepted D43899: Improvements for Handbook: section virtualization.

I asked some doc committers on IRC to have a look.

Feb 16 2024, 8:05 PM · docs, bhyve
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
  • Updated paragraph on CPU architecture to reference Nehalem instead.
  • Added --usage reference for vmstart.sh
  • Fixed disconnect key sequence for cu
Feb 16 2024, 7:31 PM · docs, bhyve
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
Feb 16 2024, 7:11 PM · docs, bhyve
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
Feb 16 2024, 7:03 PM · docs, bhyve
rgrimes accepted D43899: Improvements for Handbook: section virtualization.

Its getting much better, probably with pushing a commit soon.

Feb 16 2024, 6:00 PM · docs, bhyve

Feb 15 2024

freebsd_ny-central.org added a comment to D43899: Improvements for Handbook: section virtualization.

Included the relevant feedback points into this latest update. Thanks for the great inputs. Any further inputs/feedback welcome!

Feb 15 2024, 7:43 PM · docs, bhyve
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.

And finally condensed the processor feature constraints into a simpler and shorter statement.

Feb 15 2024, 7:42 PM · docs, bhyve
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.

Included additional updates after Rod's feedback. Thanks for the inputs!

Feb 15 2024, 7:28 PM · docs, bhyve
emaste added inline comments to D43899: Improvements for Handbook: section virtualization.
Feb 15 2024, 7:17 PM · docs, bhyve
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.

Sorry, just realized I missed the -U99999; included this now.

Feb 15 2024, 7:16 PM · docs, bhyve
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.

Updates after initial feedback - also fixed version of ISO files in the command line listings.

Feb 15 2024, 7:15 PM · docs, bhyve
emaste added a comment to D43899: Improvements for Handbook: section virtualization.

Oh, one other comment - when you regenerate the new patch please use -U999999 to get full context - Phabricator will then allow the reader to expand the blocks in between what's been changed.

Feb 15 2024, 7:08 PM · docs, bhyve
rgrimes requested changes to D43899: Improvements for Handbook: section virtualization.

Just some nits.

Feb 15 2024, 7:07 PM · docs, bhyve
freebsd_ny-central.org planned changes to D43899: Improvements for Handbook: section virtualization.

Thanks for the great feedback. I'll update the patch accordingly.

Feb 15 2024, 6:47 PM · docs, bhyve
emaste added inline comments to D43899: Improvements for Handbook: section virtualization.
Feb 15 2024, 12:22 AM · docs, bhyve

Feb 14 2024

jrm added a reviewer for D43899: Improvements for Handbook: section virtualization: docs.
Feb 14 2024, 11:10 PM · docs, bhyve
jrm added a comment to D43899: Improvements for Handbook: section virtualization.

Thanks. These are nice updates. I added a few mostly nit-picky comments and added a few other reviewers.

Feb 14 2024, 11:10 PM · docs, bhyve
freebsd_ny-central.org requested review of D43899: Improvements for Handbook: section virtualization.
Feb 14 2024, 8:48 PM · docs, bhyve

Feb 6 2024

markj closed D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 6 2024, 3:41 PM · bhyve
markj accepted D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 6 2024, 3:14 PM · bhyve
gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.

Move vm_snapshot_buf_cmp prototype under #ifndef _KERNEL.

Feb 6 2024, 1:59 PM · bhyve
markj added a comment to D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.

Looks good to me, aside from the comment.

Feb 6 2024, 1:44 PM · bhyve
gusev.vitaliy_gmail.com retitled D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT from vmm: Fix compilation with BHYVE_SNAPSHOT to vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 6 2024, 12:10 PM · bhyve
gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.

removed vm_snapshot_buf_cmp() in the kernel code

Feb 6 2024, 11:43 AM · bhyve
gusev.vitaliy_gmail.com added inline comments to D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 6 2024, 11:42 AM · bhyve
gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.

Removed vm_snapshot_buf_cmp() function in the kernel code.

Feb 6 2024, 11:41 AM · bhyve

Feb 5 2024

markj added inline comments to D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 5 2024, 11:53 PM · bhyve
gusev.vitaliy_gmail.com requested review of D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 5 2024, 10:34 PM · bhyve
gusev.vitaliy_gmail.com added a watcher for bhyve: gusev.vitaliy_gmail.com.
Feb 5 2024, 10:17 PM

Dec 29 2023

markj added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
In D43218#985321, @rew wrote:

This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.

I went ahead and took care of these, hopefully you don't mind.

Dec 29 2023, 6:22 PM · bhyve
rew added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.

This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.

Dec 29 2023, 6:20 PM · bhyve
rew closed D43226: vmm: [snapshot] MTRR should be saved/restored.
Dec 29 2023, 6:15 PM · bhyve
rew closed D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
Dec 29 2023, 5:53 PM · bhyve
rew accepted D43226: vmm: [snapshot] MTRR should be saved/restored.
Dec 29 2023, 5:32 PM · bhyve
markj accepted D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.

This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.

Dec 29 2023, 3:44 PM · bhyve
markj accepted D43226: vmm: [snapshot] MTRR should be saved/restored.
Dec 29 2023, 3:16 PM · bhyve