Page MenuHomeFreeBSD

bhyveUmbrella
ActivePublic

Details

Description

bhyve reviewers group

Recent Activity

Yesterday

andy_omniosce.org added a watcher for bhyve: andy_omniosce.org.
Fri, Dec 13, 8:09 PM

Wed, Nov 27

me_mko.io added a watcher for bhyve: me_mko.io.
Wed, Nov 27, 12:00 PM

Nov 7 2019

mike_mikezeller.net added a watcher for bhyve: mike_mikezeller.net.
Nov 7 2019, 5:16 PM

Oct 18 2019

darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.

Add license and copyrights to snapshot specific files (snapshot.[ch], vmm_snapshot[ch]).

Oct 18 2019, 6:49 AM · bhyve

Oct 7 2019

darius.mihaim_gmail.com updated the summary of D19495: bhyve - Snapshot Save and Restore.
Oct 7 2019, 1:24 PM · bhyve
darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.
  • Added compilation flag(s) to use as experimental functionality (BHYVE_SNAPSHOT) thanks to @jhb
  • Rebase with freebsd/freebsd updated master branch, on 4th of October 2019. Refs: git: e96b4170d024f41e9f178394a77006f39aaf6610 SVN: r353039
Oct 7 2019, 1:16 PM · bhyve

Aug 29 2019

jhb closed D20365: simplify bhyve vlapic ESR logic.
Aug 29 2019, 6:23 PM · bhyve

Aug 16 2019

pmooney_pfmooney.com added a comment to D20389: bhyve vioapic writes can deadlock instance.

After discussion with @markj and @jhb, I drafted up a change which involves using an sxlock to guard against racing vioapic writes while allowing the main vioapic mutex to be dropped during the sensitive portion of the TMR update process. I don't have test hardware I can dedicate to running FreeBSD bhyve, so its performance is speculative.

Aug 16 2019, 8:00 PM · bhyve
darkfiberiru_gmail.com added a watcher for bhyve: darkfiberiru_gmail.com.
Aug 16 2019, 2:22 PM

Aug 13 2019

mgrooms_shrew.net added a watcher for bhyve: mgrooms_shrew.net.
Aug 13 2019, 8:48 PM
pmooney_pfmooney.com added a comment to D20389: bhyve vioapic writes can deadlock instance.

Thanks for pointing that out @markj. This wasn't a problem in SmartOS bhyve since all of the mutexes there are adaptive, rather than spinlocks. (Due to interface differences, we couldn't guarantee a lack of voluntary context switching inside the critical_enter/critical_exit section, and spinlocks came with their own host of deadlock problems.) Considering the constraints in play on the FreeBSD side, I'm not sure this possible without serious restructuring. The vioapic lock would need to be sleeping, so the EOI processing would require a full exit from the VMRUN critical section. Other consumers (hpet, etc) would probably require similar treatment.

Aug 13 2019, 8:32 PM · bhyve

Aug 7 2019

markj added inline comments to D20389: bhyve vioapic writes can deadlock instance.
Aug 7 2019, 7:30 PM · bhyve
jhb accepted D20365: simplify bhyve vlapic ESR logic.
Aug 7 2019, 7:15 PM · bhyve
markj accepted D20365: simplify bhyve vlapic ESR logic.
Aug 7 2019, 6:42 PM · bhyve

Aug 1 2019

darius.mihaim_gmail.com added inline comments to D19495: bhyve - Snapshot Save and Restore.
Aug 1 2019, 3:11 PM · bhyve
darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.
  • integrate updated vCPU pause mechanism from @jhb that uses the VM debug components.
  • separate BSP vCPU initialization from other vCPUs (do not initialize all vCPUs before starting the VM when not restoring; do not automatically grant UNRESTRICTED_GUEST capabilities to BSP)
  • fix various coding errors, such as removing unused macros, using proper buffer size for snprintf and coding style
Aug 1 2019, 2:46 PM · bhyve

Jul 30 2019

araujo added a member for bhyve: araujo.
Jul 30 2019, 7:52 AM

Jul 24 2019

pmooney_pfmooney.com added a reviewer for D20365: simplify bhyve vlapic ESR logic: markj.
Jul 24 2019, 3:20 PM · bhyve
pmooney_pfmooney.com added a reviewer for D20389: bhyve vioapic writes can deadlock instance: markj.
Jul 24 2019, 3:19 PM · bhyve

Jul 20 2019

jhb closed D20335: bhyve could be more precise with vPIT.
Jul 20 2019, 3:59 PM · bhyve

Jul 17 2019

pmooney_pfmooney.com added inline comments to D19495: bhyve - Snapshot Save and Restore.
Jul 17 2019, 10:15 PM · bhyve
D20335: bhyve could be more precise with vPIT is now accepted and ready to land.
Jul 17 2019, 8:49 PM · bhyve

Jul 10 2019

darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.
  • kick the guest threads out of vmrun when starting the pausing vCPUs.
  • remove host registers from intel/vmx.c snapshot process (AMD registers have not been removed yet).
Jul 10 2019, 1:47 PM · bhyve

Jul 3 2019

cem added inline comments to D19495: bhyve - Snapshot Save and Restore.
Jul 3 2019, 7:45 AM · bhyve

Jul 2 2019

pmooney_pfmooney.com added inline comments to D19495: bhyve - Snapshot Save and Restore.
Jul 2 2019, 9:22 PM · bhyve

Jun 27 2019

jhb closed D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.
Jun 27 2019, 7:05 PM · bhyve
jhb added a comment to D19495: bhyve - Snapshot Save and Restore.

Even though I wasn't on the call, I agree with Mihai that a project branch isn't a good approach. It's no better than having it in a git branch, and arguably worse as svn merge not as nice as a git rebase for a patch like this.

Jun 27 2019, 5:38 PM · bhyve
darius.mihaim_gmail.com added inline comments to D19495: bhyve - Snapshot Save and Restore.
Jun 27 2019, 12:34 PM · bhyve
darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.

Remove some irrelevant comments and unused functions

Jun 27 2019, 12:32 PM · bhyve

Jun 26 2019

mihai added a comment to D19495: bhyve - Snapshot Save and Restore.

I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.

Please delay the #ifdef guards, as per the discussion in the 2019/06/20 bhyve call we may of found an alternative, using a project branch and rebasing the git to that.

Jun 26 2019, 12:39 PM · bhyve
rgrimes added a comment to D19495: bhyve - Snapshot Save and Restore.

I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.

Jun 26 2019, 11:11 AM · bhyve
darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.

I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.

Jun 26 2019, 10:21 AM · bhyve
darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.
  • rework vCPU pausing and resuming mechanism
  • rewrite VM suspend procedure - do not resume VM and devices before exit
  • add missing break clause in vmm_dev switch-case
  • various minor coding style fixes pointed by @jhb
  • remove unnecessary critical section nesting level check
Jun 26 2019, 9:59 AM · bhyve

Jun 24 2019

pmooney_pfmooney.com added a comment to D20389: bhyve vioapic writes can deadlock instance.

Merged downstream in SmartOS as ec6f18e9

Jun 24 2019, 3:07 PM · bhyve

Jun 20 2019

rgrimes resigned from D20389: bhyve vioapic writes can deadlock instance.
Jun 20 2019, 4:52 PM · bhyve

Jun 18 2019

pmooney_pfmooney.com added a comment to D19495: bhyve - Snapshot Save and Restore.

I agree with @jhb that this absolutely should be placed behind #ifdef guards for now.

Jun 18 2019, 6:09 PM · bhyve
jhb added a comment to D19495: bhyve - Snapshot Save and Restore.

So I think having this be under an optional #ifdef for now is probably best, especially since it doesn't yet work with capsicum. I can add a new WITH_BHYVE_SNAPSHOT src.conf option. I can help with adding the #ifdef or you can do that. You would do something like this in bhyve's Makefile:

Jun 18 2019, 4:19 PM · bhyve
pmooney_pfmooney.com added a comment to D20389: bhyve vioapic writes can deadlock instance.

Rebased to reflect upstream changes

Jun 18 2019, 2:15 PM · bhyve

Jun 10 2019

darius.mihaim_gmail.com updated the summary of D19495: bhyve - Snapshot Save and Restore.
Jun 10 2019, 6:58 PM · bhyve
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
Jun 10 2019, 2:28 PM · bhyve
pmooney_pfmooney.com added a comment to D20365: simplify bhyve vlapic ESR logic.

Merged downstream in SmartOS as aa2898c4.

Jun 10 2019, 2:16 PM · bhyve

Jun 5 2019

darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.

Remove debug printfs from pci_ahci.c

Jun 5 2019, 3:28 PM · bhyve
darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.

Remove vLAPIC fields from snapshot procedure, if they are not required after a restore / can be computed from other fields.
Save vLAPIC's LAPIC page as part of vLAPIC snapshot procedure, instead of a separate data structure.
Rename variables / functions / macros used to snapshot guest to host memory mappings to make them more intuitive.

Jun 5 2019, 12:02 PM · bhyve

Jun 4 2019

rgrimes added a comment to D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.

This is a ping. The pr https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229852 has had another success report. This really should get in tree and in release, what is holding it up?

Jun 4 2019, 4:09 AM · bhyve

Jun 3 2019

jhb closed D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.
Jun 3 2019, 11:17 PM · bhyve

Jun 1 2019

pmooney_pfmooney.com updated the diff for D20365: simplify bhyve vlapic ESR logic.

Eliminate the ILLEGAL_VECTOR qualification in vlapic_set_error per @jhb's feedback and rebase.

Jun 1 2019, 12:10 AM · bhyve

May 24 2019

jhb added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

@jhb, reopening a commited phab review messes with things, as now when you make a second commit the default top patch in this review well be the one you commit, and one has to go digging in the review history to find the prior patch that was in the first commit. It is fine to reopen a review for a revert, but I think one should start a new review for a new change, which is what this is.

May 24 2019, 2:53 PM · bhyve
jojo_eljojo.net added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

thanks everyone with your help here :)

May 24 2019, 4:07 AM · bhyve
rgrimes added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

@jhb, reopening a commited phab review messes with things, as now when you make a second commit the default top patch in this review well be the one you commit, and one has to go digging in the review history to find the prior patch that was in the first commit. It is fine to reopen a review for a revert, but I think one should start a new review for a new change, which is what this is.

May 24 2019, 12:45 AM · bhyve

May 23 2019

jhb added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

José, would you be able to test the updated version that permits read as well as write and verify it still works for your test case? It would be sufficient to just update your local patch to enable reading, no need to rebase on top of what I've committed so far.

May 23 2019, 11:59 PM · bhyve