bhyve reviewers group
Details
Details
Description
Mar 5 2024
Mar 5 2024
mav added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
sean_rogue-research.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
stable/13 has this patch
releng/13.2 doesn't have this patch (yet).
Mar 4 2024
Mar 4 2024
Feb 20 2024
Feb 20 2024
freebsd_ny-central.org added a comment to D43899: Improvements for Handbook: section virtualization.
Thanks to all of you for moving this along so swiftly! I've already started working on the next iteration. Will post that soon.
emaste added a comment to D43899: Improvements for Handbook: section virtualization.
Thanks again!
Feb 17 2024
Feb 17 2024
Feb 16 2024
Feb 16 2024
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
Combining Ed's and Rod's feedback on processors: removing controversial paragraph on Intel architecture
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
emaste added inline comments to D43899: Improvements for Handbook: section virtualization.
I asked some doc committers on IRC to have a look.
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
- Updated paragraph on CPU architecture to reference Nehalem instead.
- Added --usage reference for vmstart.sh
- Fixed disconnect key sequence for cu
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
Its getting much better, probably with pushing a commit soon.
Feb 15 2024
Feb 15 2024
freebsd_ny-central.org added a comment to D43899: Improvements for Handbook: section virtualization.
Included the relevant feedback points into this latest update. Thanks for the great inputs. Any further inputs/feedback welcome!
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
And finally condensed the processor feature constraints into a simpler and shorter statement.
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
Included additional updates after Rod's feedback. Thanks for the inputs!
emaste added inline comments to D43899: Improvements for Handbook: section virtualization.
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
Sorry, just realized I missed the -U99999; included this now.
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
Updates after initial feedback - also fixed version of ISO files in the command line listings.
emaste added a comment to D43899: Improvements for Handbook: section virtualization.
Oh, one other comment - when you regenerate the new patch please use -U999999 to get full context - Phabricator will then allow the reader to expand the blocks in between what's been changed.
rgrimes requested changes to D43899: Improvements for Handbook: section virtualization.
Just some nits.
freebsd_ny-central.org planned changes to D43899: Improvements for Handbook: section virtualization.
Thanks for the great feedback. I'll update the patch accordingly.
emaste added inline comments to D43899: Improvements for Handbook: section virtualization.
Feb 14 2024
Feb 14 2024
jrm added a comment to D43899: Improvements for Handbook: section virtualization.
Thanks. These are nice updates. I added a few mostly nit-picky comments and added a few other reviewers.
freebsd_ny-central.org requested review of D43899: Improvements for Handbook: section virtualization.
Feb 6 2024
Feb 6 2024
gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Move vm_snapshot_buf_cmp prototype under #ifndef _KERNEL.
markj added a comment to D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Looks good to me, aside from the comment.
gusev.vitaliy_gmail.com retitled D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT from vmm: Fix compilation with BHYVE_SNAPSHOT to vmm: Fix compiling error with BHYVE_SNAPSHOT.
gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
removed vm_snapshot_buf_cmp() in the kernel code
gusev.vitaliy_gmail.com added inline comments to D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Removed vm_snapshot_buf_cmp() function in the kernel code.
Feb 5 2024
Feb 5 2024
markj added inline comments to D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
gusev.vitaliy_gmail.com requested review of D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Dec 29 2023
Dec 29 2023
markj added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
rew added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.
Dec 28 2023
Dec 28 2023
gusev.vitaliy_gmail.com updated the summary of D43226: vmm: [snapshot] MTRR should be saved/restored.
gusev.vitaliy_gmail.com requested review of D43226: vmm: [snapshot] MTRR should be saved/restored.