Page MenuHomeFreeBSD

freebsd_ny-central.org (Christ Moerz)
User

Projects

User does not belong to any projects.

User Details

User Since
Wed, Jun 2, 11:01 AM (2 w, 1 d)

Recent Activity

Sat, Jun 12

freebsd_ny-central.org added a comment to D30591: New port: x11-wm/nscde: modern and functional CDE.

Uploading by using "update diff" always leads to creating a completely new revision. There's no option to update the existing one.

Sat, Jun 12, 1:23 PM

Tue, Jun 8

freebsd_ny-central.org added a comment to D30591: New port: x11-wm/nscde: modern and functional CDE.

I'm suggesting to ammend changes to remove obsolete integration options.

Tue, Jun 8, 8:33 AM
freebsd_ny-central.org accepted D30591: New port: x11-wm/nscde: modern and functional CDE.
Tue, Jun 8, 8:25 AM
freebsd_ny-central.org abandoned D30637: New port: x11-wm/nscde: modern and functional CDE (updated).

I'm stupid... there's just no other explanation to how I missed this...

Tue, Jun 8, 8:21 AM

Mon, Jun 7

freebsd_ny-central.org added a reviewer for D30637: New port: x11-wm/nscde: modern and functional CDE (updated): freebsd_ny-central.org.
Mon, Jun 7, 6:10 PM
freebsd_ny-central.org added a comment to D30637: New port: x11-wm/nscde: modern and functional CDE (updated).
Mon, Jun 7, 4:41 PM

Fri, Jun 4

freebsd_ny-central.org retitled D30637: New port: x11-wm/nscde: modern and functional CDE (updated) from Updated after feedback to New port: x11-wm/nscde: modern and functional CDE (updated).
Fri, Jun 4, 3:17 PM
freebsd_ny-central.org added a comment to D30591: New port: x11-wm/nscde: modern and functional CDE.

There are a lot of patches that changes NSCDE_ROOT to our PREFIX (some do more than that)... What I want to ask is, are there a way to use less patches? For instance, just replacing the variable value?
It will save time on future updates.

And watch out using post-patch target and files/* patches together.

The original install script for nscde puts everything under /opt/nscde; the whole package is set up to be crammed into one directory. Unfortunately, that is not very canonical to how the directory structure under /usr/local is supposed to work.

I had hoped to do it the easy way originally and put everything under /usr/local/nscde or /usr/local/libexec/nscde, but then the documentation would have ended up under something like /usr/local/nscde/share/doc.

Symlinking everything out from that structure kind of felt like cheating, so I distributed things into the locations that matched their use and function (i.e. %DATADIR%, %DOCSDIR%, %ETCDIR% and so on).

Originally, there were even more patches. Fortunately, eduardo@ already pointed out that I respect $PREFIX, which led to some simplification but also meant we still have patch files. Actually, it's a combination:

  1. first, we strip those NSCE_ROOT combinations and replace them with $PREFIX and sensible paths
  2. then, from the post-patch phase in Makefile we replace "$PREFIX" strings with actual $PREFIX value

If you have any suggestions on how to improve/simplify this or if we should instead go with the approach of putting everyting into /usr/local/nscde (or similar), I'm certainly willing to give it a try.

Understood and thanks for explanation.
Maybe will be good to ask upstream to help in organizing these structures there (not for now, but on future releases).

And what about the INTEGRATION options, is that really necessary?
If you look other x11-wm ports, you won't see something similar.

Fri, Jun 4, 3:11 PM
freebsd_ny-central.org updated the summary of D30637: New port: x11-wm/nscde: modern and functional CDE (updated).
Fri, Jun 4, 3:09 PM
freebsd_ny-central.org requested review of D30637: New port: x11-wm/nscde: modern and functional CDE (updated).
Fri, Jun 4, 3:07 PM

Thu, Jun 3

freebsd_ny-central.org added a comment to D30591: New port: x11-wm/nscde: modern and functional CDE.

There are a lot of patches that changes NSCDE_ROOT to our PREFIX (some do more than that)... What I want to ask is, are there a way to use less patches? For instance, just replacing the variable value?
It will save time on future updates.

And watch out using post-patch target and files/* patches together.

Thu, Jun 3, 8:06 PM