remove ${LOCALBASE}/include/sys/sysinfo.h:devel/libsysinfo from BUILD_DEPENDS

A commit in branch main references this bug:

update pkg-message to show message upon upgrade from old versions

add vertical whitespace before USES

I've refreshed 'poudriere testport' logs

Update diff to reflect 2 files deleted from files patches dir because they were included upstream.

• use DISTVERSION instead of PORTVERSION
• use USES=localbase instead of CFLAGS and LDFLAGS

While here:

Can't use _MESON_ENABLED for windows option:
"meson.build:1:0: ERROR: Value "x11=disabled" (of type "string") for combo option "window system to use" is not one of the choices. Possible choices are (as string): "all", "wayland", "x11"."

Use _MESON_ENABLED instead of _MESON_ON/OFF

git diff:
git diff -U999999 . > imv.diff

I received a message saying:
"This revision was not accepted when it landed; it landed in state "Needs Review".",
Did I do something wrong?

Maybe a local problem for me then:

% pkgconf --modversion freeimage
%%version%%
% pkgconf --modversion freeimage
%%version%%
% pkgconf --cflags freeimage
-I/usr/local/include

Yeah, that's not right, but check inside a jail with the Interactive mode:

$ sudo poudriere testport -j 14-amd64 -p head -o graphics/freeimage -I
$ sudo jexec 14-amd64-head-n env -i TERM=$TERM /usr/bin/login -fp root
...
root@14-amd64-head:~ # cat /usr/local/libdata/pkgconfig/freeimage.pc
prefix=/usr/local
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: freeimage
Description: Simple C/C++ bitmap graphics library
Version: 3.18.0
Libs: -L${libdir} -lfreeimage
Cflags: -I${includedir}

root@14-amd64-head:~ # exit
$sudo poudriere jail -k -j 14-amd64 -p head

In D29311#660489, @dbaio wrote:

In D29311#660352, @eduardo wrote:

remove prefix="${PREFIX}" from SUB_LIST

Could you please apply this patch and test the following commands?

$ pkgconf --modversion freeimage
$ pkgconf --libs freeimage
$ pkgconf --cflags freeimage

before I do poudriere testport?

$ pkgconf --modversion freeimage
3.18.0

$ pkgconf --libs freeimage
-L/usr/local/lib -lfreeimage

$ pkgconf --cflags freeimage
-I/usr/local/include

remove prefix="${PREFIX}" from SUB_LIST

In D29311#659718, @dbaio wrote:

@eduardo I've seen you have posted all build logs, I imagine this was a good exercise, thanks!

In future you don't need to show all logs (from the consumers) for us, just say if it is ok, test a few of them, that's it.

To proceed here, remove the variable prefix="${PREFIX}" and exec another poudriere testport in graphics/freeimage, update your patch and let us know.

In D29358#657462, @dbaio wrote:

This is my suggestion of course, there are people that like to write the full program changelog here in the commit message...

I prefer to separate the Port changelog from the Program changelog.

In D29311#657467, @dbaio wrote:

This update seems simple, but as there are many ports that depends on it, a good practice is doing tests for consumers as well.

https://www.freshports.org/graphics/freeimage

You can do a poudriere bulk -f /tmp/freeimage-consumers-list.txt for instance.
or check manually a few of them... well, more tests the better.

Let us know about your tests.

• separate PLIST_FILES block from PKGCONFIGDIR with a blank line
• use prefix=%%PREFIX%% in files/freeimage.pc.in

cd ${GO_WRKSRC} && \
              ${SETENV} ${MAKE_ENV} ${GO_ENV} ${GO_CMD} run ${GO_BUILDFLAGS} ./helpers/man/main.go > ${PORTNAME}.1

since version 1.12.3:
[ENHANCEMENT] Install manpage when using make install (#1845)

make makeplist instead of manual editing:

If you start all these lines with 2 spaces, as I did, it will show all block with fixed font and will respect text

In D29311#656328, @garga wrote:

PR line on commit log must contain only PR number instead of full URL. While touching it please add missed newline chars

This issue first appeared when updating graphics/imv to 4.2.0 that changed to meson/pkgconf and it failed building with freeimage (option):
"library 'freeimage' not found.

• build gopass.1 manual file
• refresh poudriere tesport logs

fix "no context" warning

Put comment back that helps others to understand why port have two GH_TUPLE lines.

• add "man" target to GO_BUILDFLAGS so it can make gopass.1 man
• add "completion" target to GO_BUILDFLAGS so it can make bash, fish and zsh completions and remove:

"eduardo abandoned this revision."

Sorry, I don't recommend porting it.

In D29214#654110, @dbaio wrote:

Hi.

I was taking a look and the project is just two scripts, to be honest, I think this is not a good candidate for a port.
https://github.com/nullgemm/gog_tomb_raider_extractor/blob/master/extract.sh

Do you think this will be useful for other users? What are your thoughts?

Looking the Repology I couldn't find an other OS that has a package for it.
https://repology.org/projects/?search=gog_tomb_raider_extractor

Sorry about my commit. Next time I will wait for permission to carry on.

In D29179#653507, @dbaio wrote:

Never follow blindly portlint.

@eduardo before you commit, I want to see the commit message, could you update the summary accordingly?
@tobik helped in the review.

revert "USE_LDCONFIG=y"es because of portlint warning, maybe it doesn,'t understand glfw pkg-plist variables(?).

updated diff