In D30591#706138, @freebsd_ny-central.org wrote:

Hi @dbaio and @garga ,

first of all - thanks for your help in reviewing this new port and I completely understand, that you likely have a ton of other things on your plates. I also know from my own experience, how reviews like these can fall to the wayside once they're no longer actively revisited.

Hence my question - is there anything I can do to support you in completing this review? I'd highly appreciate your feedback!

Thanks
chris

reset maintainer was already done:
https://cgit.freebsd.org/ports/commit/?id=707989ed0f7c83660cfb8213641054207a3de529

added pkg-message to mention the optional dependencies

add nscde to x11-wm/Makefile

remove integration options

Should I abandon this review since maintainer reset was done?

In D30591#691097, @freebsd_ny-central.org wrote:

nscde.diff823 KBDownload

Uploading by using "update diff" always leads to creating a completely new revision. There's no option to update the existing one.

so I've uploaded an updated diff now that includes the suggested changes.

In D30769#692022, @dbaio wrote:

In D30769#691961, @adamw wrote:

Maintainer resets do not require portmgr approval, but I’m happy to give it anyway. When you commit, please reword the approved by line so it doesn’t look like portmgr timed out.

Thanks @adamw
More details here Nuno:
https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-maintainer

and there are other two PR's with a timeout.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255256
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255257
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255258 (this)

all ports can be reset. https://portscout.freebsd.org/smatsui@karashi.org.html
Talk with the submitter, maybe he will want to hold maintainership for all of them.
and ok for me.

bump PORTREVISION

Should I bump PORTREVISION?

use git diff -U999999

In D30637#689530, @freebsd_ny-central.org wrote:

I'm stupid... there's just no other explanation to how I missed this...

In D30637#689203, @freebsd_ny-central.org wrote:

In D30637#689024, @eduardo wrote:

Hello!

To remove a review try this link:

https://stackoverflow.com/questions/42618344/how-to-delete-review-request-on-phabricator

Hi,

thanks for the link; unfortunately, I don't seem to have the option to abandon the revision. Strangely, I also don't have the option to update your original revision. I'm only seeing the option to create a new revision or to update my own (new) revision. Both I obviously don't want to do.

Am I doing something wrong or could I be missing some permissions?

Not sure what to do now?

This here suggests commandeering the revision - I seem to be unable to do that either, though. Admittedly, that's probably a good thing, otherwise just about anybody could take over...
https://secure.phabricator.com/T10584

Just click on "update diff":

1. Browse your diff file and upload it
2. In repository field write "ports" and choose "R11 FreeBSD ports repository
3. click "continue"

4: write a small summary of the changes

To remove a review try this link:

reformat x11-wm/nscde with portfmt