Page MenuHomeFreeBSD

gusev.vitaliy_gmail.com (Vitaliy Gusev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2019, 11:19 AM (236 w, 6 d)

Recent Activity

Feb 6 2024

gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.

Move vm_snapshot_buf_cmp prototype under #ifndef _KERNEL.

Feb 6 2024, 1:59 PM · bhyve
gusev.vitaliy_gmail.com retitled D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT from vmm: Fix compilation with BHYVE_SNAPSHOT to vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 6 2024, 12:10 PM · bhyve
gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.

removed vm_snapshot_buf_cmp() in the kernel code

Feb 6 2024, 11:43 AM · bhyve
gusev.vitaliy_gmail.com added inline comments to D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 6 2024, 11:42 AM · bhyve
gusev.vitaliy_gmail.com updated the diff for D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.

Removed vm_snapshot_buf_cmp() function in the kernel code.

Feb 6 2024, 11:41 AM · bhyve

Feb 5 2024

gusev.vitaliy_gmail.com requested review of D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Feb 5 2024, 10:34 PM · bhyve
gusev.vitaliy_gmail.com added a watcher for bhyve: gusev.vitaliy_gmail.com.
Feb 5 2024, 10:17 PM

Dec 28 2023

gusev.vitaliy_gmail.com updated the summary of D43226: vmm: [snapshot] MTRR should be saved/restored.
Dec 28 2023, 10:00 PM · bhyve
gusev.vitaliy_gmail.com requested review of D43226: vmm: [snapshot] MTRR should be saved/restored.
Dec 28 2023, 9:57 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
Dec 28 2023, 6:44 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
In D43218#985023, @rew wrote:

as a side thought, wondering if FB_SIZE and SNAPSHOT_BUFFER_SIZE should be computed on the fly at some point in the future.

Dec 28 2023, 1:38 PM · bhyve
gusev.vitaliy_gmail.com requested review of D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
Dec 28 2023, 1:01 AM · bhyve
gusev.vitaliy_gmail.com closed D42260: bhyve: [snapshot] Remove init_snapshot() and initialize static vars directly.

rG7de582874eb9d08f3f87d11ed9e2b9ce8306db79

Dec 28 2023, 12:46 AM · bhyve

Dec 5 2023

gusev.vitaliy_gmail.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.

Assuming the bug I see is indeed this bug, I reproduce in all 3 of my linux VMs, running Ubuntu 20.04 LTS and 22.04 LTS, which are all linux kernel 5.x. Looks like there is no LTS Ubuntu with kernel 6.x until upcoming 24.04. But 23.10 uses kernel 6.5, which I could try. Is kernel 6.x expected to fix something?

Dec 5 2023, 11:10 AM · bhyve

Dec 4 2023

gusev.vitaliy_gmail.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.

...
I'm not very familiar with phabricator, so I'm unsure: is this fixed in FreeBSD 13.2 or only 14.0?

Dec 4 2023, 10:36 PM · bhyve

Nov 7 2023

gusev.vitaliy_gmail.com added a comment to D34718: Warm Migration feature for bhyve [Part 2].

That's all. Kernel crashes with panic: general protection fault. Who wants to fix that ?)

I've read through the various open reviews and your suggestions for a new file format on the mailing list. Would a more robust file format fix that? I.e. adding a checksum or signing the file with a cryptographic hash?

Nov 7 2023, 7:59 PM · bhyve

Oct 17 2023

gusev.vitaliy_gmail.com requested review of D42260: bhyve: [snapshot] Remove init_snapshot() and initialize static vars directly.
Oct 17 2023, 2:56 PM · bhyve

Jun 29 2023

gusev.vitaliy_gmail.com requested review of D40804: bhyvectl: Add '--get-debug-cpus' command.
Jun 29 2023, 9:58 PM · bhyve

Jun 22 2023

gusev.vitaliy_gmail.com added a comment to D34718: Warm Migration feature for bhyve [Part 2].

I suppose that fixing existing issues and make the code stable is more important for now.

Jun 22 2023, 6:36 PM · bhyve

Jun 21 2023

gusev.vitaliy_gmail.com added a comment to D34718: Warm Migration feature for bhyve [Part 2].

Do you already have a migration feature/tool implemented (bmigrate)? If so, please let us know if you plan to make it available in the future.

Jun 21 2023, 8:28 AM · bhyve

Jun 20 2023

gusev.vitaliy_gmail.com added a comment to D34718: Warm Migration feature for bhyve [Part 2].

So instead of having a lot code in bhyve, I would suggest to have portion of primitives that can help to implement warm, live migration outside of bhyve process.

Wait. You're casually suggesting that years of work be discarded in favor of an alternate approach. Please be more specific about what you perceive to be the problem with the method taken in this patch series. "I have another idea" isn't a very good reason to go in a completely different direction.

Jun 20 2023, 11:27 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D34718: Warm Migration feature for bhyve [Part 2].

We consider that the migration part is a must-have feature for a mature hypervisor and we really want to have it for bhyve. The end goal is to have a live migration feature for bhyve. It means inspecting the guest memory pages to check for changes between rounds. It also modifies a dirty bit. The inspection (and changes) should be done from within the bhyve process. I'm not sure how this part should be tackled in your suggestion. However, please keep in mind that this approach was discussed with the bhyve's maintainers 4 years ago. We asked for advice and came up with this idea of having a custom dirty bit for migration.

Jun 20 2023, 7:20 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D34718: Warm Migration feature for bhyve [Part 2].

The *live* migration must be part of bhyve, as the migration process must transfer the virtual machine's memory from one host to the other while the virtual machine runs on the original host.

Of course, some changes to the migration code are unavoidable in case the snapshot process changes in some particular ways, but they should remain minimal in my expectations.

Jun 20 2023, 5:51 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D34718: Warm Migration feature for bhyve [Part 2].

I think we should bring support for snapshots first. And enable BHYVE_SNAPSHOT by default.

To do this, it remains to agree on the snapshot format: https://lists.freebsd.org/archives/freebsd-virtualization/2023-May/001295.html

I'm not sure whether to tie the transfer of the memory dump to the TCP.

Or add an opportunity similar to 'zfs send' to be independent of transport. For example, share a memory image using SSH or NFS.

Not sure how the transfer would be *tied* to the TCP protocol just by having the implementation use TCP by default. Many tools like curl, socat and browsers have figured out that you can use URIs to specify protocols and even authentication when connecting to a service. The migration parameters can be extended to use ssh://, file:/// or even the basic - for piping the binary data to standard output.

I think asking this question more than one year after this review has been open, and more than two after the original review (https://reviews.freebsd.org/D28270) was created is simply meant to delay accepting the changes. I understand that having a good and secure code base is a must, but this change simply asks for "why don't we over engineer this part which has very little to do with the actual virtual machine migration process?", without actually providing a good case for "this is not up to the BSD standards".

Jun 20 2023, 5:19 PM · bhyve
gusev.vitaliy_gmail.com requested changes to D34719: Warm Migration feature for bhyve [Part 3].

The same for this review. Is it really required to place this code into bhyve or it can be added to upper layer, for example to bhyvectl?

Jun 20 2023, 11:42 AM · bhyve
gusev.vitaliy_gmail.com added inline comments to D34718: Warm Migration feature for bhyve [Part 2].
Jun 20 2023, 11:41 AM · bhyve
gusev.vitaliy_gmail.com requested changes to D34718: Warm Migration feature for bhyve [Part 2].

Before proceed this work to commit, could you provide high level design for this approach ?

Jun 20 2023, 11:35 AM · bhyve

Jun 14 2023

gusev.vitaliy_gmail.com added a comment to D40105: bhyve: [snapshot] Simplify restore kernel structs.
In D40105#923164, @jhb wrote:

Can you provide some before/after JSON snippets?

Jun 14 2023, 11:22 PM · bhyve
gusev.vitaliy_gmail.com retitled D40104: bhyve: [snapshot] Rename 'structs' key with 'kern_structs' from bhyve: [snapshot] Rename 'struct's key with 'kern_structs' to bhyve: [snapshot] Rename 'structs' key with 'kern_structs'.
Jun 14 2023, 12:05 AM · bhyve
gusev.vitaliy_gmail.com retitled D40104: bhyve: [snapshot] Rename 'structs' key with 'kern_structs' from bhyve: [snapshot] Rename 'struct' key with 'kern_struct' to bhyve: [snapshot] Rename 'struct's key with 'kern_structs'.
Jun 14 2023, 12:01 AM · bhyve

Jun 7 2023

gusev.vitaliy_gmail.com updated the summary of D40105: bhyve: [snapshot] Simplify restore kernel structs.
Jun 7 2023, 8:09 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D40106: bhyve: [snapshot] Rename 'user_dev' with 'devices'.
Jun 7 2023, 8:08 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D40107: bhyve: pci_devinst.pi_name should contain bus, slot, func.
Jun 7 2023, 8:07 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D40105: bhyve: [snapshot] Simplify restore kernel structs.
Jun 7 2023, 8:05 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D40105: bhyve: [snapshot] Simplify restore kernel structs.
In D40105#921197, @jhb wrote:

Can you provide more description of what this change is doing? From what I can tell it uses err directly to abort quicker if it fails to restore an in-kernel structure, it inlines vm_restore_kern_struct into the loop in vm_restore_kern_structs. It renames vm_snapshot_kern_structs which is somewhat gratuitous IMO as it now no longer matches the other function names like vm_snapshot_user_devs. But I think the big change is not using lookup_struct and instead using meta->dev_name instead of meta->dev_req as the main key for the JSON for a given kernel struct? I think this means you can avoid lookup_struct because now instead of a flat array of all kernel structures they are separate objects with unique names? Can you expand on that more perhaps maybe with some examples of before/after JSON snippets? I would also suggest perhaps only doing the JSON change in this commit and not mixing in the other changes that I think obscure the real change you are making (e.g. the function rename, or inlining the function).

Jun 7 2023, 8:04 PM · bhyve

May 17 2023

gusev.vitaliy_gmail.com added inline comments to D40107: bhyve: pci_devinst.pi_name should contain bus, slot, func.
May 17 2023, 6:14 PM · bhyve
gusev.vitaliy_gmail.com added inline comments to D40107: bhyve: pci_devinst.pi_name should contain bus, slot, func.
May 17 2023, 5:11 PM · bhyve
gusev.vitaliy_gmail.com updated the diff for D40105: bhyve: [snapshot] Simplify restore kernel structs.

Fixed note from @corvink

May 17 2023, 5:03 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D40108: bhyve: [snapshot] Add .pe_snapshot method for PCI 'hostbridge'.

Why don't we call pci_snapshot_pci_dev unconditionally even if pe_snapshot is NULL?

May 17 2023, 4:37 PM · bhyve
gusev.vitaliy_gmail.com added inline comments to D40107: bhyve: pci_devinst.pi_name should contain bus, slot, func.
May 17 2023, 4:32 PM · bhyve

May 16 2023

gusev.vitaliy_gmail.com added a comment to D40109: bhyve: [snapshot] Use pci_next() to save/restore pci devices.

@rew Could you look again ?

May 16 2023, 4:25 PM · bhyve

May 15 2023

gusev.vitaliy_gmail.com updated the diff for D40109: bhyve: [snapshot] Use pci_next() to save/restore pci devices.

Fixed notes from @rew.

May 15 2023, 7:17 PM · bhyve
gusev.vitaliy_gmail.com added inline comments to D40109: bhyve: [snapshot] Use pci_next() to save/restore pci devices.
May 15 2023, 7:12 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D40108: bhyve: [snapshot] Add .pe_snapshot method for PCI 'hostbridge'.
In D40108#913423, @rew wrote:

not sure that devices should define a snapshot handler when not supported by the device.

At least it saves pdi.pi_cfgdata.

May 15 2023, 5:57 PM · bhyve
gusev.vitaliy_gmail.com abandoned D35454: bhyve: snapshot capsicum support.

Close as whole patch series D38886 is committed.

May 15 2023, 5:54 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D40108: bhyve: [snapshot] Add .pe_snapshot method for PCI 'hostbridge'.
In D40108#913423, @rew wrote:

not sure that devices should define a snapshot handler when not supported by the device.

May 15 2023, 5:52 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.

@corvink I've split this patch with several patches. Note, according to @rew comments about adding and usage "register_snapshot_dev", I replaced that code with pci_next() function to walk all available PCI devices and save/restore them. 'atkbdc` device is saved/restored separately in this case.

May 15 2023, 2:33 PM · bhyve
gusev.vitaliy_gmail.com updated the test plan for D40107: bhyve: pci_devinst.pi_name should contain bus, slot, func.
May 15 2023, 2:09 PM · bhyve
gusev.vitaliy_gmail.com requested review of D40109: bhyve: [snapshot] Use pci_next() to save/restore pci devices.
May 15 2023, 2:08 PM · bhyve
gusev.vitaliy_gmail.com requested review of D40108: bhyve: [snapshot] Add .pe_snapshot method for PCI 'hostbridge'.
May 15 2023, 2:03 PM · bhyve
gusev.vitaliy_gmail.com updated the test plan for D40107: bhyve: pci_devinst.pi_name should contain bus, slot, func.
May 15 2023, 1:59 PM · bhyve
gusev.vitaliy_gmail.com requested review of D40107: bhyve: pci_devinst.pi_name should contain bus, slot, func.
May 15 2023, 1:57 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D40104: bhyve: [snapshot] Rename 'structs' key with 'kern_structs'.
May 15 2023, 1:55 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D40105: bhyve: [snapshot] Simplify restore kernel structs.
May 15 2023, 1:55 PM · bhyve
gusev.vitaliy_gmail.com requested review of D40106: bhyve: [snapshot] Rename 'user_dev' with 'devices'.
May 15 2023, 1:54 PM · bhyve
gusev.vitaliy_gmail.com requested review of D40105: bhyve: [snapshot] Simplify restore kernel structs.
May 15 2023, 1:50 PM · bhyve
gusev.vitaliy_gmail.com requested review of D40104: bhyve: [snapshot] Rename 'structs' key with 'kern_structs'.
May 15 2023, 1:48 PM · bhyve

May 10 2023

gusev.vitaliy_gmail.com added inline comments to D39949: bhyve: Fix vCPU single-stepping on VMX .
May 10 2023, 2:22 PM

May 8 2023

gusev.vitaliy_gmail.com added a comment to D35447: vmm: save/restore pir_desc is required for posted-interrupts and VID.

Patch looks good but it doesn't apply any more. Could you send an updated version please?

May 8 2023, 12:05 PM · bhyve
gusev.vitaliy_gmail.com updated the diff for D35447: vmm: save/restore pir_desc is required for posted-interrupts and VID.

Rebased on main.

May 8 2023, 12:05 PM · bhyve

May 5 2023

gusev.vitaliy_gmail.com added a comment to D35447: vmm: save/restore pir_desc is required for posted-interrupts and VID.

@corvink Could you look at this ? While Patrick's changes requires (in comment) a lot of modifying generic code, this simple fix could solve issue related for suspend/resume.

May 5 2023, 4:59 PM · bhyve
gusev.vitaliy_gmail.com added a reviewer for D35447: vmm: save/restore pir_desc is required for posted-interrupts and VID: corvink.
May 5 2023, 4:57 PM · bhyve

May 2 2023

gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.

@gusev.vitaliy_gmail.com As said, please split this commit. You can also send me a link to a personal git repo where I can pull the changes from.

May 2 2023, 4:07 PM · bhyve

Apr 25 2023

gusev.vitaliy_gmail.com added a comment to D38858: bhyve: Use directory `fd` with checkpoint.

@corvink Can it be committed or I should improve/correct it ?

Apr 25 2023, 12:30 PM · bhyve

Apr 24 2023

gusev.vitaliy_gmail.com updated the diff for D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.

Correct mention of SDM : Section 29.2.1 --> Section 30.2.1

Apr 24 2023, 4:32 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.

What exactly is the problematic scenario? How do we end up with a pending, undelivered interrupt after a vmexit? Presumably the guest must have enabled interrupts before executing HLT.

The change itself seems reasonable to me, but I'd like to understand it better.

Apr 24 2023, 4:24 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.

up?

Apr 24 2023, 1:02 PM · bhyve

Apr 19 2023

gusev.vitaliy_gmail.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.

@jhb @markj Could you look at it? This fix potentially could be added to 13.2 .

Apr 19 2023, 6:58 PM · bhyve

Apr 18 2023

gusev.vitaliy_gmail.com updated the test plan for D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
Apr 18 2023, 7:44 PM · bhyve

Apr 17 2023

gusev.vitaliy_gmail.com requested review of D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
Apr 17 2023, 5:19 PM · bhyve

Mar 27 2023

gusev.vitaliy_gmail.com added inline comments to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.
Mar 27 2023, 11:32 AM · bhyve

Mar 14 2023

gusev.vitaliy_gmail.com updated the summary of D39038: vmm: IPI statistic is missed after ee98f99d7a68b "vmm: Convert VM_MAXCPU into ...".
Mar 14 2023, 11:31 AM · bhyve

Mar 13 2023

gusev.vitaliy_gmail.com added inline comments to D39038: vmm: IPI statistic is missed after ee98f99d7a68b "vmm: Convert VM_MAXCPU into ...".
Mar 13 2023, 4:25 PM · bhyve
gusev.vitaliy_gmail.com added a reviewer for D39038: vmm: IPI statistic is missed after ee98f99d7a68b "vmm: Convert VM_MAXCPU into ...": pmooney_pfmooney.com.
Mar 13 2023, 12:30 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D39038: vmm: IPI statistic is missed after ee98f99d7a68b "vmm: Convert VM_MAXCPU into ...".
Mar 13 2023, 12:19 PM · bhyve
gusev.vitaliy_gmail.com requested review of D39038: vmm: IPI statistic is missed after ee98f99d7a68b "vmm: Convert VM_MAXCPU into ...".
Mar 13 2023, 8:48 AM · bhyve

Mar 10 2023

gusev.vitaliy_gmail.com added a comment to D38858: bhyve: Use directory `fd` with checkpoint.

@rew @emaste Can we go further with this review ? Note, that some of code will be re-written in "one file per snapshot" review. However it will be later, because format of image file requires discussion.

Mar 10 2023, 9:07 AM · bhyve
gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.
In D35590#887928, @rew wrote:

That will work, but this is not easier than current review's approach.

This counter-argument lacks any technical substance.

Mar 10 2023, 9:01 AM · bhyve

Mar 9 2023

gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.

@rew Of course if assume that only PCI and Keyboard devices are used, introducing

Mar 9 2023, 4:49 PM · bhyve
gusev.vitaliy_gmail.com updated the diff for D38860: bhyve: Enable Capsicum for snapshots.

Rebased

Mar 9 2023, 2:52 PM · capsicum, bhyve
gusev.vitaliy_gmail.com added a comment to D38860: bhyve: Enable Capsicum for snapshots.
In D38860#887537, @rew wrote:
In D38860#887381, @rew wrote:

https://reviews.freebsd.org/D38858 also needs to be addressed before this patch is committed.

I've dropped my request for changes in D38858 - there's nothing blocking this review from being landed.

Mar 9 2023, 2:51 PM · capsicum, bhyve
gusev.vitaliy_gmail.com added inline comments to D38858: bhyve: Use directory `fd` with checkpoint.
Mar 9 2023, 2:44 PM · bhyve
gusev.vitaliy_gmail.com updated the diff for D38858: bhyve: Use directory `fd` with checkpoint.

Corrected fd_meta usage in case of error.

Mar 9 2023, 2:43 PM · bhyve
gusev.vitaliy_gmail.com added inline comments to D38858: bhyve: Use directory `fd` with checkpoint.
Mar 9 2023, 1:46 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D35454: bhyve: snapshot capsicum support.

FYI if you use just the D# notation Phabricator will add markup to show which reviews are open/closed e.g.

D38866 libvmm: Add missed ioctl to vm_ioctl_cmds
D38855 bhyve: [snapshot] Do not flush readonly device at blockif_pause()
D38856 bhyve: [snapshot] Add cap limits for ipc socket
D38872 bhyve: Exit with EX_OSERR if init checkpoint or restore time failed
D38857 bhyve: Init checkpoint before caph_enter()
D38858 bhyve: Use directory fd with checkpoint
D38860 bhyve: Enable Capsicum for snapshots

Mar 9 2023, 10:18 AM · bhyve

Mar 8 2023

gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.
In D35590#886738, @rew wrote:

The main idea of this review - introduce struct snapshot_dev and it will be used by the following nvlist changes.

Seems like it'd make more sense to generate this meta information from the in-core configuration at the time the snapshot is taken.

Have you considered this?

Mar 8 2023, 8:19 AM · bhyve

Mar 7 2023

gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.
In D35590#886517, @rew wrote:

I guess you think that I will upstream this changes and forgot about format work. But I am going to create nvlist (including format change) as soon as that review committed.

Before doing the work, I strongly encourage you to write an email to the virtualization mailing list with the proposed file format.

Mar 7 2023, 11:55 AM · bhyve
gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.

Only the file format is controversal. So, if you split this review into smaller ones which are unrelated to the file format change, we can make some progress.

Mar 7 2023, 10:54 AM · bhyve
gusev.vitaliy_gmail.com added a comment to D38905: bhyve: Move libcasper dependecy to lib9p.

@markj Could you re-approve and commit ?

Mar 7 2023, 7:38 AM · bhyve

Mar 6 2023

gusev.vitaliy_gmail.com updated the diff for D38905: bhyve: Move libcasper dependecy to lib9p.

Fixed "_DP_9p= sbuf" indentation.

Mar 6 2023, 4:01 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.
In D35590#885880, @rew wrote:

How is this a stopper for the file format changes?

Mar 6 2023, 2:13 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D38905: bhyve: Move libcasper dependecy to lib9p.

Seems ok. Did you test 9pfs in the guest? I would suggest trying it if so. In particular, we have no other examples where a shared library depends on casper libraries. Up until now, it is always executables which depend on casper libraries. So there might be some subtle problem or interaction.

Mar 6 2023, 1:15 PM · bhyve

Mar 4 2023

gusev.vitaliy_gmail.com updated the test plan for D38905: bhyve: Move libcasper dependecy to lib9p.
Mar 4 2023, 12:18 PM · bhyve
gusev.vitaliy_gmail.com requested review of D38905: bhyve: Move libcasper dependecy to lib9p.
Mar 4 2023, 11:07 AM · bhyve
gusev.vitaliy_gmail.com updated the summary of D35590: bhyve: multiple devices support for suspend/checkpoint/resume.
Mar 4 2023, 10:32 AM · bhyve
gusev.vitaliy_gmail.com added a comment to D35590: bhyve: multiple devices support for suspend/checkpoint/resume.

@rew This is stopper for following up nvlist changes. Please review and possibly approve. Thanks.

Mar 4 2023, 10:06 AM · bhyve
gusev.vitaliy_gmail.com edited reviewers for D35590: bhyve: multiple devices support for suspend/checkpoint/resume, added: corvink; removed: bhyve.
Mar 4 2023, 10:03 AM · bhyve

Mar 3 2023

gusev.vitaliy_gmail.com added a comment to D38858: bhyve: Use directory `fd` with checkpoint.
In D38858#885643, @rew wrote:

Why do you think single format work (nvlist) should be *before* enabling Capsicum? nvlist work will have a lot of changes and we can stuck if discussing any useful thing eats a lot of time and risk is not to move forward for the months. Just note, multiple device review is 7-8 months old. It is crazy for the code that is under #ifdef BHYVE_SNAPSHOT. We need speedup this work. For now it is about 2 years when Snapshot/Resume was added and there no significant progress.

If you have questions or notes about the code, please write here. Otherwise please accept the reviews.

The only file descriptor that needs to be passed to bhyve is the snapshot file that is being written to, which won't require opening a file descriptor to a directory.

Rebase this review after the file format work has been merged into main.

Thanks.

Mar 3 2023, 11:36 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D38858: bhyve: Use directory `fd` with checkpoint.
In D38858#885635, @rew wrote:

nvlist implementation will use single file for all:

  • config
  • vram
  • kernel data
  • devices data

So you are right, using multiple files is not reasonable and is hard to operate.

In which case, the file descriptor change needs to happen after bhyve starts using a single file for snapshots.

Mar 3 2023, 10:51 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D38858: bhyve: Use directory `fd` with checkpoint.
In D38858#885604, @rew wrote:

..

see the original commit message that brought the snapshot code in

The file format also does not currently support
    versioning of individual chunks of state.  As a result, the current
    file format is not a fixed binary format and future revisions to save
    and restore will break binary compatiblity of snapshot files.  The
    goal is to move to a more flexible format that adds versioning,
    etc. and at that point to commit to providing a reasonable level of
    compatibility.

If I understand right, all things could be achieved with nvlist implementation. Thanks.

Why does there need to be multiple files for a single snapshot?

Mar 3 2023, 9:57 PM · bhyve