Page MenuHomeFreeBSD

bryanv (Bryan Venteicher)
User

Projects

User Details

User Since
May 10 2014, 3:30 AM (355 w, 6 d)

Recent Activity

Tue, Feb 23

bryanv accepted D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Tue, Feb 23, 1:55 PM
bryanv added inline comments to D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Tue, Feb 23, 5:04 AM
bryanv requested changes to D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Tue, Feb 23, 5:04 AM
bryanv abandoned D27918: if_vtnet: Use separate variable to keep track of returned negotiated features.
Tue, Feb 23, 4:17 AM
bryanv abandoned D27927: if_vtnet: Moderneize default tunables.
Tue, Feb 23, 4:16 AM
bryanv accepted D28818: virtio_pci_legacy: Allow memory space for configuration.
Tue, Feb 23, 3:59 AM

Feb 1 2021

bryanv added a comment to D26915: virtio_pci: Allow memory space for configuration.

I'll try to get this ported and committed to the legacy PCI driver before 13.0

Feb 1 2021, 4:33 PM

Jan 21 2021

bryanv added inline comments to D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 21 2021, 3:02 AM
bryanv added inline comments to D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 21 2021, 2:05 AM
bryanv added a comment to D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.

I'd like to keep the current distinction - virito_pci and virtio_mmio - so it is clear as to what is being attached. After https://reviews.freebsd.org/D28073 there is much less boilerplate, and not likely another transport is forthcoming.

Jan 21 2021, 1:44 AM
bryanv added inline comments to D27857: Add VirtIO modern support to virtqueue.
Jan 21 2021, 1:41 AM

Jan 20 2021

bryanv abandoned D27914: if_vtnet: move IFFLAGS ioctl handler to separate function.

Committed in dc9029d863dcc48efebb6a31a25553a7459132aa

Jan 20 2021, 10:56 PM
bryanv abandoned D27915: if_vtnet: Move remaining ioctl handlers to separate functions.

Folded into https://reviews.freebsd.org/D27915

Jan 20 2021, 10:55 PM
bryanv abandoned D27924: if_vtnet: Improve support for software LRO.

Folded into https://reviews.freebsd.org/D27919

Jan 20 2021, 10:54 PM
bryanv abandoned D27929: virtio: Add drivers as children of modern PCI.
Jan 20 2021, 10:53 PM

Jan 19 2021

bryanv accepted D28073: virtio: Reduce boilerplate for device driver module definitions.
Jan 19 2021, 5:30 AM
bryanv accepted D28058: Build VirtIO modules on all architectures.
Jan 19 2021, 5:27 AM
bryanv accepted D28070: virtio_mmio: Fix V1 device probing spec conformance (section 4.2.3.1.1).
Jan 19 2021, 5:25 AM
bryanv committed R10:e6cc42f181ce: virtio: Handle possible failure of virtio_finalize_features() (authored by bryanv).
virtio: Handle possible failure of virtio_finalize_features()
Jan 19 2021, 5:13 AM
bryanv committed R10:2bfab3577452: if_vtnet: Add counter for received host LRO (authored by bryanv).
if_vtnet: Add counter for received host LRO
Jan 19 2021, 5:13 AM
bryanv committed R10:6b53aeed9162: if_vtnet: Set lro_nsegs for host LRO packets (authored by bryanv).
if_vtnet: Set lro_nsegs for host LRO packets
Jan 19 2021, 5:13 AM
bryanv committed R10:475a60aec7e3: if_vtnet: Misc Tx path cleanup (authored by bryanv).
if_vtnet: Misc Tx path cleanup
Jan 19 2021, 5:13 AM
bryanv committed R10:74cd316a09e8: if_vtnet: Resort softc fields (authored by bryanv).
if_vtnet: Resort softc fields
Jan 19 2021, 5:13 AM
bryanv committed R10:33b5433fd74c: if_vtnet: Remove unnecessary TUNABLE_INTs because of CTLFLAG_RDTUN (authored by bryanv).
if_vtnet: Remove unnecessary TUNABLE_INTs because of CTLFLAG_RDTUN
Jan 19 2021, 5:13 AM
bryanv committed R10:4f18e23f8432: if_vtnet: Schedule Rx task if pending items when enabling interrupt (authored by bryanv).
if_vtnet: Schedule Rx task if pending items when enabling interrupt
Jan 19 2021, 5:13 AM
bryanv closed D27930: virtio: Handle possible failure of virtio_finalize_features().
Jan 19 2021, 5:13 AM
bryanv committed R10:c3187190c71f: if_vtnet: Disable F_MTU feature if MTU is invalid (authored by bryanv).
if_vtnet: Disable F_MTU feature if MTU is invalid
Jan 19 2021, 5:13 AM
bryanv closed D27928: if_vtnet: Add counter for recevied host segmentation offloaded.
Jan 19 2021, 5:13 AM
bryanv closed D27926: if_vtnet: Cleanup bits of the Tx path.
Jan 19 2021, 5:12 AM
bryanv closed D27933: if_vtnet: Set lro_nsegs for host LRO packets.
Jan 19 2021, 5:12 AM
bryanv committed R10:bd8809df20be: if_vtnet: Limit allocations of unused virtqueues (authored by bryanv).
if_vtnet: Limit allocations of unused virtqueues
Jan 19 2021, 5:12 AM
bryanv committed R10:b470419ea52a: if_vtnet: Rework 4be723f63 max multiqueue pairs check (authored by bryanv).
if_vtnet: Rework 4be723f63 max multiqueue pairs check
Jan 19 2021, 5:12 AM
bryanv committed R10:42343a631683: if_vtnet: Add support for software LRO (authored by bryanv).
if_vtnet: Add support for software LRO
Jan 19 2021, 5:12 AM
bryanv closed D27925: if_vtnet: Resort softc fields.
Jan 19 2021, 5:12 AM
bryanv closed D27923: if_vtnet: Clean up the tunables definitions.
Jan 19 2021, 5:12 AM
bryanv committed R10:177761e4c467: if_vtnet: Set the interface max TSO values (authored by bryanv).
if_vtnet: Set the interface max TSO values
Jan 19 2021, 5:12 AM
bryanv closed D27922: if_vtnet: Schedule Rx task if pending items when enabling interrupt.
Jan 19 2021, 5:12 AM
bryanv committed R10:e36a6b1b1f39: if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature (authored by bryanv).
if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature
Jan 19 2021, 5:12 AM
bryanv committed R10:dc9029d863dc: if_vtnet: Move ioctl handlers into separate functions (authored by bryanv).
if_vtnet: Move ioctl handlers into separate functions
Jan 19 2021, 5:12 AM
bryanv closed D27931: if_vtnet: Disable F_MTU feature if MTU is invalid.
Jan 19 2021, 5:12 AM
bryanv committed R10:44559b26af14: if_vtnet: Cleanup the reinit process (authored by bryanv).
if_vtnet: Cleanup the reinit process
Jan 19 2021, 5:12 AM
bryanv closed D27921: if_vtnet: Limit allocations of unused virtqueues.
Jan 19 2021, 5:12 AM
bryanv closed D27920: if_vtnet: Rework 4be723f63 max multiqueue pairs check.
Jan 19 2021, 5:12 AM
bryanv committed R10:2520cd382151: if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported (authored by bryanv).
if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported
Jan 19 2021, 5:12 AM
bryanv committed R10:32e0493c9245: if_vtnet: Cleanup the interface setup methods (authored by bryanv).
if_vtnet: Cleanup the interface setup methods
Jan 19 2021, 5:12 AM
bryanv closed D27919: if_vtnet: Initial support for software LRO.
Jan 19 2021, 5:12 AM
bryanv committed R10:baa5234fbec6: if_vtnet: Move the Tx interrupt threshold into the Txq structure (authored by bryanv).
if_vtnet: Move the Tx interrupt threshold into the Txq structure
Jan 19 2021, 5:12 AM
bryanv closed D27917: if_vtnet: Set the interface max TSO values.
Jan 19 2021, 5:12 AM
bryanv closed D27916: if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature.
Jan 19 2021, 5:12 AM
bryanv committed R10:25dbc30ef5c9: if_vtnet: Remove at attach PROMISC handling (authored by bryanv).
if_vtnet: Remove at attach PROMISC handling
Jan 19 2021, 5:12 AM
bryanv committed R10:05041794d06f: if_vtnet: Defer updating generated MAC address until attached (authored by bryanv).
if_vtnet: Defer updating generated MAC address until attached
Jan 19 2021, 5:12 AM
bryanv committed R10:6a73339365cf: if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX (authored by bryanv).
if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX
Jan 19 2021, 5:11 AM
bryanv closed D27932: if_vtnet: Cleanup the reinit process.
Jan 19 2021, 5:11 AM
bryanv committed R10:aabdf5b6e8e8: if_vtnet: Support VIRTIO_NET_F_MTU (authored by bryanv).
if_vtnet: Support VIRTIO_NET_F_MTU
Jan 19 2021, 5:11 AM
bryanv closed D27913: if_vtnet: cleanup the interface setup methods.
Jan 19 2021, 5:11 AM
bryanv closed D27912: if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported.
Jan 19 2021, 5:11 AM
bryanv committed R10:fa7ca1e33241: if_vtnet: Rx path cleanup (authored by bryanv).
if_vtnet: Rx path cleanup
Jan 19 2021, 5:11 AM
bryanv committed R10:149ab110dd5c: virtio_blk: Use DISKFLAG_WRITE_PROTECT for RO disks (authored by bryanv).
virtio_blk: Use DISKFLAG_WRITE_PROTECT for RO disks
Jan 19 2021, 5:11 AM
bryanv closed D27911: if_vntet: Move the Tx interrupt threshold into the Txq structure.
Jan 19 2021, 5:11 AM
bryanv committed R10:5e2208117787: if_vtnet: Add initial modern (V1) support (authored by bryanv).
if_vtnet: Add initial modern (V1) support
Jan 19 2021, 5:11 AM
bryanv closed D27910: if_vtnet: Defer updating generated MAC address until attached.
Jan 19 2021, 5:11 AM
bryanv closed D27909: if_vtnet: Remove attach PROMISC handling.
Jan 19 2021, 5:11 AM
bryanv committed R10:15be49535dce: virtio_scsi: Add modern (V1) support (authored by bryanv).
virtio_scsi: Add modern (V1) support
Jan 19 2021, 5:11 AM
bryanv closed D27908: if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX.
Jan 19 2021, 5:11 AM
bryanv committed R10:d7f979bed092: virtio_blk: Add modern (V1) support (authored by bryanv).
virtio_blk: Add modern (V1) support
Jan 19 2021, 5:11 AM
bryanv closed D27907: if_vtnet: Support VIRTIO_NET_F_MTU.
Jan 19 2021, 5:11 AM
bryanv closed D27906: if_vtnet: improve and cleanup the receive code.
Jan 19 2021, 5:11 AM
bryanv closed D27905: virtio_blk: Use DISKFLAG_WRITE_PROTECT for RO disks.
Jan 19 2021, 5:11 AM
bryanv closed D27904: if_vtnet: Add initial modern (V1) support.
Jan 19 2021, 5:11 AM
bryanv closed D27903: virtio_scsi: Add modern (V1) support.
Jan 19 2021, 5:11 AM
bryanv closed D27902: virtio_blk: Add modern (V1) support.
Jan 19 2021, 5:11 AM
bryanv closed D27901: virtio_console: Add modern (V1) support.
Jan 19 2021, 5:10 AM
bryanv committed R10:edf7c8ddceca: virtio_console: Add modern (V1) support (authored by bryanv).
virtio_console: Add modern (V1) support
Jan 19 2021, 5:10 AM
bryanv closed D27900: virtio_balloon: Add modern (V1) support.
Jan 19 2021, 5:10 AM
bryanv committed R10:f7f9c266e439: virtio_balloon: Add modern (V1) support (authored by bryanv).
virtio_balloon: Add modern (V1) support
Jan 19 2021, 5:10 AM
bryanv closed D27899: virtio_random: Add modern (V1) support.
Jan 19 2021, 5:10 AM
bryanv committed R10:d2536a25cc1d: virtio_random: Add modern (V1) support (authored by bryanv).
virtio_random: Add modern (V1) support
Jan 19 2021, 5:10 AM
bryanv closed D27898: virtio_pci: Add sysctl to show current features.
Jan 19 2021, 5:09 AM
bryanv committed R10:703f17d60f7f: virtio_pci: Add sysctl to show current features (authored by bryanv).
virtio_pci: Add sysctl to show current features
Jan 19 2021, 5:09 AM
bryanv closed D27857: Add VirtIO modern support to virtqueue.
Jan 19 2021, 5:09 AM
bryanv committed R10:fbe0c4f4c7f4: virtio: Add modern (v1) virtqueue support (authored by bryanv).
virtio: Add modern (v1) virtqueue support
Jan 19 2021, 5:09 AM
bryanv closed D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 19 2021, 5:09 AM
bryanv committed R10:9da9560c4dd3: virtio: Add VirtIO PCI modern (V1) support (authored by bryanv).
virtio: Add VirtIO PCI modern (V1) support
Jan 19 2021, 5:09 AM
bryanv closed D27855: Summary: Revert prior VirtIO "V1" network support to simplify upcoming V1 changes.
Jan 19 2021, 5:08 AM
bryanv committed R10:1cd1ed3f5dd5: Revert: virtio: Support non-legacy network device and queue (authored by bryanv).
Revert: virtio: Support non-legacy network device and queue
Jan 19 2021, 5:08 AM

Jan 18 2021

bryanv added inline comments to D27902: virtio_blk: Add modern (V1) support.
Jan 18 2021, 6:37 PM

Jan 8 2021

bryanv added a comment to D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.

<snip>

As a separate thing I would like to update virtio_mmio to return ENXIO when probing instances with no device rather than creating pointless empty device instances as it's not particularly useful (and the AArch64 QEMU virt machine has a particularly large number of MMIO devices available for whatever reason which leads to rather silly device numbers).

I think it is useful that a transport driver has been attached. Also my recollection when I original did it this way for PCI, is that this is needed for if the device (network, block, etc) module is later loaded. In the ensuing decade, devctl has appeared, but for driver development it is nice to just be able to load/unload the module for hack/test/hack.

Oh I didn't mean if a driver wasn't available, I meant if the device ID is 0. If it's non-zero but no driver's available that would still attach ready for if the driver gets loaded later, either automatically by devd or manually by the user.

Jan 8 2021, 6:10 PM
bryanv added a comment to D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.

For reference, this is what an AArch64 QEMU virt machine shows in devinfo when using PCI:

root@:/ # devinfo
nexus0
  acpi0
    cpu0
    uart0
    virtio0
    virtio1
    virtio2
    virtio3
    virtio4
    virtio5
    virtio6
    virtio7
    virtio8
    virtio9
    virtio10
    virtio11
    virtio12
    virtio13
    virtio14
    virtio15
    virtio16
    virtio17
    virtio18
    virtio19
    virtio20
    virtio21
    virtio22
    virtio23
    virtio24
    virtio25
    virtio26
    virtio27
    virtio28
    virtio29
    virtio30
    virtio31
    pcib0
      pci0
        hostb0
        virtio32
          vtblk0
        virtio33
          vtnet0
        virtio34
    pci_link0
    pci_link1
    pci_link2
    pci_link3
    acpi_sysresource0
    acpi_button0
    psci0
    gic0
    generic_timer0
  cryptosoft0
  efirtc0
root@:/ # devinfo -p vtblk0
vtblk0 virtio32 pci0 pcib0 acpi0 nexus0
root@:/ # devinfo -p vtblk0 -v
vtblk0 pnpinfo vendor=0x00001af4 device=0x1001 subvendor=0x1af4 device_type=0x00000002
 virtio32 pnpinfo vendor=0x1af4 device=0x1001 subvendor=0x1af4 subdevice=0x0002 class=0x010000 at slot=1 function=0 dbsf=pci0:0:1:0
 pci0
 pcib0 pnpinfo _HID=PNP0A08 _UID=0 _CID=PNP0A03 at handle=\_SB_.PCI0
 acpi0
 nexus0 pnpinfo nexus

As a separate thing I would like to update virtio_mmio to return ENXIO when probing instances with no device rather than creating pointless empty device instances as it's not particularly useful (and the AArch64 QEMU virt machine has a particularly large number of MMIO devices available for whatever reason which leads to rather silly device numbers).

Jan 8 2021, 5:46 PM
bryanv added a comment to D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.

This would change the device names in places like devinfo, devctl, vmstat, etc, correct?

Of the transport, yes. The leaf device attached to that doesn't include the transport in it regardless. devinfo will still print the hierarchy so vtpci_driver instances have a pcibX above/next to them. The description of the transport device still includes the transport in it.

Jan 8 2021, 5:41 PM
bryanv added a comment to D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.

This would change the device names in places like devinfo, devctl, vmstat, etc, correct? Frankly, I prefer to keep some indication of the transport used in the device name. I have some WIP man pages changes to add a virtio_pci(4) page for modern-specific tunables, and add missing MLINK's to improve discoverability between device and kernel module names.

Jan 8 2021, 5:07 PM
bryanv updated the diff for D27856: virtio: Add VirtIO PCI modern (V1) support.

Update

Jan 8 2021, 4:14 AM

Jan 7 2021

bryanv added inline comments to D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 7 2021, 7:42 AM

Jan 6 2021

bryanv added a reviewer for D27915: if_vtnet: Move remaining ioctl handlers to separate functions: grehan.
Jan 6 2021, 4:48 PM

Jan 2 2021

bryanv published D27932: if_vtnet: Cleanup the reinit process for review.
Jan 2 2021, 10:08 PM
bryanv published D27930: virtio: Handle possible failure of virtio_finalize_features() for review.
Jan 2 2021, 10:07 PM
bryanv published D27929: virtio: Add drivers as children of modern PCI for review.
Jan 2 2021, 10:07 PM
bryanv published D27928: if_vtnet: Add counter for recevied host segmentation offloaded for review.
Jan 2 2021, 10:06 PM
bryanv published D27927: if_vtnet: Moderneize default tunables for review.
Jan 2 2021, 10:06 PM
bryanv published D27926: if_vtnet: Cleanup bits of the Tx path for review.
Jan 2 2021, 10:06 PM
bryanv published D27925: if_vtnet: Resort softc fields for review.
Jan 2 2021, 10:06 PM