Page MenuHomeFreeBSD

bryanv (Bryan Venteicher)
User

Projects

User Details

User Since
May 10 2014, 3:30 AM (253 w, 4 d)

Recent Activity

Thu, Mar 14

bryanv added a member for iflib: bryanv.
Thu, Mar 14, 5:45 PM
bryanv accepted D19573: ether: centralize fake hwaddr generation.
Thu, Mar 14, 3:48 AM

Mon, Feb 18

bryanv accepted D19104: vmxnet3: add native netmap support.
Mon, Feb 18, 6:52 PM

Jan 29 2019

bryanv accepted D19015: vtnet: fix typo in vtnet_free_taskqueues.
Jan 29 2019, 1:34 PM

Nov 14 2018

bryanv accepted D17916: vtnet: fix netmap support.
Nov 14 2018, 2:58 PM

Nov 12 2018

bryanv added inline comments to D17916: vtnet: fix netmap support.
Nov 12 2018, 5:05 PM
bryanv added inline comments to D17916: vtnet: fix netmap support.
Nov 12 2018, 2:20 PM

Nov 11 2018

bryanv added inline comments to D17916: vtnet: fix netmap support.
Nov 11 2018, 8:09 PM

Nov 10 2018

bryanv added inline comments to D17916: vtnet: fix netmap support.
Nov 10 2018, 4:48 PM
bryanv added a comment to D17916: vtnet: fix netmap support.

Can you update this diff with the full context? Thanks.

Nov 10 2018, 4:30 PM

Oct 22 2018

bryanv accepted D16305: Table driven hypervisor detection and addition of VirtualBox..
Oct 22 2018, 7:57 PM

Jul 23 2018

bryanv updated subscribers of D16305: Table driven hypervisor detection and addition of VirtualBox..
Jul 23 2018, 4:27 AM

Jul 19 2018

bryanv added inline comments to D16306: paravirt: Add KVM clock timecounter support.
Jul 19 2018, 3:17 PM
bryanv added inline comments to D16305: Table driven hypervisor detection and addition of VirtualBox..
Jul 19 2018, 1:49 PM

Jul 18 2018

bryanv abandoned D1435: paravirt: Add KVM clock timecounter support.
Jul 18 2018, 3:04 PM
bryanv abandoned D1434: paravirt: Add detection of KVM using new hypervisor interface.
Jul 18 2018, 3:03 PM
bryanv abandoned D1433: paravirt: Add detection of VMware using new hypervisor interface.
Jul 18 2018, 3:03 PM
bryanv abandoned D1432: paravirt: Add detection of bhyve using new hypervisor interface.
Jul 18 2018, 3:03 PM
bryanv abandoned D1431: paravirt: Add simple hypervisor registration and detection interface .
Jul 18 2018, 3:03 PM
bryanv abandoned D1430: paravirt: Add interface to calculate the TSC frequency from pvclock.
Jul 18 2018, 3:02 PM

Jul 9 2018

bryanv updated subscribers of D1435: paravirt: Add KVM clock timecounter support.
In D1435#343209, @mmacy wrote:

@bryanv What do you feel remains to be done?

Jul 9 2018, 3:25 PM

Jun 17 2018

bryanv committed rS335305: Update VirtIO definitions from Linux virtio_config.h and virtio_ring.h headers.
Update VirtIO definitions from Linux virtio_config.h and virtio_ring.h headers
Jun 17 2018, 8:46 PM

Jun 15 2018

bryanv accepted D15821: Reinitialize virtqueues.
Jun 15 2018, 3:29 PM
bryanv added a comment to D15821: Reinitialize virtqueues.

I don't follow why qemu clearing "pointers" means that we realloc the virtqueues in the guest. The host virtqueue state is reinitialized as part of the reinit process. Also, what do you believe has "recently" changed in qemu's virtio_reset? The blame shows very little changes in the last several years.

Jun 15 2018, 1:26 PM

Jun 2 2018

bryanv added inline comments to D15356: in-kernel virtio and VPC (virtual private cloud) stack.
Jun 2 2018, 7:16 PM

May 14 2018

bryanv added a reviewer for D15356: in-kernel virtio and VPC (virtual private cloud) stack: bryanv.
May 14 2018, 3:07 PM

May 4 2018

bryanv accepted D15261: Add netdump hooks for vtnet(4)..
May 4 2018, 7:42 PM

May 3 2018

bryanv added inline comments to D15261: Add netdump hooks for vtnet(4)..
May 3 2018, 4:39 AM

Mar 17 2018

bryanv committed rS331112: MFC r327958, r329601, r329602:.
MFC r327958, r329601, r329602:
Mar 17 2018, 8:37 PM
bryanv committed rS331111: MFC r329598:.
MFC r329598:
Mar 17 2018, 8:20 PM

Feb 19 2018

bryanv committed rS329602: Add more virtqueue getter methods.
Add more virtqueue getter methods
Feb 19 2018, 7:31 PM
bryanv committed rS329601: Add VirtIO bus config_generation method.
Add VirtIO bus config_generation method
Feb 19 2018, 7:28 PM
bryanv committed rS329598: Add PCI methods to iterate over the PCI capabilities.
Add PCI methods to iterate over the PCI capabilities
Feb 19 2018, 6:42 PM
bryanv closed D14325: Add pci_find_next_cap, pci_find_next_extcap, and pci_find_next_htcap.
Feb 19 2018, 6:42 PM

Feb 18 2018

bryanv added inline comments to D14222: Add multiple unicast destinations to vxlan.
Feb 18 2018, 11:01 PM

Feb 13 2018

bryanv updated the diff for D14325: Add pci_find_next_cap, pci_find_next_extcap, and pci_find_next_htcap.
Feb 13 2018, 4:09 PM
bryanv committed rS329217: MFC 328917:.
MFC 328917:
Feb 13 2018, 3:55 PM
bryanv added inline comments to D14325: Add pci_find_next_cap, pci_find_next_extcap, and pci_find_next_htcap.
Feb 13 2018, 2:29 PM

Feb 11 2018

bryanv created D14325: Add pci_find_next_cap, pci_find_next_extcap, and pci_find_next_htcap.
Feb 11 2018, 9:02 PM

Feb 6 2018

bryanv committed rS328917: Correct structure name used in bus_map_resource(9) example.
Correct structure name used in bus_map_resource(9) example
Feb 6 2018, 4:28 AM
bryanv closed D14188: Fix bus_map_resource(9) example.
Feb 6 2018, 4:28 AM

Feb 3 2018

bryanv created D14188: Fix bus_map_resource(9) example.
Feb 3 2018, 8:36 PM

Jan 30 2018

bryanv added a member for bhyve: bryanv.
Jan 30 2018, 4:23 PM

Jan 14 2018

bryanv committed rS327958: Sync VirtIO IDs with Linux.
Sync VirtIO IDs with Linux
Jan 14 2018, 6:04 AM
bryanv committed rS327956: MFC r327448:.
MFC r327448:
Jan 14 2018, 5:07 AM
bryanv committed rS327955: MFC r327438:.
MFC r327438:
Jan 14 2018, 5:05 AM

Jan 13 2018

bryanv committed rS327948: Fix possible panic when creating VirtIO console dev aliases.
Fix possible panic when creating VirtIO console dev aliases
Jan 13 2018, 9:40 PM
bryanv committed rS327927: MFC r327375, r327385, r327386:.
MFC r327375, r327385, r327386:
Jan 13 2018, 5:21 PM

Jan 6 2018

bryanv committed rS327635: MFC r326654:.
MFC r326654:
Jan 6 2018, 8:22 PM

Dec 31 2017

bryanv committed rS327448: Add rc.conf vxlan example.
Add rc.conf vxlan example
Dec 31 2017, 9:23 PM
bryanv committed rS327438: Add VXLAN (RFC 7348) port.
Add VXLAN (RFC 7348) port
Dec 31 2017, 5:11 PM

Dec 30 2017

bryanv committed rS327386: Add macro for vxlan list mutex lock and unlock.
Add macro for vxlan list mutex lock and unlock
Dec 30 2017, 7:50 PM
bryanv committed rS327385: Advertise IFCAP_LINKSTAT after r326480 added link status support.
Advertise IFCAP_LINKSTAT after r326480 added link status support
Dec 30 2017, 7:35 PM
bryanv committed rS327375: Add support for IPv6 scoped addresses to vxlan.
Add support for IPv6 scoped addresses to vxlan
Dec 30 2017, 4:04 AM

Dec 26 2017

bryanv committed rS327217: MFC r326480:.
MFC r326480:
Dec 26 2017, 5:12 PM

Dec 10 2017

bryanv committed rS326751: MFC r326744:.
MFC r326744:
Dec 10 2017, 7:22 PM

Dec 7 2017

bryanv closed D2868: if_vxlan(4) improvements.
Dec 7 2017, 4:56 AM
bryanv committed rS326654: Use consistent name for the vxlan VNI parameter name and provide shorthand.
Use consistent name for the vxlan VNI parameter name and provide shorthand
Dec 7 2017, 4:55 AM

Dec 2 2017

bryanv committed rS326480: Add if media and link status events to vxlan.
Add if media and link status events to vxlan
Dec 2 2017, 10:04 PM

Nov 28 2017

bryanv committed rS326309: Correctly report the vmxnet3 link down media status.
Correctly report the vmxnet3 link down media status
Nov 28 2017, 6:21 AM

Dec 30 2016

bryanv added a comment to D8803: Increasing Virtio driver TX scatter gather segments (VTNET_MIN_TX_SEGS) to support JUMBO MTU frames..

looks good! do you need this committed?

Dec 30 2016, 3:37 PM

Nov 30 2016

bryanv added a comment to D8680: add low level console support to virtio_console driver.

I'm not against this idea, but, yes, when I first wrote virtio_console I didn't implement this because I didn't consider it very useful.

Nov 30 2016, 3:16 PM

Nov 25 2016

bryanv added a comment to D1435: paravirt: Add KVM clock timecounter support.

What's the status of this patch. It looks very promising.
In fact I was writing kvmclock support code myself until I found this one. I think it is much better than the old tsc code.

Nov 25 2016, 10:48 PM

Nov 13 2015

bryanv accepted D4139: Require the number of queues to be a power of 2..
Nov 13 2015, 12:08 AM

Jun 19 2015

bryanv added a comment to D2868: if_vxlan(4) improvements.

First, thanks for this work! I had meant to add VNET support shortly after I committed this, but other stuff got in the way. Just a few initial high level comments:

  • I think using a counter(9) is overkill for those stats.
  • I'd really prefer to not lose the functionality provided by vxlan_ftable_sysctl_dump(). It is a very handy debugging feature, albeit even in its limited state.
Jun 19 2015, 9:33 PM

Jun 14 2015

bryanv committed rS284365: MFC r273331, r273371, r275851:.
MFC r273331, r273371, r275851:
Jun 14 2015, 5:52 AM

Jun 13 2015

bryanv committed rS284347: MFC r271603:.
MFC r271603:
Jun 13 2015, 7:36 PM
bryanv committed rS284344: MFC r277788:.
MFC r277788:
Jun 13 2015, 5:40 PM
bryanv committed rS284342: Fix typo when deregistering the VLAN unconfig event handler.
Fix typo when deregistering the VLAN unconfig event handler
Jun 13 2015, 4:13 PM

Apr 23 2015

bryanv accepted D2348: Don't free mbufs when stopping an interface in netmap mode..
Apr 23 2015, 2:55 PM

Feb 4 2015

bryanv closed D1429: paravirt: Generalize parts of the XEN timer code into pvclock.

Closed by commit rS278183 (authored by @bryanv).

Feb 4 2015, 8:27 AM

Jan 22 2015

bryanv added inline comments to D1431: paravirt: Add simple hypervisor registration and detection interface .
Jan 22 2015, 1:18 AM
bryanv added a comment to D1431: paravirt: Add simple hypervisor registration and detection interface .
In D1431#5, @jhb wrote:

One thing I'm worried about is that it looks like you only set the vendor name if a hypervisor "driver" calls hypervisor_register(), so that means we won't announce any "unknown" hypervisor vendor? Right now we will always pull hv_vendor out of cpuid if the cpuid leaf is valid, even if it is a hypervisor that we don't currently have a driver for. I think we don't want to lose this feature.

Jan 22 2015, 1:17 AM
bryanv added inline comments to D1429: paravirt: Generalize parts of the XEN timer code into pvclock.
Jan 22 2015, 1:13 AM

Jan 9 2015

bryanv added a reviewer for D1432: paravirt: Add detection of bhyve using new hypervisor interface: grehan.
Jan 9 2015, 3:47 PM

Jan 6 2015

bryanv added a reviewer for D1431: paravirt: Add simple hypervisor registration and detection interface : jhb.
Jan 6 2015, 6:31 PM
bryanv added a comment to D1429: paravirt: Generalize parts of the XEN timer code into pvclock.
In D1429#6, @royger wrote:

Thanks for doing this, the change looks fine, but could you wait until Friday so I can test it on Xen before committing it?

Jan 6 2015, 2:33 AM

Jan 4 2015

bryanv updated D1435: paravirt: Add KVM clock timecounter support.
Jan 4 2015, 5:58 AM
bryanv retitled D1429: paravirt: Generalize parts of the XEN timer code into pvclock from Generalized parts of the XEN timer code into pvclock to paravirt: Generalize parts of the XEN timer code into pvclock.
Jan 4 2015, 5:58 AM
bryanv retitled D1435: paravirt: Add KVM clock timecounter support from to paravirt: Add KVM clock timecounter support.
Jan 4 2015, 5:57 AM
bryanv retitled D1434: paravirt: Add detection of KVM using new hypervisor interface from to paravirt: Add detection of KVM using new hypervisor interface.
Jan 4 2015, 5:56 AM
bryanv retitled D1433: paravirt: Add detection of VMware using new hypervisor interface from to paravirt: Add detection of VMware using new hypervisor interface.
Jan 4 2015, 5:56 AM
bryanv retitled D1432: paravirt: Add detection of bhyve using new hypervisor interface from to paravirt: Add detection of bhyve using new hypervisor interface.
Jan 4 2015, 5:55 AM
bryanv retitled D1431: paravirt: Add simple hypervisor registration and detection interface from to paravirt: Add simple hypervisor registration and detection interface .
Jan 4 2015, 5:54 AM
bryanv retitled D1430: paravirt: Add interface to calculate the TSC frequency from pvclock from to paravirt: Add interface to calculate the TSC frequency from pvclock.
Jan 4 2015, 5:51 AM
bryanv set the repository for D1429: paravirt: Generalize parts of the XEN timer code into pvclock to rS FreeBSD src repository.
Jan 4 2015, 5:50 AM

Jan 3 2015

bryanv retitled D1429: paravirt: Generalize parts of the XEN timer code into pvclock from to Generalized parts of the XEN timer code into pvclock.
Jan 3 2015, 11:51 PM

Dec 8 2014

bryanv added a comment to D1240: Update the virtio driver to work on the ARM AArch64 Foundation Model..
In D1240#9, @andrew wrote:

Does anyone have any problems with this change? I would like to push this soon.

Dec 8 2014, 4:50 PM

Nov 12 2014

bryanv added a comment to D1149: ixgbe and igb should check tunables at load time. Also support per-device queue count..
In D1149#9, @alfredperlstein wrote:
In D1149#6, @bryanv wrote:

DragonflyBSD has device_getenv_int() that does something similar - device specific query with fallback to a global value. Maybe it is a good idea to add a similarly named function so it can be available to all drivers?

That would be pretty easy, code is simple:

int
device_getenv_int(device_t dev, const char *knob, int def)
{
        char env[128];

        ksnprintf(env, sizeof(env), "hw.%s.%s", device_get_nameunit(dev), knob);
        kgetenv_int(env, &def);
        return def;
}

Do we want hw.igb0.num_queues or hw.igb.0.num_queues?

I think in FreeBSD we are doing the latter (the unit number is a separate node in the mib). So for us this would be something like:

int
device_getenv_int(device_t dev, const char *knob, int def)
{
        char env[128];

        ksnprintf(env, sizeof(env), "hw.%s.%d.%s", device_get_name(dev), device_get_unit(dev), knob);
        kgetenv_int(env, &def);
        return def;
}

Or is the dfly approach correct?

Nov 12 2014, 5:26 PM
bryanv added inline comments to D1149: ixgbe and igb should check tunables at load time. Also support per-device queue count..
Nov 12 2014, 1:58 PM

Oct 30 2014

bryanv added a comment to D914: Add M_FLOWID to M_COPYFLAGS.
In D914#9, @rpaulo wrote:

What if the packet was encapsulated? Does the flag get copied over to the inner packet? If it does, then that's a bug because the flowid needs to be recalculated.

Oct 30 2014, 4:41 PM

Oct 20 2014

bryanv closed D384: Add vxlan pseudo device.

Closed by commit rS273331 (authored by @bryanv).

Oct 20 2014, 2:42 PM

Oct 10 2014

bryanv closed D383: Improve the UDP tunneling callback.
Oct 10 2014, 6:12 AM

Oct 9 2014

bryanv closed D924: Add missing dtrace UDP multicast receive probes.
Oct 9 2014, 10:36 PM
bryanv retitled D924: Add missing dtrace UDP multicast receive probes from to Add missing dtrace UDP multicast receive probes.
Oct 9 2014, 6:07 AM
bryanv closed D914: Add M_FLOWID to M_COPYFLAGS.
Oct 9 2014, 4:41 AM

Oct 8 2014

bryanv retitled D914: Add M_FLOWID to M_COPYFLAGS from to Add M_FLOWID to M_COPYFLAGS.
Oct 8 2014, 5:02 AM

Sep 15 2014

bryanv closed D382: Add DEF_CLONE_CMD_ARG2 macro to ifconfig.

r271603

Sep 15 2014, 4:02 AM

Jul 10 2014

bryanv added a comment to D384: Add vxlan pseudo device.
In D384#4, @gnn wrote:

I also saw the update and I am fine with it.

In my view of this it seems like there are two space indents which are not consistent with style(9). Is that because this is seen in a web browser or is the indent really incorrect?

Other than the indentation issue the code looks OK to me.

Jul 10 2014, 3:26 PM
bryanv added a comment to D383: Improve the UDP tunneling callback.
In D383#3, @gnn wrote:

Have you run this code with WITNESS to make sure that holding the lock when running through the tunnel does not lead to LOR?

Jul 10 2014, 3:21 PM