Page MenuHomeFreeBSD

bryanv (Bryan Venteicher)
User

Projects

User Details

User Since
May 10 2014, 3:30 AM (437 w, 4 d)

Recent Activity

Aug 17 2022

bryanv committed rG926cedd9a071: virtio_mmio: Improve V1 spec conformance (authored by bryanv).
virtio_mmio: Improve V1 spec conformance
Aug 17 2022, 8:16 PM
bryanv closed D36150: virtio_mmio: Improve V1 spec conformance.
Aug 17 2022, 8:16 PM

Aug 12 2022

bryanv updated the diff for D36150: virtio_mmio: Improve V1 spec conformance.

Address comment

Aug 12 2022, 4:39 PM
bryanv added inline comments to D36150: virtio_mmio: Improve V1 spec conformance.
Aug 12 2022, 4:39 PM
bryanv requested review of D36150: virtio_mmio: Improve V1 spec conformance.
Aug 12 2022, 3:20 AM

Aug 4 2022

bryanv committed rGdc6f578a8f53: virtio_mmio: correct offset of VIRTIO_MMIO_CONFIG_GENERATION (authored by bryanv).
virtio_mmio: correct offset of VIRTIO_MMIO_CONFIG_GENERATION
Aug 4 2022, 4:04 AM

Nov 15 2021

bryanv accepted D32974: kvmclock: Expose implied TSC frequency via sysctl.
Nov 15 2021, 5:59 PM

Nov 4 2021

bryanv added a comment to D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

Left a few comments. It has been a long while since I've dealt with vxlan - and FreeBSD network stack in general - so somebody more familiar should give a correctness review.

Nov 4 2021, 3:33 PM · network

Oct 8 2021

bryanv accepted D32370: virtio: make the write_config buffer argument const.
Oct 8 2021, 6:49 PM

Aug 9 2021

bryanv added a comment to D31424: Only use byte register access in legacy virtio pci.

LGTM

Aug 9 2021, 2:57 PM

Aug 6 2021

bryanv accepted D31424: Only use byte register access in legacy virtio pci.
Aug 6 2021, 5:49 PM

May 4 2021

bryanv accepted D28947: [POWERPC] Switch endian of common dev information.
May 4 2021, 2:54 PM · PowerPC

Apr 6 2021

bryanv added inline comments to D29531: Add kvmclock timecounter support to FreeBSD.
Apr 6 2021, 9:31 PM

Mar 28 2021

bryanv accepted D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.
Mar 28 2021, 2:48 AM · PowerPC

Mar 21 2021

bryanv added inline comments to D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.
Mar 21 2021, 10:56 PM · PowerPC

Mar 8 2021

bryanv requested changes to D28947: [POWERPC] Switch endian of common dev information.
Mar 8 2021, 10:38 PM · PowerPC

Feb 23 2021

bryanv accepted D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Feb 23 2021, 1:55 PM
bryanv added inline comments to D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Feb 23 2021, 5:04 AM
bryanv requested changes to D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Feb 23 2021, 5:04 AM
bryanv abandoned D27918: if_vtnet: Use separate variable to keep track of returned negotiated features.
Feb 23 2021, 4:17 AM
bryanv abandoned D27927: if_vtnet: Moderneize default tunables.
Feb 23 2021, 4:16 AM
bryanv accepted D28818: virtio_pci_legacy: Allow memory space for configuration.
Feb 23 2021, 3:59 AM

Feb 1 2021

bryanv added a comment to D26915: virtio_pci: Allow memory space for configuration.

I'll try to get this ported and committed to the legacy PCI driver before 13.0

Feb 1 2021, 4:33 PM

Jan 21 2021

bryanv added inline comments to D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 21 2021, 3:02 AM
bryanv added inline comments to D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 21 2021, 2:05 AM
bryanv added a comment to D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.

I'd like to keep the current distinction - virito_pci and virtio_mmio - so it is clear as to what is being attached. After https://reviews.freebsd.org/D28073 there is much less boilerplate, and not likely another transport is forthcoming.

Jan 21 2021, 1:44 AM
bryanv added inline comments to D27857: Add VirtIO modern support to virtqueue.
Jan 21 2021, 1:41 AM

Jan 20 2021

bryanv abandoned D27914: if_vtnet: move IFFLAGS ioctl handler to separate function.

Committed in dc9029d863dcc48efebb6a31a25553a7459132aa

Jan 20 2021, 10:56 PM
bryanv abandoned D27915: if_vtnet: Move remaining ioctl handlers to separate functions.

Folded into https://reviews.freebsd.org/D27915

Jan 20 2021, 10:55 PM
bryanv abandoned D27924: if_vtnet: Improve support for software LRO.

Folded into https://reviews.freebsd.org/D27919

Jan 20 2021, 10:54 PM
bryanv abandoned D27929: virtio: Add drivers as children of modern PCI.
Jan 20 2021, 10:53 PM

Jan 19 2021

bryanv accepted D28073: virtio: Reduce boilerplate for device driver module definitions.
Jan 19 2021, 5:30 AM
bryanv accepted D28058: Build VirtIO modules on all architectures.
Jan 19 2021, 5:27 AM
bryanv accepted D28070: virtio_mmio: Fix V1 device probing spec conformance (section 4.2.3.1.1).
Jan 19 2021, 5:25 AM
bryanv committed rGe6cc42f181ce: virtio: Handle possible failure of virtio_finalize_features() (authored by bryanv).
virtio: Handle possible failure of virtio_finalize_features()
Jan 19 2021, 5:13 AM
bryanv committed rG2bfab3577452: if_vtnet: Add counter for received host LRO (authored by bryanv).
if_vtnet: Add counter for received host LRO
Jan 19 2021, 5:13 AM
bryanv committed rG6b53aeed9162: if_vtnet: Set lro_nsegs for host LRO packets (authored by bryanv).
if_vtnet: Set lro_nsegs for host LRO packets
Jan 19 2021, 5:13 AM
bryanv committed rG475a60aec7e3: if_vtnet: Misc Tx path cleanup (authored by bryanv).
if_vtnet: Misc Tx path cleanup
Jan 19 2021, 5:13 AM
bryanv committed rG74cd316a09e8: if_vtnet: Resort softc fields (authored by bryanv).
if_vtnet: Resort softc fields
Jan 19 2021, 5:13 AM
bryanv committed rG33b5433fd74c: if_vtnet: Remove unnecessary TUNABLE_INTs because of CTLFLAG_RDTUN (authored by bryanv).
if_vtnet: Remove unnecessary TUNABLE_INTs because of CTLFLAG_RDTUN
Jan 19 2021, 5:13 AM
bryanv committed rG4f18e23f8432: if_vtnet: Schedule Rx task if pending items when enabling interrupt (authored by bryanv).
if_vtnet: Schedule Rx task if pending items when enabling interrupt
Jan 19 2021, 5:13 AM
bryanv closed D27930: virtio: Handle possible failure of virtio_finalize_features().
Jan 19 2021, 5:13 AM
bryanv committed rGc3187190c71f: if_vtnet: Disable F_MTU feature if MTU is invalid (authored by bryanv).
if_vtnet: Disable F_MTU feature if MTU is invalid
Jan 19 2021, 5:13 AM
bryanv closed D27928: if_vtnet: Add counter for recevied host segmentation offloaded.
Jan 19 2021, 5:13 AM
bryanv closed D27926: if_vtnet: Cleanup bits of the Tx path.
Jan 19 2021, 5:12 AM
bryanv closed D27933: if_vtnet: Set lro_nsegs for host LRO packets.
Jan 19 2021, 5:12 AM
bryanv committed rGbd8809df20be: if_vtnet: Limit allocations of unused virtqueues (authored by bryanv).
if_vtnet: Limit allocations of unused virtqueues
Jan 19 2021, 5:12 AM
bryanv committed rGb470419ea52a: if_vtnet: Rework 4be723f63 max multiqueue pairs check (authored by bryanv).
if_vtnet: Rework 4be723f63 max multiqueue pairs check
Jan 19 2021, 5:12 AM
bryanv committed rG42343a631683: if_vtnet: Add support for software LRO (authored by bryanv).
if_vtnet: Add support for software LRO
Jan 19 2021, 5:12 AM
bryanv closed D27925: if_vtnet: Resort softc fields.
Jan 19 2021, 5:12 AM
bryanv closed D27923: if_vtnet: Clean up the tunables definitions.
Jan 19 2021, 5:12 AM
bryanv committed rG177761e4c467: if_vtnet: Set the interface max TSO values (authored by bryanv).
if_vtnet: Set the interface max TSO values
Jan 19 2021, 5:12 AM
bryanv closed D27922: if_vtnet: Schedule Rx task if pending items when enabling interrupt.
Jan 19 2021, 5:12 AM
bryanv committed rGe36a6b1b1f39: if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature (authored by bryanv).
if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature
Jan 19 2021, 5:12 AM
bryanv committed rGdc9029d863dc: if_vtnet: Move ioctl handlers into separate functions (authored by bryanv).
if_vtnet: Move ioctl handlers into separate functions
Jan 19 2021, 5:12 AM
bryanv closed D27931: if_vtnet: Disable F_MTU feature if MTU is invalid.
Jan 19 2021, 5:12 AM
bryanv committed rG44559b26af14: if_vtnet: Cleanup the reinit process (authored by bryanv).
if_vtnet: Cleanup the reinit process
Jan 19 2021, 5:12 AM
bryanv closed D27921: if_vtnet: Limit allocations of unused virtqueues.
Jan 19 2021, 5:12 AM
bryanv closed D27920: if_vtnet: Rework 4be723f63 max multiqueue pairs check.
Jan 19 2021, 5:12 AM
bryanv committed rG2520cd382151: if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported (authored by bryanv).
if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported
Jan 19 2021, 5:12 AM
bryanv committed rG32e0493c9245: if_vtnet: Cleanup the interface setup methods (authored by bryanv).
if_vtnet: Cleanup the interface setup methods
Jan 19 2021, 5:12 AM
bryanv closed D27919: if_vtnet: Initial support for software LRO.
Jan 19 2021, 5:12 AM
bryanv committed rGbaa5234fbec6: if_vtnet: Move the Tx interrupt threshold into the Txq structure (authored by bryanv).
if_vtnet: Move the Tx interrupt threshold into the Txq structure
Jan 19 2021, 5:12 AM
bryanv closed D27917: if_vtnet: Set the interface max TSO values.
Jan 19 2021, 5:12 AM
bryanv closed D27916: if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature.
Jan 19 2021, 5:12 AM
bryanv committed rG25dbc30ef5c9: if_vtnet: Remove at attach PROMISC handling (authored by bryanv).
if_vtnet: Remove at attach PROMISC handling
Jan 19 2021, 5:12 AM
bryanv committed rG05041794d06f: if_vtnet: Defer updating generated MAC address until attached (authored by bryanv).
if_vtnet: Defer updating generated MAC address until attached
Jan 19 2021, 5:12 AM
bryanv committed rG6a73339365cf: if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX (authored by bryanv).
if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX
Jan 19 2021, 5:11 AM
bryanv closed D27932: if_vtnet: Cleanup the reinit process.
Jan 19 2021, 5:11 AM
bryanv committed rGaabdf5b6e8e8: if_vtnet: Support VIRTIO_NET_F_MTU (authored by bryanv).
if_vtnet: Support VIRTIO_NET_F_MTU
Jan 19 2021, 5:11 AM
bryanv closed D27913: if_vtnet: cleanup the interface setup methods.
Jan 19 2021, 5:11 AM
bryanv closed D27912: if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported.
Jan 19 2021, 5:11 AM
bryanv committed rGfa7ca1e33241: if_vtnet: Rx path cleanup (authored by bryanv).
if_vtnet: Rx path cleanup
Jan 19 2021, 5:11 AM
bryanv committed rG149ab110dd5c: virtio_blk: Use DISKFLAG_WRITE_PROTECT for RO disks (authored by bryanv).
virtio_blk: Use DISKFLAG_WRITE_PROTECT for RO disks
Jan 19 2021, 5:11 AM
bryanv closed D27911: if_vntet: Move the Tx interrupt threshold into the Txq structure.
Jan 19 2021, 5:11 AM
bryanv committed rG5e2208117787: if_vtnet: Add initial modern (V1) support (authored by bryanv).
if_vtnet: Add initial modern (V1) support
Jan 19 2021, 5:11 AM
bryanv closed D27910: if_vtnet: Defer updating generated MAC address until attached.
Jan 19 2021, 5:11 AM
bryanv closed D27909: if_vtnet: Remove attach PROMISC handling.
Jan 19 2021, 5:11 AM
bryanv committed rG15be49535dce: virtio_scsi: Add modern (V1) support (authored by bryanv).
virtio_scsi: Add modern (V1) support
Jan 19 2021, 5:11 AM
bryanv closed D27908: if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX.
Jan 19 2021, 5:11 AM
bryanv committed rGd7f979bed092: virtio_blk: Add modern (V1) support (authored by bryanv).
virtio_blk: Add modern (V1) support
Jan 19 2021, 5:11 AM
bryanv closed D27907: if_vtnet: Support VIRTIO_NET_F_MTU.
Jan 19 2021, 5:11 AM
bryanv closed D27906: if_vtnet: improve and cleanup the receive code.
Jan 19 2021, 5:11 AM
bryanv closed D27905: virtio_blk: Use DISKFLAG_WRITE_PROTECT for RO disks.
Jan 19 2021, 5:11 AM
bryanv closed D27904: if_vtnet: Add initial modern (V1) support.
Jan 19 2021, 5:11 AM
bryanv closed D27903: virtio_scsi: Add modern (V1) support.
Jan 19 2021, 5:11 AM
bryanv closed D27902: virtio_blk: Add modern (V1) support.
Jan 19 2021, 5:11 AM
bryanv closed D27901: virtio_console: Add modern (V1) support.
Jan 19 2021, 5:10 AM
bryanv committed rGedf7c8ddceca: virtio_console: Add modern (V1) support (authored by bryanv).
virtio_console: Add modern (V1) support
Jan 19 2021, 5:10 AM
bryanv closed D27900: virtio_balloon: Add modern (V1) support.
Jan 19 2021, 5:10 AM
bryanv committed rGf7f9c266e439: virtio_balloon: Add modern (V1) support (authored by bryanv).
virtio_balloon: Add modern (V1) support
Jan 19 2021, 5:10 AM
bryanv closed D27899: virtio_random: Add modern (V1) support.
Jan 19 2021, 5:10 AM
bryanv committed rGd2536a25cc1d: virtio_random: Add modern (V1) support (authored by bryanv).
virtio_random: Add modern (V1) support
Jan 19 2021, 5:10 AM
bryanv closed D27898: virtio_pci: Add sysctl to show current features.
Jan 19 2021, 5:09 AM
bryanv committed rG703f17d60f7f: virtio_pci: Add sysctl to show current features (authored by bryanv).
virtio_pci: Add sysctl to show current features
Jan 19 2021, 5:09 AM
bryanv closed D27857: Add VirtIO modern support to virtqueue.
Jan 19 2021, 5:09 AM
bryanv committed rGfbe0c4f4c7f4: virtio: Add modern (v1) virtqueue support (authored by bryanv).
virtio: Add modern (v1) virtqueue support
Jan 19 2021, 5:09 AM
bryanv closed D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 19 2021, 5:09 AM
bryanv committed rG9da9560c4dd3: virtio: Add VirtIO PCI modern (V1) support (authored by bryanv).
virtio: Add VirtIO PCI modern (V1) support
Jan 19 2021, 5:09 AM
bryanv closed D27855: Summary: Revert prior VirtIO "V1" network support to simplify upcoming V1 changes.
Jan 19 2021, 5:08 AM