Page MenuHomeFreeBSD

bryanv (Bryan Venteicher)
User

Projects

User Details

User Since
May 10 2014, 3:30 AM (519 w, 3 d)

Recent Activity

Feb 25 2024

bryanv added a comment to D43047: vtscmi: Add a virtio-scmi driver.

Thanks for the review @bryanv.
Regarding:

"A virtqueue_poll() variant with a timeout param could be useful in general."

I was thinking exactly the same while doing this, but being a first time contributor to freeBSD, I was not sure how easily acceptable would have been to post a change related to some core system (like virtio) inside this series,
so I went for a custom solution at first. I can certainly post subsequently a patch to add a virtqueue_poll timeout variant to the virtio-core and make use of it in here, once this is merged/landed.

Feb 25 2024, 6:56 PM

Jan 31 2024

bryanv committed rGe6b8c1d780b4: virtio: Add more device IDs from the specification (authored by bryanv).
virtio: Add more device IDs from the specification
Jan 31 2024, 5:12 AM
bryanv accepted D43047: vtscmi: Add a virtio-scmi driver.

Just a few minor comments. Note though that I only have time to do a brief review of this and haven't read the relevant section of the spec.

Jan 31 2024, 4:13 AM
bryanv accepted D43048: scmi: Add an SCMI VirtIO transport driver.

Just as a general comment - some of the device_printf() look potentially spammy and may be better as either guarded by bootverbose or debug macros.

Jan 31 2024, 4:13 AM
bryanv accepted D43654: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT.
Jan 31 2024, 3:39 AM

Jan 23 2024

bryanv accepted D43224: vtnet: Adjust for ethernet alignment..
Jan 23 2024, 4:52 AM

Sep 26 2023

bryanv added a comment to D41852: virtio: add man page for virtqueue(9) functions.

I'm very hesitant to consider these - or other virtio methods from other pending reviews - as man "Section 9 - Kernel Interfaces". The header files are not installed and I really don't think should be, and would require clean up before being suitable. Typically these kind methods are not documented in man pages; I think the only existing analogous man(9) would be usbdi(9) and despite the numerous MLINKs only documents a handful of methods around data transfer, that I presume are most relevant for peripheral drivers, and goes into great detail of how those 5 methods are used and related with each other. I think these proposed man pages require a lot more fleshing out before providing the level of detail to code against the "interface".

Sep 26 2023, 6:08 AM

Sep 15 2023

bryanv added a comment to D41849: virtio: add comment on the spec for vring struct.

My intention has been to keep these header files closer aligned with the BSD licensed headers from Linux, which still uses the "vring" prefix. I don't think this change really clarifies much, especially when there are numerous other naming differences between the spec and those upstream header files.

Sep 15 2023, 4:04 AM
bryanv accepted D41850: virtio: remove virtio_alloc_virtqueues' flags arg.
Sep 15 2023, 3:46 AM
bryanv accepted D41848: virtio: use bool for boolean functions.
Sep 15 2023, 3:45 AM

Jul 27 2023

bryanv added a comment to D41212: vtnet: Ensure that L3 protocol headers are aligned when necessary.

On a very, very quick first glance I've got concerns that this is incomplete, or could break alignment in other cases (but I have been away from this code for awhile). Depending on the features negotiated - V1, legacy with or without mergeable buffers - the header size can vary, along with what we enqueue for the Rx header desc. What features are negotiated on your QEMU testbed? We might be able to get a similar outcome by adjusting VTNET_RX_HEADER_PAD.

Jul 27 2023, 4:46 PM

May 26 2023

bryanv accepted D40094: Add a virtio-gpu 2D driver.

Thanks so much for this work! 1-2 years back I think there was an effort to port the full Linux DRM virito_gpu driver over, but I believe that work has stalled. This is great to have.

May 26 2023, 3:19 AM

Jan 11 2023

bryanv accepted D37799: Mechanically convert if_vtnet(4) to DrvAPI.
Jan 11 2023, 5:22 AM

Oct 10 2022

bryanv accepted D36667: vtblk: Use busdma.
Oct 10 2022, 6:33 PM

Oct 5 2022

bryanv added inline comments to D36855: if_vxlan(4): Correct the statistic for output bytes.
Oct 5 2022, 5:04 AM · network

Oct 4 2022

bryanv accepted D36841: if_vxlan(4): Add missing statistic for input packets.
Oct 4 2022, 7:44 PM · network

Oct 3 2022

bryanv accepted D36666: vtblk: Include pointer to softc in request.
Oct 3 2022, 3:32 AM
bryanv accepted D36667: vtblk: Use busdma.
Oct 3 2022, 3:31 AM
bryanv accepted D36665: vtblk: Requeue inside vtblk_request_execute.
Oct 3 2022, 3:19 AM
bryanv accepted D36664: vtblk: Make vtblk_request_execute return void..
Oct 3 2022, 2:15 AM

Aug 17 2022

bryanv committed rG926cedd9a071: virtio_mmio: Improve V1 spec conformance (authored by bryanv).
virtio_mmio: Improve V1 spec conformance
Aug 17 2022, 8:16 PM
bryanv closed D36150: virtio_mmio: Improve V1 spec conformance.
Aug 17 2022, 8:16 PM

Aug 12 2022

bryanv updated the diff for D36150: virtio_mmio: Improve V1 spec conformance.

Address comment

Aug 12 2022, 4:39 PM
bryanv added inline comments to D36150: virtio_mmio: Improve V1 spec conformance.
Aug 12 2022, 4:39 PM
bryanv requested review of D36150: virtio_mmio: Improve V1 spec conformance.
Aug 12 2022, 3:20 AM

Aug 4 2022

bryanv committed rGdc6f578a8f53: virtio_mmio: correct offset of VIRTIO_MMIO_CONFIG_GENERATION (authored by bryanv).
virtio_mmio: correct offset of VIRTIO_MMIO_CONFIG_GENERATION
Aug 4 2022, 4:04 AM

Nov 15 2021

bryanv accepted D32974: kvmclock: Expose implied TSC frequency via sysctl.
Nov 15 2021, 5:59 PM

Nov 4 2021

bryanv added a comment to D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

Left a few comments. It has been a long while since I've dealt with vxlan - and FreeBSD network stack in general - so somebody more familiar should give a correctness review.

Nov 4 2021, 3:33 PM · network

Oct 8 2021

bryanv accepted D32370: virtio: make the write_config buffer argument const.
Oct 8 2021, 6:49 PM

Aug 9 2021

bryanv added a comment to D31424: Only use byte register access in legacy virtio pci.

LGTM

Aug 9 2021, 2:57 PM

Aug 6 2021

bryanv accepted D31424: Only use byte register access in legacy virtio pci.
Aug 6 2021, 5:49 PM

May 4 2021

bryanv accepted D28947: [POWERPC] Switch endian of common dev information.
May 4 2021, 2:54 PM · PowerPC

Apr 6 2021

bryanv added inline comments to D29531: Add kvmclock timecounter support to FreeBSD.
Apr 6 2021, 9:31 PM

Mar 28 2021

bryanv accepted D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.
Mar 28 2021, 2:48 AM · PowerPC

Mar 21 2021

bryanv added inline comments to D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.
Mar 21 2021, 10:56 PM · PowerPC

Mar 8 2021

bryanv requested changes to D28947: [POWERPC] Switch endian of common dev information.
Mar 8 2021, 10:38 PM · PowerPC

Feb 23 2021

bryanv accepted D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Feb 23 2021, 1:55 PM
bryanv added inline comments to D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Feb 23 2021, 5:04 AM
bryanv requested changes to D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Feb 23 2021, 5:04 AM
bryanv abandoned D27918: if_vtnet: Use separate variable to keep track of returned negotiated features.
Feb 23 2021, 4:17 AM
bryanv abandoned D27927: if_vtnet: Moderneize default tunables.
Feb 23 2021, 4:16 AM
bryanv accepted D28818: virtio_pci_legacy: Allow memory space for configuration.
Feb 23 2021, 3:59 AM

Feb 1 2021

bryanv added a comment to D26915: virtio_pci: Allow memory space for configuration.

I'll try to get this ported and committed to the legacy PCI driver before 13.0

Feb 1 2021, 4:33 PM

Jan 21 2021

bryanv added inline comments to D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 21 2021, 3:02 AM
bryanv added inline comments to D27856: virtio: Add VirtIO PCI modern (V1) support.
Jan 21 2021, 2:05 AM
bryanv added a comment to D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.

I'd like to keep the current distinction - virito_pci and virtio_mmio - so it is clear as to what is being attached. After https://reviews.freebsd.org/D28073 there is much less boilerplate, and not likely another transport is forthcoming.

Jan 21 2021, 1:44 AM
bryanv added inline comments to D27857: Add VirtIO modern support to virtqueue.
Jan 21 2021, 1:41 AM

Jan 20 2021

bryanv abandoned D27914: if_vtnet: move IFFLAGS ioctl handler to separate function.

Committed in dc9029d863dcc48efebb6a31a25553a7459132aa

Jan 20 2021, 10:56 PM
bryanv abandoned D27915: if_vtnet: Move remaining ioctl handlers to separate functions.

Folded into https://reviews.freebsd.org/D27915

Jan 20 2021, 10:55 PM
bryanv abandoned D27924: if_vtnet: Improve support for software LRO.

Folded into https://reviews.freebsd.org/D27919

Jan 20 2021, 10:54 PM
bryanv abandoned D27929: virtio: Add drivers as children of modern PCI.
Jan 20 2021, 10:53 PM

Jan 19 2021

bryanv accepted D28073: virtio: Reduce boilerplate for device driver module definitions.
Jan 19 2021, 5:30 AM
bryanv accepted D28058: Build VirtIO modules on all architectures.
Jan 19 2021, 5:27 AM
bryanv accepted D28070: virtio_mmio: Fix V1 device probing spec conformance (section 4.2.3.1.1).
Jan 19 2021, 5:25 AM
bryanv committed rGe6cc42f181ce: virtio: Handle possible failure of virtio_finalize_features() (authored by bryanv).
virtio: Handle possible failure of virtio_finalize_features()
Jan 19 2021, 5:13 AM
bryanv committed rG2bfab3577452: if_vtnet: Add counter for received host LRO (authored by bryanv).
if_vtnet: Add counter for received host LRO
Jan 19 2021, 5:13 AM
bryanv committed rG6b53aeed9162: if_vtnet: Set lro_nsegs for host LRO packets (authored by bryanv).
if_vtnet: Set lro_nsegs for host LRO packets
Jan 19 2021, 5:13 AM
bryanv committed rG475a60aec7e3: if_vtnet: Misc Tx path cleanup (authored by bryanv).
if_vtnet: Misc Tx path cleanup
Jan 19 2021, 5:13 AM
bryanv committed rG74cd316a09e8: if_vtnet: Resort softc fields (authored by bryanv).
if_vtnet: Resort softc fields
Jan 19 2021, 5:13 AM
bryanv committed rG33b5433fd74c: if_vtnet: Remove unnecessary TUNABLE_INTs because of CTLFLAG_RDTUN (authored by bryanv).
if_vtnet: Remove unnecessary TUNABLE_INTs because of CTLFLAG_RDTUN
Jan 19 2021, 5:13 AM
bryanv committed rG4f18e23f8432: if_vtnet: Schedule Rx task if pending items when enabling interrupt (authored by bryanv).
if_vtnet: Schedule Rx task if pending items when enabling interrupt
Jan 19 2021, 5:13 AM
bryanv closed D27930: virtio: Handle possible failure of virtio_finalize_features().
Jan 19 2021, 5:13 AM
bryanv committed rGc3187190c71f: if_vtnet: Disable F_MTU feature if MTU is invalid (authored by bryanv).
if_vtnet: Disable F_MTU feature if MTU is invalid
Jan 19 2021, 5:13 AM
bryanv closed D27928: if_vtnet: Add counter for recevied host segmentation offloaded.
Jan 19 2021, 5:13 AM
bryanv closed D27926: if_vtnet: Cleanup bits of the Tx path.
Jan 19 2021, 5:12 AM
bryanv closed D27933: if_vtnet: Set lro_nsegs for host LRO packets.
Jan 19 2021, 5:12 AM
bryanv committed rGbd8809df20be: if_vtnet: Limit allocations of unused virtqueues (authored by bryanv).
if_vtnet: Limit allocations of unused virtqueues
Jan 19 2021, 5:12 AM
bryanv committed rGb470419ea52a: if_vtnet: Rework 4be723f63 max multiqueue pairs check (authored by bryanv).
if_vtnet: Rework 4be723f63 max multiqueue pairs check
Jan 19 2021, 5:12 AM
bryanv committed rG42343a631683: if_vtnet: Add support for software LRO (authored by bryanv).
if_vtnet: Add support for software LRO
Jan 19 2021, 5:12 AM
bryanv closed D27925: if_vtnet: Resort softc fields.
Jan 19 2021, 5:12 AM
bryanv closed D27923: if_vtnet: Clean up the tunables definitions.
Jan 19 2021, 5:12 AM
bryanv committed rG177761e4c467: if_vtnet: Set the interface max TSO values (authored by bryanv).
if_vtnet: Set the interface max TSO values
Jan 19 2021, 5:12 AM
bryanv closed D27922: if_vtnet: Schedule Rx task if pending items when enabling interrupt.
Jan 19 2021, 5:12 AM
bryanv committed rGe36a6b1b1f39: if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature (authored by bryanv).
if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature
Jan 19 2021, 5:12 AM
bryanv committed rGdc9029d863dc: if_vtnet: Move ioctl handlers into separate functions (authored by bryanv).
if_vtnet: Move ioctl handlers into separate functions
Jan 19 2021, 5:12 AM
bryanv closed D27931: if_vtnet: Disable F_MTU feature if MTU is invalid.
Jan 19 2021, 5:12 AM
bryanv committed rG44559b26af14: if_vtnet: Cleanup the reinit process (authored by bryanv).
if_vtnet: Cleanup the reinit process
Jan 19 2021, 5:12 AM
bryanv closed D27921: if_vtnet: Limit allocations of unused virtqueues.
Jan 19 2021, 5:12 AM
bryanv closed D27920: if_vtnet: Rework 4be723f63 max multiqueue pairs check.
Jan 19 2021, 5:12 AM
bryanv committed rG2520cd382151: if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported (authored by bryanv).
if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported
Jan 19 2021, 5:12 AM
bryanv committed rG32e0493c9245: if_vtnet: Cleanup the interface setup methods (authored by bryanv).
if_vtnet: Cleanup the interface setup methods
Jan 19 2021, 5:12 AM
bryanv closed D27919: if_vtnet: Initial support for software LRO.
Jan 19 2021, 5:12 AM
bryanv committed rGbaa5234fbec6: if_vtnet: Move the Tx interrupt threshold into the Txq structure (authored by bryanv).
if_vtnet: Move the Tx interrupt threshold into the Txq structure
Jan 19 2021, 5:12 AM
bryanv closed D27917: if_vtnet: Set the interface max TSO values.
Jan 19 2021, 5:12 AM
bryanv closed D27916: if_vtnet: Add support for CTRL_GUEST_OFFLOADS feature.
Jan 19 2021, 5:12 AM
bryanv committed rG25dbc30ef5c9: if_vtnet: Remove at attach PROMISC handling (authored by bryanv).
if_vtnet: Remove at attach PROMISC handling
Jan 19 2021, 5:12 AM
bryanv committed rG05041794d06f: if_vtnet: Defer updating generated MAC address until attached (authored by bryanv).
if_vtnet: Defer updating generated MAC address until attached
Jan 19 2021, 5:12 AM
bryanv committed rG6a73339365cf: if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX (authored by bryanv).
if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX
Jan 19 2021, 5:11 AM
bryanv closed D27932: if_vtnet: Cleanup the reinit process.
Jan 19 2021, 5:11 AM
bryanv committed rGaabdf5b6e8e8: if_vtnet: Support VIRTIO_NET_F_MTU (authored by bryanv).
if_vtnet: Support VIRTIO_NET_F_MTU
Jan 19 2021, 5:11 AM
bryanv closed D27913: if_vtnet: cleanup the interface setup methods.
Jan 19 2021, 5:11 AM
bryanv closed D27912: if_vtnet: Only set IFCAP_JUMBO_MTU when jumbo MTU is supported.
Jan 19 2021, 5:11 AM
bryanv committed rGfa7ca1e33241: if_vtnet: Rx path cleanup (authored by bryanv).
if_vtnet: Rx path cleanup
Jan 19 2021, 5:11 AM
bryanv committed rG149ab110dd5c: virtio_blk: Use DISKFLAG_WRITE_PROTECT for RO disks (authored by bryanv).
virtio_blk: Use DISKFLAG_WRITE_PROTECT for RO disks
Jan 19 2021, 5:11 AM
bryanv closed D27911: if_vntet: Move the Tx interrupt threshold into the Txq structure.
Jan 19 2021, 5:11 AM
bryanv committed rG5e2208117787: if_vtnet: Add initial modern (V1) support (authored by bryanv).
if_vtnet: Add initial modern (V1) support
Jan 19 2021, 5:11 AM
bryanv closed D27910: if_vtnet: Defer updating generated MAC address until attached.
Jan 19 2021, 5:11 AM
bryanv closed D27909: if_vtnet: Remove attach PROMISC handling.
Jan 19 2021, 5:11 AM
bryanv committed rG15be49535dce: virtio_scsi: Add modern (V1) support (authored by bryanv).
virtio_scsi: Add modern (V1) support
Jan 19 2021, 5:11 AM
bryanv closed D27908: if_vtnet: Support VIRTIO_NET_F_SPEED_DUPLEX.
Jan 19 2021, 5:11 AM