Differential D28073

virtio: Reduce boilerplate for device driver module definitions
ClosedPublic
Actions

Authored by jrtc27 on Jan 9 2021, 10:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 31, 10:47 AM

	Unknown Object (File)
	Fri, Mar 27, 7:23 AM

	Unknown Object (File)
	Thu, Mar 26, 5:16 PM

	Unknown Object (File)
	Sun, Mar 22, 6:12 PM

	Unknown Object (File)
	Fri, Mar 20, 9:01 AM

	Unknown Object (File)
	Fri, Mar 20, 3:28 AM

	Unknown Object (File)
	Fri, Mar 13, 6:00 AM

	Unknown Object (File)
	Fri, Mar 13, 6:00 AM

Subscribers

Details

Reviewers

Commits

rG633218ee4615: virtio: Reduce boilerplate for device driver module definitions

Summary

Rather than have every device register itself for both virtio_pci and
virtio_mmio, provide a VIRTIO_DRIVER_MODULE wrapper to declare both,
merge VIRTIO_SIMPLE_PNPTABLE with VIRTIO_SIMPLE_PNPINFO and make the
latter register for both buses. This also has the benefit of abstracting
away the available transports and their names.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Jan 9 2021, 10:05 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 9 2021, 10:05 PM

jrtc27 requested review of this revision.Jan 9 2021, 10:05 PM

Harbormaster completed remote builds in B36070: Diff 81977.Jan 9 2021, 10:05 PM

jrtc27 mentioned this in D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.Jan 9 2021, 10:13 PM

jrtc27 added a child revision: D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.Jan 9 2021, 10:13 PM

jrtc27 mentioned this in D27856: virtio: Add VirtIO PCI modern (V1) support.Jan 12 2021, 7:12 AM

bryanv accepted this revision.Jan 19 2021, 5:30 AM

This revision is now accepted and ready to land.Jan 19 2021, 5:30 AM

Closed by commit rG633218ee4615: virtio: Reduce boilerplate for device driver module definitions (authored by jrtc27). · Explain WhyJan 21 2021, 1:15 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG633218ee4615: virtio: Reduce boilerplate for device driver module definitions.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

balloon/

virtio_balloon.c

8 lines

block/

8 lines

console/

virtio_console.c

8 lines

network/

8 lines

random/

virtio_random.c

8 lines

scsi/

8 lines

13 lines

Diff 82667

sys/dev/virtio/balloon/virtio_balloon.c

Loading...

sys/dev/virtio/block/virtio_blk.c

Loading...

sys/dev/virtio/console/virtio_console.c

Loading...

sys/dev/virtio/network/if_vtnet.c

Loading...

sys/dev/virtio/random/virtio_random.c

Loading...

sys/dev/virtio/scsi/virtio_scsi.c

Loading...

sys/dev/virtio/virtio.h

Loading...